Gunnar Beutner
63a1ff77c3
Implement the resolve_arguments function
...
fixes #10006
2015-08-27 09:02:21 +02:00
Gunnar Beutner
6ef9d3c4db
Missing macros in nested macro() calls should not cause the outer macro resolution to fail
...
fixes #10003
2015-08-27 09:02:21 +02:00
Jean Flach
01ced1549a
Implement all actions except modified attributes
...
refs #9080 #9979
2015-08-26 13:53:17 +02:00
Gunnar Beutner
f45f6ccd82
Implement support for tracking dependencies between config objects
...
refs #9096
2015-08-25 13:54:05 +02:00
Michael Friedrich
981ed591e9
API: Return comment/downtime ids, refactor code
...
refs #9080
2015-08-21 12:49:51 +02:00
Jean Flach
c5fe46a300
Experimental actions without types
...
refs #9080
2015-08-21 12:48:32 +02:00
Jean Flach
afd6af39d5
Implement external commands as api actions
...
refs #9080
2015-08-21 12:48:32 +02:00
Gunnar Beutner
d118b71a2a
Fix compiler warnings
...
fixes #9929
2015-08-18 07:46:04 +02:00
Gunnar Beutner
7fc7cde6a1
Build fix for Windows
2015-08-17 19:36:27 +02:00
Michael Friedrich
0f5287c2b1
Add module attribute for ConfigObject and set its origin
...
fixes #9852
2015-08-17 16:08:57 +02:00
Gunnar Beutner
071d2f18fb
Rename DynamicObject/DynamicType to ConfigObject/ConfigType
...
fixes #9914
2015-08-15 20:40:41 +02:00
Gunnar Beutner
ce2735f10b
Fix validation errors when creating objects with the API
...
refs #9101
2015-08-15 20:07:11 +02:00
Gunnar Beutner
e2290d5012
Implement support for unregistering objects
...
refs #9101
2015-08-15 20:07:11 +02:00
Gunnar Beutner
3d78870339
Implement support for modified attributes in the API
...
refs #9081
2015-08-15 20:07:11 +02:00
Gunnar Beutner
a092c13ace
Implement support for persisting modified attributes
...
fixes #9093
2015-08-15 20:07:10 +02:00
Michael Friedrich
d7970f5bb1
Implement modified attributes v2
...
refs #9081
refs #9093
2015-08-15 20:07:10 +02:00
Jean Flach
60f86d01fe
Implement /v1/actions/process-check-result
...
Requires error handling.
refs #9080
2015-07-31 17:18:49 +02:00
Michael Friedrich
0712a02d1b
Add a warning if EventCommand is not found when using command_endpoint
...
fixes #9773
2015-07-31 16:04:03 +02:00
Michael Friedrich
766e2d73f4
Implement external command DEL_DOWNTIME_BY_HOST_NAME
...
Required by Classic UI 1.x, this will hopefully reduce
the noise on non-working commands with the old legacy stuff.
fixes #8979
2015-07-31 14:50:17 +02:00
Jean-Marcel Flach
9b6ebbc69b
Implement basic actions framework
...
refs #9080
2015-07-30 17:50:17 +02:00
Gunnar Beutner
a97782b3e5
Implement support for limiting output attributes
...
refs #9077
fixes #9614
2015-07-28 17:12:51 +02:00
Gunnar Beutner
8dedd47b89
Fix incorrect return value for the macro() function
...
fixes #9584
2015-07-13 08:25:19 +02:00
Michael Friedrich
184f316538
Fix wrong vars changed handler in api events
...
fixes #9547
2015-07-02 14:51:47 +02:00
Michael Friedrich
8596e2b3dc
Add log message for discarded cluster events (e.g. from unauthenticated clients)
...
fixes #9489
2015-07-02 13:04:38 +02:00
Gunnar Beutner
9238c5af11
Fix incorrect validator for command arguments
...
fixes #9436
2015-06-18 08:13:40 +02:00
Michael Friedrich
bd16651f79
Build fix
...
refs #9324
2015-06-15 17:24:55 +02:00
Markus Frosch
47c8b5e347
Fix multi line handling for compat check results
...
When a multi line result is submitted via the command pipe, any multi line
output is escaped to a actual string '\n', because any external command only
can be a single line.
Example:
[1432735140] PROCESS_SERVICE_CHECK_RESULT;host;service;3;Test1\nTest2|test=1
We need to unescape this values, just like we use to escape multi line output
for IDO and status.dat.
fixes #9324
Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-06-15 17:19:28 +02:00
Michael Friedrich
baa8fb424f
Fix missing custom attributes in backends if name is equal to object attribute
...
fixes #9222
2015-05-15 15:59:44 +02:00
Michael Friedrich
e37cd25ed4
Fix failed assertion in DB IDO
...
fixes #9121
2015-04-27 11:00:41 +02:00
Michael Friedrich
7af41e93c0
Fix that downtimes are always "fixed" even if scheduled as "flexible"
...
fixes #9142
2015-04-25 15:06:29 +02:00
Michael Friedrich
83f4ebc0df
Fix compiler warnings w/ config validators
...
fixes #9015
2015-04-20 14:16:19 +02:00
Michael Friedrich
53e6b1a6dd
Fix custom attributes with recursive macro function calls
...
fixes #9073
2015-04-17 17:23:08 +02:00
Michael Friedrich
d3a56b6404
Fix acknowledgement with expire time not added as comment expire_time
...
GetExpireTime() is always set to 0 which will make the comment reflect
wrong information compared to the text.
fixes #9041
2015-04-17 16:44:40 +02:00
Gunnar Beutner
f69c0bd5a2
Remove the ScopeCurrent constant
...
fixes #9044
2015-04-15 08:36:17 +02:00
Michael Friedrich
4f767ab06a
Change log level to 'notice' for 'Attempting to send notifications' messages
...
fixes #9021
2015-04-12 15:11:38 +02:00
Michael Friedrich
37f24592ed
Trigger downtimes for NOT-OK states after OnDowntimeAdded()
...
The fix in #8389 must happen *after* adding the downtime which signals an
insert into the IDO DB.
Once the downtimes have been added to the database, the additional
trigger_time and is_in_effect can be updated accordingly, *if* the
current object is already in a NOT-OK state.
fixes #9016
2015-04-12 14:38:35 +02:00
Gunnar Beutner
10441e9cd7
Fix permissions for agent CheckResult messages
...
fixes #8821
2015-03-30 13:50:14 +02:00
Gunnar Beutner
a5c5569324
Improve timeperiod validation error messages
...
fixes #8893
2015-03-29 08:13:11 +02:00
Gunnar Beutner
a6822fd59a
Fix validation errors for time ranges which span the DST transition
...
fixes #8892
2015-03-29 08:05:01 +02:00
Gunnar Beutner
72a7b08480
Move implementation code from thpp files into separate files
...
fixes #8890
2015-03-28 11:08:12 +01:00
Gunnar Beutner
ec7224e3ed
Generate C++ code for type validators
...
fixes #7709
fixes #8867
2015-03-27 07:59:27 +01:00
Gunnar Beutner
3adec4576c
Fix arrays in command arguments
...
fixes #8869
2015-03-26 09:29:52 +01:00
Gunnar Beutner
d3c0c1e42b
Fix incorrect variable values for apply+for
...
fixes #8851
2015-03-23 15:53:21 +01:00
Gunnar Beutner
151b6bbf00
Fix style violations
2015-03-21 10:04:14 +01:00
Michael Friedrich
e1cb543bb5
Fix missing config validator for command arguments 'set_if'
...
fixes #8724
2015-03-20 16:12:24 +01:00
Gunnar Beutner
e8cee8d5e2
Allow using more than one %validator rule for the same type
...
fixes #8829
2015-03-20 15:49:55 +01:00
Gunnar Beutner
e22386e63f
Make load order for objects more reliable
...
fixes #8770
2015-03-19 15:58:38 +01:00
Michael Friedrich
88f16abb3c
Use Utility::NaturalJoin for notification filter formatting
...
refs #8685
2015-03-19 14:08:06 +01:00
Gunnar Beutner
6c96d5bc98
Clean up the start-up process a bit
...
fixes #8791
2015-03-18 11:14:51 +01:00
Michael Friedrich
3c945914ff
Show notification state/type filter names in notice/debug log
...
fixes #8685
2015-03-12 17:11:24 +01:00
Michael Friedrich
05c237c780
Don't increment check attempt counter on OK->NOT-OK transition
...
refs #7287
Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-03-11 16:33:36 +01:00
Gunnar Beutner
228aafc945
Implement the parse_performance_data function
...
fixes #8693
2015-03-11 16:29:50 +01:00
Gunnar Beutner
e50d3e6e5a
Fix validator for dependencies
...
fixes #8596
2015-03-09 08:04:18 +01:00
Gunnar Beutner
22f3c5082d
Add validator for time ranges in ScheduledDowntime objects
...
fixes #8600
2015-03-09 08:02:12 +01:00
Gunnar Beutner
52102d815d
Fix second Deserialize() call in ApiEvents::ExecuteCommandAPIHandler
...
refs #8117
2015-03-06 01:45:43 +01:00
Gunnar Beutner
139540b570
Make sure we don't evaluate apply rules for fake hosts used in agent checks
...
fixes #8117
2015-03-05 21:19:04 +01:00
Gunnar Beutner
9181d7ae05
Add missing service name in check results
...
refs #8257
2015-03-05 20:50:27 +01:00
Gunnar Beutner
1d2b008dcb
Fix validator for TimePeriod ranges
...
fixes #8568
2015-03-03 09:56:38 +01:00
Gunnar Beutner
cf37decbef
Fix start condition for downtimes
...
fixes #8560
2015-03-03 09:52:13 +01:00
Jason Young
faf6ce1a5f
Update PerfdataValue::Parse to ignore invalid warn, crit, min, and max values
...
... instead of generating exception so that metric values can
still be passed to the graphing backend.
Also update icinga-perfdata tests to reflect these changes.
refs #5043
Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-03-02 13:52:41 +01:00
Gunnar Beutner
5968622108
Fix incorrect assignment in PluginUtility::ExecuteCommand
...
Coverity Bug ID: 1272344
2015-03-02 10:14:15 +01:00
Gunnar Beutner
9548692f00
Fix uninitialized field in the Checkable class
...
Coverity Bug ID: 1272323
2015-03-02 10:14:14 +01:00
Gunnar Beutner
c86b17132c
Make sure that the scheduled start time for downtimes isn't ignored
...
fixes #6959
2015-02-25 15:19:50 +01:00
Gunnar Beutner
acd5d55f64
Fix null pointer dereference in ApiEvents::RepositoryTimerHandler
...
fixes #8535
2015-02-25 14:00:00 +01:00
Gunnar Beutner
4da3b1c5b3
Make sure that Notification objects are activated after Host/Service objects
...
fixes #8517
2015-02-25 12:43:38 +01:00
Gunnar Beutner
551cb6ae87
Don't convert loop variables to string when using apply-for
...
fixes #8519
2015-02-24 17:51:16 +01:00
Gunnar Beutner
a104dcf773
Add validator for the 'ignore_soft_states' attribute
...
refs #7326
2015-02-23 14:29:17 +01:00
Gunnar Beutner
b5dbc66b22
Implement the 'is_inside' attribute for the TimePeriod type
...
refs #8467
2015-02-23 14:08:06 +01:00
Gunnar Beutner
47479ac4de
Implement the 'get_time_period' function
...
refs #8467
2015-02-23 13:56:53 +01:00
Michael Friedrich
aac53c1dd1
Add 'ignore_soft_states' attribute to Dependency objects
...
fixes #7326
2015-02-23 10:13:20 +01:00
Gunnar Beutner
a76f816623
Implement the 'continue' and 'break' keywords
...
fixes #8394
2015-02-19 12:57:52 +01:00
Gunnar Beutner
f097e48889
Don't use separate threads for each ApiClient object
...
fixes #6109
2015-02-14 16:34:36 +01:00
Michael Friedrich
2ed78e82a8
Validate configured TimePeriod ranges
...
Requires re-throwing the hidden exceptions inside the existing
timeperiod code and validating the configured time range
strings then.
fixes #7576
2015-02-13 17:10:58 +01:00
Michael Friedrich
2cab6fbb9d
Make the argments for the stats functions const-ref
...
fixes #8433
2015-02-13 11:29:15 +01:00
James Pharaoh
9fe52d0dc1
Make checks using 'command_endpoint' work inside HA zones
...
Previously there was no local processing of the executed
check result, which is mandatory inside a HA cluster.
Additionally this patch splits the command execution and
check result processing into more logical parts, executing
local checks, checks on the same command endpoint, and
remote checks.
More details in the referenced issue.
fixes #8249
Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2015-02-12 17:53:50 +01:00
Michael Friedrich
2ae06b7a52
Implement {EN,DIS}ABLE_HOST_SVC_NOTIFICATIONS commands
...
fixes #7784
2015-02-11 16:45:52 +01:00
Michael Friedrich
24852e05c7
Move ValidateMacroString into the MacroProcessor class
...
refs #7311
2015-02-11 16:14:59 +01:00
Michael Friedrich
0d18b96c39
Resolve macros in dictionary values
...
refs #7311
2015-02-11 15:58:59 +01:00
Gunnar Beutner
cb6f1043e1
Replace if( with if (
2015-02-11 15:47:45 +01:00
Michael Friedrich
8ca57cba03
Add macro config validator for command args, env, custom attr, perfdata templates
...
fixes #7311
2015-02-11 15:32:10 +01:00
Gunnar Beutner
2de89fe8d4
Allow funcs in the 'env' dictionary
...
refs #7564
2015-02-10 10:59:08 +01:00
Gunnar Beutner
9de7da4d2a
Update validators for CustomVarObject
...
fixes #7542
2015-02-10 08:53:15 +01:00
Gunnar Beutner
96aa503dbe
Disable flapping detection by default
...
fixes #6868
2015-02-09 14:23:09 +01:00
Gunnar Beutner
97fc5bb10b
Implement additional attributes for the Host class
...
refs #7564
2015-02-09 08:50:17 +01:00
Gunnar Beutner
e456cfd99c
Relax the validator for Notification::users/Notification::user_groups a bit
...
fixes #8067
2015-02-08 11:03:10 +01:00
Michael Friedrich
b23d58dccc
Add host/service runtime macro downtime_depth
...
fixes #8195
2015-02-08 00:15:38 +01:00
Michael Friedrich
34b5a4d9b4
Trigger added downtimes immediately if checkable is Not-OK
...
fixes #8389
2015-02-08 00:08:12 +01:00
Michael Friedrich
db9c55835f
Require at least one user for notification objects (user or as member of user_groups)
...
fixes #8067
2015-02-07 23:04:01 +01:00
Michael Friedrich
9302a6d03c
StatusDataWriter: Fix wrong host notification filters
...
fixes #8387
refs #8192
2015-02-07 22:46:34 +01:00
Michael Friedrich
ea2ac81003
Remove name and return value for stats functions
...
fixes #6171
2015-02-07 22:36:17 +01:00
Michael Friedrich
9ce061a8c4
Fix User::ValidateFilters isn't being used
...
fixes #8111
2015-02-07 21:57:49 +01:00
Michael Friedrich
a1f04992f3
Fix notify flag is ignored in ACKNOWLEDGE_*_PROBLEM commands
...
fixes #8298
2015-02-07 21:39:19 +01:00
Gunnar Beutner
0605b76e7a
Report failed agent checks to the master
...
fixes #8257
2015-02-05 15:36:17 +01:00
Gunnar Beutner
2d5112c878
Send check result even when accept_commands is not set
...
fixes #8333
2015-02-05 15:17:56 +01:00
Michael Friedrich
06a262f7db
Schedule a host downtime for command SCHEDULE_HOST_SVC_DOWNTIME
...
fixes #8299
2015-02-04 21:19:47 +01:00
Gunnar Beutner
e3dcc8a610
Implement a unit test for nullary lambdas
...
fixes #7805
2015-02-03 14:02:32 +01:00
Gunnar Beutner
c01fb97337
Don't escape macros for the macro() function
...
refs #7564
2015-01-29 16:52:04 +01:00
Gunnar Beutner
2f44581f14
Validate timeperiod segments
...
fixes #8309
2015-01-29 14:14:56 +01:00
Gunnar Beutner
a3e0c9d898
Add missing mutex for AddNotification/RemoveNotification
...
fixes #8311
2015-01-29 13:21:22 +01:00
Gunnar Beutner
fb323ee215
Evaluate apply filters in the for loop
...
fixes #7610
2015-01-29 12:38:25 +01:00