1032 Commits

Author SHA1 Message Date
Gunnar Beutner
01e58b463a Fix incorrect re-scheduling behavior for command_endpoint checks
refs #8137
2016-05-12 14:06:47 +02:00
Michael Friedrich
a6e70a155d Fix possible crash in Add{Comment,Downtime}
refs #11112
2016-05-12 11:11:03 +02:00
Gunnar Beutner
21d1ffa28b Fix incorrect calculation in Downtime::IsInEffect
fixes #11589
2016-05-12 11:11:03 +02:00
Gunnar Beutner
89c7b5a900 Fix: "day -X" time specifications are parsed incorrectly
fixes #11147
2016-05-12 11:09:49 +02:00
Michael Friedrich
b3ad32712e Move CalculateExecutionTime and CalculateLatency into the CheckResult class
fixes #11751
2016-05-12 11:09:43 +02:00
Gunnar Beutner
f08d378202 Implement support for limiting the number of concurrent checks
fixes #8137
2016-05-12 11:08:21 +02:00
Gunnar Beutner
f2e6694179 Remove unused cluster commands
fixes #11748
2016-05-12 11:08:21 +02:00
Gunnar Beutner
d82db2ae6c Make sure the dependency graph is properly updated when adding and removing objects
fixes #11686
fixes #11374
2016-05-12 11:08:21 +02:00
Michael Friedrich
e0d1c2f020 Fix: Expired downtimes are not removed
fixes #11711
2016-05-12 11:08:20 +02:00
Jean Flach
0e70165bc9 Fix external commands comments crashing icinga
Now an exception will be thrown when AddSvcComment or AddHostComment are
run with and empty Author or comment

fixes #11112
2016-05-12 11:08:20 +02:00
Michael Friedrich
418636f7da Fix crash with empty ScheduledDowntime 'ranges' attribute
fixes #11158
2016-05-12 11:08:20 +02:00
Vytenis Darulis
9f3a6b92a2 Try to queue all PROCESS_FILE commands instead of exploding the stack
fixes #10426

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>
2016-05-12 11:08:19 +02:00
Gunnar Beutner
d4b5ada951 Fix crash in Checkable::ExecuteCheck
fixes #11582
2016-04-20 10:09:38 +02:00
Gunnar Beutner
159681c390 Fix crash in Downtime::DowntimesExpireTimerHandler
fixes #11534
fixes #11559
2016-04-20 10:09:34 +02:00
Michael Friedrich
1a21293809 Implement support for overriding check command timeout
fixes #9283
2016-04-20 10:09:34 +02:00
Michael Friedrich
0cbedf495a IDO: Ensure that the notification insert id is passed to contactnotification inserts
We cannot add the notification insert id directly
to the following contactnotifications queries. Instead
we need to pass a DbValue reference which gets set after
the notification insert id is calculated.
The contactnotifications insert queries are fired as query
group calling CanExecuteQuery() and FieldToEscapedString().
If the notification id does not exist yet, the queries are
moved to the end of the queue.
Once the contactnotifications queries are fired the DbValue
reference is destroyed.

This patch also removes the old notification insert id cache
which was broken in many ways.

fixes #11387
2016-04-20 10:07:24 +02:00
Michael Friedrich
d0b5898c46 Fix: Downtimes/Comments not being synced to child zones
fixes #11227
2016-04-20 10:07:24 +02:00
Gunnar Beutner
13c4bb06b8 Improve validation for arrays
fixes #11434
2016-04-20 10:07:23 +02:00
Michael Friedrich
521580f76e Ensure that the legacy_id attribute for comment/downtime objects is restored on restart
This has been changed when moving comments/downtimes to config objects
in 050c520b2a3df0477f2eec71ec2d874b6dd36aa5

It may cause trouble with DB IDO DELETE and UPDATE statements
depending on the old value.

refs #11382
2016-04-20 10:07:22 +02:00
Michael Friedrich
e076e91706 Only call UpdateNextCheck() for soft states
refs #11336
2016-04-20 10:00:09 +02:00
Michael Friedrich
8668eb65b5 Use UpdateNextCheck() for determining the retry_interval in ProcessCheckResult()
This patch also moves the next check updates for passive
check results into ProcessCheckResult(). That way the
next check status updates for DB IDO work in a sane way
again.

refs #11336
2016-04-20 10:00:08 +02:00
Michael Friedrich
122256bb91 Use retry_interval on first OK -> NOT-OK state change
Only valid for active check results. The API actions were
missing that marker similar to the external command processor.

The initial OK -> NOT-OK transition should use the retry_interval
but nothing else.

fixes #11336
2016-04-20 10:00:07 +02:00
Gunnar Beutner
4c7b5f710f Fix crash in ScheduledDowntime::TimerProc
fixes #11352
2016-03-15 13:15:57 +01:00
Michael Friedrich
f386920e60 Refactor patch for host recovery notifications
refs #10225
2016-03-15 13:11:01 +01:00
Michael Friedrich
ee7af887c8 Fix host recovery notifications for warning states
fixes  #10225
2016-03-11 15:58:13 +01:00
Julian Brost
ca869719d0 Fix max number of args for DEL_DOWNTIME_BY_HOST_NAME
The RegisterCommand call for DEL_DOWNTIME_BY_HOST_NAME was missing the
max args parameter. This prevented the optional service name, start time
and comment arguments to be passed.

Signed-off-by: Michael Friedrich <michael.friedrich@netways.de>

fixes #11240
2016-03-11 15:57:35 +01:00
Michael Friedrich
7ad7e28d7a Fix: Volatile transitions from HARD NOT-OK->NOT-OK do not trigger notifications
fixes #11320
2016-03-11 15:56:43 +01:00
Michael Friedrich
f99feab08c Revert "Fix check scheduling w/ retry_interval"
This reverts commit a51e647cc760bd5f7c4de6182961a477478c11a9.

This patch causes trouble with check results received
1) passively 2) throughout the cluster. A proper patch
for setting the retry_interval on NOT-OK state changes
is required.

refs #11248
refs #11257
refs #11273

(the old issue)
refs #7287
2016-03-11 15:55:14 +01:00
Michael Friedrich
8344f749cd Revert "Properly set the next check time for active and passive checks"
This reverts commit 2a11b27972e4325bf80e9abc9017eab7dd03e712.

This patch does not properly work and breaks the check_interval setting
for passive checks. Requires a proper patch.

refs #11248
refs #11257
refs #11273

(the old issue)
refs #7287
2016-03-11 15:55:03 +01:00
Sebastian Chrostek
f5f0f7bd6e Fix problem notifications while flapping is active
fixes #9969
fixes #9642
2016-03-11 15:24:02 +01:00
Michael Friedrich
e4b99ca87e Ensure that config files are readable by the daemon
refs #11212
refs #11211
2016-02-24 14:25:09 +01:00
Michael Friedrich
a79ea88fff Fix permissions for temporary files
fixes #11212
fixes #11211
2016-02-24 11:27:22 +01:00
Michael Friedrich
a837198bbc Fix unique creation of temp files
fixes #10948
2016-02-23 12:34:38 +01:00
Jean Flach
9376a37806 Remove unused variable 2016-02-23 10:51:54 +01:00
Gunnar Beutner
b8195beada Increase grace period for agent-based checks
refs #11020
2016-02-23 10:51:12 +01:00
Gunnar Beutner
fc90265332 Ensure that checks are not scheduled for command_endpoint fake hosts
refs #10963
2016-02-23 10:46:18 +01:00
Gunnar Beutner
7985e93ca0 Make sure we're not running command_endpoint-based checks more than once
refs #10963
2016-02-23 10:46:18 +01:00
Adam James
998abbbae7 Fix parsing of YYYY-MM-DD in LegacyTimePeriod::ParseTimeSpec
fixes #11132

Signed-off-by: Jean Flach <jean-marcel.flach@netways.de>
2016-02-23 09:45:34 +01:00
Jean Flach
9bc7f0ad75 Make schedule-downtime default fixed
fixes #10923
2016-02-23 09:43:53 +01:00
Gunnar Beutner
b3b2eb856b Make sure the "syncing" attribute is set to false
refs #11083
2016-02-23 09:35:57 +01:00
Michael Friedrich
186b52082a Remove debug output
refs #11014
2016-02-23 09:31:52 +01:00
Michael Friedrich
9dc37c58ea DB IDO: Only update 'next_check' column when manually scheduling a check
Otherwise the changes from #7287 already take care of setting
the proper next check time from inside ProcessCheckResult().

There is no need to use the generic OnNextCheckChanged signal
but instead we're using a new one, locally just for DB IDO.

fixes #11019
2016-02-23 09:25:05 +01:00
Michael Friedrich
9ca7245c18 Properly set the next check time for active and passive checks
fixes #7287
refs #11019
2016-02-23 09:24:57 +01:00
Michael Friedrich
ec9caa4517 Fix: Modified attributes do not work for the IcingaApplication object w/ external commands
fixes #10974
2016-02-23 09:23:25 +01:00
Michael Friedrich
f5fda9ebf0 Raise a config error for "Checkable" objects in global zones
fixes #10807
2016-02-23 09:20:39 +01:00
Gunnar Beutner
c544c686a8 Update copyright headers for 2016 2016-01-12 08:31:24 +01:00
Michael Friedrich
893f0b9853 Fix missing num_hosts_pending in /v1/status/CIB
fixes #10736
2015-12-08 15:45:22 +01:00
Michael Friedrich
6518f78af0 Fix attribute validation for PUT queries
fixes #10601
2015-11-12 10:13:46 +01:00
Gunnar Beutner
e3c75faabc Implement support for recursive object locks
fixes #10596
2015-11-11 10:21:30 +01:00
Michael Friedrich
f5da37b7df Remove obsolete checks from API actions
refs #10561
2015-11-10 16:13:14 +01:00