3866 Commits

Author SHA1 Message Date
Thomas Gelf
799a332c22 Html\Attributes: callbacks for setters and getters 2018-05-23 08:22:06 +02:00
Thomas Gelf
14cd540ce9 HostServiceRedirector: add applied service sets 2018-05-23 08:18:57 +02:00
Thomas Gelf
0f4fd471e2 HostServiceRedirector: new implementation for...
...service links. Fallback route and more

fixes #689
2018-05-23 00:47:30 +02:00
Thomas Gelf
d5807495a0 TemplateTree: load inheritance for unstored...
...objects even if the given parent is not a template. This happens with fake
objects while managing overrides
2018-05-22 14:40:56 +02:00
Thomas Gelf
d8b1207254 Sync: it's not yet possible to let single...
...objects fail

refs #1048
2018-05-22 12:17:22 +02:00
Markus Frosch
49afcd5855 Sync: Only prefetch relations for IcingaObject
So DatalistEntry can be synced

fixes #1048
2018-05-22 11:08:03 +02:00
Thomas Gelf
b773b90ae5 JobDetails: fix message "characters are not yet.." 2018-05-17 08:36:39 +02:00
Thomas Gelf
05bc9e5bfc CustomvarTable, SyncRunDetails: small fixes 2018-05-09 13:18:10 +02:00
Thomas Gelf
df83c9abad ipl: no more Html::__callStatic, add phpdocs 2018-05-08 19:54:00 +02:00
Thomas Gelf
cbd0d03d36 Merge branch 'feature/refresh-ipl' 2018-05-08 17:04:35 +02:00
Thomas Gelf
c514b3995b ObjectTabs: show 'inspect' only for endpoints...
...with an ApiUser reference

fixes #1293
2018-05-08 16:28:31 +02:00
Thomas Gelf
b1fd0bd9ed ObjectTabs: show 'inspect' only for endpoints...
...with an ApiUser reference

fixes #1293
2018-05-08 16:25:38 +02:00
Thomas Gelf
319b000407 ipl: phpdoc, cleanup 2018-05-06 09:08:37 +02:00
Thomas Gelf
01c3a553ba ipl: drop obsoleted components 2018-05-05 18:49:58 +02:00
Thomas Gelf
df7c77a0f6 ipl-related fixes 2018-05-05 18:29:17 +02:00
Thomas Gelf
988319dcf6 ipl-related: use HtmlDocument instead of Html 2018-05-05 01:25:24 +02:00
Thomas Gelf
955695682d Use BaseHtmlElement and more 2018-05-05 01:11:55 +02:00
Thomas Gelf
f1480359da ipl: even more changes 2018-05-05 01:04:25 +02:00
Thomas Gelf
4f8c60bb46 various: cleanup, sop using deprecated methods 2018-05-05 00:24:49 +02:00
Thomas Gelf
403df971a1 dipl: align with ipl, first step 2018-05-05 00:18:45 +02:00
Thomas Gelf
be0d41459f ipl: code cleanup 2018-05-04 22:55:24 +02:00
Thomas Gelf
30c6bf1b95 ipl: relax attribute name checks 2018-05-04 22:54:48 +02:00
Thomas Gelf
a10fa5abff Merge branch 'feature/sync-keep-overrides-1307' 2018-05-04 22:14:26 +02:00
Thomas Gelf
a033e411c6 Sync: preserve _override_servicevars
fixes #1307
2018-05-04 22:14:07 +02:00
Thomas Gelf
d3aabe0e99 js: allow suggestion list to be twice the input...
...field width

fixes #1308
2018-05-04 19:23:37 +02:00
Thomas Gelf
d4de84eddc css: allow textarea fields to grow horizontally
fixes #299
2018-05-04 18:46:16 +02:00
Thomas Gelf
99ddb9266b Commands: show usage over templates and objects
fixes #335
2018-05-04 18:02:05 +02:00
Thomas Gelf
6add437dce IcingaCommand: do not allow to delete while in use
fixes #1443
2018-05-04 13:12:23 +02:00
Thomas Gelf
8e4b88195b ObjectsTableCommand: formatting 2018-05-04 12:47:51 +02:00
offsides
38a56f68fe Assign: add "is not set" operator
fixes #1436
2018-05-04 12:42:39 +02:00
Da Rold Valentina
69d3675b34 SuggestController: don't suggest command templates
...where commands are required

fixes #1414
2018-05-04 11:32:18 +02:00
Thomas Gelf
cd2de241dd Commands: allow to filter by usage
fixes #1480
2018-05-04 11:03:42 +02:00
Thomas Gelf
4c77a32ee0 IcingaConfig: remove hard-coded global zone
Anyways, this line should be obsolete
2018-05-04 08:45:32 +02:00
Thomas Gelf
b6c0895d33 IcingaServiceSetForm: hide empty descriptions 2018-05-04 08:43:43 +02:00
Michael Friedrich
05a8918f07 Update docs to GitHub issue tracker 2018-05-03 22:29:13 +02:00
Thomas Gelf
f49276372a cli: add SyncruleCommand
fixes #1476
2018-04-27 18:14:56 +02:00
Markus Frosch
bd5e33ab11 SyncruleController: Handle forms before processing the rule for content
This ensures we show the latest details on the sync rule, without need
to reload the view (reload was active before adding benchmark)
2018-04-27 16:05:39 +02:00
Markus Frosch
c2fcd407cc ObjectApplyMatches: Prepare filters only once
So that it can be re-used on multiple objects during sync.
2018-04-27 16:05:39 +02:00
Markus Frosch
0b7bb123cd GroupMembershipResolver: Parse filters before iterating through objects
Massive performance improvement! Up to 10x!
2018-04-27 16:05:39 +02:00
Markus Frosch
f6cf1a4245 GroupMembershipResolver: Improve Benchmark output 2018-04-27 16:05:39 +02:00
Markus Frosch
3b812fab7d Sync: Make sure to prefetch relations for objects
This can avoid a lot of queries for zones, commands, timeperiods.
2018-04-27 16:05:39 +02:00
Markus Frosch
c4a95fd64e Sync: Implement Benchmark for the Sync process
Note: This disables redirect-on-success for the forms, so you can see
the benchmark result.
2018-04-27 16:05:39 +02:00
Thomas Gelf
fb3dc92b36 ImportRunBasedPurgeStrategy: performance boost...
...for some older MariaDB/MySQL versions
2018-04-27 15:58:13 +02:00
Thomas Gelf
d001d4a9be cli: add ImportsourceCommand
fixes #1474
2018-04-27 15:06:45 +02:00
Markus Frosch
43a68c78ad
Merge pull request #1460 from M2Mobi/php-diff
Upstream fixes for php-diff
2018-04-16 09:08:13 +02:00
Heinz Wiesinger
525b3164c0 vendor: Update php-diff with fixes
Version is based on:
* 3cb3f7ce6b
* and https://github.com/chrisboulton/php-diff/pull/50

Also see SOURCE
2018-04-16 08:59:59 +02:00
David McBride
8e28f7f9c8 Avoid failing when attempting to render NULL column-set
PHP 7.2 is stricter about invoking count() with parameters which
are not countable:

 https://secure.php.net/manual/en/migration72.incompatible.php

This case is triggered in QueryBasedTable, for example when reviewing
the Activity Log:

 count(): Parameter must be an array or an object that implements Countable (QueryBasedTable.php:115)
 #0 [internal function]: Icinga\Application\ApplicationBootstrap->Icinga\Application\{closure}(2, 'count(): Parame...', '/usr/share/icin...', 115, Array)
 #1 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Web/Table/QueryBasedTable.php(115): count(NULL)
 #2 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Html/BaseElement.php(133): dipl\Web\Table\QueryBasedTable->renderContent()
 #3 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Html/Html.php(171): dipl\Html\BaseElement->render()
 #4 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Html/BaseElement.php(105): dipl\Html\Html->render()
 #5 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Html/BaseElement.php(133): dipl\Html\BaseElement->renderContent()
 #6 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Html/Html.php(259): dipl\Html\BaseElement->render()
 #7 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Zf1/SimpleViewRenderer.php(47): dipl\Html\Html->__toString()
 #8 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Zf1/SimpleViewRenderer.php(66): dipl\Zf1\SimpleViewRenderer->render()
 #9 /usr/share/icingaweb2/library/vendor/Zend/Controller/Action/HelperBroker.php(272): dipl\Zf1\SimpleViewRenderer->postDispatch()
 #10 /usr/share/icingaweb2/library/vendor/Zend/Controller/Action.php(518): Zend_Controller_Action_HelperBroker->notifyPostDispatch()
 #11 /usr/share/php/Icinga/Web/Controller/Dispatcher.php(76): Zend_Controller_Action->dispatch('activitiesActio...')
 #12 /usr/share/icingaweb2/library/vendor/Zend/Controller/Front.php(937): Icinga\Web\Controller\Dispatcher->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
 #13 /usr/share/php/Icinga/Application/Web.php(389): Zend_Controller_Front->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
 #14 /usr/share/php/Icinga/Application/webrouter.php(109): Icinga\Application\Web->dispatch()
 #15 /usr/share/icingaweb2/public/index.php(4): require_once('/usr/share/php/...')
 #16 {main}

Perhaps over-simplistically, this failure can be avoided by first
checking the countability of the relevant value with isset().
2018-04-05 16:55:16 +02:00
Thomas Gelf
473bbd40c4 IcingaHostForm: fix premission checks on new Hosts
refs #1451
2018-03-29 16:46:41 +02:00
Thomas Gelf
5dab1d3bb8 IcingaHostForm: logic belongs here
refs #1451
2018-03-28 18:38:36 +02:00
Thomas Gelf
8c7897ee46 DirectorObjectForm: do not allow to store...
...IcingaHost objects you wouldn't be allowed to see afterwards

fixes #1451
2018-03-28 18:32:52 +02:00