Commit Graph

95 Commits

Author SHA1 Message Date
Thomas Gelf 606d71501e Use ipl, try to keep dipl compatibility 2019-09-11 23:02:39 +02:00
Thomas Gelf e1565c9990 Revert "Merge branch 'next'"
This reverts commit f45f925e5e, reversing
changes made to 90c07943e4.

This was too early, need to check for incubator
2019-09-06 09:54:03 +02:00
Thomas Gelf 17f8ef1dd0 Use ipl, try to keep dipl compatibility 2019-09-06 09:48:11 +02:00
Thomas Gelf 5e19d3bada BaseFormElement: move attribute callbacks to...
...dedicated methods, this allows to override them
2019-04-11 02:34:14 +02:00
Thomas Gelf 15ae2da996 SimpleViewRenderer: fix indentation 2019-02-13 11:56:39 +01:00
Thomas Gelf 9237d34aa4 SimpleViewRenderer: deal with early errors
fixes #1742
2019-02-12 11:45:52 +01:00
Thomas Gelf cf161f480c SubmitElement: always ignore value 2018-11-06 07:18:34 +01:00
Thomas Gelf dfdc7d327b FilterRenderer: support SimpleQuery
fixes #1670
2018-10-30 18:02:32 +01:00
Thomas Gelf d8184ce373 ZfQueryBasedTable: only search with wildcards...
...when no wildcard has been given
2018-10-30 16:42:55 +01:00
Thomas Gelf eedb6edff0 ControlsAndContent, js: trigger immediate refresh
...on missing WindowId. This fixes an issue for instances with multiple DB
resources
2018-10-08 13:54:18 +02:00
Thomas Gelf 3632eea164 Html: allow for string/int/float as tag content 2018-10-08 06:36:45 +02:00
Thomas Gelf ba47c39c51 BaseFormElement: '' is null for now 2018-10-08 06:36:38 +02:00
Thomas Gelf c93657c42e ZfQueryBasedTable: provide hasSearch() 2018-10-06 17:16:34 +02:00
Thomas Gelf 2b61a0e7c4 CompatController: use default exception 2018-10-01 11:59:02 +02:00
Thomas Gelf 77543371b7 ipl\Html\Form: use value name, not index 2018-10-01 11:59:02 +02:00
Thomas Gelf 095de49570 ipl/Form: set correct action url 2018-09-13 19:38:30 +02:00
Thomas Gelf fb4efa303f ipl\Html: Textarea is a FormElement 2018-09-06 01:16:37 +02:00
Thomas Gelf 6d139752fe QueryBasedTables: make search() public 2018-09-04 11:08:37 +02:00
Thomas Gelf b790c7410a Pagination: do not count twice for the same query 2018-09-04 11:08:37 +02:00
Thomas Gelf 14a3039f65 controllers, libs: less noise from exceptions 2018-08-08 10:07:39 +02:00
Thomas Gelf 71ad8553cf ComatController: add missing use 2018-08-06 13:59:57 +02:00
Thomas Gelf e6563b9882 ipl: fix SelectElement callback, Table cleanup 2018-06-23 09:07:07 +02:00
Thomas Gelf 35815e0dad library: lot's of cleanup 2018-06-19 13:47:19 +02:00
Thomas Gelf 33ff71ce94 Url: hide Icinga Exceptions 2018-06-14 10:14:08 +02:00
Thomas Gelf 0026e7fd61 ipl/Web: avoid Icinga Exceptions 2018-06-14 08:51:40 +02:00
Thomas Gelf c587067a33 ipl\Html\Form: tweak error handling 2018-06-12 20:00:38 +02:00
Thomas Gelf a80bc13f39 Form: elements is a ElementContainer property 2018-06-08 16:54:13 +02:00
Thomas Gelf 35c2c034fd ipl: add ipl\Html\Form prototype 2018-06-07 23:32:39 +02:00
Thomas Gelf 31a6ab0cf2 IcingaHostServiceTable, others: cleanup, fix...
...blacklist-styling
2018-05-30 00:45:08 +02:00
Markus Frosch f19a41d11a php-diff: Fix undefined offset in Array Renderer
See https://github.com/chrisboulton/php-diff/pull/51
2018-05-29 17:22:52 +02:00
Thomas Gelf 5a8c785b7c dipl: align with ipl-html, stop using deprecated
...method Html::escapeForHtml
2018-05-25 19:09:42 +02:00
Thomas Gelf 3673daaa3c Html: allow to wrap elements, needed for forms 2018-05-23 08:30:37 +02:00
Thomas Gelf 799a332c22 Html\Attributes: callbacks for setters and getters 2018-05-23 08:22:06 +02:00
Thomas Gelf df83c9abad ipl: no more Html::__callStatic, add phpdocs 2018-05-08 19:54:00 +02:00
Thomas Gelf 319b000407 ipl: phpdoc, cleanup 2018-05-06 09:08:37 +02:00
Thomas Gelf 01c3a553ba ipl: drop obsoleted components 2018-05-05 18:49:58 +02:00
Thomas Gelf df7c77a0f6 ipl-related fixes 2018-05-05 18:29:17 +02:00
Thomas Gelf 988319dcf6 ipl-related: use HtmlDocument instead of Html 2018-05-05 01:25:24 +02:00
Thomas Gelf 955695682d Use BaseHtmlElement and more 2018-05-05 01:11:55 +02:00
Thomas Gelf f1480359da ipl: even more changes 2018-05-05 01:04:25 +02:00
Thomas Gelf 403df971a1 dipl: align with ipl, first step 2018-05-05 00:18:45 +02:00
Thomas Gelf be0d41459f ipl: code cleanup 2018-05-04 22:55:24 +02:00
Thomas Gelf 30c6bf1b95 ipl: relax attribute name checks 2018-05-04 22:54:48 +02:00
Heinz Wiesinger 525b3164c0 vendor: Update php-diff with fixes
Version is based on:
* 3cb3f7ce6b
* and https://github.com/chrisboulton/php-diff/pull/50

Also see SOURCE
2018-04-16 08:59:59 +02:00
David McBride 8e28f7f9c8 Avoid failing when attempting to render NULL column-set
PHP 7.2 is stricter about invoking count() with parameters which
are not countable:

 https://secure.php.net/manual/en/migration72.incompatible.php

This case is triggered in QueryBasedTable, for example when reviewing
the Activity Log:

 count(): Parameter must be an array or an object that implements Countable (QueryBasedTable.php:115)
 #0 [internal function]: Icinga\Application\ApplicationBootstrap->Icinga\Application\{closure}(2, 'count(): Parame...', '/usr/share/icin...', 115, Array)
 #1 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Web/Table/QueryBasedTable.php(115): count(NULL)
 #2 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Html/BaseElement.php(133): dipl\Web\Table\QueryBasedTable->renderContent()
 #3 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Html/Html.php(171): dipl\Html\BaseElement->render()
 #4 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Html/BaseElement.php(105): dipl\Html\Html->render()
 #5 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Html/BaseElement.php(133): dipl\Html\BaseElement->renderContent()
 #6 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Html/Html.php(259): dipl\Html\BaseElement->render()
 #7 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Zf1/SimpleViewRenderer.php(47): dipl\Html\Html->__toString()
 #8 /usr/share/icingaweb2/modules/director/library/vendor/ipl/Zf1/SimpleViewRenderer.php(66): dipl\Zf1\SimpleViewRenderer->render()
 #9 /usr/share/icingaweb2/library/vendor/Zend/Controller/Action/HelperBroker.php(272): dipl\Zf1\SimpleViewRenderer->postDispatch()
 #10 /usr/share/icingaweb2/library/vendor/Zend/Controller/Action.php(518): Zend_Controller_Action_HelperBroker->notifyPostDispatch()
 #11 /usr/share/php/Icinga/Web/Controller/Dispatcher.php(76): Zend_Controller_Action->dispatch('activitiesActio...')
 #12 /usr/share/icingaweb2/library/vendor/Zend/Controller/Front.php(937): Icinga\Web\Controller\Dispatcher->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
 #13 /usr/share/php/Icinga/Application/Web.php(389): Zend_Controller_Front->dispatch(Object(Icinga\Web\Request), Object(Icinga\Web\Response))
 #14 /usr/share/php/Icinga/Application/webrouter.php(109): Icinga\Application\Web->dispatch()
 #15 /usr/share/icingaweb2/public/index.php(4): require_once('/usr/share/php/...')
 #16 {main}

Perhaps over-simplistically, this failure can be avoided by first
checking the countability of the relevant value with isset().
2018-04-05 16:55:16 +02:00
Thomas Gelf feb80480ea QueryBasedTable: remove a superfluous empty line 2018-02-25 17:47:20 +01:00
Thomas Gelf 0ae1ed1319 Img: allow for data urls 2018-02-20 14:39:58 +01:00
Thomas Gelf 5a5cd9ba1e BaseElement: easier way to override isVoid 2018-02-20 14:38:32 +01:00
Thomas Gelf 20bcbdccf7 ipl/Attributes: allow a prefix, helps with data-* 2018-02-20 14:36:01 +01:00
Thomas Gelf 7fa2d91d37 Html/Text: fix wrong type in hint 2018-01-25 13:17:19 +01:00