DataView: Remove not in use method `applyUrlFilter()`

This commit is contained in:
Sukhwinder Dhillon 2022-05-30 12:21:51 +02:00 committed by Johannes Meyer
parent 3b04a0489e
commit 4ab79a6758
2 changed files with 1 additions and 20 deletions

View File

@ -44,6 +44,7 @@ v2.6 to v2.8 requires to follow the instructions for v2.7 too.
+ `DbConnection::getConnection()`: Use `Connection::getDbAdapter()` instead.
+ `DbQuery::renderFilter()`: Use `DbConnection::renderFilter()` instead.
+ `DbQuery::whereToSql()`: Use `DbConnection::renderFilter()` instead.
+ `DataView::applyUrlFilter()`: Not in use.
**Classes:**
+ `Icinga\Util\String`: Use `Icinga\Util\StringHelper` instead.

View File

@ -135,26 +135,6 @@ abstract class DataView implements QueryInterface, SortRules, FilterColumns, Ite
return $columns;
}
// TODO: This is not the right place for this, move it away
protected function applyUrlFilter($request = null)
{
$url = Url::fromRequest();
$limit = $url->shift('limit');
$sort = $url->shift('sort');
$dir = $url->shift('dir');
$page = $url->shift('page');
$format = $url->shift('format');
$view = $url->shift('showCompact');
$view = $url->shift('backend');
foreach ($url->getParams() as $k => $v) {
$this->where($k, $v);
}
if ($sort) {
$this->order($sort, $dir);
}
}
/**
* Create view from params
*