tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Handle _blank and similar links in JS as 'return true' seems unreliable

This commit is contained in:
Thomas Gelf 2014-03-09 00:58:49 +01:00
parent 959967c646
commit f31e697d72
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
public/js/icinga/events.js
View File

@ -155,20 +155,22 @@
linkClicked: function (event) {
var self = event.data.self;
var icinga = self.icinga;
var $a = $(this);
var href = $a.attr('href');
var linkTarget = $a.attr('target');
var $li;
var $target;
var isMenuLink = $a.closest('#menu').length > 0;
// TODO: Let remote links pass through. Right now they only work
// combined with target="_blank" or target="_self"
if ($a.attr('target') === '_blank' || $a.attr('target') === '_self') {
return true;
// window.open is used as return true; didn't work reliable
if (linkTarget === '_blank' || linkTarget === '_self') {
window.open(href, linkTarget);
return false;
}
// All other links are handled as XHR requests
// Handle all other links as XHR requests
event.stopPropagation();
event.preventDefault();