2104 Commits

Author SHA1 Message Date
Johannes Meyer
54a834266c Form::createElements() should add elements instead of returning them
In case createElements() would still return the elements while requiring
the caller to add them to the form all form dependent configurations get
lost. (displaygroups, belongTo, ...) Wizards or parent forms can still
retrieve only input relevant fields by just calling createElements() and
getElements().

refs #5525
2014-09-03 12:21:31 +02:00
Eric Lippmann
dd3901e891 `FormNumber': Fix "The use statement with non-compound name..."
refs #5525
2014-09-02 17:08:54 +02:00
Johannes Meyer
5ce9bef689 Replace usages of the helptext' form element option with description'
refs #5525
2014-09-02 17:03:51 +02:00
Eric Lippmann
c7a4098c04 lib: Respect the disabled attribute in `FormNumber'
refs #5525
2014-09-02 16:54:43 +02:00
Johannes Meyer
95c839a8bd Remove remaining usages of the ElementWrapper- and HelpText-Decorator
refs #5525
2014-09-02 16:50:59 +02:00
Thomas Gelf
8577940e1e StaticController: cache gravatar images
fixes #7061
2014-09-02 16:31:38 +02:00
Johannes Meyer
5464321a1b ConfigController: Remove obsolete functionality 2014-09-02 16:25:03 +02:00
Johannes Meyer
1ba3df310c Remove BaseConfigController, User\Message and Widget\AlertMesageBox
refs #6758
2014-09-02 16:25:03 +02:00
Johannes Meyer
2d86e6ba3b Rename ResourceForm and make it use handleRequest() & Co.
refs #5525
2014-09-02 16:25:03 +02:00
Johannes Meyer
5b14d8fed3 Fix that the force_creation checkbox disappears after another error
Once the user enters invalid data after he tried to save a backend without
success (because the backend was not successfully validated) the shown
checkbox disappeared in this case regardless of whether it was checked
or not.

refs #5525
2014-09-02 16:25:03 +02:00
Johannes Meyer
aedc8cc8b1 Fix spelling issue in german translation catalog 2014-09-02 16:19:45 +02:00
Johannes Meyer
39bb01b433 Rename Icinga\Web\Form::onShow() to onRequest()
onShow() is misleading because at the time this method is being called the
form is neither shown nor created.

refs #5525
2014-09-02 16:19:45 +02:00
Johannes Meyer
deebb64869 Adjust Icinga\Form\Config\General* to use handleRequest() & Co.
refs #5525
2014-09-01 16:16:56 +02:00
Johannes Meyer
0e63e36ec0 Move Icinga\Form\Config\ConfirmRemovalForm to Icinga\Form
This is a generic form not necessarily being used just for configuration
purposes.

refs #5525
2014-09-01 15:11:09 +02:00
Marius Hein
751d2e6d11 ErrorController: Log exception and stacktrace
refe #5896
2014-09-01 10:00:04 +02:00
Johannes Meyer
fb5685bac3 Merge branch 'master' into bugfix/rebuild-form-builder-5525
Conflicts:
	application/forms/Config/Authentication/BaseBackendForm.php
	application/forms/Config/Authentication/DbBackendForm.php
	application/forms/Config/Authentication/LdapBackendForm.php
	application/forms/Config/Authentication/ReorderForm.php
	application/forms/Config/LoggingForm.php
	application/forms/Config/ResourceForm.php
	application/forms/Preference/GeneralForm.php
	library/Icinga/Application/Config.php
	library/Icinga/Web/Form.php
	modules/monitoring/application/controllers/ConfigController.php
	modules/monitoring/application/forms/Config/Backend/CreateBackendForm.php
	modules/monitoring/application/forms/Config/Instance/CreateInstanceForm.php
	modules/monitoring/application/forms/Config/Instance/EditInstanceForm.php
	modules/monitoring/application/forms/Config/SecurityForm.php
2014-08-29 16:05:56 +02:00
Johannes Meyer
ae35650c7e Adjust authentication backend forms to suit.. some form implementation
refs #5525
2014-08-29 15:16:13 +02:00
Johannes Meyer
364c7c0858 Add base form class for configuration forms
refs #5525
2014-08-29 12:25:25 +02:00
Marius Hein
e345aa257a Platform: Drop *Available function
Create a function extensionLoaded and change usages.

refs #5514
2014-08-28 12:14:55 +02:00
Marius Hein
436a4d2965 ResourceConfig: Chance createResouce to create
Not useful everywhere. Changed on the best suitable places.

refs #5514
2014-08-28 12:14:55 +02:00
Marius Hein
22e17e9901 ResourceFactory: Move available function to platform
refs #5514
2014-08-28 12:14:54 +02:00
Alexander Fuhr
66062c87b6 Remove unused use Zend_Config 2014-08-28 10:55:06 +02:00
Alexander Klimov
45638b218c Throw IcingaException rather than Exception
fixes #7014
2014-08-27 16:03:15 +02:00
Alexander Klimov
7ff51caed0 Remove leading backslashes from the targets of use statements
- use \Exception;
+ use Exception;
2014-08-27 15:51:49 +02:00
Eric Lippmann
1dea19504f Revert "Remove leading backslashes from the targets of use statements"
This reverts commit 87a59675011a4cf284d8e44c4fb66042ad84c39f.

At least 'modules/doc/run.php' issues a warning about "The use statement with non-compound name 'Zend_Controller_Router_Route' has no effect"
2014-08-27 12:24:11 +02:00
Marius Hein
88698cb05d Hook/TopBar: Rework interface for monitoring top bar
refs #6929
2014-08-27 11:31:48 +02:00
Alexander Klimov
87a5967501 Remove leading backslashes from the targets of use statements
- use \Exception;
+ use Exception;
2014-08-27 11:16:44 +02:00
Alexander Fuhr
af0cf48197 Add self provided configuration for dashlets
refs #6639
2014-08-26 10:34:35 +02:00
Alexander Fuhr
11127446e0 Update description if no dashlets available
refs #6639
2014-08-26 10:34:34 +02:00
Alexander Fuhr
b60c3590b0 Deactivate addUrl to Dashboard
refs #6639
2014-08-26 10:34:34 +02:00
Thomas Gelf
5c46355474 translation: refresh de_DE 2014-08-22 17:58:53 +02:00
Johannes Meyer
7b221e2aba It should not be a form's responsibility how its submit button should look..
...in case it's a standard button. No need to be DRY here.

refs #5525
2014-08-22 15:20:54 +02:00
Johannes Meyer
403f745488 Remove obsolete loggingAction
refs #6933
2014-08-22 12:34:33 +02:00
Johannes Meyer
a0b2c0b454 Fix another documentation block 2014-08-22 12:18:26 +02:00
Johannes Meyer
75a0c17933 Ensure that all forms have a name
refs #5525
2014-08-22 12:15:02 +02:00
Johannes Meyer
2b879b344f Do not populate using createElements() and fix documentation blocks
refs #5525
2014-08-22 12:04:14 +02:00
Alexander Fuhr
20cead67a6 Merge branch 'master' into bugfix/modules-menu-provider-6639 2014-08-22 11:44:10 +02:00
Alexander Fuhr
f757f69bd1 Change Menu load from config ini files to self provided configuration
refs #6639
2014-08-22 11:10:17 +02:00
Johannes Meyer
bc05d2ee64 Merge LoggingForm into GeneralForm
fixes #6933
2014-08-22 11:05:20 +02:00
Thomas Gelf
af97db31d7 StaticController: fix gravatar sample img header 2014-08-21 19:10:53 +02:00
Johannes Meyer
bb7972aa39 Merge branch 'master' into bugfix/rebuild-form-builder-5525
Conflicts:
	application/controllers/AuthenticationController.php
	application/controllers/ConfigController.php
	application/forms/Authentication/LoginForm.php
	application/forms/Preference/GeneralForm.php
	modules/monitoring/application/controllers/ChartController.php
2014-08-20 13:13:50 +02:00
Thomas Gelf
736113c80c AuthenticationController: show friendlier hints...
...while not disclosing sensitive information. More to come once we
have our setup wizard.

fixes #6534
2014-08-19 18:55:58 +02:00
Alexander Fuhr
2f54ff4797 Fix the unrelated tabs
resolves #6934
2014-08-19 13:18:52 +02:00
Thomas Gelf
7334716d15 favicon: add link type
The favicon link tag was missing a type attribute.
2014-08-19 12:25:14 +02:00
Thomas Gelf
0d3fb9e7a5 LoginForm: explicitely remove renderLayout
Should prevent against rare race conditions.

refs #6584
2014-08-19 11:35:51 +02:00
Alexander Fuhr
c69af6c5d2 Move "modules" to "System" menu
resolves #6934
2014-08-19 11:14:18 +02:00
Thomas Gelf
f67d273bbd AuthenticationController: handle redirect parameter
This is a form field instead of a get parameter right now.

fixes #6584
2014-08-19 10:14:46 +02:00
Thomas Gelf
17b64f9dd5 layout: add favicon
fixes #6956
2014-08-19 10:13:19 +02:00
Thomas Gelf
b5f336583f layout/body: protect containers from renderLayout
IMO this should be stripped before, this is just an additional
security measure.

refs #6935
2014-08-19 10:10:23 +02:00
Thomas Gelf
5a6b5172e6 Menu: ignore special params when comparing URLs
This fixes issues on login with dashboard != dashboard?renderLayout
and similar

refs #6699
2014-08-19 10:06:14 +02:00