If you filter by host custom variables and the query does not have the services table joined,
our query implementation calls the joinHosts method. Then, the column for the JOIN ON condition is
automatically set to h.host_object_id.
But it may be required by the query to call joinServices and use s.host_object_id instead of
h.host_object_id because the query does not use any host related table at all.
This is now possible when h.host_object_id is mapped to s.host_object_id:
class ServicesRelatedQuery
{
protected $columnMap = array(
'hosts' => array(
'h.host_object_id' => 's.host_object_id'
)
);
protected function joinHosts()
{
$this->requireVirtualTable('services');
}
}
Custom variables added via the URL parameters addColumns or sort must be added to the GROUP BY list when using PostgreSQL.
Credits to @nbuchwitz who came up with the initial fix for this.
refs #1873
The query for fetching the unhandled services count utilises the hosts query as subquery.
Restrictions are applied to both the hosts query and the query for the unhandled services count.
This leads to wrong results since the restrictions are already in place for the unhandled services count because we're using the hosts query as subquery.
refs #2822
Unfortunately, PhpStorm does not regonise PSR2 fall-through comments.
On the other hand, phpcs does not support the @noinspection phpdoc comment (/**).
The fix is a mix of PSR2 comments and @noinspection tags in code comments.
The help text still showed the wrong paramter, while it was not documented
as possible parameter either. In addition to that #562 unveils that a
custom --format parameter requires selected columns to do so.
This patch adds that into the documentation which is rendered as CLI command
help text then.
refs #562
Added comment types 'comment' and 'ack' as separate fields and removed
the array syntax due to problems with the filter editor.
refs #2925
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
This applies a new structure for the main doc/ and modules/*/doc tree with
01-About.md
02-Installation.md
...
This allows us to link from the main doc directory into module specific
documentation entries.
Furthermore table formatting, examples, and missing settings have been added
where applicable.
This patch also takes care about proper URL anchors and file names and directories.
fixes#2950
