13989 Commits

Author SHA1 Message Date
Yonas Habteab
17752eb8ac Don't render safari default details marker 2023-07-14 20:05:35 +02:00
Yonas Habteab
b619dd2186 Add activateEntry() & getActiveEntry() interface methods 2023-07-14 20:05:35 +02:00
Yonas Habteab
ee829fd4dc Unify error messages & add some class docblocks 2023-07-14 20:05:35 +02:00
Yonas Habteab
73853c327c DashboardsController: Remove some superfluous control structures & keep all dashboard actions consistent 2023-07-14 20:05:35 +02:00
Yonas Habteab
67b9d58557 Forms: Unify notification messages & add some return type declarations 2023-07-14 20:05:35 +02:00
Yonas Habteab
303084e34a DashboardsController: Check whether the pane has been moved before redirecting
We only need to construct a proper redirection when the current pane has been
moved to another home.
2023-07-14 20:05:35 +02:00
Yonas Habteab
c147341648 Fix dashlet unit tests 2023-07-14 20:05:35 +02:00
Yonas Habteab
6e28912db7 DashboardController: Redirect reqeusts to the new route & mark it as deprecated 2023-07-14 20:05:35 +02:00
Yonas Habteab
ebcc8ebc59 Model: Remove some unnecessary codes 2023-07-14 20:05:35 +02:00
Yonas Habteab
c56cbf25d6 Replace count(getEntries()) with countEntries() 2023-07-14 20:05:35 +02:00
Yonas Habteab
d0b3437995 Dashlet: Add return type decleration where applicable & use parent method in toArray() 2023-07-14 20:05:35 +02:00
Yonas Habteab
92226d4f08 DashboardList: Try to load dashlets when the current pane is empty
The controller only loads dashboards/dashlets either of the given name
or of the first home/pane that can be determined, so we need to load dashlets
for panes that aren't active when creating the list. Otherwise, we will end
up with empty dashboard panes.
2023-07-14 20:05:35 +02:00
Yonas Habteab
a6483e6e28 Pane: Implement DashboardEntry & add some return type decs & fixlets 2023-07-14 20:05:35 +02:00
Yonas Habteab
94d3fd2ac4 DashboardHome: Check whether org home doesn't match the current one before moving a pane
When updating/creating a Dashlet, the current and the original home passed as param
might be identical, which is fine but this shouldn't cause any duplicate entry errors
2023-07-14 20:05:34 +02:00
Yonas Habteab
ffbdbb9e13 DashboardEntries: Implement countEntries() & enhance how widgets are reordered 2023-07-14 20:05:34 +02:00
Yonas Habteab
4a347362e2 DashboardEntry: Introduce counteEntries() method & add return type dec where applicable 2023-07-14 20:05:34 +02:00
Yonas Habteab
d0d33d990c Ensure to load dashlets of the current pane before creating/updating a dashlet 2023-07-14 20:05:34 +02:00
Yonas Habteab
51370a9e37 Don't perform DB updates when the home/pane hasn't been changed 2023-07-14 20:05:34 +02:00
Yonas Habteab
89cbc9f644 SetupNewDashbaordForm: Remove superfluous control sturcture 2023-07-14 20:05:34 +02:00
Yonas Habteab
af7263d216 CSS: Don't add padding top to the dashelt caption
When you add some text that exceeds the webkit line clamp, the dashlet caption
looks off to me. Since the caption doesn't have padding-bottom, we shouldn't
also add padding-top to it.
2023-07-14 20:05:34 +02:00
Yonas Habteab
628b270e51 Add custom form-controls minimal layout 2023-07-14 20:05:34 +02:00
Yonas Habteab
79ca930930 BaseDashboard: Don't implement DashboardEntry interface 2023-07-14 20:05:34 +02:00
Yonas Habteab
7698baf5b8 IndexController: Redirect requests to the new dashboards route 2023-07-14 20:05:34 +02:00
Yonas Habteab
1ecbce7041 Render search hint without using a view script 2023-07-14 20:05:34 +02:00
Yonas Habteab
a726348718 Drop all dashboards related legacy codes 2023-07-14 20:05:34 +02:00
Yonas Habteab
e689959839 Redirect properly when the currently active home/pane is removed/moved
When the currently request home/pane is being removed/moved and we're still redirecting
with the `__CLOSE__` url, the removed/moved home/pane will sill remain in the history
state and will produce http not found exceptions
2023-07-14 20:05:34 +02:00
Yonas Habteab
8685a0d247 Let Sortable detect sort direction dynamically & don't use invertSwap sortable option 2023-07-14 20:05:34 +02:00
Yonas Habteab
22d483b515 Fix moving panes around using drag&drop doesn't update the tabs sometimes 2023-07-14 20:05:34 +02:00
Yonas Habteab
826e39ce91 DashboardsController: Ensure currently active home is still active when performing all kinds of dashboard actions 2023-07-14 20:05:34 +02:00
raviks789
533d329810 Revert "Add form controls in the correct order"
This reverts commit 61c3469fc63e559164016784034bcae18b3a2e04.
2023-07-14 20:05:34 +02:00
raviks789
122505ced4 Ensure drag and drop of dashboard home happens correctly (caused by b6958b1) 2023-07-14 20:05:34 +02:00
raviks789
4369b121c6 Do not make first letter of dashboard key capital 2023-07-14 20:05:34 +02:00
raviks789
8f9a55fcbf Allow adding and editing of dashlet description. 2023-07-14 20:05:34 +02:00
Yonas Habteab
cc5e08da7d DashletTest: Add test for creating dashlets from multiple modules 2023-07-14 20:05:34 +02:00
Yonas Habteab
a2e9d3c946 Allow creating same dashlets from different modules 2023-07-14 20:05:34 +02:00
Yonas Habteab
ec4d246a3c Add minimal layout for the welcome page 2023-07-14 20:05:34 +02:00
Yonas Habteab
d38ad63c96 DashboardEntries: Perform case-insensitive key checks when searching for dashboard entry 2023-07-14 20:05:34 +02:00
Yonas Habteab
aa33940ded forms.less: Add also button style on minimal layout & add mirgin-right to the btn-remove 2023-07-14 20:05:34 +02:00
Yonas Habteab
4fa5d5d717 Add form controls in the correct order 2023-07-14 20:05:34 +02:00
Yonas Habteab
05767811b3 DashboardsCommand: Avoid duplicating pane titles & remove unnecessary stuff 2023-07-14 20:05:34 +02:00
raviks789
f3de1dd2b6 Fix Add to Dashboard feature 2023-07-14 20:05:34 +02:00
Yonas Habteab
77e759fe8e Pane: Don't break the foreach prematurely when managing dashlets from multiple modules 2023-07-14 20:05:34 +02:00
Yonas Habteab
61cd09ab42 Ensure not to render custom url when updating a dashlet (caused by f8b9b02) 2023-07-14 20:05:34 +02:00
raviks789
f91e2769fb Show custom dashlet in case no dashlets are selected. 2023-07-14 20:05:34 +02:00
raviks789
abb78bb9ee Replace spl_object_hash($dashlet) with bin2hex($dashlet->getUuid()) and make $moduleDashlets attribute non-static 2023-07-14 20:05:34 +02:00
Yonas Habteab
509afbe6c4 Migrate command handle duplicate error correctly when the user supresses all the errors 2023-07-14 20:05:34 +02:00
Yonas Habteab
91272870a3 DBUtils: Make sure to use string types for hex/binary formats 2023-07-14 20:05:34 +02:00
Yonas Habteab
d454113941 DashboardsCommand: Handle also case where dashlets are defined before the actual dashboard panes 2023-07-14 20:05:34 +02:00
Yonas Habteab
474a26b1eb DashboardsController: Load all dashboard homes in the index action 2023-07-14 20:05:34 +02:00
Yonas Habteab
641e3042b3 DashboardManager: Don't raise an error when the passed name is the default home 2023-07-14 20:05:34 +02:00