2177 Commits

Author SHA1 Message Date
Yonas Habteab
b619dd2186 Add activateEntry() & getActiveEntry() interface methods 2023-07-14 20:05:35 +02:00
Yonas Habteab
ee829fd4dc Unify error messages & add some class docblocks 2023-07-14 20:05:35 +02:00
Yonas Habteab
73853c327c DashboardsController: Remove some superfluous control structures & keep all dashboard actions consistent 2023-07-14 20:05:35 +02:00
Yonas Habteab
67b9d58557 Forms: Unify notification messages & add some return type declarations 2023-07-14 20:05:35 +02:00
Yonas Habteab
303084e34a DashboardsController: Check whether the pane has been moved before redirecting
We only need to construct a proper redirection when the current pane has been
moved to another home.
2023-07-14 20:05:35 +02:00
Yonas Habteab
6e28912db7 DashboardController: Redirect reqeusts to the new route & mark it as deprecated 2023-07-14 20:05:35 +02:00
Yonas Habteab
c56cbf25d6 Replace count(getEntries()) with countEntries() 2023-07-14 20:05:35 +02:00
Yonas Habteab
d0d33d990c Ensure to load dashlets of the current pane before creating/updating a dashlet 2023-07-14 20:05:34 +02:00
Yonas Habteab
51370a9e37 Don't perform DB updates when the home/pane hasn't been changed 2023-07-14 20:05:34 +02:00
Yonas Habteab
89cbc9f644 SetupNewDashbaordForm: Remove superfluous control sturcture 2023-07-14 20:05:34 +02:00
Yonas Habteab
7698baf5b8 IndexController: Redirect requests to the new dashboards route 2023-07-14 20:05:34 +02:00
Yonas Habteab
1ecbce7041 Render search hint without using a view script 2023-07-14 20:05:34 +02:00
Yonas Habteab
a726348718 Drop all dashboards related legacy codes 2023-07-14 20:05:34 +02:00
Yonas Habteab
e689959839 Redirect properly when the currently active home/pane is removed/moved
When the currently request home/pane is being removed/moved and we're still redirecting
with the `__CLOSE__` url, the removed/moved home/pane will sill remain in the history
state and will produce http not found exceptions
2023-07-14 20:05:34 +02:00
Yonas Habteab
8685a0d247 Let Sortable detect sort direction dynamically & don't use invertSwap sortable option 2023-07-14 20:05:34 +02:00
Yonas Habteab
826e39ce91 DashboardsController: Ensure currently active home is still active when performing all kinds of dashboard actions 2023-07-14 20:05:34 +02:00
raviks789
533d329810 Revert "Add form controls in the correct order"
This reverts commit 61c3469fc63e559164016784034bcae18b3a2e04.
2023-07-14 20:05:34 +02:00
raviks789
8f9a55fcbf Allow adding and editing of dashlet description. 2023-07-14 20:05:34 +02:00
Yonas Habteab
a2e9d3c946 Allow creating same dashlets from different modules 2023-07-14 20:05:34 +02:00
Yonas Habteab
ec4d246a3c Add minimal layout for the welcome page 2023-07-14 20:05:34 +02:00
Yonas Habteab
4fa5d5d717 Add form controls in the correct order 2023-07-14 20:05:34 +02:00
raviks789
f3de1dd2b6 Fix Add to Dashboard feature 2023-07-14 20:05:34 +02:00
Yonas Habteab
61cd09ab42 Ensure not to render custom url when updating a dashlet (caused by f8b9b02) 2023-07-14 20:05:34 +02:00
raviks789
f91e2769fb Show custom dashlet in case no dashlets are selected. 2023-07-14 20:05:34 +02:00
raviks789
abb78bb9ee Replace spl_object_hash($dashlet) with bin2hex($dashlet->getUuid()) and make $moduleDashlets attribute non-static 2023-07-14 20:05:34 +02:00
Yonas Habteab
474a26b1eb DashboardsController: Load all dashboard homes in the index action 2023-07-14 20:05:34 +02:00
Yonas Habteab
3be596641f Render also the cog icon when there is more than 1 home 2023-07-14 20:05:34 +02:00
Yonas Habteab
3058983011 Force to refresh the menu container when removing a home & unset moved entry from the original widget 2023-07-14 20:05:34 +02:00
Yonas Habteab
d27b654208 DashboardsController: Redirect also when moving the requested pane to another home 2023-07-14 20:05:34 +02:00
Yonas Habteab
d7dcfd7cd9 DashboardsController: Add requested params to the refresh url when reordering widgets 2023-07-14 20:05:34 +02:00
Yonas Habteab
4fc410c6e9 Don't ignore url params of the DM view when requesting Drag&Drop actions 2023-07-14 20:05:34 +02:00
Yonas Habteab
54c3b9e2c6 DashboardsController: Use the default home when pane is requested without a home param in the DM view 2023-07-14 20:05:34 +02:00
Yonas Habteab
0c91a8a283 Adjust disabled input style sheets & remove unnecessary control structure within the WelcomeForm::onSuccess() method 2023-07-14 20:05:34 +02:00
Yonas Habteab
af062b8cb2 Add missing LICENSE header & adjust some notifcation messages 2023-07-14 20:05:34 +02:00
Yonas Habteab
ea4e0b8719 SetupNewDashboardForm: Use SPL object hash as an element name 2023-07-14 20:05:34 +02:00
Yonas Habteab
e8741c961f DashboardsController: Preserve params when redirecting after successfully performed dashboard actions 2023-07-14 20:05:34 +02:00
Yonas Habteab
c4112b40d5 Don't access Request except in controller & activate home/pane by a given name 2023-07-14 20:04:31 +02:00
Yonas Habteab
a527946306 DashboardsController: Adjust usage of Dashboard::getActivePane() 2023-07-14 19:51:08 +02:00
Yonas Habteab
4a32ee7b60 DashboardsController: Add the welcomeFrom instance directly to the dashboard
Since we no longer use an additional wrapper for the dashboards,
the welcome form can be added directly to the dashboard instance
2023-07-14 19:51:08 +02:00
Yonas Habteab
9f7eba4cf8 WelcomeForm: Don't raise sys errors directly but use notifications to notify the user 2023-07-14 19:51:08 +02:00
Yonas Habteab
2105541493 DashletForm: Don't override populated value with the request param 2023-07-14 19:51:08 +02:00
Yonas Habteab
be973d29e2 Use own form class for all dashboard types & cleanup Dashlet-/SetupNewDashboardForm classes 2023-07-14 19:51:08 +02:00
Yonas Habteab
c577e2f279 Forms: Introduce RemovePaneForm class 2023-07-14 19:51:08 +02:00
Yonas Habteab
3f4c0a8de6 Forms: Introduce PaneForm class 2023-07-14 19:51:08 +02:00
Yonas Habteab
c382d0fbaa Forms: Introduce RemoveHomeForm class 2023-07-14 19:51:08 +02:00
Yonas Habteab
4f98b0c696 Forms: Introduce HomeForm class 2023-07-14 19:51:08 +02:00
Yonas Habteab
04495e6276 Adjust Dashboard::getConn() calls & filtering by username 2023-07-14 19:51:08 +02:00
Johannes Meyer
84b462f57c dashboards/settings: Show tabs depending on where the user comes from 2023-07-14 19:51:08 +02:00
Johannes Meyer
2f09dbe68a DashboardsController: $this->httpNotFound() already accepts format params
there's no need to use `sprintf` explicitly
2023-07-14 19:51:08 +02:00
Johannes Meyer
3041d7d3c1 dashboards/settings: Cleanup HTML and CSS
Well what should I say..

* There should be nothing else inside a `ul` than `li` elements
 * If that's not feasible, don't use a `ul` but a `div`
* If adjusting a stylesheet, don't add new stuff to it without
  making sure that redundant/obsolete stuff is removed
* Restructure your stylesheet once you notice you're adding
  one rule after another to counteract the one before it.
  There was way too much code smell
* Only be as specific in CSS rules as you absolutely need to.
  Classes are usually enough. Only add tags if you use the same
  classes on different tags.
* Ensure that your CSS makes as less assumptions as possible
2023-07-14 19:51:08 +02:00