1771 Commits

Author SHA1 Message Date
Johannes Meyer
4b60f87021 IdoQuery: Correct doc of method requireColumn() 2022-07-05 09:55:32 +02:00
Johannes Meyer
e5ec9a36f7 monitoring: Fix conversion rules for timestamps in various queries 2022-07-05 09:55:32 +02:00
Johannes Meyer
3d159fe434 TimeRange: Accept strings in method validateTime() 2022-06-30 08:41:47 +02:00
Johannes Meyer
ec27f77861 DataView: Relax filter validation again
There are way too much missing columns in data views all
over the place. I dont' see a justification to fix them
as it's only now this "issue" occurs. It's easier to
revert this change here.

fixes #4797
2022-06-14 15:32:21 +02:00
Sukhwinder Dhillon
4ab79a6758 DataView: Remove not in use method applyUrlFilter() 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon
3b04a0489e Replace class Backend use with MonitoringBackend and remove class Backend 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon
0db42b32e6 Remove not in use class Icinga\Module\Monitoring\Environment.php 2022-06-14 14:24:30 +02:00
Johannes Meyer
46a21d9709 Drop method DbQuery::whereToSql()
It's been used by `DbQuery::renderFilter()` rather
exclusively. So if removing one, both need to go.
2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon
be1ff03dd3 MonitoredObject: Remove deprecated methods matches() and fromParams() 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon
60756afa34 Replace MonitoringBackend::createBackend() with MonitoringBackend::instance() 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon
49bea36345 MonitoringBackend: Remove deprecated method createBackedn() 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon
577d97a450 DataView: Move sort() body to order() and remove sort() and fromRequest() 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon
d8ddc6600a overrides customvarsWithOriginalNames only if the given object is of type host
A call to `__get()` reset the array if the given `$name` is a customvar
If `service` has a `host` customvar filter, the `fetchHostVariables()`
method was executed and overwrote the `customvarsWithOriginalNames` array.

fixes #4757
2022-06-13 11:56:57 +02:00
Johannes Meyer
777d146ba1 Perfdata: Avoid passing null to number_format() 2022-05-27 14:41:42 +02:00
Johannes Meyer
0f64e24f99 MonitoredObject: Register filters with whereEx() 2022-05-12 16:33:30 +02:00
raviks789
8898ed85ab Change FilterMatch to FilterEqual class for single object filter on object name.
Correspondingly the DbConnection::renderFilter() (as DbQuery::renderFilter() is deprecated and will be removed, hence no modifications here)
is also modified to render accordingly.
This correctly selects the host, service or contact in case the object name contains wild card characters like "\*".
2022-05-12 16:28:35 +02:00
Johannes Meyer
3edb5c3c94 IdoQuery: Introduce method whereEx() 2022-05-12 16:28:35 +02:00
Johannes Meyer
c5cf7abf0d IdoQuery: Avoid passing null to preg_replace()
refs #4640
2022-04-19 15:01:52 +02:00
Johannes Meyer
3dc384fb58 Avoid passing null to non-nullable arguments 2022-03-24 12:29:06 +01:00
Johannes Meyer
c038e84fc2 Ensure Return Type Compatibility with Internal Classes 2022-03-24 12:29:06 +01:00
Johannes Meyer
0d032989e6 Fix style issues in recent security fixes 2022-03-08 15:20:16 +01:00
Johannes Meyer
e815ff0309
Merge pull request from GHSA-qcmg-vr56-x9wf
Fix/ghsa qcmg vr56 x9wf
2022-03-08 12:03:41 +01:00
Johannes Meyer
6085b02b16 monitoring: Introduce new class CustomVarTable 2022-03-02 10:38:08 +01:00
Johannes Meyer
b0a7464795 Introduce new hook Monitoring/CustomVarRenderer 2022-03-02 10:38:08 +01:00
Johannes Meyer
8779f9f175 IdoQuery: Join customvars with only live references 2022-02-28 13:08:05 +01:00
Johannes Meyer
1092421782 Ido\Query\: Add objecttype_id checks where missing 2022-02-28 13:07:17 +01:00
Johannes Meyer
00353a1f25
Merge pull request #4660 from Icinga/fix/unhandled-service-counter-not-always-visible-3921
Drop the unhandled services counter in host lists
2022-02-28 13:05:29 +01:00
Johannes Meyer
e7bc0a136b Perfdata: Render unknown UOMs as-is 2022-02-28 11:53:59 +01:00
Johannes Meyer
796742f03d monitoring/list/hosts: Don't show unhandled service counts
It has too much problems. It wasn't even visible since the
initial release, at least not if there were many results.
It being visible was more a case of chance than guarantee.
We now also identified a major issue with restrictions and
the way we can assemble queries here. In short, there are
too much technical difficulties that we deemed it not
worthwhile to keep.
2022-02-25 17:09:13 +01:00
Johannes Meyer
2e9a94144f HostserviceproblemsummaryQuery: Don't clear order of the host status query 2022-02-25 17:08:39 +01:00
Johannes Meyer
a4d34e265f IdoQuery: Don't try to add a HAVING without group by rules 2022-02-11 12:11:40 +01:00
Johannes Meyer
6b4f4d388a monitoring: Really show custom variable names as-is 2022-02-04 15:56:44 +01:00
Johannes Meyer
83557afd35 IdoQuery: Qualify and resolve subquery filters ASAP
fixes #4508
2021-08-24 09:32:36 +02:00
Eric Lippmann
1e1b4b74ad If appropriate, set the API parameter all_services for schedule-downtime
Since Icinga 2.11.0 the schedule-downtime API supports the
all_services parameter. So far we've always sent a separate
request for scheduling service downtimes. As of Icinga 2.13.0,
these service downtimes are automatically removed when the host
downtimes are removed. Of course, this doesn't work if we don't
use the all_services parameter but send a separate request.
With this commit we set this parameter if the transport is API
and Icinga is equal to or greater than 2.11.0.

In addition, if child_options and all_services were previously set,
a request was sent per host and service. This is now also only a
single request if an API command transport is requested or only
API command transports are configured.
2021-08-09 16:55:05 +02:00
Johannes Meyer
b94617c575 ServicestatusQuery: Define correct grouping rules for contacts and -groups
fixes #4464
2021-07-21 17:41:55 +02:00
Johannes Meyer
d123b390b1 MonitoredObject: Keep structure of nested cvs during protection
fixes #4439
2021-07-21 08:01:08 +02:00
Johannes Meyer
9c1e4fa491 monitoring: Ensure cvs are also protected in exported results 2021-07-12 09:42:03 +02:00
Johannes Meyer
1dc6f35916 MonitoredObject: Make customvar protection available to the outside 2021-07-12 09:42:03 +02:00
Johannes Meyer
963fdbd3e2 ServicegroupQuery: Join hostgroups with a LEFT JOIN
refs #4404
2021-07-05 14:59:24 +02:00
Johannes Meyer
13125e8059 HostgroupQuery: Join services and servicegroups with a LEFT JOIN
refs #4404
2021-07-05 14:58:49 +02:00
Johannes Meyer
37c982a044 MonitoringWizard: Remove redundant requirements and steps 2021-06-30 18:54:47 +02:00
Johannes Meyer
84949f214e monitoring: Provide health hook 2021-05-14 15:45:35 +02:00
Damiano Chini
89fdccb858 Pass event instead of object to the getHtmlForEvent method of EventDetailsExtensionHook 2021-05-11 12:36:07 +02:00
Johannes Meyer
1a5cedfee1 setup: Skip browser validation when validating a form manually
fixes #4291
2021-04-13 16:57:03 +02:00
Johannes Meyer
a4d495e17c PerfData: Don't render missing values as 0.00 2021-04-13 14:50:18 +02:00
Alexander A. Klimov
6d5024c671 *downtimestarthistoryQuery#joinBaseTables(): don't call func_get_arg() with an invalid index
... as PHP 8 doesn't tolerate that.

refs #4287
2021-04-09 12:37:03 +02:00
Johannes Meyer
fe51f8c968 IdoQuery: Accept any character in custom var names
fixes #4342
2021-04-06 10:47:03 +02:00
Johannes Meyer
0fc06d7795 Transform * equal/unequal comparisons to NULL checks
This comes from https://github.com/Icinga/ipl-sql/pull/31
2021-03-12 09:50:59 +01:00
Alexander A. Klimov
6af1e5d43b Monitoring: add expire option for comments
refs #3447
2020-11-30 17:24:57 +01:00
Rick Henry
92ef10c22b Add notification badges for disabled active checks
We mistakenly disabled active checks in our Icinga environment and did
not notice for some time. This commit hooks into the badge mechanic used
when notifications are turned off, and also provides badges when active
host checks and active service checks are disabled.
2020-11-22 21:18:08 +00:00