Alexander A. Klimov
00880710ed
Navigation::fromArray(): pass $name only as string to addItem()
...
fixes #12923
2016-10-18 18:06:51 +02:00
Noah Hilverling
888ac98007
Response: Improve documentation for method getHeader
...
refs #12161
2016-10-18 11:07:24 +02:00
Noah Hilverling
e5c736aab4
Response: Use method getHeader to check if Content-Type is set already
...
refs #12161
2016-10-18 10:13:58 +02:00
Noah Hilverling
f95c789353
Response: Add method getHeader
...
refs #12161
2016-10-18 09:58:33 +02:00
Noah Hilverling
c927c32442
Response: Only set header Content-Type in method prepare if not already set
...
refs #12161
2016-10-17 16:34:07 +02:00
Noah Hilverling
703561f874
JsonResponse: Set content type at initialization and not at sendHeaders
...
refs #12161
2016-10-17 16:33:51 +02:00
Noah Hilverling
c3276d4341
Response: Remove empty line after method getContentType
...
refs #12161
2016-10-17 16:03:33 +02:00
Noah Hilverling
4df9696ed9
StyleSheet: Modify send method to use setContentType of Response class
...
refs #12161
2016-10-17 08:29:51 +02:00
Noah Hilverling
af5c578adf
Response: Set header Content-Type for every response by default
...
refs #12161
2016-10-14 16:16:13 +02:00
Noah Hilverling
7cf6b860b5
Response: Add contentType attribute
...
refs #12161
2016-10-14 16:12:47 +02:00
Jennifer Mourek
0cd2d98f71
StyleSheet: Don't try to load the icinga default theme
...
refs #12660
2016-10-14 13:24:17 +02:00
Jennifer Mourek
8294471253
Revert "LessCompiler: Remove error message when switching to Icinga theme"
...
This reverts commit 2e24833d7c
.
2016-10-14 09:39:24 +02:00
Jennifer Mourek
2e24833d7c
LessCompiler: Remove error message when switching to Icinga theme
...
fixes #12660
2016-10-14 08:06:05 +02:00
Alexander A. Klimov
8bc7d47a62
Merge branch 'bugfix/preserve-http-response-code-in-rest-error-responses-12583'
...
fixes #12583
2016-10-11 10:46:20 +02:00
Alexander A. Klimov
bf3cfda209
Response: rename setMetaDataFrom() to copyMetaDataFrom()
...
refs #12583
2016-10-11 10:45:15 +02:00
Eric Lippmann
c83659eff7
Sometimes you just herp the derp so hard it herpderps
2016-09-29 16:19:41 +02:00
Alexander A. Klimov
4d16656100
Preserve status code and headers in JSON responses
...
refs #12583
2016-09-27 13:26:20 +02:00
Johannes Meyer
5b875f3749
JsonResponse: Allow to output the "data" key in case of an error
...
As stated by the JSend specification this key is optional for error responses.
2016-09-21 15:58:59 +02:00
Alexander A. Klimov
c8b1693fdc
Fix Controller::assertPermission() allowing everything for unauthenticated requests
...
fixes #12108
2016-09-12 08:18:36 +02:00
Eric Lippmann
ef7be98e0c
Simplify InternalUrlValidator::isValid()
...
refs #11920
2016-09-09 15:22:24 +02:00
Eric Lippmann
1f980f92f2
Optimize imports in InternalUrlValidator
...
refs #11920
2016-09-09 15:21:06 +02:00
Alexander A. Klimov
fa113e023b
dashboard/new-dashlet: don't allow external URLs
...
refs #11920
2016-08-31 15:11:55 +02:00
Eric Lippmann
42991b0756
Ensure correct URL for the refresh container button
...
Shifted params no longer appear in the URL which is retrieved from the request object.
We now use Url::fromRequest() instead.
2016-07-13 10:24:30 +02:00
Johannes Meyer
4774db16ef
View: Add methods setHelperFunction and dropHelperFunction
2016-07-11 09:08:43 +02:00
Eric Lippmann
97451dae86
Merge branch 'bugfix/remove-large-add-to-menu-tab-11850'
...
fixes #11850
2016-06-02 17:57:51 +02:00
hailthemelody@rm-laptop04
188703cf95
fix various typos
...
Signed-off-by: Johannes Meyer <johannes.meyer@netways.de>
2016-06-02 08:24:05 +02:00
Alexander A. Klimov
50037d8ec9
Tabs: fix wrong parameter for array_splice()
...
refs #11850
2016-05-31 14:47:25 +02:00
Alexander A. Klimov
2179c3aaef
FilterEditor: check for a hidden form field instead of the submit button
2016-04-27 15:05:25 +02:00
Alexander A. Klimov
6def061742
FilterEditor: correct submit button name
2016-04-27 12:49:40 +02:00
Alexander A. Klimov
281e6e8163
Revert "Revert "FilterEditor::handleRequest(): don't apply a filter's changes if the 'Apply' button hasn't been pressed""
...
This reverts commit 45a6259b4c
.
2016-04-27 12:46:48 +02:00
Alexander A. Klimov
45a6259b4c
Revert "FilterEditor::handleRequest(): don't apply a filter's changes if the 'Apply' button hasn't been pressed"
...
This reverts commit 61a04e7ba1
.
2016-04-27 12:10:46 +02:00
Marius Hein
6607af61e1
Set dashboard active if it is not disabled
2016-04-26 13:50:02 +02:00
Alexander A. Klimov
eecd15ee68
NavigationItem: fall back to the default renderer if an error occurrs
...
fixes #10486
2016-04-25 15:26:08 +02:00
Alexander A. Klimov
242cdab754
DateTimePicker: implement getFormat()
...
refs #10847
2016-04-18 17:19:57 +02:00
Alexander A. Klimov
61a04e7ba1
FilterEditor::handleRequest(): don't apply a filter's changes if the 'Apply' button hasn't been pressed
...
fixes #10848
2016-04-18 15:15:41 +02:00
Eric Lippmann
be7263ebfa
Fix that only one default dashboard could be removed
...
fixes #11078
2016-04-13 12:27:25 +02:00
Eric Lippmann
7dbcd27c3c
Remove superfluous whitespace
2016-04-13 11:04:54 +02:00
Eric Lippmann
9082a5204e
Fix tab order of refresh and close container controls
2016-04-13 11:04:23 +02:00
Florian Strohmaier
0a9c0925cb
CSS: Add space before the autosubmit info in forms
2016-04-07 12:46:13 +02:00
Eric Lippmann
c7aec8ae64
Respect module stylesheets again when generating the ETag
...
fixes #11465
2016-03-29 11:39:41 +02:00
Markus Frosch
88d973ac39
Restrict access to application log with 'application/log' permission
...
fixes #11279
2016-03-02 20:47:37 +01:00
Eric Lippmann
9c5dfc5207
Merge branch 'bugfix/benchmark-not-always-rendered-10856'
...
fixes #10856
2016-02-27 22:49:44 +01:00
Eric Lippmann
03d7f3a1f4
Ensure trailing slash if cookie path is detected automatically
...
Seems like IE (8, 9, ?) has problems w/o the trailing slash and additional directories on the server that start w/ the path.
refs #11187
2016-02-27 22:42:32 +01:00
Eric Lippmann
5f43ac8f26
Fix path, secure flag and domain of session cookies
...
refs #11187
2016-02-27 22:24:01 +01:00
Eric Lippmann
5f642879c7
Respect cookie domain config in Cookie.php
...
refs #11187
2016-02-27 22:19:37 +01:00
Eric Lippmann
7cef06f981
Disable benchmark only if the layout is disabled
...
Benchmark should be disabled if the response is not HTML. This is most likely the case when the layout is disabled.
If Web 2 or Zend sends JSON for example, the layout is disabled.
The follwing code inside an action disables the layout (and view):
$this->_helper->layout()->disableLayout();
The following code inside an action disables the action's view script:
$this->_helper->viewRenderer->setNoRender(true);
Note that an action's view script is also disabled via setNoRender() when rendering another view script via
render() or renderScript().
Another appraoch is to check the content-type. If explicitly set to not HTML, disable benchmark:
$renderBenchmark = true;
$response = $this->getResponse();
$headers = $response->getHeaders();
foreach ($headers as $header) {
if (strtolower($header['name']) === 'content-type'
&& stristr($header['value'], 'text/html') === false
) {
$renderBenchmark = false;
break;
}
}
if ($renderBenchmark) {
$layout->benchmark = $this->renderBenchmark();
}
Maybe we should also provide a action method for disabling benchmark, regardless of the user's setting.
refs #10856
2016-02-27 20:14:02 +01:00
Eric Lippmann
bf7d082576
Fix PHPDoc of Url::addFilter()
2016-02-27 16:25:04 +01:00
Alexander A. Klimov
5b0730574d
Simplify Url::addFilter()
...
This changes the rendered resulting Url from x&(y&z) to x&y&z.
refs #10778
2016-02-27 16:23:09 +01:00
Eric Lippmann
8433bf1fc1
Don't hide the filter editor from the view if the view is compact
...
refs #10778
2016-02-27 15:57:00 +01:00
Eric Lippmann
d8b14cb772
Control whether a filter editor should be rendered via setVisible()
...
We (may) have situations where a controller or view has to access the filter editor being created via Controller::setupFilterControl().
This is impossible if the view is compact because the filterEditor will be unset. This change introduces FilterEditor::setVisible() for
giving the responsibility of rendering to the filter editor. Controller::setupFilterControl() will be adapted accordingly.
refs #10778
2016-02-27 15:51:13 +01:00