Johannes Meyer
6a3244d8df
Do not show a summary for the MakeDirStep
...
The user does not configure anything this step will process so there is no
need to show the user a summary about something he can't control.
refs #7163
2014-10-29 08:38:59 +01:00
Johannes Meyer
83cfcef85c
Add EnableModuleStep
...
refs #7163
2014-10-29 08:38:59 +01:00
Johannes Meyer
3c438d9221
Allow install steps to return no summary
...
refs #7163
2014-10-29 08:38:59 +01:00
Johannes Meyer
dbf5512252
Drop Icinga\Application\Installation and introduce Icinga\Installation
...
refs #7163
2014-10-29 08:38:59 +01:00
Johannes Meyer
a899070606
Move MakeDirStep to Icinga\Web\Setup
...
refs #7163
2014-10-29 08:38:59 +01:00
Johannes Meyer
dd6b045183
Fix that the ModulePage cant find modules when being asked for
...
refs #7163
2014-10-29 08:38:59 +01:00
Johannes Meyer
98acc24869
Create configuration sub directories as part of the setup wizard
...
refs #7163
2014-10-29 08:38:59 +01:00
Johannes Meyer
1fd4a301c4
Pass the wizard title to the summary page to be able to reuse the page
...
Module wizards can now use the SummaryPage as well if they want to.
refs #7163
2014-10-29 08:38:58 +01:00
Johannes Meyer
3206ded18c
Pass the entire page data to the ModulePage
...
As module wizards might require some configuration values aggregated by
the main application wizard we pass the entire page data to each wizard as
if the data were aggregated by a module wizard itself.
refs #7163
2014-10-29 08:38:58 +01:00
Matthias Jentsch
2e8c0cffe6
Check privileges of database user accounts before continuing with the setup
...
Implement owner and privilege checks for postgresql, and fix some errors in
existing MySQL privilege checks.
resolves #7389
2014-10-27 15:08:52 +01:00
Johannes Meyer
2f83976f50
Add ModulePage
...
refs #7163
2014-10-24 17:10:17 +02:00
Johannes Meyer
851682cf18
Make page count assertion more sensitive
...
refs #7163
2014-10-24 14:06:31 +02:00
Johannes Meyer
1bd5868a88
Fix access of an array key which does not exist in some circumstances
...
refs #7163
2014-10-24 13:57:30 +02:00
Johannes Meyer
03bbc2e2e6
Use a dedicated method to clear a wizard's session
...
Simplifies session removal in case a sub-class of Icinga\Web\Wizard
requires special session handling
refs #7163
2014-10-24 13:55:41 +02:00
Johannes Meyer
a8dd9c933d
Add the possibility for modules to provide a setup wizard
...
refs #7163
2014-10-24 13:52:26 +02:00
Johannes Meyer
64e6886c9c
Make it possible to pass the module paths directly to the module manager
2014-10-24 13:51:23 +02:00
Johannes Meyer
d90d6fe6a9
Improve summary page layout a bit
...
refs #7163
2014-10-23 15:16:25 +02:00
Johannes Meyer
a6cbde54c5
Move summary HTML generation from the view script to each install step
...
refs #7163
2014-10-23 15:15:59 +02:00
Johannes Meyer
216c072024
Implement installation routines modularly
...
This allows us to "merge" module installation
routines with our main installer routines.
refs #7163
2014-10-23 11:41:16 +02:00
Eric Lippmann
f44b0525d8
logging: Fix that setting a numeric log level is flawed
2014-10-23 03:50:03 +02:00
Eric Lippmann
f68c591a46
LDAP Auth: Make group loading really optional
...
fixes #7432
2014-10-23 03:50:03 +02:00
Johannes Meyer
f5c4708ae2
Add a default file mode for new configuration files
...
The file mode which can be configured in the general configuration is now
used when creating new configuration files with the PreservingIniWriter.
2014-10-21 17:02:21 +02:00
Johannes Meyer
a5b10235d2
Add more detail to error messages when token validation fails
...
refs #7163
fixes #7410
2014-10-21 16:10:21 +02:00
Johannes Meyer
8c62c66a4e
Make regular expression pattern in autologin backend being fully optional
2014-10-20 15:14:14 +02:00
Eric Lippmann
424cee6b4a
Auth: Load user groups using the new user group backends
2014-10-20 13:43:40 +02:00
Eric Lippmann
2b67683e00
DbConnection::__construct(): Set prefix if configured
2014-10-20 13:43:03 +02:00
Eric Lippmann
aa56f3010c
lib: Add DbUserGroupBackend
2014-10-20 13:42:33 +02:00
Eric Lippmann
d170cf0c9d
lib: Replace Membership with IniUserGroupBackend
2014-10-20 13:42:15 +02:00
Eric Lippmann
d1228deef2
lib: Add UserGroupBackend as base class and factory for user group backends
2014-10-20 13:41:33 +02:00
Eric Lippmann
79ade944de
Resources: Support type 'ini' yet only in the resources.ini
...
Configuring the resource type 'ini' via the web interface is not yet possible.
2014-10-20 13:40:35 +02:00
Eric Lippmann
cee261bf7e
Use lowercase username and user groups for loading user permissions and restrictions
2014-10-20 13:36:37 +02:00
Johannes Meyer
e72f2cac24
Fix that page information gets deleted when navigating back
...
refs #7163
2014-10-17 15:42:06 +02:00
Johannes Meyer
24b6274f01
Fix logging configuration installation
...
refs #7163
refs #6933
2014-10-17 13:05:56 +02:00
Johannes Meyer
9f127be1dc
Merge branch 'master' into feature/setup-wizard-7163
...
Conflicts:
application/forms/Config/General/LoggingConfigForm.php
2014-10-17 13:04:59 +02:00
Johannes Meyer
a54c81b2a7
Adjust button labels only in WebSetup::addButtons(), not in view scripts
...
refs #7163
2014-10-17 11:20:20 +02:00
Eric Lippmann
6c59c22044
Bootstrap: Remove logging configuration directives which do not override defaults
2014-10-16 15:59:56 +02:00
Eric Lippmann
6dfefb0e73
CLI: Fix logging setup
2014-10-16 15:59:35 +02:00
Eric Lippmann
d2d653209f
Logger/SyslogWriter: Define configuration defaults here
...
Usage of closelog() is optional so I removed the explicit calls.
2014-10-16 15:56:38 +02:00
Eric Lippmann
04a8df54cd
Logger/FileWriter: Rename 'target' directive to 'file'
2014-10-16 15:55:24 +02:00
Eric Lippmann
97677ee2c1
Fix our Logger not supporting named logging levels and requiring the 'enabled' directive
2014-10-16 15:54:13 +02:00
Eric Lippmann
985154d3d8
Throw an ErrorException on E_STRICT errors
2014-10-16 15:51:18 +02:00
Eric Lippmann
a2772a17a7
File: Fix ErrorException::__construct()'s parameters
2014-10-16 15:47:50 +02:00
Johannes Meyer
d73423ceee
Style summary page
...
Dropped also the layout logic as it was too generic.
refs #7163
2014-10-16 14:52:26 +02:00
Johannes Meyer
d1ea7e87a2
Improve form styling slightly
2014-10-15 15:46:07 +02:00
Johannes Meyer
38ee467603
Fix that the session is written too early when post-dispatching
2014-10-15 13:15:30 +02:00
Johannes Meyer
2c09ca1623
Fix that retrieving notifications causes them to be dropped entirely
...
I've broke this when doing some improvements while being
brainless, obviously.
2014-10-15 13:14:51 +02:00
Johannes Meyer
5d44a005a0
Fix that notifications are not registered
2014-10-15 13:02:56 +02:00
Johannes Meyer
45e179d939
Fix that `type' is missing for installed ldap authentication backends
...
refs #7163
2014-10-15 10:44:08 +02:00
Matthias Jentsch
937dbe2c15
Add missing close buttons to views without tabs
2014-10-14 17:54:52 +02:00
Matthias Jentsch
9a9aa84e23
Respect base_dn in LdapUserBackend
2014-10-14 14:37:21 +02:00
Johannes Meyer
b5798331db
Wrap form notifications in <p> by default, not <div>
2014-10-13 09:41:36 +02:00
Johannes Meyer
13678bb33e
Add useful @todo hint
...
refs #7163
2014-10-13 09:35:00 +02:00
Johannes Meyer
52016d81b9
Consider `root_dn' and `base_dn' when installing config files
...
refs #7163
2014-10-13 09:34:22 +02:00
Johannes Meyer
437b41c6c1
Merge branch 'master' into feature/setup-wizard-7163
2014-10-13 08:18:43 +02:00
Johannes Meyer
ca6eca6b67
Quote database names, usernames and passwords when setting up the db
...
refs #7163
2014-10-09 16:02:18 +02:00
Johannes Meyer
78b130a4f3
Fix that the LDAP discovery page is shown for non-LDAP authentication
...
refs #7163
2014-10-09 15:05:21 +02:00
Johannes Meyer
c3404fdc67
Support prepared statements in DbTool::exec and DbTool::query
...
refs #7163
2014-10-09 15:03:51 +02:00
Johannes Meyer
f8f27e046d
Ensure that we advance a wizard when pushing ENTER
...
refs #7163
2014-10-09 13:41:06 +02:00
Johannes Meyer
169a646a1a
Fix that LDAP discovery suggestions are not populated
...
I've broke this when re-commiting the changes made by Matthias and fixed
this by populating dependent pages directly in WebSetup::setupPage.
refs #7163
2014-10-09 10:47:45 +02:00
Matthias Jentsch
e29a568bff
Add LDAP discovery pages
...
refs #7163
2014-10-09 10:20:07 +02:00
Matthias Jentsch
df69fd2264
Make Dns::getSrvRecors being more generic
...
The `target' property of a returned service record is too specific and causes
other properties being ignored.
2014-10-09 10:19:21 +02:00
Matthias Jentsch
dd21b7b5d1
Make sure that we work only with arrays when handling LDAP groups
2014-10-09 10:14:42 +02:00
Matthias Jentsch
04e83a53c5
Add `base_dn' directive to LDAP backend config
2014-10-09 10:10:09 +02:00
Eric Lippmann
cc61dc2b01
Form: Don't override Zend_Form::setDefaults()
...
fixes #7315
2014-10-08 17:43:28 +02:00
Johannes Meyer
1cbe2451a8
Merge branch 'master' into feature/setup-wizard-7163
...
Conflicts:
application/forms/Config/Resource/StatusdatResourceForm.php
2014-10-08 16:34:31 +02:00
Johannes Meyer
7c202dd8fa
Improve the db-summary text and db-creation/-resource step handling
...
refs #7163
2014-10-08 15:36:26 +02:00
Johannes Meyer
8fa8642917
Do not show the db-creation step when the db-resource step was skipped
...
refs #7163
2014-10-08 15:35:12 +02:00
Johannes Meyer
89ae05899b
Query a particular login name and create database logins using the DbTool
...
refs #7163
2014-10-08 15:33:51 +02:00
Johannes Meyer
96ba45d896
Convert password salt to ASCII to avoid encoding issues with PostgreSQL
2014-10-08 15:26:42 +02:00
Alexander Fuhr
4c23d98575
Merge branch 'master' into bugfix/monitoring-list-dup-entries-7057
2014-10-08 12:45:14 +02:00
Alexander Fuhr
afc97b1cac
Fix the duplicate entries in monitoring list shows
...
refs #7057
refs #7344
fixes #7057
2014-10-08 12:30:08 +02:00
Johannes Meyer
baa6abdb00
Relax schema check
...
Checking one table for its existence is more than enough. Creating a diff
implies conditional CREATE TABLE instructions and the like, what we want
to avoid.
refs #7163
2014-10-08 11:24:05 +02:00
Johannes Meyer
393191ced1
Add admin creation routine
...
refs #7163
2014-10-08 10:26:12 +02:00
Johannes Meyer
abc34a5f1a
Add database setup routines
...
refs #7163
2014-10-07 17:08:50 +02:00
Johannes Meyer
7da11b83f5
Fix that the database is displayed instead of the login in the db summary
...
refs #7163
2014-10-07 17:06:51 +02:00
Johannes Meyer
1136a09741
Wrap report message registration in a specific method
...
refs #7163
2014-10-07 17:05:55 +02:00
Johannes Meyer
627a19a2a9
Fix warning "references should be passed by variable"
2014-10-07 15:57:00 +02:00
Eric Lippmann
1b23fd7fbe
monitoring: Don't support status.dat as backend
...
Icinga Web 2 will not support status.dat for now and maybe forever.
2014-10-07 13:22:07 +02:00
Johannes Meyer
d54bfddee4
Silence file_get_contents call
...
Since an earlier change already made the existence of config files not
required we do not care about any E_WARNING or notice emitted by
"file_get_contents".
2014-10-06 16:55:20 +02:00
Johannes Meyer
04ff2e271a
Drop dependent page data more earlier
...
Not only the "setup_authentication_backend" page depends on the auth
type but also the "setup_admin_account" page, so just drop both entries
once a new auth type gets submitted.
refs #7163
2014-10-06 16:52:19 +02:00
Johannes Meyer
ad7965228c
Add install routines for all INI files
...
This is just a quick&dirty implementation. Once we know how modules are
being processed/installed this needs to be revisited.
refs #7163
2014-10-06 16:49:29 +02:00
Johannes Meyer
b50c780bcf
Let the setup's view scripts be a bit more generic
...
refs #7163
2014-10-06 16:04:58 +02:00
Johannes Meyer
ac255eeda0
Change form name of GeneralConfigPage to "setup_general_config"
...
Used to be "setup_application_config".
refs #7163
2014-10-06 13:52:32 +02:00
Alexander Fuhr
421263af00
Make LDAP Groups optional
...
refs #7343
2014-10-06 13:35:17 +02:00
Eric Lippmann
865ef76cb8
filter: Fix whitespace sanitizing
2014-10-06 13:19:25 +02:00
Alexander Fuhr
5143c78f1a
Merge branch 'master' into bugfix/monitoring-list-duplicates-7057
2014-10-06 13:06:56 +02:00
Alexander Fuhr
97d2a920db
Implement GROUP BY clause functionality
2014-10-06 11:34:04 +02:00
Alexander Fuhr
36681bb55a
Add new QueryException
2014-10-06 11:30:48 +02:00
Johannes Meyer
83006c014c
Wrap wizard buttons in a div
...
refs #7163
2014-10-06 11:07:21 +02:00
Eric Lippmann
2956d9e342
form: Correctly set our default element decorators
2014-10-06 10:42:24 +02:00
Eric Lippmann
fa96a1cbbe
Number: Extend our FormElement class
2014-10-06 10:21:17 +02:00
Eric Lippmann
a3409b166d
Note: Extend our FormElement class
2014-10-06 10:21:02 +02:00
Eric Lippmann
9be52a9148
DateTimePicker: Extend our FormElement class
...
fixes #7322
2014-10-06 10:20:26 +02:00
Eric Lippmann
9db76bf371
CsrfCounterMeasure: Save calls to `setRequired()' and `setIgnore()'
2014-10-06 10:19:36 +02:00
Eric Lippmann
8106fe4f79
form: Add `FormElement' as base class for our elements
2014-10-06 10:19:05 +02:00
Johannes Meyer
9cbd7e945d
Do not permit the user to give equal names to multiple resources
...
refs #7163
2014-10-06 09:43:50 +02:00
Johannes Meyer
b4a1364a92
Add summary report
...
refs #7163
2014-10-06 09:30:51 +02:00
Johannes Meyer
f29705fc59
Add summary page
...
refs #7163
2014-10-02 17:11:00 +02:00
Johannes Meyer
0f302bfc0a
Fix form population in case the user navigates backwards to make changes
...
refs #7163
2014-10-02 17:08:55 +02:00
Johannes Meyer
4f52da95ac
Drop page data when skipping a page that was displayed before
...
refs #7163
2014-10-02 16:35:41 +02:00
Alexander Klimov
1a2d15b638
Drop Icinga\Util\Enumerate
2014-10-02 13:59:54 +02:00
Alexander Klimov
051128b967
Icinga\Protocol\File\FileReader: don't use Icinga\Util\Enumerate
2014-10-02 13:59:53 +02:00
Alexander Klimov
e192b939c2
Icinga\Protocol\File\FileIterator: extend EnumeratingFilterIterator
2014-10-02 13:59:52 +02:00
Alexander Klimov
081d8eecfc
Implement abstract class EnumeratingFilterIterator
2014-10-02 13:59:51 +02:00
Alexander Fuhr
017d4b8c9d
Introduce Groups from LDAP to User Object
2014-10-01 16:03:42 +02:00
Johannes Meyer
a980184eb9
Move css instructions to dedicated stylesheet
...
refs #7163
2014-10-01 15:46:58 +02:00
Johannes Meyer
464fefa578
Fix exception in case the database access credentials are invalid
...
refs #7163
2014-10-01 15:44:43 +02:00
Matthias Jentsch
ed91e119d2
Add close-button to all containers
...
refs #6216
2014-10-01 14:51:51 +02:00
Eric Lippmann
74bd9b319d
restrictions: Include restriction's section name in user restrictions
2014-10-01 14:08:21 +02:00
Eric Lippmann
64d41ac5a3
filter: Make `DbQuery::applyFilterSql()' public
...
I want to use that function in a module :)
2014-10-01 12:51:28 +02:00
Johannes Meyer
8f79e0a713
Fix warning "references should be passed by variable only"
2014-10-01 09:17:48 +02:00
Johannes Meyer
08d259eccf
Add database creation page
...
refs #7163
2014-10-01 09:16:53 +02:00
Eric Lippmann
bbee06b57f
form: Ignore note elments when retrieving values at form level
2014-10-01 08:18:34 +02:00
Eric Lippmann
fa9bd59565
lib: Support `isset()' and `empty()' checks on CLI params
2014-10-01 08:17:35 +02:00
Eric Lippmann
084691570e
permissions: Use a comma-separated list as config instead of the `permission_*' directives
...
Permissions are now set using a comma-separated list of permissions using the `permissions' config because
the `users' and `groups' are comma-separated lists too.
2014-10-01 08:14:03 +02:00
Eric Lippmann
ebde422824
filter: Fix whitepsace sanitation when expression is an array
2014-10-01 04:00:43 +02:00
Eric Lippmann
46078f50db
filter: Fix that leading and trailing whitespaces for columns and expressions let filters fail
...
Before, filtering for "host = localhost" issued "got invalid column host".
2014-10-01 03:13:27 +02:00
Eric Lippmann
1c7eb0d59a
lib: Introduce function `String::cname()'
2014-09-30 22:34:58 +02:00
Matthias Jentsch
8eb7db9b35
Avoid type warning when using array_combine on empty arrays
2014-09-30 15:54:38 +02:00
Johannes Meyer
c78b016d74
Remove boiler plate code
2014-09-30 10:26:10 +02:00
Johannes Meyer
7b01525456
Fix that navigation buttons have labels
...
refs #7163
refs #7320
2014-09-29 16:42:38 +02:00
Johannes Meyer
513d5e30a4
Merge branch 'master' into feature/setup-wizard-7163
2014-09-29 16:16:12 +02:00
Johannes Meyer
ab8436dea8
Fix Icinga\Web\Form\Element\Note using its default decorators
2014-09-29 16:12:38 +02:00
Alexander Fuhr
dacbd329dd
Translator: Implement domain fallback for translate and translatePlural
2014-09-29 15:56:48 +02:00
Johannes Meyer
cbadaa78d6
Merge branch 'master' into feature/setup-wizard-7163
2014-09-29 15:35:52 +02:00
Johannes Meyer
28d16a8961
Add web setup
...
Page config and dependency handling is implemented and works like a
charm. Though there is one known bug that occurs when navigating back,
taking changes and moving onward to a page that needs to update its
state due to the changes while adding some elements that have similar
names as the ones shown before. This is only an issue with hidden elements.
refs #7163
2014-09-29 14:30:34 +02:00
Johannes Meyer
2d24828230
Add web installer
...
Logic is still missing and follows later.
refs #7163
2014-09-29 14:23:42 +02:00
Johannes Meyer
4a14dc5916
Add interface for setup wizards
...
refs #7163
2014-09-29 14:19:05 +02:00
Johannes Meyer
5d6391242c
Add interface for installers
...
refs #7163
2014-09-29 14:18:50 +02:00
Johannes Meyer
929344e68b
Add container to store and handle installation requirements
...
refs #7163
2014-09-29 12:25:29 +02:00
Johannes Meyer
aa17f2828d
Add utility to ease working with databases without the use of Zend
...
refs #7163
2014-09-29 12:24:56 +02:00
Johannes Meyer
7c53e6f7be
Improve page permission handling
...
refs #7163
2014-09-29 11:31:59 +02:00
Johannes Meyer
5c13a19b1a
Populate a wizard page in case the user moves backwards
...
refs #7163
2014-09-29 11:31:13 +02:00
Johannes Meyer
73b41769e7
__toString() should call __toString() as well if possible
...
There may be cases that an error occurs and another _toString()
implementation handles that appropriately. This is such a case.
2014-09-29 11:28:58 +02:00
Johannes Meyer
3107eb87bb
Silence stat() call
2014-09-29 11:24:59 +02:00
Johannes Meyer
5b3d549e5c
Add some more platform related calls
...
refs #7163
2014-09-29 11:21:56 +02:00
Johannes Meyer
8fcf21a6b8
Make it possible to retrieve a list of available users for authentication
...
refs #7163
2014-09-29 11:21:40 +02:00
Alexander Fuhr
b2f12e1caa
Revert "lib: Remove form element `Note'"
...
This reverts commit c21d7d1fdd
.
2014-09-26 16:19:44 +02:00
Alexander Fuhr
c8a24f72b8
Introduce getValue() in Preferences and fix the loading of values
2014-09-26 14:15:50 +02:00
Johannes Meyer
8e48853f4d
Add Wizard
...
This is a container/controller for form based wizards. Can be used directly
or by using a subclass that allows for a more customized handling.
refs #7163
2014-09-24 10:46:36 +02:00
Johannes Meyer
028a6c442b
Fix persisting notification messages in the session
2014-09-24 10:46:35 +02:00
Johannes Meyer
635b802a2b
Add tests for hasChanged, set/getByRef and fix setByRef
2014-09-24 10:46:35 +02:00
Johannes Meyer
6f988cb94c
Remove method write() from Icinga\Web\Session\SessionNamespace
2014-09-24 10:46:35 +02:00
Johannes Meyer
c00dbf9f46
Write session on response
...
There should not be any necessity to write the session once changes are
being made to it. We now track whether changes were made and write
the session when responding to the user's request if so.
2014-09-24 10:46:35 +02:00
Johannes Meyer
7fcd665aaa
Fix value invalidation in Icinga\Web\Session\SessionNamespace
2014-09-24 10:46:35 +02:00
Johannes Meyer
efab6c7827
Add method set/getByRef to Icinga\Web\Session\SessionNamespace
2014-09-24 10:46:35 +02:00
Johannes Meyer
c772787967
Re-add TokenValidator
...
refs #7163
2014-09-24 10:46:35 +02:00
Eric Lippmann
cde3ec6bc8
Merge branch 'master' into bugfix/commands-6593
...
Conflicts:
modules/monitoring/application/controllers/TimelineController.php
2014-09-23 22:54:17 -07:00
Alexander Fuhr
07a4b25560
Merge branch 'master' into bug/history-notification-time-format-6980
2014-09-23 11:38:24 +02:00
Alexander Fuhr
e784aa34b6
Implement DateTimeRenderer and fix history time format
...
refs #6980
2014-09-23 11:36:09 +02:00
Matthias Jentsch
6c8f324dd4
Add filter widget to StateHistorySummary and fix some minor bugs
...
fixes #6979
2014-09-19 17:41:44 +02:00
Matthias Jentsch
4ce71ef2f2
Display a tooltip on days without events
2014-09-19 17:41:44 +02:00
Matthias Jentsch
6f1cb6f1f3
Adjust brightness for different event type colors
2014-09-19 17:41:44 +02:00
Matthias Jentsch
65203fddcf
Add additional state history filters for time interval and event type
2014-09-19 17:41:44 +02:00
Matthias Jentsch
ef2f332869
Do not refresh a container when form input was changed or a form element is focused
...
Listen for changes in form elements and abort all reloads that contain a form with
at least one changed form element. Do not refresh containers that contain a focused form
element, except of elements with autofocus, to preserve form elements with a dropdown.
Only focus autofocus elements when there is currently no other selection.
refs #7146
refs #5537
fixes #7162
2014-09-19 15:48:44 +02:00
Eric Lippmann
264d818133
Do not save config references in the `ActionController'
...
This is redundant because our `Config' class already caches loaded configs.
2014-09-19 14:44:21 +02:00
Eric Lippmann
119e23e79e
Make `InlinePie's setters fluent
2014-09-19 14:43:25 +02:00
Eric Lippmann
90dbcdbbfb
The stupid `DbQuery::isTimestamp()' hack must return false
...
This a fix for modules using our query / filter combination since `return $this;' renders all columns as timestamps.
2014-09-19 14:29:29 +02:00
Eric Lippmann
bea110d0c7
Fix `Form::isSubmitted()' for dynamic submit labels
2014-09-19 14:27:04 +02:00
Eric Lippmann
5b5f553d0d
form: Fix dynamic submit label retrieval
2014-09-19 13:39:38 +02:00
Eric Lippmann
c13823d406
bootstrap: Fix error reporting level not including E_STRICT
2014-09-19 13:19:24 +02:00
Eric Lippmann
c51b05296e
Merge branch 'master' into bugfix/commands-6593
2014-09-19 13:18:47 +02:00
Eric Lippmann
3c9859a0f1
Call `Form::getSubmitLabal()' in `Form::addSubmitButton()'
...
This allows us to dynamically define submit labels in form subclasses.
2014-09-19 13:00:15 +02:00
Eric Lippmann
5ba96c32f9
`Form::setDefaults()' fix strict standards violation
...
Declaration of Icinga\Web\Form::setDefaults() should be compatible with that of Zend_Form::setDefaults().
2014-09-19 12:59:01 +02:00
Eric Lippmann
7eb51f6367
form/csrf: Set the csrf element decorators in the element not in the form
2014-09-19 12:57:53 +02:00
Eric Lippmann
f1d3b72f05
autologin: Fix externally-authenticated users still being authenticated after external authentication is disabled
...
The if condition for revoking authentication if the username changed relied on having the `$_SERVER' variable set which was used for authentication.
Authentication is now revoked if the username changed or external authentication is no longer in effect.
refs #6462
2014-09-18 15:20:46 +02:00
Eric Lippmann
854e284d42
autologin: Don't use `count()' for is empty checks
...
Using `count()' in favor of `empty()' for empty checks on arrays is bad habit.
While there's literally no performance gain in the "fixed" scenario, there's one on large arrays
and thus should be avoided everywhere.
refs #6462
2014-09-18 15:18:01 +02:00
Eric Lippmann
794910256a
Use `User::can()' in `hasPermission()' of the authentication manager
2014-09-18 14:57:24 +02:00
Eric Lippmann
af58732545
Introduce `User::can()' for checking whether a user has a given permission
...
The authentication manager already has the `hasPermission()' method but it lacks wildcard support
and uses stupid looping. Implementing this method on the user further saves a call to `User::getPermissions()'.
2014-09-18 14:37:18 +02:00
Eric Lippmann
d091e2150c
Fix `ActionController::prepareInit()' php doc
2014-09-16 18:43:14 +02:00
Alexander Fuhr
b38ef9c0bd
Implement plural and context based translation functionality
...
refs #6982
2014-09-16 15:19:23 +02:00
Eric Lippmann
c21d7d1fdd
lib: Remove form element `Note'
...
Zend already provides this.
2014-09-16 09:54:23 +02:00
Eric Lippmann
5c647719e4
lib/ModuleActionController: Fix stupid code
2014-09-16 09:29:03 +02:00
Eric Lippmann
f8edb4f220
lib: Add method `ActionController::prepareInit()'
...
As it should not be required for controllers to call the parent's init() method, base controllers should use
prepareInit() in order to prepare the controller initialization.
2014-09-16 09:28:10 +02:00
Alexander Fuhr
e2b5e05f21
Implement plural translation (testing)
2014-09-15 14:11:42 +02:00
Eric Lippmann
8bf66425d1
Merge branch 'master' into bugfix/commands-6593
2014-09-15 09:27:56 +02:00
Eric Lippmann
9e0d6657b7
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
...
Conflicts:
application/forms/Preference/GeneralForm.php
2014-09-15 09:27:07 +02:00
Alexander Fuhr
f48094f01a
Merge branch 'master' into feature/translation-plurals-6982
2014-09-15 08:34:19 +02:00
Matthias Jentsch
1932a912f8
Fix month-naming for different week arrangements
...
fixes #7179
2014-09-12 11:51:51 +02:00
Matthias Jentsch
6c3c466f92
Start history grid weeks at monday
...
Add configuration option for week-start and set the default to Monday.
2014-09-12 11:51:51 +02:00
Matthias Jentsch
e42b7b3026
Display current weeks at the beginning of the history grid
...
fixes #7179
2014-09-12 11:51:51 +02:00
Eric Lippmann
beecf16ad0
lib: Add `InvalidPropertyException'
2014-09-12 10:18:48 +02:00
Thomas Gelf
8ceef96d28
Web\Hook: remove unused methods
2014-09-12 09:53:38 +02:00
Thomas Gelf
93777ac15e
Web/Response: use & to encode XHR redirection URLs
2014-09-12 09:28:11 +02:00
Matthias Jentsch
ad53f7ad3d
Use EventEmitter class as a way to delegate events from behaviors to the dom
2014-09-12 09:09:21 +02:00
Thomas Gelf
0e926ba05e
Revert "Revert "Web\Hook: register('grapher')
...
This reverts commit 65564cda65
.
The test was wrong, not the code.
2014-09-12 09:02:23 +02:00
Alexander Fuhr
583fd46f15
Experimental Plural Translation Implementation
...
Personal BACKUP
2014-09-11 18:04:10 +02:00
Alexander Fuhr
65564cda65
Revert "Web\Hook: register('grapher') => GrapherHook"
...
This reverts commit 4a89c2e163
.
2014-09-11 15:00:28 +02:00
Matthias Jentsch
9376ceed33
Add missing use-statement for Exceptions in MenuRenderer
...
fixes #7157
2014-09-10 17:12:19 +02:00
Matthias Jentsch
f58da73e2d
Move javascript behaviors into separate classes
2014-09-10 17:02:39 +02:00
Matthias Jentsch
d99d50b3c4
Add stub for javascript behaviors
2014-09-10 17:02:38 +02:00
Thomas Gelf
ea63dad087
viewHelpers: use the view
...
refs #7177
2014-09-10 16:56:26 +02:00
Thomas Gelf
631b3d9f6e
viewHelpers: There is no $this, not before 5.4
...
refs #7177
2014-09-10 16:54:57 +02:00
Thomas Gelf
c2fe0232ca
helpers/attributes: escape value
...
refs #7177
2014-09-10 16:07:00 +02:00
Matthias Jentsch
27960fc628
Catch exceptions in MenuItemRenderers
...
fixes #7157
2014-09-10 14:38:11 +02:00
Johannes Meyer
83772c6684
Merge branch 'master' into bugfix/rebuild-form-builder-5525
2014-09-09 16:03:22 +02:00
Matthias Jentsch
71f55e388f
Only display custom menu renders on XHR requests and not in regular HTML
...
The main navigation should be rendered without a working backend.
fixes #7143
2014-09-09 15:33:42 +02:00
Johannes Meyer
e7c021845d
Simplify subform usage
...
refs #5525
2014-09-09 15:00:33 +02:00
Johannes Meyer
9d8f810e10
Icinga\Web\Request::getParam() should be mocked as well by default
2014-09-09 13:01:09 +02:00
Johannes Meyer
d6377ca00c
Return bootstrap mock when calling BaseTestCase::setupIcingaMock()
2014-09-09 10:19:51 +02:00
Johannes Meyer
f7f6bcc447
Make Form base class more test friendly..
...
refs #5525
2014-09-09 09:31:15 +02:00
Johannes Meyer
c8ce1088c9
Disable checking whether a form is sent when form identification is disabled
...
refs #5525
2014-09-09 09:30:33 +02:00
Johannes Meyer
34bbe6508a
Remove form test functionality from BaseTestCase
...
BaseTestCase::createForm() is not required as the Form base class does
not have that much bloat anymore to have the need for a form factory.
2014-09-09 09:29:29 +02:00
Johannes Meyer
1137c010a8
Provide global request and response mocks
...
Prior to this change one had to overwrite setupIcingaMock or setUp to set
a specific mock as request or response. Now it is possible to do this for a
specific test without overwriting any method.
2014-09-09 09:24:38 +02:00
Matthias Jentsch
a352131d65
Move charts.less into widgets.less
...
Don't use a separate less file for only two styles
2014-09-08 16:25:11 +02:00
Matthias Jentsch
40611659ed
Fix disappearing tooltips on SVG reload
...
Use a unified linebreak in the chart controller, so the tooltip handling will recognize the titles as identical
2014-09-08 16:23:14 +02:00
Matthias Jentsch
0fd561928a
Remove cached version of dompdf log.htm from source control
2014-09-08 16:22:15 +02:00
Alexander Fuhr
7386ae5ef5
Update Module img_ route to get image subfolders
2014-09-08 11:31:05 +02:00
Matthias Jentsch
e8164c6da0
Show tooltips to describe menu badges
2014-09-08 10:38:02 +02:00
Eric Lippmann
0e7ca591ec
Merge branch 'master' into bugfix/commands-6593
...
Conflicts:
application/forms/Preference/GeneralForm.php
application/views/helpers/FormDateTime.php
modules/monitoring/application/forms/Command/CommandForm.php
2014-09-08 10:16:05 +02:00
Matthias Jentsch
e39dd64a1b
Fix layout of HistoryColorGrid
...
Use actual color for critical hosts and only display the first two letters of the weekday
2014-09-08 09:52:28 +02:00
Johannes Meyer
12b4865559
Fix incompatible declaration of Form::setDefaults()
...
PHP with strict standards: Declaration of Icinga\Web\Form::setDefaults()
should be compatible with that of Zend_Form::setDefaults()
refs #5525
2014-09-08 09:42:02 +02:00
Johannes Meyer
930e6e7d71
We shouldn't require Form::createElements() to return self
...
refs #5525
2014-09-08 09:24:53 +02:00
Johannes Meyer
ae9e5a40cc
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Preference/GeneralForm.php
2014-09-08 08:46:53 +02:00
Thomas Gelf
4a89c2e163
Web\Hook: register('grapher') => GrapherHook
2014-09-05 18:54:50 +02:00
Matthias Jentsch
51d14af154
Merge branch 'master' into feature/navigation-unhandled-badges-7114
...
Conflicts:
library/Icinga/Web/Menu.php
2014-09-05 18:14:29 +02:00
Matthias Jentsch
19eca5f50b
Show all unhandled host and services in a menu
...
Add the option to define custom renderers for menu items and implement renderers to
display all unhandled services and host in a badge in the navigation.
resolves #7114
2014-09-05 17:57:20 +02:00
Thomas Gelf
596800bd7d
helpers/url: overwrite existing params
2014-09-05 17:56:55 +02:00
Thomas Gelf
4bb065d9bb
Web\Menu: provide and render unique id
...
fixes #7083
2014-09-05 17:24:55 +02:00
Thomas Gelf
b034028ff8
Menu: do not show application log when none exists
...
Added new functions to the logger to get rid of distributed logging config
"knowledge".
fixes #7062
fixes #7098
2014-09-05 15:31:30 +02:00
Marius Hein
a300877878
Time detection: Add receiever to bootstrap method
...
refs #6078
2014-09-05 15:24:13 +02:00
Marius Hein
3ce42489c6
Timezone detection: Client implementation
...
refs #6078
2014-09-05 15:24:13 +02:00
Thomas Gelf
e205ca4d0b
FilterWidget: remove icon titles
...
fixes #7105
2014-09-05 14:50:22 +02:00
Alexander Klimov
52c1d98beb
Icinga\Protocol\File\FileReader: use Icinga\Util\Enumerate
2014-09-05 13:49:28 +02:00
Alexander Klimov
982cda6805
Implement Icinga\Util\Enumerate
2014-09-05 13:49:27 +02:00
Thomas Gelf
33d2175b77
Web\UrlParams: allow to merge single value
2014-09-05 13:35:51 +02:00
Thomas Gelf
baa775dd74
Web\Url: document with() method
2014-09-05 11:40:43 +02:00
Thomas Gelf
1c2207f51d
Web\Url: provide a with() function
2014-09-05 11:21:10 +02:00
Thomas Gelf
4c8407e2b6
Web\StyleSheet: outer #layout access for modules
...
fixes #7093
2014-09-05 10:56:26 +02:00
Thomas Gelf
b14e7f5696
LessCompiler: remove obsolete cache-related comment
2014-09-05 10:56:25 +02:00
Johannes Meyer
fc72ddfbc8
Adjust Preferences/GeneralForm to use handleRequest() &. Co.
...
refs #5525
2014-09-05 10:21:24 +02:00
Johannes Meyer
d021747bde
Fix form widgets
...
refs #5525
2014-09-05 09:17:09 +02:00
Johannes Meyer
8846f17ae1
Make it possible to disable form identification
...
refs #5525
2014-09-05 09:16:09 +02:00
Alexander Fuhr
ba623d0544
SearchDashboard: adjust SearchDashboardTest and rename searchQuery to searchString
2014-09-04 22:54:41 +02:00
Thomas Gelf
0f7f2f2d8b
SearchDashboard: rename ::load() to ::search()
...
Function signature didn't match parent factory function
fixes #7081
2014-09-04 19:35:31 +02:00
Thomas Gelf
0f8d5bddba
Web\Menu: make use of Web\Url
...
refs #7083
2014-09-04 19:18:09 +02:00
Thomas Gelf
f91892cb80
Web\Url: add matches() function
...
fixes #6992
2014-09-04 18:46:58 +02:00
Alexander Fuhr
e4d1143870
Add SearchDashboardTest
2014-09-04 18:31:08 +02:00
Alexander Klimov
70146c43e7
Icinga\Protocol\File\FileReader: implement Icinga\Data\Selectable, and Countable
2014-09-04 16:59:37 +02:00
Alexander Klimov
3c4a719feb
Revert "Icinga\Protocol\File\FileReader: implement Icinga\Data\Selectable, ...\Fetchable and Countable"
...
This reverts commit 7edbb8f27216e6faa0d0dc5a71b407748e9dd535.
2014-09-04 16:55:02 +02:00
Alexander Klimov
876b94cccf
Icinga\Protocol\File\FileReader: implement Icinga\Data\Selectable, ...\Fetchable and Countable
2014-09-04 16:54:14 +02:00
Alexander Klimov
f0969e0b2e
Split Icinga\Protocol\File\FileReader into ...\FileReader and ...\FileIterator
2014-09-04 16:37:26 +02:00
Alexander Klimov
fcd12073f8
Rename Icinga\Protocol\File\Query to ...\File\FileQuery
2014-09-04 16:37:25 +02:00
Alexander Klimov
36a3c36c1b
Rename Icinga\Protocol\File\Reader to ...\File\FileReader
2014-09-04 16:37:24 +02:00
Alexander Fuhr
1eacde0233
Implement modules self provided search configuration
...
refs #6495
2014-09-04 16:31:10 +02:00
Marius Hein
c8eaf66823
GrapherHook: Rework hook
...
refs #6932
2014-09-04 14:00:48 +02:00
Marius Hein
4fb47ef768
Hook classes: Add class suffix if not exist
...
refs #7066
refs #7067
refs #7068
2014-09-04 14:00:48 +02:00
Matthias Jentsch
eeed030bb5
Do not use an invalid HTML attributes for rich titles
2014-09-04 13:32:30 +02:00
Eric Lippmann
c3c0043307
Merge branch 'master' into bugfix/commands-6593
2014-09-03 23:23:20 +02:00
Eric Lippmann
a4da3b61b3
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
2014-09-03 23:23:02 +02:00
Alexander Klimov
2eccc6188f
Merge branch 'master' into bugfix/rebuild-application-log-logic-7060
2014-09-03 19:08:40 +02:00
Alexander Klimov
ede5b8f0b9
Icinga\Protocol\File\Reader::fetchPairs(): increase $index manually as the iterator's one makes trouble
...
refs #7060
2014-09-03 18:36:59 +02:00
Matthias Jentsch
da85112538
Merge branch 'master' into feature/svg-chart-tooltips-7024
2014-09-03 17:08:00 +02:00
Matthias Jentsch
37b168995b
Rename tipsy stylesheet file type to css and add license
2014-09-03 17:01:07 +02:00
Alexander Klimov
e45f50408a
Icinga\Protocol\File\Reader::fetchPairs(): rename variables
...
$skipLines -> $skip
$readLines -> $read
refs #7060
2014-09-03 16:14:14 +02:00
Matthias Jentsch
b10b1ea034
Add jQuery tooltips
2014-09-03 15:53:56 +02:00
Alexander Klimov
88dde47b7a
Foreach: add $value so that the value won't be assigned to $key
...
refs #7060
2014-09-03 15:39:25 +02:00
Eric Lippmann
2025fb3a2f
lib: Let the date-and-time input control behave as defined in HTML5
...
refs #6593
2014-09-03 14:40:58 +02:00
Alexander Fuhr
acbd2bd7c0
Merge branch 'master' into feature/dashboard-component-disabled-property-6986
2014-09-03 14:40:30 +02:00
Eric Lippmann
906de4e679
lib: Add the HTML5 attributes 'min', 'max' and 'step' to the number input control
...
refs #6593
2014-09-03 14:39:42 +02:00
Eric Lippmann
774db9a7c8
lib: Add function `isUnixTimestamp' to the `DateTimeFactory'
...
Before, the `DateTimeValidator' defined this function.
refs #6593
2014-09-03 14:37:33 +02:00
Eric Lippmann
1a4e908461
lib: Let `DateTimeValidator' validate values as defined in HTML5
...
See http://www.w3.org/TR/html-markup/datatypes.html#common.data.datetime for the specification.
refs #6593
2014-09-03 14:36:18 +02:00
Alexander Fuhr
7cfc051228
Add tests for Dashboard and fix doc blocks
...
refs #6986
2014-09-03 14:36:04 +02:00
Alexander Klimov
33669f8969
Logger: add/update documentation
...
refs #7060
2014-09-03 13:53:46 +02:00
Johannes Meyer
54a834266c
Form::createElements() should add elements instead of returning them
...
In case createElements() would still return the elements while requiring
the caller to add them to the form all form dependent configurations get
lost. (displaygroups, belongTo, ...) Wizards or parent forms can still
retrieve only input relevant fields by just calling createElements() and
getElements().
refs #5525
2014-09-03 12:21:31 +02:00
Alexander Klimov
1e06c20dcb
FileWriter: implement getPath()
...
refs #7060
2014-09-03 12:09:38 +02:00
Alexander Klimov
6aeab59ead
Logger: implement getWriter() and getInstance()
...
refs #7060
2014-09-03 12:02:11 +02:00
Alexander Klimov
70cf14f775
Logger: rename getWriter() -> createWriter()
...
refs #7060
2014-09-03 11:34:21 +02:00
Alexander Klimov
3ade6da44d
FileReaderException: extend IcingaException
2014-09-03 11:14:22 +02:00
Thomas Gelf
3d352ba446
Filter: add FilterNotEqual and FilterMatch
...
fixes #6557
2014-09-02 19:51:56 +02:00
Eric Lippmann
0b1d2bf685
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
2014-09-02 17:09:36 +02:00
Eric Lippmann
5485ca8a25
lib: Use Zend's `Int' validator in the `Number' form element
...
Further disabled default decorators since our form sets them.
refs #5525
2014-09-02 16:54:43 +02:00
Thomas Gelf
b60b811335
ApplicationBootstrap: list "core" translations
...
Just to make application fit module capabilities. We might find a better
place for both later on.
refs #7054
2014-09-02 16:51:17 +02:00
Johannes Meyer
95c839a8bd
Remove remaining usages of the ElementWrapper- and HelpText-Decorator
...
refs #5525
2014-09-02 16:50:59 +02:00
Thomas Gelf
6faedf5733
ActionController: no benchmark for no renderer
...
Benchmarks should not be shown when the renderer is no longer available.
2014-09-02 16:49:28 +02:00
Thomas Gelf
4cef333add
Modules\Module: implement listLocales
...
fixes #7054
2014-09-02 16:28:27 +02:00
Thomas Gelf
e4687a60f9
Web\JavaScript: use Cache and ETags
...
refs #6927
2014-09-02 16:25:44 +02:00
Johannes Meyer
1ba3df310c
Remove BaseConfigController, User\Message and Widget\AlertMesageBox
...
refs #6758
2014-09-02 16:25:03 +02:00
Johannes Meyer
539ab91ffa
Add the FormErrors decorator as default decorator for forms
...
This allows us to use Zend_Form::addError() to show error messages for
the entire form context.
refs #5525
2014-09-02 16:25:03 +02:00
Thomas Gelf
f0d6cf994e
Web\StyleSheet: use Cache and ETags
2014-09-02 16:24:55 +02:00
Thomas Gelf
ff6483cec5
Web\FileCache: initial implementation
...
refs #6927
2014-09-02 16:22:48 +02:00
Johannes Meyer
338f549233
Add class ReadablePathValidator
2014-09-02 16:19:45 +02:00
Johannes Meyer
39bb01b433
Rename Icinga\Web\Form::onShow() to onRequest()
...
onShow() is misleading because at the time this method is being called the
form is neither shown nor created.
refs #5525
2014-09-02 16:19:45 +02:00
Eric Lippmann
9bcd861b1c
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
2014-09-02 15:27:27 +02:00
Eric Lippmann
d4c4ab7b2c
lib/form: Fix default element decorators but breaking noscript layout
...
Replaced `ElementWrapper' and `HelpText' with Zend's `HtmlTag' and `Label' respectively.
Instances of Zend_Form_Element returned by `Form::createElements()' now receive our desired default decorators.
refs #5525
2014-09-02 15:23:07 +02:00
Eric Lippmann
8478ef3fce
lib: Remove `HelpText' form element decorator
...
Zend already has a `Description' decorator.
refs #5525
2014-09-02 15:05:47 +02:00
Eric Lippmann
7143837ae3
lib: Remove `ElementWrapper' form element decorator
...
Zend has a `Label' decorator already.
refs #5525
2014-09-02 15:04:23 +02:00
Thomas Gelf
62c0f0be03
Web\Session: implement lazy loading
...
fixes #7055
2014-09-02 13:23:15 +02:00
Alexander Fuhr
26339b128a
Add disabled property and implement the functionality
...
refs #6986
2014-09-02 13:16:21 +02:00
Matthias Jentsch
4b55bcf8b6
Add tooltips to bar charts
...
Add a class to format and populate tooltips from graph data sets and implement
those tooltips in the ChartController.
2014-09-02 12:24:29 +02:00
Alexander Fuhr
bb0e1dc105
Revert "Fixes unaccepted behavior in module configuration"
...
This reverts commit 236d384bab
.
2014-09-02 10:23:41 +02:00
Marius Hein
ee6145a173
Ldap/Query: Remove __toString()
...
This is needed because of exception handling. Exceptions can now bubble
up for default handling. Method render() was renamed to create() because
the method create a query. Adjust the test for method create().
refs #5536
2014-09-02 10:17:01 +02:00
Marius Hein
baf768040f
LdapQuery: Use Ldap/Exception for errors
...
refs #5536
2014-09-02 09:55:57 +02:00
Marius Hein
6b6826f737
Bug7043Test: Fix test to run without ini configuration
...
fixes #7043
2014-09-01 15:53:32 +02:00
Johannes Meyer
cd8015f41a
Pass the current form instance to the callback as second argument
...
refs #5525
2014-09-01 14:58:16 +02:00
Eric Lippmann
30965c247b
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
2014-09-01 14:50:32 +02:00
Eric Lippmann
0822aff293
library/form: Fix return value of `getName()' not being filterd the first time it's called
...
`Form::getName()' auto-detects the form's name if it's not set and sets the form's name using `Zend_Form::setName()'.
`Zend_Form::setName()' then filters the form name stripping backslash '\' characters. The first call to `Form::getName()'
did not regard the filtering and thus returned the unfiltered name which led to `Form::wasSent()' returning `false'.
refs #5525
2014-09-01 14:40:45 +02:00
Marius Hein
30f391035c
Postgres/DbQuery: Add orderfields to select
...
refs #6896
2014-09-01 10:00:04 +02:00
Eric Lippmann
f3e74f0f24
library/form: Append class 'autosubmit' in case the element to autosubmit has the class attribute set
...
Before, the class attribute would've been overwritten.
refs #5525
2014-09-01 09:44:04 +02:00
Eric Lippmann
a01ee00c27
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
...
Conflicts:
library/Icinga/Protocol/Commandpipe/Transport/Transport.php
2014-08-29 17:24:44 +02:00
Johannes Meyer
fb5685bac3
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Config/Authentication/BaseBackendForm.php
application/forms/Config/Authentication/DbBackendForm.php
application/forms/Config/Authentication/LdapBackendForm.php
application/forms/Config/Authentication/ReorderForm.php
application/forms/Config/LoggingForm.php
application/forms/Config/ResourceForm.php
application/forms/Preference/GeneralForm.php
library/Icinga/Application/Config.php
library/Icinga/Web/Form.php
modules/monitoring/application/controllers/ConfigController.php
modules/monitoring/application/forms/Config/Backend/CreateBackendForm.php
modules/monitoring/application/forms/Config/Instance/CreateInstanceForm.php
modules/monitoring/application/forms/Config/Instance/EditInstanceForm.php
modules/monitoring/application/forms/Config/SecurityForm.php
2014-08-29 16:05:56 +02:00
Johannes Meyer
e020dd3541
Icinga\App..\Config: Rename __construct to fromIni and add setConfigPath
...
Prior to this change it was not possible to create an instance of Config
without passing a config file.
2014-08-29 12:23:48 +02:00
Johannes Meyer
79b0ed64ec
Make it possible to provide a closure to be called instead of onSuccess()
...
This allows us to write generic forms like the ConfirmRemoval form but to
utilize handleRequest() while providing a closure in the array that is passed
to a form's constructor.
refs #5525
2014-08-29 12:21:31 +02:00
Johannes Meyer
bf23688e73
Make autosubmit work in non-JS enviroments
...
We require forms to set autosubmit=true on elements which are supposed
to be submitted automatically now. The base form then ensures that this
works in JS environments and non-JS environments as well by applying the
right changes to the HTML.
refs #5525
2014-08-29 09:08:53 +02:00
Johannes Meyer
486104d59e
Check explictly for FALSE when calling onSuccess()
...
This allows us to just end onSuccess() without requiring it to return TRUE
to initiate redirection.
refs #5525
2014-08-29 09:04:20 +02:00
Matthias Jentsch
3642b7b6fc
Adjust CSS for inlinePies to be centered on the current line
2014-08-28 18:27:30 +02:00
Matthias Jentsch
a26370bb12
Adjust PieCharts that are rendered without labels
...
Center and resize PieCharts to use the full width and height of the available view port
2014-08-28 18:25:19 +02:00
Matthias Jentsch
00a2d225a2
Ensure that PieCharts are centered and that labels dont leave the viewBox
...
Add scaling and transformations to move the PieChart into a valid coordinate system and reduce the offset of the labels to make more efficient use of available space.
2014-08-28 16:42:31 +02:00
Matthias Jentsch
c5cface661
Improve readability of small pie charts
...
Use a bigger font, to ensure that small pie charts still have readable labels.
2014-08-28 16:40:34 +02:00
Matthias Jentsch
98809a1447
Do not use width and height as width and height percentages in the outer SVG element
...
Height and width are solely used to define the SVGs ratio and should not cause side effects on the SVGs size in the site context.
2014-08-28 16:37:21 +02:00
Matthias Jentsch
a9eec0d672
Remove useless width and height properties from PieChart
2014-08-28 16:33:38 +02:00
Matthias Jentsch
f77cd9cafa
Fix coding guidelines
2014-08-28 16:21:16 +02:00
Matthias Jentsch
573a4ea12f
Fix spelling mistakes
2014-08-28 16:14:59 +02:00
Eric Lippmann
4ca1eaa7ce
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
...
Conflicts:
library/Icinga/Web/Form.php
modules/monitoring/application/forms/Config/SecurityForm.php
2014-08-28 13:58:02 +02:00
Marius Hein
e345aa257a
Platform: Drop *Available function
...
Create a function extensionLoaded and change usages.
refs #5514
2014-08-28 12:14:55 +02:00
Marius Hein
9d0037a53a
ResourceFactory: Add function create(<name>)
...
The ConfigAwareFactory is an interface forcing "backend-type" classes to call
ResourceFactory::createResource() passing a config they got in the constructor.
That's kind of overdesigned, if the ResourceFactory wants to be something like
a service locator it's responsabilities should include object instantiation.
refs #5514
2014-08-28 12:14:54 +02:00
Marius Hein
35d11bd145
Class doc for Platform
...
refs #5514
2014-08-28 12:14:54 +02:00
Marius Hein
9b83074cc9
Class doc for ResourceFactory
...
refs #5514
2014-08-28 12:14:54 +02:00
Marius Hein
22e17e9901
ResourceFactory: Move available function to platform
...
refs #5514
2014-08-28 12:14:54 +02:00
Matthias Jentsch
947cd0c5d3
Merge branch 'master' of git.icinga.org:icingaweb2
...
fixes #7006
2014-08-27 17:22:09 +02:00
Alexander Klimov
e6612fefe7
FilterParseException: extend IcingaException
...
refs #6931
2014-08-27 16:26:43 +02:00
Alexander Klimov
afd0c20c42
FilterException: extend IcingaException
...
refs #6931
2014-08-27 16:23:44 +02:00
Alexander Klimov
45638b218c
Throw IcingaException rather than Exception
...
fixes #7014
2014-08-27 16:03:15 +02:00
Alexander Klimov
7ff51caed0
Remove leading backslashes from the targets of use statements
...
- use \Exception;
+ use Exception;
2014-08-27 15:51:49 +02:00
Alexander Fuhr
236d384bab
Fixes unaccepted behavior in module configuration
...
fixes #7011
2014-08-27 14:57:08 +02:00
Matthias Jentsch
4a59ff6712
Support preserveAspectRatio in SVGRenderer
...
Add support for the preserveAspectRatio attributes in root SVG elements, to improve the handling of padding and automatic resizing of inline SVG.
2014-08-27 13:51:52 +02:00
Johannes Meyer
e1329058db
Do not hard code the name of the form identification element
...
Like the csrf element name the form identification element name should
be publicly accessible as well.
refs #5525
2014-08-27 13:14:40 +02:00
Eric Lippmann
1dea19504f
Revert "Remove leading backslashes from the targets of use statements"
...
This reverts commit 87a5967501
.
At least 'modules/doc/run.php' issues a warning about "The use statement with non-compound name 'Zend_Controller_Router_Route' has no effect"
2014-08-27 12:24:11 +02:00
Marius Hein
88698cb05d
Hook/TopBar: Rework interface for monitoring top bar
...
refs #6929
2014-08-27 11:31:48 +02:00
Marius Hein
b7ae66b496
Hook: Add web hook base class
...
refs #6929
2014-08-27 11:31:47 +02:00
Marius Hein
e0d7c3855d
Hook: Add class suffix for base class testing
...
refs #6928
2014-08-27 11:31:47 +02:00
Alexander Klimov
87a5967501
Remove leading backslashes from the targets of use statements
...
- use \Exception;
+ use Exception;
2014-08-27 11:16:44 +02:00
Marius Hein
5abf41edef
Hook/ConfigurationTab: Remove deprecated implementation
...
ConfigurationTab hook is not used anywhere. Test is
removed also.
2014-08-27 10:29:04 +02:00
Johannes Meyer
6783d51f76
A form is "submitted" when it was "sent" but no submit label was set
...
This enables us to use handleRequest() as is when no specific submit button
is required.
refs #5525
2014-08-27 10:28:50 +02:00
Johannes Meyer
0ff79b0948
Replace Form::onFailure() with Form::onShow()
...
There is currently no usecase for onFailure() but for onShow() wherewith
the case is covered when a form needs to be prepared before showing it
to the user while the form was not submitted in any way.
refs #5525
2014-08-27 10:25:50 +02:00
Johannes Meyer
d3c2fc858c
Access formdata internally using a public helper method
...
This way concrete form implementations can also simply fetch form
dependent request values without referring to the form's submission
method.
refs #5525
2014-08-27 10:19:33 +02:00
Johannes Meyer
65dd3f9a5b
Make the form in view scripts accessible using $form instead of $element
...
refs #5525
2014-08-27 10:10:55 +02:00
Johannes Meyer
98b2bce15e
Icinga\Web\Form::onSuccess() must not return TRUE
...
When using Icinga\Web\Form directly without creating a specific sub-class
and calling handleRequest() one must not get redirected.
refs #5525
2014-08-27 10:09:29 +02:00
Marius Hein
89541f5727
Merge branch 'bugfix/hook-interface-6932'
...
fixes #6932
fixes #6928
2014-08-27 09:39:56 +02:00
Marius Hein
7e5b5a0b30
Hook/Grapher: Rework hook interface
...
Rework interface based on specification and changed consumer calls.
refs #6932
2014-08-27 09:35:43 +02:00
Matthias Jentsch
1ff63dbf3f
Support nested keys expressed as single strings in the PreservingIniWriter
...
Automatically convert keys with dots into nested configurations to avoid errors during the property diff, of the old and new configuration file.
2014-08-26 18:05:22 +02:00
Eric Lippmann
6b88f1c98e
Move Commandpipe/* classes from Icinga Web 2's library to the monitoring module
...
refs #6593
2014-08-26 16:35:30 +02:00
Matthias Jentsch
ff1d2e4fed
Fix coding style
2014-08-26 15:20:15 +02:00
Goran Rakic
23aa57a5d7
Remove 100% pie slice hack
...
The getPieSlicePath primitive can draw it now.
2014-08-26 15:20:15 +02:00
Goran Rakic
2575634dec
Draw full circle pie slice (100%) as a primitive
...
Allows getPieSlicePath to draw a full circle pie slice (100%) by slightly adjusting endpoint to have a valid arc. Also hides a central line as there will be no more pie slices.
2014-08-26 15:20:15 +02:00
Marius Hein
376e9aa160
Rename hook base classes
...
Adding suffix "Hook" to every base class. This simplifies development
because you don't need to alias bases classes in your concrete
hook classes
refs #6928
2014-08-26 14:29:55 +02:00
Johannes Meyer
45cbd3f067
We do not require the request being passed to handleRequest()
...
refs #5525
2014-08-26 12:31:05 +02:00
Johannes Meyer
5c7999fe9b
Forms should be responsible for any redirection as well
...
If no specific url has been set with setRedirectUrl() a form redirects to the
current action it was posted to.
refs #5525
2014-08-26 12:30:37 +02:00
Alexander Klimov
1f7d4cb61b
Merge branch 'master' into bugfix/exceptions-with-printf-params-6931
2014-08-26 11:24:33 +02:00
Alexander Klimov
a2011b1665
SystemPermissionException: extend IcingaException
...
refs #6931
2014-08-26 11:21:57 +02:00