13644 Commits

Author SHA1 Message Date
Johannes Meyer
b3eeb5a892 php: Don't lint tests on PHP 5.6 2021-04-09 12:38:43 +02:00
Johannes Meyer
e671324ddb tests: Don't use deprecated assertion assertRegExp() 2021-04-09 12:38:43 +02:00
Johannes Meyer
f27e872d90 tests: Don't make use of deprecated phpunit features 2021-04-09 12:38:43 +02:00
Johannes Meyer
bc1c967dec BaseTestCase: Inherit from Mockery\Adapter\Phpunit\MockeryTestCase 2021-04-09 12:38:43 +02:00
Johannes Meyer
cb87190138 tests: Add :void return type declarations 2021-04-09 12:38:43 +02:00
Johannes Meyer
19a092c13f php: Don't test on PHP 5.6 through 7.1 2021-04-09 12:38:39 +02:00
Alexander A. Klimov
eff10ec613 ApplicationBootstrap#setupErrorHandling(): migrate error handler to PHP 8
... as recommended here:
https://www.php.net/manual/de/migration80.incompatible.php

refs #4287
2021-04-09 12:37:03 +02:00
Alexander A. Klimov
6d5024c671 *downtimestarthistoryQuery#joinBaseTables(): don't call func_get_arg() with an invalid index
... as PHP 8 doesn't tolerate that.

refs #4287
2021-04-09 12:37:03 +02:00
Alexander A. Klimov
2990ca09ab GitHub actions: test also with PHP 8.0
refs #4287
2021-04-09 12:37:03 +02:00
Alexander A. Klimov
2c5f141cc1 /setup/: ensure not to pass an empty array to max()
... as PHP 8 doesn't tolerate such.

refs #4287
2021-04-09 12:37:03 +02:00
Johannes Meyer
f782c08d80 RoleForm: Highlight set privileges in headers
resolves #4241
2021-04-08 10:13:24 +02:00
Johannes Meyer
6f317ade30
Merge pull request #4336 from Icinga/feature/audit-view-3053
Audit View
2021-04-08 08:50:21 +02:00
Johannes Meyer
8e2ae13885 role/audit: Show a message if no suggestions are found 2021-04-07 16:03:05 +02:00
Johannes Meyer
54acd6b4c8 role/audit: Group suggestions by backend name 2021-04-07 16:02:31 +02:00
Johannes Meyer
b48f7f3489 role/audit: Don't use class EmptyState, it's from icingadb web 2021-04-07 16:00:01 +02:00
Johannes Meyer
0d35a1774d SingleValueSearchControl: Add failure message for empty results 2021-04-07 15:59:03 +02:00
Johannes Meyer
a6507daaaf SingleValueSearchControl: Allow to pass html as labels 2021-04-07 15:58:25 +02:00
Johannes Meyer
d49962ac82 role/audit: Pre-populate backend name with the first one found
Otherwise a user who doesn't use a suggestion will see an error.
2021-04-07 15:10:01 +02:00
Johannes Meyer
5b970c79ad role/audit: Use role-audit as id instead of role/audit
Since HTML5 nearly any char is allowed in ids, including the slash,
but jQuery doesn't support the slash as part of css selectors...
2021-04-07 14:30:14 +02:00
Johannes Meyer
314ec5256c PrivilegeAudit: Show missing initiators in inheritance paths 2021-04-07 14:30:14 +02:00
Johannes Meyer
b5334a063e PrivilegeAudit: Show missing restrictions if only parents restrict 2021-04-07 14:30:14 +02:00
Johannes Meyer
65cfa9236c role/[add|edit|remove]: Set __CLOSE__ as redirect target
The form is also reachable through the audit view now. This
results in the correct handling in either of both views.
2021-04-07 14:30:14 +02:00
Johannes Meyer
fa2c3c8999 role/audit: Give the privilege audit an explicit (non-protected) id 2021-04-07 14:30:14 +02:00
Johannes Meyer
bab10899a2 role/audit: Fix layout on mobile devices
Not perfect, but enough for now.
2021-04-07 14:30:14 +02:00
Johannes Meyer
698e7bcfa4 SingleValueSearchControl: Show magnifier icon in the text input 2021-04-07 14:30:14 +02:00
Johannes Meyer
9db50eb75b css: Enhance layout of inline forms 2021-04-07 14:30:14 +02:00
Johannes Meyer
e288ccd713 css: Don't override padding of all inputs in controls
inputs are expected to have their own padding and if
that doesn't suit everywhere, they have to be adjusted.
Overriding padding and such stuff this generally is bad.
This also solves the problem that the filter editor
search field is missing its specific padding, yay. -.-
2021-04-07 14:30:14 +02:00
Johannes Meyer
68f101b015 RoleForm: Don't let privilege labels break on dashes 2021-04-07 14:30:14 +02:00
Johannes Meyer
be227fd61d roles/audit: Utilize view Icinga\Web\View\PrivilegeAudit 2021-04-07 14:30:14 +02:00
Johannes Meyer
074f08db4e Introduce view Icinga\Web\View\PrivilegeAudit 2021-04-07 14:30:14 +02:00
Johannes Meyer
f31b1569aa css: Add new mixin .user-select() 2021-04-07 14:30:14 +02:00
Johannes Meyer
ce1fed1b1d css: Use specific colors to represent grants, refusals and restrictions 2021-04-07 14:30:14 +02:00
Johannes Meyer
ab90b3e0a1 Role: Add param $cascadeUpwards also to public method grant() 2021-04-07 14:30:14 +02:00
Johannes Meyer
c203ffdd79 role|user|group: Open Audit tab always in #col1 and close #col2 2021-04-07 14:30:14 +02:00
Johannes Meyer
ab7d73a8ee RoleForm: Add static method collectProvidedPrivileges()
Was previously part of method `init()`. Split up into its
own method to allow external usage.
2021-04-07 14:30:14 +02:00
Johannes Meyer
9d10424f97 AdmissionLoader: Set additional user information assigned_roles 2021-04-07 14:30:14 +02:00
Johannes Meyer
8ff88cd6f1 role/audit: Require a backend name for user audits 2021-04-07 14:30:14 +02:00
Johannes Meyer
f4da973f68 Auth: Only reload CSS upon login if the theme **really** changed
fixes #2233
2021-04-07 14:30:14 +02:00
Johannes Meyer
0aa4e25723 Auth: Introduce method setupUser()
This was previously part of method `setAuthenticated()`.
Split up to allow external usage.
2021-04-07 14:30:14 +02:00
Johannes Meyer
1fbd76ef69 role/audit: Also allow to audit groups 2021-04-07 14:30:14 +02:00
Johannes Meyer
153e9b4ade SingleValueSearchControl: Add support for groups and meta data 2021-04-07 14:30:14 +02:00
Johannes Meyer
05fdd98ba8 role/audit: Add input to choose a user 2021-04-07 14:30:14 +02:00
Johannes Meyer
42bdbe38b1 Introduce class Icinga\Web\Widget\SingleValueSearchControl 2021-04-07 14:30:14 +02:00
Johannes Meyer
fe7879c68b group|role|user: Add new tab role/audit 2021-04-07 14:30:14 +02:00
Johannes Meyer
a4a658974d AuthBackendController: Inherit from ipl\Web\Compat\CompatController 2021-04-07 14:30:14 +02:00
Johannes Meyer
fe51f8c968 IdoQuery: Accept any character in custom var names
fixes #4342
2021-04-06 10:47:03 +02:00
Johannes Meyer
867b2af12d pdf: Include <base> tag in PDF layout
This forces the browser (in case of the pdfexport module)
to perform a network request. Otherwise there's no way
(currently) to know what the browser does or cannot do.
File resource loading isn't logged through the CDP.
2021-03-31 16:39:19 +02:00
Johannes Meyer
a8be92c245 loader.js: Still apply some accessibility changes..
..if a renderHook discards an autorefresh. There is
unfortunately no way to distinguish between a renderHook
that really discards changes or one that applies them
on the DOM itself. If it's the first, this change
*shouldn't* hurt. If it's the latter, users should
benefit.
2021-03-31 12:38:35 +02:00
Johannes Meyer
e65ec1900a js: Add new special redirect target __CLOSE__
This has the same effect as a normal redirect. The benefit of it however
is that the server doesn't need to know what's being shown in the left
column. It just instructs the client to close the right and refresh the
left column. But still produces a new history state, it's a forward
navigation nonetheless.
2021-03-30 13:25:40 +02:00
Johannes Meyer
d0642587e4
Merge pull request #4341 from Icinga/fix/quick-search-double-encodes-query-values-4321
Don't double encode query param values when using the quick search
2021-03-30 10:37:41 +02:00