Jannis Moßhammer
03cc43a3f6
Merge branch 'bugfix/missing-doc-4547-4548'
...
fixes #4546
fixes #4548
2013-09-04 13:55:08 +02:00
Eric Lippmann
68585b98b5
Doc: Add DateTimePicker documentation
...
refs #4547
2013-09-04 13:54:45 +02:00
Eric Lippmann
9c73802ce6
Doc: Add Testing Singletons paragraph
...
refs #4548
2013-09-04 13:54:45 +02:00
Jannis Moßhammer
4658405990
Merge branch 'bugfix/module-namespace-4586'
...
fixes #4586
2013-09-04 11:25:58 +02:00
Eric Lippmann
1b858cbdb4
Monitoring: Fix remaining usages of namespace Monitoring without Icinga\Module prefix
...
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
3e4d1aa2fb
Monitoring/Tests: Replace BaseFormTest with BaseTestCase
...
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
6f383abdd1
Tests: Let the BaseTestCase require db and form libraries once it's being required
...
Further add function t() and mt() to the global namespace when requiring BaseTestCase
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
e3044b8b62
Tests/Monitoring: Remove ScheduleDowntimeFormTest since it's being refactored in another branch
...
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
a89631fd92
Tests/Monitoring: Remove useless test ConfirmationFormTest
...
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
74b9731df5
Remove auto class requirement from BaseTestCase::createForm()
...
The tests for the respective forms must require the form class.
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
092c5780ea
CS: Fix violations for overdue files
...
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
8a062ff3e5
Fix tests after renaming the namespace
...
refs #4586
2013-09-04 11:21:12 +02:00
Eric Lippmann
c86874d4ba
Rename namespace Monitoring to Icingæ\Module\Monitoring
...
refs #4586
2013-09-04 11:21:11 +02:00
Eric Lippmann
03f081ce33
Module/Autoloader: Register Icinga\Module\<module> namespace
...
refs #4586
2013-09-04 11:21:11 +02:00
Jannis Moßhammer
67fcb09a89
Merge branch 'bugfix/proper-datetime-validation-4581'
...
fixes #4581
2013-09-04 11:06:51 +02:00
Jannis Moßhammer
a0e63a1320
Fix error message and move validation in own DateTimeValidator
...
refs #4581
refs #4632
2013-09-04 11:06:36 +02:00
Johannes Meyer
4d040fd761
Adjust command forms and tests
...
Made those command forms using the DateTimePicker
element compatible with its new validation.
refs #4581
2013-09-04 11:06:36 +02:00
Johannes Meyer
14b56151aa
Move configuration and preference handling to Form base class
...
Moved setConfiguration, setUserPreferences and getUserPreferences
to our Form base class due to some redundancies.
refs #4581
2013-09-04 11:06:24 +02:00
Johannes Meyer
86d721c317
Merge branch 'bugfix/proper-datetime-validation-4581'
...
fixes #4581
fixes #4632
2013-09-03 09:27:39 +02:00
Johannes Meyer
23f0962da1
Adjust command forms and tests
...
Made those command forms using the DateTimePicker
element compatible with its new validation.
refs #4581
2013-09-03 09:27:02 +02:00
Johannes Meyer
368bd3c9c7
Refactor datetime validation
...
The DateTimePicker form element needs to know from now on,
how user input can be formatted when validating.
refs #4581
2013-09-03 09:27:02 +02:00
Johannes Meyer
1a003f8c8b
Move configuration and preference handling to Form base class
...
Moved setConfiguration, setUserPreferences and getUserPreferences
to our Form base class due to some redundancies.
refs #4581
2013-09-03 09:27:02 +02:00
Eric Lippmann
30e36f1e09
Merge branch 'bugfix/pagination-fixes-4589'
...
fixes #4589
fixes #4591
fixes #4572
2013-09-02 18:43:16 +02:00
Eric Lippmann
b09b3676de
Rename determineAuthenticationState to requiresLogin
...
refs #4572
2013-09-02 18:42:05 +02:00
Jannis Moßhammer
9f923b4940
Fix pagination and remove ModuleController, rename handlesAuth
...
This commit introduces the following changes:
- Count is now performed after joins are added to the selection query,
therefore returning the correct number
- MonitoringControllerTest now needn't to mock ModuleActionController (which is now removed)
- handlesAuthentication is now requiresAuthentication
- Redirection to login is now directly handled in the ActionController constructor,
so we don't need to overwrite the preDispatch method
refs #4589
refs #4591
refs #4572
2013-09-02 18:42:05 +02:00
Jannis Moßhammer
aac1d69ed2
Fix count query ignoring joins
...
Count queries were created before the required columns were added,
so they often returned more values than a resultset really offers
refs #4589
2013-09-02 18:42:05 +02:00
Jannis Moßhammer
cce217c7c2
Merge branch 'bugfix/correct-check-result-type-distinction-4600'
...
fixes #4600
2013-09-02 17:24:53 +02:00
Johannes Meyer
d8eccd3858
Skip regression tests if no configuration available
...
refs #4600
refs #4666
2013-09-02 17:24:43 +02:00
Johannes Meyer
01d7ea39aa
Fix error when initiating multiple logins with casperjs
...
refs #4600
2013-09-02 17:24:43 +02:00
Johannes Meyer
24ecbb56d7
Fix incorrect checkresult type selection
...
When submitting a passive checkresult for hosts only their correct
result types are added to the selection.
refs #4600
2013-09-02 17:24:42 +02:00
Jannis Moßhammer
b63e19063e
Merge branch 'bugfix/enable-module-exception-4604'
...
fixes #4604
2013-09-02 13:15:22 +02:00
Marius Hein
b99b9a7ca8
ModuleManager: Throw module dir exceptions later
...
This is important for bootstrap to detect configuration
errors.
refs #4604
2013-09-02 12:52:51 +02:00
Marius Hein
b6eb19ce6a
Module enable/disable: Better error messages
...
refs #4604
2013-09-02 12:52:51 +02:00
Marius Hein
439fade88d
Simplify SystemPermissionException
...
refs #4606
2013-09-02 12:52:51 +02:00
Johannes Meyer
a01559f6e5
Merge branch 'bugfix/log-disable-broken-4595'
...
fixes #4595
2013-09-02 12:16:55 +02:00
Jannis Moßhammer
18d021d104
Fix logger not testing if it's disabled
...
refs #4595
2013-09-02 12:16:05 +02:00
Marius Hein
fff746bdb3
Merge branch 'bugfix/discard-changes-notify-4622'
...
fixes #4622
fixes #4617
2013-09-02 11:19:01 +02:00
Marius Hein
6c59d2cf40
Fix icinga js license header
...
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
6db96bfb8f
CS Fixes: form.js License, comments and deprecated bind()
...
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
c77f4ff1d9
Frontend tests: Run each *.js file seperately
...
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
c7375d44fb
Add regressiontest for this bug
...
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
4d9ecd2b3b
Fix FormTest breaking after onchange modification
...
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
a8b3716662
Fix checkswag not testing jshint correctly
...
The path was wrong, now it is correct.
refs #4617
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
c5fde2324e
Generalize form handling in Icinga\Web Form & Tests
...
configForm.js is now form.js and applied on all forms,
the autosubmit is now a special attribute for input fields,
so the PHP code doesn't create JS snippets anymore
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
978b3519f6
Add configform js component (will be renamed later)
...
refs #4622
2013-09-02 10:59:05 +02:00
Jannis Moßhammer
649dcd434c
Merge branch 'bugfix/fix-auth-manager-4641'
...
fixes #4641
fixes #4590
fixes #4593
2013-08-30 16:31:31 +02:00
Jannis Moßhammer
feab57e790
Fix old constructor syntax being called in DbBackendForm
...
refs #4641
2013-08-30 16:28:13 +02:00
Marius Hein
446da85a88
UserBackend: Fix interface in test
...
refs #4593
2013-08-30 15:32:06 +02:00
Marius Hein
e2e744a424
Fix authentication chain
...
refs #4593
2013-08-30 14:46:52 +02:00
Marius Hein
845f181001
CS: Fix UserBackend interface
...
refs #4641
2013-08-30 12:50:57 +02:00