Commit Graph

452 Commits

Author SHA1 Message Date
Johannes Meyer 2490d0ae67 ConfigController: We're configuring user backends from now on
refs #8826
2015-06-02 09:58:57 +02:00
Matthias Jentsch 4c6a2b4f06 Fix ini writer unit tests
refs #8706
2015-06-01 16:46:52 +02:00
Johannes Meyer ec556edc65 Merge branch 'master' into feature/user-and-group-management-8826 2015-05-26 09:28:35 +02:00
Eric Lippmann 54577d04bd Merge branch 'master' into bugfix/time-formatting-6778
Conflicts:
	modules/monitoring/application/views/scripts/list/comments.phtml
	modules/monitoring/application/views/scripts/list/hostgroups.phtml
	modules/monitoring/application/views/scripts/process/info.phtml
	modules/monitoring/application/views/scripts/show/components/downtime.phtml
	modules/monitoring/application/views/scripts/show/components/notifications.phtml
	modules/monitoring/public/css/module.less
2015-05-21 14:57:01 +02:00
Johannes Meyer fb07f0b94c Merge branch 'master' into feature/user-and-group-management-8826
Conflicts:
	library/Icinga/Authentication/Backend/LdapUserBackend.php
	library/Icinga/Protocol/Ldap/Query.php
2015-05-19 14:14:03 +02:00
Eric Lippmann 5b3957baca Drop the DateTimeRendererTest
refs #6778
2015-05-19 12:46:33 +02:00
Eric Lippmann 15b2e873b2 Drop the DateTimeFactoryTest
refs #6778
2015-05-19 11:27:56 +02:00
Eric Lippmann 82ee1d6e60 Merge branch 'master' into bugfix/significant-whitespaces-8777
Conflicts:
	library/Icinga/Web/Widget/FilterEditor.php
2015-05-18 13:35:28 +02:00
Johannes Meyer c91d3e52ac Merge branch 'master' into feature/user-and-group-management-8826 2015-05-12 15:39:02 +02:00
Alexander Fuhr 891ce0fe57 UserTest: Fix wrong assert condition for wildcard 2015-05-07 17:19:00 +02:00
Johannes Meyer e228404bf4 Adjust ConfigObjectTest as ConfigObjects are not countable anymore
They are of course still indirectly countable, by using Config::count() or
ConfigObject::select()::count().
2015-05-05 15:36:15 +02:00
Alexander Fuhr 612fefba9c Fix the permission wildcards assertion
fixes #9202
2015-05-05 12:36:26 +02:00
Johannes Meyer 9163fb0f0f Drop Icinga\Protocol\Ldap\ConnectionTest
...located at *test*/php/library/Icinga/Protocol/Ldap/.
2015-05-04 13:40:54 +02:00
Johannes Meyer 100d475b58 Fix ldap ConnectionTest
If I ever have to look at this test again, I'll drop it.

refs #8826
2015-05-04 13:25:07 +02:00
Johannes Meyer c441117324 LdapUserBackend: Extend Repository and implement UserBackendInterface
refs #8826
2015-05-04 12:18:25 +02:00
Johannes Meyer 99ac0b78ea DbUserBackend: Extend DbRepository and implement UserBackendInterface
refs #8826
2015-05-04 12:15:05 +02:00
Johannes Meyer 5baa0590b1 Ldap\Query: Extend SimpleQuery and add missing documentation
refs #8826
refs #8955
2015-05-04 11:26:27 +02:00
Johannes Meyer d09ea2845d Merge branch 'master' into feature/user-and-group-management-8826 2015-04-30 15:20:40 +02:00
Johannes Meyer 034421d0cb Fix form tests utilizing Mockery's partial mock functionality
Since an update of Mockery, partial mocks do not call the constructor
of their mocked classes anymore without explicitly passing a non empty
array. This is a regression of the following bug:
https://github.com/padraic/mockery/issues/144
2015-04-30 15:20:19 +02:00
Johannes Meyer adae7b34c1 Fix DbBackendFormTest and LdapBackendFormTest
refs #8826
2015-04-22 10:36:37 +02:00
Eric Lippmann 09acddb3b7 Fix filter tests not taking whitespaces into account
refs #8777
2015-04-08 10:18:42 +02:00
Louis Sautier 083c1a9e6b Fix some spelling errors in comments and messages
fixes #8633

Signed-off-by: Gunnar Beutner <gunnar@beutner.name>
2015-03-08 15:32:22 +01:00
Johannes Meyer 5c371a6d0b Fix form tests 2015-03-04 09:43:37 +01:00
Matthias Jentsch e4f71eacd6 Add unit tests for ldap connection behavior
It is important that we test handling of protocol extensions properly, to prohibit errors that are difficult to reproduce like this in the future.

fixes #7993
2015-02-27 17:11:12 +01:00
Eric Lippmann 6bae2e0a53 Note that our license is GPL v2 or any later version in our license header instead of pointing to the license's URL 2015-02-04 10:52:27 +01:00
Eric Lippmann 5b4fab0750 Add license header
This time without syntax errors hopefully :)
2015-02-03 16:27:59 +01:00
Eric Lippmann 5fa2e3cfdc Revert "Add license header"
This reverts commit 338d067aba.
2015-02-03 16:16:26 +01:00
Eric Lippmann 338d067aba Add license header
fixes #7788
2015-02-03 15:51:04 +01:00
Johannes Meyer 625fa4d738 Use shipped Zend framework in the testsuite as well 2014-11-27 11:37:18 +01:00
Alexander Klimov a3fa31c35a PHP tests: don't require Hamcrest 2014-11-26 13:51:48 +01:00
Marius Hein bfa7320d85 Dashboard: Fix tests
refs #7751
2014-11-20 12:48:05 +01:00
Marius Hein 8c3dbb2b45 Dashbosrd: Fix tests
refs #4537
2014-11-18 17:26:28 +01:00
Johannes Meyer 7621f6642d Adjust usages of Icinga\Application\Config
refs #7147
2014-11-18 13:11:52 +01:00
Johannes Meyer 0c84bf614d Split config functionality into two classes
There is now Icinga\Application\Config as our ini configuration handler and
Icinga\Data\ConfigObject as our general configuration container.

refs #7147
2014-11-18 13:02:56 +01:00
Johannes Meyer ddf2ef5cc9 Remove $request parameter from Form::onSuccess and Form::onRequest
fixes #7552
2014-11-14 14:59:29 +01:00
Johannes Meyer 586b4f463b Let our module autloader know that we renamed our form namespaces
refs #7553
2014-11-14 11:30:44 +01:00
Johannes Meyer 775c20d9ad Rename namespace Icinga\Form to Icinga\Forms
refs #7553
2014-11-14 10:57:14 +01:00
Eric Lippmann ac2ec83852 Merge branch 'master' into feature/localization-form-6073
Conflicts:
	library/Icinga/Application/ApplicationBootstrap.php
	test/php/library/Icinga/User/Store/DbStoreTest.php
2014-11-13 17:03:41 +01:00
Alexander Fuhr b8113b688b Update User\Store\IniStoreTest 2014-11-12 17:13:15 +01:00
Alexander Fuhr 8bb318eb72 Update User\Store\DbStoreTest 2014-11-12 17:12:05 +01:00
Johannes Meyer 7aae291f69 Merge branch 'master' into feature/setup-wizard-7163 2014-11-12 10:08:28 +01:00
Johannes Meyer a6af51f402 Fix that Config::fromSection cannot return the actual value
refs #7147
2014-11-11 15:51:54 +01:00
Matthias Jentsch fdfad34e5c Do not normalize configuration keys to nested arrays in IniWriter
More than one nesting level (the section) is no longer allowed in configuration files. Dots in keys are now
part of the key and will not lead to a nested configuration.

fixes #7120
2014-11-11 15:05:34 +01:00
Johannes Meyer af99f62843 Prefer Icinga\Application\Config over Zend_Config
refs #7163
2014-11-11 12:11:14 +01:00
Johannes Meyer 9d292269b1 Merge branch 'master' into feature/setup-wizard-7163
Conflicts:
	application/forms/Config/Resource/LdapResourceForm.php
	test/php/application/forms/Config/Authentication/LdapBackendFormTest.php
2014-11-11 09:44:11 +01:00
Johannes Meyer 7b99b74ae1 Prefer Icinga\Application\Config instead of Zend_Config
refs #7147
2014-11-07 13:53:03 +01:00
Johannes Meyer 4537b2932e Fix that current(), key(), etc does not work with Config objects 2014-11-07 13:37:09 +01:00
Johannes Meyer 83f386f92a Do not extend Zend_Config in Icinga\Application\Config
refs #7147
fixes #7580
2014-11-06 15:41:31 +01:00
Johannes Meyer 170ded6510 Merge branch 'master' into feature/setup-wizard-7163
Conflicts:
	library/Icinga/Authentication/Backend/LdapUserBackend.php
	library/Icinga/File/Ini/IniWriter.php
2014-11-04 14:22:53 +01:00
Eric Lippmann b38e3affb9 Move INI writer classes to the File namespace
fixes #7150
2014-10-31 10:54:53 +01:00
Eric Lippmann 16352fc10c Move Logger to the Application namespace
fixes #7148
2014-10-31 10:27:17 +01:00
Johannes Meyer c1bff9a26e Merge branch 'master' into feature/setup-wizard-7163 2014-10-30 10:38:21 +01:00
Eric Lippmann 1b83ec3ce2 Preferences: Fix saving preferences when using a database store
Our DbSelect::where() is not (or no longer?) compatible w/ Zend_Db_Select::where().
DbStore::load() now uses Zend_Db_Select but we should definitely think about our
DbSelect::where() implementation.

fixes #7353
2014-10-30 09:49:21 +01:00
Johannes Meyer 9f127be1dc Merge branch 'master' into feature/setup-wizard-7163
Conflicts:
	application/forms/Config/General/LoggingConfigForm.php
2014-10-17 13:04:59 +02:00
Eric Lippmann 501aca42b9 Logger: Fix the StreamWriterTest 2014-10-16 15:58:37 +02:00
Johannes Meyer 1cbe2451a8 Merge branch 'master' into feature/setup-wizard-7163
Conflicts:
	application/forms/Config/Resource/StatusdatResourceForm.php
2014-10-08 16:34:31 +02:00
Eric Lippmann ebde422824 filter: Fix whitepsace sanitation when expression is an array 2014-10-01 04:00:43 +02:00
Eric Lippmann 56a1af47e7 filter: Add test for whitespace sanitizing 2014-10-01 03:23:06 +02:00
Johannes Meyer cbadaa78d6 Merge branch 'master' into feature/setup-wizard-7163 2014-09-29 15:35:52 +02:00
Johannes Meyer 07d25e8bed Fix form tests 2014-09-29 12:56:36 +02:00
Johannes Meyer 0e92e333aa Make isValid* calls of configuration forms being static
This allows a more flexible usage as there is no need to access instance
formdata when validating such configuration.
2014-09-29 11:02:45 +02:00
Alexander Fuhr c8a24f72b8 Introduce getValue() in Preferences and fix the loading of values 2014-09-26 14:15:50 +02:00
Johannes Meyer 635b802a2b Add tests for hasChanged, set/getByRef and fix setByRef 2014-09-24 10:46:35 +02:00
Johannes Meyer 6f988cb94c Remove method write() from Icinga\Web\Session\SessionNamespace 2014-09-24 10:46:35 +02:00
Eric Lippmann cde3ec6bc8 Merge branch 'master' into bugfix/commands-6593
Conflicts:
	modules/monitoring/application/controllers/TimelineController.php
2014-09-23 22:54:17 -07:00
Alexander Fuhr 07a4b25560 Merge branch 'master' into bug/history-notification-time-format-6980 2014-09-23 11:38:24 +02:00
Alexander Fuhr e784aa34b6 Implement DateTimeRenderer and fix history time format
refs #6980
2014-09-23 11:36:09 +02:00
Eric Lippmann c51b05296e Merge branch 'master' into bugfix/commands-6593 2014-09-19 13:18:47 +02:00
Eric Lippmann af58732545 Introduce `User::can()' for checking whether a user has a given permission
The authentication manager already has the `hasPermission()' method but it lacks wildcard support
and uses stupid looping. Implementing this method on the user further saves a call to `User::getPermissions()'.
2014-09-18 14:37:18 +02:00
Eric Lippmann d10afa1f9b Remove the command pipe tests 2014-09-17 12:59:45 +02:00
Eric Lippmann f640874865 monitoring: Fix DateTimePicker test 2014-09-17 12:40:41 +02:00
Alexander Fuhr 0be8b97e88 Extend TranslatorTest with new tests
refs #6982
2014-09-16 16:14:07 +02:00
Eric Lippmann 8bf66425d1 Merge branch 'master' into bugfix/commands-6593 2014-09-15 09:27:56 +02:00
Thomas Gelf 3a5415f7c8 test/Web/Hook: refactor without mocks
Mocks made no sense here. Also introduced a "new" way of naming test
functions. Output now looks as follows:

s\Icinga\Web\Hook
 [x] Knows which hooks are registered
 [x] Correctly handles multiple instances
 [x] Returns null for invalid hooks
 [x] Returns null for failing hook
 [x] Checks whether created instances inherit base classes
 [x] Throws errors for instances not inheriting base classes
 [x] Creates identical instances only once
 [x] Returns an empty array with no registered hook
2014-09-12 09:07:27 +02:00
Johannes Meyer 0693e7cf2d Fix ResourceForm tests
refs #5525
2014-09-09 13:06:30 +02:00
Johannes Meyer 40947acd16 Fix, rename and move ReorderFormTest
refs #5525
2014-09-09 12:02:51 +02:00
Johannes Meyer 7dbc83e21f Drop obsolete BaseBackendFormTest
refs #5525
2014-09-09 11:58:07 +02:00
Johannes Meyer e4fccdd150 Fix DbBackendFormTest
refs #5525
2014-09-09 10:39:49 +02:00
Johannes Meyer 31978e1236 Fix LdapBackendFormTest
refs #5525
2014-09-09 10:36:42 +02:00
Johannes Meyer cee3c32fa5 Fix dashboard tests utilizing BaseTestCase::setupIcingaMock() 2014-09-09 10:21:37 +02:00
Johannes Meyer a5c027b77c Fix UrlTest utilizing BaseTestCase::setupIcingaMock() 2014-09-09 10:21:09 +02:00
Johannes Meyer 6525d6933a Add test for Icinga\Web\Form
refs #5525
2014-09-09 09:40:49 +02:00
Alexander Fuhr ab71b1cf1c Update TranslatorTest: adjust systemwide locales order 2014-09-05 10:53:56 +02:00
Alexander Fuhr ba623d0544 SearchDashboard: adjust SearchDashboardTest and rename searchQuery to searchString 2014-09-04 22:54:41 +02:00
Thomas Gelf 0f7f2f2d8b SearchDashboard: rename ::load() to ::search()
Function signature didn't match parent factory function

fixes #7081
2014-09-04 19:35:31 +02:00
Thomas Gelf dd943c3aa7 Web\UrlTest: test the new matches() function
refs #6992
2014-09-04 18:59:22 +02:00
Thomas Gelf 97cfeaa3df SessionNamespaceTest: expect the correct exception 2014-09-04 18:39:02 +02:00
Thomas Gelf 3d170f90a5 TranslatorTest: expect the correct exception 2014-09-04 18:39:02 +02:00
Thomas Gelf 0cc024a30a DateFormatTest: disable it as it is broken 2014-09-04 18:39:02 +02:00
Thomas Gelf 5314e57b0f ResourceFormTest: disable, messed up 2014-09-04 18:39:02 +02:00
Alexander Fuhr e4d1143870 Add SearchDashboardTest 2014-09-04 18:31:08 +02:00
Thomas Gelf 4513ab2aed GraphChartTest: match current implementation
We have more nodes right now as of a graphical hack (white bg)
2014-09-04 17:57:02 +02:00
Thomas Gelf 5a29315ee8 Web\UrlTest: make tests fit current implementation
* temporarily disable [] tests
* getAbsoluteUrl uses & and not &amp; by default
* __toString uses & and does not match getAbsoluteUrl by default
* addParams MUST hide existing ones, getValues still ships them

fixes #6604
2014-09-04 17:35:55 +02:00
Marius Hein 0935a8e340 DateFormatTest: Remove dependencies to global/user config
refs #6077
2014-09-04 16:02:10 +02:00
Alexander Fuhr 1d81211427 Move DashboardTest in correct directory
resf #6986
2014-09-03 15:13:16 +02:00
Thomas Gelf 65fb246b7e FilterTest: fix complex filter example
The filter in the test was not a valid filter.

fixes #7069
2014-09-03 15:03:24 +02:00
Alexander Fuhr acbd2bd7c0 Merge branch 'master' into feature/dashboard-component-disabled-property-6986 2014-09-03 14:40:30 +02:00
Alexander Fuhr 7cfc051228 Add tests for Dashboard and fix doc blocks
refs #6986
2014-09-03 14:36:04 +02:00
Johannes Meyer 3f9cb00b1f Fix DbBackendFormTest not creating a valid ResourceFactory mock object
refs #7063
2014-09-03 10:00:41 +02:00
Johannes Meyer 8e5deb8029 Fix TranslatorTest not expecting the default locale as being "available"
refs #7063
2014-09-03 10:00:04 +02:00