c42c7977be
Call extended backend health checks when creating ldap authentication backends
...
fixes #6457
2014-06-11 15:09:36 +02:00
6c82cb8988
Check ldap backend health during Authentication
...
Check if authentication is possible during authentication, to generate more
useful error and log messages, in case the backend configuration is wrong
ref #6457
2014-06-11 15:08:05 +02:00
bca166c644
Do not throw an exception when the username does not exist
...
refs #6457
2014-06-11 15:08:05 +02:00
159d765f14
Fix that calling ActionController::translate() throws an exception
...
Translating strings must not throw an exception
even if the given domain is not valid.
fixes #6432
2014-06-11 13:39:22 +02:00
305a025e7a
Detect ldap default naming context
...
Read the entries in the RootDTS of the given ldap server, to discover
its default naming context and capabilities
refs #6097
refs #6096
2014-06-06 18:18:58 +02:00
efe67377a8
Move dns discovery functions into separate class
...
Add functions to lookup and reverse-lookup domain names and move the ldap
discovery function into a separate class
refs #6093
2014-06-06 17:49:55 +02:00
953d22244a
Add host discovery to authentication page
...
Find all domains for a given hostname.
refs #6093
Conflicts:
application/forms/Install/AuthenticationPage.php
2014-06-06 17:49:55 +02:00
06296f29d8
UI/Sparklines: Change sparkline code to serverside only
...
fixes #6124
2014-06-06 16:35:33 +02:00
e01629fe0b
ActionController: fix initial redirect
...
refs #6419
2014-06-06 08:32:21 +00:00
1e9bc6c7d4
Data\PivotTable: should work with new queries
...
There is still some work to do be done here. And we should/could
rethink columns() VS getColumns().
2014-06-06 06:47:49 +00:00
db3accc704
Data\Db: rename Query and Connection to Db...
...
Class names in namespaces should not be chosen as once we didn't have
such. The fact that we already did "use Db\Connection as DbConnection"
is the best hint that naming was wrong.
So this patch renames Db\Connection to Db\DbConnection and does the
same with DbQuery. DbQuery has been adjusted to fit our new SimpleQuery
and to handle the new Filter implementation.
2014-06-06 06:43:13 +00:00
1fbca25d99
Data\DataArray: use SimpleQuery and new interfaces
...
Removed ArrayQuery implementation as SimpleQuery is enough here.
Renamed the Datasource class to ArrayDatasource.
refs #6418
2014-06-06 06:21:35 +00:00
31047e8082
Data\SimpleQuery: concrete implementation
...
SimpleQuery is no longer abstract, implements the Filterable interface
and should now be usable as a basic Query implemenation as is.
2014-06-06 06:12:17 +00:00
85605597cc
Data/interfaces: add Filterable, extend Connection
...
New interface ConnectionInterface attempts to aggregate things.
Extended Filterable interface, added Filter-related functions. Please
note that apply will probably get dropped later on, I'll keep it for
compatibility reasons right now.
refs #6418
2014-06-06 06:07:33 +00:00
f438cb30e1
Data\Filter: initial commit basic implementation
...
Basic operators are there, still missing: subclassed "where" to distinct
comparison operators like greater/less than on a class level.
refs #6418
2014-06-06 06:04:24 +00:00
d44a87717d
Data\SimpleQuery: implement column handling
...
We want SimpleQuery to be able to run standalone
2014-06-06 05:49:39 +00:00
4b8e09b12a
Data\SimpleQuery: get front controller without ZF
2014-06-06 05:48:29 +00:00
bfe6a1593a
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
2014-06-06 05:32:54 +00:00
20b43a92f1
Dashboard: Better implementation of handling errors
...
refs #6412
2014-06-05 16:07:40 +02:00
151f058286
Dashboard: Display error message on failure
...
When no (default) configuration is available for dashboards
application dies not very gracefully. Display error message
and guid the user to the solution is a better way.
fixes #6412
2014-06-05 15:20:54 +02:00
1b3bb6cade
Web\Url: add getQueryString() and without()
2014-06-05 03:44:12 +00:00
99aae5a0d9
JS/XHR: get ready to get XHR redirect-aware
...
These are just the first steps, there is more to come
2014-06-05 03:37:36 +00:00
c592236258
vendorlibs: library/vendor to libary/IcingaVendor
...
This doesn't make it much better but allows to build a package
libicinga-vendor-php placing those files to /usr/share/php/IcingaVendor
or similar.
refs #4075
2014-06-05 00:10:49 +00:00
8df26bb5f5
bootstrapping: add a dispatchModule() shortcut
...
This allows to easily jump into a specific modules CLI controllers.
refs #6411
2014-06-04 23:39:12 +00:00
4202e34d13
bootstrapping: play nice with duplicate modules
...
A module loaded manually could also exist in the list of enabled
modules if a configuration is given and a module with the same name
has been enabled. This used to confuse documentation.
2014-06-04 23:37:36 +00:00
bdcec5a253
Cli\Loader: allow injecting a module name
...
This helps those who prefer to create their own executables instead
of creating icingacli subcommands.
refs #6411
2014-06-04 23:04:11 +00:00
eadb6cb518
bootstrapping: allow to retrieve a modules base...
...
...directory if it has been loaded but neither enabled nor installed.
refs #6411
2014-06-04 22:59:48 +00:00
0e6aecbd43
bootstrapping: allow to load modules neither...
...
...enabled nor installed by passing their base directory. In favour
of this parameter I dropped the possibility to inject a Module class
for testing purposes. There is no such test and I see no point in
doing so.
refs #6411
2014-06-04 22:57:50 +00:00
e076d2d1d6
bootstrapping: create only one CLI loader instance
...
This used to work fine as long as you didn't try to interfere from
outside to influence the cli loader. The instance returned by
cliLoader() was not the same as used internally once dispatching the
CLI command.
refs #6411
2014-06-04 22:52:38 +00:00
a221afd933
bootstrapping: autoloader exceptions should not...
...
...require to be autoloaded.
refs #6411
2014-06-04 22:50:08 +00:00
602b448505
bootstrapping: only web should depend on forms
...
This fixes the problem that CLI scripts or other applications without
an application directory would badly fail because of missing web forms.
refs #6411
2014-06-04 22:46:16 +00:00
bdc3423d4e
packaging/config: allow to override APPDIR
...
It is now possible to either define ICINGAWEB_APPDIR in an Environment
variable or to define it as a PHP constant before bootstrapping.
fixes #6400
2014-06-04 21:22:29 +00:00
55880cb5a3
packaging/config: rename ICINGA_APPDIR
...
Renamed ICINGA_APPDIR to ICINGAWEB_APPDIR for consistency. This way
it fits ICINGAWEB_CONFIGDIR.
refs #6400
2014-06-04 21:11:27 +00:00
e992f152bb
packaging/configuration: get rid of _ENV
...
We should use _SERVER for our settings as it works fine on CLI and
for web servers.
refs #6400
2014-06-04 21:08:49 +00:00
29f593a357
Authentication: Add backend to handle external authentication
...
Drop external auth configuration from config.ini and move
implementation into a single backend provider named
'autologin'. This provider can strip realm names from
username with a custom regexp.
fixes #6081
2014-06-03 17:59:22 +02:00
a0459d0172
ExternalAuthentication: Move authenticationMode to config.ini
...
fixes #6214
2014-06-03 15:26:15 +02:00
160a95e32d
Bootstrap/Web: Only load authentication.ini if needed
...
fixes #6238
2014-06-03 14:16:01 +02:00
cfcaf019bd
User backends: Throw exception when authentication fails due to an exception
...
refs #5685
2014-06-02 15:52:58 +02:00
2274b6e11e
lib: Add phpdoc to class `AuthChain'
...
refs #5685
2014-06-02 15:46:15 +02:00
79fb8b1e0d
Config: Remove base path subsitution
...
Test for leading slash and prepend base path to allow
absolute configuration files.
fixes #5556
2014-06-02 14:54:31 +02:00
5559cf6c2b
lib: Add AuthenticationException for exceptions thrown during authentication
...
Our user backends log exceptions thrown during authentication but they don't throw
a exception to inform the caller that an error occured. The new `AuthenticationException'
class should be thrown in that case.
2014-06-02 14:07:59 +02:00
a379502b15
Preferences: Rename `showBenchmark' to `show_benchmark'
...
We use underscore_case notation for all configuration keys.
refs #4952
2014-06-02 13:33:55 +02:00
50e01d1284
Config: Rename `configPath' to `config_path'
...
We use underscore_case notation for all configuration keys.
refs #4952
2014-06-02 12:09:16 +02:00
5cc69b53cf
Remove superfluous space in prefixedTimeSince
...
refs #5981
2014-05-29 13:11:01 +02:00
a66a1a4729
Refactor the timeSincePrefix and timeUntilPrefix functions
...
Instead of having two separate functions to get the prefix
and the formatted time interval the new functions return
both the prefix and the time interval.
refs #5981
2014-05-29 13:03:10 +02:00
7b0a48bef5
Rename timeUnless to timeUntil
...
refs #5981
2014-05-29 12:38:59 +02:00
d01a98b7e6
Fix some of the time-related grammar mistakes
...
This updates some of the messages to use "For"
instead of "Since" where appropriate.
fixes #5981
2014-05-29 11:30:08 +02:00
88460189cd
Encoding: no ASCII chars > 127 in HTTP headers
...
Had quite some trouble with this, decided to URL-encode titles and
notifications.
2014-05-28 21:34:36 +00:00
92f454c36d
Chart\InlinePie: locale-ignorant casts for floats
...
PHP respects locales (LC_NUMERIC) when casting floats to string. That
affected the generated HTML for our inline pie charts. This patch is
not that beautiful - but fixes this.
fixes #6348
2014-05-28 10:20:34 +00:00
360ac87550
Translation: add a module-aware translation helper
...
With this fix $this->translate works in our view scripts
refs #6338
2014-05-27 21:41:46 +00:00
70ba36aad6
notifications: improve client- and serverside
...
This is just a first step, trying to catch a few gotchas:
* it doesn't send notifications to the browser when issueing a redirect
as redirects can currently not be catched in jQuery response handlers
* it tries to find a better notification handling place in the response
handler (JS) - still imperfect
* it explicitely stores sessions once modified by notifications. Still
need to crosscheck whether this is really needed and how we can get
rid of this.
refs #6280
2014-05-26 14:41:47 +00:00
8a770007ff
Modules\Module: provide a lighter header sample
...
We should get rid of the current way of copying license snippets to
every single file. This is a first example of how a lighter header
could look like. I'd add a short slogan to the title and place a
copy of the license to icinga.org, so our links could point there
instead of gnu.org.
refs #6309
2014-05-26 14:17:46 +00:00
7c68d0a30f
Modules\Module: clean up phpdoc blocks
2014-05-26 14:14:34 +00:00
5b87d6238b
Modules\Module: improve provided metadata
...
refs #4095
2014-05-26 14:11:43 +00:00
8ff757f6df
Inline\PieChart: code style
2014-05-20 23:29:13 +00:00
12b57c6d95
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
...
Conflicts:
modules/monitoring/library/Monitoring/Backend/Ido/Query/ContactgroupQuery.php
modules/monitoring/library/Monitoring/Backend/Ido/Query/IdoQuery.php
modules/monitoring/library/Monitoring/Backend/Ido/Query/StatusQuery.php
modules/monitoring/library/Monitoring/Controller.php
2014-05-20 23:15:11 +00:00
24f2ae607f
Pdf/Charts: add initial chart support to PDFs
...
Problem: TCPDF had SVG support, dompdf hasn't. This patch adds a
first rudimentary PNG conversion and a sample implementation making
use of such.
2014-05-20 22:48:06 +00:00
78bc2b4ec7
Modules\Manager: no warning for duplicate modules
...
Formerly we logged a warning if a module was found in multiple module
paths. This is pointless, because as soon as you got a default module
installed by your distribution and "upgraded" it via your web frontend
this "error" will be the default. Logging at debug level right now.
2014-05-20 22:39:32 +00:00
51c3fed743
File\Pdf: remove obsolete code
2014-05-20 22:39:03 +00:00
4e88a4e008
Web\Url: add a shift() method
...
This methods allows to retrieve an URL param while removing it from the
URL object
2014-05-20 13:49:35 +00:00
e6d80ae1f6
IDO Queries: performance quickfixes
...
Will be obsoleted by the new filter implementation, but for now it
helps a little bit
2014-05-20 13:27:58 +00:00
b447225512
Web\Form: Revert "Fix subForm functionality"
...
This reverts commit 51bac035ac
2014-05-20 13:10:18 +00:00
ef7bb0e794
It is a multistep page's responsibility whether it is shown to the user
...
refs #6136
2014-05-14 12:53:45 +02:00
754f854dd0
Multistep pages should know about their multistep form
...
refs #6136
2014-05-14 12:53:45 +02:00
1f942acd38
Fix multistep page creation
...
refs #6136
2014-05-14 12:53:45 +02:00
33d4142664
Make it possible to recreate a form
2014-05-14 12:53:44 +02:00
1637a19c23
Fix multistep form creation
...
refs #6136
2014-05-14 12:53:44 +02:00
429e09aae2
Multistep pages should not have random generated names
...
refs #6136
2014-05-14 12:53:44 +02:00
51bac035ac
Fix subForm functionality
2014-05-14 12:53:44 +02:00
de169c7bf5
Make it possible to disable form submit buttons forcefully
2014-05-14 12:53:44 +02:00
88e451402f
Redirect to /install when the setup.token exists but no config.ini
...
refs #6136
2014-05-14 12:53:44 +02:00
4cf5fe6fdd
Add multistep form
...
refs #6136
2014-05-14 12:53:44 +02:00
e1230eb8ae
Add style and view scripts for first prototype
...
refs #6136
2014-05-14 12:53:44 +02:00
e04ca8c29a
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
2014-05-07 15:53:48 +00:00
d0c56126b8
Fix inline pie reload.
...
refs #6124
2014-05-07 17:03:27 +02:00
820b6b7a8d
Data\BaseQuery: rename to Data\SimpleQuery
...
BaseQuery should no longer be abstract but be usable as is as soon as
we stripped ResultSet-specific tasks. As "Base" suggests something that
must be extended, the name no longer fits. So this is SimpleQuery right
now.
2014-05-07 11:55:35 +00:00
ab32a91a6e
File\Csv: use Fetchable instead of BaseQuery
2014-05-07 11:33:48 +00:00
ecbd9b8616
Sortable: Fix PHPDoc for parameter `$direction'
...
`$direction' must be a string instead of an integer because
the direction constants `SORT_ASC' and `SORT_DESC' are strings.
2014-05-07 10:00:41 +02:00
d87788b9c1
Merge branch 'master' into feature/query-interfaces-6018
...
Conflicts:
modules/monitoring/library/Monitoring/Backend/Ido/Query/ContactgroupQuery.php
2014-05-06 18:45:12 +02:00
2f911f75a1
Fix division by zero in Icinga\Util\Format
...
refs #6125
2014-05-06 08:32:42 +02:00
c711e3405d
Fix cli default log configuration and js-loader debug message
2014-05-05 16:17:21 +02:00
0627d954ac
Fix usages of Icinga\Module\Monitoring\Plugin\*
...
refs #5973
2014-05-05 16:16:45 +02:00
6a1602a499
Exception messages should be single-line strings
...
fixes #6095
2014-05-02 11:19:35 +02:00
6c698c1543
Tests: Remove Zend Controller Test from base test
...
fixes #6106
2014-05-02 09:46:01 +02:00
6aaff6b399
IniWriter: Delete nested properties
...
fixes #5958
2014-05-02 09:26:17 +02:00
4cf3044a53
Rename Icinga\Logger\Writer\StreamWriter to FileWriter
...
refs #6038
2014-04-30 11:59:22 +02:00
270181885c
Fix Url error for emty baseUrl, less function calls
2014-04-29 12:27:19 +00:00
e2ba172a8e
Make dashboard components using the ini writer class
...
fixes #5524
2014-04-29 11:30:53 +02:00
085025ba7d
Icingaweb shoul work without optional extensions when they are not used
...
When optional classes and php extensions like pgsql and additonal Zend-Pdos are
actually required by creating a new resource or authentication backend,
perform a check and display a warning instead of just throwing an exception.
refs #4788
2014-04-28 17:13:40 +02:00
98ca15d1fb
Mark less important or non-testable code as skipped for code coverage
...
refs #6011
2014-04-28 14:06:41 +02:00
07da92ee42
Rewrite test for Icinga\Web\Url and fix some bugs
...
refs #6011
2014-04-28 14:06:40 +02:00
729c33c3cf
Add helpful documentation to Icinga\Web\ViewStream
2014-04-28 14:06:40 +02:00
c5c375e72d
Add test for Icinga\Web\MenuItem
...
refs #6011
2014-04-28 14:06:40 +02:00
290fe9eeb5
Rewrite test for Icinga\Web\Hook
...
refs #6011
2014-04-28 14:06:40 +02:00
2b15d35dec
Rewrite test for Icinga\Web\Form
...
refs #6011
2014-04-28 14:06:40 +02:00
87863d3212
Add test for Icinga\File\Csv
...
refs #6011
2014-04-28 14:06:40 +02:00
e8ed7c7166
Rewrite test for Icinga\Config\PreservingIniWriter
...
refs #6011
2014-04-28 14:06:40 +02:00
fe44f8ed7c
Remove empty file library/Icinga/File/Csv/Query.php
2014-04-28 14:06:40 +02:00
54a5e996bb
Add test for Icinga/Logger/Writer/StreamWriter
...
refs #6011
2014-04-28 14:06:39 +02:00
45d7864198
Refactor test for Icinga\Test\BaseTestCase
...
refs #6011
2014-04-28 14:06:39 +02:00
Matthias Jentsch
Johannes Meyer
Marius Hein
Thomas Gelf
Eric Lippmann
Gunnar Beutner