Commit Graph

10125 Commits

Author SHA1 Message Date
Thomas Gelf 1fba491160 DbConnection: fix utf8-encoded MySQL connections 2016-02-29 20:58:34 +01:00
Johannes Meyer 1dca5bd123 ActionsController: Pass the backend to downtime command forms
fixes #11260
2016-02-29 15:25:03 +01:00
Eric Lippmann 9c5dfc5207 Merge branch 'bugfix/benchmark-not-always-rendered-10856'
fixes #10856
2016-02-27 22:49:44 +01:00
Eric Lippmann 70d296ea32 Merge branch 'bugfix/disable-comment-persisent-for-icinga2-11100'
fixes #11100
2016-02-27 22:48:45 +01:00
Eric Lippmann 25f596969f Merge branch 'bugfix/session-cookie-11187'
fixes #11187
2016-02-27 22:47:20 +01:00
Eric Lippmann 4275d030c5 Merge branch 'feature/puppet-install-mod-ssl-11238'
resolves #11238
2016-02-27 22:45:50 +01:00
Eric Lippmann 03d7f3a1f4 Ensure trailing slash if cookie path is detected automatically
Seems like IE (8, 9, ?) has problems w/o the trailing slash and additional directories on the server that start w/ the path.

refs #11187
2016-02-27 22:42:32 +01:00
Eric Lippmann 5f43ac8f26 Fix path, secure flag and domain of session cookies
refs #11187
2016-02-27 22:24:01 +01:00
Eric Lippmann 5f642879c7 Respect cookie domain config in Cookie.php
refs #11187
2016-02-27 22:19:37 +01:00
Alexander A. Klimov 923e902957 Web::bootstrap(): set up the request before setting up the session
refs #11187
2016-02-27 22:17:01 +01:00
Eric Lippmann ad3ca513c9 Fix misleading tooltip in Tactical Overview
fixes #11039
2016-02-27 22:03:14 +01:00
Eric Lippmann dc0359f5b2 Fix icon_image size and provide a CSS class for theming
fixes #11032
2016-02-27 21:57:02 +01:00
Eric Lippmann 7cef06f981 Disable benchmark only if the layout is disabled
Benchmark should be disabled if the response is not HTML. This is most likely the case when the layout is disabled.
If Web 2 or Zend sends JSON for example, the layout is disabled.

The follwing code inside an action disables the layout (and view):
$this->_helper->layout()->disableLayout();

The following code inside an action disables the action's view script:
$this->_helper->viewRenderer->setNoRender(true);

Note that an action's view script is also disabled via setNoRender() when rendering another view script via
render() or renderScript().

Another appraoch is to check the content-type. If explicitly set to not HTML, disable benchmark:

$renderBenchmark = true;
$response = $this->getResponse();
$headers = $response->getHeaders();
foreach ($headers as $header) {
    if (strtolower($header['name']) === 'content-type'
        && stristr($header['value'], 'text/html') === false
    ) {
        $renderBenchmark = false;
        break;
    }
}
if ($renderBenchmark) {
    $layout->benchmark = $this->renderBenchmark();
}

Maybe we should also provide a action method for disabling benchmark, regardless of the user's setting.

refs #10856
2016-02-27 20:14:02 +01:00
Eric Lippmann 16cc5e333a Merge branch 'bugfix/respect-filter-in-state-links-in-group-overviews-10778'
fixes #10778
2016-02-27 16:28:32 +01:00
Eric Lippmann bf7d082576 Fix PHPDoc of Url::addFilter() 2016-02-27 16:25:04 +01:00
Alexander A. Klimov 5b0730574d Simplify Url::addFilter()
This changes the rendered resulting Url from x&(y&z) to x&y&z.

refs #10778
2016-02-27 16:23:09 +01:00
Eric Lippmann f6e4b0aed0 Respect filter in state links in group overviews
refs #10778
2016-02-27 16:22:44 +01:00
Eric Lippmann 8433bf1fc1 Don't hide the filter editor from the view if the view is compact
refs #10778
2016-02-27 15:57:00 +01:00
Eric Lippmann d8b14cb772 Control whether a filter editor should be rendered via setVisible()
We (may) have situations where a controller or view has to access the filter editor being created via Controller::setupFilterControl().
This is impossible if the view is compact because the filterEditor will be unset. This change introduces FilterEditor::setVisible() for
giving the responsibility of rendering to the filter editor. Controller::setupFilterControl() will be adapted accordingly.

refs #10778
2016-02-27 15:51:13 +01:00
Eric Lippmann c5aab53745 Add upgrading note about the changed Authentication and Authorization menu entries
refs #10309
2016-02-27 15:27:59 +01:00
Eric Lippmann 88f4f68f29 Merge branch 'bugfix/move-auth-backend-configuration-to-app-config-10309'
fixes #10309
2016-02-27 15:25:11 +01:00
Eric Lippmann 7188a82a4c Fix that the close-container-control is not immediately shown for #col1
refs #8590
2016-02-27 15:09:11 +01:00
Florian Strohmaier 0c34c20640 Prepare close-container for behavior implementation
refs #8590
2016-02-27 15:07:10 +01:00
Alexander A. Klimov ce4f844e9f Vagrant: forward port 8443 -> 443
refs #11238
2016-02-26 14:01:15 +01:00
Alexander A. Klimov d66198e555 Puppet module apache: install package mod_ssl
refs #11238
2016-02-26 13:56:06 +01:00
Eric Lippmann e4a0678df0 Load resources from config automatically instead of throwing an exception
fixes #10918
2016-02-26 12:29:30 +01:00
Eric Lippmann 9d5e21e71e Remove IniUserGroupBackend.php
Does not conform to its interface anymore and is not in use.
2016-02-26 10:32:13 +01:00
Thomas Gelf 9231746d09 functions.php: failsafe method initialization
This avoids collisions for modules not using the fake bootstrap in our
current tests. Can be removed once we fixed that.
2016-02-25 18:07:29 +01:00
Eric Lippmann 5f8b994d5f Use isIcinga2() in command forms where needed 2016-02-25 17:51:37 +01:00
Eric Lippmann 02eea2ad11 Disable persistent comment checkbox if backend is Icinga 2
refs #11100
2016-02-25 17:51:02 +01:00
Eric Lippmann 863bf08864 Use isIcinga2() in the ToggleInstanceFeaturesCommandForm 2016-02-25 17:48:32 +01:00
Eric Lippmann 47b3019940 Add MonitoringBackend::isIcinga2()
This function is for the many places where we have to distinguish between Icinga 1.x and Icinga 2.x.

refs #11100
2016-02-25 17:45:51 +01:00
Alexander A. Klimov 1bbb7a3118 Manager::detectEnabledModules(): shorten error message 2016-02-25 17:34:03 +01:00
Alexander A. Klimov 1aada1abbb Present the fact that Icinga Web 2's config directory isn't readable in a nicer way
fixes #11119
2016-02-25 17:31:09 +01:00
Alexander A. Klimov 4751df692d Allow style classes in plugin output
resolves #11062
2016-02-25 17:09:39 +01:00
Eric Lippmann 5a76895105 CSS: Disable :hover transition on tr (WIP)
If any tr is hovered and auto-refresh kicks in, the tr will be hovered again which leads to "flickering".

We should find good a way to use transitions w/o flickering.

refs #11073
2016-02-25 14:52:54 +01:00
Alexander A. Klimov 45168caa37 TimezoneDetect: support comma-separated icingaweb2-tzo cookies 2016-02-25 14:41:42 +01:00
Alexander A. Klimov af18334e3e Cookie icingaweb2-tzo: use `-' as separator
fixes #11126
2016-02-25 13:21:34 +01:00
Eric Lippmann 43a7ed357a Fix whitespaces in event-history
overview-plugin-output now has white-space: pre-wrap
2016-02-25 11:34:23 +01:00
Eric Lippmann a34f48c990 Fix wrong "Sent out to any contact" notification information 2016-02-25 11:33:43 +01:00
Eric Lippmann f032a670f0 Merge branch 'feature/render-links-in-acknowledgements-comments-and-downtimes-10654'
resolves #10654
2016-02-25 11:31:13 +01:00
Eric Lippmann c834e66b9a Show useful error message if a command transport failed
fixes #10173
2016-02-25 10:36:10 +01:00
Eric Lippmann 102ed40378 Show "Remove problem acknowledgement" in multi-select views
fixes #10469
2016-02-25 10:21:10 +01:00
Eric Lippmann 23b5777b05 CSS: Left-align text in link-button
If the text in a link-button consumes more than one line, text would be center-aligned else.
2016-02-25 10:18:41 +01:00
Alexander A. Klimov 172ebd0fd4 Escape backend names in authentication backend reorder form 2016-02-24 17:07:07 +01:00
Eric Lippmann e407f6d116 Merge branch 'bugfix/users-with-no-permissions-can-check-multiple-services-10397'
fixes #10397
2016-02-24 12:42:46 +01:00
Alexander A. Klimov d257c71c54 Respect permission for check now on multiple services
refs #10397
2016-02-24 12:40:00 +01:00
Alexander A. Klimov 23841b635e Respect permission for check now on multiple hosts
refs #10397
2016-02-24 12:39:54 +01:00
Alexander A. Klimov 21eeeea7ea Don't allow raw double quotes in dashlet URLs 2016-02-23 16:34:18 +01:00
Alexander A. Klimov b7bdf2e8d4 Implement UrlValidator 2016-02-23 16:34:18 +01:00