Commit Graph

1769 Commits

Author SHA1 Message Date
Noah Hilverling e4324605bc Merge branch 'bugfix/username-and-password-not-being-passed-in-navigation-item-urls-12133'
fixes #12133
2016-10-20 09:30:54 +02:00
Noah Hilverling 1ff3149636 Url: Add basePath to urlString if url is external or has a username
refs #12133
2016-10-19 09:41:03 +02:00
Noah Hilverling 2fd1a957a8 Url: Add basePath to baseUrl in method getBaseUrl
refs #12133
2016-10-19 09:40:08 +02:00
Noah Hilverling 13827c79e4 Url: Improve documentation of method setHost
refs #12133
2016-10-19 09:35:40 +02:00
Alexander A. Klimov 00880710ed Navigation::fromArray(): pass $name only as string to addItem()
fixes #12923
2016-10-18 18:06:51 +02:00
Noah Hilverling 3b6b0b8d4b Url: Build full urlString instead of path if username is set
refs #12133
2016-10-18 16:19:24 +02:00
Noah Hilverling a952a400ca Url: Add username and password to method getBaseUrl
refs #12133
2016-10-18 16:16:13 +02:00
Noah Hilverling 9fcc39e0ba Url: Add use of method setBasePath in method setBaseUrl
refs #12133
2016-10-18 16:15:14 +02:00
Noah Hilverling 08719b0522 Url: Do not try to set attributes in method fromPath if not needed
refs #12133
2016-10-18 16:13:37 +02:00
Noah Hilverling b4aca4737b Url: Cut of "/" and spaces at the end of basePath in setBasePath
refs #12133
2016-10-18 16:08:34 +02:00
Noah Hilverling 1c55351460 Url: Remove "/" in front of path if the url has a user parameter
refs #12133
2016-10-18 16:07:13 +02:00
Noah Hilverling dda7311226 Url: Improve documentation
refs #12133
2016-10-18 16:03:31 +02:00
Noah Hilverling 4e64c02078 Url: Remove attribute baseUrl
refs #12133
2016-10-18 16:01:23 +02:00
Noah Hilverling 4dd9c05882 Url: Return basePath in method getBaseUrl if url is internal
refs #12133
2016-10-18 12:57:02 +02:00
Noah Hilverling f6f90822d6 Url: Set basePath correctly in methods fromRequest and fromPath
refs #12133
2016-10-18 12:57:02 +02:00
Noah Hilverling 888ac98007 Response: Improve documentation for method getHeader
refs #12161
2016-10-18 11:07:24 +02:00
Noah Hilverling e5c736aab4 Response: Use method getHeader to check if Content-Type is set already
refs #12161
2016-10-18 10:13:58 +02:00
Noah Hilverling f95c789353 Response: Add method getHeader
refs #12161
2016-10-18 09:58:33 +02:00
Noah Hilverling c927c32442 Response: Only set header Content-Type in method prepare if not already set
refs #12161
2016-10-17 16:34:07 +02:00
Noah Hilverling 703561f874 JsonResponse: Set content type at initialization and not at sendHeaders
refs #12161
2016-10-17 16:33:51 +02:00
Noah Hilverling c3276d4341 Response: Remove empty line after method getContentType
refs #12161
2016-10-17 16:03:33 +02:00
Noah Hilverling 2439460371 Url: Fix incorrect line indentation in method getAbsoluteUrl
refs #12133
2016-10-17 10:16:03 +02:00
Noah Hilverling 4df9696ed9 StyleSheet: Modify send method to use setContentType of Response class
refs #12161
2016-10-17 08:29:51 +02:00
Noah Hilverling af5c578adf Response: Set header Content-Type for every response by default
refs #12161
2016-10-14 16:16:13 +02:00
Noah Hilverling 7cf6b860b5 Response: Add contentType attribute
refs #12161
2016-10-14 16:12:47 +02:00
Noah Hilverling 9439dfa8f3 Url: Fix path handling for internal urls
refs #12133
2016-10-14 15:05:34 +02:00
Noah Hilverling ef359aa686 Url: Improve documentation
refs #12133
2016-10-14 15:04:03 +02:00
Noah Hilverling 3e2f3c8467 Url: Add basePath attribute
refs #12133
2016-10-14 15:01:03 +02:00
Jennifer Mourek 0cd2d98f71 StyleSheet: Don't try to load the icinga default theme
refs #12660
2016-10-14 13:24:17 +02:00
Jennifer Mourek 8294471253 Revert "LessCompiler: Remove error message when switching to Icinga theme"
This reverts commit 2e24833d7c.
2016-10-14 09:39:24 +02:00
Jennifer Mourek 2e24833d7c LessCompiler: Remove error message when switching to Icinga theme
fixes #12660
2016-10-14 08:06:05 +02:00
Noah Hilverling f557b89aea Url: Add support for username and password
fixes #12133
2016-10-13 11:01:39 +02:00
Noah Hilverling c868789472 Url: Add alternative attributes for baseUrl
refs #12133
2016-10-13 11:01:10 +02:00
Alexander A. Klimov 8bc7d47a62 Merge branch 'bugfix/preserve-http-response-code-in-rest-error-responses-12583'
fixes #12583
2016-10-11 10:46:20 +02:00
Alexander A. Klimov bf3cfda209 Response: rename setMetaDataFrom() to copyMetaDataFrom()
refs #12583
2016-10-11 10:45:15 +02:00
Eric Lippmann c83659eff7 Sometimes you just herp the derp so hard it herpderps 2016-09-29 16:19:41 +02:00
Alexander A. Klimov 4d16656100 Preserve status code and headers in JSON responses
refs #12583
2016-09-27 13:26:20 +02:00
Johannes Meyer 5b875f3749 JsonResponse: Allow to output the "data" key in case of an error
As stated by the JSend specification this key is optional for error responses.
2016-09-21 15:58:59 +02:00
Alexander A. Klimov c8b1693fdc Fix Controller::assertPermission() allowing everything for unauthenticated requests
fixes #12108
2016-09-12 08:18:36 +02:00
Eric Lippmann ef7be98e0c Simplify InternalUrlValidator::isValid()
refs #11920
2016-09-09 15:22:24 +02:00
Eric Lippmann 1f980f92f2 Optimize imports in InternalUrlValidator
refs #11920
2016-09-09 15:21:06 +02:00
Alexander A. Klimov fa113e023b dashboard/new-dashlet: don't allow external URLs
refs #11920
2016-08-31 15:11:55 +02:00
Eric Lippmann 42991b0756 Ensure correct URL for the refresh container button
Shifted params no longer appear in the URL which is retrieved from the request object.
We now use Url::fromRequest() instead.
2016-07-13 10:24:30 +02:00
Johannes Meyer 4774db16ef View: Add methods setHelperFunction and dropHelperFunction 2016-07-11 09:08:43 +02:00
Eric Lippmann 97451dae86 Merge branch 'bugfix/remove-large-add-to-menu-tab-11850'
fixes #11850
2016-06-02 17:57:51 +02:00
hailthemelody@rm-laptop04 188703cf95 fix various typos
Signed-off-by: Johannes Meyer <johannes.meyer@netways.de>
2016-06-02 08:24:05 +02:00
Alexander A. Klimov 50037d8ec9 Tabs: fix wrong parameter for array_splice()
refs #11850
2016-05-31 14:47:25 +02:00
Alexander A. Klimov 2179c3aaef FilterEditor: check for a hidden form field instead of the submit button 2016-04-27 15:05:25 +02:00
Alexander A. Klimov 6def061742 FilterEditor: correct submit button name 2016-04-27 12:49:40 +02:00
Alexander A. Klimov 281e6e8163 Revert "Revert "FilterEditor::handleRequest(): don't apply a filter's changes if the 'Apply' button hasn't been pressed""
This reverts commit 45a6259b4c.
2016-04-27 12:46:48 +02:00
Alexander A. Klimov 45a6259b4c Revert "FilterEditor::handleRequest(): don't apply a filter's changes if the 'Apply' button hasn't been pressed"
This reverts commit 61a04e7ba1.
2016-04-27 12:10:46 +02:00
Marius Hein 6607af61e1 Set dashboard active if it is not disabled 2016-04-26 13:50:02 +02:00
Alexander A. Klimov eecd15ee68 NavigationItem: fall back to the default renderer if an error occurrs
fixes #10486
2016-04-25 15:26:08 +02:00
Alexander A. Klimov 242cdab754 DateTimePicker: implement getFormat()
refs #10847
2016-04-18 17:19:57 +02:00
Alexander A. Klimov 61a04e7ba1 FilterEditor::handleRequest(): don't apply a filter's changes if the 'Apply' button hasn't been pressed
fixes #10848
2016-04-18 15:15:41 +02:00
Eric Lippmann be7263ebfa Fix that only one default dashboard could be removed
fixes #11078
2016-04-13 12:27:25 +02:00
Eric Lippmann 7dbcd27c3c Remove superfluous whitespace 2016-04-13 11:04:54 +02:00
Eric Lippmann 9082a5204e Fix tab order of refresh and close container controls 2016-04-13 11:04:23 +02:00
Florian Strohmaier 0a9c0925cb CSS: Add space before the autosubmit info in forms 2016-04-07 12:46:13 +02:00
Eric Lippmann c7aec8ae64 Respect module stylesheets again when generating the ETag
fixes #11465
2016-03-29 11:39:41 +02:00
Markus Frosch 88d973ac39 Restrict access to application log with 'application/log' permission
fixes #11279
2016-03-02 20:47:37 +01:00
Eric Lippmann 9c5dfc5207 Merge branch 'bugfix/benchmark-not-always-rendered-10856'
fixes #10856
2016-02-27 22:49:44 +01:00
Eric Lippmann 03d7f3a1f4 Ensure trailing slash if cookie path is detected automatically
Seems like IE (8, 9, ?) has problems w/o the trailing slash and additional directories on the server that start w/ the path.

refs #11187
2016-02-27 22:42:32 +01:00
Eric Lippmann 5f43ac8f26 Fix path, secure flag and domain of session cookies
refs #11187
2016-02-27 22:24:01 +01:00
Eric Lippmann 5f642879c7 Respect cookie domain config in Cookie.php
refs #11187
2016-02-27 22:19:37 +01:00
Eric Lippmann 7cef06f981 Disable benchmark only if the layout is disabled
Benchmark should be disabled if the response is not HTML. This is most likely the case when the layout is disabled.
If Web 2 or Zend sends JSON for example, the layout is disabled.

The follwing code inside an action disables the layout (and view):
$this->_helper->layout()->disableLayout();

The following code inside an action disables the action's view script:
$this->_helper->viewRenderer->setNoRender(true);

Note that an action's view script is also disabled via setNoRender() when rendering another view script via
render() or renderScript().

Another appraoch is to check the content-type. If explicitly set to not HTML, disable benchmark:

$renderBenchmark = true;
$response = $this->getResponse();
$headers = $response->getHeaders();
foreach ($headers as $header) {
    if (strtolower($header['name']) === 'content-type'
        && stristr($header['value'], 'text/html') === false
    ) {
        $renderBenchmark = false;
        break;
    }
}
if ($renderBenchmark) {
    $layout->benchmark = $this->renderBenchmark();
}

Maybe we should also provide a action method for disabling benchmark, regardless of the user's setting.

refs #10856
2016-02-27 20:14:02 +01:00
Eric Lippmann bf7d082576 Fix PHPDoc of Url::addFilter() 2016-02-27 16:25:04 +01:00
Alexander A. Klimov 5b0730574d Simplify Url::addFilter()
This changes the rendered resulting Url from x&(y&z) to x&y&z.

refs #10778
2016-02-27 16:23:09 +01:00
Eric Lippmann 8433bf1fc1 Don't hide the filter editor from the view if the view is compact
refs #10778
2016-02-27 15:57:00 +01:00
Eric Lippmann d8b14cb772 Control whether a filter editor should be rendered via setVisible()
We (may) have situations where a controller or view has to access the filter editor being created via Controller::setupFilterControl().
This is impossible if the view is compact because the filterEditor will be unset. This change introduces FilterEditor::setVisible() for
giving the responsibility of rendering to the filter editor. Controller::setupFilterControl() will be adapted accordingly.

refs #10778
2016-02-27 15:51:13 +01:00
Alexander A. Klimov b7bdf2e8d4 Implement UrlValidator 2016-02-23 16:34:18 +01:00
Johannes Meyer c7443924bd NavigationItemRenderer: Ignore target for '#' urls
fixes #11197
2016-02-22 11:13:23 +01:00
Alexander A. Klimov 9ef78e6856 Fix double escape of `&' in navigation items
fixes #11190
2016-02-19 15:38:34 +01:00
Alexander A. Klimov 41a8c75a4f FilterEditor: always escape filter embedded in HTML 2016-02-19 15:22:10 +01:00
Alexander A. Klimov a83ab2c7cb Escape URLs of navigation items while rendering them
fixes #11091
2016-02-18 15:01:21 +01:00
Thomas Gelf 97b5800f32 LessCompiler: fix #layout usage in module CSS 2016-02-17 18:26:07 +01:00
Alexander A. Klimov c5281935c6 Regenerate a session ID only if the session exists
refs #11151
2016-02-15 11:14:37 +01:00
Alexander A. Klimov 474803fee4 Change all license headers to only reflect a file's year of creation
refs #11000
2016-02-08 15:41:00 +01:00
Eric Lippmann 7fd575080e PHP7: Rename String to StringHelper
refs #10251
2016-01-27 16:46:55 +01:00
Eric Lippmann e9bc11d340 Fix case sensitive interpretation of dashboard config files
fixes #10878
2016-01-27 15:45:37 +01:00
Eric Lippmann 78c1e17c20 lib/Response: Allow to control the auto-refresh interval 2016-01-27 09:14:11 +01:00
Eric Lippmann f7ba48eaac CSS: Remove main-content.less
Not in use anymore.
2016-01-25 08:50:18 +01:00
Eric Lippmann f5945ff908 CSS: Move colors to mixins 2016-01-25 08:20:58 +01:00
Eric Lippmann d2e4664dce Add aria-label to dropdown menu and close container control 2016-01-25 07:23:12 +01:00
Johannes Meyer 8a17cc5161 login: Fix that the system's default theme is not applied
fixes #11021
2016-01-22 16:34:31 +01:00
Eric Lippmann bc187d91c5 monitoring: Make inline pie charts accessible 2016-01-22 13:33:22 +01:00
Eric Lippmann 9a5e69a8ec Improve tab styles for accessibility 2016-01-12 08:52:30 +01:00
Eric Lippmann 79fbed0ad4 Use icon font instead of images in the dashboard settings tab extension 2016-01-12 08:52:30 +01:00
Eric Lippmann 7c1ccc685f Rename close-toggle to close-container-control 2016-01-12 08:52:30 +01:00
Eric Lippmann 31df702a80 Remove logo.less
Not used anymore.
2016-01-12 08:52:30 +01:00
Eric Lippmann cbfaee8681 CSS: Optimize dashboard, column and controls styles
fixes #7350
fixes #10289
fixes #10871
2016-01-12 08:52:30 +01:00
Eric Lippmann 25d8215b95 Fix Dashboard::setDefaultPane() activating an inexistent pane 2015-12-22 14:54:33 +01:00
Eric Lippmann 9599b63a55 Fix that setting a default theme had not effect 2015-12-22 13:00:01 +01:00
Uwe Ebel 3c47436c1b Fix the wrong mask for temp. directory in FileCache.php
Detail see https://dev.icinga.org/issues/10892.

ref #10892

Signed-off-by: Thomas Gelf <thomas@gelf.net>
2015-12-21 13:46:04 +01:00
Eric Lippmann ca1f412080 JS: Include autofocus behavior
refs #10671
2015-12-21 13:03:28 +01:00
Eric Lippmann a3f89c8d20 lib/Tabs: Throw HttpNotFoundException when activating an inexistent tab
refs #10884
2015-12-21 10:09:13 +01:00
Eric Lippmann 11e7d1050f Merge branch 'bugfix/line-breaks-in-comments-10603'
fixes #10603
2015-12-21 09:39:12 +01:00
Alexander A. Klimov 21f7af4b64 Revert "Merge branch 'bugfix/logout-requires-restart-of-browser-10330'"
This reverts commit 94f4c670c1, reversing
changes made to 7d5c15469e.

refs #10330
2015-12-17 18:50:51 +01:00
Alexander A. Klimov f6cd4794ee NavigationItemRenderer::renderTargetAttribute(): don't use the same name for two different variables
refs #10330
2015-12-17 17:45:03 +01:00
Alexander A. Klimov a9b818d52c NavigationItemRenderer: split actualLinkTarget() into getIcingaLinkTarget() and getHtmlLinkTarget()
refs #10330
2015-12-17 17:38:21 +01:00
Alexander A. Klimov 5edd8df1b6 NavigationItemRenderer: provide more human-readable aliases for native HTML link targets
refs #10330
2015-12-17 16:52:14 +01:00
Alexander A. Klimov 2473c4bbef NavigationItemRenderer: provide more human-readable aliases for internal link targets
refs #10330
2015-12-17 16:51:45 +01:00
Eric Lippmann 8006090108 Merge branch 'feature/theming-10705'
resolves #10705
2015-12-16 12:49:11 +01:00
Eric Lippmann 755f361e4c Add behavior for dropdown navigation items
Dropdown navigation is not yet accessible. The added behavior listens for activity on dropdown-navigation-item for toggling the CSS class active.
2015-12-16 12:48:02 +01:00
Eric Lippmann 2d5bd3085f Don't send cookies on API requests 2015-12-10 13:34:54 +01:00
Eric Lippmann bcd1402123 CSS: Combine header-, footer-elements and layout-colors in layout.less 2015-12-10 13:34:53 +01:00
Eric Lippmann b193ea5d32 Fix print styles 2015-12-10 13:34:53 +01:00
Eric Lippmann a1bb4bb695 Merge branch 'master' into feature/theming-10705 2015-12-07 14:17:57 +01:00
Eric Lippmann cce6af9243 Don't load inaccessible themes
refs #10705
2015-12-07 13:51:30 +01:00
Eric Lippmann bf0b673640 Fix section for themes config in StyleSheet
refs #10705
2015-12-07 12:37:34 +01:00
Johannes Meyer e7399c312f SortBox: Add support for sort defaults provided by the controller action 2015-12-04 07:44:55 +01:00
Johannes Meyer 4f5afb5ee2 SortBox: Fix "algorithm" to detect the opposite sort direction 2015-12-03 17:15:57 +01:00
Johannes Meyer 3d60e60842 SortBox: Fix too strict sort param check
One was able to produce invalid SQL or other
errors by adding "sort=" as parameter.
2015-12-03 15:17:09 +01:00
Eric Lippmann 3a22168b64 Handle no-cache control in JavaScript and StyleSheet, not in FileCache 2015-11-27 16:51:19 +01:00
Eric Lippmann bac09fd125 Fix void method result used in JavaScript 2015-11-27 16:48:38 +01:00
Eric Lippmann 1f467ecfaa Add theme to the stylesheet if set and ...
... revamp interface of LessCompiler and StyleSheet

refs #10705
2015-11-27 16:40:17 +01:00
Eric Lippmann 59b540cc12 lib: Implement cookie handling in Response
Cookies set via Response::setCookie() or Response::getCookies()::add() will be automatically sent to client.
2015-11-27 15:51:38 +01:00
Eric Lippmann 2a0d3412d1 lib: Add CookieSet for maintaining a set of cookies 2015-11-27 15:50:29 +01:00
Eric Lippmann 8fb9d94f46 lib: Allow to control reload CSS header in Response
Whenever the theme is switched, client side script code has to be instructed to reload CSS.

refs #10705
2015-11-27 15:44:40 +01:00
Eric Lippmann 5d4a628e2d Provide cookie implementation 2015-11-27 15:42:18 +01:00
Eric Lippmann 271b5f9d5c Move cookie support detection to a helper class
Icinga\Web\Cookie will become a real cookie implementation.
2015-11-27 15:42:18 +01:00
Eric Lippmann 6e618300ec Guard the FileCache if the systemd private tmp directory for the web server has been removed
refs #10123
2015-11-26 12:13:02 +01:00
Eric Lippmann 045e4a99b5 Guard FileCache against an existing but not writeable runtime path
fixes #10123
2015-11-26 12:02:55 +01:00
Eric Lippmann 91e576d530 lib: Add nl2br view helper
refs #10603
2015-11-20 15:17:38 +01:00
Eric Lippmann 96466241c2 Fix img helper not setting icon class 2015-11-16 15:27:59 +01:00
Eric Lippmann 0cc54ce34b Refresh session every 10 minutes
Quick and dirty fix.

fixes #10229
2015-11-16 14:19:33 +01:00
Eric Lippmann 5e5e9709a5 Show sort direction as toggle button 2015-11-16 10:20:21 +01:00
Thomas Gelf d903f850da Application\Hook: move existing ones, keep compat 2015-11-13 17:37:02 +01:00
Thomas Gelf 576747f792 Application\Hook is the new Hook loader 2015-11-13 17:37:02 +01:00
Eric Lippmann d5fe0c9610 Merge branch 'feature/dope-layout-5543#2' 2015-11-13 15:21:07 +01:00
Bernd Erk 39aa888131 Adds new about page and dotted bottom lines in detail 2015-11-13 13:57:09 +01:00
Bernd Erk ecf929ec96 Fixes form decorator and uses sprintf 2015-11-12 23:11:07 +01:00
Bernd Erk d8d917ef5a Remove long required hint in forms 2015-11-12 16:01:20 +01:00
Eric Lippmann 47401ca4b2 Don't talk about panes
refs #5543
2015-11-12 15:53:38 +01:00
Eric Lippmann ad31f3fbdb CSS: Remove selection-toolbar
Not in use.

refs #5543
2015-11-12 13:08:05 +01:00
Eric Lippmann b64bf06df7 CSS: Move limiter and pagination styles to controls.less
refs #5543
2015-11-12 13:07:35 +01:00
Eric Lippmann 0abbe2583b Introduce a form the limiter control
refs #5543
2015-11-12 13:04:52 +01:00
Eric Lippmann 75091d0eaa Reduce HTML for sparkline pie charts
refs #5543
2015-11-11 15:11:14 +01:00
Johannes Meyer a662fc9af0 Controller: Re-add "view" as preserved column
We're still utilizing this in the dashboard..
2015-11-10 16:08:02 +01:00
Eric Lippmann 8a26e81c1c Remove LogoutNavigationItemRenderer
refs #5543
2015-11-10 14:06:49 +01:00
Johannes Meyer 8d04c8548a Do not hardcode action specific parameters to preserve in the FilterEditor
This should only happen for other control parameters or framework
specific stuff. This is still subject to improvement, as this solution is
rather ugly imho..

refs #10370
2015-11-10 11:51:26 +01:00
Eric Lippmann 802cba3fb8 CSS: Move variables from themes/icinga.less to base.less
refs #5543
2015-11-09 13:32:59 +01:00
Eric Lippmann b5c8579d0e lib: Fix Url paramter encoding if parameter is a Url object
fixes #10321
2015-11-09 09:55:17 +01:00
Eric Lippmann ba4256d983 Quick and dirty fix menu in FF
refs #5543
2015-11-04 17:49:43 +01:00
Eric Lippmann 8cc96e61da Re-add time-ago, -since and -until CSS classes
refs #5543
2015-10-28 10:41:22 +01:00
Eric Lippmann bb33a43cb9 CSS: Don't pollute time related format helpers w/ text-small
fixes #10301
2015-10-27 16:23:32 +01:00
Eric Lippmann 4eb92438dd Add nav-level-$level CSS classes to navigation 2015-10-27 13:52:18 +01:00
Eric Lippmann 6e5ba364fb CSS: Introduce badge-nav-item
refs #5543
2015-10-26 12:44:11 +01:00
Eric Lippmann 8341415d28 nav: Give item renderer a chance to set the CSS class of the outer li element
refs #5543
2015-10-26 12:32:49 +01:00
Eric Lippmann 4593c78d16 lib: Fix JSON response exception on form failure 2015-10-26 12:30:50 +01:00
Eric Lippmann e07e16d7a1 lib: Remove UserNavigationItemRenderer 2015-10-22 14:26:53 +02:00
Johannes Meyer 98e0081d81 Limiter: Use the limit also as priority
fixes #10288
2015-10-05 10:54:43 +02:00
Eric Lippmann 54bb99a96d Merge branch 'feature/dope-layout-5543'
refs #5543
2015-10-02 11:16:35 +02:00
Johannes Meyer 53f29131af ActionController: Use a controller's inner layout script instead of "body"
"body" is still the default inner layout script.
2015-10-02 10:18:37 +02:00
Eric Lippmann 56ed92a8e6 Merge branch 'master' into feature/dope-layout-5543 2015-10-01 21:29:35 +02:00
Thomas Gelf 9ca81320ac Search: re-add object names, allow for addresses
It's now possible do search for IP (and IPv6) addresses. Object names
are once again allowed

fixes #9591
fixes #10163
2015-10-01 18:48:36 +02:00
Johannes Meyer 209c084f51 Form: Only add the ViewHelper decorator for hidden form fields
refs #5543
2015-10-01 18:31:05 +02:00
Johannes Meyer 14ae04b631 RecursiveNavigationRenderer: Allow to enforce the standard item renderer 2015-10-01 17:43:48 +02:00
Eric Lippmann 3d2521abf0 Merge branch 'master' into feature/dope-layout-5543 2015-10-01 17:42:24 +02:00
Johannes Meyer 8c8af9cd50 DashboardPane: Fix that ordering dashlets is persistent 2015-10-01 17:35:11 +02:00
Johannes Meyer b63a956a38 Dashboard: Respect original dashlet order 2015-10-01 17:34:45 +02:00
Johannes Meyer 0cc06d6af9 NavigationItem: Improve merge "algorithm" 2015-10-01 17:12:55 +02:00
Thomas Gelf 270520eac3 helpers/icon: allow for img urls outside of icons
Icon images where restricted to img/icons, this did not allow modules
to use custom images. Left behaviour for img urls without slash
untouched.
2015-10-01 16:52:39 +02:00
Thomas Gelf cb5f741f22 UserNavigationItemRenderer: disable avatar
Broken on ff, no such image, rendering issues - postponed
2015-10-01 16:39:20 +02:00
Johannes Meyer d54e5f62e6 NavigationItem: Accept priority while merging if none is set yet 2015-10-01 16:32:47 +02:00
Eric Lippmann 08ab0befcd CSS: compat.less and monitoring detail
refs #5543
2015-10-01 16:31:25 +02:00
Johannes Meyer b74f8ce51d Wizard: Add css class control-group to all buttons
refs #5543
2015-10-01 13:34:16 +02:00
Matthias Jentsch db74f7e780 Fix icon layout in dropdown
refs #5543
2015-10-01 11:18:00 +02:00
Johannes Meyer 85e7e7920a Url: Fix detection of the current base url when stripping it from a given path 2015-10-01 10:42:28 +02:00
Eric Lippmann 968754ec2e CSS: Add class no-icon to menu items w/o an icon
refs #5543
2015-10-01 02:51:46 +02:00
Eric Lippmann c318454a45 CSS: Style form descriptions, hints, notifications and errors
refs #5543
2015-10-01 02:49:38 +02:00
Eric Lippmann 51d6c61bf7 CSS: Re-add spinner for autosubmit
refs #5543
2015-10-01 01:59:56 +02:00
Eric Lippmann 05904de5d5 Fix about markup
refs #5543
2015-10-01 00:55:49 +02:00
Eric Lippmann be3c43ef77 Add tab to new, update and remove role
refs #5543
2015-10-01 00:25:54 +02:00
Eric Lippmann 48b1c5ff30 CSS: Move spinner related styles to spinner.less
refs #5543
2015-09-30 22:24:26 +02:00
Eric Lippmann 02a3f56481 CSS: Disable logo.less
refs #5543
2015-09-30 18:52:59 +02:00
Eric Lippmann 231c63b703 Merge branch 'master' into feature/dope-layout-5543 2015-09-30 18:52:52 +02:00
Johannes Meyer c2ac841871 Make the about page pretty
refs #9247
2015-09-30 17:07:55 +02:00
Matthias Jentsch 7e81b00a96 Fix multi-view badge filters
Allow providing a base URL for StateBadges to display hosts and services based on a filter.

refs #5543
2015-09-30 16:58:42 +02:00
Johannes Meyer bd206e3718 Url: Do not trim leading slahes in method setPath()
We're handling external urls specifically now.
2015-09-30 15:42:01 +02:00
Johannes Meyer eef4322188 Url: Fix automatic stripping of the current base url in method fromPath() 2015-09-30 15:36:45 +02:00
Johannes Meyer 415690134b Add tab extension to add the current container url as new menu entry 2015-09-30 14:47:42 +02:00
Johannes Meyer 722152a876 Url: Fix that full external urls with path component are incorrectly handled
fixes #10236
2015-09-30 13:41:50 +02:00
Johannes Meyer 1c7b398219 Navigation: Do not provide "dashlet" as default item type
Please revert this commit once we're about to finish the new
implementation.

refs #6084
2015-09-30 12:55:21 +02:00
Johannes Meyer 95d1ce371c Navigation: Add static method getItemTypeConfiguration()
refs #10246
2015-09-30 11:18:15 +02:00
Eric Lippmann 274910a611 CSS: Use class form-controls for form buttons by default
refs #5543
2015-09-30 09:53:36 +02:00
Eric Lippmann c36c0455d4 CSS: Use icon-info-circled for form control help
refs #5543
2015-09-30 09:52:53 +02:00
Eric Lippmann eb246babd5 CSS: Add grid.less
refs #5543
2015-09-29 17:02:59 +02:00
Eric Lippmann ca45522da7 CSS: Move badge related styles to badges.less 2015-09-28 17:02:37 +02:00
Eric Lippmann 98f1e9028e Fix user menu CSS classes
refs #5543
2015-09-28 16:40:16 +02:00
Eric Lippmann ed6da19876 lib: Support setting CSS class for li on navigation items
refs #5543
2015-09-28 16:39:28 +02:00
Eric Lippmann c3b085cf7f lib: Respect Cache-Control: no-cache
fixes #9688
2015-09-28 15:59:11 +02:00
Eric Lippmann d03647f2e6 JS: Rename dblclickselect to selectable
refs #9826
2015-09-28 15:44:25 +02:00
Eric Lippmann 9dff864b80 Prepare markup for new user menu
refs #5543
2015-09-28 14:48:54 +02:00
Eric Lippmann 2ff822c2ac Merge branch 'master' into feature/ipv6-addresses-9645-9826 2015-09-28 13:09:30 +02:00
Johannes Meyer 2f9bd78721 Merge branch 'master' into bugfix/Prettify-page-layout-when-accessing-a-non-existent-route-while-not-being-authenticated-10009 2015-09-28 09:55:07 +02:00
Johannes Meyer d627f419ef Fix that an object's notes and action url label is escaped twice
fixes #10218
2015-09-28 09:05:17 +02:00
Eric Lippmann ab50fcc091 CSS: Introduce .primary-nav
refs #5543
2015-09-27 16:06:46 +02:00
Eric Lippmann 8cd715f2d4 CSS: Include main.less after nav.less
refs #5543
2015-09-27 16:00:19 +02:00
Eric Lippmann 2996cb77ab Navigation: Close the navigation item after all children have been rendererd
refs #5543
2015-09-27 15:43:49 +02:00
Eric Lippmann 63e0549618 Navigation: Support empty labels for creating containers
refs #5543
2015-09-27 15:42:26 +02:00
Eric Lippmann 9115e1d834 CSS: Move monitoring/colors.less to application
refs #5543
2015-09-27 14:28:36 +02:00
Eric Lippmann d59b09ca48 Fix badge markup in the BadgeNavigationItemRenderer
refs #5543
2015-09-27 14:16:51 +02:00
Eric Lippmann 30ed3ad760 Fix badge markup in the BadgeMenuItemRenderer
refs #5543
2015-09-27 14:16:36 +02:00
Eric Lippmann 4c798d4e04 Fix coding style in the SummaryNavigationItemRenderer
refs #5543
2015-09-27 14:16:10 +02:00
Eric Lippmann 181f6d5285 CSS: Re-add form.less but w/ out-commented content
refs #5543
2015-09-27 13:37:35 +02:00
Eric Lippmann 901a5b6d34 lib: Remove obsolete navigation renderer classes
refs #5543
2015-09-27 13:32:14 +02:00
Eric Lippmann 9789aed870 lib: Fix navigation renderer usage in the limiter widget
refs #5543
2015-09-27 13:29:22 +02:00
Eric Lippmann a9f0aa6bcd lib: Fix navigation usage in the limiter widget
refs #5543
2015-09-27 13:22:43 +02:00
Eric Lippmann d79a160547 Navigation: Disable ids on li for the moment
refs #5543
2015-09-27 13:11:49 +02:00
Eric Lippmann d3ac1b16ee Merge branch 'master' into feature/dope-layout-5543 2015-09-27 13:11:11 +02:00
Eric Lippmann ed9a6aa39d lib: Fix Navigation::addItem()
refs #5543
2015-09-27 12:26:58 +02:00
Alexander A. Klimov ed935696ac CSS: outsource .logo related rules into a new .less file `logo.less'
refs #10009
2015-09-25 15:31:39 +02:00
Johannes Meyer a55cced039 Merge branch 'master' into feature/custom-menu-items-5600
Conflicts:
	modules/monitoring/application/views/scripts/list/comments.phtml
	modules/monitoring/application/views/scripts/list/downtimes.phtml
2015-09-25 14:12:43 +02:00
Eric Lippmann 7ff74ae36a lib: Use navigation classes in the limiter control
refs #5543
2015-09-25 13:36:28 +02:00
Eric Lippmann 823a2cc8ea CSS: Add nav.less and limiter.less to our stylesheet
refs #5543
2015-09-25 13:36:04 +02:00
Eric Lippmann 1122ffafad lib: Add navigation classes (WIP)
- Lacks custom renderer functionality
- Lacks navigation item priorities
- Lacks permission handling

refs #5600
2015-09-25 13:16:44 +02:00
Eric Lippmann 59b9155ca7 CSS: Include dev.less in our style sheet
refs #5543
2015-09-25 00:35:12 +02:00
Johannes Meyer 165dc00fad Url: Do not throw ProgrammingError if there is no relative url available
refs #5600
2015-09-24 14:03:15 +02:00
Eric Lippmann 27f3dd94d2 CSS: Add text-small to time-since, -until and -ago
refs #5543
2015-09-24 10:28:56 +02:00
Eric Lippmann 5b1e4f0a1c CSS: Add new main.less to our stylesheet
refs #5543
2015-09-23 13:41:39 +02:00
Eric Lippmann 2e9ea40eb1 CSS: Disable main-content.less for now
refs #5543
2015-09-23 13:37:19 +02:00
Eric Lippmann e982735451 CSS: Rename main.less to base.less
refs #5543
2015-09-23 13:36:25 +02:00
Eric Lippmann d1b141d142 CSS: Include main.less in our stylesheet
refs #5543
2015-09-23 11:01:55 +02:00
Eric Lippmann 12227d9d08 CSS: Disable defaults.less for now
refs #5543
2015-09-23 10:57:39 +02:00
Eric Lippmann 8b9cdc5c1e CSS: Include normalize.css in our style sheet
refs #5543
2015-09-23 10:43:43 +02:00
Johannes Meyer 5193fce1dd Url: Fix external url detection
refs #5600
2015-09-22 16:18:27 +02:00
Johannes Meyer 81e13109fc Revert "Url: Add support macros"
This reverts commit 33231d24da.
There is no need for url macros, since we're handling absolute
urls correctly now.
2015-09-22 15:51:00 +02:00
Johannes Meyer 33231d24da Url: Add support macros
refs #5600
2015-09-22 14:15:04 +02:00
Johannes Meyer 7321d67b4f Url: Consider urls with a leading slash as absolute..
..and make it possible to have a url without a base.

refs #5600
2015-09-22 14:14:41 +02:00
Johannes Meyer 3c7155f246 NavigationItemRenderer: Pass external urls through the iframe module
refs #5600
2015-09-21 14:13:10 +02:00
Johannes Meyer 7e460e7c03 Url: Remove redundant slash on urls without path 2015-09-21 14:04:36 +02:00
Johannes Meyer 776d06d6ca Url: Fix host check in fromPath()
refs #5600
2015-09-21 14:03:53 +02:00
Johannes Meyer c8d3aa2517 Url: Support external urls in fromPath()
refs #5600
2015-09-21 13:10:35 +02:00
Johannes Meyer 3aaf726856 Update CSS style used for the navigation
refs #5600
2015-09-21 11:13:05 +02:00
Johannes Meyer 76cf01869e NavigationItem: Add property $target
refs #5600
2015-09-21 10:18:46 +02:00
Eric Lippmann 46ab8d847d Forms: Wrap the label and the help icon in a div
refs #5543
2015-09-19 21:58:02 +02:00
Eric Lippmann a92c0de52f CSS: Disable all form styles for the moment
refs #5543
2015-09-19 21:57:29 +02:00
Eric Lippmann cf8548a29d CSS: Add Icinga theme (WIP)
refs #5543
2015-09-18 15:25:14 +02:00
Johannes Meyer d4a9198310 Navigation: Only fail if there's really no chance to create the requested hierarchy
refs #5600
2015-09-17 14:42:02 +02:00
Johannes Meyer b6fe6ffd6b Navigation: Relax type check in method fromConfig()
refs #5600
2015-09-17 13:41:28 +02:00
Eric Lippmann 79c9a8af9b lib: Fix Number::isValid(), again :) 2015-09-17 12:52:09 +02:00
Johannes Meyer 83bde3aa81 Form: Rename property $parent to $_parent
Zend.. I love you..
2015-09-17 11:23:47 +02:00
Johannes Meyer 4f5a5c83bc Navigation: Add method hasRenderableItems()
refs #5600
2015-09-17 11:01:06 +02:00
Johannes Meyer bf4e492fa1 Action: Accept and apply option "filter"
refs #5600
2015-09-17 11:00:40 +02:00
Johannes Meyer b1ee12f721 NavigationItem: Allow to dynamically decide whether to render an item
refs #5600
2015-09-17 09:11:17 +02:00
Johannes Meyer 84f733b177 DashboardPane: Rename param $order to $ordered in method getDashlets
refs #5600
2015-09-17 08:25:17 +02:00
Johannes Meyer 54d08f99e8 DashboardPane: Order dashlets alphabetically
refs #5600
2015-09-16 15:31:41 +02:00
Johannes Meyer 8b7a1ce28f Late translate a module's dashboard-pane/dashlet labels
refs #5600
2015-09-16 14:29:33 +02:00
Johannes Meyer d0eb61dc2e Form: Add property $parent
refs #5600
2015-09-15 16:09:33 +02:00
Johannes Meyer 1d6ad6df21 Merge branch 'master' into feature/custom-menu-items-5600
Conflicts:
	modules/monitoring/configuration.php
2015-09-15 13:31:30 +02:00
Eric Lippmann e8c21868ff lib: Fix Number::isValid()
- Calls $this->translate()
- Always performs is_numeric check, even if the element is not required
2015-09-07 16:57:09 +02:00
Eric Lippmann b897813e71 lib: Add Form::setRequest() 2015-09-07 13:55:52 +02:00
Eric Lippmann 1fb613e811 api/forms: Fix array access of a notification
refs #9606
2015-09-07 13:49:53 +02:00
Eric Lippmann d3fe1e1973 api/response: Allow setting null as success data
refs #9606
2015-09-07 13:45:13 +02:00
Eric Lippmann b20eb681c0 api/forms: Use the first success notification as success message
refs #9606
2015-09-07 13:44:46 +02:00
Eric Lippmann f467d085b0 api: Use JsonResponse in form
refs #9606
2015-09-07 13:36:12 +02:00
Johannes Meyer 21180e2fd4 NavigationItem: Fix method conflictsWith()
...

refs #5600
2015-09-07 13:26:44 +02:00
Johannes Meyer 6b13f2a987 NavigationRenderer: Do not render an empty header
refs #5600
2015-09-07 13:25:25 +02:00
Eric Lippmann 25abc16e15 lib: Replace Repsonse::sendJson() w/ Response::json()
refs #9606
2015-09-07 13:24:21 +02:00
Eric Lippmann a9cb8bfb2c lib: Add JsonResponse class
refs #9606
2015-09-07 13:22:58 +02:00
Johannes Meyer f9441c91d5 Navigation: Load shared navigation items
refs #5600
2015-09-07 13:22:36 +02:00
Johannes Meyer ee43fdad0a DashboardPane: Consider dashlets when merging
refs #5600
2015-09-07 13:21:31 +02:00
Johannes Meyer bf2cb9ab7e NavigationItem: Provide a more sophisticated conflict detection
refs #5600
2015-09-07 13:20:49 +02:00
Johannes Meyer 0feaec7af1 NavigationItem: Return a instance of Url in method getUrl(), really
refs #5600
2015-09-07 13:20:17 +02:00
Johannes Meyer 451a0c91f2 NavigationItem: Add missing return statement in method merge()
refs #5600
2015-09-07 13:19:36 +02:00
Johannes Meyer f958a1c323 Navigation: Load a user's navigation items
refs #5600
2015-09-07 12:20:14 +02:00
Johannes Meyer 411c6e0546 Navigation: Fix that a module's item class is not found
refs #5600
2015-09-07 12:01:05 +02:00
Eric Lippmann 0f8c28d749 Merge branch 'master' into feature/api-9606 2015-09-07 11:33:44 +02:00
Johannes Meyer f9b68b683b NavigationItem: Consider unknown properties as element attributes
refs #5600
2015-09-07 09:49:05 +02:00
Johannes Meyer ca72bd5455 NavigationRendererInterface: Use "div" as default outer element tag
"nav" is less often necessary.

refs #5600
2015-09-07 09:48:32 +02:00
Johannes Meyer e63e15e471 Add class DashboardPane
refs #5600
2015-09-07 09:06:40 +02:00
Johannes Meyer b5711f4031 Dashboard: Load panes by utilizing the new Navigation
This is only a quick fix to avoid adjusting the complete dashboard
implementation.

refs #5600
2015-09-07 09:05:50 +02:00
Johannes Meyer a3539b0817 Navigation: Fix method getActiveItem() failing badly for empty navigations
refs #5600
2015-09-07 08:37:06 +02:00
Johannes Meyer 6dd49761ff Navigation: Add method getActiveItem()
refs #5600
2015-09-04 16:21:09 +02:00
Johannes Meyer 6967fffb1f Navigation: Add support dashboard-panes and check module permissions
refs #5600
2015-09-04 15:51:51 +02:00
Johannes Meyer 2af06e9415 NavigationItem: Re-introduce a default priority of 100
refs #5600
2015-09-04 14:20:21 +02:00
Johannes Meyer b2a0f1b9c2 Navigation: Peform a case-insensitive search when merging items
refs #5600
2015-09-04 14:17:16 +02:00
Johannes Meyer 63f8f34c15 Navigation: Add method load()
Supports currently only module menus.

refs #5600
2015-09-04 13:55:31 +02:00
Johannes Meyer 881880f18f SummaryNavigationItemRenderer: Fix method getTitle()
refs #5600
2015-09-04 13:48:29 +02:00
Johannes Meyer 8e24ec978d BadgeNavigationItemRenderer: Use view() instead of getView()
refs #5600
2015-09-04 13:47:57 +02:00
Johannes Meyer 044fe031da NavigationItemRenderer: Add method init()
refs #5600
2015-09-04 13:47:38 +02:00
Johannes Meyer 1a42c04c8e NavigationItem: Fix locating a module's custom navigation renderer
refs #5600
2015-09-04 13:47:17 +02:00
Matthias Jentsch ca33e71f2d Deduplicate and clean up service summary component
Remove redundant component view script and streamline subFilter handling in all views that render it. Remove
heading from component to allow embedding in different types of views.

refs #10033
2015-09-04 13:02:57 +02:00
Johannes Meyer 5ff3db8a3c Url: Explicitly handle '#'
Feels like a quick&dirty solution. Feel free to improve it.

refs #5600
2015-09-04 10:34:39 +02:00
Johannes Meyer 07588595f2 NavigationItem: Automatically determine whether it's active or not
refs #5600
2015-09-04 10:10:33 +02:00
Johannes Meyer baefc89f85 NavigationRenderer: Provide a id for outer item markup (<li>)
refs #5600
2015-09-04 09:41:39 +02:00
Johannes Meyer 2855778dc7 Revert "NavigationItemRenderer: Provide a id if none is set"
This reverts commit c60839d798.
2015-09-04 09:38:03 +02:00
Johannes Meyer 975cc92f6b NavigationItem: Provide "#" as default url for items with children
refs #5600
2015-09-04 09:31:23 +02:00
Johannes Meyer 4e948b46bf NavigationRenderer: Add id "navigation" to the navigation's heading
refs #5600
2015-09-04 09:26:28 +02:00
Johannes Meyer c60839d798 NavigationItemRenderer: Provide a id if none is set
refs #5600
2015-09-04 09:25:58 +02:00
Johannes Meyer a8d5a78aa2 NavigationItem: Fix method getUniqueName()
refs #5600
2015-09-04 09:25:25 +02:00
Johannes Meyer a6b2c23684 Update navigation rendering code to fit the previous adjustments
refs #5600
2015-09-04 09:08:20 +02:00
Johannes Meyer 9e558c9861 Add class SummaryNavigationItemRenderer
refs #5600
2015-09-03 15:53:42 +02:00
Johannes Meyer ad6a2938ab Add class BadgeNavigationItemRenderer
refs #5600
2015-09-03 15:53:23 +02:00
Johannes Meyer b53fb04a0f Move navigation related renderer classes to the new namespace
refs #5600
2015-09-03 15:52:37 +02:00
Johannes Meyer 7adfc58878 NavigationItem: Add missing return keyword in method render()
refs #5600
2015-09-03 15:04:39 +02:00
Johannes Meyer a930ea7f7a Navigation: Add method render()
refs #5600
2015-09-03 15:04:07 +02:00
Johannes Meyer 9a725330fb NavigationItem: Provide the item to the renderer before calling render
refs #5600
2015-09-03 14:22:38 +02:00
Johannes Meyer 16ece09b0a NavigationItemRenderer: Add option $target
refs #5600
2015-09-03 13:36:34 +02:00