Commit Graph

5021 Commits

Author SHA1 Message Date
Johannes Meyer a2009913c9 WithCommentCommand: Utilize `CommandAuthor` 2020-05-14 13:51:21 +02:00
Johannes Meyer b4e7d80807 Introduce trait `CommandAuthor` 2020-05-14 13:50:48 +02:00
Johannes Meyer 4aab354b7f PluginOutput: Adjust html detection regex again 2020-05-13 17:16:22 +02:00
Johannes Meyer 5d603cd026 Macro: Also resolve `service.name` to `service_description`
resolves #4000
2020-05-13 15:32:44 +02:00
Johannes Meyer 87e676e1fb customvars.phtml: Show a customvar name as-is
Don't uppercase first, exchange `_` for spaces and lower everything else

resolves #3987
2020-05-13 14:56:58 +02:00
Johannes Meyer d6151f8413 translation: Remove instructions to create application locales
The translation module should only be used for third party
modules now.
2020-05-12 12:13:48 +02:00
Johannes Meyer 335dde7b68 WebModuleRequirement: Strip leading `v` from a module's version 2020-05-05 16:26:39 +02:00
Thomas Gelf bdea1bfd47 Query\*notificationQuery: add missing host_alias
Fixes an Exception when searching for a specific alias (as offered in
the filter form)
2020-05-04 12:26:49 +02:00
Johannes Meyer d585a37641 setup: Introduce class `WebModuleRequirement` 2020-04-30 16:43:24 +02:00
Johannes Meyer 6a4b07a0f7 Remove `required => true` from skip validation switches 2020-04-20 14:44:35 +02:00
Johannes Meyer f581c67aeb WebWizard: Allow config validation also for icingadb pages 2020-04-20 14:26:18 +02:00
Johannes Meyer a6bacd0dc3 ModulePage: Select icingadb by default if installed 2020-04-20 11:16:38 +02:00
Johannes Meyer a087089025 monitoring: Update module description in module.info 2020-04-20 11:16:10 +02:00
Johannes Meyer abef0621ff forms: Remove `required => true` from force creation checkboxes 2020-04-20 09:04:04 +02:00
Johannes Meyer 5ace00ed0b list/servicegrid: Make problems only work in no-js envs 2020-04-15 09:42:36 +02:00
Johannes Meyer 9c2f6f4fd7
Merge pull request #4008 from Al2Klimov/bugfix/checkbox-required
Form: allow checkboxes to be required
2020-04-09 16:05:42 +02:00
Johannes Meyer dfda22017b TacticalController: Subtract not checked count from pending count
Pending counts include not checked objects as well

fixes #3280
2020-04-09 16:04:36 +02:00
Johannes Meyer e01852f34b Update `required` attribute of all forms
Some were missing it, some were adding it unnecessarily.
Since it's now displayed what's required this needed to
be streamlined.
2020-04-09 14:39:52 +02:00
Feu Mourek d7a8765fc9 Add appropriate aria labels to tactical overview 2020-04-09 08:36:29 +02:00
Johannes Meyer d72bdc2c32 Raise version to 2.8.0-rc1 2020-03-13 10:40:35 +01:00
Johannes Meyer 13a329ba20 Update po files of all available locales 2020-03-13 10:40:35 +01:00
Johannes Meyer cd738e858c Update de_DE translations
fixes #3994
2020-03-13 10:40:35 +01:00
Johannes Meyer 1c8e487588 setup: Fix scroll issues in the wizard 2020-02-28 09:33:15 +01:00
Johannes Meyer 201e2f136d ScheduleServiceCheckCommandForm: Only ignore services if rescheduling is restricted 2020-01-31 16:07:56 +01:00
Johannes Meyer 6d6e235e5c ScheduleHostCheckCommandForm: Only ignore hosts if rescheduling is restricted 2020-01-31 16:07:56 +01:00
Johannes Meyer b555c4bd8b
Merge pull request #4047 from Icinga/fix/firefox-layout-issues
Fix Firefox layout issues
2020-01-16 16:05:44 +01:00
Eric Lippmann 154357aa11 DeleteDowntimesCommandForm: Allow iterable for setDowntimes()
The command form loops over the downtimes to delete. It is not necessary
to expect an array here. The Icinga DB web module passes an iterable
here.
2020-01-14 14:36:50 +01:00
Eric Lippmann 9ddd941b42 DeleteCommentsCommandForm: Allow iterable for setComments()
The command form loops over the comments to delete. It is not necessary
to expect an array here. The Icinga DB web module passes an iterable
here.
2020-01-14 14:30:50 +01:00
Johannes Meyer 82733f321e css: Fix collapsed border spacing in FF in list views
fixes #4043
2020-01-13 16:01:50 +01:00
Bernd Arnold ffadceafd7 Fixed %s database name in DE translation
At the end of the Icinga Web 2 setup procedure, there's a nice welcome greeting.

Since there's no database name in the [original message], there's no text that could be replaced by the %s.

This is untested. Please let me know if there are other lines/files that have to be changed in order to make this work.

Kind regards,
Bernd

[original message] 81bb5272b5/modules/setup/library/Setup/Steps/DatabaseStep.php (L252)
2020-01-13 13:53:57 +01:00
Valentina Da Rold 48fb288206 Add EventDetailsExtensionHook and include it into EventController 2020-01-13 09:33:24 +01:00
Johannes Meyer d79feca63f
Merge pull request #3969 from WuerthPhoenix/custom-tab-hook
Add custom tab hook
2019-12-12 15:55:25 +01:00
Johannes Meyer 7417349cec
Merge pull request #4025 from papillon326/master
Update Japanese translation
2019-12-12 14:00:38 +01:00
Florian Strohmaier e1c47a8f59 module.less: Fix status-bar height 2019-12-11 11:14:34 +01:00
Johannes Meyer da5704fa83
Revert "Introduce option to hide specific customvars in web" 2019-12-10 07:56:11 +01:00
papillon326 be5a6a4251 Update Japanese translation 2019-12-09 18:15:20 +09:00
Johannes Meyer 33cb90b0e3 monitoring: Also consider normal acknowledgements for acke`d problems 2019-12-09 08:42:13 +01:00
Florian Strohmaier 8ebc04f2c1 Monitoring: Beautify quick-action item hover 2019-12-06 15:36:34 +01:00
Florian Strohmaier 955ab298f7 CSS: Flex layout to container contents 2019-12-06 15:36:34 +01:00
Florian Strohmaier 098898eca6 Services/Hosts: Remove status-bar-ghost 2019-12-06 15:36:34 +01:00
Johannes Meyer b8f8187762 AuthBackendPage: Fix crash when external authentication is chosen
Only occurred due to PHP 7.4
2019-12-06 15:34:56 +01:00
Johannes Meyer a6d2590666 hosts/services: Remove `*_active_checks_enabled` from a redirect's filter
Actually only a quick fix but who cares..
2019-12-05 15:42:47 +01:00
Johannes Meyer bb7f1cd24b monitoring: Apply permission `no-monitoring/contacts` where applicable 2019-12-05 08:50:51 +01:00
Johannes Meyer a9d5f2a6f0 monitoring: Provide new permission `no-monitoring/contacts` 2019-12-05 08:50:14 +01:00
Nicolai Buchwitz e7f965e70c fix sytax error (missing space after comma) 2019-12-04 13:06:26 +01:00
Nicolai Buchwitz 55104cba14 Introduce hide customvar option in monitoring view 2019-12-04 13:06:26 +01:00
Johannes Meyer 7b488d7f93 swag: Fix violations of PSR-12
PSR-2 has been deprecated and phpcs v3.5.3
now checks for the successor PSR-12
2019-12-04 11:28:08 +01:00
Feu Mourek 57f966734a Perfdata: add function to get perfdata unit 2019-11-04 11:36:57 +01:00
Johannes Meyer e0be21f655 Raise version to 2.7.3 2019-10-18 07:41:53 +02:00
Johannes Meyer ded92c786a Add missing columns to empty group queries 2019-10-18 07:32:58 +02:00
Johannes Meyer 8e51518e96 ServicegroupQuery: Really join hosts if instructed to do so
fixes #3983
2019-10-17 16:14:28 +02:00
Johannes Meyer 362c30c1dd Raise version to 2.7.2 2019-10-16 08:12:09 +02:00
Johannes Meyer 01bcf980f2
Merge pull request #3965 from Icinga/fix/slow-queries-when-filtering-groups-3928
Enhance query performance when filtering for groups and reduce double query execution
2019-10-16 08:05:30 +02:00
Johannes Meyer bb2673a49a EventController: Use `DateFormatter::formatDateTime` to render dates
fixes #3968
2019-10-14 08:12:35 +02:00
Johannes Meyer cbc12ab31e event-history.phtml: Don't use `hasResult()` to check if there are results
28ec1e236 has no result on history views as they never count their results.
So restructuring this particular view script I deemed reasonable since the
history queries tend to show very poor performance.

refs #3905
refs #3836
2019-10-11 10:27:43 +02:00
Johannes Meyer 908c408d3d ServicegroupsummaryQuery: Fetch empty groups with a union query
refs #3928
2019-10-11 10:27:43 +02:00
Johannes Meyer faca6d53c8 HostgroupsummaryQuery: Add empty groups to the union
refs #3928
2019-10-11 10:27:43 +02:00
Johannes Meyer fae60f06bf Revert "Show empty groups with a filter chain too"
This reverts commit fadf12e98a.
2019-10-08 13:39:52 +02:00
Johannes Meyer 0e729bb85b Revert "ServicegroupQuery: Use left joins instead of inner joins"
This reverts commit 23066d2cc4.
2019-10-08 13:39:52 +02:00
Johannes Meyer 94b0689b95 Revert "HostgroupQuery: Use left joins instead of inner joins"
This reverts commit 4ef085bdcd.
2019-10-08 13:39:52 +02:00
Johannes Meyer 25e1942a9b
Merge pull request #3956 from Icinga/bugfix/checks-wrongly-marked-as-late-3696
Fix checks being marked as late when they are scheduled for later time
2019-10-08 13:39:21 +02:00
Johannes Meyer 8ec0c40f21 monitoring: Fix missing load more link when there's a single row 2019-10-08 13:36:35 +02:00
Johannes Meyer c21867699a ServicestatusQuery: Adjust `next_update` calculation to respect `next_check` 2019-10-08 13:21:43 +02:00
Johannes Meyer b9ea432d35 HoststatusQuery: Adjust `next_update` calculation to respect `next_check` 2019-10-08 13:21:43 +02:00
Johannes Meyer b3c6af4ea6 ToggleObjectFeaturesCommandForm: Use a select instead of radio buttons
refs #3957
2019-10-08 12:39:07 +02:00
Gianluca Piccolo 1e2bd37ae8 Add custom tab hook 2019-10-02 13:42:42 +02:00
Johannes Meyer f4c43ecafb
Merge pull request #3966 from Icinga/fix/invalid-filter-suggestions-in-group-overviews-3940
Fix invalid filter suggestions in group overviews
2019-09-26 14:35:11 +02:00
Johannes Meyer 5352e72d1f
Merge pull request #3946 from Icinga/fix/wrong-dashlet-order-3931
Fix wrong dashlet order
2019-09-26 14:34:13 +02:00
Johannes Meyer b4f1847ec0
Merge pull request #3948 from Icinga/fix/missing-notifications-in-timeline-3947
Fix timeline
2019-09-26 14:33:47 +02:00
Johannes Meyer 97c1c4e215
Merge pull request #3949 from Icinga/feature/relax-html-restrictions-for-plugin-output
PluginOutput: Relax html restrictions
2019-09-26 14:33:14 +02:00
Johannes Meyer d6a630432e Servicegroupsummary: Only provide valid filter columns
refs #3940
2019-09-26 13:48:49 +02:00
Johannes Meyer 2b77baa19f Hostgroupsummary: Only provide valid filter columns
refs #3940
2019-09-26 13:47:56 +02:00
Johannes Meyer f98f988aff Remove tristate form element 2019-09-23 08:36:24 +02:00
Marc DeTrano 6166d1eaf9 Quick fix for timestamp filtering on EventGrid
fixes #3927
2019-09-12 11:25:45 +02:00
Johannes Meyer ab99d25cb5 PluginOutput: Relax html restrictions 2019-09-12 10:50:17 +02:00
Johannes Meyer bfa5f9610b monitoring: Fix timeline
* Fixes extrapolation style
* Fixes missing notifications

fixes #3947
2019-09-12 10:31:41 +02:00
Johannes Meyer d055e43367 monitoring: Define priorities for dashlets
refs #3931
2019-09-09 14:43:28 +02:00
Johannes Meyer c3603c991d downtimes/comments: Don't mark service urls with `.rowaction`
fixes #3920
2019-09-09 12:28:49 +02:00
Florian Strohmaier 00257f163d CSS: Consolidate .object-features styles 2019-09-04 17:21:01 +02:00
Johannes Meyer 04b23811be Raise version to 2.7.1 2019-08-14 13:10:19 +02:00
Eric Lippmann fadf12e98a Show empty groups with a filter chain too 2019-08-14 11:50:14 +02:00
Eric Lippmann 214a34a5a8 Always use subquery filters for subquery targets in the group views 2019-08-13 17:18:50 +02:00
Johannes Meyer b0875d40f1
Merge pull request #3895 from Icinga/fix/dashboard-migration-requires-all-locales
Don't fail dashboard migration just because a locale is missing
2019-08-12 13:33:07 +02:00
Johannes Meyer 86eefe5abf
monitoring: Highlight links in markdown content (#3893)
Doesn't apply to all markdown content. Our only use-case
currently is in the monitoring module and this already got
a known style for external/custom links.

Other modules may want to apply a different style or possibly
none at all.

resolves #3888
2019-08-12 12:58:29 +02:00
Johannes Meyer de0a46aaaf list/servicegrid: Also show problem toggle if the grid is flipped
fixes #3906
2019-08-12 10:43:03 +02:00
Johannes Meyer 53598ecd18 DashboardCommand: Don't swallow custom dashboards 2019-08-02 14:14:28 +02:00
Johannes Meyer 49e84f2ad0 migrate: Don't fail dashboard migration just because a locale is missing 2019-08-02 12:00:26 +02:00
Johannes Meyer 105f32a006 locale: Update de_DE translation of the setup module 2019-07-30 10:36:01 +02:00
Johannes Meyer 7237d7e086 locale: Update de_DE translation of the monitoring module 2019-07-30 10:35:30 +02:00
Eric Lippmann f35946df29 Raise version to 2.7.0 2019-07-30 10:19:53 +02:00
Eric Lippmann 7730058c2c Fix Event Grid PostgreSQL error
PostgreSQL fails with failed to find conversion function from
unknown to text. PostgreSQL won't detect the type of object_type.
Most likely because it's used in a CASE statement and provided by a
subquery:

select case when s.object_type = 'service' then 1 else 0 end from
(select ('service') as object_type) as s;

This commit just removes object_type from the CASE statements because we
don't need them anyway. Recently we've changed the event grid query to
only select hosts or services and not both.
2019-07-30 09:32:59 +02:00
Peter Eckel 718ecd05a7 Fix Icinga 2 version detection
With this commit the version prefix character is treated as optional
which always used to be 'r' or 'v'. But this is gone since Icinga 2
version 2.11.0 RC1.

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2019-07-30 09:32:17 +02:00
Eric Lippmann ac08fb2c3b Fix filtered links in the tactical overview
Filter chains require parantheses to work properly.
2019-07-30 09:17:25 +02:00
Eric Lippmann e61cb71c17 Use unique values for combined AND group membership filters 2019-07-30 09:17:25 +02:00
Eric Lippmann 0de923fc5f Support "old" combined group membership filter in subquery filter chains 2019-07-30 09:17:25 +02:00
Eric Lippmann bee5099a08 Fix show all services links in the servicegroup overview
Before, the forced servicegroup_name paramemter may interfere with an
existing servicegroup_name filter.
2019-07-30 09:17:25 +02:00
Eric Lippmann 58e3ae46a7 Fix servicegroup subquery filter in the servicegroup view 2019-07-30 09:17:25 +02:00
Eric Lippmann cc94c12e55 Fix show all hosts/services links in the hostgroup overview
Before, the forced hostgroup_name paramemter may interfere with an
existing hostgroup_name filter.
2019-07-30 09:17:25 +02:00
Eric Lippmann 9a75e101ee Support subquery filters in filter chains
Before, combined membership filters were only possible in filter
expressions, e.g. hostgroup_name=(a&b). Now, also
(hostgroup_name=a&hostgroup_name=b) is supported which makes it easier
to build such filters with the filter editor.
2019-07-30 09:17:25 +02:00
Johannes Meyer a33fda9dd7
Merge pull request #3846 from Icinga/feature/contact-and-contactgroup-filter
Add contact and contactgroup filters
2019-07-30 09:07:55 +02:00
Johannes Meyer ea3a541017
Merge pull request #3801 from Icinga/feature/improve-host-service-distinction-in-lists-3615
Improve host-service distinction in lists
2019-07-30 08:55:03 +02:00
Johannes Meyer d13cade0f3
Merge pull request #3871 from Icinga/feature/add-servicegrid-problem-toggle-3793
Servicegrid: Add toggle to show problems only or everything
2019-07-30 08:26:46 +02:00
Johannes Meyer b31dd77812
Merge pull request #3676 from Icinga/feature/form-styling
Improve look of our forms
2019-07-30 08:26:08 +02:00
Eric Lippmann 11097fe75b Make host and service names bold in their detail headers 2019-07-29 14:03:40 +02:00
Eric Lippmann 9221e7894c Make host names bold in the event history 2019-07-29 14:03:40 +02:00
Eric Lippmann dc3147c652 Improve host-service distinction for events 2019-07-29 14:03:40 +02:00
Eric Lippmann f7ed5de8c8 Remove icon from event detail tab 2019-07-29 14:03:40 +02:00
Eric Lippmann 135601c0dc Add tab to contact detail 2019-07-29 14:03:40 +02:00
Eric Lippmann b6a399df1a Make host links bold in the comments view 2019-07-29 14:03:40 +02:00
Eric Lippmann 1f4c970cb3 Fix title attributes in the comment header 2019-07-29 14:03:40 +02:00
Eric Lippmann 5b3cbb0ffe Fix title attributes in the downtime header 2019-07-29 14:03:40 +02:00
Eric Lippmann 5993745a86 Select notification id 2019-07-29 14:03:40 +02:00
Eric Lippmann 227cb2c512 Fix grouping error when selecting the notification id 2019-07-29 14:03:40 +02:00
Eric Lippmann 98388c4346 Link to the event detail from the notifications view 2019-07-29 14:03:40 +02:00
Eric Lippmann 99ff058561 Improve host-service distinction for notifications 2019-07-29 14:03:40 +02:00
Eric Lippmann 0500afb013 Make contact group name bold in the contact groups view 2019-07-29 14:03:40 +02:00
Eric Lippmann 0efe72b429 Make contact name bold in the contacts view 2019-07-29 14:03:40 +02:00
Eric Lippmann 4323c060ce Remove icons from notifications view 2019-07-29 14:03:40 +02:00
Jennifer Mourek 9c3da17f2e Improve host-service distinction for hosts, services, comments and
downtimes
2019-07-29 14:03:37 +02:00
Eric Lippmann a94e8fb211 monitoring: Clone the filter for the grid links
Before, it was impossible to change an existing filter via the filter
editor in the host and service group views because of an exception about
wrong IDs.
The filter editor sets the IDs correctly. But since we're adding the
filter again to another URL, FilterChain::addFilter() overrides the IDs
because it is not working with a clone.
2019-07-29 13:22:55 +02:00
Johannes Meyer d2a2eae600 css: Re-add `margin:0` removed by 9d0ef4cf3 to `.overview-plugin-output` 2019-07-29 12:24:52 +02:00
Johannes Meyer 66c436b98c BackendConfigForm: Don't wrap resource elements twice with .control-group 2019-07-29 10:19:39 +02:00
Johannes Meyer 4f507d9672 SelectBox: Also use the default form classes 2019-07-29 10:19:39 +02:00
Johannes Meyer dd1a3dfb31 monitoring: Align object feature toggles with baseline 2019-07-29 10:19:39 +02:00
Johannes Meyer c7a3783034 css: Avoid that toggle switches break onto a new line in minimal layout 2019-07-29 10:17:59 +02:00
Johannes Meyer 212606de78 setup: Apply new icinga form style 2019-07-29 10:17:59 +02:00
Johannes Meyer 1b8501d5b7 ToggleInstanceFeaturesCommandForm: Apply icinga form style 2019-07-29 10:17:59 +02:00
Johannes Meyer 721dab93a0 ToggleObjectFeaturesCommandForm: Apply icinga form style 2019-07-29 10:17:59 +02:00
Florian Strohmaier 58a68b4e40 CSS: Remove redundant style attributes 2019-07-29 10:17:59 +02:00
Johannes Meyer b6c89bc863
Merge pull request #3870 from Icinga/feature/collapsible-plugin-output-3566
Collapsible plugin output
2019-07-29 09:33:58 +02:00
Johannes Meyer f32dac7a70 ServicestatusQuery: Add `latency` to next_update calculation..
..and double the entire result

refs #3212
2019-07-29 09:12:46 +02:00
Johannes Meyer 44f63576d1 HoststatusQuery: Add `latency` to next_update calculation..
..and double the entire result

refs #3212
2019-07-29 09:12:46 +02:00
Johannes Meyer 5ead593fa7 monitoring/list/services: Make overdue/unreachable services better visible
refs #3212
2019-07-29 09:12:46 +02:00
Johannes Meyer 18b933679c monitoring/list/hosts: Make overdue/unreachable hosts better visible
refs #3212
2019-07-29 09:12:46 +02:00
Eric Lippmann bcc867d48e Allow to filter for contact groups 2019-07-29 09:12:01 +02:00
Eric Lippmann 2c11f5307d Fix event detail link for notifications 2019-07-26 16:53:13 +02:00
Feu Mourek 4760e55786 Fix typo 'overvies' -> 'overviews' (#3876) 2019-07-26 07:49:48 +02:00
Johannes Meyer 74bf1bdc89 notes.phtml: Collapse notes if they exceed 200px 2019-07-26 07:36:17 +02:00
Johannes Meyer 226b58ac9d customvars.phtml: Collapse custom variables if they exceed 5 rows
Also collapses customvar values if they're JSON blobs and exceed
5 rows.

refs #3566
2019-07-26 07:36:17 +02:00
Johannes Meyer f42a49d4a9 perfdata.phtml: Collapse perfdata values if they exceed 5 lines
refs #3566
2019-07-25 13:22:43 +02:00
Johannes Meyer b61a952cfd output.phtml: Collapse plugin output if it exceeds 100px
refs #3566
2019-07-25 08:17:41 +02:00
Eric Lippmann aa293f54bd Separate icon and event output in the history views 2019-07-23 14:49:39 +02:00
Eric Lippmann 213e7a3c13 Show new notfication types in the history views 2019-07-23 14:48:00 +02:00
Eric Lippmann 54f9c68887 Show notifications before any other event in the history views 2019-07-23 14:48:00 +02:00
Eric Lippmann f80a61d9e5 Respect notification type of subqueries 2019-07-23 14:48:00 +02:00
Eric Lippmann 1d1fd0b3b2 Use notification_reason for new notification types 2019-07-23 14:48:00 +02:00
Johannes Meyer 9d0ef4cf33 Wrap any markdown output with a `<section>` and remove explicit containers 2019-07-23 14:45:32 +02:00
Johannes Meyer b1705ca0e1 list/servicegrid: Add toggle to show problems only or everything
resolves #3793
2019-07-18 15:38:51 +02:00
Johannes Meyer 39fbd3e27e monitoring: Re-add missing query columns to event overview
`hostgroup`, `hostgroup_alias`, `servicegroup`, `servicegroup_alias`

fixes #3848
2019-07-18 14:50:35 +02:00
Johannes Meyer 40529e76ef
Merge pull request #3858 from Icinga/feature/downtime-schedule-times
Require time output for downtime schedule and end/expire times
2019-07-18 08:47:55 +02:00