2a2966fc56
Fix Config.php relocation, fix header.phtml crashing due to old tab rendering
...
refs #4192
2013-08-07 17:51:52 +02:00
488310df37
Fix style and docstrings, exception when removing the last tab
...
refs #4192
2013-08-07 17:45:09 +02:00
9ba3c90931
Rename dashboard folder to work on non case-insensitive fs
...
refs #4192
2013-08-07 17:44:40 +02:00
19764485bc
Add untracked files
...
refs #4192
2013-08-07 17:44:40 +02:00
ec17efe328
Add test for Dimension
...
refs #4192
2013-08-07 17:44:40 +02:00
2b25757e20
Add documentation, add errorhandling and sizing
...
The optional width/height parameter can be set in the ini to change the dashboard components
size, documentation has been added and in the error case a message with the configuration is shown
refs #4192
2013-08-07 17:44:30 +02:00
f8bb478f0e
Update dashboard implementation
...
fix javascript naming (icinga-url to icingaurl), fix add form, add remove
button, code style changes
refs #4192
2013-08-07 17:43:37 +02:00
b3e0d5e8ce
Remove AbstractWidget and make Widget an interface
...
As Widget's already denote an abstract concept, the name
'AbstractWidget' is redundant. Also this class didn't do anything except
fetching a view via a singleton (which is now injected into the render method)
and bypassing the PHP class properties by creating a 'properties' array which is
filled with magic getters and setters (which now are simply php class properties)
Further changes:
- toString is removed, as this incorporated a lot of
application logic which would cause unrecoverable
errors when throwing exceptions
- renderToHtml is now just render and the view dependency must be
passed, as a widget shouldn't be responsible for getting
view instance (this means that <?= $this->tabs ?> is now
<?= $this->tabs->render($this); ?> in the templates
- Controllers don't have $this->widget anymore as Widgets are
directly instanciated with their class, allowing better code completion
and avoiding hidden dependencies, also Widget::create is now removed
in favor of direct instanciation.
refs #4192
2013-08-07 17:41:43 +02:00
4149328216
Merge branch 'feature/ini-writer-for-config-4352'
...
resolves #4352
2013-08-07 16:31:19 +02:00
57257d1af3
Fix coding standard violations
...
resolves #4352
2013-08-07 16:19:15 +02:00
76d7753860
Split up functions in PreservingIniWriter for better readabillity and add better comment handling
...
Split up the function diffPropertyUpdates into two single functions. Change the
IniEditor to "glue" comments to section declarations.
resolves #4352
2013-08-07 15:58:51 +02:00
c1338898a6
Fix errors in function comments and move IniEditor into single class file
...
refs #4352
2013-08-07 15:58:51 +02:00
56e47fd084
Add an ini writer for configuration files
...
Add an ini writer that respects the file structure and the comments that may be
already present in the config file. Move Application/Config.php into
Config/Config.php.
refs #4352
2013-08-07 15:58:42 +02:00
edebbf93ab
Add an IniWriter that preserves the comments in already existing files
...
Add a function to create diffs between two object, add a
FileEditor to edit files line-by-line and add the class PropertyDiff to
describe a single property change.
refs #4352
2013-08-07 15:56:42 +02:00
290c8c5225
CC: Add newline to end of file where missing
...
Following command was used:
$ find application/ library/Icinga/ modules/ -name *.php | xargs sed -i -e :a -e '/./,$!d;/^\n*$/{$d;N;};/\n$/ba;$a\'
2013-08-07 10:27:50 +02:00
ab1673f198
Merge branch 'feature/dynamic-forms-4439'
...
resolves #4439
2013-08-06 15:22:30 +02:00
ff62a82895
Fix dynamic form validation behaviour, fix documentaion, fix correct isValid() call
...
- When a dynamic form is modified, no validation is performed, but
the form is being populated with $this->populate.
- changed parent::isValid to $this->isValid, otherwise no custom validation
logic could be implemented
- Updated documentation
- Fix CSRF protection by removing the time
refs #4439
2013-08-06 15:08:54 +02:00
66592ecabf
Enable dynamic form elements
...
Expire time of the AcknowledgeForm and hours as well as
minutes of the ScheduleDowntimeForm are now dynamic.
refs #4439
2013-08-06 15:06:20 +02:00
f5162189dd
Implement dynamic form elements
...
Rename "isPostAndValid" to "isSubmittedAndValid" and refactor it.
Add possibility for specific form elements to auto-submit their form.
refs #4439
2013-08-06 15:03:25 +02:00
1b9885f274
Merge branch 'bugfix/fix-hostlist-test-4516'
...
fixes #4516
2013-08-06 14:06:49 +02:00
584198f00c
Fix hostlist test
...
refs #4516
2013-08-06 14:06:25 +02:00
7ba6d4a74f
Merge branch 'bugfix/forward-fix-4382'
...
fixes #4382
2013-08-06 13:40:19 +02:00
15999eb880
Change _forward to redirect() to keep url history updates
...
refs #4382
2013-08-06 13:39:10 +02:00
4befc9be94
Merge branch 'feature/preferences-backend-4069'
...
resolves #4069
2013-08-06 12:04:16 +02:00
27ae3ceb35
Merge branch 'feature/dynamic-forms-4439'
...
fixes #4439
2013-08-06 11:46:15 +02:00
d78a5338df
Rename ConfirmationForm and ConfirmationWithIdentifierForm
...
Rename ConfirmationForm to CommandForm and
ConfirmationWithIdentifierForm to CommandWithIdentifierForm.
refs #4439
2013-08-06 11:14:56 +02:00
3ad4a4281d
Add missing form tests and update documentation
...
refs #4439
2013-08-06 11:11:29 +02:00
5533b632ed
Fix code style and make form name non mandatory
...
refs #4439
2013-08-06 11:11:29 +02:00
f26af0eb12
Update command form tests
...
Update command form tests so that they reflect the new dynamic
functionality and the correct purpose of "isSubmittedAndValid".
refs #4439
2013-08-06 11:11:28 +02:00
8efbe6f613
Move submit and cancel handling
...
Move submit and cancel handling from ConfirmationForm to Form.
refs #4439
2013-08-06 11:11:28 +02:00
fa7379adc7
Enable dynamic form elements
...
Expire time of the AcknowledgeForm and hours as well as
minutes of the ScheduleDowntimeForm are now dynamic.
refs #4439
2013-08-06 11:09:42 +02:00
98e7ab02db
Implement dynamic form elements
...
Rename "isPostAndValid" to "isSubmittedAndValid" and refactor it.
Add possibility for specific form elements to auto-submit their form.
refs #4439
2013-08-06 11:09:42 +02:00
cc77a55435
Merge branch 'feature/send-commands-4441'
...
resolves #4441
2013-08-06 09:58:42 +02:00
c9c5e6ef3c
Send commands: Review fixes
...
refs #4441
2013-08-06 09:32:27 +02:00
a58c933a29
Code style and comment fixes
...
refs #4441
2013-08-06 09:32:27 +02:00
7675ea0514
Call commandhandler from commandcontroller actions
...
The CommandController now implements the calls to the specific
command methods and sends commands to the icinga process
refs #4441
2013-08-06 09:31:13 +02:00
1894054929
Implement first commands, fix obsessing state
...
refs #4441
2013-08-06 09:30:25 +02:00
029ff17cec
Add documentation for instances.ini
...
refs #4441
2013-08-06 09:27:37 +02:00
c2781f4969
Fix test cases for Confirmation forms
...
refs #4441
2013-08-06 09:27:37 +02:00
4f1e6ec720
Code style and comment fixes
...
refs #4441
2013-08-06 09:27:37 +02:00
81c2f3b9de
Add list of objects that are affected by a command
...
refs #4441
2013-08-06 09:27:37 +02:00
b44de95caa
Call commandhandler from commandcontroller actions
...
The CommandController now implements the calls to the specific
command methods and sends commands to the icinga process
refs #4441
2013-08-06 09:27:37 +02:00
2091f63c3b
Implement first commands, fix obsessing state
...
refs #4441
2013-08-06 09:27:37 +02:00
d6bbed3a54
Extract the transport functions from the CommandPipe
...
- The CommandPipe class now delegates submission of commands to
the Transport classes (LocalPipe or SecureShell)
- Added SSH options for non-interactive mode
- Refactored tests
refs #4441
2013-08-06 09:27:37 +02:00
512676ec1a
User preferences: Review fixes
...
refs #4069
2013-08-05 16:56:03 +02:00
8f1a3b228b
User preferences: remove test code
...
refs #4096
2013-08-05 16:56:03 +02:00
944c9c13e9
User preferences: Doc fixes
...
refs #4069
2013-08-05 16:56:03 +02:00
cc9b18376d
User preferences: Add doc, fix initial session write
...
refs #4069
2013-08-05 16:56:03 +02:00
6112189b0c
User preferences: Add database store
...
refs #4069
2013-08-05 16:56:03 +02:00
f3ed73175b
User preferences: Session store and glue to build instance
...
refs #4069
2013-08-05 16:56:02 +02:00
Jannis Moßhammer
Matthias Jentsch
Eric Lippmann
Johannes Meyer
Marius Hein