Matthias Jentsch
31618ce2cf
Fix unit DB Form unit tests broken by inspection
...
refs #9641
2015-07-16 16:15:27 +02:00
Matthias Jentsch
f4054d575b
Add Inspection API to db connection
...
refs #9641
2015-07-16 15:29:45 +02:00
Matthias Jentsch
3cd6d2e490
Merge branch 'feature/add-inspectable-api-to-db-and-ldap-connections-9630'
...
resolves #9630
2015-07-16 13:56:56 +02:00
Matthias Jentsch
c55ba6dff4
fix coding guideline violations
2015-07-16 13:51:35 +02:00
Matthias Jentsch
ffe672c252
Improve message texts and scalabillity
...
Always start uppercase and don't use count() function until we've got a more scalable implementation in the LdapConnection.
refs #9630
2015-07-16 13:51:26 +02:00
Matthias Jentsch
da5ceb0e73
Fix broken unit tests
...
Fix unit tests that were broken by API changes to the resource form classes and contemplate life choices.
refs #9630
2015-07-16 12:54:37 +02:00
Matthias Jentsch
6b8e5da76d
Move all assertion functions into the inspect functions
...
Reduce code duplication and add class Inspection
refs #9630
2015-07-16 12:21:11 +02:00
Matthias Jentsch
59c4f8d056
Use Inspection API in User Backend Form
...
refs #9630
2015-07-15 19:35:25 +02:00
Matthias Jentsch
cf8b760ade
Use Inspection API in LdapResourceForm
...
refs #9630
2015-07-15 19:33:47 +02:00
Matthias Jentsch
276aa43aa2
Upgrdae Inspection API again
...
Do not use InspectionException any more to reduce complexity of nested inspections, but keep error states
in the Inspection object itself.
refs #9630
2015-07-15 18:39:09 +02:00
Matthias Jentsch
6762ef053e
Upgrade Inspection API
...
Reduce code duplication and stateffullnes by using InspectionException to indicate that an error was thrown, and only using one inspect function.
refs #9630
2015-07-15 17:51:18 +02:00
Matthias Jentsch
11360f36e4
Fix grammar errors in backend titles
2015-07-15 15:37:59 +02:00
Matthias Jentsch
774d6ce94a
Fix invalid function call in getCapabilities caused by refactoring
2015-07-15 15:36:32 +02:00
Matthias Jentsch
930303dfb2
Merge branch 'bugfix/ldap-connection-fail-when-encryption-not-possible-9608'
...
fixes #9608
2015-07-15 12:50:49 +02:00
Matthias Jentsch
af58d6964b
Fix isEncrypted function broken by refactaring
...
refs #9608
2015-07-15 12:23:30 +02:00
Matthias Jentsch
7daa97a166
Clean up unneded code
...
Remove the now useless error handling cases in case encryption wasn't successful.
refs #9608
2015-07-15 11:31:56 +02:00
Matthias Jentsch
3b8b5b0022
Revert accidentally commited unneded changes
2015-07-15 11:16:06 +02:00
Matthias Jentsch
6db80f1e74
Merge branch 'feature/ldap-connection-test-function-9605'
...
fixes #9605
2015-07-15 10:50:02 +02:00
Matthias Jentsch
212111511a
Fix violations of coding guidelines
2015-07-15 10:32:54 +02:00
Matthias Jentsch
84899e3e56
Revert some unneeded changes
...
refs #9605
2015-07-15 09:56:18 +02:00
Johannes Meyer
9a90e2a183
Wizard: Be less hysteric to not to make users upset
...
fixes #9620
2015-07-15 08:50:39 +02:00
Matthias Jentsch
f4d8bfc309
Display connection test info when inspecting LdapConnections
...
refs #9605
2015-07-14 18:36:26 +02:00
Matthias Jentsch
3ddb8ca1bd
Add abillity to discover AD version and vendor name to discovery
...
refs #9605
2015-07-14 18:32:44 +02:00
Matthias Jentsch
40d432100b
Add a function to test the connection health
...
refs #9605
2015-07-14 18:29:58 +02:00
Matthias Jentsch
6599940e6c
Introduce Interface for inspecting ldap connections
...
refs #9605
2015-07-14 12:30:16 +02:00
Johannes Meyer
8b4c2c459a
comments overview: Improve link titles
2015-07-13 12:51:50 +02:00
Johannes Meyer
d6f756c670
downtimes overview: Improve link titles
2015-07-13 12:51:12 +02:00
Johannes Meyer
c90da0378d
downtimes overview: Fix detail links
2015-07-13 12:17:00 +02:00
Johannes Meyer
3db81a8d0f
downtimes-header: Do not show links with a bold font
2015-07-10 15:46:24 +02:00
Johannes Meyer
d0a588ef58
downtimes-header: Do not access a non-existent property, again
...
I don't get it..
2015-07-10 15:43:07 +02:00
Johannes Meyer
ac8a2d1673
downtimes-header: Show proper times for fixed downtimes not yet started
2015-07-10 15:41:42 +02:00
Johannes Meyer
831581471c
downtimes/show.phtml: Drop redundant link title
...
Such a title has not any advantage as it contains the same content
as the link label.
2015-07-10 15:17:25 +02:00
Johannes Meyer
3091b8cf5c
downtimes/show.phtml: Do not show an (inappropriate) icon in the title
2015-07-10 15:16:16 +02:00
Johannes Meyer
52bde67653
Link: Show the link's label in its title as well
2015-07-10 15:12:56 +02:00
Johannes Meyer
9ca1a6dea6
downtimes-header: Add links for hosts and services
2015-07-10 15:11:59 +02:00
Johannes Meyer
4fd5c43c70
downtimes-header: Show a line-break between an object's name and..
...
..a downtime's description
2015-07-10 14:44:24 +02:00
Johannes Meyer
e8f16d112d
downtimes-header: We're listing downtimes rather than showing them
2015-07-10 14:43:36 +02:00
Johannes Meyer
006d2cb537
downtimes-header: Be more efficient when listing downtimes
2015-07-10 14:39:30 +02:00
Johannes Meyer
bba57d2bbc
downtimes-header: Use <strong> instead of <b>
2015-07-10 14:32:08 +02:00
Johannes Meyer
5ded76536e
downtimes-header: Use the correct property to access a service's name
...
Seems to me that no-one has ever selected multiple service downtimes..
2015-07-10 14:30:07 +02:00
Johannes Meyer
e5f62f017f
DeleteCommentCommandForm: Show a trash icon instead
...
The "cancel" icon is, like its name implies, supposed to abort/close
something..
2015-07-10 14:26:39 +02:00
Johannes Meyer
23f7570ce0
LdapConnection: Don't run a discovery when preparing a new connection
...
fixes #9179
2015-07-10 10:45:10 +02:00
Johannes Meyer
a8ac420897
LdapConnection: Establish a connection lazily
2015-07-10 09:51:39 +02:00
Matthias Jentsch
39df25f043
Fix HTML detection in PluginOutput
...
refs #9036
2015-07-08 15:16:32 +02:00
Johannes Meyer
fc8b51c4be
ObjectList: Register columns to select even if we're only counting
...
We should never apply any pseudo optimizations on a higher level if
already the lower level applies them, as the optimization might not
be valid in every circumstance.
fixes #9573
2015-07-07 15:50:40 +02:00
Johannes Meyer
f5089dab1a
DbUserGroupBackend: Use is_numeric() instead of is_int()
...
Using MySQL fetchColumn() returns integers for id fields, using MariaDB
though, fetchColumn() returns strings..
fixes #9572
2015-07-07 14:07:55 +02:00
Matthias Jentsch
604ef87de8
Merge branch 'bugfix/plugin-output-always-escaped-9036'
...
fixes #9036
2015-07-07 10:24:54 +02:00
Matthias Jentsch
4f884b1529
Revert "Don't use HTMLPurifier in list views to improve performance"
...
Performance gain turned out to be insignificant. This reverts commit 17bb725f84
.
refs #9036
2015-07-07 10:17:04 +02:00
Matthias Jentsch
17bb725f84
Don't use HTMLPurifier in list views to improve performance
...
refs #9036
2015-07-06 17:14:36 +02:00
Johannes Meyer
3098c21c17
loader.js: Push failed requests to history
...
The commit ae68e8aec4
reverted
earlier seems to be supposed to do exactly what this one does now.
Prior, the commits ae68e8aec4
and
8bb0e4e0a0
were effectively
neutralizing each other. Quick tests of how Web 2 handles failing
requests while interacting with the browser's history were successful.
If this change breaks something else (again?), leave me a note and do
*not* fix it straight away..
2015-07-06 16:56:44 +02:00