tyler.durden/icingaweb2
1
0
Fork 0
mirror of https://github.com/Icinga/icingaweb2.git synced 2025-07-22 21:34:28 +02:00
Code Issues Packages Projects Releases Wiki Activity
2,868 Commits 125 Branches 76 Tags
Commit Graph

2868 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Matthias Jentsch
cb27a3d0f1 Do not use height and width in bar charts, to avoid layout errors 2014-07-22 17:57:40 +02:00
Eric Lippmann
e005333806 Merge branch 'master' into feature/display-documentation-4820 2014-07-22 12:25:58 +02:00
Matthias Jentsch
0eaaaf2f29 Make bar charts thicker 2014-07-22 11:32:52 +02:00
Matthias Jentsch
4b8bb99fa1 Fix svg text rotation in firefox 
Use the SVG transform attribute instead of the writing-mode attribute to support firefox.
 2014-07-22 11:26:35 +02:00
Matthias Jentsch
0a500efd8a Determine the max value in LinearUnit dynamically 
The range between min and max should always be divisable by the amount of
ticks, to ensure that the vertical lines are always at a full discrete value.

fixes #6769
 2014-07-21 17:21:54 +02:00
Johannes Meyer
75e09f2c69 Do not consider submit buttons when checking form completion 
refs #5525
 2014-07-21 15:25:00 +02:00
Johannes Meyer
a73e2ee654 Adjust general config form to suit the new form builder implementation 
refs #5525
 2014-07-21 14:33:52 +02:00
Alexander Klimov
cebd71b2ff Fix "Fatal error: Interface 'Icinga\Data\DatasourceInterface' not found in Icinga\Protocol\File\Reader" 
fixes #6722
 2014-07-21 14:14:13 +02:00
Alexander Klimov
c5ecbf250d lib: add FileReaderException for file reader specific errors 
refs #6722
 2014-07-21 14:11:08 +02:00
Alexander Klimov
6df7be7ee5 File/Query: Fix applyFilter' and order' not matching SimpleQuery's interfaces 
refs #6722
 2014-07-21 14:09:40 +02:00
Michael Friedrich
da78445686 Add apache 2.4 example for 'Require all granted' 
fixes #6771
 2014-07-21 13:38:19 +02:00
Matthias Jentsch
53c9292b41 Fix BarChart padding in Dashboard 
Use max-width instead of width in the chart layout to make better use of the available space, but prevent the charts from growing too big. Use a bigger weight and height in the default dashboard configuration.

fixes #6744
 2014-07-21 13:06:35 +02:00
Johannes Meyer
a9f0b95e51 Adjust preferences form to suit the new form builder implementation 
refs #5525
 2014-07-21 10:20:04 +02:00
Matthias Jentsch
091ddbe552 Partiall revert bfc54b7e 
Refactor Url->getParams() to return an instance of UrlParam instead of an array.

fixes #6760
 2014-07-21 09:22:19 +02:00
Johannes Meyer
f5ac592645 Do not consider disabled elements when checking form completion 
Values of disabled inputs are not sent by browsers.

refs #5525
 2014-07-21 08:57:41 +02:00
Alexander Klimov
5ea02b41ea Optimize variable names and positions, cast array direct to object 2014-07-18 17:35:24 +02:00
Alexander Klimov
f9a274d079 Add contact detail view 
refs #4804
refs #6514
 2014-07-18 17:35:24 +02:00
Thomas Gelf
2a204897b4 DbQuery: improve method description 
Not English mine this was, copy paste did I ;)
 2014-07-18 16:48:52 +02:00
Thomas Gelf
209894d857 DbQuery: add dummy isTimestamp function 
Not the best solution, but helps for now.

fixes #6675
 2014-07-18 16:35:29 +02:00
Johannes Meyer
6ed3d5fdbd Remove Icinga\Form\Install\LoggingPage 2014-07-18 10:40:37 +02:00
Johannes Meyer
7157b11f97 Adjust LoggingForm to suit the "final" form builder implementation 
refs #5525
 2014-07-18 10:29:23 +02:00
Johannes Meyer
5da14d3fc5 Adjust LoginForm to suit the "final" form builder implementation 
refs #5525
 2014-07-18 10:23:04 +02:00
Johannes Meyer
f4ff2c90f2 It's a form's responsibility how its submit button should look like 
refs #5525
 2014-07-18 09:54:36 +02:00
Johannes Meyer
6ac471c598 Also mention the viewscript functionality of Form::loadDefaultDecorators() 
refs #5525
 2014-07-18 09:52:50 +02:00
Johannes Meyer
8f0b9899a3 We cannot know what kind of data is passed to Form::isValid() 
refs #5525
 2014-07-18 09:52:05 +02:00
Johannes Meyer
78a6175acc Make form creation lazy and implement the new validation mechanism 
Form creation must not depend on specific function calls. If a forms' elements are required and missing, create them. Form::isValid() must be
able to determine whether a form can be processed or not without to rely
on a particular button value.

refs #5525
 2014-07-18 09:51:15 +02:00
Johannes Meyer
37fd3deb67 Rename initCsrfToken to addCsrfToken and move it upwards 
Form::addCsrfToken() should be public and fluent to ensure more
flexibility.

refs #5525
 2014-07-18 09:43:03 +02:00
Johannes Meyer
58188c5cc1 We only want to rely on Form::isValid() when about to process forms 
As the new auto-submission implementation does not depend on whether
a submit button was pressed or not we need another way to determine
whether a form should be processed.

refs #5525
 2014-07-18 09:33:09 +02:00
Johannes Meyer
802c095bf8 Configuration values need to be inserted to forms explicitly 
It's the controllers' responsibility to ensure that forms are populated with
configuration values on GET requests.

refs #5525
 2014-07-18 09:27:10 +02:00
Johannes Meyer
21cd503ee7 Form buttons need to be added explicitly 
We either demand the user to add a submit button or provide a implicit
function call to be implemented by him, adding additional elements once
the form gets rendered.

refs #5525
 2014-07-18 09:24:49 +02:00
Johannes Meyer
47ae4d79dc Forms do not need a special title property 
As our upcoming wizard has no menu and our tabs are hardcoded we do not
need a special "title" property anymore.

refs #5525
 2014-07-18 09:21:11 +02:00
Michael Friedrich
f9513cc14b Fix comment prefix in config/authentication.ini 2014-07-17 19:07:35 +02:00
Alexander Klimov
96d3406446 Prefer style="clear: both;" rather than Bootstrap's class="clearfix" 2014-07-17 17:46:28 +02:00
Alexander Klimov
882699201d Contacts: replace foreach loop with hardcoded HTML and move the styles to a CSS file 2014-07-17 17:33:45 +02:00
Johannes Meyer
1de2d0c14f Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	application/forms/Authentication/LoginForm.php
	library/Icinga/Test/BaseTestCase.php
	library/Icinga/Web/Form.php
	library/Icinga/Web/Form/Decorator/BootstrapForm.php
 2014-07-17 13:15:42 +02:00
Alexander Klimov
eca0d50bae Don't use printf format strings as array keys 
An array with printf format strings as keys looks pretty ugly
 2014-07-17 11:26:18 +02:00
Johannes Meyer
4d199180b3 We do not want to access $_POST directly if it is possible to avoid it 2014-07-17 09:28:10 +02:00
Johannes Meyer
b7f5c8a84d Fix that the default sort order of a view is not being applied 
fixes #6644
 2014-07-17 09:28:10 +02:00
Alexander Klimov
b23e36aa1a Swap array keys and values 
Non-hardcoded keys may be not unique
 2014-07-16 17:54:06 +02:00
Alexander Klimov
62da942159 Don't close and re-open php tags, remove unneeded spaces 
To close and re-open php tags makes no sense if there's nothing between them
 2014-07-16 17:54:06 +02:00
Matthias Jentsch
bfc54b7e32 Fix array conversion of the Dashboard and its Components 
Do not omit the parameters when converting the dashboard components to
an array. Add an array conversion to the UrlParams class.

refs #6691
 2014-07-16 17:31:01 +02:00
Johannes Meyer
5c507d5d91 Fix notice that the session has been already started after retrieving its id 2014-07-16 15:39:40 +02:00
Alexander Klimov
1ad263170e Revert "Small fixes" 
This reverts commit 8086292b1bd844b3a9f3377c7f0fc2521c9e197f.

The commit included too many changes.
 2014-07-16 15:30:20 +02:00
Johannes Meyer
eb977b7a55 Fix wrong variable assignment causing preferred languages not being set 2014-07-16 15:17:14 +02:00
Johannes Meyer
f1d7cd8b50 Remove forgotten coding standards annotation 2014-07-16 13:59:43 +02:00
Alexander Klimov
cb04c42bab Use htmlspecialchars to prevent attacks 2014-07-16 13:10:28 +02:00
Johannes Meyer
e5fdf78c98 Fix testing errors due to accessing the session id by using our container 2014-07-16 10:18:00 +02:00
Johannes Meyer
e6dee9fe89 Protect login against CSRF 
refs #5626
 2014-07-16 09:55:23 +02:00
Johannes Meyer
b40027b6c7 Purge session when logging out 
fixes #6739
 2014-07-16 09:55:22 +02:00
Johannes Meyer
19f05256a0 Only call session_start() when reading from session 
fixes #6383
 2014-07-16 09:55:22 +02:00