4fb6856caf
Fix exception when navigating to the preferences after namespacing all controllers
2015-08-31 10:19:30 +02:00
e7e1b1a98e
Dispatcher: Default to the default module if no module has been given in the request
...
This is most likely the case when custom routes have been added to the router w/o the module parameter being set.
refs #5786
2015-08-28 13:13:20 +02:00
9cf56410e9
lib: Fix PHPDoc of Form::populate()
2015-08-27 15:52:13 +02:00
4070f6c75b
Merge branch 'master' into feature/namespaced-controllers-5786
2015-08-27 15:05:44 +02:00
28009eb563
Rename controller namespace to Controllers
...
refs #5786
2015-08-27 13:03:45 +02:00
c294283636
Merge branch 'bugfix/service-grid-grouping-postgres-9333'
...
Conflicts:
modules/monitoring/application/controllers/ListController.php
modules/monitoring/library/Monitoring/Backend/Ido/Query/IdoQuery.php
fixes #9333
fixes #9538
2015-08-27 12:58:49 +02:00
8cc1970a9f
SearchDashboard: Use t() instead of the view helper
...
Since it's library code we do not need to use the module-aware
translation helper.
2015-08-25 16:51:50 +02:00
c8790fad93
Merge branch 'bugfix/service-grid-display_name-9538' into bugfix/service-grid-grouping-postgres-9333
...
Conflicts:
library/Icinga/Data/PivotTable.php
modules/monitoring/application/controllers/ListController.php
2015-08-25 15:51:20 +02:00
7c86f19aee
SearchDashboard: Utilize createDashlet() and set a progress label
...
refs #8848
2015-08-24 12:36:59 +02:00
320a4080ec
Dashlet: Add support for CSS animated progress labels
...
refs #8848
2015-08-24 12:36:35 +02:00
db4c81a093
Pane: Add method createDashlet()
...
refs #8848
2015-08-24 12:35:38 +02:00
ceaba90872
css: Load mixins.less
2015-08-21 16:45:05 +02:00
675a130787
Fix active configuration/application menu highlighting
...
Fix a bug that caused the application config to not be set to active when navigating through history.
refs #9761
2015-08-21 16:04:04 +02:00
d31b60102e
Form: Fix that form titles are missing
...
The description may not be set at the time
loadDefaultDecorators() is called.
2015-08-21 14:20:09 +02:00
9ca278d7b2
Merge branch 'master' into feature/activity-indicators-for-form-submits-8369
2015-08-21 13:37:54 +02:00
fbca28c024
Form: Only add a form header if a description is set
...
refs #8369
2015-08-21 13:34:17 +02:00
747f6dcf77
Form: Show the form autosubmit warning in the header tag...
...
...and use a unique id for the progress element.
refs #8369
2015-08-21 11:40:38 +02:00
85ef98f72d
lib: Add PHPDoc to Request::hasCookieSupport()
2015-08-21 11:27:03 +02:00
b9d64b40a4
forms.less: Fix help icon layout
2015-08-21 10:36:08 +02:00
7244906515
Wizard: Use a constant for the name and id of the progress element
...
refs #8369
2015-08-21 10:16:23 +02:00
07b17cc701
Wizard: Add Spinner decorator to the first (and only) submit button
...
refs #8369
2015-08-21 09:52:57 +02:00
44271471e3
Allow declarative definitions of badge renderers and improve interface
...
Allow the data backend, columns and generated tooltips to be defined in the configuration instead of providing subclasses for every new configuration. Provide an abstract BadgeMenuItemRenderer that allows creating Badges with less boilerplate.
fixes #9694
2015-08-20 18:16:33 +02:00
46cd47b73c
Form: Automatically set data-progress-element...
...
..for forms with form based autosubmit warnings.
refs #8369
2015-08-20 16:54:20 +02:00
32f8c0770c
Wizard: Use a single spinner for all submit buttons
...
refs #8369
2015-08-20 16:13:56 +02:00
20f144bd4b
Spinner: Accept option `id'
...
refs #8369
2015-08-20 16:13:30 +02:00
a77dc3665c
Form: Show a spinner for ongoing form submits
...
This will only be shown if there's no progress label set.
refs #8369
2015-08-20 15:05:02 +02:00
275b57cb69
Form: Allow to set a progress label
...
refs #8369
2015-08-20 15:04:15 +02:00
690d60672c
Introduce form element decorator Spinner
...
refs #8369
2015-08-20 14:34:43 +02:00
63e639caf0
Handle module identification directly in the ActionController
...
Fixes some issues with more complex customisations in a
module's controller.
Obsoletes: 93f8297344
2015-08-19 13:39:46 +02:00
036da072c5
Revert "ActionController: Give modules a chance to dynamically require auth"
...
This reverts commit 93f8297344
2015-08-19 13:39:46 +02:00
1492218962
Fix SortBox not usable w/o SortRules
...
The SortBox assumes the first avaiable sort column as default column if the given Sortable does not implement the SortRules interface.
When changing the direction of the default sort column, the sort box did not pass the column to Sortable::sort(). Thus the Sortable did not know by which column to sort.
Now the SortBox passes the sort column even if the direction of the default column is changed.
refs #9333
2015-08-18 14:18:48 +02:00
93f8297344
ActionController: Give modules a chance to dynamically require auth
2015-08-18 11:28:02 +02:00
e31dce97a9
Fix dispatching namespaced module controllers
...
refs #5786
2015-08-18 11:11:28 +02:00
e5f249270a
Merge branch 'master' into feature/provide-a-complete-list-of-filter-columns-9029
2015-08-17 15:41:40 +02:00
f7b0e6956d
FilterEditor: Only apply the filter if a query is set
...
refs #9029
2015-08-17 13:43:48 +02:00
7252f3237a
Introduce a constant for the controller namespace
...
refs #5786
2015-08-17 13:43:34 +02:00
06e879f078
Throw an expcetion in our Dispatcher if the controller is not an instance of Zend_Controller_Action_Interface
...
refs #5786
2015-08-17 13:38:16 +02:00
e26a7fd4d1
Use Zend_Cotroller_Dispatcher_Standard::getActionMethod() in the Dispatcher
...
refs #5786
2015-08-17 13:34:47 +02:00
965fee1e9e
Fix 'void' method result used in the Dispatcher
...
refs #5786
2015-08-17 13:31:05 +02:00
8b32edd6e9
Default to Zend's dispatcher if the controller name is empty
...
refs #5786
2015-08-17 13:29:47 +02:00
e8c0e97bb3
Add PHPDoc to the Dispatcher
...
refs #5786
2015-08-17 13:10:01 +02:00
f972a034e7
Fix license header in Dispatcher
...
refs #5786
2015-08-17 13:08:41 +02:00
392eee5a1f
Merge branch 'master' into feature/namespaced-controllers-5786
...
Conflicts:
library/Icinga/Application/Web.php
2015-08-17 12:59:44 +02:00
97245c5166
FilterEditor: Uppercase all words for non labelled filter columns
...
refs #9029
2015-08-14 15:36:54 +02:00
ca4789f114
FilterEditor: Fix automatic filter label creation
...
refs #9029
2015-08-13 17:20:40 +02:00
1e6c394693
Controller: Create the filter editor in setupFilterControl() ...
...
...instead of demanding a concrete controller to do so.
We still have to decide how to handle parameter preservation
properly.
refs #9029
2015-08-13 17:05:13 +02:00
63fb8dcafa
FilterEditor: Do not show an empty line at the bottom of the select
2015-08-13 15:59:00 +02:00
41b80efa0e
FilterEditor: Support queries implementing the FilterColumns interface
...
refs #9029
2015-08-13 15:58:04 +02:00
2e7ff7dd6e
FilterEditor: Require an instance of Filterable for setQuery()
...
refs #9029
2015-08-13 11:35:45 +02:00
fc35f3e46b
FilterEditor: Apply the filter on the query internally
...
refs #9029
2015-08-13 11:33:25 +02:00
069fcc40ea
FilterEditor: Accept null for method setColumns()
...
refs #9029
2015-08-13 11:30:26 +02:00
9ad14fc644
FilterEditor: Accept null for method setSearchColumns()
...
refs #9029
2015-08-13 11:30:05 +02:00
a9ff6eebc0
Merge branch 'master' into bugfix/cookie-support-7383
2015-08-13 11:22:14 +02:00
813154f6ef
Cookie: Make it no static and use the request
...
refs #7383
2015-08-13 11:19:48 +02:00
2332b94f0b
Request: Add getResponse() to retrieve the Response
...
refs #7383
2015-08-13 11:19:08 +02:00
fa1e3a763d
Do not show the full layout on the login page
...
...
refs #9892
2015-08-13 08:12:30 +02:00
ad8f16c185
Cookie: Set the rigth license line header
...
refs #7383
2015-08-11 16:37:05 +02:00
cea3727c97
Merge conflicts
2015-08-11 16:35:14 +02:00
aa4e3c5a22
Dashboard: Defer construction of the Url object to Dashlet::getUrl()
...
Before, the Url object was constructed in Dashlet::setUrl() and Dashlet::__construct8) which lead to an exception when parsing a module's configuration.php from our CLI.
refs #9375
2015-08-10 14:05:08 +02:00
1363ea4370
Menu: Defer construction of the Url object to Menu::getUrl()
...
Before, the Url object was constructed in Menu::setUrl() which lead to an exception when parsing a module's configuration.php from our CLI.
refs #9375
2015-08-10 14:05:00 +02:00
c7cc9e66df
JavaScript: Load all available module javascript files
...
refs #9702
2015-08-06 15:15:02 +02:00
9cea83242c
StyleSheet: Load all available module stylesheets
...
refs #9702
2015-08-06 15:14:29 +02:00
688a08585b
Merge branch 'master' into bugfix/error-prone-generictts-9611
...
Conflicts:
modules/monitoring/application/views/scripts/show/components/downtime.phtml
2015-08-03 15:05:45 +02:00
ea5db51213
Fix "Try to get an inexistent pane." when clicking on the "Search" tab
2015-08-03 13:01:11 +02:00
139baffdc6
lib: Make Dashboard::$tabs protected
...
The SearchDashboard has to override Dashboard::getTabs() in order to set up the correct tab.
2015-08-03 13:01:11 +02:00
177fafaa56
lib: Fix TicketHook's PHPDoc
...
refs #9611
2015-08-03 11:05:48 +02:00
451be1e97f
monitoring/hooks: Add TicketHook::createLinks()
...
Instead of calling preg_replace_callback w/o error handling in our view scripts, TicketHook::createLinks() will take care of that.
refs #9611
2015-07-31 15:31:41 +02:00
6c105b867e
Form: Be less error-prone while calling array_search
2015-07-31 11:05:09 +02:00
5345831742
SessionNamespace: Be less error-prone while calling array_search
2015-07-31 11:04:51 +02:00
449a19c3a3
Session: Be less error-prone while calling array_search
2015-07-31 11:04:43 +02:00
24cb123f47
Tabs: Be less error-prone while calling array_search
2015-07-31 11:04:36 +02:00
a234852f32
Merge branch 'feature/basic-auth-9660'
...
resolves #9660
2015-07-30 15:05:07 +02:00
9060e8a034
lib: Only call Icinga::app()->getRequest() for getting the request outside of a controller
...
Saves a call to getFrontController().
refs #9660
2015-07-30 14:02:44 +02:00
81aad9d6a6
Rename Notifiation::getMessages() to popMessages()
...
Because the call to popMessages()--before getMessages()--automatically resets the notification messages on the instance, popMessages() is a much better name for the method.
refs #9660
2015-07-30 13:45:39 +02:00
d545e1f7d1
lib: Don't write the empty notifications array into the session
...
I combined this w/ introducing some constants for notification types and PHPDoc.
refs #9660
2015-07-30 13:42:59 +02:00
9aa1599a18
Form: Disable CSRF counter measure only on API requests
...
refs #9660
2015-07-30 12:04:22 +02:00
c23c7a5fa9
lib: Add Request::getIsApiRequest()
...
If the Accept header is set to application/json it's an API request.
refs #9660
2015-07-30 12:03:33 +02:00
db505281ee
lib: Disable CSRF token on HTTP authenticated users and not XHR
...
refs #9660
2015-07-30 09:33:04 +02:00
9f0e48a0a1
Don't send the X-Icinga-Module header more than once
...
fixes #9349
2015-07-30 09:28:05 +02:00
20aa17c831
Merge branch 'bugfix/selected-row-lost-after-autorefresh-8623'
...
fixes #8623
2015-07-29 17:30:45 +02:00
3e7cc299ec
Fix issue that caused the refresh button to remove side bar
...
Do not apply base target globally for all toolbar elements, but specifically for those that should remove side-bars.
refs #8623
refs #6436
2015-07-29 17:18:52 +02:00
ba906d2fca
FilterEditor: allow to set custom filter columns
2015-07-29 17:13:18 +02:00
432efcb089
lib: Handle Response::setRerenderLayout() correctly
...
The header is different if it's not a redirect.
refs #9660
2015-07-29 15:08:36 +02:00
aaae7e03b4
lib: Introduce Response::setRerenderLayout()
...
Instead of handling response headers based on flags in our controllers, this should happen in the request for usage w/o controllers.
refs #9660
2015-07-29 14:39:45 +02:00
91720810cc
lib: Document Response::redirectAndExit()
...
refs #9660
2015-07-29 14:22:45 +02:00
a31c799043
lib: Introduce Response::getRequest()
...
refs #9660
2015-07-29 14:20:39 +02:00
07849e0fea
lib: Rename Authentication/Manager to Authentication/Auth
...
refs #9660
2015-07-28 17:08:55 +02:00
7cfc78558d
Merge branch 'master' into feature/secure-modules-9644
...
Conflicts:
library/Icinga/Exception/IcingaException.php
2015-07-28 13:42:02 +02:00
e231ef8061
SortBox: Fix some documenation and code style issues
2015-07-28 12:04:16 +02:00
f7b35b04f4
SortBox: Properly apply sort rules and show the user the default
...
refs #6644
2015-07-28 12:03:50 +02:00
78285b95a3
Make Controller::httpNotFound() variadic
...
refs #9644
2015-07-28 10:40:02 +02:00
4d9aa54814
SortBox: Utilize a separate form for each control
...
refs #9421
2015-07-27 11:43:47 +02:00
86ad6c48ff
Form: Automatically remove query parameters only for GET forms
...
refs #9421
2015-07-27 08:52:33 +02:00
8358e9165c
Don't require the module permission for the default module
...
refs #9644
2015-07-24 15:11:21 +02:00
727a2d7141
Paginator: relax requirements to Paginatable
...
* we need no full query interface here
* introduced new interface "Paginatable"
fixes #9483
2015-07-23 13:48:49 +02:00
a34ad0227f
Don't load module menu entries if the authenticated user lacks the module permission
...
refs #9644
2015-07-23 12:59:30 +02:00
fd77c30838
Don't load module dashboards if the authenticated user lacks the module permission
...
refs #9644
2015-07-23 12:57:23 +02:00
e8e01257e6
Change interface of SearchDashboard to allow setting a user before calling ::search()
...
Because search dashlets are provided by modules, the authenticated user's module permissions have to be validated before loading search dashlets provided by modules.
refs #9644
2015-07-23 12:53:08 +02:00
b4f4ce4406
Require the module's permission for every module automatically
...
Module permissions are not required if authentication is disabled on the controller.
refs #9644
2015-07-23 12:51:10 +02:00
b000ae3a37
Do not require permissions if authentication is not required
...
refs #9644
2015-07-23 12:50:02 +02:00
Eric Lippmann
Johannes Meyer
Matthias Jentsch
Alexander Fuhr
Thomas Gelf