Commit Graph

4975 Commits

Author SHA1 Message Date
Johannes Meyer 7b488d7f93 swag: Fix violations of PSR-12
PSR-2 has been deprecated and phpcs v3.5.3
now checks for the successor PSR-12
2019-12-04 11:28:08 +01:00
Feu Mourek 57f966734a Perfdata: add function to get perfdata unit 2019-11-04 11:36:57 +01:00
Johannes Meyer e0be21f655 Raise version to 2.7.3 2019-10-18 07:41:53 +02:00
Johannes Meyer ded92c786a Add missing columns to empty group queries 2019-10-18 07:32:58 +02:00
Johannes Meyer 8e51518e96 ServicegroupQuery: Really join hosts if instructed to do so
fixes 
2019-10-17 16:14:28 +02:00
Johannes Meyer 362c30c1dd Raise version to 2.7.2 2019-10-16 08:12:09 +02:00
Johannes Meyer 01bcf980f2
Merge pull request from Icinga/fix/slow-queries-when-filtering-groups-3928
Enhance query performance when filtering for groups and reduce double query execution
2019-10-16 08:05:30 +02:00
Johannes Meyer bb2673a49a EventController: Use `DateFormatter::formatDateTime` to render dates
fixes 
2019-10-14 08:12:35 +02:00
Johannes Meyer cbc12ab31e event-history.phtml: Don't use `hasResult()` to check if there are results
28ec1e236 has no result on history views as they never count their results.
So restructuring this particular view script I deemed reasonable since the
history queries tend to show very poor performance.

refs 
refs 
2019-10-11 10:27:43 +02:00
Johannes Meyer 908c408d3d ServicegroupsummaryQuery: Fetch empty groups with a union query
refs 
2019-10-11 10:27:43 +02:00
Johannes Meyer faca6d53c8 HostgroupsummaryQuery: Add empty groups to the union
refs 
2019-10-11 10:27:43 +02:00
Johannes Meyer fae60f06bf Revert "Show empty groups with a filter chain too"
This reverts commit fadf12e98a.
2019-10-08 13:39:52 +02:00
Johannes Meyer 0e729bb85b Revert "ServicegroupQuery: Use left joins instead of inner joins"
This reverts commit 23066d2cc4.
2019-10-08 13:39:52 +02:00
Johannes Meyer 94b0689b95 Revert "HostgroupQuery: Use left joins instead of inner joins"
This reverts commit 4ef085bdcd.
2019-10-08 13:39:52 +02:00
Johannes Meyer 25e1942a9b
Merge pull request from Icinga/bugfix/checks-wrongly-marked-as-late-3696
Fix checks being marked as late when they are scheduled for later time
2019-10-08 13:39:21 +02:00
Johannes Meyer 8ec0c40f21 monitoring: Fix missing load more link when there's a single row 2019-10-08 13:36:35 +02:00
Johannes Meyer c21867699a ServicestatusQuery: Adjust `next_update` calculation to respect `next_check` 2019-10-08 13:21:43 +02:00
Johannes Meyer b9ea432d35 HoststatusQuery: Adjust `next_update` calculation to respect `next_check` 2019-10-08 13:21:43 +02:00
Johannes Meyer b3c6af4ea6 ToggleObjectFeaturesCommandForm: Use a select instead of radio buttons
refs 
2019-10-08 12:39:07 +02:00
Gianluca Piccolo 1e2bd37ae8 Add custom tab hook 2019-10-02 13:42:42 +02:00
Johannes Meyer f4c43ecafb
Merge pull request from Icinga/fix/invalid-filter-suggestions-in-group-overviews-3940
Fix invalid filter suggestions in group overviews
2019-09-26 14:35:11 +02:00
Johannes Meyer 5352e72d1f
Merge pull request from Icinga/fix/wrong-dashlet-order-3931
Fix wrong dashlet order
2019-09-26 14:34:13 +02:00
Johannes Meyer b4f1847ec0
Merge pull request from Icinga/fix/missing-notifications-in-timeline-3947
Fix timeline
2019-09-26 14:33:47 +02:00
Johannes Meyer 97c1c4e215
Merge pull request from Icinga/feature/relax-html-restrictions-for-plugin-output
PluginOutput: Relax html restrictions
2019-09-26 14:33:14 +02:00
Johannes Meyer d6a630432e Servicegroupsummary: Only provide valid filter columns
refs 
2019-09-26 13:48:49 +02:00
Johannes Meyer 2b77baa19f Hostgroupsummary: Only provide valid filter columns
refs 
2019-09-26 13:47:56 +02:00
Johannes Meyer f98f988aff Remove tristate form element 2019-09-23 08:36:24 +02:00
Marc DeTrano 6166d1eaf9 Quick fix for timestamp filtering on EventGrid
fixes 
2019-09-12 11:25:45 +02:00
Johannes Meyer ab99d25cb5 PluginOutput: Relax html restrictions 2019-09-12 10:50:17 +02:00
Johannes Meyer bfa5f9610b monitoring: Fix timeline
* Fixes extrapolation style
* Fixes missing notifications

fixes 
2019-09-12 10:31:41 +02:00
Johannes Meyer d055e43367 monitoring: Define priorities for dashlets
refs 
2019-09-09 14:43:28 +02:00
Johannes Meyer c3603c991d downtimes/comments: Don't mark service urls with `.rowaction`
fixes 
2019-09-09 12:28:49 +02:00
Florian Strohmaier 00257f163d CSS: Consolidate .object-features styles 2019-09-04 17:21:01 +02:00
Johannes Meyer 04b23811be Raise version to 2.7.1 2019-08-14 13:10:19 +02:00
Eric Lippmann fadf12e98a Show empty groups with a filter chain too 2019-08-14 11:50:14 +02:00
Eric Lippmann 214a34a5a8 Always use subquery filters for subquery targets in the group views 2019-08-13 17:18:50 +02:00
Johannes Meyer b0875d40f1
Merge pull request from Icinga/fix/dashboard-migration-requires-all-locales
Don't fail dashboard migration just because a locale is missing
2019-08-12 13:33:07 +02:00
Johannes Meyer 86eefe5abf
monitoring: Highlight links in markdown content ()
Doesn't apply to all markdown content. Our only use-case
currently is in the monitoring module and this already got
a known style for external/custom links.

Other modules may want to apply a different style or possibly
none at all.

resolves 
2019-08-12 12:58:29 +02:00
Johannes Meyer de0a46aaaf list/servicegrid: Also show problem toggle if the grid is flipped
fixes 
2019-08-12 10:43:03 +02:00
Johannes Meyer 53598ecd18 DashboardCommand: Don't swallow custom dashboards 2019-08-02 14:14:28 +02:00
Johannes Meyer 49e84f2ad0 migrate: Don't fail dashboard migration just because a locale is missing 2019-08-02 12:00:26 +02:00
Johannes Meyer 105f32a006 locale: Update de_DE translation of the setup module 2019-07-30 10:36:01 +02:00
Johannes Meyer 7237d7e086 locale: Update de_DE translation of the monitoring module 2019-07-30 10:35:30 +02:00
Eric Lippmann f35946df29 Raise version to 2.7.0 2019-07-30 10:19:53 +02:00
Eric Lippmann 7730058c2c Fix Event Grid PostgreSQL error
PostgreSQL fails with failed to find conversion function from
unknown to text. PostgreSQL won't detect the type of object_type.
Most likely because it's used in a CASE statement and provided by a
subquery:

select case when s.object_type = 'service' then 1 else 0 end from
(select ('service') as object_type) as s;

This commit just removes object_type from the CASE statements because we
don't need them anyway. Recently we've changed the event grid query to
only select hosts or services and not both.
2019-07-30 09:32:59 +02:00
Peter Eckel 718ecd05a7 Fix Icinga 2 version detection
With this commit the version prefix character is treated as optional
which always used to be 'r' or 'v'. But this is gone since Icinga 2
version 2.11.0 RC1.

Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2019-07-30 09:32:17 +02:00
Eric Lippmann ac08fb2c3b Fix filtered links in the tactical overview
Filter chains require parantheses to work properly.
2019-07-30 09:17:25 +02:00
Eric Lippmann e61cb71c17 Use unique values for combined AND group membership filters 2019-07-30 09:17:25 +02:00
Eric Lippmann 0de923fc5f Support "old" combined group membership filter in subquery filter chains 2019-07-30 09:17:25 +02:00
Eric Lippmann bee5099a08 Fix show all services links in the servicegroup overview
Before, the forced servicegroup_name paramemter may interfere with an
existing servicegroup_name filter.
2019-07-30 09:17:25 +02:00
Eric Lippmann 58e3ae46a7 Fix servicegroup subquery filter in the servicegroup view 2019-07-30 09:17:25 +02:00
Eric Lippmann cc94c12e55 Fix show all hosts/services links in the hostgroup overview
Before, the forced hostgroup_name paramemter may interfere with an
existing hostgroup_name filter.
2019-07-30 09:17:25 +02:00
Eric Lippmann 9a75e101ee Support subquery filters in filter chains
Before, combined membership filters were only possible in filter
expressions, e.g. hostgroup_name=(a&b). Now, also
(hostgroup_name=a&hostgroup_name=b) is supported which makes it easier
to build such filters with the filter editor.
2019-07-30 09:17:25 +02:00
Johannes Meyer a33fda9dd7
Merge pull request from Icinga/feature/contact-and-contactgroup-filter
Add contact and contactgroup filters
2019-07-30 09:07:55 +02:00
Johannes Meyer ea3a541017
Merge pull request from Icinga/feature/improve-host-service-distinction-in-lists-3615
Improve host-service distinction in lists
2019-07-30 08:55:03 +02:00
Johannes Meyer d13cade0f3
Merge pull request from Icinga/feature/add-servicegrid-problem-toggle-3793
Servicegrid: Add toggle to show problems only or everything
2019-07-30 08:26:46 +02:00
Johannes Meyer b31dd77812
Merge pull request from Icinga/feature/form-styling
Improve look of our forms
2019-07-30 08:26:08 +02:00
Eric Lippmann 11097fe75b Make host and service names bold in their detail headers 2019-07-29 14:03:40 +02:00
Eric Lippmann 9221e7894c Make host names bold in the event history 2019-07-29 14:03:40 +02:00
Eric Lippmann dc3147c652 Improve host-service distinction for events 2019-07-29 14:03:40 +02:00
Eric Lippmann f7ed5de8c8 Remove icon from event detail tab 2019-07-29 14:03:40 +02:00
Eric Lippmann 135601c0dc Add tab to contact detail 2019-07-29 14:03:40 +02:00
Eric Lippmann b6a399df1a Make host links bold in the comments view 2019-07-29 14:03:40 +02:00
Eric Lippmann 1f4c970cb3 Fix title attributes in the comment header 2019-07-29 14:03:40 +02:00
Eric Lippmann 5b3cbb0ffe Fix title attributes in the downtime header 2019-07-29 14:03:40 +02:00
Eric Lippmann 5993745a86 Select notification id 2019-07-29 14:03:40 +02:00
Eric Lippmann 227cb2c512 Fix grouping error when selecting the notification id 2019-07-29 14:03:40 +02:00
Eric Lippmann 98388c4346 Link to the event detail from the notifications view 2019-07-29 14:03:40 +02:00
Eric Lippmann 99ff058561 Improve host-service distinction for notifications 2019-07-29 14:03:40 +02:00
Eric Lippmann 0500afb013 Make contact group name bold in the contact groups view 2019-07-29 14:03:40 +02:00
Eric Lippmann 0efe72b429 Make contact name bold in the contacts view 2019-07-29 14:03:40 +02:00
Eric Lippmann 4323c060ce Remove icons from notifications view 2019-07-29 14:03:40 +02:00
Jennifer Mourek 9c3da17f2e Improve host-service distinction for hosts, services, comments and
downtimes
2019-07-29 14:03:37 +02:00
Eric Lippmann a94e8fb211 monitoring: Clone the filter for the grid links
Before, it was impossible to change an existing filter via the filter
editor in the host and service group views because of an exception about
wrong IDs.
The filter editor sets the IDs correctly. But since we're adding the
filter again to another URL, FilterChain::addFilter() overrides the IDs
because it is not working with a clone.
2019-07-29 13:22:55 +02:00
Johannes Meyer d2a2eae600 css: Re-add `margin:0` removed by 9d0ef4cf3 to `.overview-plugin-output` 2019-07-29 12:24:52 +02:00
Johannes Meyer 66c436b98c BackendConfigForm: Don't wrap resource elements twice with .control-group 2019-07-29 10:19:39 +02:00
Johannes Meyer 4f507d9672 SelectBox: Also use the default form classes 2019-07-29 10:19:39 +02:00
Johannes Meyer dd1a3dfb31 monitoring: Align object feature toggles with baseline 2019-07-29 10:19:39 +02:00
Johannes Meyer c7a3783034 css: Avoid that toggle switches break onto a new line in minimal layout 2019-07-29 10:17:59 +02:00
Johannes Meyer 212606de78 setup: Apply new icinga form style 2019-07-29 10:17:59 +02:00
Johannes Meyer 1b8501d5b7 ToggleInstanceFeaturesCommandForm: Apply icinga form style 2019-07-29 10:17:59 +02:00
Johannes Meyer 721dab93a0 ToggleObjectFeaturesCommandForm: Apply icinga form style 2019-07-29 10:17:59 +02:00
Florian Strohmaier 58a68b4e40 CSS: Remove redundant style attributes 2019-07-29 10:17:59 +02:00
Johannes Meyer b6c89bc863
Merge pull request from Icinga/feature/collapsible-plugin-output-3566
Collapsible plugin output
2019-07-29 09:33:58 +02:00
Johannes Meyer f32dac7a70 ServicestatusQuery: Add `latency` to next_update calculation..
..and double the entire result

refs 
2019-07-29 09:12:46 +02:00
Johannes Meyer 44f63576d1 HoststatusQuery: Add `latency` to next_update calculation..
..and double the entire result

refs 
2019-07-29 09:12:46 +02:00
Johannes Meyer 5ead593fa7 monitoring/list/services: Make overdue/unreachable services better visible
refs 
2019-07-29 09:12:46 +02:00
Johannes Meyer 18b933679c monitoring/list/hosts: Make overdue/unreachable hosts better visible
refs 
2019-07-29 09:12:46 +02:00
Eric Lippmann bcc867d48e Allow to filter for contact groups 2019-07-29 09:12:01 +02:00
Eric Lippmann 2c11f5307d Fix event detail link for notifications 2019-07-26 16:53:13 +02:00
Feu Mourek 4760e55786 Fix typo 'overvies' -> 'overviews' () 2019-07-26 07:49:48 +02:00
Johannes Meyer 74bf1bdc89 notes.phtml: Collapse notes if they exceed 200px 2019-07-26 07:36:17 +02:00
Johannes Meyer 226b58ac9d customvars.phtml: Collapse custom variables if they exceed 5 rows
Also collapses customvar values if they're JSON blobs and exceed
5 rows.

refs 
2019-07-26 07:36:17 +02:00
Johannes Meyer f42a49d4a9 perfdata.phtml: Collapse perfdata values if they exceed 5 lines
refs 
2019-07-25 13:22:43 +02:00
Johannes Meyer b61a952cfd output.phtml: Collapse plugin output if it exceeds 100px
refs 
2019-07-25 08:17:41 +02:00
Eric Lippmann aa293f54bd Separate icon and event output in the history views 2019-07-23 14:49:39 +02:00
Eric Lippmann 213e7a3c13 Show new notfication types in the history views 2019-07-23 14:48:00 +02:00
Eric Lippmann 54f9c68887 Show notifications before any other event in the history views 2019-07-23 14:48:00 +02:00
Eric Lippmann f80a61d9e5 Respect notification type of subqueries 2019-07-23 14:48:00 +02:00
Eric Lippmann 1d1fd0b3b2 Use notification_reason for new notification types 2019-07-23 14:48:00 +02:00
Johannes Meyer 9d0ef4cf33 Wrap any markdown output with a `<section>` and remove explicit containers 2019-07-23 14:45:32 +02:00
Johannes Meyer b1705ca0e1 list/servicegrid: Add toggle to show problems only or everything
resolves 
2019-07-18 15:38:51 +02:00
Johannes Meyer 39fbd3e27e monitoring: Re-add missing query columns to event overview
`hostgroup`, `hostgroup_alias`, `servicegroup`, `servicegroup_alias`

fixes 
2019-07-18 14:50:35 +02:00
Johannes Meyer 40529e76ef
Merge pull request from Icinga/feature/downtime-schedule-times
Require time output for downtime schedule and end/expire times
2019-07-18 08:47:55 +02:00
Johannes Meyer fdff949a59 migrate: Introduce class DashboardCommand
refs 
2019-07-18 08:33:35 +02:00
Johannes Meyer f8d3f43965 js: Drop vendor library tipsy 2019-07-18 07:57:14 +02:00
Eric Lippmann 037bcc4b3e Don't show flexible twice for not yet started flexible downtimes 2019-07-15 10:11:52 +02:00
Eric Lippmann 0fb034b663 Require time output for dowtime end/expire times 2019-07-15 10:11:52 +02:00
Eric Lippmann b5bfd0c620 Show expire time for flexbile downtimes where missing 2019-07-15 10:11:52 +02:00
Johannes Meyer 066aa0ef03 setup: Set a proper title for the wizard
refs 
2019-07-15 08:24:44 +02:00
Johannes Meyer 7ba998c6b1 monitoring: Set a proper title for all controller actions
refs 
2019-07-15 08:24:44 +02:00
Eric Lippmann fe3a51937a Show downtime schedule times before creation time 2019-07-11 13:10:58 +02:00
Eric Lippmann ba6b8c04ec Always show downtime schedule times 2019-07-11 13:07:30 +02:00
Eric Lippmann 523a35f4c1 Allow to filter for contacts 2019-07-08 18:00:28 +02:00
Johannes Meyer 2e574f64e2 monitoring: Provide the tactical overview as search url
refs 
2019-07-04 15:10:04 +02:00
Johannes Meyer 1aca142e1a tatical/index: Use an `ul` for the legends and render real links
refs 
refs 
2019-07-04 14:49:53 +02:00
Johannes Meyer 36524bcd94
Merge pull request from Icinga/feature/make-notes-and-comments-markdown-aware-3684
Make notes, comments and announcements markdown aware
2019-07-02 15:30:21 +02:00
Johannes Meyer 7cb2050623
Merge pull request from p4k8/master
Add Ukrainian language support
2019-07-02 15:27:54 +02:00
Johannes Meyer 3a955ae19b monitoring: Transform markdown markup in host and service notes
refs 
2019-06-25 15:04:04 +02:00
Johannes Meyer d4cf7a8ec4 monitoring: Transform markdown markup in comments
refs 
refs 
2019-06-25 15:04:04 +02:00
Johannes Meyer 3f2a2fa984 Action: Only create an `Url` object once macros are resolved
refs 
2019-06-25 09:08:04 +02:00
p4k8 0e3be14f96 Add Ukrainian language support 2019-06-23 21:48:32 +03:00
Johannes Meyer 96f3807610 GettextTranslationHelper: Properly fix module source paths 2019-05-27 11:02:34 +02:00
Johannes Meyer 5961f43aa9
Merge pull request from mdetrano/bugfix/cant_search_for_output_in_event_history_2266
Fixes 2266.  Special handling of notification 'output' field.
2019-05-27 08:29:34 +02:00
Johannes Meyer a2d82c2365
Merge pull request from Punkoivan/master
Added info about icingaweb endpoint into "System -> Monitoring Health" section
2019-05-27 08:28:00 +02:00
Marc DeTrano 5e5a5c68cc Fixes 2266. Special handling of notification 'output' field to avoid using aggregate function in WHERE clause of query...which dumps an error
style fixup, exact === usage
2019-05-24 17:04:02 -06:00
PunkoIvan 20614a8cea
updated with requested changes from PR 3783 2019-05-24 21:01:57 +03:00
Johannes Meyer a063cc9dcf
Merge pull request from mdetrano/feature/improve-eventgrid-performance-12732
Improve Event Grid performance
2019-05-24 07:53:21 +02:00
mdetrano c05d15c427
Update modules/monitoring/library/Monitoring/Backend/Ido/Query/EventgridservicesQuery.php
extra line fixup, as suggested

Co-Authored-By: Jennifer Mourek <jennifer.mourek@netways.de>
2019-05-22 13:29:12 -06:00
mdetrano 2ecfcd2860
Update modules/monitoring/application/controllers/ListController.php
use form value for object type, as suggested

Co-Authored-By: Jennifer Mourek <jennifer.mourek@netways.de>
2019-05-22 13:28:47 -06:00
mdetrano 9470268f50
Update modules/monitoring/application/controllers/ListController.php
Use form value for from, as suggested

Co-Authored-By: Jennifer Mourek <jennifer.mourek@netways.de>
2019-05-22 13:28:24 -06:00
Johannes Meyer bc1371bad7
Merge pull request from Icinga/fix/broken-tests-if-module-requires-its-own-config
tests: Don't include non-enabled modules
2019-05-22 12:53:09 +02:00
Johannes Meyer 2aff4eebe4
Merge pull request from chisatohasimoto/icingaweb2_1
Add Japanese language support
2019-05-22 12:46:25 +02:00
Johannes Meyer 970eb6c56a tests: Don't include modules which provide a `phpunit.xml`
Some modules may require their very own phpunit configuration in order to run.
2019-05-22 12:43:29 +02:00
PunkoIvan d5fd559a82
added info about icingaweb endpoint
added info about icingaweb endpoint when using IcingaWeb in HA mode.
2019-05-19 21:18:17 +03:00
Johannes Meyer ef470b3c1d
Merge pull request from Icinga/bugfix/setup-cli-webserver-config-fpm-enabled
Setup: Allow to enable FPM
2019-05-08 09:29:13 +02:00
chisatohasimoto 65a0223b92 Add Japanese language support doc 2019-05-08 09:21:34 +09:00
chisatohasimoto ba6bef18f8 Add Japanese language support monitoring 2019-05-08 09:19:58 +09:00
chisatohasimoto 1ee8c67403 Add Japanese language support setup 2019-05-08 09:17:48 +09:00
Michael Friedrich 7f7b3b0b91 Setup: Fix example for Nginx 2019-05-03 16:28:46 +02:00
Johannes Meyer 201cfa2330
Merge pull request from Icinga/feature/detailview-improvement
Integrate DetailviewExtension into multi-select views
2019-05-02 14:02:21 +02:00
Johannes Meyer c0e102cedd Release version 2.6.3
(cherry picked from commit 78d215ce36)
Signed-off-by: Johannes Meyer <johannes.meyer@icinga.com>
2019-04-24 14:49:21 +02:00
Florian Strohmaier fa26e24a60 CSS: Fix hover effect bug occuring in safari ()
fixes 
2019-04-24 12:12:00 +02:00
Johannes Meyer bd2cd0dda5
event-history.phtml: Remove duplicate `class` attribute () 2019-04-24 09:38:56 +02:00
Johannes Meyer 2e2a269549
Merge pull request from ConstantinMatheis/master
Add check source to history details view.
2019-04-18 14:37:26 +02:00
Johannes Meyer 81bb5272b5
Merge pull request from Icinga/feature/date-timezone-3626
Setup: don't require date.timezone
2019-04-18 14:20:47 +02:00
Alexander A. Klimov 5a0434431f Setup: don't require date.timezone
refs 
2019-04-18 11:31:37 +02:00
Johannes Meyer dc8184ccf1 list/servicegroup-grid: Preserve filter when navigating away
refs 
2019-04-16 13:54:55 +02:00
Johannes Meyer da415b8fe6 list/hostgroup-grid: Preserve filter when navigating away
refs 
2019-04-16 13:54:27 +02:00
Johannes Meyer 6761aecb60 list/servicegroups: Preserve filter when switching to grid mode
refs 
2019-04-16 13:53:54 +02:00