Commit Graph

3950 Commits

Author SHA1 Message Date
Alexander A. Klimov c717ebeb94 Make Plugin class loadable 2018-01-24 10:21:37 +01:00
Eric Lippmann 56d28a6c14 Prepare release version 2.5.1 2018-01-22 13:47:41 +01:00
Johannes Meyer e8fa99f913 PluginOutput: Use new PluginOutputPurifier helper instead 2018-01-19 16:16:35 +01:00
Johannes Meyer 42b685d336 Introduce class Icinga\Module\Monitoring\Web\Helper\PluginOutputPurifier 2018-01-19 16:16:35 +01:00
lippserd 226cc2c810
Merge pull request #3274 from Icinga/bugfix/inner-donut-labels-firefox-3226
Donut: place HTML tags outside <svg>
2018-01-18 10:15:49 +01:00
Michael Friedrich 4dfc309e12 Fix command transport documentation for inline comments
fixes #3281
2018-01-17 17:02:50 +01:00
lippserd 21d1e0d3cd
Merge pull request #3142 from Icinga/bugfix/icingacli-monitoring-list-host-without-services-3050
Split icingacli monitoring list
2018-01-17 16:03:06 +01:00
Alexander A. Klimov 0ad153a223 Tactical overview: always show the problems amount
refs #3226
2018-01-17 15:01:02 +01:00
lippserd f4c46cde19
Merge pull request #3278 from Icinga/bugfix/drop-obsolete-aggregates-from-event-history-query-2860
EventHistory: Drop obsolete SUM aggregates
2018-01-17 14:07:20 +01:00
Johannes Meyer 0610718930 PluginOutput: Allow ordered and unordered lists in html output
refs #2846
2018-01-17 13:02:11 +01:00
Johannes Meyer dff6c16bf8 PluginOutput: Properly handle whitespace for html output
refs #2846
2018-01-17 13:02:11 +01:00
Johannes Meyer b07e4b409f EventHistory: Drop obsolete SUM aggregates
Not used anywhere and not working for a long time already,
at least as filter columns.

refs #2860
2018-01-17 12:41:10 +01:00
lippserd 375b140c48
Merge pull request #3126 from mapa82/master
Monitoring: add setting acknowledge_expire_time
2018-01-17 12:18:00 +01:00
mapa82 9b81492e8b Monitoring: add setting acknowledge_expire_time
Signed-off-by: Alexander A. Klimov <alexander.klimov@icinga.com>
2018-01-17 12:07:03 +01:00
Alexander A. Klimov 4e57fa1dd7 Split icingacli monitoring list
refs #3050
2018-01-16 11:02:19 +01:00
lippserd 2fb9ce9f93
Merge pull request #3145 from Icinga/bugfix/history-eventgrid-format-2678
Accept /monitoring/list/eventgrid?format=*
2018-01-16 10:43:09 +01:00
lippserd 30e5ee9d79
Merge pull request #3227 from Icinga/feature/separate-reachability-and-check-source-2953
Separate reachability and check source info in detail views
2018-01-16 10:24:14 +01:00
lippserd e529b9b2ba
Merge pull request #3218 from Icinga/bugfix/remove-leading-and-trailing-blank-from-ip-address-2494
Remove leading and trailing blanks from ip addresses
2018-01-16 09:20:37 +01:00
lippserd 5b069bace4
Merge pull request #3138 from Icinga/bugfix/typo-existance-3062
Fix typo "existance"
2018-01-16 09:03:48 +01:00
lippserd 6abb91421a
Merge pull request #3220 from Icinga/fix/filter-by-custom-variables
Fix filter by host custom variables
2018-01-11 11:40:22 +01:00
Alexander A. Klimov 196cdbe4af Implement event history detail view
refs #3191
2018-01-09 13:04:06 +01:00
Alexander A. Klimov 0b6336c623 Separate reachability and check source info in detail views
refs #2953
2017-12-19 17:57:04 +01:00
Eric Lippmann 93ec798c6b Ido: Map h.host_object_id to s.host_object_id in the ServicegroupQuery
This is required to make filters work which filter by host custom variables without using any host related table.
2017-12-18 10:35:16 +01:00
Eric Lippmann b1f7923711 Ido: Allow custom variables to be mapped
If you filter by host custom variables and the query does not have the services table joined,
our query implementation calls the joinHosts method. Then, the column for the JOIN ON condition is
automatically set to h.host_object_id.
But it may be required by the query to call joinServices and use s.host_object_id instead of
h.host_object_id because the query does not use any host related table at all.

This is now possible when h.host_object_id is mapped to s.host_object_id:

class ServicesRelatedQuery
{
    protected $columnMap = array(
        'hosts' => array(
            'h.host_object_id' => 's.host_object_id'
        )
    );

    protected function joinHosts()
    {
        $this->requireVirtualTable('services');
    }
}
2017-12-18 10:23:45 +01:00
Alexander A. Klimov ba9d286567 Remove leading and trailing blanks from ip addresses
refs #2494
2017-12-15 13:08:14 +01:00
Eric Lippmann e376b137c7 Prepare release version 2.5.0 2017-11-27 16:18:13 +01:00
lippserd a5bf9e0175
Merge pull request #3029 from Icinga/bugfix/empty-host-and-service-groups-not-shown-2796
Bugfix/empty host and service groups not shown 2796
2017-11-27 14:24:11 +01:00
Alexander A. Klimov 5f443af14d Accept /monitoring/list/eventgrid?format=*
refs #2678
2017-11-24 17:16:33 +01:00
Alexander A. Klimov 667f3cca01 Fix typo "existance"
refs #3062
2017-11-23 16:28:19 +01:00
Eric Lippmann ca803e8f05 Fix monitoring health badge if programstatus has never been set 2017-11-22 11:12:24 +01:00
Eric Lippmann 3db9a1d77f Fix TacticalController if/else complexity 2017-11-22 11:12:24 +01:00
Jennifer Mourek d34ea588b1 Tactical overview: Add donut graphs 2017-11-21 23:38:04 +01:00
Eric Lippmann fd0fe9a403 Monitoring: Add icons and descriptions for second level menu items 2017-11-21 22:55:46 +01:00
Markus Frosch 762b4eeed2 de_DE: Extend and improve translation
refs #3067
2017-11-21 15:47:46 +01:00
Markus Frosch 2493cb8d63 Fix incorrect uses of translation around sprintf 2017-11-21 15:47:46 +01:00
Johannes Meyer e4fd8d5124 Setup: Only allow to validate the API transport configuration
refs #3101
2017-11-21 13:48:29 +01:00
Markus Frosch 22c6bf75e7 Setup: Fix that the API transport validation does not work
refs #3101
2017-11-21 13:48:17 +01:00
Eric Lippmann d11519ac49 pogsql: Group by custom variables when querying them
Custom variables added via the URL parameters addColumns or sort must be added to the GROUP BY list when using PostgreSQL.

Credits to @nbuchwitz who came up with the initial fix for this.

refs #1873
2017-11-16 09:20:22 +01:00
Florian Strohmaier 166f27b947 CSS: Optimize monitoring status bar spacing 2017-11-13 15:02:06 +01:00
cstegm bb794d6993 Detect UP and DOWN in plugin output to colorize output
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-11-10 11:33:52 +01:00
Klaus Jrgensen fa9b2981d7 Fix PHP fatal error on monitoring/health/info when asking for JSON
Signed-off-by: Eric Lippmann <eric.lippmann@icinga.com>
2017-11-10 11:16:33 +01:00
Eric Lippmann 928185a144 Fix wrong unhandled services count in host views when restrictions are used
The query for fetching the unhandled services count utilises the hosts query as subquery.
Restrictions are applied to both the hosts query and the query for the unhandled services count.
This leads to wrong results since the restrictions are already in place for the unhandled services count because we're using the hosts query as subquery.

refs #2822
2017-11-10 10:17:32 +01:00
Johannes Meyer 23066d2cc4 ServicegroupQuery: Use left joins instead of inner joins
refs #2796
2017-11-09 09:42:46 +01:00
Johannes Meyer 4ef085bdcd HostgroupQuery: Use left joins instead of inner joins
refs #2796
2017-11-09 09:42:46 +01:00
Eric Lippmann 121fdaadb0 Allow to search for host and servicegroups by their case insensitive names too
refs #2971
2017-11-08 15:40:43 +01:00
Eric Lippmann f4ce2a5d82 Fix code style issues 2017-11-08 11:29:33 +01:00
Eric Lippmann 73a6750489 Make phpcs and PhpStorm happy w/ intentional switch, case fall-throughs
Unfortunately, PhpStorm does not regonise PSR2 fall-through comments.
On the other hand, phpcs does not support the @noinspection phpdoc comment (/**).
The fix is a mix of PSR2 comments and @noinspection tags in code comments.
2017-11-08 10:25:28 +01:00
Markus Frosch c3ef50978a style: Fix minor styleguide issues for PHPCS 2017-11-08 10:06:45 +01:00
lippserd 2caa07ce9b
Merge pull request #3027 from Icinga/bugfix/respect-limits-and-sort-order-for-format-requests-2967
Respect limits and sort orders for format requests
2017-11-06 09:51:19 +01:00
Michael Friedrich 1748b3df9d Fix help for icingacli monitoring list (--unhandled is --problems, etc.)
The help text still showed the wrong paramter, while it was not documented
as possible parameter either. In addition to that #562 unveils that a
custom --format parameter requires selected columns to do so.

This patch adds that into the documentation which is rendered as CLI command
help text then.

refs #562
2017-10-24 21:05:39 +02:00