486104d59e
Check explictly for FALSE when calling onSuccess()
...
This allows us to just end onSuccess() without requiring it to return TRUE
to initiate redirection.
refs #5525
2014-08-29 09:04:20 +02:00
e1329058db
Do not hard code the name of the form identification element
...
Like the csrf element name the form identification element name should
be publicly accessible as well.
refs #5525
2014-08-27 13:14:40 +02:00
6783d51f76
A form is "submitted" when it was "sent" but no submit label was set
...
This enables us to use handleRequest() as is when no specific submit button
is required.
refs #5525
2014-08-27 10:28:50 +02:00
0ff79b0948
Replace Form::onFailure() with Form::onShow()
...
There is currently no usecase for onFailure() but for onShow() wherewith
the case is covered when a form needs to be prepared before showing it
to the user while the form was not submitted in any way.
refs #5525
2014-08-27 10:25:50 +02:00
d3c2fc858c
Access formdata internally using a public helper method
...
This way concrete form implementations can also simply fetch form
dependent request values without referring to the form's submission
method.
refs #5525
2014-08-27 10:19:33 +02:00
65dd3f9a5b
Make the form in view scripts accessible using $form instead of $element
...
refs #5525
2014-08-27 10:10:55 +02:00
98b2bce15e
Icinga\Web\Form::onSuccess() must not return TRUE
...
When using Icinga\Web\Form directly without creating a specific sub-class
and calling handleRequest() one must not get redirected.
refs #5525
2014-08-27 10:09:29 +02:00
45cbd3f067
We do not require the request being passed to handleRequest()
...
refs #5525
2014-08-26 12:31:05 +02:00
5c7999fe9b
Forms should be responsible for any redirection as well
...
If no specific url has been set with setRedirectUrl() a form redirects to the
current action it was posted to.
refs #5525
2014-08-26 12:30:37 +02:00
52534a2f46
It is a form's responsibility to process the request it was submitted with
...
How forms are being validated should not be a task that is part of the
controller action, but should be handled by the form base class as it is
most of the time the same procedure. Now a controller action just sets
up the form to use, calls handleRequest() and acts upon its return value.
(e.g. calling handleRequest() from another form or any redirection)
refs #5525
2014-08-25 17:06:45 +02:00
c93ab7951d
Check whether a form's data was sent instead of whether it's complete
...
It is not sufficient to just check whether all required elements are being
submitted. We definetely need to check whether the submit button was
pressed. But doing this and providing a standard button with a static name
simultaneously will produce conflicts if forms are using the same action
urls. To fix this, we'll add an additional form-identification check by using
a form's name or class.
refs #5525
2014-08-25 16:49:54 +02:00
7b221e2aba
It should not be a form's responsibility how its submit button should look..
...
...in case it's a standard button. No need to be DRY here.
refs #5525
2014-08-22 15:20:54 +02:00
403f745488
Remove obsolete loggingAction
...
refs #6933
2014-08-22 12:34:33 +02:00
5028ec7b0b
Avoid NIH
...
It's useless to have specific getters and setters if generic methods from the
baseclass can be used as well to accomplish the same task.
refs #6641
2014-08-22 12:30:13 +02:00
a0b2c0b454
Fix another documentation block
2014-08-22 12:18:26 +02:00
75a0c17933
Ensure that all forms have a name
...
refs #5525
2014-08-22 12:15:02 +02:00
2b879b344f
Do not populate using createElements() and fix documentation blocks
...
refs #5525
2014-08-22 12:04:14 +02:00
bc05d2ee64
Merge LoggingForm into GeneralForm
...
fixes #6933
2014-08-22 11:05:20 +02:00
d1b1bc368f
Monitoring_ConfigController: don't use SecurityForm::isSubmittedAndValid()
...
refs #5525
2014-08-21 11:51:49 +02:00
b81e96574a
SecurityForm: replace create() with createElements() and add addSubmitButton()
...
refs #5525
2014-08-21 11:48:07 +02:00
11063495b2
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
modules/monitoring/application/controllers/ConfigController.php
2014-08-21 10:22:16 +02:00
b146a8c311
Relax locale code validation to just a format check
...
fixes #6930
2014-08-21 10:07:07 +02:00
b36fe5d564
Fix version access while refreshing translations
2014-08-21 10:07:07 +02:00
36a275371f
Delete unnecessary configurations files from .vagrant-puppet
...
fixes #5749
2014-08-20 16:26:52 +02:00
e0b9730f17
Update configurations source paths in puppet default.pp
...
refs #5749
2014-08-20 16:01:08 +02:00
00ac224ec1
Delete deprecated menu.ini.in
...
refs #5749
2014-08-20 15:39:48 +02:00
bef639ecb8
Update deprecated output variable in puppet files
2014-08-20 15:16:42 +02:00
a8d33d90e2
Monitoring\Object: fix a couple of cv-related issues
...
* Don't throw exceptions with no config
* Provide a secure default if not configured
* Improve code readability
2014-08-20 13:36:03 +02:00
bb7972aa39
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/controllers/AuthenticationController.php
application/controllers/ConfigController.php
application/forms/Authentication/LoginForm.php
application/forms/Preference/GeneralForm.php
modules/monitoring/application/controllers/ChartController.php
2014-08-20 13:13:50 +02:00
bb65fb396a
Merge branch 'bugfix/sensitive-custom-vars-6641'
...
fixes #6641
2014-08-20 12:29:45 +02:00
78b98a7d67
SecurityForm: Add helptext
...
refs #6641
2014-08-20 12:21:11 +02:00
f4b33c64dc
Merge branch 'bugfix/styled-history-views-6637'
...
fixes #6637
2014-08-20 11:39:37 +02:00
09dfcca0bc
Merge branch 'master' into bugfix/styled-history-views-6637
2014-08-20 11:39:03 +02:00
4ceecf1146
Let comment view look more standardized and add limit control
...
refs #6637
2014-08-20 11:34:24 +02:00
4eaf94cdf1
Show only acknowledgement and user comments by default
2014-08-20 11:33:22 +02:00
538c6cf90b
js/events: ignore button/submit clicks
...
In case you clicked a (submit) button in an action row this also
also triggered that row's click handler. As the event is going to be
stopped there, this leads to "unsubmittable forms". Fixed.
fixes #6963
2014-08-20 09:26:16 +02:00
686152abf3
js/events: fix a small bug introduced right now
...
Links on non-multiselect action tables stopped working.
refs #6705
2014-08-19 19:04:29 +02:00
736113c80c
AuthenticationController: show friendlier hints...
...
...while not disclosing sensitive information. More to come once we
have our setup wizard.
fixes #6534
2014-08-19 18:55:58 +02:00
071937910b
Monitoring/Object: filter protected customvars
...
Move the responsibility from the viewscript to Monitoring/Object
refs #6641
2014-08-19 18:46:37 +02:00
ba748cbc4a
Refactor multiSelect and highlight
...
refs #6705
2014-08-19 18:33:28 +02:00
ea0248ecf4
Remove '{{SAVE_ICON}}', tiny design fixes
...
refs #6641
2014-08-19 17:54:22 +02:00
6fe47bf5b0
Fix rows highlighting after refresh
...
fixes #6705
2014-08-19 17:32:17 +02:00
3573908071
Let downtime view look more list-like and fix downtime end calculation
...
refs #6637
2014-08-19 17:03:35 +02:00
995355ec30
lib/Limiter: fix translate w/ sprintf
2014-08-19 16:29:11 +02:00
8c02f140c3
doc: fix translate calls w/ sprintf
2014-08-19 16:22:54 +02:00
c6d4ab4c44
Vagrant/Puppet: add file '/etc/icingaweb/modules/monitoring/config.ini'
...
refs #6641
2014-08-19 15:04:43 +02:00
f49a34625e
Url\Params: check for QUERY_STRING before using it
...
fixes #6957
2014-08-19 14:53:56 +02:00
3e079efe2a
SecurityForm: replace `customvars' with `protected_customvars'
...
refs #6641
2014-08-19 14:51:30 +02:00
7035099468
Fix the host_unhandled_service_count error
...
fixes #6833
2014-08-19 14:43:24 +02:00
65473ac8ee
Monitoring config: use SecurityForm
...
refs #6641
2014-08-19 14:04:00 +02:00
Johannes Meyer
Alexander Klimov
Alexander Fuhr
Thomas Gelf
Eric Lippmann