2851 Commits

Author SHA1 Message Date
Johannes Meyer
5028ec7b0b Avoid NIH
It's useless to have specific getters and setters if generic methods from the
baseclass can be used as well to accomplish the same task.

refs #6641
2014-08-22 12:30:13 +02:00
Johannes Meyer
a0b2c0b454 Fix another documentation block 2014-08-22 12:18:26 +02:00
Johannes Meyer
75a0c17933 Ensure that all forms have a name
refs #5525
2014-08-22 12:15:02 +02:00
Johannes Meyer
2b879b344f Do not populate using createElements() and fix documentation blocks
refs #5525
2014-08-22 12:04:14 +02:00
Johannes Meyer
bc05d2ee64 Merge LoggingForm into GeneralForm
fixes #6933
2014-08-22 11:05:20 +02:00
Alexander Klimov
d1b1bc368f Monitoring_ConfigController: don't use SecurityForm::isSubmittedAndValid()
refs #5525
2014-08-21 11:51:49 +02:00
Alexander Klimov
b81e96574a SecurityForm: replace create() with createElements() and add addSubmitButton()
refs #5525
2014-08-21 11:48:07 +02:00
Johannes Meyer
11063495b2 Merge branch 'master' into bugfix/rebuild-form-builder-5525
Conflicts:
	modules/monitoring/application/controllers/ConfigController.php
2014-08-21 10:22:16 +02:00
Johannes Meyer
b146a8c311 Relax locale code validation to just a format check
fixes #6930
2014-08-21 10:07:07 +02:00
Johannes Meyer
b36fe5d564 Fix version access while refreshing translations 2014-08-21 10:07:07 +02:00
Alexander Fuhr
36a275371f Delete unnecessary configurations files from .vagrant-puppet
fixes #5749
2014-08-20 16:26:52 +02:00
Alexander Fuhr
e0b9730f17 Update configurations source paths in puppet default.pp
refs #5749
2014-08-20 16:01:08 +02:00
Alexander Fuhr
00ac224ec1 Delete deprecated menu.ini.in
refs #5749
2014-08-20 15:39:48 +02:00
Alexander Fuhr
bef639ecb8 Update deprecated output variable in puppet files 2014-08-20 15:16:42 +02:00
Thomas Gelf
a8d33d90e2 Monitoring\Object: fix a couple of cv-related issues
* Don't throw exceptions with no config
* Provide a secure default if not configured
* Improve code readability
2014-08-20 13:36:03 +02:00
Johannes Meyer
bb7972aa39 Merge branch 'master' into bugfix/rebuild-form-builder-5525
Conflicts:
	application/controllers/AuthenticationController.php
	application/controllers/ConfigController.php
	application/forms/Authentication/LoginForm.php
	application/forms/Preference/GeneralForm.php
	modules/monitoring/application/controllers/ChartController.php
2014-08-20 13:13:50 +02:00
Alexander Klimov
bb65fb396a Merge branch 'bugfix/sensitive-custom-vars-6641'
fixes #6641
2014-08-20 12:29:45 +02:00
Alexander Klimov
78b98a7d67 SecurityForm: Add helptext
refs #6641
2014-08-20 12:21:11 +02:00
Johannes Meyer
f4b33c64dc Merge branch 'bugfix/styled-history-views-6637'
fixes #6637
2014-08-20 11:39:37 +02:00
Johannes Meyer
09dfcca0bc Merge branch 'master' into bugfix/styled-history-views-6637 2014-08-20 11:39:03 +02:00
Johannes Meyer
4ceecf1146 Let comment view look more standardized and add limit control
refs #6637
2014-08-20 11:34:24 +02:00
Johannes Meyer
4eaf94cdf1 Show only acknowledgement and user comments by default 2014-08-20 11:33:22 +02:00
Thomas Gelf
538c6cf90b js/events: ignore button/submit clicks
In case you clicked a (submit) button in an action row this also
also triggered that row's click handler. As the event is going to be
stopped there, this leads to "unsubmittable forms". Fixed.

fixes #6963
2014-08-20 09:26:16 +02:00
Thomas Gelf
686152abf3 js/events: fix a small bug introduced right now
Links on non-multiselect action tables stopped working.

refs #6705
2014-08-19 19:04:29 +02:00
Thomas Gelf
736113c80c AuthenticationController: show friendlier hints...
...while not disclosing sensitive information. More to come once we
have our setup wizard.

fixes #6534
2014-08-19 18:55:58 +02:00
Alexander Klimov
071937910b Monitoring/Object: filter protected customvars
Move the responsibility from the viewscript to Monitoring/Object

refs #6641
2014-08-19 18:46:37 +02:00
Alexander Fuhr
ba748cbc4a Refactor multiSelect and highlight
refs #6705
2014-08-19 18:33:28 +02:00
Alexander Klimov
ea0248ecf4 Remove '{{SAVE_ICON}}', tiny design fixes
refs #6641
2014-08-19 17:54:22 +02:00
Alexander Fuhr
6fe47bf5b0 Fix rows highlighting after refresh
fixes #6705
2014-08-19 17:32:17 +02:00
Johannes Meyer
3573908071 Let downtime view look more list-like and fix downtime end calculation
refs #6637
2014-08-19 17:03:35 +02:00
Eric Lippmann
995355ec30 lib/Limiter: fix translate w/ sprintf 2014-08-19 16:29:11 +02:00
Eric Lippmann
8c02f140c3 doc: fix translate calls w/ sprintf 2014-08-19 16:22:54 +02:00
Alexander Klimov
c6d4ab4c44 Vagrant/Puppet: add file '/etc/icingaweb/modules/monitoring/config.ini'
refs #6641
2014-08-19 15:04:43 +02:00
Thomas Gelf
f49a34625e Url\Params: check for QUERY_STRING before using it
fixes #6957
2014-08-19 14:53:56 +02:00
Alexander Klimov
3e079efe2a SecurityForm: replace customvars' with protected_customvars'
refs #6641
2014-08-19 14:51:30 +02:00
Alexander Fuhr
7035099468 Fix the host_unhandled_service_count error
fixes #6833
2014-08-19 14:43:24 +02:00
Alexander Klimov
65473ac8ee Monitoring config: use SecurityForm
refs #6641
2014-08-19 14:04:00 +02:00
Alexander Klimov
1ba3954b95 Monitoring config: implement SecurityForm
refs #6641
2014-08-19 14:02:26 +02:00
Alexander Klimov
6b468b7f9b Monitoring_ConfigController: make writeConfiguration's parameter `file' non-required
refs #6641
2014-08-19 13:51:10 +02:00
Eric Lippmann
d29eb21b5f Merge branch 'feature/display-documentation-4820'
fixes #6730
resolves #4820
resolves #6303
resolves #6484
resolves #6629
resolves #6633
resolves #6726
2014-08-19 13:41:21 +02:00
Eric Lippmann
1c74fd7028 Merge branch 'master' into feature/display-documentation-4820
Conflicts:
	modules/doc/library/Doc/DocParser.php
2014-08-19 13:39:48 +02:00
Eric Lippmann
f52b3f7b8c doc/config: add menu.ini
refs #4820
2014-08-19 13:38:34 +02:00
Eric Lippmann
55b3a5384a doc: set page title
refs #4820
2014-08-19 13:38:18 +02:00
Eric Lippmann
d35e0816c9 doc: use `sprintf' in exceptions
refs #4820
2014-08-19 13:20:46 +02:00
Alexander Fuhr
2f54ff4797 Fix the unrelated tabs
resolves #6934
2014-08-19 13:18:52 +02:00
Thomas Gelf
cd825a4e6b tests/ScrollingStyle: adjust, pagination shortened
Pagination has been "shortened" some time ago to waste less space,
tests now fit the current implementation.

fixes #6594
fixes #6595
2014-08-19 12:45:42 +02:00
Thomas Gelf
3f65f3447d Web\UrlTest: test should use %20 instead of +
We MUST use rawurlencode everywhere to avoid potential conflicts with
URLs created on JS side.

refs #6604
2014-08-19 12:39:53 +02:00
Thomas Gelf
db3ef8fbd0 ActionController: remove redirectToLogin default
The redirectOnLogin function now doesn't have any predefined default.
This also leads to the behaviour that "Logout" will not redirect you
anywhere on a new login while "forcibly being logged out" (e.g. by
logging out in another browser tab) will bring you back to where you
came from.
2014-08-19 12:28:24 +02:00
Thomas Gelf
7334716d15 favicon: add link type
The favicon link tag was missing a type attribute.
2014-08-19 12:25:14 +02:00
Thomas Gelf
f40ada6c81 js/ui: check whether a link tag has a type
The new favicon didn't have such, resulting in JS error when reloading
CSS at runtime.
2014-08-19 12:23:51 +02:00