fc72ddfbc8
Adjust Preferences/GeneralForm to use handleRequest() &. Co.
...
refs #5525
2014-09-05 10:21:24 +02:00
d021747bde
Fix form widgets
...
refs #5525
2014-09-05 09:17:09 +02:00
8846f17ae1
Make it possible to disable form identification
...
refs #5525
2014-09-05 09:16:09 +02:00
ba623d0544
SearchDashboard: adjust SearchDashboardTest and rename searchQuery to searchString
2014-09-04 22:54:41 +02:00
0f7f2f2d8b
SearchDashboard: rename ::load() to ::search()
...
Function signature didn't match parent factory function
fixes #7081
2014-09-04 19:35:31 +02:00
0f8d5bddba
Web\Menu: make use of Web\Url
...
refs #7083
2014-09-04 19:18:09 +02:00
f91892cb80
Web\Url: add matches() function
...
fixes #6992
2014-09-04 18:46:58 +02:00
e4d1143870
Add SearchDashboardTest
2014-09-04 18:31:08 +02:00
70146c43e7
Icinga\Protocol\File\FileReader: implement Icinga\Data\Selectable, and Countable
2014-09-04 16:59:37 +02:00
3c4a719feb
Revert "Icinga\Protocol\File\FileReader: implement Icinga\Data\Selectable, ...\Fetchable and Countable"
...
This reverts commit 7edbb8f27216e6faa0d0dc5a71b407748e9dd535.
2014-09-04 16:55:02 +02:00
876b94cccf
Icinga\Protocol\File\FileReader: implement Icinga\Data\Selectable, ...\Fetchable and Countable
2014-09-04 16:54:14 +02:00
f0969e0b2e
Split Icinga\Protocol\File\FileReader into ...\FileReader and ...\FileIterator
2014-09-04 16:37:26 +02:00
fcd12073f8
Rename Icinga\Protocol\File\Query to ...\File\FileQuery
2014-09-04 16:37:25 +02:00
36a3c36c1b
Rename Icinga\Protocol\File\Reader to ...\File\FileReader
2014-09-04 16:37:24 +02:00
1eacde0233
Implement modules self provided search configuration
...
refs #6495
2014-09-04 16:31:10 +02:00
c8eaf66823
GrapherHook: Rework hook
...
refs #6932
2014-09-04 14:00:48 +02:00
4fb47ef768
Hook classes: Add class suffix if not exist
...
refs #7066
refs #7067
refs #7068
2014-09-04 14:00:48 +02:00
eeed030bb5
Do not use an invalid HTML attributes for rich titles
2014-09-04 13:32:30 +02:00
c3c0043307
Merge branch 'master' into bugfix/commands-6593
2014-09-03 23:23:20 +02:00
a4da3b61b3
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
2014-09-03 23:23:02 +02:00
2eccc6188f
Merge branch 'master' into bugfix/rebuild-application-log-logic-7060
2014-09-03 19:08:40 +02:00
ede5b8f0b9
Icinga\Protocol\File\Reader::fetchPairs(): increase $index manually as the iterator's one makes trouble
...
refs #7060
2014-09-03 18:36:59 +02:00
da85112538
Merge branch 'master' into feature/svg-chart-tooltips-7024
2014-09-03 17:08:00 +02:00
37b168995b
Rename tipsy stylesheet file type to css and add license
2014-09-03 17:01:07 +02:00
e45f50408a
Icinga\Protocol\File\Reader::fetchPairs(): rename variables
...
$skipLines -> $skip
$readLines -> $read
refs #7060
2014-09-03 16:14:14 +02:00
b10b1ea034
Add jQuery tooltips
2014-09-03 15:53:56 +02:00
88dde47b7a
Foreach: add $value so that the value won't be assigned to $key
...
refs #7060
2014-09-03 15:39:25 +02:00
2025fb3a2f
lib: Let the date-and-time input control behave as defined in HTML5
...
refs #6593
2014-09-03 14:40:58 +02:00
acbd2bd7c0
Merge branch 'master' into feature/dashboard-component-disabled-property-6986
2014-09-03 14:40:30 +02:00
906de4e679
lib: Add the HTML5 attributes 'min', 'max' and 'step' to the number input control
...
refs #6593
2014-09-03 14:39:42 +02:00
774db9a7c8
lib: Add function `isUnixTimestamp' to the `DateTimeFactory'
...
Before, the `DateTimeValidator' defined this function.
refs #6593
2014-09-03 14:37:33 +02:00
1a4e908461
lib: Let `DateTimeValidator' validate values as defined in HTML5
...
See http://www.w3.org/TR/html-markup/datatypes.html#common.data.datetime for the specification.
refs #6593
2014-09-03 14:36:18 +02:00
7cfc051228
Add tests for Dashboard and fix doc blocks
...
refs #6986
2014-09-03 14:36:04 +02:00
33669f8969
Logger: add/update documentation
...
refs #7060
2014-09-03 13:53:46 +02:00
54a834266c
Form::createElements() should add elements instead of returning them
...
In case createElements() would still return the elements while requiring
the caller to add them to the form all form dependent configurations get
lost. (displaygroups, belongTo, ...) Wizards or parent forms can still
retrieve only input relevant fields by just calling createElements() and
getElements().
refs #5525
2014-09-03 12:21:31 +02:00
1e06c20dcb
FileWriter: implement getPath()
...
refs #7060
2014-09-03 12:09:38 +02:00
6aeab59ead
Logger: implement getWriter() and getInstance()
...
refs #7060
2014-09-03 12:02:11 +02:00
70cf14f775
Logger: rename getWriter() -> createWriter()
...
refs #7060
2014-09-03 11:34:21 +02:00
3ade6da44d
FileReaderException: extend IcingaException
2014-09-03 11:14:22 +02:00
3d352ba446
Filter: add FilterNotEqual and FilterMatch
...
fixes #6557
2014-09-02 19:51:56 +02:00
0b1d2bf685
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
2014-09-02 17:09:36 +02:00
5485ca8a25
lib: Use Zend's `Int' validator in the `Number' form element
...
Further disabled default decorators since our form sets them.
refs #5525
2014-09-02 16:54:43 +02:00
b60b811335
ApplicationBootstrap: list "core" translations
...
Just to make application fit module capabilities. We might find a better
place for both later on.
refs #7054
2014-09-02 16:51:17 +02:00
95c839a8bd
Remove remaining usages of the ElementWrapper- and HelpText-Decorator
...
refs #5525
2014-09-02 16:50:59 +02:00
6faedf5733
ActionController: no benchmark for no renderer
...
Benchmarks should not be shown when the renderer is no longer available.
2014-09-02 16:49:28 +02:00
4cef333add
Modules\Module: implement listLocales
...
fixes #7054
2014-09-02 16:28:27 +02:00
e4687a60f9
Web\JavaScript: use Cache and ETags
...
refs #6927
2014-09-02 16:25:44 +02:00
1ba3df310c
Remove BaseConfigController, User\Message and Widget\AlertMesageBox
...
refs #6758
2014-09-02 16:25:03 +02:00
539ab91ffa
Add the FormErrors decorator as default decorator for forms
...
This allows us to use Zend_Form::addError() to show error messages for
the entire form context.
refs #5525
2014-09-02 16:25:03 +02:00
f0d6cf994e
Web\StyleSheet: use Cache and ETags
2014-09-02 16:24:55 +02:00
ff6483cec5
Web\FileCache: initial implementation
...
refs #6927
2014-09-02 16:22:48 +02:00
338f549233
Add class ReadablePathValidator
2014-09-02 16:19:45 +02:00
39bb01b433
Rename Icinga\Web\Form::onShow() to onRequest()
...
onShow() is misleading because at the time this method is being called the
form is neither shown nor created.
refs #5525
2014-09-02 16:19:45 +02:00
9bcd861b1c
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
2014-09-02 15:27:27 +02:00
d4c4ab7b2c
lib/form: Fix default element decorators but breaking noscript layout
...
Replaced `ElementWrapper' and `HelpText' with Zend's `HtmlTag' and `Label' respectively.
Instances of Zend_Form_Element returned by `Form::createElements()' now receive our desired default decorators.
refs #5525
2014-09-02 15:23:07 +02:00
8478ef3fce
lib: Remove `HelpText' form element decorator
...
Zend already has a `Description' decorator.
refs #5525
2014-09-02 15:05:47 +02:00
7143837ae3
lib: Remove `ElementWrapper' form element decorator
...
Zend has a `Label' decorator already.
refs #5525
2014-09-02 15:04:23 +02:00
62c0f0be03
Web\Session: implement lazy loading
...
fixes #7055
2014-09-02 13:23:15 +02:00
26339b128a
Add disabled property and implement the functionality
...
refs #6986
2014-09-02 13:16:21 +02:00
4b55bcf8b6
Add tooltips to bar charts
...
Add a class to format and populate tooltips from graph data sets and implement
those tooltips in the ChartController.
2014-09-02 12:24:29 +02:00
bb0e1dc105
Revert "Fixes unaccepted behavior in module configuration"
...
This reverts commit 236d384bab
2014-09-02 10:23:41 +02:00
ee6145a173
Ldap/Query: Remove __toString()
...
This is needed because of exception handling. Exceptions can now bubble
up for default handling. Method render() was renamed to create() because
the method create a query. Adjust the test for method create().
refs #5536
2014-09-02 10:17:01 +02:00
baf768040f
LdapQuery: Use Ldap/Exception for errors
...
refs #5536
2014-09-02 09:55:57 +02:00
6b6826f737
Bug7043Test: Fix test to run without ini configuration
...
fixes #7043
2014-09-01 15:53:32 +02:00
cd8015f41a
Pass the current form instance to the callback as second argument
...
refs #5525
2014-09-01 14:58:16 +02:00
30965c247b
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
2014-09-01 14:50:32 +02:00
0822aff293
library/form: Fix return value of `getName()' not being filterd the first time it's called
...
`Form::getName()' auto-detects the form's name if it's not set and sets the form's name using `Zend_Form::setName()'.
`Zend_Form::setName()' then filters the form name stripping backslash '\' characters. The first call to `Form::getName()'
did not regard the filtering and thus returned the unfiltered name which led to `Form::wasSent()' returning `false'.
refs #5525
2014-09-01 14:40:45 +02:00
30f391035c
Postgres/DbQuery: Add orderfields to select
...
refs #6896
2014-09-01 10:00:04 +02:00
f3e74f0f24
library/form: Append class 'autosubmit' in case the element to autosubmit has the class attribute set
...
Before, the class attribute would've been overwritten.
refs #5525
2014-09-01 09:44:04 +02:00
a01ee00c27
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
...
Conflicts:
library/Icinga/Protocol/Commandpipe/Transport/Transport.php
2014-08-29 17:24:44 +02:00
fb5685bac3
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Config/Authentication/BaseBackendForm.php
application/forms/Config/Authentication/DbBackendForm.php
application/forms/Config/Authentication/LdapBackendForm.php
application/forms/Config/Authentication/ReorderForm.php
application/forms/Config/LoggingForm.php
application/forms/Config/ResourceForm.php
application/forms/Preference/GeneralForm.php
library/Icinga/Application/Config.php
library/Icinga/Web/Form.php
modules/monitoring/application/controllers/ConfigController.php
modules/monitoring/application/forms/Config/Backend/CreateBackendForm.php
modules/monitoring/application/forms/Config/Instance/CreateInstanceForm.php
modules/monitoring/application/forms/Config/Instance/EditInstanceForm.php
modules/monitoring/application/forms/Config/SecurityForm.php
2014-08-29 16:05:56 +02:00
e020dd3541
Icinga\App..\Config: Rename __construct to fromIni and add setConfigPath
...
Prior to this change it was not possible to create an instance of Config
without passing a config file.
2014-08-29 12:23:48 +02:00
79b0ed64ec
Make it possible to provide a closure to be called instead of onSuccess()
...
This allows us to write generic forms like the ConfirmRemoval form but to
utilize handleRequest() while providing a closure in the array that is passed
to a form's constructor.
refs #5525
2014-08-29 12:21:31 +02:00
bf23688e73
Make autosubmit work in non-JS enviroments
...
We require forms to set autosubmit=true on elements which are supposed
to be submitted automatically now. The base form then ensures that this
works in JS environments and non-JS environments as well by applying the
right changes to the HTML.
refs #5525
2014-08-29 09:08:53 +02:00
486104d59e
Check explictly for FALSE when calling onSuccess()
...
This allows us to just end onSuccess() without requiring it to return TRUE
to initiate redirection.
refs #5525
2014-08-29 09:04:20 +02:00
3642b7b6fc
Adjust CSS for inlinePies to be centered on the current line
2014-08-28 18:27:30 +02:00
a26370bb12
Adjust PieCharts that are rendered without labels
...
Center and resize PieCharts to use the full width and height of the available view port
2014-08-28 18:25:19 +02:00
00a2d225a2
Ensure that PieCharts are centered and that labels dont leave the viewBox
...
Add scaling and transformations to move the PieChart into a valid coordinate system and reduce the offset of the labels to make more efficient use of available space.
2014-08-28 16:42:31 +02:00
c5cface661
Improve readability of small pie charts
...
Use a bigger font, to ensure that small pie charts still have readable labels.
2014-08-28 16:40:34 +02:00
98809a1447
Do not use width and height as width and height percentages in the outer SVG element
...
Height and width are solely used to define the SVGs ratio and should not cause side effects on the SVGs size in the site context.
2014-08-28 16:37:21 +02:00
a9eec0d672
Remove useless width and height properties from PieChart
2014-08-28 16:33:38 +02:00
f77cd9cafa
Fix coding guidelines
2014-08-28 16:21:16 +02:00
573a4ea12f
Fix spelling mistakes
2014-08-28 16:14:59 +02:00
4ca1eaa7ce
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
...
Conflicts:
library/Icinga/Web/Form.php
modules/monitoring/application/forms/Config/SecurityForm.php
2014-08-28 13:58:02 +02:00
e345aa257a
Platform: Drop *Available function
...
Create a function extensionLoaded and change usages.
refs #5514
2014-08-28 12:14:55 +02:00
9d0037a53a
ResourceFactory: Add function create(<name>)
...
The ConfigAwareFactory is an interface forcing "backend-type" classes to call
ResourceFactory::createResource() passing a config they got in the constructor.
That's kind of overdesigned, if the ResourceFactory wants to be something like
a service locator it's responsabilities should include object instantiation.
refs #5514
2014-08-28 12:14:54 +02:00
35d11bd145
Class doc for Platform
...
refs #5514
2014-08-28 12:14:54 +02:00
9b83074cc9
Class doc for ResourceFactory
...
refs #5514
2014-08-28 12:14:54 +02:00
22e17e9901
ResourceFactory: Move available function to platform
...
refs #5514
2014-08-28 12:14:54 +02:00
947cd0c5d3
Merge branch 'master' of git.icinga.org:icingaweb2
...
fixes #7006
2014-08-27 17:22:09 +02:00
e6612fefe7
FilterParseException: extend IcingaException
...
refs #6931
2014-08-27 16:26:43 +02:00
afd0c20c42
FilterException: extend IcingaException
...
refs #6931
2014-08-27 16:23:44 +02:00
45638b218c
Throw IcingaException rather than Exception
...
fixes #7014
2014-08-27 16:03:15 +02:00
7ff51caed0
Remove leading backslashes from the targets of use statements
...
- use \Exception;
+ use Exception;
2014-08-27 15:51:49 +02:00
236d384bab
Fixes unaccepted behavior in module configuration
...
fixes #7011
2014-08-27 14:57:08 +02:00
4a59ff6712
Support preserveAspectRatio in SVGRenderer
...
Add support for the preserveAspectRatio attributes in root SVG elements, to improve the handling of padding and automatic resizing of inline SVG.
2014-08-27 13:51:52 +02:00
e1329058db
Do not hard code the name of the form identification element
...
Like the csrf element name the form identification element name should
be publicly accessible as well.
refs #5525
2014-08-27 13:14:40 +02:00
1dea19504f
Revert "Remove leading backslashes from the targets of use statements"
...
This reverts commit 87a5967501
2014-08-27 12:24:11 +02:00
88698cb05d
Hook/TopBar: Rework interface for monitoring top bar
...
refs #6929
2014-08-27 11:31:48 +02:00
b7ae66b496
Hook: Add web hook base class
...
refs #6929
2014-08-27 11:31:47 +02:00
e0d7c3855d
Hook: Add class suffix for base class testing
...
refs #6928
2014-08-27 11:31:47 +02:00
87a5967501
Remove leading backslashes from the targets of use statements
...
- use \Exception;
+ use Exception;
2014-08-27 11:16:44 +02:00
5abf41edef
Hook/ConfigurationTab: Remove deprecated implementation
...
ConfigurationTab hook is not used anywhere. Test is
removed also.
2014-08-27 10:29:04 +02:00
6783d51f76
A form is "submitted" when it was "sent" but no submit label was set
...
This enables us to use handleRequest() as is when no specific submit button
is required.
refs #5525
2014-08-27 10:28:50 +02:00
0ff79b0948
Replace Form::onFailure() with Form::onShow()
...
There is currently no usecase for onFailure() but for onShow() wherewith
the case is covered when a form needs to be prepared before showing it
to the user while the form was not submitted in any way.
refs #5525
2014-08-27 10:25:50 +02:00
d3c2fc858c
Access formdata internally using a public helper method
...
This way concrete form implementations can also simply fetch form
dependent request values without referring to the form's submission
method.
refs #5525
2014-08-27 10:19:33 +02:00
65dd3f9a5b
Make the form in view scripts accessible using $form instead of $element
...
refs #5525
2014-08-27 10:10:55 +02:00
98b2bce15e
Icinga\Web\Form::onSuccess() must not return TRUE
...
When using Icinga\Web\Form directly without creating a specific sub-class
and calling handleRequest() one must not get redirected.
refs #5525
2014-08-27 10:09:29 +02:00
89541f5727
Merge branch 'bugfix/hook-interface-6932'
...
fixes #6932
fixes #6928
2014-08-27 09:39:56 +02:00
7e5b5a0b30
Hook/Grapher: Rework hook interface
...
Rework interface based on specification and changed consumer calls.
refs #6932
2014-08-27 09:35:43 +02:00
1ff63dbf3f
Support nested keys expressed as single strings in the PreservingIniWriter
...
Automatically convert keys with dots into nested configurations to avoid errors during the property diff, of the old and new configuration file.
2014-08-26 18:05:22 +02:00
6b88f1c98e
Move Commandpipe/* classes from Icinga Web 2's library to the monitoring module
...
refs #6593
2014-08-26 16:35:30 +02:00
ff1d2e4fed
Fix coding style
2014-08-26 15:20:15 +02:00
23aa57a5d7
Remove 100% pie slice hack
...
The getPieSlicePath primitive can draw it now.
2014-08-26 15:20:15 +02:00
2575634dec
Draw full circle pie slice (100%) as a primitive
...
Allows getPieSlicePath to draw a full circle pie slice (100%) by slightly adjusting endpoint to have a valid arc. Also hides a central line as there will be no more pie slices.
2014-08-26 15:20:15 +02:00
376e9aa160
Rename hook base classes
...
Adding suffix "Hook" to every base class. This simplifies development
because you don't need to alias bases classes in your concrete
hook classes
refs #6928
2014-08-26 14:29:55 +02:00
45cbd3f067
We do not require the request being passed to handleRequest()
...
refs #5525
2014-08-26 12:31:05 +02:00
5c7999fe9b
Forms should be responsible for any redirection as well
...
If no specific url has been set with setRedirectUrl() a form redirects to the
current action it was posted to.
refs #5525
2014-08-26 12:30:37 +02:00
1f7d4cb61b
Merge branch 'master' into bugfix/exceptions-with-printf-params-6931
2014-08-26 11:24:33 +02:00
a2011b1665
SystemPermissionException: extend IcingaException
...
refs #6931
2014-08-26 11:21:57 +02:00
febb2d1ae2
ProgrammingError: extend IcingaException
...
refs #6931
2014-08-26 11:15:19 +02:00
d8bbd7a0a0
Merge branch 'bugfix/modules-dashlet-provider-6639'
...
fixes #6639
2014-08-26 10:57:37 +02:00
4ec6dbe3f0
Prefer single quotes ' rather than double quotes "
2014-08-26 10:41:17 +02:00
42e2b34356
Implement self provided configuration for dashboard/dashlets in modules
...
refs #6639
2014-08-26 10:34:36 +02:00
f754531e4d
Fix grammatical error
2014-08-26 10:22:14 +02:00
52534a2f46
It is a form's responsibility to process the request it was submitted with
...
How forms are being validated should not be a task that is part of the
controller action, but should be handled by the form base class as it is
most of the time the same procedure. Now a controller action just sets
up the form to use, calls handleRequest() and acts upon its return value.
(e.g. calling handleRequest() from another form or any redirection)
refs #5525
2014-08-25 17:06:45 +02:00
c93ab7951d
Check whether a form's data was sent instead of whether it's complete
...
It is not sufficient to just check whether all required elements are being
submitted. We definetely need to check whether the submit button was
pressed. But doing this and providing a standard button with a static name
simultaneously will produce conflicts if forms are using the same action
urls. To fix this, we'll add an additional form-identification check by using
a form's name or class.
refs #5525
2014-08-25 16:49:54 +02:00
7074fa1331
NotWritableError: extend IcingaException
...
refs #6931
2014-08-25 12:56:35 +02:00
6c9947326d
NotReadableError: extend IcingaException
...
refs #6931
2014-08-25 12:38:34 +02:00
f4dbb4df96
NotImplementedError: extend IcingaException
...
refs #6931
2014-08-25 12:21:59 +02:00
013aad8f73
MissingParameterException: extend IcingaException
...
refs #6931
2014-08-25 12:14:18 +02:00
7b221e2aba
It should not be a form's responsibility how its submit button should look..
...
...in case it's a standard button. No need to be DRY here.
refs #5525
2014-08-22 15:20:54 +02:00
2b879b344f
Do not populate using createElements() and fix documentation blocks
...
refs #5525
2014-08-22 12:04:14 +02:00
9c5878cbbe
ConfigurationError: extend IcingaException
...
refs #6931
2014-08-22 11:46:11 +02:00
20cead67a6
Merge branch 'master' into bugfix/modules-menu-provider-6639
2014-08-22 11:44:10 +02:00
1886569174
Implement Module self provided configuration for menus
...
refs #6639
2014-08-22 11:35:42 +02:00
bc05d2ee64
Merge LoggingForm into GeneralForm
...
fixes #6933
2014-08-22 11:05:20 +02:00
b764993091
AuthenticationException: extend IcingaException
...
refs #6931
2014-08-22 10:59:52 +02:00
b55a313146
Implement IcingaException
...
refs #6931
2014-08-22 10:27:30 +02:00
09412d03b6
Benchmark: hide timestamp on HTML output
...
Wastes space and is mostly useless, absolut and relative expired time
gives more than enough information.
2014-08-22 09:34:43 +02:00
8733238a6e
Loader::registerNamespace(): correct exception message
2014-08-21 12:40:41 +02:00
bb7972aa39
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/controllers/AuthenticationController.php
application/controllers/ConfigController.php
application/forms/Authentication/LoginForm.php
application/forms/Preference/GeneralForm.php
modules/monitoring/application/controllers/ChartController.php
2014-08-20 13:13:50 +02:00
995355ec30
lib/Limiter: fix translate w/ sprintf
2014-08-19 16:29:11 +02:00
f49a34625e
Url\Params: check for QUERY_STRING before using it
...
fixes #6957
2014-08-19 14:53:56 +02:00
1c74fd7028
Merge branch 'master' into feature/display-documentation-4820
...
Conflicts:
modules/doc/library/Doc/DocParser.php
2014-08-19 13:39:48 +02:00
db3ef8fbd0
ActionController: remove redirectToLogin default
...
The redirectOnLogin function now doesn't have any predefined default.
This also leads to the behaviour that "Logout" will not redirect you
anywhere on a new login while "forcibly being logged out" (e.g. by
logging out in another browser tab) will bring you back to where you
came from.
2014-08-19 12:28:24 +02:00
a38d71f17c
Cli\Command: provide Config()
...
This makes it feel more like action controllers
fixes #6954
2014-08-19 10:27:26 +02:00
9d4a4f49c9
ActionController: JS should redirect to __SELF__...
...
...once you lost your session. That's the only way to do this in a
smooth way. When the server get's an unauthenticated request for a
single container, redirecting to auth/login?redir=<that-container>
was not what you expect.
Together with JS handling __SELF__ in redirection URLs this will
play fine.
refs #6935
2014-08-19 09:57:24 +02:00
b9cc964e24
Url\Params: remove() should reindex on change
...
There was a small bug, fixed.
refs #6699
2014-08-19 09:49:53 +02:00
344909dfcd
Web\UrlParams: add() and set() should encode...
...
...while there is now a addEncoded function, mostly for internal use.
refs #6699
2014-08-19 09:45:58 +02:00
217595dc15
Web/Url: more intuitive separator usage
...
One might not expect to get a URL with params separated by & while
this is the correct way of writing them to HTML attributes. So default
behaviour is right now that all functions return URL params separated
by &, but if you cast a URL (or it's params) to a string, & will be
used.
Additionally there are toString functions allowing you to choose the
separator "manually".
refs #6699
2014-08-19 09:42:16 +02:00
7caccd7691
Web\Url: remove stripUrlFragment()
...
This function had an interesting history and seems to be a result of
missunderstanding of each others commits. Removed, as the fragment is
already there.
refs #6699
2014-08-19 09:36:15 +02:00
f2ed813c9a
Fix that Icinga\Web\Url::fromPath drops fragments
...
fixes #6284
2014-08-14 14:23:31 +02:00
4ddc0e718b
Report the default language also as being available for setting up the locale
...
fixes #6905
2014-08-14 10:48:52 +02:00
dc8181cdc5
Escape linefeeds and carriage returns in commands and show them as html
...
fixes #6088
2014-08-14 10:23:04 +02:00
666591beb7
Encode url before passing it to Icinga\Form\Dashboard\AddUrlForm
...
fixes #6611
2014-08-13 16:41:40 +02:00
7311ab964e
Do not set the full url from the request as action with form parameters
...
Setting an url with parameters named like form elements in a form with
method POST causes Zend to ignore any POST data because GET will be
processed with higher priority.
fixes #6806
2014-08-13 14:50:21 +02:00
e7da9c0a00
Make our anti CSRF logic being a form element
...
refs #5525
2014-08-12 14:43:10 +02:00
fe63ce664f
Make use if 'ignore´ instead of explicitly unsetting array keys
...
refs #5525
2014-08-12 13:57:28 +02:00
4b1169c0a1
Fix improper form submission
...
refs #5525
2014-08-12 10:41:19 +02:00
8f729bfb65
ActionController: set a default window title
...
In case a controller action didn't set a view title this fix restores
the default title on XHR requests.
fixes #6797
2014-07-31 17:04:26 +02:00
56a29354d3
AutoLogin: Check the remote username against logged in user
...
fixes #6462
2014-07-30 12:54:08 +02:00
e2c761a7aa
AutoLogin/Logout: Remove own session namespace
...
Store data in the user and implement interface to left
backends store remote information.
fixes #6461
2014-07-30 12:35:55 +02:00
294728ac47
Revert "Autologin: Test logged session against remote user"
...
This reverts commit 64954e9924#6462
2014-07-29 17:50:44 +02:00
64954e9924
Autologin: Test logged session against remote user
...
fixes #6462
2014-07-29 12:06:43 +02:00
8b9d446d2e
Autologin: Remove deprecated autologin methods
...
Remove methods from manager because autologin
is now handled with special backends (AutoLoginBackend).
The session is used to store the status about a remote
user authentication to send a 401 header to the client
upon logout.
refs #6461
2014-07-29 10:48:57 +02:00
edc89d6ad6
lib: Remove `NodeRenderer'
...
`NodeRenderer' is superseded by `TocRenderer'.
2014-07-28 19:12:35 +02:00
e26d360561
lib/Node: Remove method `findNodeBy()'
...
The new `DocTree' class provides `getNode()'.
2014-07-28 19:07:13 +02:00
bbcdcb4609
lib: Add `Identifiable' interface for objects that are identifiable by an ID of any type
2014-07-28 19:05:37 +02:00
c3731fa79e
Adjust removeresource-action to suit the new resource form interface
...
refs #5525
2014-07-24 16:17:30 +02:00
a68ccecb28
Revert "Do not use htmlspecialchars in widgets"
...
This reverts commit 2ff43abcf5
2014-07-23 12:28:04 +02:00
2ff43abcf5
Do not use htmlspecialchars in widgets
...
refs #6759
2014-07-23 12:12:05 +02:00
8b2cc3a558
Do not consider <button type=submit> when checking form completion
...
refs #5525
2014-07-23 10:58:45 +02:00
0bf0213547
Rename Form::addElement to Form::createElement
...
Since we are using mainly createElement and addElement is only an alias for
createElement if no object is passed our changes to addElement can safely
be moved to createElement.
refs #5525
2014-07-23 10:57:46 +02:00
25c9ee567d
Add missing use statement for Zend_View_Abstract
2014-07-23 10:54:22 +02:00
e005333806
Merge branch 'master' into feature/display-documentation-4820
2014-07-22 12:25:58 +02:00
0eaaaf2f29
Make bar charts thicker
2014-07-22 11:32:52 +02:00
4b8bb99fa1
Fix svg text rotation in firefox
...
Use the SVG transform attribute instead of the writing-mode attribute to support firefox.
2014-07-22 11:26:35 +02:00
0a500efd8a
Determine the max value in LinearUnit dynamically
...
The range between min and max should always be divisable by the amount of
ticks, to ensure that the vertical lines are always at a full discrete value.
fixes #6769
2014-07-21 17:21:54 +02:00
75e09f2c69
Do not consider submit buttons when checking form completion
...
refs #5525
2014-07-21 15:25:00 +02:00
cebd71b2ff
Fix "Fatal error: Interface 'Icinga\Data\DatasourceInterface' not found in Icinga\Protocol\File\Reader"
...
fixes #6722
2014-07-21 14:14:13 +02:00
c5ecbf250d
lib: add FileReaderException for file reader specific errors
...
refs #6722
2014-07-21 14:11:08 +02:00
6df7be7ee5
File/Query: Fix `applyFilter' and `order' not matching SimpleQuery's interfaces
...
refs #6722
2014-07-21 14:09:40 +02:00
091ddbe552
Partiall revert bfc54b7e
...
Refactor Url->getParams() to return an instance of UrlParam instead of an array.
fixes #6760
2014-07-21 09:22:19 +02:00
f5ac592645
Do not consider disabled elements when checking form completion
...
Values of disabled inputs are not sent by browsers.
refs #5525
2014-07-21 08:57:41 +02:00
5ea02b41ea
Optimize variable names and positions, cast array direct to object
2014-07-18 17:35:24 +02:00
2a204897b4
DbQuery: improve method description
...
Not English mine this was, copy paste did I ;)
2014-07-18 16:48:52 +02:00
209894d857
DbQuery: add dummy isTimestamp function
...
Not the best solution, but helps for now.
fixes #6675
2014-07-18 16:35:29 +02:00
f4ff2c90f2
It's a form's responsibility how its submit button should look like
...
refs #5525
2014-07-18 09:54:36 +02:00
6ac471c598
Also mention the viewscript functionality of Form::loadDefaultDecorators()
...
refs #5525
2014-07-18 09:52:50 +02:00
8f0b9899a3
We cannot know what kind of data is passed to Form::isValid()
...
refs #5525
2014-07-18 09:52:05 +02:00
78a6175acc
Make form creation lazy and implement the new validation mechanism
...
Form creation must not depend on specific function calls. If a forms' elements are required and missing, create them. Form::isValid() must be
able to determine whether a form can be processed or not without to rely
on a particular button value.
refs #5525
2014-07-18 09:51:15 +02:00
37fd3deb67
Rename initCsrfToken to addCsrfToken and move it upwards
...
Form::addCsrfToken() should be public and fluent to ensure more
flexibility.
refs #5525
2014-07-18 09:43:03 +02:00
58188c5cc1
We only want to rely on Form::isValid() when about to process forms
...
As the new auto-submission implementation does not depend on whether
a submit button was pressed or not we need another way to determine
whether a form should be processed.
refs #5525
2014-07-18 09:33:09 +02:00
802c095bf8
Configuration values need to be inserted to forms explicitly
...
It's the controllers' responsibility to ensure that forms are populated with
configuration values on GET requests.
refs #5525
2014-07-18 09:27:10 +02:00
21cd503ee7
Form buttons need to be added explicitly
...
We either demand the user to add a submit button or provide a implicit
function call to be implemented by him, adding additional elements once
the form gets rendered.
refs #5525
2014-07-18 09:24:49 +02:00
47ae4d79dc
Forms do not need a special title property
...
As our upcoming wizard has no menu and our tabs are hardcoded we do not
need a special "title" property anymore.
refs #5525
2014-07-18 09:21:11 +02:00
1de2d0c14f
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Authentication/LoginForm.php
library/Icinga/Test/BaseTestCase.php
library/Icinga/Web/Form.php
library/Icinga/Web/Form/Decorator/BootstrapForm.php
2014-07-17 13:15:42 +02:00
bfc54b7e32
Fix array conversion of the Dashboard and its Components
...
Do not omit the parameters when converting the dashboard components to
an array. Add an array conversion to the UrlParams class.
refs #6691
2014-07-16 17:31:01 +02:00
5c507d5d91
Fix notice that the session has been already started after retrieving its id
2014-07-16 15:39:40 +02:00
Johannes Meyer
Alexander Fuhr
Thomas Gelf
Alexander Klimov
Marius Hein
Matthias Jentsch
Eric Lippmann
Matthias Jentsch
Goran Rakic