Alexander Klimov
9c5878cbbe
ConfigurationError: extend IcingaException
...
refs #6931
2014-08-22 11:46:11 +02:00
Alexander Fuhr
1886569174
Implement Module self provided configuration for menus
...
refs #6639
2014-08-22 11:35:42 +02:00
Johannes Meyer
bb7972aa39
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/controllers/AuthenticationController.php
application/controllers/ConfigController.php
application/forms/Authentication/LoginForm.php
application/forms/Preference/GeneralForm.php
modules/monitoring/application/controllers/ChartController.php
2014-08-20 13:13:50 +02:00
Eric Lippmann
995355ec30
lib/Limiter: fix translate w/ sprintf
2014-08-19 16:29:11 +02:00
Thomas Gelf
f49a34625e
Url\Params: check for QUERY_STRING before using it
...
fixes #6957
2014-08-19 14:53:56 +02:00
Thomas Gelf
db3ef8fbd0
ActionController: remove redirectToLogin default
...
The redirectOnLogin function now doesn't have any predefined default.
This also leads to the behaviour that "Logout" will not redirect you
anywhere on a new login while "forcibly being logged out" (e.g. by
logging out in another browser tab) will bring you back to where you
came from.
2014-08-19 12:28:24 +02:00
Thomas Gelf
9d4a4f49c9
ActionController: JS should redirect to __SELF__...
...
...once you lost your session. That's the only way to do this in a
smooth way. When the server get's an unauthenticated request for a
single container, redirecting to auth/login?redir=<that-container>
was not what you expect.
Together with JS handling __SELF__ in redirection URLs this will
play fine.
refs #6935
2014-08-19 09:57:24 +02:00
Thomas Gelf
b9cc964e24
Url\Params: remove() should reindex on change
...
There was a small bug, fixed.
refs #6699
2014-08-19 09:49:53 +02:00
Thomas Gelf
344909dfcd
Web\UrlParams: add() and set() should encode...
...
...while there is now a addEncoded function, mostly for internal use.
refs #6699
2014-08-19 09:45:58 +02:00
Thomas Gelf
217595dc15
Web/Url: more intuitive separator usage
...
One might not expect to get a URL with params separated by & while
this is the correct way of writing them to HTML attributes. So default
behaviour is right now that all functions return URL params separated
by &, but if you cast a URL (or it's params) to a string, & will be
used.
Additionally there are toString functions allowing you to choose the
separator "manually".
refs #6699
2014-08-19 09:42:16 +02:00
Thomas Gelf
7caccd7691
Web\Url: remove stripUrlFragment()
...
This function had an interesting history and seems to be a result of
missunderstanding of each others commits. Removed, as the fragment is
already there.
refs #6699
2014-08-19 09:36:15 +02:00
Johannes Meyer
f2ed813c9a
Fix that Icinga\Web\Url::fromPath drops fragments
...
fixes #6284
2014-08-14 14:23:31 +02:00
Johannes Meyer
666591beb7
Encode url before passing it to Icinga\Form\Dashboard\AddUrlForm
...
fixes #6611
2014-08-13 16:41:40 +02:00
Johannes Meyer
7311ab964e
Do not set the full url from the request as action with form parameters
...
Setting an url with parameters named like form elements in a form with
method POST causes Zend to ignore any POST data because GET will be
processed with higher priority.
fixes #6806
2014-08-13 14:50:21 +02:00
Johannes Meyer
e7da9c0a00
Make our anti CSRF logic being a form element
...
refs #5525
2014-08-12 14:43:10 +02:00
Johannes Meyer
fe63ce664f
Make use if 'ignore´ instead of explicitly unsetting array keys
...
refs #5525
2014-08-12 13:57:28 +02:00
Johannes Meyer
4b1169c0a1
Fix improper form submission
...
refs #5525
2014-08-12 10:41:19 +02:00
Thomas Gelf
8f729bfb65
ActionController: set a default window title
...
In case a controller action didn't set a view title this fix restores
the default title on XHR requests.
fixes #6797
2014-07-31 17:04:26 +02:00
Johannes Meyer
c3731fa79e
Adjust removeresource-action to suit the new resource form interface
...
refs #5525
2014-07-24 16:17:30 +02:00
Eric Lippmann
a68ccecb28
Revert "Do not use htmlspecialchars in widgets"
...
This reverts commit 2ff43abcf5
.
`Widget::escape()' does not exist. But `Widget::view()::espcae()' does.
2014-07-23 12:28:04 +02:00
Alexander Klimov
2ff43abcf5
Do not use htmlspecialchars in widgets
...
refs #6759
2014-07-23 12:12:05 +02:00
Johannes Meyer
8b2cc3a558
Do not consider <button type=submit> when checking form completion
...
refs #5525
2014-07-23 10:58:45 +02:00
Johannes Meyer
0bf0213547
Rename Form::addElement to Form::createElement
...
Since we are using mainly createElement and addElement is only an alias for
createElement if no object is passed our changes to addElement can safely
be moved to createElement.
refs #5525
2014-07-23 10:57:46 +02:00
Johannes Meyer
25c9ee567d
Add missing use statement for Zend_View_Abstract
2014-07-23 10:54:22 +02:00
Johannes Meyer
75e09f2c69
Do not consider submit buttons when checking form completion
...
refs #5525
2014-07-21 15:25:00 +02:00
Matthias Jentsch
091ddbe552
Partiall revert bfc54b7e
...
Refactor Url->getParams() to return an instance of UrlParam instead of an array.
fixes #6760
2014-07-21 09:22:19 +02:00
Johannes Meyer
f5ac592645
Do not consider disabled elements when checking form completion
...
Values of disabled inputs are not sent by browsers.
refs #5525
2014-07-21 08:57:41 +02:00
Johannes Meyer
f4ff2c90f2
It's a form's responsibility how its submit button should look like
...
refs #5525
2014-07-18 09:54:36 +02:00
Johannes Meyer
6ac471c598
Also mention the viewscript functionality of Form::loadDefaultDecorators()
...
refs #5525
2014-07-18 09:52:50 +02:00
Johannes Meyer
8f0b9899a3
We cannot know what kind of data is passed to Form::isValid()
...
refs #5525
2014-07-18 09:52:05 +02:00
Johannes Meyer
78a6175acc
Make form creation lazy and implement the new validation mechanism
...
Form creation must not depend on specific function calls. If a forms' elements are required and missing, create them. Form::isValid() must be
able to determine whether a form can be processed or not without to rely
on a particular button value.
refs #5525
2014-07-18 09:51:15 +02:00
Johannes Meyer
37fd3deb67
Rename initCsrfToken to addCsrfToken and move it upwards
...
Form::addCsrfToken() should be public and fluent to ensure more
flexibility.
refs #5525
2014-07-18 09:43:03 +02:00
Johannes Meyer
58188c5cc1
We only want to rely on Form::isValid() when about to process forms
...
As the new auto-submission implementation does not depend on whether
a submit button was pressed or not we need another way to determine
whether a form should be processed.
refs #5525
2014-07-18 09:33:09 +02:00
Johannes Meyer
802c095bf8
Configuration values need to be inserted to forms explicitly
...
It's the controllers' responsibility to ensure that forms are populated with
configuration values on GET requests.
refs #5525
2014-07-18 09:27:10 +02:00
Johannes Meyer
21cd503ee7
Form buttons need to be added explicitly
...
We either demand the user to add a submit button or provide a implicit
function call to be implemented by him, adding additional elements once
the form gets rendered.
refs #5525
2014-07-18 09:24:49 +02:00
Johannes Meyer
47ae4d79dc
Forms do not need a special title property
...
As our upcoming wizard has no menu and our tabs are hardcoded we do not
need a special "title" property anymore.
refs #5525
2014-07-18 09:21:11 +02:00
Johannes Meyer
1de2d0c14f
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Authentication/LoginForm.php
library/Icinga/Test/BaseTestCase.php
library/Icinga/Web/Form.php
library/Icinga/Web/Form/Decorator/BootstrapForm.php
2014-07-17 13:15:42 +02:00
Matthias Jentsch
bfc54b7e32
Fix array conversion of the Dashboard and its Components
...
Do not omit the parameters when converting the dashboard components to
an array. Add an array conversion to the UrlParams class.
refs #6691
2014-07-16 17:31:01 +02:00
Johannes Meyer
5c507d5d91
Fix notice that the session has been already started after retrieving its id
2014-07-16 15:39:40 +02:00
Johannes Meyer
e6dee9fe89
Protect login against CSRF
...
refs #5626
2014-07-16 09:55:23 +02:00
Johannes Meyer
19f05256a0
Only call session_start() when reading from session
...
fixes #6383
2014-07-16 09:55:22 +02:00
Johannes Meyer
3105c2059e
Remove license headers from all files
...
refs #6309
2014-07-15 13:43:52 +02:00
Johannes Meyer
e567ad67c5
Display statehistory summary vertically
...
fixes #6636
2014-07-14 15:26:35 +02:00
Johannes Meyer
0dce204651
Refactor Icinga\Web\Form
...
We eagerly waited badly for a new approach to build forms, so here it is.
Should be the best compromise between the Zend_Form functionality and
our requirements regarding automatic submits.
refs #5525
2014-07-10 11:13:45 +02:00
Johannes Meyer
1a1263d9d8
Rename Icinga\Web\Form\Decorator\BootstrapForm
...
We do not use bootstrap anymore but do not want the default Zend
decorators either so this decorator got a more common name.
refs #5525
2014-07-10 11:09:48 +02:00
Thomas Gelf
49c679fe0f
FilterEditor: hide "add" links
...
They where there to show how this should look like. Removed for now as
they are not implemented yet.
refs #6668
2014-07-08 17:21:36 +02:00
Johannes Meyer
bb2c85f90b
Remove forgotten ActionController::requiresConfig() call
...
Should have been reverted by last commit but was not.
2014-07-07 16:12:26 +02:00
Johannes Meyer
82d2f5ac9b
Revert "Merge branch 'feature/install-wizard-6136'"
...
This reverts commit 88d4262e7c
, reversing
changes made to 6fae333048
.
Conflicts:
application/controllers/InstallController.php
library/Icinga/Web/Controller/ActionController.php
2014-07-07 15:09:03 +02:00
Thomas Gelf
0d4166b1bd
ModuleActionController: fix reference, var removed
2014-07-04 12:39:23 +02:00
Thomas Gelf
3cfdf4c977
Web\Response: add redirection function
...
The response now provides redirectAndExit(). One more step to clean up
our action controller. Please not that this is still unused right now.
2014-07-04 12:35:33 +02:00
Thomas Gelf
3772b9c16f
ActionController: set layout module name early
...
Didn't work correctly before
2014-07-04 12:33:49 +02:00
Johannes Meyer
143a1e44fe
Add a HTML renderer for Icinga\Web\Menu
...
The menu was being rendered through recursive partials before. The
overhead this fact implicates is not as efficient as standard recursion
so there is now a special renderer for Icinga\Web\Menu utilizing
the RecursiveIteratorIterator
refs #6153
2014-07-03 15:46:46 +02:00
Johannes Meyer
be18af7e7e
Merge Icinga\Web\MenuItem into Icinga\Web\Menu
...
We do not need an additional class for the menu's root item just to
encapsulate our config handling, so these two classes were now merged
into a single one. Icinga\Web\Menu now also extends from
RecursiveIterator to be able to render the menu more efficient to html.
refs #6153
2014-07-03 15:14:47 +02:00
Johannes Meyer
7eb0f3c472
Remove @codingStandardsIgnoreStart/-Stop annotations
...
refs #6091
2014-06-30 13:59:58 +02:00
Johannes Meyer
f2e5d8afa5
Remove @codeCoverageIgnoreStart/-Stop annotations
...
refs #6091
2014-06-30 13:58:37 +02:00
Thomas Gelf
62928c48b0
helpers/timeSince: fix c&p error
2014-06-27 23:37:39 +02:00
Thomas Gelf
7112ed23f4
Chart\InlinePie: locale-ignorant cast for floats
...
This has already been fixed with 92f454c3
and got broken again with be0c5d4b
.
Time for a regression test I guess.
refs #6348
2014-06-25 22:13:19 +02:00
Thomas Gelf
10d1520711
Widget\Limiter: show "all"
...
In case we pass limit=0 we show this, still unsure whether we should
provide a link for "showing all" - might really hurt with millions of
history rows.
2014-06-25 20:39:10 +02:00
Thomas Gelf
59dd80ed32
ActionController: benchmark should measure rendering
...
We have been cheating a little bit, now the measurement should be more
precise.
2014-06-25 20:37:17 +02:00
Matthias Jentsch
d49f30ff77
Improve InlinePie performance
...
Use str_replace instead of preg_replace
2014-06-25 15:24:53 +02:00
Matthias Jentsch
7b19bd1d99
Improve interface of InlinePie
...
Method setLabel can also accept a simple string and title is mandatory in constructor
2014-06-25 15:21:12 +02:00
Matthias Jentsch
8839166090
Add number format 'none' to InlinePie
2014-06-25 14:53:39 +02:00
Matthias Jentsch
35a5431512
Revert "Refractor InlinePie and Perfdata helper"
...
This reverts commit f003c38abd
.
2014-06-25 14:29:17 +02:00
Matthias Jentsch
f003c38abd
Refractor InlinePie and Perfdata helper
...
Refractor InlinePie methods for better usability, fix several coding guideline
issues and fix some typos
2014-06-25 12:41:17 +02:00
Thomas Gelf
4591297e56
SortBox: use POST instead of GET
...
This avoids trouble with complex filter URLs
fixes #6556
2014-06-25 11:00:10 +02:00
Thomas Gelf
1dcf44b9cd
FilterEditor: fix buggy dropdown boxes
...
There were some issues with option names. Also cleaned up HTML a
little bit and added autosubmission.
2014-06-25 10:37:06 +02:00
Thomas Gelf
b40d0f6a1e
FilterWidget: POST instead of GET
...
Might have been a JS issue, but instead of messing with the URL just
POSTing is easier here - and works. Filters from the search box are
now added flawlessly to the filter tree.
2014-06-25 10:34:09 +02:00
Thomas Gelf
2746b5ff9f
ConfigController: switch over to new config tabs
...
Module configuration now takes place in module detail view and does no
longer pollute our config tabs. Modules are now able to provide a bunch
of own config tabs, we don't really care what they use them for.
2014-06-24 21:31:59 +02:00
Thomas Gelf
b38bcfc19b
Widget\FilterEditor: correct expression output
...
Filter expressions should be filled into form fields exactly as we
expect them at parse time.
fixes #6568
2014-06-24 21:00:01 +02:00
Thomas Gelf
47b893e1ea
Widget\FilterEditor: handle custom vars
...
There was an issue with custom vars as they made only partially part
of the column dropdown. Sorted columns and tried to beautify column
names.
fixes #6569
2014-06-24 20:57:41 +02:00
Thomas Gelf
3f9f4bb9e1
ModuleActionController: module object shortcut
...
This helps modules with the need to know more about themselves. No
more App -> Module Manager -> Module voodoo.
2014-06-24 20:54:39 +02:00
Thomas Gelf
b7b99cfd67
Widget\AlertMessageBox: fix broken widget
...
This widget is pretty useless as the error view script can to it's
job. Interestingly nobody missed it, even the render() call was wrong.
I guess we will remove this soon, but for now it's fixed. Looks ugly,
but works.
2014-06-24 20:30:41 +02:00
Thomas Gelf
ba9a633b73
Web\Form: relax form submission check
...
We have to live with some badly designed forms right now. Some have
submit buttons but don't know about, others don't have such but link
to foreign controllers fiddling with the form and adding different
button AFTER the form got submitted - it's a mess.
Relaxing the submission check to "just check whether btn_submit has
a value" fixes most of this. However I do not consider this being a
solution for the long run.
fixes #6423
fixes #5967
refs #6540
2014-06-23 13:31:34 +02:00
Thomas Gelf
ea44de8698
ActionController/translate: detect domain only once
2014-06-22 20:09:23 +02:00
Thomas Gelf
23ed744747
params/_render: replace it everywhere
...
Cleaning up controllers and JS, using headers only and respecting
history.
2014-06-22 20:07:44 +02:00
Thomas Gelf
61600ae2d4
ModuleActionController: fix typo
2014-06-22 19:39:54 +02:00
Thomas Gelf
997587d729
Chart\InlinePie: remove ugly default border
2014-06-22 16:38:12 +02:00
Thomas Gelf
216f0f3f55
isIframe: clean up, load less html and js
...
We use isIframe only when we have no JS, therefore it makes no sense
to load JS files in an iFrame. Also removed sidebar.
2014-06-22 16:30:06 +02:00
Thomas Gelf
3b84078b2f
Params/_render: get rid of it, start with iframe
2014-06-22 16:18:23 +02:00
Thomas Gelf
bb23d0636c
ModuleActionController: use isXhr()
2014-06-22 16:04:55 +02:00
Thomas Gelf
3774eb6889
ActionController: add isXhr() method
...
Makes things easier as we use this a lot
2014-06-22 15:36:41 +02:00
Thomas Gelf
331d756a2a
ActionController: isolate ignoreXhrBody
...
This function is only a workaround for broken forms not redirecting
after submission. Will hopefully be removed soon.
2014-06-22 15:33:38 +02:00
Thomas Gelf
b4f8ef74fa
ActionController: remove obsolete code
2014-06-22 15:20:55 +02:00
Thomas Gelf
631603aba3
ActionController: create postDispatchXhr
...
Moved XHR-specific stuff to a dedicated post-dispatch function
2014-06-22 15:17:28 +02:00
Thomas Gelf
cf995b366b
ActionController: cleanup postDispatch
...
Make XHR handling more readable, move module-related stuff to the
module controller
2014-06-22 15:11:08 +02:00
Thomas Gelf
de19745eb2
ActionController: move moduleInit to Module controller
2014-06-22 13:54:02 +02:00
Thomas Gelf
2cd25b7376
ActionController: if/else should be easy to read
2014-06-22 13:52:40 +02:00
Thomas Gelf
b7fc0b67a8
Web/controllers: use own Request/Response objects
...
* introduces Icinga\Web\Response
* uses ModuleActionController where necessary
* no module translationDomain voodoo in base ActionController
2014-06-22 13:49:21 +02:00
Thomas Gelf
ef5e1b54fd
Web\Window: fix it's usage, add helper function
...
Improved window handling, fixed controllers using it.
2014-06-22 13:21:21 +02:00
Thomas Gelf
b350e3640d
Web\Window: move window handle to dedicated class
...
One more step in cleaning up our ActionController
2014-06-22 13:01:48 +02:00
Thomas Gelf
d69a6d1640
ActionController: remove getRequestUrl
...
Thie removes complexity and makes redirection to login less error-
prone.
2014-06-22 12:23:34 +02:00
Thomas Gelf
9608d8254d
ActionController: remove addModuleContainer
...
This method was obsolete
2014-06-22 12:09:07 +02:00
Thomas Gelf
4980b700da
ActionController: __construct() as first function
2014-06-22 12:07:50 +02:00
Thomas Gelf
a4955df1a9
controller->Auth(): one more lazy-loading helper
...
Not sure about the capital A, but doesn't look so bad - and similar
to Config().
2014-06-22 12:06:09 +02:00
Thomas Gelf
373e1c5ecb
Web\Controller: re-introduce ModuleActionController
...
This will help getting rid of a couple of if/else constructs
2014-06-22 12:03:37 +02:00
Thomas Gelf
469eb3dc98
Web\Url: remove forgotten "debug" line
2014-06-22 11:59:24 +02:00
Thomas Gelf
b3cdeee35d
monitoring/timeline: should benefit from new filter
...
Different changes have been applied:
* Allow integer unix timestamps as parameters for timestamp columns
* Remove alias-rewriting from Url class
* Remove all traces of raw_timestamp
* Use new filters
2014-06-21 03:09:40 +02:00
Thomas Gelf
216c2ca770
Autorefresh: should work also on initial page load
...
fixes #6296
2014-06-21 01:54:32 +02:00
Thomas Gelf
c0c7a815f8
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
2014-06-20 19:18:38 +02:00
Thomas Gelf
3e24a2cbe4
Paginator/SlidingWithBorder: use less space
...
Showing less items right now. It would be great if we could steer
this by parameter. IMO we should also think about dropping ZF
pagination and use a custom tiny widget.
2014-06-20 17:31:32 +02:00
Thomas Gelf
afd6b11b7b
Web\Url: add set/mergeValues support
2014-06-20 15:50:55 +02:00
Thomas Gelf
2cf79fe9a7
Widget\SortBox: hardcode some styles
...
This is a quickfix, should be moved to CSS once we know how our HTML
elements will definitively look like
2014-06-20 14:55:43 +02:00
Thomas Gelf
916c9c027e
forms: fix isSubmitted
...
Implementation made wrong assumptions. A form is submitted when the
submit button has been pressed. It's value is then filled, it also
is when you're just pressing "RETURN". RETURN triggers the FIRST
submit button in a form. This way we are also able to find out which
form button has been pressed.
Current implementation is still poor, however isSubmitted works as
expected right now - and so does autosubmission.
fixes #5967
2014-06-20 14:32:22 +02:00
Thomas Gelf
01631720cc
Dashboard\Component: don't pass on limit
...
Dashlets might be limited to just a few line, we shoultn't pass on
this parameters when showing the "large" variant
2014-06-20 14:29:45 +02:00
Thomas Gelf
ac7354295a
Accessibiltiy: add alt tag for icons
...
Screen readers to not read title tags per default
2014-06-20 14:28:19 +02:00
Thomas Gelf
27e7839d1b
Widget\Limiter: initial commit
...
This allows one to easily switch row count shown on a single page
2014-06-20 13:48:17 +02:00
Thomas Gelf
07134cf931
JS/XHR: handle multiple notifications
...
As there seems to be problems with sending the same header multiple
times we put multiple notifications in one header.
2014-06-20 13:20:20 +02:00
Thomas Gelf
617741c62f
helpers/widget: options are opional
2014-06-20 13:18:52 +02:00
Thomas Gelf
dbf03ee647
ActionController: refine url handling on redirect
2014-06-20 13:18:03 +02:00
Thomas Gelf
7cad4de3be
ActionController: allow to disable autorefresh
2014-06-20 13:17:11 +02:00
Thomas Gelf
f498cd0c81
Web\Url: small fixes, allow override queryString
2014-06-20 12:41:16 +02:00
Thomas Gelf
d504c27641
timeUntil/timeSince: add timestamp hover title
...
It's sometimes easier to read "full" timestamps.
2014-06-20 12:28:55 +02:00
Thomas Gelf
317094aed3
Widget\FilterWidget: ui cleanup
2014-06-20 12:16:33 +02:00
Thomas Gelf
644dd5e33e
Widget\FilterEditor: improve the filter editor
...
This adds quite a bunch of changes. Part of the filter-modifying
complexity has been moved to the filter, the editor widget itself
now makes use of new filter capabilities such as changing operator
or expression type.
2014-06-20 12:03:22 +02:00
Matthias Jentsch
aae49ce0c0
Do not show tooltips for piechart areas that indicate empty or free areas
...
refs #6117
2014-06-18 17:38:25 +02:00
Matthias Jentsch
6555d347a7
Escape InlinePie html and adjust chart size
...
fixes #6117
2014-06-18 14:43:14 +02:00
Matthias Jentsch
be0c5d4b23
Add more meaningful tooltip labels to InlinePies
...
Show current title, a well-formated value and a label for each area in a
tooltip and add the ability to customize tooltip labels of InlinePies
refs #6117
2014-06-18 14:43:14 +02:00
Thomas Gelf
21febddad2
Widget\Filter*: rudimentary filter widgets
...
Initial implementation, more to come
2014-06-17 14:00:38 +00:00
Thomas Gelf
54e97f114d
Widget\SortBox: hardcode element width
...
Temporarily added inline CSS, shall be removed soon
2014-06-17 13:54:32 +00:00
Thomas Gelf
d63d8fe451
view/helpers: add $this->widget()
2014-06-17 13:53:05 +00:00
Thomas Gelf
e3e6826d9d
Icinga\Filter: remove
2014-06-17 13:26:57 +00:00
Thomas Gelf
992a8a276b
Web/ActionController: provide $this->params
...
We always need params, this are our new URL params made accessible
this way. This is just for our query string, not for POST body params.
2014-06-17 12:58:04 +00:00
Thomas Gelf
468b290277
Monitoring\Controller: provide $this->backend
...
Every monitoring controller needs $backend, so why declaring it over
and over again. Created "moduleInit" dummy function in our base action
controller to allow such implementations without polluting init().
2014-06-17 12:55:43 +00:00
Thomas Gelf
5ea9b2be84
Web\Url: make use of the new UrlParams class
...
This makes a lot of things easier while trying to preserve compatibililty.
However, a few things like aliases are marked for removal (TODO).
2014-06-17 10:07:19 +00:00
Thomas Gelf
de5bb56fb3
Web\UrlParams: new implementation
...
The URL query string parsing done by PHP/ZF doesn't suffice our needs.
This is an implementation preserving filter-related "strange" query
string components while still offering legacy behaviour.
Missing right now: support for [].
2014-06-17 10:00:49 +00:00
Thomas Gelf
44a7aa6adb
JS/IE8: deliver legacy jQuery for IE8
...
This patch makes IcingaWeb deliver a legacy jQuery version for IE8
as it is no longer supported in jQuery 2.x. JS for IE8 will not be
delivered minified to ease troubleshooting on that buggy platform.
fixes #5866
refs #6417
2014-06-12 17:33:28 +00:00
Johannes Meyer
159d765f14
Fix that calling ActionController::translate() throws an exception
...
Translating strings must not throw an exception
even if the given domain is not valid.
fixes #6432
2014-06-11 13:39:22 +02:00
Marius Hein
06296f29d8
UI/Sparklines: Change sparkline code to serverside only
...
fixes #6124
2014-06-06 16:35:33 +02:00
Thomas Gelf
e01629fe0b
ActionController: fix initial redirect
...
refs #6419
2014-06-06 08:32:21 +00:00
Marius Hein
20b43a92f1
Dashboard: Better implementation of handling errors
...
refs #6412
2014-06-05 16:07:40 +02:00
Marius Hein
151f058286
Dashboard: Display error message on failure
...
When no (default) configuration is available for dashboards
application dies not very gracefully. Display error message
and guid the user to the solution is a better way.
fixes #6412
2014-06-05 15:20:54 +02:00
Thomas Gelf
1b3bb6cade
Web\Url: add getQueryString() and without()
2014-06-05 03:44:12 +00:00
Thomas Gelf
99aae5a0d9
JS/XHR: get ready to get XHR redirect-aware
...
These are just the first steps, there is more to come
2014-06-05 03:37:36 +00:00
Thomas Gelf
c592236258
vendorlibs: library/vendor to libary/IcingaVendor
...
This doesn't make it much better but allows to build a package
libicinga-vendor-php placing those files to /usr/share/php/IcingaVendor
or similar.
refs #4075
2014-06-05 00:10:49 +00:00
Marius Hein
79fb8b1e0d
Config: Remove base path subsitution
...
Test for leading slash and prepend base path to allow
absolute configuration files.
fixes #5556
2014-06-02 14:54:31 +02:00
Eric Lippmann
a379502b15
Preferences: Rename `showBenchmark' to `show_benchmark'
...
We use underscore_case notation for all configuration keys.
refs #4952
2014-06-02 13:33:55 +02:00
Gunnar Beutner
5cc69b53cf
Remove superfluous space in prefixedTimeSince
...
refs #5981
2014-05-29 13:11:01 +02:00
Gunnar Beutner
a66a1a4729
Refactor the timeSincePrefix and timeUntilPrefix functions
...
Instead of having two separate functions to get the prefix
and the formatted time interval the new functions return
both the prefix and the time interval.
refs #5981
2014-05-29 13:03:10 +02:00
Gunnar Beutner
7b0a48bef5
Rename timeUnless to timeUntil
...
refs #5981
2014-05-29 12:38:59 +02:00
Gunnar Beutner
d01a98b7e6
Fix some of the time-related grammar mistakes
...
This updates some of the messages to use "For"
instead of "Since" where appropriate.
fixes #5981
2014-05-29 11:30:08 +02:00
Thomas Gelf
88460189cd
Encoding: no ASCII chars > 127 in HTTP headers
...
Had quite some trouble with this, decided to URL-encode titles and
notifications.
2014-05-28 21:34:36 +00:00
Thomas Gelf
92f454c36d
Chart\InlinePie: locale-ignorant casts for floats
...
PHP respects locales (LC_NUMERIC) when casting floats to string. That
affected the generated HTML for our inline pie charts. This patch is
not that beautiful - but fixes this.
fixes #6348
2014-05-28 10:20:34 +00:00
Thomas Gelf
360ac87550
Translation: add a module-aware translation helper
...
With this fix $this->translate works in our view scripts
refs #6338
2014-05-27 21:41:46 +00:00
Thomas Gelf
70ba36aad6
notifications: improve client- and serverside
...
This is just a first step, trying to catch a few gotchas:
* it doesn't send notifications to the browser when issueing a redirect
as redirects can currently not be catched in jQuery response handlers
* it tries to find a better notification handling place in the response
handler (JS) - still imperfect
* it explicitely stores sessions once modified by notifications. Still
need to crosscheck whether this is really needed and how we can get
rid of this.
refs #6280
2014-05-26 14:41:47 +00:00
Thomas Gelf
4e88a4e008
Web\Url: add a shift() method
...
This methods allows to retrieve an URL param while removing it from the
URL object
2014-05-20 13:49:35 +00:00
Thomas Gelf
b447225512
Web\Form: Revert "Fix subForm functionality"
...
This reverts commit 51bac035ac
.
The div element introduced by this commit breaks inline form layout
2014-05-20 13:10:18 +00:00
Johannes Meyer
ef7bb0e794
It is a multistep page's responsibility whether it is shown to the user
...
refs #6136
2014-05-14 12:53:45 +02:00
Johannes Meyer
754f854dd0
Multistep pages should know about their multistep form
...
refs #6136
2014-05-14 12:53:45 +02:00
Johannes Meyer
1f942acd38
Fix multistep page creation
...
refs #6136
2014-05-14 12:53:45 +02:00
Johannes Meyer
33d4142664
Make it possible to recreate a form
2014-05-14 12:53:44 +02:00
Johannes Meyer
1637a19c23
Fix multistep form creation
...
refs #6136
2014-05-14 12:53:44 +02:00
Johannes Meyer
429e09aae2
Multistep pages should not have random generated names
...
refs #6136
2014-05-14 12:53:44 +02:00
Johannes Meyer
51bac035ac
Fix subForm functionality
2014-05-14 12:53:44 +02:00
Johannes Meyer
de169c7bf5
Make it possible to disable form submit buttons forcefully
2014-05-14 12:53:44 +02:00
Johannes Meyer
88e451402f
Redirect to /install when the setup.token exists but no config.ini
...
refs #6136
2014-05-14 12:53:44 +02:00
Johannes Meyer
4cf5fe6fdd
Add multistep form
...
refs #6136
2014-05-14 12:53:44 +02:00
Johannes Meyer
e1230eb8ae
Add style and view scripts for first prototype
...
refs #6136
2014-05-14 12:53:44 +02:00
Matthias Jentsch
d0c56126b8
Fix inline pie reload.
...
refs #6124
2014-05-07 17:03:27 +02:00
Thomas Gelf
270181885c
Fix Url error for emty baseUrl, less function calls
2014-04-29 12:27:19 +00:00
Johannes Meyer
e2ba172a8e
Make dashboard components using the ini writer class
...
fixes #5524
2014-04-29 11:30:53 +02:00
Johannes Meyer
98ca15d1fb
Mark less important or non-testable code as skipped for code coverage
...
refs #6011
2014-04-28 14:06:41 +02:00
Johannes Meyer
07da92ee42
Rewrite test for Icinga\Web\Url and fix some bugs
...
refs #6011
2014-04-28 14:06:40 +02:00
Johannes Meyer
729c33c3cf
Add helpful documentation to Icinga\Web\ViewStream
2014-04-28 14:06:40 +02:00
Johannes Meyer
c5c375e72d
Add test for Icinga\Web\MenuItem
...
refs #6011
2014-04-28 14:06:40 +02:00
Johannes Meyer
290fe9eeb5
Rewrite test for Icinga\Web\Hook
...
refs #6011
2014-04-28 14:06:40 +02:00
Johannes Meyer
2b15d35dec
Rewrite test for Icinga\Web\Form
...
refs #6011
2014-04-28 14:06:40 +02:00
Johannes Meyer
21b949758f
Refactor ResourceForm tests
...
refs #6011
2014-04-28 14:06:38 +02:00
Matthias Jentsch
b16c6efa05
Add PieChart to display hosts and services, improve layout and fix flag
...
checkboxes
refs #5765
2014-04-28 09:48:06 +02:00
Matthias Jentsch
081b5072a6
Fix layout of MultiController views
...
refs #5765
2014-04-28 09:48:06 +02:00
Thomas Gelf
d939e12ef9
Only XHR requests use the "inline" layout
2014-04-17 17:03:35 +00:00
Thomas Gelf
83b26bc595
JS-less iFrame rendering improvements
2014-04-17 16:20:03 +00:00
Johannes Meyer
4c8428423e
Convert existing mocks to Mockery-mocks (Part 1)
...
refs #4639
2014-04-11 17:03:45 +02:00
Johannes Meyer
6056327c6d
Fix that it's not possible to set non-existing values in a session with setAll()
...
refs #4639
2014-04-09 16:18:51 +02:00
Johannes Meyer
a1649a1f22
Refactor PreferencesStore and IniStore
...
refs #5682
2014-04-07 15:13:28 +02:00
Thomas Gelf
a857af60be
Intendation
2014-04-07 12:03:53 +00:00
Thomas Gelf
88cdf99934
More code style
2014-04-07 12:03:53 +00:00
Johannes Meyer
d109046bc0
Fix that the general and logging form cannot write configuration changes
...
fixes #5952
2014-04-07 09:27:37 +02:00
Johannes Meyer
8be3ccc527
Make it possible to save the session by its associated session namespaces
2014-04-04 11:13:07 +02:00
Johannes Meyer
98b640f1e0
Fix that removed values/namespaces remain in the session storage
...
fixes #5934
2014-04-04 11:10:45 +02:00
Johannes Meyer
21b9c1f4af
Fix that filters are not preserved on timeline element urls
...
refs #4190
2014-04-01 14:26:10 +02:00
Johannes Meyer
3d658a664c
Do not use logarithm base from session if the timeline is not being extended
...
refs #4190
2014-04-01 11:46:43 +02:00
Johannes Meyer
b0709d8cba
Revert postDispatch -> preDispatch change in ActionController
...
refs #4190
2014-04-01 11:44:25 +02:00
Johannes Meyer
aade2ab7f6
Move timeline classes into the monitoring module
...
refs #4190
2014-04-01 11:44:24 +02:00
Johannes Meyer
0a146b4bb4
Clientside scrolling implementation [WIP]
...
refs #4190
2014-04-01 11:44:24 +02:00
Johannes Meyer
40f70eb572
Fix license header
...
refs #4190
2014-04-01 11:44:24 +02:00
Johannes Meyer
ba541b402d
Add timeline helper classes
...
#refs 4190
2014-04-01 11:44:23 +02:00
Thomas Gelf
056b8d5395
Coding style
2014-03-31 16:30:27 +00:00
Matthias Jentsch
d3c4660c2d
Fix colors of svg charts in Firefox
2014-03-31 12:35:39 +02:00
Thomas Gelf
5c89512e05
New router needs JavaScript and Stylesheet handlers fitting it's needs
2014-03-27 07:32:02 +00:00
Matthias Jentsch
2360f21b09
Fix InlinePie boundaries and use floats for the PieSlice path coordinates
...
Use floats as path coordinates in PieSlices, to
avoid that the start and ending position of the arc are at the exact same
position. This would cause buggy behavior, when displaying values like "99,999%".
refs #5863
2014-03-26 17:06:21 +01:00
Matthias Jentsch
15723f088b
Include SVG piecharts in perfData helpers
...
When no JavaScript is available, SVG piecharts will be shown instead of the
jQuery sparklines.
fixes #5865
2014-03-26 14:56:35 +01:00
Thomas Gelf
faec625912
Ship module JS files even with minified JS
2014-03-26 09:24:27 +00:00
Thomas Gelf
eeaec20873
Add support for server-side triggered CSS reload
2014-03-26 07:58:00 +00:00
Thomas Gelf
87f90b6bdd
Replace escaped ampersands in URLs with & for redirects
...
* NB: Icinga\Web\Url could provide a method for this
2014-03-26 07:56:30 +00:00
Johannes Meyer
18b825a24b
Add missing keyword "new" in class SessionNamespace
2014-03-25 13:24:06 +01:00
Johannes Meyer
f802b36ca9
Move session class files
2014-03-25 11:13:10 +01:00
Johannes Meyer
9ab53558f0
Add helper to get window-aware session namespaces
2014-03-25 11:13:10 +01:00
Thomas Gelf
9c5eb19af6
Re-add potentially obsolete dynamic Widget properties
2014-03-25 07:23:14 +00:00
Thomas Gelf
01f94c574d
Handle window-id requests, allowing us to identify distinct windows
2014-03-21 13:27:44 +00:00
Thomas Gelf
3059228378
Fix JS support for modules
2014-03-20 09:55:29 +00:00