Commit Graph

5585 Commits

Author SHA1 Message Date
Johannes Meyer 5c371a6d0b Fix form tests 2015-03-04 09:43:37 +01:00
Johannes Meyer ff263946c8 Form: Fix translation domain detection while running unit tests 2015-03-04 09:38:00 +01:00
Johannes Meyer 6e61980dd2 Fix operator precedence when detecting the default locale
fixes #8370
2015-03-04 08:28:30 +01:00
Johannes Meyer e2887df03e Form: It's a field, not a control 2015-03-03 15:01:09 +01:00
Johannes Meyer 507e5b43cc Show a form based autosubmit warning when toggling object features
refs #7935
2015-03-03 14:52:45 +01:00
Johannes Meyer 8510835fba Fix accessibility of the Autosubmit decorator when applied to a form
refs #7935
2015-03-03 14:35:46 +01:00
Johannes Meyer c2339d156b Improve aria-hidden handling in the icon and img view helper 2015-03-03 14:35:41 +01:00
Johannes Meyer d9fdcf036b Show a form based autosubmit warning when toggling instance features
refs #7935
2015-03-03 14:34:08 +01:00
Johannes Meyer 747e51553e Allow the Autosubmit decorator being used on forms as well
refs #7935
2015-03-03 13:33:26 +01:00
Johannes Meyer dcf38cbf73 Fix form id of the authentication configuration 2015-03-03 09:54:12 +01:00
Johannes Meyer 642fa44fce Move a form's title into the markup of its form 2015-03-03 09:53:25 +01:00
Johannes Meyer f7785ee04a Fix that the DashletForm handles the autosubmit manually 2015-03-03 08:24:23 +01:00
Johannes Meyer 53e73161d8 Fix that the AcknowledgeCommandForm is opened in a new column 2015-03-02 18:45:38 +01:00
Johannes Meyer b9ac42b54d Drop CommandForm::getHelp() as being obsolete 2015-03-02 18:40:47 +01:00
Johannes Meyer a2f88dc60f Commands: Use native form title and description support where appropriate
refs #7947
refs #7976
2015-03-02 18:40:47 +01:00
Johannes Meyer 4ba281e7e8 Config: Use native form title and description support where appropriate
refs #7947
refs #7976
2015-03-02 18:40:47 +01:00
Johannes Meyer 2af83e7d72 Installation: Use native form title and description support where appropriate
refs #7947
refs #7976
2015-03-02 18:40:47 +01:00
Johannes Meyer d3f9bd633c Installation: Hide the required cue when choosing the preference backend
refs #7934
2015-03-02 18:40:46 +01:00
Johannes Meyer ea7b77eb72 Remove the required cue when disabling notifications globally
refs #7934
2015-03-02 18:40:46 +01:00
Johannes Meyer d714c4323c Installation: Remove required cue from the token input
refs #7934
2015-03-02 18:40:46 +01:00
Johannes Meyer 4d2bd75a38 Installation: Fix ugly checkbox positioning when selecting modules 2015-03-02 18:40:46 +01:00
Johannes Meyer b1d0c12df3 Form: Introduce setTitle() as alias for Zend_Form::setDescription() 2015-03-02 18:40:46 +01:00
Johannes Meyer ad288c08ca Form: Add the Description decorator by default for native title support 2015-03-02 18:40:46 +01:00
Johannes Meyer cbd061aa41 Fix that the FormDescriptions decorator does not ignore Notes and Buttons 2015-03-02 18:40:46 +01:00
Johannes Meyer e9bae08a6e Fix that one can't advance the wizard when skipping the ldap discovery
fixes #8506
2015-03-02 18:40:46 +01:00
Johannes Meyer 65eafc0e8f LdapDiscoveryForm: Remove waste 2015-03-02 18:40:46 +01:00
Matthias Jentsch 92a15a6ee4 Fix badge css
Nav element added for accesssibility destroyed the badge CSS. Make badge CSS more robust against inserted elements.
2015-03-02 18:26:33 +01:00
Johannes Meyer 1eacaa4c48 Improve the display of the text cue on required form elements
Shows just a message at the top of the form if all elements are required
and a explaining message what the cue is standing for otherwise.

refs #7934
2015-03-02 13:48:35 +01:00
Johannes Meyer 1a334f8d64 Add decorator FormDescriptions
This decorator displays a list of messages at the top of a form.

refs #7947
2015-03-02 13:45:24 +01:00
Matthias Jentsch 0f3c27f812 Fix event grid for dashboard 2015-03-02 12:27:27 +01:00
Matthias Jentsch e4f71eacd6 Add unit tests for ldap connection behavior
It is important that we test handling of protocol extensions properly, to prohibit errors that are difficult to reproduce like this in the future.

fixes #7993
2015-02-27 17:11:12 +01:00
Matthias Jentsch 36d2d31035 Do not use page control unless explicitly announced
refs #8490
2015-02-27 17:10:55 +01:00
Matthias Jentsch 65821863fa Don't crash on single ldap capability entries
refs #8490
2015-02-27 17:10:21 +01:00
Matthias Jentsch e93a5f16d9 Move capability-related code of the ldap connection into a separate class
Achieve a better separation between the different concerns, more readable code and get rid of unused dead code.
2015-02-27 17:10:21 +01:00
Johannes Meyer 7bb78330a9 Replace cancel icon with the trash icon...
...where the link's purpose is to remove something
2015-02-27 14:47:46 +01:00
Johannes Meyer 74dfa6e72a Fix invalid icon names passed to the icon view helper 2015-02-27 14:45:47 +01:00
Johannes Meyer 96c132908d Provide a warning on autosubmit form elements and a title for the apply btn
resolves #7935
2015-02-27 13:09:13 +01:00
Johannes Meyer 4f0bddd7da Do not add aria-label to icons and images with titles if aria-hidden is set 2015-02-27 12:12:24 +01:00
Johannes Meyer f2259557c8 Fix missing tab labels
fixes #8518
2015-02-27 09:32:44 +01:00
Johannes Meyer 82017da85f Help: Do not protect form element ids twice 2015-02-27 09:20:15 +01:00
Johannes Meyer ea4de82545 Login: Disable the required cue
It should be obvious that it is necessary to input a name and a password
to login in case you're looking at a "login" form...

refs #7934
2015-02-27 09:09:25 +01:00
Johannes Meyer c00e336ea8 Make the cue that is being appended to required form elements configurable
refs #7934
2015-02-27 09:08:05 +01:00
Johannes Meyer 48c3199a2d Form: Fix id protection
Altering element ids upon rendering makes it impossible to reference
them elsewhere. Zend_Form::getId() should be preferred over getName()
as it falls automatically back to getName() in case there is no id attribute
set. Setter are required to return their instance. Overwriting methods
without calling the parent (getId) without any valid (or at least
documented) reason is very bad practice.

refs #8460
2015-02-27 09:01:46 +01:00
Johannes Meyer 6d81a194ab Make form element descriptions accessible
Re-added the Help decorator to make sure an element's description
is being added in an accessible way.
2015-02-27 08:10:25 +01:00
Johannes Meyer 0111fdf78e Add an asterisk suffix to a form element's label if its required
The screen reader part "(required)" is not being considered with this
commit as most screen readers do not need this due to the ARIA and
HTML5 property.

resolves #7934
2015-02-26 16:05:13 +01:00
Johannes Meyer 4351603243 Fix that editing an auth backend does not open the next column 2015-02-26 14:48:37 +01:00
Matthias Jentsch bc950a855d Surpress warnings when ldap page control is not available 2015-02-25 18:39:03 +01:00
Matthias Jentsch 89451f3086 Ensure that form ids are unique
Add an unique prefix to each Form- or FormElement id, unless id protection is disabled explicitly, to prevent id collisions between different containers.

fixes #8460
2015-02-25 18:00:28 +01:00
Alexander Fuhr cc403806f7 Fix refresh accessibility lable if it is empty
refs #7968
2015-02-25 15:28:09 +01:00
Alexander Fuhr 453e0af987 Merge branch 'feature/refresh-control-7968'
resolves #7968
2015-02-25 14:28:25 +01:00