Alexander Klimov
5e6ef57590
LdapBackendForm: replace create with createElements and getResources with __construct
...
refs #5525
2014-07-29 12:21:58 +02:00
Johannes Meyer
5a738112ea
Remove isExistingBackend/-Instance
...
It is more efficient to access configuration files only once instead of
accessing them multiple times in different locations.
refs #5525
2014-07-25 16:02:13 +02:00
Johannes Meyer
d7ed6bd249
Adjust removebackend-action to suit the new backend form interface
...
Drops additionally the ConfirmRemovalForm of the monitoring module
as there is already one in icingaweb2's form-set.
refs #5525
2014-07-25 16:00:38 +02:00
Johannes Meyer
a78d11345b
Adjust createbackend-action to suit the new backend form interface
...
refs #5525
2014-07-25 15:58:44 +02:00
Alexander Klimov
02c3223a82
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/autologin-backend-form-6434
2014-07-25 15:07:04 +02:00
Johannes Meyer
b743cf8143
Adjust editbackend-action to suit the new backend-form interface
...
refs #5525
2014-07-25 14:55:36 +02:00
Alexander Klimov
ed10e49bb6
Add AutologinBackendForm
...
fixes #6434
2014-07-25 14:51:42 +02:00
Johannes Meyer
488ea4633d
Merge EditBackendForm with CreateBackendForm and rename it
...
It is not necessary to distinct between whether a backend is created or
edited as a user perhaps likes to change the name of a backend directly
instead of the need to remove and recreate it.
refs #5525
2014-07-25 14:50:53 +02:00
Alexander Klimov
644b3a1628
Make it possible to remove an authentication backend
...
refs #6434
2014-07-25 14:49:05 +02:00
Alexander Klimov
c06db7495b
Merge remote-tracking branch 'origin/bugfix/rebuild-form-builder-5525' into bugfix/autologin-backend-form-6434
2014-07-25 10:57:08 +02:00
Alexander Klimov
50de21e437
Make it possible to edit an authentication backend
...
refs #6434
2014-07-25 10:29:33 +02:00
Johannes Meyer
af5a3262be
Revert backslash removal in front of namespace-less use statement
2014-07-25 09:12:12 +02:00
Johannes Meyer
26d42da635
Re-add getResourcesByType as simplified version
...
refs #5525
2014-07-25 08:58:50 +02:00
Johannes Meyer
a6bd802e3e
Remove unnecessary properties and its getters/setters
...
refs #5525
2014-07-25 08:58:11 +02:00
Johannes Meyer
5f7652133e
Fix code-style and documentation
2014-07-25 08:39:27 +02:00
Alexander Klimov
af898cc2b3
Prefer switch rather than if - elseif
2014-07-24 17:35:26 +02:00
Johannes Meyer
26a78dc387
Remove properties from ConfirmRemovalForm and update it
...
Which object should be removed needs not to be a part of a form but is
accessible from the url's query string which should be in the action of the
form.
refs #5525
2014-07-24 16:20:01 +02:00
Johannes Meyer
c3731fa79e
Adjust removeresource-action to suit the new resource form interface
...
refs #5525
2014-07-24 16:17:30 +02:00
Alexander Klimov
1902b4f10f
Make it possible to create an authentication backend of type autologin
...
refs #6434
2014-07-24 15:50:01 +02:00
Johannes Meyer
0964316df4
Adjust editresource-action to suit the new resource form interface
...
refs #5525
2014-07-24 12:37:33 +02:00
Johannes Meyer
9c434fe8bf
Make isValid more compact and fix coding style
...
refs #5525
2014-07-24 09:05:10 +02:00
Johannes Meyer
edf49d091e
Rewrite addForceCreationCheckbox and move it downwards
...
We should not instantiate form elements directly without any specific
reason.
refs #5525
2014-07-24 08:57:49 +02:00
Johannes Meyer
d8b468cf12
Add addSubmitButton to BaseBackendForm
...
refs #5525
2014-07-24 08:49:47 +02:00
Johannes Meyer
235c4a8c52
Remove getConfig and add get/setBackendConfig instead
...
As for every configuration form, backend forms need special population
mechanisms as well.
refs #5525
2014-07-24 08:47:58 +02:00
Johannes Meyer
4fe46a2c6e
Remove unnecessary properties and their getters/setters
...
This kind of data is mainly prepared in the controller's action now or
directly fetched in a concrete form implementation.
refs #5525
2014-07-24 08:45:38 +02:00
Johannes Meyer
fd912daa3d
Adjust createresource-action to suit the updated resource form interface
...
refs #5525
2014-07-23 16:39:54 +02:00
Johannes Meyer
936f65eb27
Adjust resource form to suit the new form builder implementation
...
refs #5525
2014-07-23 16:39:15 +02:00
Johannes Meyer
c8d61f78e7
Fix the config/resource-action's html markup
2014-07-23 12:55:43 +02:00
Johannes Meyer
9cdd891866
Drop ReorderForm and handle its logic in the controller and view instead
...
refs #5525
2014-07-23 12:35:39 +02:00
Johannes Meyer
8b2cc3a558
Do not consider <button type=submit> when checking form completion
...
refs #5525
2014-07-23 10:58:45 +02:00
Johannes Meyer
0bf0213547
Rename Form::addElement to Form::createElement
...
Since we are using mainly createElement and addElement is only an alias for
createElement if no object is passed our changes to addElement can safely
be moved to createElement.
refs #5525
2014-07-23 10:57:46 +02:00
Johannes Meyer
25c9ee567d
Add missing use statement for Zend_View_Abstract
2014-07-23 10:54:22 +02:00
Johannes Meyer
75e09f2c69
Do not consider submit buttons when checking form completion
...
refs #5525
2014-07-21 15:25:00 +02:00
Johannes Meyer
a73e2ee654
Adjust general config form to suit the new form builder implementation
...
refs #5525
2014-07-21 14:33:52 +02:00
Johannes Meyer
a9f0b95e51
Adjust preferences form to suit the new form builder implementation
...
refs #5525
2014-07-21 10:20:04 +02:00
Johannes Meyer
f5ac592645
Do not consider disabled elements when checking form completion
...
Values of disabled inputs are not sent by browsers.
refs #5525
2014-07-21 08:57:41 +02:00
Johannes Meyer
6ed3d5fdbd
Remove Icinga\Form\Install\LoggingPage
2014-07-18 10:40:37 +02:00
Johannes Meyer
7157b11f97
Adjust LoggingForm to suit the "final" form builder implementation
...
refs #5525
2014-07-18 10:29:23 +02:00
Johannes Meyer
5da14d3fc5
Adjust LoginForm to suit the "final" form builder implementation
...
refs #5525
2014-07-18 10:23:04 +02:00
Johannes Meyer
f4ff2c90f2
It's a form's responsibility how its submit button should look like
...
refs #5525
2014-07-18 09:54:36 +02:00
Johannes Meyer
6ac471c598
Also mention the viewscript functionality of Form::loadDefaultDecorators()
...
refs #5525
2014-07-18 09:52:50 +02:00
Johannes Meyer
8f0b9899a3
We cannot know what kind of data is passed to Form::isValid()
...
refs #5525
2014-07-18 09:52:05 +02:00
Johannes Meyer
78a6175acc
Make form creation lazy and implement the new validation mechanism
...
Form creation must not depend on specific function calls. If a forms' elements are required and missing, create them. Form::isValid() must be
able to determine whether a form can be processed or not without to rely
on a particular button value.
refs #5525
2014-07-18 09:51:15 +02:00
Johannes Meyer
37fd3deb67
Rename initCsrfToken to addCsrfToken and move it upwards
...
Form::addCsrfToken() should be public and fluent to ensure more
flexibility.
refs #5525
2014-07-18 09:43:03 +02:00
Johannes Meyer
58188c5cc1
We only want to rely on Form::isValid() when about to process forms
...
As the new auto-submission implementation does not depend on whether
a submit button was pressed or not we need another way to determine
whether a form should be processed.
refs #5525
2014-07-18 09:33:09 +02:00
Johannes Meyer
802c095bf8
Configuration values need to be inserted to forms explicitly
...
It's the controllers' responsibility to ensure that forms are populated with
configuration values on GET requests.
refs #5525
2014-07-18 09:27:10 +02:00
Johannes Meyer
21cd503ee7
Form buttons need to be added explicitly
...
We either demand the user to add a submit button or provide a implicit
function call to be implemented by him, adding additional elements once
the form gets rendered.
refs #5525
2014-07-18 09:24:49 +02:00
Johannes Meyer
47ae4d79dc
Forms do not need a special title property
...
As our upcoming wizard has no menu and our tabs are hardcoded we do not
need a special "title" property anymore.
refs #5525
2014-07-18 09:21:11 +02:00
Johannes Meyer
1de2d0c14f
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Authentication/LoginForm.php
library/Icinga/Test/BaseTestCase.php
library/Icinga/Web/Form.php
library/Icinga/Web/Form/Decorator/BootstrapForm.php
2014-07-17 13:15:42 +02:00
Johannes Meyer
4d199180b3
We do not want to access $_POST directly if it is possible to avoid it
2014-07-17 09:28:10 +02:00