Commit Graph

5560 Commits

Author SHA1 Message Date
Johannes Meyer 65eafc0e8f LdapDiscoveryForm: Remove waste 2015-03-02 18:40:46 +01:00
Matthias Jentsch 92a15a6ee4 Fix badge css
Nav element added for accesssibility destroyed the badge CSS. Make badge CSS more robust against inserted elements.
2015-03-02 18:26:33 +01:00
Johannes Meyer 1eacaa4c48 Improve the display of the text cue on required form elements
Shows just a message at the top of the form if all elements are required
and a explaining message what the cue is standing for otherwise.

refs #7934
2015-03-02 13:48:35 +01:00
Johannes Meyer 1a334f8d64 Add decorator FormDescriptions
This decorator displays a list of messages at the top of a form.

refs #7947
2015-03-02 13:45:24 +01:00
Matthias Jentsch 0f3c27f812 Fix event grid for dashboard 2015-03-02 12:27:27 +01:00
Matthias Jentsch e4f71eacd6 Add unit tests for ldap connection behavior
It is important that we test handling of protocol extensions properly, to prohibit errors that are difficult to reproduce like this in the future.

fixes #7993
2015-02-27 17:11:12 +01:00
Matthias Jentsch 36d2d31035 Do not use page control unless explicitly announced
refs #8490
2015-02-27 17:10:55 +01:00
Matthias Jentsch 65821863fa Don't crash on single ldap capability entries
refs #8490
2015-02-27 17:10:21 +01:00
Matthias Jentsch e93a5f16d9 Move capability-related code of the ldap connection into a separate class
Achieve a better separation between the different concerns, more readable code and get rid of unused dead code.
2015-02-27 17:10:21 +01:00
Johannes Meyer 7bb78330a9 Replace cancel icon with the trash icon...
...where the link's purpose is to remove something
2015-02-27 14:47:46 +01:00
Johannes Meyer 74dfa6e72a Fix invalid icon names passed to the icon view helper 2015-02-27 14:45:47 +01:00
Johannes Meyer 96c132908d Provide a warning on autosubmit form elements and a title for the apply btn
resolves #7935
2015-02-27 13:09:13 +01:00
Johannes Meyer 4f0bddd7da Do not add aria-label to icons and images with titles if aria-hidden is set 2015-02-27 12:12:24 +01:00
Johannes Meyer f2259557c8 Fix missing tab labels
fixes #8518
2015-02-27 09:32:44 +01:00
Johannes Meyer 82017da85f Help: Do not protect form element ids twice 2015-02-27 09:20:15 +01:00
Johannes Meyer ea4de82545 Login: Disable the required cue
It should be obvious that it is necessary to input a name and a password
to login in case you're looking at a "login" form...

refs #7934
2015-02-27 09:09:25 +01:00
Johannes Meyer c00e336ea8 Make the cue that is being appended to required form elements configurable
refs #7934
2015-02-27 09:08:05 +01:00
Johannes Meyer 48c3199a2d Form: Fix id protection
Altering element ids upon rendering makes it impossible to reference
them elsewhere. Zend_Form::getId() should be preferred over getName()
as it falls automatically back to getName() in case there is no id attribute
set. Setter are required to return their instance. Overwriting methods
without calling the parent (getId) without any valid (or at least
documented) reason is very bad practice.

refs #8460
2015-02-27 09:01:46 +01:00
Johannes Meyer 6d81a194ab Make form element descriptions accessible
Re-added the Help decorator to make sure an element's description
is being added in an accessible way.
2015-02-27 08:10:25 +01:00
Johannes Meyer 0111fdf78e Add an asterisk suffix to a form element's label if its required
The screen reader part "(required)" is not being considered with this
commit as most screen readers do not need this due to the ARIA and
HTML5 property.

resolves #7934
2015-02-26 16:05:13 +01:00
Johannes Meyer 4351603243 Fix that editing an auth backend does not open the next column 2015-02-26 14:48:37 +01:00
Matthias Jentsch bc950a855d Surpress warnings when ldap page control is not available 2015-02-25 18:39:03 +01:00
Matthias Jentsch 89451f3086 Ensure that form ids are unique
Add an unique prefix to each Form- or FormElement id, unless id protection is disabled explicitly, to prevent id collisions between different containers.

fixes #8460
2015-02-25 18:00:28 +01:00
Alexander Fuhr cc403806f7 Fix refresh accessibility lable if it is empty
refs #7968
2015-02-25 15:28:09 +01:00
Alexander Fuhr 453e0af987 Merge branch 'feature/refresh-control-7968'
resolves #7968
2015-02-25 14:28:25 +01:00
Alexander Fuhr 797d37735d Add .spinner class to CheckNowCommandForm submit button
refs #7968
2015-02-25 14:16:35 +01:00
Alexander Fuhr 16200417eb Add spinner active indicator for form submit buttons
refs #7968
2015-02-25 14:15:32 +01:00
Alexander Fuhr 08ace05ac7 Remove animations.css from StyleSheet loading lessFiles
refs #7968
2015-02-25 13:56:32 +01:00
Alexander Fuhr c029ec1af9 Replace animate-spin with own animate implementation in spinner
refs #7968
2015-02-25 13:53:00 +01:00
Alexander Fuhr 7f883a4770 Add own animation.less to provide own parameterized animate function
refs #7968
2015-02-25 13:51:26 +01:00
Alexander Fuhr ef79d6bc12 Replace spinner.active font-family css definition with a note
refs #7968
2015-02-25 13:34:58 +01:00
Alexander Fuhr 3a2b69a63c Remove refreshTab property from Tabs
refs #7968
2015-02-25 13:24:11 +01:00
Alexander Fuhr 8669dcb078 Add font-family to the active spinner icon
refs #7968
2015-02-25 13:23:12 +01:00
Alexander Fuhr e219bb1664 Add doc for the label
refs #7968
2015-02-25 13:13:22 +01:00
Alexander Fuhr 481c58ec03 Add accessibility to renderRefreshTab
refs #7968
2015-02-25 12:14:26 +01:00
Alexander Fuhr c583a351bb Add .spinner css definition
refs #7968
2015-02-25 12:11:58 +01:00
Alexander Fuhr 4505718ecc Move spinner indicator functionality to linkClicked method
refs #7968
2015-02-25 12:10:08 +01:00
Alexander Fuhr 3b2e3dcd36 Revert the animate-spin css to the original
refs #7968
2015-02-25 12:07:59 +01:00
Alexander Fuhr 5297b15a61 Merge branch 'master' into feature/refresh-control-7968 2015-02-24 14:41:09 +01:00
Johannes Meyer d68c636359 Wizard: Disable the browser's form validation when navigating back
formnovalidate... The fukin awesomeness of HTML5 is sometimes
even impressing a god-damned h4x0r like me.

fixes #8507
2015-02-24 13:16:31 +01:00
Matthias Jentsch d4dc0177c0 Sort LDAP user list
fixes #7693
2015-02-24 12:50:57 +01:00
Matthias Jentsch b70cda77d4 Fail gracefully if the page control is not available
Execute the runPagedQuery without pagination instead of throwing an exception.

fixes #8490
2015-02-24 12:22:29 +01:00
Johannes Meyer decab543b0 Merge branch 'feature/link-labels-8458'
resolves #8458
2015-02-24 11:35:56 +01:00
Johannes Meyer 8e8bab0795 Do only escape a qlink's label manually if necessary 2015-02-24 11:35:25 +01:00
Johannes Meyer 907134cee2 Ensure that all link-like form buttons got proper titles
refs #8458
2015-02-24 09:03:47 +01:00
Johannes Meyer 956efe5ef9 Merge branch 'master' into feature/link-labels-8458
Conflicts:
	application/views/scripts/config/application.phtml
	application/views/scripts/config/module.phtml
	application/views/scripts/config/modules.phtml
	library/Icinga/Web/Widget/Dashboard/Dashlet.php
	modules/monitoring/application/controllers/TimelineController.php
2015-02-24 08:42:36 +01:00
Johannes Meyer 61dc4c09f0 Fix css of the event grid 2015-02-23 17:33:44 +01:00
Johannes Meyer e6957967f9 Wizard: Add proper titles to the button-like links on the last page
refs #8458
2015-02-23 17:33:23 +01:00
Johannes Meyer 60a9d1f224 Wizard: Add proper title to the refresh button of the requirements page
refs #8458
2015-02-23 17:32:55 +01:00
Johannes Meyer cebaa47aa9 Hide the css-hidden link to extend the timeline from screen readers as well 2015-02-23 17:32:29 +01:00