Commit Graph

4489 Commits

Author SHA1 Message Date
raviks789 b813e0badb `Perfdata`: Fix return type for method `convert()` 2023-08-23 10:53:13 +02:00
raviks789 8fe428f987 `CustomVarTable`: Cast `$wrapper` to `ipl\Html\HtmlDocument` using inline `@var` in `renderGroup()` 2023-08-23 10:53:13 +02:00
raviks789 00f367c7d6 `MonitoredObjectController`: Access `MonitoredObject::fetchEventhistory()` with correct name case 2023-08-23 10:53:13 +02:00
Sukhwinder Dhillon 72d155c57d Remove not in use class `Plugin.php` 2023-08-23 10:53:13 +02:00
raviks789 8a17c56345 Remove requiring vendor dependencies
Also avoid autoloading vendor.
2023-08-09 15:16:16 +02:00
Johannes Meyer c9f3f0444d tests: Require view helpers at runtime 2023-07-04 16:24:19 +02:00
Gianluca Piccolo db9888b1f1 Fixes #5020 2023-06-22 15:11:39 +02:00
Thomas Gelf 463cc748bf MonitoringBadgeNavigationItemRenderer: do not fail
...on wildcard filter
2023-06-22 15:07:47 +02:00
Sukhwinder Dhillon ea1e5f9245 TimeLine: Always parse `int` to validateTime()
Php < 8.1 converts fetched time(stamp) to string. This must always be an int.
2023-06-22 15:05:10 +02:00
Johannes Meyer 693bed1710 Raise version to 2.11.4 2023-01-26 09:42:18 +01:00
Johannes Meyer e542982de0 Fix some reflected XSS bugs
fixes #4979
2023-01-12 09:55:57 +01:00
Johannes Meyer d0a83a646c Release version 2.11.3 2022-12-14 13:21:01 +01:00
Johannes Meyer 6ef968bb96 Raise version to v2.11.2 2022-11-04 12:14:40 +01:00
Johannes Meyer 17bd3ce14f collapsible.js: Use a data-attr to identify collapsible collapsibles 2022-10-10 10:42:45 +02:00
raviks789 bff47213ee Show warning health state badges
The warning state badges should be shown when notifications or active host/service checks are disabled.
2022-10-10 10:00:06 +02:00
Sukhwinder Dhillon 762630c027 event-history.phtml: Don't sort events by time
Sort only by day and date
2022-10-10 09:59:26 +02:00
Johannes Meyer dae7bf4657 Macro: Log the object where a macro is not found
fixes #3759
2022-10-10 09:58:39 +02:00
Alexander Aleksandrovič Klimov ad827395af Unveil hidden downtime in checkable detail view
Case: there are no comments, one downtime and you may not schedule additional ones.

Before: downtime is not shown in checkable detail view.

After: downtime is shown in checkable detail view.
2022-10-04 16:04:55 +02:00
Johannes Meyer 225d43b45f Release version 2.11.1 2022-07-06 14:48:48 +02:00
Johannes Meyer 4b60f87021 IdoQuery: Correct doc of method `requireColumn()` 2022-07-05 09:55:32 +02:00
Johannes Meyer e5ec9a36f7 monitoring: Fix conversion rules for timestamps in various queries 2022-07-05 09:55:32 +02:00
Johannes Meyer dcf194bc4c Raise version to 2.11.0 2022-06-30 13:47:07 +02:00
Johannes Meyer 3d159fe434 TimeRange: Accept strings in method `validateTime()` 2022-06-30 08:41:47 +02:00
Johannes Meyer e3a9b56423 eventgrid: Avoid passing null to string type functions 2022-06-30 08:40:28 +02:00
Dirk Goetz d5d714b1ee Fix gravatar: set content-type header and size
Fixes #2254
2022-06-15 09:03:12 +02:00
mrdsam 0c325eb027
Update 03-Configuration.md (#4806) 2022-06-15 08:57:45 +02:00
Johannes Meyer ec27f77861 DataView: Relax filter validation again
There are way too much missing columns in data views all
over the place. I dont' see a justification to fix them
as it's only now this "issue" occurs. It's easier to
revert this change here.

fixes #4797
2022-06-14 15:32:21 +02:00
Sukhwinder Dhillon 4ab79a6758 DataView: Remove not in use method `applyUrlFilter()` 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon 3b04a0489e Replace class `Backend` use with `MonitoringBackend` and remove class `Backend` 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon 0db42b32e6 Remove not in use class `Icinga\Module\Monitoring\Environment.php` 2022-06-14 14:24:30 +02:00
Johannes Meyer 46a21d9709 Drop method `DbQuery::whereToSql()`
It's been used by `DbQuery::renderFilter()` rather
exclusively. So if removing one, both need to go.
2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon be1ff03dd3 MonitoredObject: Remove deprecated methods `matches()` and `fromParams()` 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon 60756afa34 Replace `MonitoringBackend::createBackend()` with `MonitoringBackend::instance()` 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon 49bea36345 MonitoringBackend: Remove deprecated method `createBackedn()` 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon 577d97a450 DataView: Move `sort()` body to `order()` and remove `sort()` and `fromRequest()` 2022-06-14 14:24:30 +02:00
Sukhwinder Dhillon d8ddc6600a overrides `customvarsWithOriginalNames` only if the given object is of type `host`
A call to `__get()` reset the array if the given `$name` is a customvar
If `service` has a `host` customvar filter, the `fetchHostVariables()`
method was executed and overwrote the `customvarsWithOriginalNames` array.

fixes #4757
2022-06-13 11:56:57 +02:00
Johannes Meyer 777d146ba1 Perfdata: Avoid passing null to `number_format()` 2022-05-27 14:41:42 +02:00
Johannes Meyer 74022ae4e0
Merge pull request #4697 from Icinga/feature/redesigned-user-menu-new
Feature/redesigned user menu
2022-05-16 09:04:26 +02:00
Johannes Meyer 0f64e24f99 MonitoredObject: Register filters with `whereEx()` 2022-05-12 16:33:30 +02:00
raviks789 8898ed85ab Change FilterMatch to FilterEqual class for single object filter on object name.
Correspondingly the DbConnection::renderFilter() (as DbQuery::renderFilter() is deprecated and will be removed, hence no modifications here)
is also modified to render accordingly.
This correctly selects the host, service or contact in case the object name contains wild card characters like "\*".
2022-05-12 16:28:35 +02:00
Johannes Meyer 3edb5c3c94 IdoQuery: Introduce method `whereEx()` 2022-05-12 16:28:35 +02:00
Florian Strohmaier 04199915fe monitoring/configuration: Do not add ‘Monitoring Health’ item 2022-05-12 15:13:16 +02:00
Johannes Meyer c5cf7abf0d IdoQuery: Avoid passing `null` to preg_replace()
refs #4640
2022-04-19 15:01:52 +02:00
Alexander A. Klimov e6eb1540c0 Monitoring: permit disabling IDO backends no Icinga writes to 2022-04-11 16:40:22 +02:00
Patrick Dolinic f9ec105537 Monitoring: Delete unnecessary cli-command 2022-04-11 13:31:59 +02:00
Johannes Meyer 95d0ac018c Raise version to 2.10.1 2022-04-06 09:34:11 +02:00
Johannes Meyer 1717afbe39 event-history.phtml: Use `Intl` to localize dates
instead of `strftime`, which is deprecated
2022-03-24 12:29:06 +01:00
Johannes Meyer 3dc384fb58 Avoid passing `null` to non-nullable arguments 2022-03-24 12:29:06 +01:00
Johannes Meyer c038e84fc2 Ensure Return Type Compatibility with Internal Classes 2022-03-24 12:29:06 +01:00
Johannes Meyer f72837676c monitoring: Drop controller `AlertsummaryController` 2022-03-24 12:27:20 +01:00
Johannes Meyer 7a12849a66 TacticalController: Use correct state filter for big services url
fixes #4714
2022-03-24 10:21:33 +01:00
Johannes Meyer 6802abc2c7 quick-actions.phtml: Set explicit ids instead of overriding the name..
..to avoid duplicate ids

fixes #4711
2022-03-24 10:21:07 +01:00
Johannes Meyer d0677a127f Release version 2.10.0 2022-03-23 11:49:06 +01:00
Johannes Meyer 0d032989e6 Fix style issues in recent security fixes 2022-03-08 15:20:16 +01:00
Johannes Meyer f21200f167 Release version 2.9.6 2022-03-08 15:12:52 +01:00
Johannes Meyer e815ff0309
Merge pull request from GHSA-qcmg-vr56-x9wf
Fix/ghsa qcmg vr56 x9wf
2022-03-08 12:03:41 +01:00
Johannes Meyer a48bd84fb4 monitoring: Drop obsolete view script `show/components/customvars.phtml` 2022-03-02 10:41:23 +01:00
Johannes Meyer 83e8b3b8e8 detail-content: Use widget `CustomVarTable` to render custom vars 2022-03-02 10:40:57 +01:00
Johannes Meyer 6085b02b16 monitoring: Introduce new class `CustomVarTable` 2022-03-02 10:38:08 +01:00
Johannes Meyer b0a7464795 Introduce new hook `Monitoring/CustomVarRenderer` 2022-03-02 10:38:08 +01:00
Johannes Meyer 48e0f1bd1f PluginOutput: Transform newlines first and purify HTML afterwards
fixes #4686
2022-03-02 08:23:51 +01:00
Johannes Meyer 6d744e585f monitoring/list/services: Enhance PDF layout 2022-03-01 17:04:38 +01:00
Johannes Meyer 159ca2ce3f monitoring/list/servicegroups: Enhance PDF layout 2022-03-01 17:04:38 +01:00
Johannes Meyer 861f166798 monitoring/list/hosts: Enhance PDF layout 2022-03-01 17:04:38 +01:00
Johannes Meyer 4da687ae27 monitoring/list/hostgroups: Enhance PDF layout 2022-03-01 17:04:38 +01:00
Johannes Meyer d5fbae7b28 monitoring/list/downtimes: Enhance PDF layout 2022-03-01 17:04:38 +01:00
Johannes Meyer 122d52c953 monitoring/list/contacts: Enhance PDF layout 2022-03-01 17:04:38 +01:00
Johannes Meyer 298f2a3061 monitoring/list/comments: Enhance PDF layout 2022-03-01 17:04:38 +01:00
Johannes Meyer 8779f9f175 IdoQuery: Join customvars with only live references 2022-02-28 13:08:05 +01:00
Johannes Meyer 1092421782 Ido\Query\: Add objecttype_id checks where missing 2022-02-28 13:07:17 +01:00
Johannes Meyer 00353a1f25
Merge pull request #4660 from Icinga/fix/unhandled-service-counter-not-always-visible-3921
Drop the unhandled services counter in host lists
2022-02-28 13:05:29 +01:00
Johannes Meyer e7bc0a136b Perfdata: Render unknown UOMs as-is 2022-02-28 11:53:59 +01:00
Johannes Meyer 796742f03d monitoring/list/hosts: Don't show unhandled service counts
It has too much problems. It wasn't even visible since the
initial release, at least not if there were many results.
It being visible was more a case of chance than guarantee.
We now also identified a major issue with restrictions and
the way we can assemble queries here. In short, there are
too much technical difficulties that we deemed it not
worthwhile to keep.
2022-02-25 17:09:13 +01:00
Johannes Meyer 2e9a94144f HostserviceproblemsummaryQuery: Don't clear order of the host status query 2022-02-25 17:08:39 +01:00
Johannes Meyer a4d34e265f IdoQuery: Don't try to add a `HAVING` without group by rules 2022-02-11 12:11:40 +01:00
Johannes Meyer 7a938f6b02 css: Don't use `.var()` or `var()` calls explicitly 2022-02-10 10:59:01 +01:00
Johannes Meyer 3166d112f1 monitoring/list/hosts: Apply restrictions to host service problem summary 2022-02-07 17:20:41 +01:00
Johannes Meyer 28a8771a37 components/comments.phtml: Use base target `_next` only for comment links 2022-02-07 14:47:03 +01:00
Johannes Meyer 4f501a89f5 monitoring: Avoid duplicate ids for check now and remove ack forms 2022-02-04 17:21:41 +01:00
Johannes Meyer 56cde52351 Drop locales of builtin modules 2022-02-04 15:58:06 +01:00
Johannes Meyer 6b4f4d388a monitoring: Really show custom variable names as-is 2022-02-04 15:56:44 +01:00
Johannes Meyer 316885b271
Merge pull request #4498 from Icinga/bugfix/tactical-4494
/monitoring/tactical: fall back to unknown services if none critical
2021-12-14 10:24:57 +01:00
Sukhwinder Dhillon c30df56de4 Release version 2.9.5 2021-11-17 16:51:55 +01:00
Johannes Meyer 81f6116f3f Release version 2.9.4 2021-11-10 10:17:35 +01:00
Johannes Meyer 47922673fc PluginOutput: Don't "optimize" two subsequent newlines to one
fixes #4522
2021-11-02 09:00:21 +01:00
Ravi Kumar Kempapura Srinivasa be3a722a28 Compress comment detail in Hosts detail and Comments list. 2021-10-07 10:44:10 +02:00
Alexander A. Klimov 6e1ab2c0ea /monitoring/tactical: fall back to unknown services if none critical
refs #4494
2021-09-23 15:17:33 +02:00
Johannes Meyer 83557afd35 IdoQuery: Qualify and resolve subquery filters ASAP
fixes #4508
2021-08-24 09:32:36 +02:00
Johannes Meyer b2274a5589 Release version 2.9.3 2021-08-10 10:11:44 +02:00
Eric Lippmann 1e1b4b74ad If appropriate, set the API parameter all_services for schedule-downtime
Since Icinga 2.11.0 the schedule-downtime API supports the
all_services parameter. So far we've always sent a separate
request for scheduling service downtimes. As of Icinga 2.13.0,
these service downtimes are automatically removed when the host
downtimes are removed. Of course, this doesn't work if we don't
use the all_services parameter but send a separate request.
With this commit we set this parameter if the transport is API
and Icinga is equal to or greater than 2.11.0.

In addition, if child_options and all_services were previously set,
a request was sent per host and service. This is now also only a
single request if an API command transport is requested or only
API command transports are configured.
2021-08-09 16:55:05 +02:00
Johannes Meyer 907f7826b2 Release version 2.9.2 2021-07-28 09:33:41 +02:00
Johannes Meyer 1b2cd8fdf3 Release version 2.9.1 2021-07-27 15:22:32 +02:00
Johannes Meyer b94617c575 ServicestatusQuery: Define correct grouping rules for contacts and -groups
fixes #4464
2021-07-21 17:41:55 +02:00
Johannes Meyer d123b390b1 MonitoredObject: Keep structure of nested cvs during protection
fixes #4439
2021-07-21 08:01:08 +02:00
Johannes Meyer f73614be4d Raise version to 2.9.0 2021-07-12 10:35:56 +02:00
Johannes Meyer 9c1e4fa491 monitoring: Ensure cvs are also protected in exported results 2021-07-12 09:42:03 +02:00
Johannes Meyer b48fc20edf monitoring/list/(hosts|services): Respect cv blacklist with `?addColumns` 2021-07-12 09:42:03 +02:00
Johannes Meyer e035f5b9f2 monitoring/list/services: Protect custom variables added with `?addColumns` 2021-07-12 09:42:03 +02:00
Johannes Meyer c953e4f92d monitoring/list/hosts: Protect custom variables added with `?addColumns` 2021-07-12 09:42:03 +02:00
Johannes Meyer 1dc6f35916 MonitoredObject: Make customvar protection available to the outside 2021-07-12 09:42:03 +02:00