f2e5d8afa5
Remove @codeCoverageIgnoreStart/-Stop annotations
...
refs #6091
2014-06-30 13:58:37 +02:00
62928c48b0
helpers/timeSince: fix c&p error
2014-06-27 23:37:39 +02:00
7112ed23f4
Chart\InlinePie: locale-ignorant cast for floats
...
This has already been fixed with 92f454c3be0c5d4b#6348
2014-06-25 22:13:19 +02:00
10d1520711
Widget\Limiter: show "all"
...
In case we pass limit=0 we show this, still unsure whether we should
provide a link for "showing all" - might really hurt with millions of
history rows.
2014-06-25 20:39:10 +02:00
59dd80ed32
ActionController: benchmark should measure rendering
...
We have been cheating a little bit, now the measurement should be more
precise.
2014-06-25 20:37:17 +02:00
d49f30ff77
Improve InlinePie performance
...
Use str_replace instead of preg_replace
2014-06-25 15:24:53 +02:00
7b19bd1d99
Improve interface of InlinePie
...
Method setLabel can also accept a simple string and title is mandatory in constructor
2014-06-25 15:21:12 +02:00
8839166090
Add number format 'none' to InlinePie
2014-06-25 14:53:39 +02:00
35a5431512
Revert "Refractor InlinePie and Perfdata helper"
...
This reverts commit f003c38abd
2014-06-25 14:29:17 +02:00
f003c38abd
Refractor InlinePie and Perfdata helper
...
Refractor InlinePie methods for better usability, fix several coding guideline
issues and fix some typos
2014-06-25 12:41:17 +02:00
4591297e56
SortBox: use POST instead of GET
...
This avoids trouble with complex filter URLs
fixes #6556
2014-06-25 11:00:10 +02:00
1dcf44b9cd
FilterEditor: fix buggy dropdown boxes
...
There were some issues with option names. Also cleaned up HTML a
little bit and added autosubmission.
2014-06-25 10:37:06 +02:00
b40d0f6a1e
FilterWidget: POST instead of GET
...
Might have been a JS issue, but instead of messing with the URL just
POSTing is easier here - and works. Filters from the search box are
now added flawlessly to the filter tree.
2014-06-25 10:34:09 +02:00
2746b5ff9f
ConfigController: switch over to new config tabs
...
Module configuration now takes place in module detail view and does no
longer pollute our config tabs. Modules are now able to provide a bunch
of own config tabs, we don't really care what they use them for.
2014-06-24 21:31:59 +02:00
b38bcfc19b
Widget\FilterEditor: correct expression output
...
Filter expressions should be filled into form fields exactly as we
expect them at parse time.
fixes #6568
2014-06-24 21:00:01 +02:00
47b893e1ea
Widget\FilterEditor: handle custom vars
...
There was an issue with custom vars as they made only partially part
of the column dropdown. Sorted columns and tried to beautify column
names.
fixes #6569
2014-06-24 20:57:41 +02:00
3f9f4bb9e1
ModuleActionController: module object shortcut
...
This helps modules with the need to know more about themselves. No
more App -> Module Manager -> Module voodoo.
2014-06-24 20:54:39 +02:00
b7b99cfd67
Widget\AlertMessageBox: fix broken widget
...
This widget is pretty useless as the error view script can to it's
job. Interestingly nobody missed it, even the render() call was wrong.
I guess we will remove this soon, but for now it's fixed. Looks ugly,
but works.
2014-06-24 20:30:41 +02:00
ba9a633b73
Web\Form: relax form submission check
...
We have to live with some badly designed forms right now. Some have
submit buttons but don't know about, others don't have such but link
to foreign controllers fiddling with the form and adding different
button AFTER the form got submitted - it's a mess.
Relaxing the submission check to "just check whether btn_submit has
a value" fixes most of this. However I do not consider this being a
solution for the long run.
fixes #6423
fixes #5967
refs #6540
2014-06-23 13:31:34 +02:00
ea44de8698
ActionController/translate: detect domain only once
2014-06-22 20:09:23 +02:00
23ed744747
params/_render: replace it everywhere
...
Cleaning up controllers and JS, using headers only and respecting
history.
2014-06-22 20:07:44 +02:00
61600ae2d4
ModuleActionController: fix typo
2014-06-22 19:39:54 +02:00
997587d729
Chart\InlinePie: remove ugly default border
2014-06-22 16:38:12 +02:00
216f0f3f55
isIframe: clean up, load less html and js
...
We use isIframe only when we have no JS, therefore it makes no sense
to load JS files in an iFrame. Also removed sidebar.
2014-06-22 16:30:06 +02:00
3b84078b2f
Params/_render: get rid of it, start with iframe
2014-06-22 16:18:23 +02:00
bb23d0636c
ModuleActionController: use isXhr()
2014-06-22 16:04:55 +02:00
3774eb6889
ActionController: add isXhr() method
...
Makes things easier as we use this a lot
2014-06-22 15:36:41 +02:00
331d756a2a
ActionController: isolate ignoreXhrBody
...
This function is only a workaround for broken forms not redirecting
after submission. Will hopefully be removed soon.
2014-06-22 15:33:38 +02:00
b4f8ef74fa
ActionController: remove obsolete code
2014-06-22 15:20:55 +02:00
631603aba3
ActionController: create postDispatchXhr
...
Moved XHR-specific stuff to a dedicated post-dispatch function
2014-06-22 15:17:28 +02:00
cf995b366b
ActionController: cleanup postDispatch
...
Make XHR handling more readable, move module-related stuff to the
module controller
2014-06-22 15:11:08 +02:00
de19745eb2
ActionController: move moduleInit to Module controller
2014-06-22 13:54:02 +02:00
2cd25b7376
ActionController: if/else should be easy to read
2014-06-22 13:52:40 +02:00
b7fc0b67a8
Web/controllers: use own Request/Response objects
...
* introduces Icinga\Web\Response
* uses ModuleActionController where necessary
* no module translationDomain voodoo in base ActionController
2014-06-22 13:49:21 +02:00
ef5e1b54fd
Web\Window: fix it's usage, add helper function
...
Improved window handling, fixed controllers using it.
2014-06-22 13:21:21 +02:00
b350e3640d
Web\Window: move window handle to dedicated class
...
One more step in cleaning up our ActionController
2014-06-22 13:01:48 +02:00
d69a6d1640
ActionController: remove getRequestUrl
...
Thie removes complexity and makes redirection to login less error-
prone.
2014-06-22 12:23:34 +02:00
9608d8254d
ActionController: remove addModuleContainer
...
This method was obsolete
2014-06-22 12:09:07 +02:00
4980b700da
ActionController: __construct() as first function
2014-06-22 12:07:50 +02:00
a4955df1a9
controller->Auth(): one more lazy-loading helper
...
Not sure about the capital A, but doesn't look so bad - and similar
to Config().
2014-06-22 12:06:09 +02:00
373e1c5ecb
Web\Controller: re-introduce ModuleActionController
...
This will help getting rid of a couple of if/else constructs
2014-06-22 12:03:37 +02:00
469eb3dc98
Web\Url: remove forgotten "debug" line
2014-06-22 11:59:24 +02:00
b3cdeee35d
monitoring/timeline: should benefit from new filter
...
Different changes have been applied:
* Allow integer unix timestamps as parameters for timestamp columns
* Remove alias-rewriting from Url class
* Remove all traces of raw_timestamp
* Use new filters
2014-06-21 03:09:40 +02:00
216c2ca770
Autorefresh: should work also on initial page load
...
fixes #6296
2014-06-21 01:54:32 +02:00
c0c7a815f8
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
2014-06-20 19:18:38 +02:00
3e24a2cbe4
Paginator/SlidingWithBorder: use less space
...
Showing less items right now. It would be great if we could steer
this by parameter. IMO we should also think about dropping ZF
pagination and use a custom tiny widget.
2014-06-20 17:31:32 +02:00
afd6b11b7b
Web\Url: add set/mergeValues support
2014-06-20 15:50:55 +02:00
2cf79fe9a7
Widget\SortBox: hardcode some styles
...
This is a quickfix, should be moved to CSS once we know how our HTML
elements will definitively look like
2014-06-20 14:55:43 +02:00
916c9c027e
forms: fix isSubmitted
...
Implementation made wrong assumptions. A form is submitted when the
submit button has been pressed. It's value is then filled, it also
is when you're just pressing "RETURN". RETURN triggers the FIRST
submit button in a form. This way we are also able to find out which
form button has been pressed.
Current implementation is still poor, however isSubmitted works as
expected right now - and so does autosubmission.
fixes #5967
2014-06-20 14:32:22 +02:00
01631720cc
Dashboard\Component: don't pass on limit
...
Dashlets might be limited to just a few line, we shoultn't pass on
this parameters when showing the "large" variant
2014-06-20 14:29:45 +02:00
ac7354295a
Accessibiltiy: add alt tag for icons
...
Screen readers to not read title tags per default
2014-06-20 14:28:19 +02:00
27e7839d1b
Widget\Limiter: initial commit
...
This allows one to easily switch row count shown on a single page
2014-06-20 13:48:17 +02:00
07134cf931
JS/XHR: handle multiple notifications
...
As there seems to be problems with sending the same header multiple
times we put multiple notifications in one header.
2014-06-20 13:20:20 +02:00
617741c62f
helpers/widget: options are opional
2014-06-20 13:18:52 +02:00
dbf03ee647
ActionController: refine url handling on redirect
2014-06-20 13:18:03 +02:00
7cad4de3be
ActionController: allow to disable autorefresh
2014-06-20 13:17:11 +02:00
f498cd0c81
Web\Url: small fixes, allow override queryString
2014-06-20 12:41:16 +02:00
d504c27641
timeUntil/timeSince: add timestamp hover title
...
It's sometimes easier to read "full" timestamps.
2014-06-20 12:28:55 +02:00
317094aed3
Widget\FilterWidget: ui cleanup
2014-06-20 12:16:33 +02:00
644dd5e33e
Widget\FilterEditor: improve the filter editor
...
This adds quite a bunch of changes. Part of the filter-modifying
complexity has been moved to the filter, the editor widget itself
now makes use of new filter capabilities such as changing operator
or expression type.
2014-06-20 12:03:22 +02:00
aae49ce0c0
Do not show tooltips for piechart areas that indicate empty or free areas
...
refs #6117
2014-06-18 17:38:25 +02:00
6555d347a7
Escape InlinePie html and adjust chart size
...
fixes #6117
2014-06-18 14:43:14 +02:00
be0c5d4b23
Add more meaningful tooltip labels to InlinePies
...
Show current title, a well-formated value and a label for each area in a
tooltip and add the ability to customize tooltip labels of InlinePies
refs #6117
2014-06-18 14:43:14 +02:00
21febddad2
Widget\Filter*: rudimentary filter widgets
...
Initial implementation, more to come
2014-06-17 14:00:38 +00:00
54e97f114d
Widget\SortBox: hardcode element width
...
Temporarily added inline CSS, shall be removed soon
2014-06-17 13:54:32 +00:00
d63d8fe451
view/helpers: add $this->widget()
2014-06-17 13:53:05 +00:00
e3e6826d9d
Icinga\Filter: remove
2014-06-17 13:26:57 +00:00
992a8a276b
Web/ActionController: provide $this->params
...
We always need params, this are our new URL params made accessible
this way. This is just for our query string, not for POST body params.
2014-06-17 12:58:04 +00:00
468b290277
Monitoring\Controller: provide $this->backend
...
Every monitoring controller needs $backend, so why declaring it over
and over again. Created "moduleInit" dummy function in our base action
controller to allow such implementations without polluting init().
2014-06-17 12:55:43 +00:00
5ea9b2be84
Web\Url: make use of the new UrlParams class
...
This makes a lot of things easier while trying to preserve compatibililty.
However, a few things like aliases are marked for removal (TODO).
2014-06-17 10:07:19 +00:00
de5bb56fb3
Web\UrlParams: new implementation
...
The URL query string parsing done by PHP/ZF doesn't suffice our needs.
This is an implementation preserving filter-related "strange" query
string components while still offering legacy behaviour.
Missing right now: support for [].
2014-06-17 10:00:49 +00:00
44a7aa6adb
JS/IE8: deliver legacy jQuery for IE8
...
This patch makes IcingaWeb deliver a legacy jQuery version for IE8
as it is no longer supported in jQuery 2.x. JS for IE8 will not be
delivered minified to ease troubleshooting on that buggy platform.
fixes #5866
refs #6417
2014-06-12 17:33:28 +00:00
159d765f14
Fix that calling ActionController::translate() throws an exception
...
Translating strings must not throw an exception
even if the given domain is not valid.
fixes #6432
2014-06-11 13:39:22 +02:00
06296f29d8
UI/Sparklines: Change sparkline code to serverside only
...
fixes #6124
2014-06-06 16:35:33 +02:00
e01629fe0b
ActionController: fix initial redirect
...
refs #6419
2014-06-06 08:32:21 +00:00
20b43a92f1
Dashboard: Better implementation of handling errors
...
refs #6412
2014-06-05 16:07:40 +02:00
151f058286
Dashboard: Display error message on failure
...
When no (default) configuration is available for dashboards
application dies not very gracefully. Display error message
and guid the user to the solution is a better way.
fixes #6412
2014-06-05 15:20:54 +02:00
1b3bb6cade
Web\Url: add getQueryString() and without()
2014-06-05 03:44:12 +00:00
99aae5a0d9
JS/XHR: get ready to get XHR redirect-aware
...
These are just the first steps, there is more to come
2014-06-05 03:37:36 +00:00
c592236258
vendorlibs: library/vendor to libary/IcingaVendor
...
This doesn't make it much better but allows to build a package
libicinga-vendor-php placing those files to /usr/share/php/IcingaVendor
or similar.
refs #4075
2014-06-05 00:10:49 +00:00
79fb8b1e0d
Config: Remove base path subsitution
...
Test for leading slash and prepend base path to allow
absolute configuration files.
fixes #5556
2014-06-02 14:54:31 +02:00
a379502b15
Preferences: Rename `showBenchmark' to `show_benchmark'
...
We use underscore_case notation for all configuration keys.
refs #4952
2014-06-02 13:33:55 +02:00
5cc69b53cf
Remove superfluous space in prefixedTimeSince
...
refs #5981
2014-05-29 13:11:01 +02:00
a66a1a4729
Refactor the timeSincePrefix and timeUntilPrefix functions
...
Instead of having two separate functions to get the prefix
and the formatted time interval the new functions return
both the prefix and the time interval.
refs #5981
2014-05-29 13:03:10 +02:00
7b0a48bef5
Rename timeUnless to timeUntil
...
refs #5981
2014-05-29 12:38:59 +02:00
d01a98b7e6
Fix some of the time-related grammar mistakes
...
This updates some of the messages to use "For"
instead of "Since" where appropriate.
fixes #5981
2014-05-29 11:30:08 +02:00
88460189cd
Encoding: no ASCII chars > 127 in HTTP headers
...
Had quite some trouble with this, decided to URL-encode titles and
notifications.
2014-05-28 21:34:36 +00:00
92f454c36d
Chart\InlinePie: locale-ignorant casts for floats
...
PHP respects locales (LC_NUMERIC) when casting floats to string. That
affected the generated HTML for our inline pie charts. This patch is
not that beautiful - but fixes this.
fixes #6348
2014-05-28 10:20:34 +00:00
360ac87550
Translation: add a module-aware translation helper
...
With this fix $this->translate works in our view scripts
refs #6338
2014-05-27 21:41:46 +00:00
70ba36aad6
notifications: improve client- and serverside
...
This is just a first step, trying to catch a few gotchas:
* it doesn't send notifications to the browser when issueing a redirect
as redirects can currently not be catched in jQuery response handlers
* it tries to find a better notification handling place in the response
handler (JS) - still imperfect
* it explicitely stores sessions once modified by notifications. Still
need to crosscheck whether this is really needed and how we can get
rid of this.
refs #6280
2014-05-26 14:41:47 +00:00
4e88a4e008
Web\Url: add a shift() method
...
This methods allows to retrieve an URL param while removing it from the
URL object
2014-05-20 13:49:35 +00:00
b447225512
Web\Form: Revert "Fix subForm functionality"
...
This reverts commit 51bac035ac
2014-05-20 13:10:18 +00:00
ef7bb0e794
It is a multistep page's responsibility whether it is shown to the user
...
refs #6136
2014-05-14 12:53:45 +02:00
754f854dd0
Multistep pages should know about their multistep form
...
refs #6136
2014-05-14 12:53:45 +02:00
1f942acd38
Fix multistep page creation
...
refs #6136
2014-05-14 12:53:45 +02:00
33d4142664
Make it possible to recreate a form
2014-05-14 12:53:44 +02:00
1637a19c23
Fix multistep form creation
...
refs #6136
2014-05-14 12:53:44 +02:00
429e09aae2
Multistep pages should not have random generated names
...
refs #6136
2014-05-14 12:53:44 +02:00
51bac035ac
Fix subForm functionality
2014-05-14 12:53:44 +02:00
de169c7bf5
Make it possible to disable form submit buttons forcefully
2014-05-14 12:53:44 +02:00
88e451402f
Redirect to /install when the setup.token exists but no config.ini
...
refs #6136
2014-05-14 12:53:44 +02:00
4cf5fe6fdd
Add multistep form
...
refs #6136
2014-05-14 12:53:44 +02:00
e1230eb8ae
Add style and view scripts for first prototype
...
refs #6136
2014-05-14 12:53:44 +02:00
d0c56126b8
Fix inline pie reload.
...
refs #6124
2014-05-07 17:03:27 +02:00
270181885c
Fix Url error for emty baseUrl, less function calls
2014-04-29 12:27:19 +00:00
e2ba172a8e
Make dashboard components using the ini writer class
...
fixes #5524
2014-04-29 11:30:53 +02:00
98ca15d1fb
Mark less important or non-testable code as skipped for code coverage
...
refs #6011
2014-04-28 14:06:41 +02:00
07da92ee42
Rewrite test for Icinga\Web\Url and fix some bugs
...
refs #6011
2014-04-28 14:06:40 +02:00
729c33c3cf
Add helpful documentation to Icinga\Web\ViewStream
2014-04-28 14:06:40 +02:00
c5c375e72d
Add test for Icinga\Web\MenuItem
...
refs #6011
2014-04-28 14:06:40 +02:00
290fe9eeb5
Rewrite test for Icinga\Web\Hook
...
refs #6011
2014-04-28 14:06:40 +02:00
2b15d35dec
Rewrite test for Icinga\Web\Form
...
refs #6011
2014-04-28 14:06:40 +02:00
21b949758f
Refactor ResourceForm tests
...
refs #6011
2014-04-28 14:06:38 +02:00
b16c6efa05
Add PieChart to display hosts and services, improve layout and fix flag
...
checkboxes
refs #5765
2014-04-28 09:48:06 +02:00
081b5072a6
Fix layout of MultiController views
...
refs #5765
2014-04-28 09:48:06 +02:00
d939e12ef9
Only XHR requests use the "inline" layout
2014-04-17 17:03:35 +00:00
83b26bc595
JS-less iFrame rendering improvements
2014-04-17 16:20:03 +00:00
4c8428423e
Convert existing mocks to Mockery-mocks (Part 1)
...
refs #4639
2014-04-11 17:03:45 +02:00
6056327c6d
Fix that it's not possible to set non-existing values in a session with setAll()
...
refs #4639
2014-04-09 16:18:51 +02:00
a1649a1f22
Refactor PreferencesStore and IniStore
...
refs #5682
2014-04-07 15:13:28 +02:00
a857af60be
Intendation
2014-04-07 12:03:53 +00:00
88cdf99934
More code style
2014-04-07 12:03:53 +00:00
d109046bc0
Fix that the general and logging form cannot write configuration changes
...
fixes #5952
2014-04-07 09:27:37 +02:00
8be3ccc527
Make it possible to save the session by its associated session namespaces
2014-04-04 11:13:07 +02:00
98b640f1e0
Fix that removed values/namespaces remain in the session storage
...
fixes #5934
2014-04-04 11:10:45 +02:00
21b9c1f4af
Fix that filters are not preserved on timeline element urls
...
refs #4190
2014-04-01 14:26:10 +02:00
3d658a664c
Do not use logarithm base from session if the timeline is not being extended
...
refs #4190
2014-04-01 11:46:43 +02:00
b0709d8cba
Revert postDispatch -> preDispatch change in ActionController
...
refs #4190
2014-04-01 11:44:25 +02:00
aade2ab7f6
Move timeline classes into the monitoring module
...
refs #4190
2014-04-01 11:44:24 +02:00
0a146b4bb4
Clientside scrolling implementation [WIP]
...
refs #4190
2014-04-01 11:44:24 +02:00
40f70eb572
Fix license header
...
refs #4190
2014-04-01 11:44:24 +02:00
ba541b402d
Add timeline helper classes
...
#refs 4190
2014-04-01 11:44:23 +02:00
056b8d5395
Coding style
2014-03-31 16:30:27 +00:00
d3c4660c2d
Fix colors of svg charts in Firefox
2014-03-31 12:35:39 +02:00
5c89512e05
New router needs JavaScript and Stylesheet handlers fitting it's needs
2014-03-27 07:32:02 +00:00
2360f21b09
Fix InlinePie boundaries and use floats for the PieSlice path coordinates
...
Use floats as path coordinates in PieSlices, to
avoid that the start and ending position of the arc are at the exact same
position. This would cause buggy behavior, when displaying values like "99,999%".
refs #5863
2014-03-26 17:06:21 +01:00
15723f088b
Include SVG piecharts in perfData helpers
...
When no JavaScript is available, SVG piecharts will be shown instead of the
jQuery sparklines.
fixes #5865
2014-03-26 14:56:35 +01:00
faec625912
Ship module JS files even with minified JS
2014-03-26 09:24:27 +00:00
eeaec20873
Add support for server-side triggered CSS reload
2014-03-26 07:58:00 +00:00
87f90b6bdd
Replace escaped ampersands in URLs with & for redirects
...
* NB: Icinga\Web\Url could provide a method for this
2014-03-26 07:56:30 +00:00
18b825a24b
Add missing keyword "new" in class SessionNamespace
2014-03-25 13:24:06 +01:00
f802b36ca9
Move session class files
2014-03-25 11:13:10 +01:00
9ab53558f0
Add helper to get window-aware session namespaces
2014-03-25 11:13:10 +01:00
9c5eb19af6
Re-add potentially obsolete dynamic Widget properties
2014-03-25 07:23:14 +00:00
01f94c574d
Handle window-id requests, allowing us to identify distinct windows
2014-03-21 13:27:44 +00:00
3059228378
Fix JS support for modules
2014-03-20 09:55:29 +00:00
e355415164
Fix that queryfilters are being ignored by the parser
2014-03-19 09:11:25 +01:00
58248c34a9
Remove width & height settings from dashboard components
2014-03-17 17:43:45 +00:00
ebbd4119c2
New approach for view helpers - register anonymous functions
...
* May be subject to change
* TODO: Find out how to phpDoc them
* Removed a bunch of "old-style" view helpers
* more to come
2014-03-17 17:14:16 +01:00
757570cdc2
Improve Action Controller postDispatch readability
2014-03-17 17:11:08 +01:00
Johannes Meyer
Thomas Gelf
Matthias Jentsch
Marius Hein
Eric Lippmann
Gunnar Beutner