Commit Graph

451 Commits

Author SHA1 Message Date
Johannes Meyer 3573908071 Let downtime view look more list-like and fix downtime end calculation
refs #6637
2014-08-19 17:03:35 +02:00
Alexander Klimov 65473ac8ee Monitoring config: use SecurityForm
refs #6641
2014-08-19 14:04:00 +02:00
Alexander Klimov 0464099764 Monitoring: implement "Security" config tab 2014-08-19 11:19:30 +02:00
Johannes Meyer 332be22f7e Fix object history dates make output look similar to the event history
refs #6637
2014-08-18 15:32:12 +02:00
Johannes Meyer bbddb9ed87 Add limit-control and fix indentation of the eventhistory view
refs #6637
2014-08-18 15:30:59 +02:00
Johannes Meyer 043688e514 Make event history view more fancier
refs #6637
2014-08-15 17:03:03 +02:00
Johannes Meyer cae84a5d7f Fix float formatting of timeline circle margins and widths
fixes #6926
2014-08-15 13:39:02 +02:00
Johannes Meyer dc8181cdc5 Escape linefeeds and carriage returns in commands and show them as html
fixes #6088
2014-08-14 10:23:04 +02:00
Johannes Meyer b5d6481c12 Make it possible to translate the process info view
refs #6610
2014-08-13 15:52:33 +02:00
Johannes Meyer be14844fa8 Merge EditInstanceForm with CreateInstanceForm and rename it
As with the backend form, a user might like to change the name of an
instance. The new form and its actions are also adjusted to suit the new form interface.

refs #5525
2014-08-11 14:49:42 +02:00
Johannes Meyer d7ed6bd249 Adjust removebackend-action to suit the new backend form interface
Drops additionally the ConfirmRemovalForm of the monitoring module
as there is already one in icingaweb2's form-set.

refs #5525
2014-07-25 16:00:38 +02:00
Johannes Meyer a78d11345b Adjust createbackend-action to suit the new backend form interface
refs #5525
2014-07-25 15:58:44 +02:00
Johannes Meyer b743cf8143 Adjust editbackend-action to suit the new backend-form interface
refs #5525
2014-07-25 14:55:36 +02:00
Alexander Klimov a4b7204e23 Contactgroups view: correct links to contacts detail pages
fixes #6514
2014-07-23 13:10:09 +02:00
Alexander Klimov a2809552f2 Do not use htmlspecialchars in view scripts
fixes #6759
2014-07-23 12:41:05 +02:00
Eric Lippmann 9269a0cbd5 Revert "Do not use htmlspecialchars in view scripts"
This reverts commit 607aa9b203.

`Perfdata::escape()' does not exist. But `Perfdata::view::escape()' does.
2014-07-23 12:29:27 +02:00
Alexander Klimov 607aa9b203 Do not use htmlspecialchars in view scripts
fixes #6759
2014-07-23 12:12:49 +02:00
Matthias Jentsch cb27a3d0f1 Do not use height and width in bar charts, to avoid layout errors 2014-07-22 17:57:40 +02:00
Matthias Jentsch 53c9292b41 Fix BarChart padding in Dashboard
Use max-width instead of width in the chart layout to make better use of the available space, but prevent the charts from growing too big. Use a bigger weight and height in the default dashboard configuration.

fixes #6744
2014-07-21 13:06:35 +02:00
Alexander Klimov f9a274d079 Add contact detail view
refs #4804
refs #6514
2014-07-18 17:35:24 +02:00
Alexander Klimov 882699201d Contacts: replace foreach loop with hardcoded HTML and move the styles to a CSS file 2014-07-17 17:33:45 +02:00
Alexander Klimov eca0d50bae Don't use printf format strings as array keys
An array with printf format strings as keys looks pretty ugly
2014-07-17 11:26:18 +02:00
Alexander Klimov b23e36aa1a Swap array keys and values
Non-hardcoded keys may be not unique
2014-07-16 17:54:06 +02:00
Alexander Klimov 62da942159 Don't close and re-open php tags, remove unneeded spaces
To close and re-open php tags makes no sense if there's nothing between them
2014-07-16 17:54:06 +02:00
Alexander Klimov 1ad263170e Revert "Small fixes"
This reverts commit 8086292b1b.

The commit included too many changes.
2014-07-16 15:30:20 +02:00
Alexander Klimov cb04c42bab Use htmlspecialchars to prevent attacks 2014-07-16 13:10:28 +02:00
Alexander Klimov 8086292b1b Small fixes 2014-07-15 18:00:52 +02:00
Alexander Klimov 4c415aac5c Make contacts' view look more like contactgroups' view 2014-07-15 16:17:02 +02:00
Alexander Klimov d021ddebee Make contacts' view work like the downtimes' one
fixes #6513
2014-07-15 10:47:12 +02:00
Thomas Gelf 9a6821c860 monitoring/list/hosts: restore page behaviour
The problem here was that an accidentally removed closing div tag in
15325949 caused the application to missbehave badly. Host details where
rendered below the list in some scenarios and the whole multicolumn
thingy started to feel broken.
2014-07-08 15:17:00 +02:00
Thomas Gelf e3b2f15863 list/hosts: show unhandled services righthand
This way we automagically fix the problem with the wrong row links.
I guess we should re-introduce the "row-action" class allowing "precedence"
rules, so also a link not being the first one in a row could act as "row-link".

Changed formatting / text output a little bit, IMO even more cure is needed.

fixes #6645
2014-07-04 18:13:44 +02:00
Matthias Jentsch d2098be625 Only display header when not in compact mode
fixes #6508
2014-07-04 12:45:17 +02:00
Matthias Jentsch 9a1b7179e1 Fix violations of coding guidelines 2014-06-30 12:33:51 +02:00
Matthias Jentsch 7fe056d03a Display note when host and service is not found
When the show/host and show/service views do not find a host or service,
don't show a non-working view, but display a error message

fixes #6469
2014-06-30 12:33:51 +02:00
Matthias Jentsch a2fa5c055c Display a message when a list view is empty
fixes #6469
2014-06-30 12:33:51 +02:00
Alexander Klimov 1532594948 Deduplicate code: lists/hosts.phtml VS lists/hosts-compact.phtml
fixes #6541
2014-06-27 11:53:08 +02:00
Thomas Gelf c85a0ac11e list/limits: special treatment for 0 only, not null 2014-06-26 00:39:10 +02:00
Thomas Gelf d44f89f287 list/hosts: fix downtime icon
I re-enabled host list icons, they have been missing for a while. The
downtime icon logic used to be inverted, this fixes it. Also showing
acknowledgements now even if object is in downtime.
2014-06-25 21:46:03 +02:00
Thomas Gelf ff9c29472e monitoring/status: re-introduce comments, problems
This re-introduces expensive columns been disabled time ago and adds
even more to it. We are now showing last comment, last ack comment and
service problem count on hosts in list views.

It still costs performance, but seems that we can stand it. I'd like
to add more like this to the host view.
2014-06-25 21:42:24 +02:00
Thomas Gelf 86f70e0a4f list/services: don't count with no limit
This is a performance evaluation right now, we might delegate such
logic to paginator later on. Cuts load time for lists and/or dashlets
with complicated filters by 50% - only for those with limit=0 of course.
2014-06-25 20:45:08 +02:00
Matthias Jentsch ae4aa9c182 Fix violations of coding guidelines 2014-06-25 15:07:39 +02:00
Matthias Jentsch 35a5431512 Revert "Refractor InlinePie and Perfdata helper"
This reverts commit f003c38abd.
2014-06-25 14:29:17 +02:00
Matthias Jentsch f003c38abd Refractor InlinePie and Perfdata helper
Refractor InlinePie methods for better usability, fix several coding guideline
issues and fix some typos
2014-06-25 12:41:17 +02:00
Thomas Gelf 532ab60b36 monitoring/show/history: fix html on empty list
This view script used to render broken HTML on empty result
2014-06-24 21:23:51 +02:00
Thomas Gelf 51c57520ad iconSubmitForm: replace with labelSubmitForm
There is no way in ZF to have an input[type=submit] with an unescaped
label ( = value). I temporarily replaced all iconSubmitForms with
inputs labelled with "X" - as all we used them for were delete
operations.
2014-06-23 14:42:26 +02:00
Matthias Jentsch 010466f8f9 Replace sizeof with count
Do not use sizeof to get the length of an array, as the function name 'sizeof'
is misleading
2014-06-23 14:19:55 +02:00
Matthias Jentsch bde6e29c61 Display a message instead of empty service matrix
refs #6535
2014-06-23 12:24:27 +02:00
Thomas Gelf b03307196a monitoring/list/services: hardcode margin once again 2014-06-21 05:27:10 +02:00
Thomas Gelf 7f53ba11cf Hook\Grapher: use it in monitoring/show 2014-06-21 04:13:14 +02:00
Thomas Gelf 7b5d7bdbcf monitoring/statehistorysummary: filter fixes
Slightly adjusted filter string to fit new filters, fixed an issue
with 'object_type' column in virtual eventhistory table.
2014-06-21 03:18:00 +02:00
Thomas Gelf b3cdeee35d monitoring/timeline: should benefit from new filter
Different changes have been applied:

* Allow integer unix timestamps as parameters for timestamp columns
* Remove alias-rewriting from Url class
* Remove all traces of raw_timestamp
* Use new filters
2014-06-21 03:09:40 +02:00
Thomas Gelf 6d7a1cfe08 list/services: remove hardcoded margin 2014-06-20 19:12:46 +02:00
Thomas Gelf 127b728a4c list/notifications: fix query, select columns, style 2014-06-20 19:12:10 +02:00
Thomas Gelf 4821c6e3e5 monitoring/show/history: use limiter, nicer output 2014-06-20 14:02:03 +02:00
Thomas Gelf 65db5c4acc list/services: move filterEditor to content
As it may occupy quite some space it is better having it scrollable
2014-06-20 13:50:25 +02:00
Thomas Gelf 1bddcd7282 list/hosts,services: use limiter widget 2014-06-20 13:49:50 +02:00
Thomas Gelf f4b7075293 monitoring/multi: view script cleanup
They now play fine with new filters, tried to improve usability
2014-06-20 13:46:09 +02:00
Thomas Gelf 0642c9d33c monitoring/list/hosts: filter-related cleanup 2014-06-20 13:24:32 +02:00
Thomas Gelf 5dfd4aedac monitoring/downtime: add missing ticket hook
We used to have this when showing comments, but not for downtimes.
2014-06-20 12:37:09 +02:00
Thomas Gelf 21febddad2 Widget\Filter*: rudimentary filter widgets
Initial implementation, more to come
2014-06-17 14:00:38 +00:00
Thomas Gelf 1a91f0369e list/servicematrix: adjust URLs to fit new filters 2014-06-17 13:37:29 +00:00
Thomas Gelf ef4403f204 monitoring/show/history: make it look better
Supporting newly implemented history states (comment removal...),
prepare for translation, better styling.
2014-06-17 13:32:12 +00:00
Thomas Gelf 517894d86f show/header.phtml: try to look like other states 2014-06-17 13:22:52 +00:00
Gunnar Beutner a66a1a4729 Refactor the timeSincePrefix and timeUntilPrefix functions
Instead of having two separate functions to get the prefix
and the formatted time interval the new functions return
both the prefix and the time interval.

refs #5981
2014-05-29 13:03:10 +02:00
Gunnar Beutner 7b0a48bef5 Rename timeUnless to timeUntil
refs #5981
2014-05-29 12:38:59 +02:00
Gunnar Beutner d01a98b7e6 Fix some of the time-related grammar mistakes
This updates some of the messages to use "For"
instead of "Since" where appropriate.

fixes #5981
2014-05-29 11:30:08 +02:00
Thomas Gelf f790e0c323 Translation: keep translation domain with partial
We should try to avoid partial and pass translation domain where forced
to use it.

refs #6338
2014-05-27 22:20:21 +00:00
Thomas Gelf 7b58134378 show/history: sorry, typo 2014-05-27 22:16:45 +00:00
Thomas Gelf b47cec3e02 Translation: use translation for monitoring/views
Just a bunch of translation-helper calls

refs #6339
2014-05-27 21:44:02 +00:00
Thomas Gelf 40e45a2a39 monitoring/lists: Don't render unexistant controls
Even PHP code in HTML comments will be executed. As the filter object
sometimes failes, this can result in an invisible "breaking" exception.

refs #6031
2014-05-26 14:57:18 +00:00
Thomas Gelf 79f3b32474 monitoring/viewscripts: avoid errors in comments
PHP code may cause errors even if sitting in HTML comments. Also fixed a
HTML nesting error in list/servicematrix and reduced indentation.
2014-05-20 22:26:21 +00:00
Michael Friedrich d155c7a3fc Fix checks for empty check source attribute
refs ##5814
2014-05-20 23:46:33 +02:00
Michael Friedrich ef2ac077c8 Fix typo in flapping note 2014-05-20 23:45:48 +02:00
Thomas Gelf 941ff2a980 monitoring/show: remove CheckSource helper
It isn't doing anything but escape, so we can safely skip it.
2014-05-20 20:39:02 +00:00
Michael Friedrich 9fbdb65a4b Add check source to host/service details
refs #5814
2014-05-20 20:07:09 +02:00
Thomas Gelf 8f77ce607e show/services: don't navigate to the right
When using list/services for show/services (services for a single host)
we us an ugly PREG-based hack fixing the base link target. This got
broken by the multiselect feature, now it's working again. We need a
better solution for this.
2014-05-20 13:53:36 +00:00
Thomas Gelf 33e326a232 list/services: ignore broken service image hacks
People used to configure something like "dot.png'> <img ..." as their
service image icon. Those hacks will no longer work as we correctly
escape everything. This fix hinders Icingaweb from even trying to load
them.
2014-05-20 13:31:13 +00:00
Matthias Jentsch d0c56126b8 Fix inline pie reload.
refs #6124
2014-05-07 17:03:27 +02:00
Matthias Jentsch c641988233 Preserve multiselection during refresh
refs #5765
2014-04-28 09:48:06 +02:00
Matthias Jentsch b791883fa8 Fix configuration checkboxes and colors in piecharts
refs #5765
2014-04-28 09:48:06 +02:00
Matthias Jentsch b16c6efa05 Add PieChart to display hosts and services, improve layout and fix flag
checkboxes

refs #5765
2014-04-28 09:48:06 +02:00
Matthias Jentsch 081b5072a6 Fix layout of MultiController views
refs #5765
2014-04-28 09:48:06 +02:00
Matthias Jentsch cb630d45ad Fix issues issues with javascript multiselection
refs #5765
2014-04-28 09:48:05 +02:00
Matthias Jentsch 6d303f1c42 Add abillity for multi and range-selection to events.js
Add the abillity to select multiple rows, with a multi-selection using the
CTRL-key or a range-selection using the shift-key. Also fix several issues in
the Multi-Controller of the Backend.

refs #5765
2014-04-28 09:48:05 +02:00
Johannes Meyer 21b9c1f4af Fix that filters are not preserved on timeline element urls
refs #4190
2014-04-01 14:26:10 +02:00
Johannes Meyer 2049e42988 Show a horizontal line when the timeline switches its context
refs #4190
2014-04-01 11:46:44 +02:00
Johannes Meyer 80b4e3bf33 Add infinite scrolling to the timeline
refs #4190
2014-04-01 11:46:44 +02:00
Johannes Meyer c94cd40b92 Center timeframe elements vertically
refs #4190
2014-04-01 11:46:44 +02:00
Johannes Meyer e3be5dd255 Restructure timeline layout and styles
refs #4190
2014-04-01 11:46:44 +02:00
Johannes Meyer 8e7d1dd8f6 Improve timeline style
refs #4190
2014-04-01 11:46:44 +02:00
Johannes Meyer f5e4331d71 Add timeline view script and styles
refs #4190
2014-04-01 11:46:43 +02:00
Johannes Meyer 18b5f715c5 Refactor timeline components
refs #4190
2014-04-01 11:44:25 +02:00
Johannes Meyer b22f3f6b47 The timeline object is NOT a form
refs #4190
2014-04-01 11:44:24 +02:00
Johannes Meyer 5e945e3194 Make interval selection being a widget
refs #4190
2014-04-01 11:44:24 +02:00
Johannes Meyer f93d67dfa3 Add timeline controller
refs #4190
2014-04-01 11:44:23 +02:00
Thomas Gelf 41617e8119 Change forgotten title 2014-03-27 11:16:43 +00:00
Thomas Gelf 04cab7e0f8 Fix action target for downtime removal 2014-03-25 08:45:51 +00:00
Thomas Gelf 851bea0725 One more _self-targetting form 2014-03-25 08:03:12 +00:00
Thomas Gelf d4ccc68eab Remove sample graphite preview, should not have been pushed to master 2014-03-25 07:21:46 +00:00
Thomas Gelf b5b4d276d1 Add more structure to host and service details 2014-03-21 18:56:55 +00:00
Thomas Gelf f24e5eaa8a Stay on the same column when switching between services of the same host 2014-03-21 10:30:12 +00:00
Thomas Gelf 8a7ac587d9 Get rid of hardcoded target for action-tables 2014-03-21 10:27:46 +00:00
Thomas Gelf 4378282e9f Show additional custom columns in services list 2014-03-21 10:25:48 +00:00
Thomas Gelf 9517824b41 Better form target settings for more comfort 2014-03-20 16:33:06 +00:00
Thomas Gelf 3be2834af7 "Check now" should stay in the same container 2014-03-20 15:42:24 +00:00
Johannes Meyer bf717654f0 Add more consistency to the servicematrix when switching pages 2014-03-20 11:30:55 +01:00
Johannes Meyer aa6d6b1d41 Make servicematrix x-axis header titles linking to filtered servicelist 2014-03-20 09:41:41 +01:00
Johannes Meyer 44950ea570 Fix servicematrix styling issues in firefox and ie 2014-03-20 09:22:29 +01:00
Johannes Meyer e9ec87b0e3 Refine styling of the servicematrix
refs #4180
2014-03-19 09:11:25 +01:00
Johannes Meyer 0227c6a49d Fix hosts without services being displayed in the servicematrix
refs #4180
2014-03-19 09:11:25 +01:00
Johannes Meyer c73928d7a8 Add pagination control to the servicematrix
refs #4180
2014-03-19 09:11:25 +01:00
Johannes Meyer 617b6822d7 Add pagination support to the servicematrix
refs #4180
2014-03-19 09:11:24 +01:00
Johannes Meyer 13b509bf4b Do not display hosts without any services in the servicematrix
refs #4180
2014-03-19 09:11:24 +01:00
Johannes Meyer 71f4b6960b Add servicematrix view
refs #4180
2014-03-19 09:11:24 +01:00
Thomas Gelf 5dd06d8132 Host detail view should also point to _next 2014-03-17 16:36:38 +00:00
Thomas Gelf e0c93d6ca7 JS cleanup
* Precedence rules: skip autorefresh if click is pending
* Clean up the attr VS data mess
* More steps towards a column-count-ignorant GUI
2014-03-17 17:10:03 +01:00
Alexander Klimov 5c3df3db15 Handle not readable monitoring config files more intelligent 2014-03-13 15:54:27 +01:00
Alexander Klimov fbd354fa55 Small view changes 2014-03-12 11:22:20 +01:00
Alexander Klimov 5c0441bc06 Re-design configuration interface 2014-03-11 17:13:42 +01:00
Johannes Meyer e291974e55 Refine tactical overview style 2014-03-10 15:09:53 +01:00
Thomas Gelf 448d7c1a8d Fix PDF output wherever it works, disable dead filter control 2014-03-10 01:24:45 +01:00
Thomas Gelf e54c91c2f7 Restyle process info and shorten performance info 2014-03-10 00:49:21 +01:00
Thomas Gelf 5962fd71d0 Fix erranous table row title 2014-03-10 00:48:23 +01:00
Thomas Gelf 62ff31d4ee Downtimes could look better, HTML still missing 2014-03-09 22:59:49 +01:00
Thomas Gelf 88859cb838 The next fat package: downtimes, everywhere 2014-03-09 21:58:01 +01:00
Thomas Gelf 2f8c6a37d3 Spacing, quick and dirty 2014-03-09 20:09:26 +01:00
Thomas Gelf 63fd074a4f Comments are still messy, clean up and fix adding / removing them 2014-03-09 19:29:23 +01:00
Thomas Gelf c7d3b38739 Comment list style 2014-03-09 18:02:12 +01:00
Michael Friedrich e947b4363b System->Performance: Add RuntimeVariables view helper for 'average_{,scheduled_}services_per_host' calculation. 2014-03-09 16:38:55 +01:00
Thomas Gelf 54162d9538 Fine-tune commment list 2014-03-09 13:41:31 +01:00
Thomas Gelf 6bea9e8b43 Style comment list 2014-03-09 12:10:05 +01:00
Thomas Gelf 7202e13837 Link to filtered contact group list unless we have show/contactgroup 2014-03-09 11:26:57 +01:00
Thomas Gelf 4d48f4fb0e Filter form restyle dirty preview 2014-03-09 02:03:06 +01:00
Thomas Gelf e6fc6375b5 Refactor acknowledgements, finally get rid of status component 2014-03-08 21:28:32 +01:00
Thomas Gelf a87925bbf6 Refactored notifications for object detail view 2014-03-08 21:02:22 +01:00
Thomas Gelf c41160405d Dedicated view script for object actions 2014-03-08 19:49:57 +01:00
Thomas Gelf b4aff8f39b Small HTML fix 2014-03-08 19:48:47 +01:00
Thomas Gelf 07f76a631a AVP table should not influence perfdata table sitting there 2014-03-08 19:48:07 +01:00
Thomas Gelf e2955c5af2 Remove obsolete files 2014-03-08 18:55:09 +01:00
Thomas Gelf 740df4ccac Cleaning up object downtimes. What a mess... :( 2014-03-08 18:28:19 +01:00
Thomas Gelf 8e44c66850 Style comment removal. Did it ever work? It doesn't... 2014-03-08 17:16:42 +01:00
Thomas Gelf dc865df3c4 Restyle "Check now" 2014-03-08 17:02:14 +01:00
Thomas Gelf 235d655808 One more #col2 2014-03-08 15:01:00 +01:00
Thomas Gelf 73a8e13fc8 Remove #col2 traces in the application code 2014-03-08 15:00:23 +01:00
Thomas Gelf e8118f9116 Host grid links should point to host view 2014-03-08 12:58:32 +01:00
Thomas Gelf 3f6e5e65d1 Fix HTML on no host found 2014-03-08 12:55:17 +01:00
Thomas Gelf 79fe20a95c No (row) links back in object history, as we are already there 2014-03-08 12:38:31 +01:00
Thomas Gelf 3e09931f2c Restyle object flags 2014-03-08 08:23:48 +00:00
Thomas Gelf d234a87e84 Introduce new detail section headers fitting the rest of the layout 2014-03-08 00:17:42 +00:00
Thomas Gelf d53573ede2 Host services view 2014-03-08 00:00:21 +00:00