Eric Lippmann
ebde422824
filter: Fix whitepsace sanitation when expression is an array
2014-10-01 04:00:43 +02:00
Eric Lippmann
46078f50db
filter: Fix that leading and trailing whitespaces for columns and expressions let filters fail
...
Before, filtering for "host = localhost" issued "got invalid column host".
2014-10-01 03:13:27 +02:00
Eric Lippmann
1c7eb0d59a
lib: Introduce function `String::cname()'
2014-09-30 22:34:58 +02:00
Matthias Jentsch
8eb7db9b35
Avoid type warning when using array_combine on empty arrays
2014-09-30 15:54:38 +02:00
Johannes Meyer
ab8436dea8
Fix Icinga\Web\Form\Element\Note using its default decorators
2014-09-29 16:12:38 +02:00
Alexander Fuhr
dacbd329dd
Translator: Implement domain fallback for translate and translatePlural
2014-09-29 15:56:48 +02:00
Alexander Fuhr
b2f12e1caa
Revert "lib: Remove form element `Note'"
...
This reverts commit c21d7d1fdd
.
2014-09-26 16:19:44 +02:00
Alexander Fuhr
c8a24f72b8
Introduce getValue() in Preferences and fix the loading of values
2014-09-26 14:15:50 +02:00
Eric Lippmann
cde3ec6bc8
Merge branch 'master' into bugfix/commands-6593
...
Conflicts:
modules/monitoring/application/controllers/TimelineController.php
2014-09-23 22:54:17 -07:00
Alexander Fuhr
07a4b25560
Merge branch 'master' into bug/history-notification-time-format-6980
2014-09-23 11:38:24 +02:00
Alexander Fuhr
e784aa34b6
Implement DateTimeRenderer and fix history time format
...
refs #6980
2014-09-23 11:36:09 +02:00
Matthias Jentsch
6c8f324dd4
Add filter widget to StateHistorySummary and fix some minor bugs
...
fixes #6979
2014-09-19 17:41:44 +02:00
Matthias Jentsch
4ce71ef2f2
Display a tooltip on days without events
2014-09-19 17:41:44 +02:00
Matthias Jentsch
6f1cb6f1f3
Adjust brightness for different event type colors
2014-09-19 17:41:44 +02:00
Matthias Jentsch
65203fddcf
Add additional state history filters for time interval and event type
2014-09-19 17:41:44 +02:00
Matthias Jentsch
ef2f332869
Do not refresh a container when form input was changed or a form element is focused
...
Listen for changes in form elements and abort all reloads that contain a form with
at least one changed form element. Do not refresh containers that contain a focused form
element, except of elements with autofocus, to preserve form elements with a dropdown.
Only focus autofocus elements when there is currently no other selection.
refs #7146
refs #5537
fixes #7162
2014-09-19 15:48:44 +02:00
Eric Lippmann
264d818133
Do not save config references in the `ActionController'
...
This is redundant because our `Config' class already caches loaded configs.
2014-09-19 14:44:21 +02:00
Eric Lippmann
119e23e79e
Make `InlinePie's setters fluent
2014-09-19 14:43:25 +02:00
Eric Lippmann
90dbcdbbfb
The stupid `DbQuery::isTimestamp()' hack must return false
...
This a fix for modules using our query / filter combination since `return $this;' renders all columns as timestamps.
2014-09-19 14:29:29 +02:00
Eric Lippmann
bea110d0c7
Fix `Form::isSubmitted()' for dynamic submit labels
2014-09-19 14:27:04 +02:00
Eric Lippmann
5b5f553d0d
form: Fix dynamic submit label retrieval
2014-09-19 13:39:38 +02:00
Eric Lippmann
c13823d406
bootstrap: Fix error reporting level not including E_STRICT
2014-09-19 13:19:24 +02:00
Eric Lippmann
c51b05296e
Merge branch 'master' into bugfix/commands-6593
2014-09-19 13:18:47 +02:00
Eric Lippmann
3c9859a0f1
Call `Form::getSubmitLabal()' in `Form::addSubmitButton()'
...
This allows us to dynamically define submit labels in form subclasses.
2014-09-19 13:00:15 +02:00
Eric Lippmann
5ba96c32f9
`Form::setDefaults()' fix strict standards violation
...
Declaration of Icinga\Web\Form::setDefaults() should be compatible with that of Zend_Form::setDefaults().
2014-09-19 12:59:01 +02:00
Eric Lippmann
7eb51f6367
form/csrf: Set the csrf element decorators in the element not in the form
2014-09-19 12:57:53 +02:00
Eric Lippmann
f1d3b72f05
autologin: Fix externally-authenticated users still being authenticated after external authentication is disabled
...
The if condition for revoking authentication if the username changed relied on having the `$_SERVER' variable set which was used for authentication.
Authentication is now revoked if the username changed or external authentication is no longer in effect.
refs #6462
2014-09-18 15:20:46 +02:00
Eric Lippmann
854e284d42
autologin: Don't use `count()' for is empty checks
...
Using `count()' in favor of `empty()' for empty checks on arrays is bad habit.
While there's literally no performance gain in the "fixed" scenario, there's one on large arrays
and thus should be avoided everywhere.
refs #6462
2014-09-18 15:18:01 +02:00
Eric Lippmann
794910256a
Use `User::can()' in `hasPermission()' of the authentication manager
2014-09-18 14:57:24 +02:00
Eric Lippmann
af58732545
Introduce `User::can()' for checking whether a user has a given permission
...
The authentication manager already has the `hasPermission()' method but it lacks wildcard support
and uses stupid looping. Implementing this method on the user further saves a call to `User::getPermissions()'.
2014-09-18 14:37:18 +02:00
Eric Lippmann
d091e2150c
Fix `ActionController::prepareInit()' php doc
2014-09-16 18:43:14 +02:00
Alexander Fuhr
b38ef9c0bd
Implement plural and context based translation functionality
...
refs #6982
2014-09-16 15:19:23 +02:00
Eric Lippmann
c21d7d1fdd
lib: Remove form element `Note'
...
Zend already provides this.
2014-09-16 09:54:23 +02:00
Eric Lippmann
5c647719e4
lib/ModuleActionController: Fix stupid code
2014-09-16 09:29:03 +02:00
Eric Lippmann
f8edb4f220
lib: Add method `ActionController::prepareInit()'
...
As it should not be required for controllers to call the parent's init() method, base controllers should use
prepareInit() in order to prepare the controller initialization.
2014-09-16 09:28:10 +02:00
Alexander Fuhr
e2b5e05f21
Implement plural translation (testing)
2014-09-15 14:11:42 +02:00
Eric Lippmann
8bf66425d1
Merge branch 'master' into bugfix/commands-6593
2014-09-15 09:27:56 +02:00
Eric Lippmann
9e0d6657b7
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
...
Conflicts:
application/forms/Preference/GeneralForm.php
2014-09-15 09:27:07 +02:00
Alexander Fuhr
f48094f01a
Merge branch 'master' into feature/translation-plurals-6982
2014-09-15 08:34:19 +02:00
Matthias Jentsch
1932a912f8
Fix month-naming for different week arrangements
...
fixes #7179
2014-09-12 11:51:51 +02:00
Matthias Jentsch
6c3c466f92
Start history grid weeks at monday
...
Add configuration option for week-start and set the default to Monday.
2014-09-12 11:51:51 +02:00
Matthias Jentsch
e42b7b3026
Display current weeks at the beginning of the history grid
...
fixes #7179
2014-09-12 11:51:51 +02:00
Eric Lippmann
beecf16ad0
lib: Add `InvalidPropertyException'
2014-09-12 10:18:48 +02:00
Thomas Gelf
8ceef96d28
Web\Hook: remove unused methods
2014-09-12 09:53:38 +02:00
Thomas Gelf
93777ac15e
Web/Response: use & to encode XHR redirection URLs
2014-09-12 09:28:11 +02:00
Matthias Jentsch
ad53f7ad3d
Use EventEmitter class as a way to delegate events from behaviors to the dom
2014-09-12 09:09:21 +02:00
Thomas Gelf
0e926ba05e
Revert "Revert "Web\Hook: register('grapher')
...
This reverts commit 65564cda65
.
The test was wrong, not the code.
2014-09-12 09:02:23 +02:00
Alexander Fuhr
583fd46f15
Experimental Plural Translation Implementation
...
Personal BACKUP
2014-09-11 18:04:10 +02:00
Alexander Fuhr
65564cda65
Revert "Web\Hook: register('grapher') => GrapherHook"
...
This reverts commit 4a89c2e163
.
2014-09-11 15:00:28 +02:00
Matthias Jentsch
9376ceed33
Add missing use-statement for Exceptions in MenuRenderer
...
fixes #7157
2014-09-10 17:12:19 +02:00
Matthias Jentsch
f58da73e2d
Move javascript behaviors into separate classes
2014-09-10 17:02:39 +02:00
Matthias Jentsch
d99d50b3c4
Add stub for javascript behaviors
2014-09-10 17:02:38 +02:00
Thomas Gelf
ea63dad087
viewHelpers: use the view
...
refs #7177
2014-09-10 16:56:26 +02:00
Thomas Gelf
631b3d9f6e
viewHelpers: There is no $this, not before 5.4
...
refs #7177
2014-09-10 16:54:57 +02:00
Thomas Gelf
c2fe0232ca
helpers/attributes: escape value
...
refs #7177
2014-09-10 16:07:00 +02:00
Matthias Jentsch
27960fc628
Catch exceptions in MenuItemRenderers
...
fixes #7157
2014-09-10 14:38:11 +02:00
Johannes Meyer
83772c6684
Merge branch 'master' into bugfix/rebuild-form-builder-5525
2014-09-09 16:03:22 +02:00
Matthias Jentsch
71f55e388f
Only display custom menu renders on XHR requests and not in regular HTML
...
The main navigation should be rendered without a working backend.
fixes #7143
2014-09-09 15:33:42 +02:00
Johannes Meyer
e7c021845d
Simplify subform usage
...
refs #5525
2014-09-09 15:00:33 +02:00
Johannes Meyer
9d8f810e10
Icinga\Web\Request::getParam() should be mocked as well by default
2014-09-09 13:01:09 +02:00
Johannes Meyer
d6377ca00c
Return bootstrap mock when calling BaseTestCase::setupIcingaMock()
2014-09-09 10:19:51 +02:00
Johannes Meyer
f7f6bcc447
Make Form base class more test friendly..
...
refs #5525
2014-09-09 09:31:15 +02:00
Johannes Meyer
c8ce1088c9
Disable checking whether a form is sent when form identification is disabled
...
refs #5525
2014-09-09 09:30:33 +02:00
Johannes Meyer
34bbe6508a
Remove form test functionality from BaseTestCase
...
BaseTestCase::createForm() is not required as the Form base class does
not have that much bloat anymore to have the need for a form factory.
2014-09-09 09:29:29 +02:00
Johannes Meyer
1137c010a8
Provide global request and response mocks
...
Prior to this change one had to overwrite setupIcingaMock or setUp to set
a specific mock as request or response. Now it is possible to do this for a
specific test without overwriting any method.
2014-09-09 09:24:38 +02:00
Matthias Jentsch
a352131d65
Move charts.less into widgets.less
...
Don't use a separate less file for only two styles
2014-09-08 16:25:11 +02:00
Matthias Jentsch
40611659ed
Fix disappearing tooltips on SVG reload
...
Use a unified linebreak in the chart controller, so the tooltip handling will recognize the titles as identical
2014-09-08 16:23:14 +02:00
Matthias Jentsch
0fd561928a
Remove cached version of dompdf log.htm from source control
2014-09-08 16:22:15 +02:00
Alexander Fuhr
7386ae5ef5
Update Module img_ route to get image subfolders
2014-09-08 11:31:05 +02:00
Matthias Jentsch
e8164c6da0
Show tooltips to describe menu badges
2014-09-08 10:38:02 +02:00
Eric Lippmann
0e7ca591ec
Merge branch 'master' into bugfix/commands-6593
...
Conflicts:
application/forms/Preference/GeneralForm.php
application/views/helpers/FormDateTime.php
modules/monitoring/application/forms/Command/CommandForm.php
2014-09-08 10:16:05 +02:00
Matthias Jentsch
e39dd64a1b
Fix layout of HistoryColorGrid
...
Use actual color for critical hosts and only display the first two letters of the weekday
2014-09-08 09:52:28 +02:00
Johannes Meyer
12b4865559
Fix incompatible declaration of Form::setDefaults()
...
PHP with strict standards: Declaration of Icinga\Web\Form::setDefaults()
should be compatible with that of Zend_Form::setDefaults()
refs #5525
2014-09-08 09:42:02 +02:00
Johannes Meyer
930e6e7d71
We shouldn't require Form::createElements() to return self
...
refs #5525
2014-09-08 09:24:53 +02:00
Johannes Meyer
ae9e5a40cc
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Preference/GeneralForm.php
2014-09-08 08:46:53 +02:00
Thomas Gelf
4a89c2e163
Web\Hook: register('grapher') => GrapherHook
2014-09-05 18:54:50 +02:00
Matthias Jentsch
51d14af154
Merge branch 'master' into feature/navigation-unhandled-badges-7114
...
Conflicts:
library/Icinga/Web/Menu.php
2014-09-05 18:14:29 +02:00
Matthias Jentsch
19eca5f50b
Show all unhandled host and services in a menu
...
Add the option to define custom renderers for menu items and implement renderers to
display all unhandled services and host in a badge in the navigation.
resolves #7114
2014-09-05 17:57:20 +02:00
Thomas Gelf
596800bd7d
helpers/url: overwrite existing params
2014-09-05 17:56:55 +02:00
Thomas Gelf
4bb065d9bb
Web\Menu: provide and render unique id
...
fixes #7083
2014-09-05 17:24:55 +02:00
Thomas Gelf
b034028ff8
Menu: do not show application log when none exists
...
Added new functions to the logger to get rid of distributed logging config
"knowledge".
fixes #7062
fixes #7098
2014-09-05 15:31:30 +02:00
Marius Hein
a300877878
Time detection: Add receiever to bootstrap method
...
refs #6078
2014-09-05 15:24:13 +02:00
Marius Hein
3ce42489c6
Timezone detection: Client implementation
...
refs #6078
2014-09-05 15:24:13 +02:00
Thomas Gelf
e205ca4d0b
FilterWidget: remove icon titles
...
fixes #7105
2014-09-05 14:50:22 +02:00
Alexander Klimov
52c1d98beb
Icinga\Protocol\File\FileReader: use Icinga\Util\Enumerate
2014-09-05 13:49:28 +02:00
Alexander Klimov
982cda6805
Implement Icinga\Util\Enumerate
2014-09-05 13:49:27 +02:00
Thomas Gelf
33d2175b77
Web\UrlParams: allow to merge single value
2014-09-05 13:35:51 +02:00
Thomas Gelf
baa775dd74
Web\Url: document with() method
2014-09-05 11:40:43 +02:00
Thomas Gelf
1c2207f51d
Web\Url: provide a with() function
2014-09-05 11:21:10 +02:00
Thomas Gelf
4c8407e2b6
Web\StyleSheet: outer #layout access for modules
...
fixes #7093
2014-09-05 10:56:26 +02:00
Thomas Gelf
b14e7f5696
LessCompiler: remove obsolete cache-related comment
2014-09-05 10:56:25 +02:00
Johannes Meyer
fc72ddfbc8
Adjust Preferences/GeneralForm to use handleRequest() &. Co.
...
refs #5525
2014-09-05 10:21:24 +02:00
Johannes Meyer
d021747bde
Fix form widgets
...
refs #5525
2014-09-05 09:17:09 +02:00
Johannes Meyer
8846f17ae1
Make it possible to disable form identification
...
refs #5525
2014-09-05 09:16:09 +02:00
Alexander Fuhr
ba623d0544
SearchDashboard: adjust SearchDashboardTest and rename searchQuery to searchString
2014-09-04 22:54:41 +02:00
Thomas Gelf
0f7f2f2d8b
SearchDashboard: rename ::load() to ::search()
...
Function signature didn't match parent factory function
fixes #7081
2014-09-04 19:35:31 +02:00
Thomas Gelf
0f8d5bddba
Web\Menu: make use of Web\Url
...
refs #7083
2014-09-04 19:18:09 +02:00
Thomas Gelf
f91892cb80
Web\Url: add matches() function
...
fixes #6992
2014-09-04 18:46:58 +02:00
Alexander Fuhr
e4d1143870
Add SearchDashboardTest
2014-09-04 18:31:08 +02:00
Alexander Klimov
70146c43e7
Icinga\Protocol\File\FileReader: implement Icinga\Data\Selectable, and Countable
2014-09-04 16:59:37 +02:00