f58da73e2d
Move javascript behaviors into separate classes
2014-09-10 17:02:39 +02:00
d99d50b3c4
Add stub for javascript behaviors
2014-09-10 17:02:38 +02:00
ea63dad087
viewHelpers: use the view
...
refs #7177
2014-09-10 16:56:26 +02:00
631b3d9f6e
viewHelpers: There is no $this, not before 5.4
...
refs #7177
2014-09-10 16:54:57 +02:00
c2fe0232ca
helpers/attributes: escape value
...
refs #7177
2014-09-10 16:07:00 +02:00
27960fc628
Catch exceptions in MenuItemRenderers
...
fixes #7157
2014-09-10 14:38:11 +02:00
83772c6684
Merge branch 'master' into bugfix/rebuild-form-builder-5525
2014-09-09 16:03:22 +02:00
71f55e388f
Only display custom menu renders on XHR requests and not in regular HTML
...
The main navigation should be rendered without a working backend.
fixes #7143
2014-09-09 15:33:42 +02:00
e7c021845d
Simplify subform usage
...
refs #5525
2014-09-09 15:00:33 +02:00
9d8f810e10
Icinga\Web\Request::getParam() should be mocked as well by default
2014-09-09 13:01:09 +02:00
d6377ca00c
Return bootstrap mock when calling BaseTestCase::setupIcingaMock()
2014-09-09 10:19:51 +02:00
f7f6bcc447
Make Form base class more test friendly..
...
refs #5525
2014-09-09 09:31:15 +02:00
c8ce1088c9
Disable checking whether a form is sent when form identification is disabled
...
refs #5525
2014-09-09 09:30:33 +02:00
34bbe6508a
Remove form test functionality from BaseTestCase
...
BaseTestCase::createForm() is not required as the Form base class does
not have that much bloat anymore to have the need for a form factory.
2014-09-09 09:29:29 +02:00
1137c010a8
Provide global request and response mocks
...
Prior to this change one had to overwrite setupIcingaMock or setUp to set
a specific mock as request or response. Now it is possible to do this for a
specific test without overwriting any method.
2014-09-09 09:24:38 +02:00
a352131d65
Move charts.less into widgets.less
...
Don't use a separate less file for only two styles
2014-09-08 16:25:11 +02:00
40611659ed
Fix disappearing tooltips on SVG reload
...
Use a unified linebreak in the chart controller, so the tooltip handling will recognize the titles as identical
2014-09-08 16:23:14 +02:00
0fd561928a
Remove cached version of dompdf log.htm from source control
2014-09-08 16:22:15 +02:00
7386ae5ef5
Update Module img_ route to get image subfolders
2014-09-08 11:31:05 +02:00
e8164c6da0
Show tooltips to describe menu badges
2014-09-08 10:38:02 +02:00
0e7ca591ec
Merge branch 'master' into bugfix/commands-6593
...
Conflicts:
application/forms/Preference/GeneralForm.php
application/views/helpers/FormDateTime.php
modules/monitoring/application/forms/Command/CommandForm.php
2014-09-08 10:16:05 +02:00
e39dd64a1b
Fix layout of HistoryColorGrid
...
Use actual color for critical hosts and only display the first two letters of the weekday
2014-09-08 09:52:28 +02:00
12b4865559
Fix incompatible declaration of Form::setDefaults()
...
PHP with strict standards: Declaration of Icinga\Web\Form::setDefaults()
should be compatible with that of Zend_Form::setDefaults()
refs #5525
2014-09-08 09:42:02 +02:00
930e6e7d71
We shouldn't require Form::createElements() to return self
...
refs #5525
2014-09-08 09:24:53 +02:00
ae9e5a40cc
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Preference/GeneralForm.php
2014-09-08 08:46:53 +02:00
4a89c2e163
Web\Hook: register('grapher') => GrapherHook
2014-09-05 18:54:50 +02:00
51d14af154
Merge branch 'master' into feature/navigation-unhandled-badges-7114
...
Conflicts:
library/Icinga/Web/Menu.php
2014-09-05 18:14:29 +02:00
19eca5f50b
Show all unhandled host and services in a menu
...
Add the option to define custom renderers for menu items and implement renderers to
display all unhandled services and host in a badge in the navigation.
resolves #7114
2014-09-05 17:57:20 +02:00
596800bd7d
helpers/url: overwrite existing params
2014-09-05 17:56:55 +02:00
4bb065d9bb
Web\Menu: provide and render unique id
...
fixes #7083
2014-09-05 17:24:55 +02:00
b034028ff8
Menu: do not show application log when none exists
...
Added new functions to the logger to get rid of distributed logging config
"knowledge".
fixes #7062
fixes #7098
2014-09-05 15:31:30 +02:00
a300877878
Time detection: Add receiever to bootstrap method
...
refs #6078
2014-09-05 15:24:13 +02:00
3ce42489c6
Timezone detection: Client implementation
...
refs #6078
2014-09-05 15:24:13 +02:00
e205ca4d0b
FilterWidget: remove icon titles
...
fixes #7105
2014-09-05 14:50:22 +02:00
52c1d98beb
Icinga\Protocol\File\FileReader: use Icinga\Util\Enumerate
2014-09-05 13:49:28 +02:00
982cda6805
Implement Icinga\Util\Enumerate
2014-09-05 13:49:27 +02:00
33d2175b77
Web\UrlParams: allow to merge single value
2014-09-05 13:35:51 +02:00
baa775dd74
Web\Url: document with() method
2014-09-05 11:40:43 +02:00
1c2207f51d
Web\Url: provide a with() function
2014-09-05 11:21:10 +02:00
4c8407e2b6
Web\StyleSheet: outer #layout access for modules
...
fixes #7093
2014-09-05 10:56:26 +02:00
b14e7f5696
LessCompiler: remove obsolete cache-related comment
2014-09-05 10:56:25 +02:00
fc72ddfbc8
Adjust Preferences/GeneralForm to use handleRequest() &. Co.
...
refs #5525
2014-09-05 10:21:24 +02:00
d021747bde
Fix form widgets
...
refs #5525
2014-09-05 09:17:09 +02:00
8846f17ae1
Make it possible to disable form identification
...
refs #5525
2014-09-05 09:16:09 +02:00
ba623d0544
SearchDashboard: adjust SearchDashboardTest and rename searchQuery to searchString
2014-09-04 22:54:41 +02:00
0f7f2f2d8b
SearchDashboard: rename ::load() to ::search()
...
Function signature didn't match parent factory function
fixes #7081
2014-09-04 19:35:31 +02:00
0f8d5bddba
Web\Menu: make use of Web\Url
...
refs #7083
2014-09-04 19:18:09 +02:00
f91892cb80
Web\Url: add matches() function
...
fixes #6992
2014-09-04 18:46:58 +02:00
e4d1143870
Add SearchDashboardTest
2014-09-04 18:31:08 +02:00
70146c43e7
Icinga\Protocol\File\FileReader: implement Icinga\Data\Selectable, and Countable
2014-09-04 16:59:37 +02:00
3c4a719feb
Revert "Icinga\Protocol\File\FileReader: implement Icinga\Data\Selectable, ...\Fetchable and Countable"
...
This reverts commit 7edbb8f27216e6faa0d0dc5a71b407748e9dd535.
2014-09-04 16:55:02 +02:00
876b94cccf
Icinga\Protocol\File\FileReader: implement Icinga\Data\Selectable, ...\Fetchable and Countable
2014-09-04 16:54:14 +02:00
f0969e0b2e
Split Icinga\Protocol\File\FileReader into ...\FileReader and ...\FileIterator
2014-09-04 16:37:26 +02:00
fcd12073f8
Rename Icinga\Protocol\File\Query to ...\File\FileQuery
2014-09-04 16:37:25 +02:00
36a3c36c1b
Rename Icinga\Protocol\File\Reader to ...\File\FileReader
2014-09-04 16:37:24 +02:00
1eacde0233
Implement modules self provided search configuration
...
refs #6495
2014-09-04 16:31:10 +02:00
c8eaf66823
GrapherHook: Rework hook
...
refs #6932
2014-09-04 14:00:48 +02:00
4fb47ef768
Hook classes: Add class suffix if not exist
...
refs #7066
refs #7067
refs #7068
2014-09-04 14:00:48 +02:00
eeed030bb5
Do not use an invalid HTML attributes for rich titles
2014-09-04 13:32:30 +02:00
c3c0043307
Merge branch 'master' into bugfix/commands-6593
2014-09-03 23:23:20 +02:00
a4da3b61b3
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
2014-09-03 23:23:02 +02:00
2eccc6188f
Merge branch 'master' into bugfix/rebuild-application-log-logic-7060
2014-09-03 19:08:40 +02:00
ede5b8f0b9
Icinga\Protocol\File\Reader::fetchPairs(): increase $index manually as the iterator's one makes trouble
...
refs #7060
2014-09-03 18:36:59 +02:00
da85112538
Merge branch 'master' into feature/svg-chart-tooltips-7024
2014-09-03 17:08:00 +02:00
37b168995b
Rename tipsy stylesheet file type to css and add license
2014-09-03 17:01:07 +02:00
e45f50408a
Icinga\Protocol\File\Reader::fetchPairs(): rename variables
...
$skipLines -> $skip
$readLines -> $read
refs #7060
2014-09-03 16:14:14 +02:00
b10b1ea034
Add jQuery tooltips
2014-09-03 15:53:56 +02:00
88dde47b7a
Foreach: add $value so that the value won't be assigned to $key
...
refs #7060
2014-09-03 15:39:25 +02:00
2025fb3a2f
lib: Let the date-and-time input control behave as defined in HTML5
...
refs #6593
2014-09-03 14:40:58 +02:00
acbd2bd7c0
Merge branch 'master' into feature/dashboard-component-disabled-property-6986
2014-09-03 14:40:30 +02:00
906de4e679
lib: Add the HTML5 attributes 'min', 'max' and 'step' to the number input control
...
refs #6593
2014-09-03 14:39:42 +02:00
774db9a7c8
lib: Add function `isUnixTimestamp' to the `DateTimeFactory'
...
Before, the `DateTimeValidator' defined this function.
refs #6593
2014-09-03 14:37:33 +02:00
1a4e908461
lib: Let `DateTimeValidator' validate values as defined in HTML5
...
See http://www.w3.org/TR/html-markup/datatypes.html#common.data.datetime for the specification.
refs #6593
2014-09-03 14:36:18 +02:00
7cfc051228
Add tests for Dashboard and fix doc blocks
...
refs #6986
2014-09-03 14:36:04 +02:00
33669f8969
Logger: add/update documentation
...
refs #7060
2014-09-03 13:53:46 +02:00
54a834266c
Form::createElements() should add elements instead of returning them
...
In case createElements() would still return the elements while requiring
the caller to add them to the form all form dependent configurations get
lost. (displaygroups, belongTo, ...) Wizards or parent forms can still
retrieve only input relevant fields by just calling createElements() and
getElements().
refs #5525
2014-09-03 12:21:31 +02:00
1e06c20dcb
FileWriter: implement getPath()
...
refs #7060
2014-09-03 12:09:38 +02:00
6aeab59ead
Logger: implement getWriter() and getInstance()
...
refs #7060
2014-09-03 12:02:11 +02:00
70cf14f775
Logger: rename getWriter() -> createWriter()
...
refs #7060
2014-09-03 11:34:21 +02:00
3ade6da44d
FileReaderException: extend IcingaException
2014-09-03 11:14:22 +02:00
3d352ba446
Filter: add FilterNotEqual and FilterMatch
...
fixes #6557
2014-09-02 19:51:56 +02:00
0b1d2bf685
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
2014-09-02 17:09:36 +02:00
5485ca8a25
lib: Use Zend's `Int' validator in the `Number' form element
...
Further disabled default decorators since our form sets them.
refs #5525
2014-09-02 16:54:43 +02:00
b60b811335
ApplicationBootstrap: list "core" translations
...
Just to make application fit module capabilities. We might find a better
place for both later on.
refs #7054
2014-09-02 16:51:17 +02:00
95c839a8bd
Remove remaining usages of the ElementWrapper- and HelpText-Decorator
...
refs #5525
2014-09-02 16:50:59 +02:00
6faedf5733
ActionController: no benchmark for no renderer
...
Benchmarks should not be shown when the renderer is no longer available.
2014-09-02 16:49:28 +02:00
4cef333add
Modules\Module: implement listLocales
...
fixes #7054
2014-09-02 16:28:27 +02:00
e4687a60f9
Web\JavaScript: use Cache and ETags
...
refs #6927
2014-09-02 16:25:44 +02:00
1ba3df310c
Remove BaseConfigController, User\Message and Widget\AlertMesageBox
...
refs #6758
2014-09-02 16:25:03 +02:00
539ab91ffa
Add the FormErrors decorator as default decorator for forms
...
This allows us to use Zend_Form::addError() to show error messages for
the entire form context.
refs #5525
2014-09-02 16:25:03 +02:00
f0d6cf994e
Web\StyleSheet: use Cache and ETags
2014-09-02 16:24:55 +02:00
ff6483cec5
Web\FileCache: initial implementation
...
refs #6927
2014-09-02 16:22:48 +02:00
338f549233
Add class ReadablePathValidator
2014-09-02 16:19:45 +02:00
39bb01b433
Rename Icinga\Web\Form::onShow() to onRequest()
...
onShow() is misleading because at the time this method is being called the
form is neither shown nor created.
refs #5525
2014-09-02 16:19:45 +02:00
9bcd861b1c
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
2014-09-02 15:27:27 +02:00
d4c4ab7b2c
lib/form: Fix default element decorators but breaking noscript layout
...
Replaced `ElementWrapper' and `HelpText' with Zend's `HtmlTag' and `Label' respectively.
Instances of Zend_Form_Element returned by `Form::createElements()' now receive our desired default decorators.
refs #5525
2014-09-02 15:23:07 +02:00
8478ef3fce
lib: Remove `HelpText' form element decorator
...
Zend already has a `Description' decorator.
refs #5525
2014-09-02 15:05:47 +02:00
7143837ae3
lib: Remove `ElementWrapper' form element decorator
...
Zend has a `Label' decorator already.
refs #5525
2014-09-02 15:04:23 +02:00
62c0f0be03
Web\Session: implement lazy loading
...
fixes #7055
2014-09-02 13:23:15 +02:00
26339b128a
Add disabled property and implement the functionality
...
refs #6986
2014-09-02 13:16:21 +02:00
4b55bcf8b6
Add tooltips to bar charts
...
Add a class to format and populate tooltips from graph data sets and implement
those tooltips in the ChartController.
2014-09-02 12:24:29 +02:00
bb0e1dc105
Revert "Fixes unaccepted behavior in module configuration"
...
This reverts commit 236d384bab
2014-09-02 10:23:41 +02:00
ee6145a173
Ldap/Query: Remove __toString()
...
This is needed because of exception handling. Exceptions can now bubble
up for default handling. Method render() was renamed to create() because
the method create a query. Adjust the test for method create().
refs #5536
2014-09-02 10:17:01 +02:00
baf768040f
LdapQuery: Use Ldap/Exception for errors
...
refs #5536
2014-09-02 09:55:57 +02:00
6b6826f737
Bug7043Test: Fix test to run without ini configuration
...
fixes #7043
2014-09-01 15:53:32 +02:00
cd8015f41a
Pass the current form instance to the callback as second argument
...
refs #5525
2014-09-01 14:58:16 +02:00
30965c247b
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
2014-09-01 14:50:32 +02:00
0822aff293
library/form: Fix return value of `getName()' not being filterd the first time it's called
...
`Form::getName()' auto-detects the form's name if it's not set and sets the form's name using `Zend_Form::setName()'.
`Zend_Form::setName()' then filters the form name stripping backslash '\' characters. The first call to `Form::getName()'
did not regard the filtering and thus returned the unfiltered name which led to `Form::wasSent()' returning `false'.
refs #5525
2014-09-01 14:40:45 +02:00
30f391035c
Postgres/DbQuery: Add orderfields to select
...
refs #6896
2014-09-01 10:00:04 +02:00
f3e74f0f24
library/form: Append class 'autosubmit' in case the element to autosubmit has the class attribute set
...
Before, the class attribute would've been overwritten.
refs #5525
2014-09-01 09:44:04 +02:00
a01ee00c27
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
...
Conflicts:
library/Icinga/Protocol/Commandpipe/Transport/Transport.php
2014-08-29 17:24:44 +02:00
fb5685bac3
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Config/Authentication/BaseBackendForm.php
application/forms/Config/Authentication/DbBackendForm.php
application/forms/Config/Authentication/LdapBackendForm.php
application/forms/Config/Authentication/ReorderForm.php
application/forms/Config/LoggingForm.php
application/forms/Config/ResourceForm.php
application/forms/Preference/GeneralForm.php
library/Icinga/Application/Config.php
library/Icinga/Web/Form.php
modules/monitoring/application/controllers/ConfigController.php
modules/monitoring/application/forms/Config/Backend/CreateBackendForm.php
modules/monitoring/application/forms/Config/Instance/CreateInstanceForm.php
modules/monitoring/application/forms/Config/Instance/EditInstanceForm.php
modules/monitoring/application/forms/Config/SecurityForm.php
2014-08-29 16:05:56 +02:00
e020dd3541
Icinga\App..\Config: Rename __construct to fromIni and add setConfigPath
...
Prior to this change it was not possible to create an instance of Config
without passing a config file.
2014-08-29 12:23:48 +02:00
79b0ed64ec
Make it possible to provide a closure to be called instead of onSuccess()
...
This allows us to write generic forms like the ConfirmRemoval form but to
utilize handleRequest() while providing a closure in the array that is passed
to a form's constructor.
refs #5525
2014-08-29 12:21:31 +02:00
bf23688e73
Make autosubmit work in non-JS enviroments
...
We require forms to set autosubmit=true on elements which are supposed
to be submitted automatically now. The base form then ensures that this
works in JS environments and non-JS environments as well by applying the
right changes to the HTML.
refs #5525
2014-08-29 09:08:53 +02:00
486104d59e
Check explictly for FALSE when calling onSuccess()
...
This allows us to just end onSuccess() without requiring it to return TRUE
to initiate redirection.
refs #5525
2014-08-29 09:04:20 +02:00
3642b7b6fc
Adjust CSS for inlinePies to be centered on the current line
2014-08-28 18:27:30 +02:00
a26370bb12
Adjust PieCharts that are rendered without labels
...
Center and resize PieCharts to use the full width and height of the available view port
2014-08-28 18:25:19 +02:00
00a2d225a2
Ensure that PieCharts are centered and that labels dont leave the viewBox
...
Add scaling and transformations to move the PieChart into a valid coordinate system and reduce the offset of the labels to make more efficient use of available space.
2014-08-28 16:42:31 +02:00
c5cface661
Improve readability of small pie charts
...
Use a bigger font, to ensure that small pie charts still have readable labels.
2014-08-28 16:40:34 +02:00
98809a1447
Do not use width and height as width and height percentages in the outer SVG element
...
Height and width are solely used to define the SVGs ratio and should not cause side effects on the SVGs size in the site context.
2014-08-28 16:37:21 +02:00
a9eec0d672
Remove useless width and height properties from PieChart
2014-08-28 16:33:38 +02:00
f77cd9cafa
Fix coding guidelines
2014-08-28 16:21:16 +02:00
573a4ea12f
Fix spelling mistakes
2014-08-28 16:14:59 +02:00
4ca1eaa7ce
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
...
Conflicts:
library/Icinga/Web/Form.php
modules/monitoring/application/forms/Config/SecurityForm.php
2014-08-28 13:58:02 +02:00
e345aa257a
Platform: Drop *Available function
...
Create a function extensionLoaded and change usages.
refs #5514
2014-08-28 12:14:55 +02:00
9d0037a53a
ResourceFactory: Add function create(<name>)
...
The ConfigAwareFactory is an interface forcing "backend-type" classes to call
ResourceFactory::createResource() passing a config they got in the constructor.
That's kind of overdesigned, if the ResourceFactory wants to be something like
a service locator it's responsabilities should include object instantiation.
refs #5514
2014-08-28 12:14:54 +02:00
35d11bd145
Class doc for Platform
...
refs #5514
2014-08-28 12:14:54 +02:00
9b83074cc9
Class doc for ResourceFactory
...
refs #5514
2014-08-28 12:14:54 +02:00
22e17e9901
ResourceFactory: Move available function to platform
...
refs #5514
2014-08-28 12:14:54 +02:00
947cd0c5d3
Merge branch 'master' of git.icinga.org:icingaweb2
...
fixes #7006
2014-08-27 17:22:09 +02:00
e6612fefe7
FilterParseException: extend IcingaException
...
refs #6931
2014-08-27 16:26:43 +02:00
afd0c20c42
FilterException: extend IcingaException
...
refs #6931
2014-08-27 16:23:44 +02:00
45638b218c
Throw IcingaException rather than Exception
...
fixes #7014
2014-08-27 16:03:15 +02:00
7ff51caed0
Remove leading backslashes from the targets of use statements
...
- use \Exception;
+ use Exception;
2014-08-27 15:51:49 +02:00
236d384bab
Fixes unaccepted behavior in module configuration
...
fixes #7011
2014-08-27 14:57:08 +02:00
4a59ff6712
Support preserveAspectRatio in SVGRenderer
...
Add support for the preserveAspectRatio attributes in root SVG elements, to improve the handling of padding and automatic resizing of inline SVG.
2014-08-27 13:51:52 +02:00
e1329058db
Do not hard code the name of the form identification element
...
Like the csrf element name the form identification element name should
be publicly accessible as well.
refs #5525
2014-08-27 13:14:40 +02:00
1dea19504f
Revert "Remove leading backslashes from the targets of use statements"
...
This reverts commit 87a5967501
2014-08-27 12:24:11 +02:00
88698cb05d
Hook/TopBar: Rework interface for monitoring top bar
...
refs #6929
2014-08-27 11:31:48 +02:00
b7ae66b496
Hook: Add web hook base class
...
refs #6929
2014-08-27 11:31:47 +02:00
e0d7c3855d
Hook: Add class suffix for base class testing
...
refs #6928
2014-08-27 11:31:47 +02:00
87a5967501
Remove leading backslashes from the targets of use statements
...
- use \Exception;
+ use Exception;
2014-08-27 11:16:44 +02:00
5abf41edef
Hook/ConfigurationTab: Remove deprecated implementation
...
ConfigurationTab hook is not used anywhere. Test is
removed also.
2014-08-27 10:29:04 +02:00
6783d51f76
A form is "submitted" when it was "sent" but no submit label was set
...
This enables us to use handleRequest() as is when no specific submit button
is required.
refs #5525
2014-08-27 10:28:50 +02:00
0ff79b0948
Replace Form::onFailure() with Form::onShow()
...
There is currently no usecase for onFailure() but for onShow() wherewith
the case is covered when a form needs to be prepared before showing it
to the user while the form was not submitted in any way.
refs #5525
2014-08-27 10:25:50 +02:00
d3c2fc858c
Access formdata internally using a public helper method
...
This way concrete form implementations can also simply fetch form
dependent request values without referring to the form's submission
method.
refs #5525
2014-08-27 10:19:33 +02:00
65dd3f9a5b
Make the form in view scripts accessible using $form instead of $element
...
refs #5525
2014-08-27 10:10:55 +02:00
98b2bce15e
Icinga\Web\Form::onSuccess() must not return TRUE
...
When using Icinga\Web\Form directly without creating a specific sub-class
and calling handleRequest() one must not get redirected.
refs #5525
2014-08-27 10:09:29 +02:00
89541f5727
Merge branch 'bugfix/hook-interface-6932'
...
fixes #6932
fixes #6928
2014-08-27 09:39:56 +02:00
Matthias Jentsch
Thomas Gelf
Johannes Meyer
Alexander Fuhr
Eric Lippmann
Marius Hein
Alexander Klimov