10944 Commits

Author SHA1 Message Date
Eric Lippmann
8a6240fe02 Reduce service_severity order by columns
Ordering by host and service display_name too here reduces performance and is not necessary.
2017-07-27 15:03:12 +02:00
Eric Lippmann
c5f2fc5aa5 Reduce service_display_names order by columns
Ordering by host_display_name too here reduces performance as it forces MySQL to use a temp table.
2017-07-27 15:03:12 +02:00
Eric Lippmann
ee429f54d0 Reduce host_severity order by columns
Ordering by host_display_name too here reduces performance and is not necessary.
2017-07-27 15:03:12 +02:00
Eric Lippmann
e7776d08a9 Don't call UNIX_TIMESTAMP when sorting by host_last_state_change
Else possible indices can't be used.
2017-07-27 15:03:12 +02:00
Eric Lippmann
3a1afb3511 Don't call UNIX_TIMESTAMP when sorting by service_last_state_change
Else possible indices can't be used.
2017-07-27 15:03:12 +02:00
Eric Lippmann
9b529bcd15 Flip base tables in HoststatusQuery
This has no performance impact but all our queries should start w/ select from icinga_objects.
2017-07-27 15:03:12 +02:00
Eric Lippmann
370d148072 Optimize imports in HoststatusQuery 2017-07-27 15:03:12 +02:00
Eric Lippmann
e42d86a4e1 Remove unncessary column definitions in the Hostgroupsummary and Servicegroupsummary data views 2017-07-27 15:03:12 +02:00
Eric Lippmann
0a3da99e7f Reduce filter columns of the Hostgroup and Servicegroup data views
Its not necessary to expose those columns because these data views do not directly accept user input.
2017-07-27 15:03:12 +02:00
Eric Lippmann
44da318109 Remove no-op order columns Hosts Severiy and Services Severity from the host group and service group views 2017-07-27 15:03:12 +02:00
Eric Lippmann
b4df81e75a Optimize queries used for fetching the service group summaries 2017-07-27 15:03:12 +02:00
Eric Lippmann
06cb980308 Don't add GROUP BY for unjoined tables 2017-07-27 15:03:12 +02:00
Eric Lippmann
30cc51a823 Optimize queries used for fetching the host group summaries
refs #1883
2017-07-27 11:43:13 +02:00
Eric Lippmann
f5a9016dea Optimize queries for creating the host and service problem badges in the menu
We now use two fast count queries w/ an appropriate filter instead of fetching a whole bunch of unnecessary host and service counters.
2017-07-27 11:38:00 +02:00
Eric Lippmann
a9f3f99049 Don't hide errors in the BackendAvailabilityNavigationItemRenderer
If an exception occurs when fetching the dataview, we will now log the exception and display a badge in state unknown.
2017-07-27 11:35:40 +02:00
Eric Lippmann
439d78a982 Don't hide errors in the MonitoringBadgeNavigationItemRenderer
If an exception occurs when fetching the dataview, we will now log the exception and display a badge in state unknown.
2017-07-27 11:31:10 +02:00
Eric Lippmann
28790d254b Remove caching form the MonitoringBadgeNavigationItemRenderer
Caching will be no longer necessary because we will replace the queries used to fetch the problem badges.
2017-07-27 11:29:57 +02:00
Eric Lippmann
c0d359fbbd Fix base class of MonitoringBadgeNavigationItemRenderer
The MonitoringBadgeNavigationItemRenderer extended the SummaryNavigationItemRenderer before which does not make sense because they have nothing in common.
2017-07-27 09:33:44 +02:00
Johannes Meyer
eb343009bb Form: Don't prevent disabled elements from getting overwritten..
..if someone just utilizes populate() programatically.

refs #2509
2017-07-13 13:53:48 +02:00
Johannes Meyer
ed5ba14df2 Form: Register form notifications as custom error messages for API requests
I'd have liked to fix how we transmit validation messages in such cases,
but for compatibilty reasons this has to suffice..
2017-07-13 13:00:24 +02:00
Johannes Meyer
96c96df636 Form: Don't transmit duplicate error messages
Zend_Form::getMessages() already returns custom error messages,
if there are any
2017-07-13 12:59:23 +02:00
Johannes Meyer
b93dc06f5b ActionController: Let the repsonse itself set its headers
The only header that is now set by the ActionController is X-Icinga-Title,
all others are delegated to Icinga\Web\Response.
2017-07-13 12:56:03 +02:00
Johannes Meyer
0d52bb421f ActionController: Don't re-enable the layout when just setting XHR layout
In case someone doesn't want the layout, we should not force it, especially
not for XHR requests.
2017-07-12 16:54:52 +02:00
Johannes Meyer
73f254ff32 BaseHttpException: Don't return null in method getHeaders() 2017-07-12 16:54:52 +02:00
Eric Lippmann
f25420f458 DbConnection: Fix "Driver does not support setting attributes" for the pdolib extension
fixes #2545
2017-07-11 17:20:25 +02:00
Eric Lippmann
a9e6814785 Revert "DbConnection: Fix "Driver does not support setting attributes" for the pdolib extension"
This reverts commit 3e743a8799d5720c19e23c9e5e56eec42103ca29.

Referenced the wrong issue number.
2017-07-11 17:19:16 +02:00
Eric Lippmann
3e743a8799 DbConnection: Fix "Driver does not support setting attributes" for the pdolib extension
fixes #12640
2017-07-11 17:17:48 +02:00
Eric Lippmann
f02d631aa1 DbConnection: Respect port settings for all database types and provide defaults 2017-07-11 17:11:44 +02:00
Eric Lippmann
b13c38b65b Auth/Groups: Prefer the domain from the LDAP/MSAD user backend
If a LDAP/MSAD user group backend is linked w/ a user backend, the domain from the user backend is preferred over the domain configured for the user group backend.
2017-07-11 17:09:24 +02:00
Eric Lippmann
4b11afe7d5 Remove unused method LdapUserBackend::setConfig() 2017-07-11 17:08:16 +02:00
Eric Lippmann
bd23d008ca Auth: Make sure to set the configured domain on LDAP/MSAD user backends 2017-07-11 17:02:32 +02:00
Eric Lippmann
cbde758fc6 Remove unused domain-aware auth related functions from UserBackend
These functions made it into the master branch accidentally.
2017-07-11 17:01:06 +02:00
Eric Lippmann
d05a262819 Auth: Protect User::setDomain() from empty strings 2017-07-11 16:56:35 +02:00
Johannes Meyer
b397b01966 DbRepository: Avoid to overwrite foreign keys in $aliasTableMap and $aliasColumnMap 2017-07-06 14:10:15 +02:00
Alexander A. Klimov
6848ed6c1e Merge branch 'bugfix/can-t-progress-in-wizard-due-to-error-2842'
fixes #2842
2017-07-05 14:40:10 +02:00
Alexander A. Klimov
5460465e07 Fix null->setDecorators()
refs #2842
2017-07-05 14:34:17 +02:00
Johannes Meyer
375920f761 Use a more sophisticated inheritance and interface structure for HTTP exceptions (#2881)
HttpExceptionInterface now identifies HTTP exceptions, BaseHttpExceptions supersedes
HttpException as new superclass for other more concrete Exceptions and HttpException
is now a generic class to create new HTTP exceptions on the fly.

resolves #2880
2017-07-05 06:26:58 +02:00
Eric Lippmann
d208b48b72 Monitoring: Fix permission for the 'Process check result' action
fixes #2878
2017-07-04 17:24:57 +02:00
Eric Lippmann
c0d82fa2cc Rephrase autosumbit tooltips
fixes #1507
2017-07-04 13:59:02 +02:00
Eric Lippmann
53091384cd Remove unused attributes from the date time picker element 2017-07-04 10:32:30 +02:00
Eric Lippmann
a5990d4de8 Add date and time form elements 2017-07-03 15:03:26 +02:00
Johannes Meyer
08095ad5e8 ErrorController: Set $this->rerenderLayout in init()
Solves the issue that when being redirected directly after login
or any other route which causes the layout being rerendered, we
are only presented with the inline layout of the error controller.
2017-06-29 09:51:24 +02:00
Johannes Meyer
f6166b3ab6 ActionController: Allow to control which inline view script to use
This also affects that rerendering the layout does only have any effect
in case of XHR requests and is not overwritten anymore in this case.
Since this property was previously private, this should not break anything.
2017-06-28 11:14:01 +02:00
Johannes Meyer
22223acf1d Controllers: Make all private properties protected
Controllers are neither library stuff nor any vital part that need to be
protected from too adventurous module developers.
2017-06-28 09:51:28 +02:00
Eric Lippmann
c554ebb473 Merge pull request #74 from Icinga/feature/travis 2017-06-23 14:45:38 +02:00
Alexander A. Klimov
8b43bd6646 Remove LdapBackendForm::isValidPartial() 2017-06-21 16:59:46 +02:00
Eric Lippmann
686d022987 Merge pull request #2863 from Icinga/feature/domain-support-for-authn-authz-2153 2017-06-21 13:16:36 +02:00
Alexander A. Klimov
fa5bc6c1ae Wizard: make LDAP domain discovery working again
refs #2153
2017-06-20 15:46:31 +02:00
Alexander A. Klimov
9237c3e27d Wizard: make AD discovery working again
refs #2153
2017-06-20 14:46:44 +02:00
Johannes Meyer
46647444c4 Repository: Fix broken conversion rules
The additional layers in $aliasTableMap and $aliasColumnMap required
for DbRepository's join probabilities are now only established there.
2017-06-20 08:32:44 +02:00