Commit Graph

12430 Commits

Author SHA1 Message Date
Johannes Meyer 8b4d5f37c5 travis: Raise phpcs version to 3.5.3 to support PHP 7.4 2019-12-04 11:28:08 +01:00
Johannes Meyer d855c837ba travis: Test on xenial, trusty has no PHP 7.4 2019-12-04 11:28:08 +01:00
Johannes Meyer 5e82c401db travis: Remove php 7.0, test everything on php 7.1 and 7.2 2019-12-04 11:28:08 +01:00
Johannes Meyer 9c94b9cde7 vendor/lessphp: Check for an array before accessing an offset
https://www.php.net/manual/en/migration74.incompatible.php#migration74.incompatible.core.non-array-access
2019-12-04 11:28:08 +01:00
Johannes Meyer 369ffa758e zend/Registry: Don't override method `offsetExists()`
It's not possible to use `array_key_exists()` on objects anymore
(https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.array-key-exists-objects)
and since the referenced bug (http://bugs.php.net/bug.php?id=40442)
only applied to PHP 5.2.0 it's now obsolete.
2019-12-04 11:28:08 +01:00
Johannes Meyer d34909bbac vendor/lessphp: Avoid curly braces to access array offsets
https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.array-string-access-curly-brace
2019-12-04 11:28:08 +01:00
Johannes Meyer 0a44bbc804 vendor/Zend: Avoid curly braces to access array offsets
https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.array-string-access-curly-brace
2019-12-04 11:28:08 +01:00
Johannes Meyer 67dd439673 vendor/HTMLPurifier: Avoid curly braces to access array offsets
https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.array-string-access-curly-brace
2019-12-04 11:28:08 +01:00
Johannes Meyer 0442c4f0ab View: Ignore setting `short_open_tag`
Adjusting class `Zend_View_Stream` according to https://www.php.net/manual/en/migration74.incompatible.php#migration74.incompatible.core.stream-wrappers
didn't work. (*syntax error, unexpected end of file* after every last php statement in phtml files)

So.. since `<?= ?>` instructions are permanently available since PHP 5.4 (https://www.php.net/manual/en/language.basic-syntax.phptags.php)
we'll just omit using a custom stream wrapper now.
2019-12-04 09:35:24 +01:00
Johannes Meyer 7bc1893a24 LdapConnection: Don't utilize `ldap_control_paged_result()` on PHP 7.3+
https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.ldap
2019-12-04 09:33:13 +01:00
Johannes Meyer e93fbdb802 travis: Test on PHP 7.4 as well 2019-12-04 09:30:47 +01:00
Johannes Meyer 9b1dc44130 FilterEditor: Also trim trailing whitespace from search values
Simple values are wrapped with `*` anyway, so trimming all
whitespace doesn't pose an issue. (Even if inserted intentionally)
This doesn't apply to qualified search values. (e.g. `host = abc `)

resolves #4002
2019-12-03 10:33:00 +01:00
Florian Strohmaier 1755c01390 base.less: Add gray-semilight var 2019-11-28 15:32:38 +01:00
Johannes Meyer cc065b949b js: Use custom event `icinga-init` to trigger initial render events
The `load` event is not really only fired *after all shared resources are loaded*.
Just Chromium ensures this event is fired only after `ready` and `DOMContentLoaded`.
FF, IE and Safari don't so we need our own post-init event: `icinga-init`
2019-11-26 16:00:21 +01:00
Johannes Meyer 48098a2830 js: Don't initialize modules using a `beforerender` event
`beforerender` is already too late. Module initialization
done using an event handler is wrong anyway. It's some
kind of bootstrapping after all and should be performed
by parts of the code which is directly responsible for
DOM content handling of modules. (i.e. loader.js)

This change though introduces a side-effect which was
not the case previously: Nested `.container` elements
trigger `rendered` events now. I've introduced this to
ensure we're also lazy loading modules and let them
handle their `rendered` events right after a redirect
which rerendered the layout. (Only `#layout` got a
`rendered` event then prior to this change)
2019-11-21 09:55:20 +01:00
Johannes Meyer 7f78c1a8a8 js: Properly initialize modules and don't trigger `rendered` events twice
Cleans up how our JS initializes module javascript. Previously the `rendered`
event only got fired upon page load if a module got loaded as well. This is
now decoupled and `rendered` events fire for all containers and the entire
layout upon page load.

Notable changes:
* A `load` event initializes modules and triggers `rendered` on `.container` and `#layout` elements
* Module javascript (module.js) is still lazy loaded but with a `beforerender` event, not `rendered`
* Previously `#layout` received a `rendered` event during bootstrapping, this is not the case anymore
* Initial search value preservation now got its own handler `events.onRenderedMenu()`
* Initial dashlet loading now git its own handler `events.loadDashlets()`
2019-11-20 16:22:56 +01:00
Johannes Meyer 47c2a8bdc1 js: Utilize `utils.objectsEqual()` in `actiontable.select()` 2019-11-20 16:22:56 +01:00
Johannes Meyer 2dbf9ca8ab js: Properly parse/decode query params in `utils.parseParams()` 2019-11-20 16:22:56 +01:00
Michael Friedrich 4d790e70fc
Merge pull request #4003 from Icinga/feature/docs-installation-el8-sles15
Docs: Update installation for RHEL/CentOS 8 and SLES 15
2019-11-20 16:10:50 +01:00
Michael Friedrich 3c8c2ba3e9 Docs: Update installation for RHEL/CentOS 8 and SLES 15 2019-11-20 15:58:10 +01:00
Johannes Meyer 5f739deea3 loader.js: Enhance __BACK__ handling 2019-11-05 15:04:23 +01:00
Johannes Meyer da565f4d16 loader.js: Refresh left twice in case right has been closed..
..if the redirect target is `__BACK__`
2019-11-04 17:25:05 +01:00
Johannes Meyer 42e596f457 loader.js: Navigate back if redirect target is `__BACK__` 2019-11-04 16:03:54 +01:00
Eric Lippmann 10d8715d1d Merge branch 'feature/modals' 2019-11-04 12:46:34 +01:00
Eric Lippmann 9f4e29b56c JS/CSS: Load modal behavior and styles 2019-11-04 12:46:30 +01:00
Johannes Meyer a13d2b1e48 js: Introduce behavior modal.js 2019-11-04 12:46:30 +01:00
Johannes Meyer 05aac50ae2 layout: Render basic modal markup 2019-11-04 12:46:30 +01:00
Florian Strohmaier ad66582e9c CSS: Add modal styles 2019-11-04 12:46:30 +01:00
Johannes Meyer c0cac6fe3c loader.js: Allow to use a separate target for redirections 2019-11-04 12:46:30 +01:00
Johannes Meyer 0e5e046ae5 js: Split event handling and processing of form submits 2019-11-04 12:46:30 +01:00
Johannes Meyer 50bf126d36 js: Move function events.getLinkTargetFor to loader.js 2019-11-04 12:46:30 +01:00
Feu Mourek 57f966734a Perfdata: add function to get perfdata unit 2019-11-04 11:36:57 +01:00
Florian Strohmaier 82e02c8ce1 CSS: Align value-table-name width with label width 2019-10-31 14:43:37 +01:00
Eric Lippmann c196631f5a Add Markdown::line() 2019-10-31 14:41:39 +01:00
Florian Strohmaier a00151ef5c CSS: Use margin-right only for non-inline control-groups 2019-10-30 14:57:13 +01:00
Johannes Meyer 8a16349fe4 Update CHANGELOG.md 2019-10-18 07:41:53 +02:00
Johannes Meyer e0be21f655 Raise version to 2.7.3 2019-10-18 07:41:53 +02:00
Johannes Meyer ded92c786a Add missing columns to empty group queries 2019-10-18 07:32:58 +02:00
Johannes Meyer 8e51518e96 ServicegroupQuery: Really join hosts if instructed to do so
fixes #3983
2019-10-17 16:14:28 +02:00
Johannes Meyer 8d2970a18e Update CHANGELOG.md 2019-10-16 08:12:09 +02:00
Johannes Meyer 362c30c1dd Raise version to 2.7.2 2019-10-16 08:12:09 +02:00
Johannes Meyer 01bcf980f2
Merge pull request #3965 from Icinga/fix/slow-queries-when-filtering-groups-3928
Enhance query performance when filtering for groups and reduce double query execution
2019-10-16 08:05:30 +02:00
Johannes Meyer 683e70310a
Merge pull request #3979 from Icinga/fix/event-details-dont-show-dates-3968
Render missing dates of event details
2019-10-14 09:19:43 +02:00
Johannes Meyer bb2673a49a EventController: Use `DateFormatter::formatDateTime` to render dates
fixes #3968
2019-10-14 08:12:35 +02:00
Johannes Meyer cbc12ab31e event-history.phtml: Don't use `hasResult()` to check if there are results
28ec1e236 has no result on history views as they never count their results.
So restructuring this particular view script I deemed reasonable since the
history queries tend to show very poor performance.

refs #3905
refs #3836
2019-10-11 10:27:43 +02:00
Johannes Meyer 8e5380220c SimpleQuery: Cache count query result and use it in `hasResult()`
Does not affect views which do not run a count query. (e.g. dashlets)
Though, this is a quick win for all other views with which the user
interacts directly and gets the desired result quicker than before.

refs #3905
refs #3836
2019-10-11 10:27:43 +02:00
Johannes Meyer 908c408d3d ServicegroupsummaryQuery: Fetch empty groups with a union query
refs #3928
2019-10-11 10:27:43 +02:00
Johannes Meyer faca6d53c8 HostgroupsummaryQuery: Add empty groups to the union
refs #3928
2019-10-11 10:27:43 +02:00
Johannes Meyer fae60f06bf Revert "Show empty groups with a filter chain too"
This reverts commit fadf12e98a.
2019-10-08 13:39:52 +02:00
Johannes Meyer 0e729bb85b Revert "ServicegroupQuery: Use left joins instead of inner joins"
This reverts commit 23066d2cc4.
2019-10-08 13:39:52 +02:00