a980184eb9
Move css instructions to dedicated stylesheet
...
refs #7163
2014-10-01 15:46:58 +02:00
ed91e119d2
Add close-button to all containers
...
refs #6216
2014-10-01 14:51:51 +02:00
8f79e0a713
Fix warning "references should be passed by variable only"
2014-10-01 09:17:48 +02:00
08d259eccf
Add database creation page
...
refs #7163
2014-10-01 09:16:53 +02:00
bbee06b57f
form: Ignore note elments when retrieving values at form level
2014-10-01 08:18:34 +02:00
7b01525456
Fix that navigation buttons have labels
...
refs #7163
refs #7320
2014-09-29 16:42:38 +02:00
513d5e30a4
Merge branch 'master' into feature/setup-wizard-7163
2014-09-29 16:16:12 +02:00
ab8436dea8
Fix Icinga\Web\Form\Element\Note using its default decorators
2014-09-29 16:12:38 +02:00
cbadaa78d6
Merge branch 'master' into feature/setup-wizard-7163
2014-09-29 15:35:52 +02:00
4a14dc5916
Add interface for setup wizards
...
refs #7163
2014-09-29 14:19:05 +02:00
5d6391242c
Add interface for installers
...
refs #7163
2014-09-29 14:18:50 +02:00
929344e68b
Add container to store and handle installation requirements
...
refs #7163
2014-09-29 12:25:29 +02:00
aa17f2828d
Add utility to ease working with databases without the use of Zend
...
refs #7163
2014-09-29 12:24:56 +02:00
7c53e6f7be
Improve page permission handling
...
refs #7163
2014-09-29 11:31:59 +02:00
5c13a19b1a
Populate a wizard page in case the user moves backwards
...
refs #7163
2014-09-29 11:31:13 +02:00
73b41769e7
__toString() should call __toString() as well if possible
...
There may be cases that an error occurs and another _toString()
implementation handles that appropriately. This is such a case.
2014-09-29 11:28:58 +02:00
3107eb87bb
Silence stat() call
2014-09-29 11:24:59 +02:00
b2f12e1caa
Revert "lib: Remove form element `Note'"
...
This reverts commit c21d7d1fdd
2014-09-26 16:19:44 +02:00
c8a24f72b8
Introduce getValue() in Preferences and fix the loading of values
2014-09-26 14:15:50 +02:00
8e48853f4d
Add Wizard
...
This is a container/controller for form based wizards. Can be used directly
or by using a subclass that allows for a more customized handling.
refs #7163
2014-09-24 10:46:36 +02:00
028a6c442b
Fix persisting notification messages in the session
2014-09-24 10:46:35 +02:00
635b802a2b
Add tests for hasChanged, set/getByRef and fix setByRef
2014-09-24 10:46:35 +02:00
6f988cb94c
Remove method write() from Icinga\Web\Session\SessionNamespace
2014-09-24 10:46:35 +02:00
c00dbf9f46
Write session on response
...
There should not be any necessity to write the session once changes are
being made to it. We now track whether changes were made and write
the session when responding to the user's request if so.
2014-09-24 10:46:35 +02:00
7fcd665aaa
Fix value invalidation in Icinga\Web\Session\SessionNamespace
2014-09-24 10:46:35 +02:00
efab6c7827
Add method set/getByRef to Icinga\Web\Session\SessionNamespace
2014-09-24 10:46:35 +02:00
c772787967
Re-add TokenValidator
...
refs #7163
2014-09-24 10:46:35 +02:00
cde3ec6bc8
Merge branch 'master' into bugfix/commands-6593
...
Conflicts:
modules/monitoring/application/controllers/TimelineController.php
2014-09-23 22:54:17 -07:00
07a4b25560
Merge branch 'master' into bug/history-notification-time-format-6980
2014-09-23 11:38:24 +02:00
e784aa34b6
Implement DateTimeRenderer and fix history time format
...
refs #6980
2014-09-23 11:36:09 +02:00
6c8f324dd4
Add filter widget to StateHistorySummary and fix some minor bugs
...
fixes #6979
2014-09-19 17:41:44 +02:00
4ce71ef2f2
Display a tooltip on days without events
2014-09-19 17:41:44 +02:00
6f1cb6f1f3
Adjust brightness for different event type colors
2014-09-19 17:41:44 +02:00
65203fddcf
Add additional state history filters for time interval and event type
2014-09-19 17:41:44 +02:00
ef2f332869
Do not refresh a container when form input was changed or a form element is focused
...
Listen for changes in form elements and abort all reloads that contain a form with
at least one changed form element. Do not refresh containers that contain a focused form
element, except of elements with autofocus, to preserve form elements with a dropdown.
Only focus autofocus elements when there is currently no other selection.
refs #7146
refs #5537
fixes #7162
2014-09-19 15:48:44 +02:00
264d818133
Do not save config references in the `ActionController'
...
This is redundant because our `Config' class already caches loaded configs.
2014-09-19 14:44:21 +02:00
119e23e79e
Make `InlinePie's setters fluent
2014-09-19 14:43:25 +02:00
bea110d0c7
Fix `Form::isSubmitted()' for dynamic submit labels
2014-09-19 14:27:04 +02:00
5b5f553d0d
form: Fix dynamic submit label retrieval
2014-09-19 13:39:38 +02:00
c51b05296e
Merge branch 'master' into bugfix/commands-6593
2014-09-19 13:18:47 +02:00
3c9859a0f1
Call `Form::getSubmitLabal()' in `Form::addSubmitButton()'
...
This allows us to dynamically define submit labels in form subclasses.
2014-09-19 13:00:15 +02:00
5ba96c32f9
`Form::setDefaults()' fix strict standards violation
...
Declaration of Icinga\Web\Form::setDefaults() should be compatible with that of Zend_Form::setDefaults().
2014-09-19 12:59:01 +02:00
7eb51f6367
form/csrf: Set the csrf element decorators in the element not in the form
2014-09-19 12:57:53 +02:00
d091e2150c
Fix `ActionController::prepareInit()' php doc
2014-09-16 18:43:14 +02:00
b38ef9c0bd
Implement plural and context based translation functionality
...
refs #6982
2014-09-16 15:19:23 +02:00
c21d7d1fdd
lib: Remove form element `Note'
...
Zend already provides this.
2014-09-16 09:54:23 +02:00
5c647719e4
lib/ModuleActionController: Fix stupid code
2014-09-16 09:29:03 +02:00
f8edb4f220
lib: Add method `ActionController::prepareInit()'
...
As it should not be required for controllers to call the parent's init() method, base controllers should use
prepareInit() in order to prepare the controller initialization.
2014-09-16 09:28:10 +02:00
e2b5e05f21
Implement plural translation (testing)
2014-09-15 14:11:42 +02:00
8bf66425d1
Merge branch 'master' into bugfix/commands-6593
2014-09-15 09:27:56 +02:00
9e0d6657b7
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
...
Conflicts:
application/forms/Preference/GeneralForm.php
2014-09-15 09:27:07 +02:00
f48094f01a
Merge branch 'master' into feature/translation-plurals-6982
2014-09-15 08:34:19 +02:00
1932a912f8
Fix month-naming for different week arrangements
...
fixes #7179
2014-09-12 11:51:51 +02:00
6c3c466f92
Start history grid weeks at monday
...
Add configuration option for week-start and set the default to Monday.
2014-09-12 11:51:51 +02:00
e42b7b3026
Display current weeks at the beginning of the history grid
...
fixes #7179
2014-09-12 11:51:51 +02:00
8ceef96d28
Web\Hook: remove unused methods
2014-09-12 09:53:38 +02:00
93777ac15e
Web/Response: use & to encode XHR redirection URLs
2014-09-12 09:28:11 +02:00
ad53f7ad3d
Use EventEmitter class as a way to delegate events from behaviors to the dom
2014-09-12 09:09:21 +02:00
0e926ba05e
Revert "Revert "Web\Hook: register('grapher')
...
This reverts commit 65564cda65
2014-09-12 09:02:23 +02:00
583fd46f15
Experimental Plural Translation Implementation
...
Personal BACKUP
2014-09-11 18:04:10 +02:00
65564cda65
Revert "Web\Hook: register('grapher') => GrapherHook"
...
This reverts commit 4a89c2e163
2014-09-11 15:00:28 +02:00
9376ceed33
Add missing use-statement for Exceptions in MenuRenderer
...
fixes #7157
2014-09-10 17:12:19 +02:00
f58da73e2d
Move javascript behaviors into separate classes
2014-09-10 17:02:39 +02:00
d99d50b3c4
Add stub for javascript behaviors
2014-09-10 17:02:38 +02:00
ea63dad087
viewHelpers: use the view
...
refs #7177
2014-09-10 16:56:26 +02:00
631b3d9f6e
viewHelpers: There is no $this, not before 5.4
...
refs #7177
2014-09-10 16:54:57 +02:00
c2fe0232ca
helpers/attributes: escape value
...
refs #7177
2014-09-10 16:07:00 +02:00
27960fc628
Catch exceptions in MenuItemRenderers
...
fixes #7157
2014-09-10 14:38:11 +02:00
83772c6684
Merge branch 'master' into bugfix/rebuild-form-builder-5525
2014-09-09 16:03:22 +02:00
71f55e388f
Only display custom menu renders on XHR requests and not in regular HTML
...
The main navigation should be rendered without a working backend.
fixes #7143
2014-09-09 15:33:42 +02:00
e7c021845d
Simplify subform usage
...
refs #5525
2014-09-09 15:00:33 +02:00
f7f6bcc447
Make Form base class more test friendly..
...
refs #5525
2014-09-09 09:31:15 +02:00
c8ce1088c9
Disable checking whether a form is sent when form identification is disabled
...
refs #5525
2014-09-09 09:30:33 +02:00
a352131d65
Move charts.less into widgets.less
...
Don't use a separate less file for only two styles
2014-09-08 16:25:11 +02:00
e8164c6da0
Show tooltips to describe menu badges
2014-09-08 10:38:02 +02:00
0e7ca591ec
Merge branch 'master' into bugfix/commands-6593
...
Conflicts:
application/forms/Preference/GeneralForm.php
application/views/helpers/FormDateTime.php
modules/monitoring/application/forms/Command/CommandForm.php
2014-09-08 10:16:05 +02:00
e39dd64a1b
Fix layout of HistoryColorGrid
...
Use actual color for critical hosts and only display the first two letters of the weekday
2014-09-08 09:52:28 +02:00
12b4865559
Fix incompatible declaration of Form::setDefaults()
...
PHP with strict standards: Declaration of Icinga\Web\Form::setDefaults()
should be compatible with that of Zend_Form::setDefaults()
refs #5525
2014-09-08 09:42:02 +02:00
930e6e7d71
We shouldn't require Form::createElements() to return self
...
refs #5525
2014-09-08 09:24:53 +02:00
ae9e5a40cc
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Preference/GeneralForm.php
2014-09-08 08:46:53 +02:00
4a89c2e163
Web\Hook: register('grapher') => GrapherHook
2014-09-05 18:54:50 +02:00
51d14af154
Merge branch 'master' into feature/navigation-unhandled-badges-7114
...
Conflicts:
library/Icinga/Web/Menu.php
2014-09-05 18:14:29 +02:00
19eca5f50b
Show all unhandled host and services in a menu
...
Add the option to define custom renderers for menu items and implement renderers to
display all unhandled services and host in a badge in the navigation.
resolves #7114
2014-09-05 17:57:20 +02:00
596800bd7d
helpers/url: overwrite existing params
2014-09-05 17:56:55 +02:00
4bb065d9bb
Web\Menu: provide and render unique id
...
fixes #7083
2014-09-05 17:24:55 +02:00
b034028ff8
Menu: do not show application log when none exists
...
Added new functions to the logger to get rid of distributed logging config
"knowledge".
fixes #7062
fixes #7098
2014-09-05 15:31:30 +02:00
3ce42489c6
Timezone detection: Client implementation
...
refs #6078
2014-09-05 15:24:13 +02:00
e205ca4d0b
FilterWidget: remove icon titles
...
fixes #7105
2014-09-05 14:50:22 +02:00
33d2175b77
Web\UrlParams: allow to merge single value
2014-09-05 13:35:51 +02:00
baa775dd74
Web\Url: document with() method
2014-09-05 11:40:43 +02:00
1c2207f51d
Web\Url: provide a with() function
2014-09-05 11:21:10 +02:00
4c8407e2b6
Web\StyleSheet: outer #layout access for modules
...
fixes #7093
2014-09-05 10:56:26 +02:00
b14e7f5696
LessCompiler: remove obsolete cache-related comment
2014-09-05 10:56:25 +02:00
fc72ddfbc8
Adjust Preferences/GeneralForm to use handleRequest() &. Co.
...
refs #5525
2014-09-05 10:21:24 +02:00
d021747bde
Fix form widgets
...
refs #5525
2014-09-05 09:17:09 +02:00
8846f17ae1
Make it possible to disable form identification
...
refs #5525
2014-09-05 09:16:09 +02:00
ba623d0544
SearchDashboard: adjust SearchDashboardTest and rename searchQuery to searchString
2014-09-04 22:54:41 +02:00
0f7f2f2d8b
SearchDashboard: rename ::load() to ::search()
...
Function signature didn't match parent factory function
fixes #7081
2014-09-04 19:35:31 +02:00
0f8d5bddba
Web\Menu: make use of Web\Url
...
refs #7083
2014-09-04 19:18:09 +02:00
f91892cb80
Web\Url: add matches() function
...
fixes #6992
2014-09-04 18:46:58 +02:00
e4d1143870
Add SearchDashboardTest
2014-09-04 18:31:08 +02:00
1eacde0233
Implement modules self provided search configuration
...
refs #6495
2014-09-04 16:31:10 +02:00
c8eaf66823
GrapherHook: Rework hook
...
refs #6932
2014-09-04 14:00:48 +02:00
4fb47ef768
Hook classes: Add class suffix if not exist
...
refs #7066
refs #7067
refs #7068
2014-09-04 14:00:48 +02:00
c3c0043307
Merge branch 'master' into bugfix/commands-6593
2014-09-03 23:23:20 +02:00
a4da3b61b3
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
2014-09-03 23:23:02 +02:00
da85112538
Merge branch 'master' into feature/svg-chart-tooltips-7024
2014-09-03 17:08:00 +02:00
37b168995b
Rename tipsy stylesheet file type to css and add license
2014-09-03 17:01:07 +02:00
b10b1ea034
Add jQuery tooltips
2014-09-03 15:53:56 +02:00
2025fb3a2f
lib: Let the date-and-time input control behave as defined in HTML5
...
refs #6593
2014-09-03 14:40:58 +02:00
acbd2bd7c0
Merge branch 'master' into feature/dashboard-component-disabled-property-6986
2014-09-03 14:40:30 +02:00
906de4e679
lib: Add the HTML5 attributes 'min', 'max' and 'step' to the number input control
...
refs #6593
2014-09-03 14:39:42 +02:00
1a4e908461
lib: Let `DateTimeValidator' validate values as defined in HTML5
...
See http://www.w3.org/TR/html-markup/datatypes.html#common.data.datetime for the specification.
refs #6593
2014-09-03 14:36:18 +02:00
7cfc051228
Add tests for Dashboard and fix doc blocks
...
refs #6986
2014-09-03 14:36:04 +02:00
54a834266c
Form::createElements() should add elements instead of returning them
...
In case createElements() would still return the elements while requiring
the caller to add them to the form all form dependent configurations get
lost. (displaygroups, belongTo, ...) Wizards or parent forms can still
retrieve only input relevant fields by just calling createElements() and
getElements().
refs #5525
2014-09-03 12:21:31 +02:00
3d352ba446
Filter: add FilterNotEqual and FilterMatch
...
fixes #6557
2014-09-02 19:51:56 +02:00
5485ca8a25
lib: Use Zend's `Int' validator in the `Number' form element
...
Further disabled default decorators since our form sets them.
refs #5525
2014-09-02 16:54:43 +02:00
95c839a8bd
Remove remaining usages of the ElementWrapper- and HelpText-Decorator
...
refs #5525
2014-09-02 16:50:59 +02:00
6faedf5733
ActionController: no benchmark for no renderer
...
Benchmarks should not be shown when the renderer is no longer available.
2014-09-02 16:49:28 +02:00
e4687a60f9
Web\JavaScript: use Cache and ETags
...
refs #6927
2014-09-02 16:25:44 +02:00
1ba3df310c
Remove BaseConfigController, User\Message and Widget\AlertMesageBox
...
refs #6758
2014-09-02 16:25:03 +02:00
539ab91ffa
Add the FormErrors decorator as default decorator for forms
...
This allows us to use Zend_Form::addError() to show error messages for
the entire form context.
refs #5525
2014-09-02 16:25:03 +02:00
f0d6cf994e
Web\StyleSheet: use Cache and ETags
2014-09-02 16:24:55 +02:00
ff6483cec5
Web\FileCache: initial implementation
...
refs #6927
2014-09-02 16:22:48 +02:00
338f549233
Add class ReadablePathValidator
2014-09-02 16:19:45 +02:00
39bb01b433
Rename Icinga\Web\Form::onShow() to onRequest()
...
onShow() is misleading because at the time this method is being called the
form is neither shown nor created.
refs #5525
2014-09-02 16:19:45 +02:00
d4c4ab7b2c
lib/form: Fix default element decorators but breaking noscript layout
...
Replaced `ElementWrapper' and `HelpText' with Zend's `HtmlTag' and `Label' respectively.
Instances of Zend_Form_Element returned by `Form::createElements()' now receive our desired default decorators.
refs #5525
2014-09-02 15:23:07 +02:00
8478ef3fce
lib: Remove `HelpText' form element decorator
...
Zend already has a `Description' decorator.
refs #5525
2014-09-02 15:05:47 +02:00
7143837ae3
lib: Remove `ElementWrapper' form element decorator
...
Zend has a `Label' decorator already.
refs #5525
2014-09-02 15:04:23 +02:00
62c0f0be03
Web\Session: implement lazy loading
...
fixes #7055
2014-09-02 13:23:15 +02:00
26339b128a
Add disabled property and implement the functionality
...
refs #6986
2014-09-02 13:16:21 +02:00
bb0e1dc105
Revert "Fixes unaccepted behavior in module configuration"
...
This reverts commit 236d384bab
2014-09-02 10:23:41 +02:00
cd8015f41a
Pass the current form instance to the callback as second argument
...
refs #5525
2014-09-01 14:58:16 +02:00
0822aff293
library/form: Fix return value of `getName()' not being filterd the first time it's called
...
`Form::getName()' auto-detects the form's name if it's not set and sets the form's name using `Zend_Form::setName()'.
`Zend_Form::setName()' then filters the form name stripping backslash '\' characters. The first call to `Form::getName()'
did not regard the filtering and thus returned the unfiltered name which led to `Form::wasSent()' returning `false'.
refs #5525
2014-09-01 14:40:45 +02:00
f3e74f0f24
library/form: Append class 'autosubmit' in case the element to autosubmit has the class attribute set
...
Before, the class attribute would've been overwritten.
refs #5525
2014-09-01 09:44:04 +02:00
fb5685bac3
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Config/Authentication/BaseBackendForm.php
application/forms/Config/Authentication/DbBackendForm.php
application/forms/Config/Authentication/LdapBackendForm.php
application/forms/Config/Authentication/ReorderForm.php
application/forms/Config/LoggingForm.php
application/forms/Config/ResourceForm.php
application/forms/Preference/GeneralForm.php
library/Icinga/Application/Config.php
library/Icinga/Web/Form.php
modules/monitoring/application/controllers/ConfigController.php
modules/monitoring/application/forms/Config/Backend/CreateBackendForm.php
modules/monitoring/application/forms/Config/Instance/CreateInstanceForm.php
modules/monitoring/application/forms/Config/Instance/EditInstanceForm.php
modules/monitoring/application/forms/Config/SecurityForm.php
2014-08-29 16:05:56 +02:00
79b0ed64ec
Make it possible to provide a closure to be called instead of onSuccess()
...
This allows us to write generic forms like the ConfirmRemoval form but to
utilize handleRequest() while providing a closure in the array that is passed
to a form's constructor.
refs #5525
2014-08-29 12:21:31 +02:00
bf23688e73
Make autosubmit work in non-JS enviroments
...
We require forms to set autosubmit=true on elements which are supposed
to be submitted automatically now. The base form then ensures that this
works in JS environments and non-JS environments as well by applying the
right changes to the HTML.
refs #5525
2014-08-29 09:08:53 +02:00
486104d59e
Check explictly for FALSE when calling onSuccess()
...
This allows us to just end onSuccess() without requiring it to return TRUE
to initiate redirection.
refs #5525
2014-08-29 09:04:20 +02:00
3642b7b6fc
Adjust CSS for inlinePies to be centered on the current line
2014-08-28 18:27:30 +02:00
45638b218c
Throw IcingaException rather than Exception
...
fixes #7014
2014-08-27 16:03:15 +02:00
7ff51caed0
Remove leading backslashes from the targets of use statements
...
- use \Exception;
+ use Exception;
2014-08-27 15:51:49 +02:00
236d384bab
Fixes unaccepted behavior in module configuration
...
fixes #7011
2014-08-27 14:57:08 +02:00
e1329058db
Do not hard code the name of the form identification element
...
Like the csrf element name the form identification element name should
be publicly accessible as well.
refs #5525
2014-08-27 13:14:40 +02:00
1dea19504f
Revert "Remove leading backslashes from the targets of use statements"
...
This reverts commit 87a5967501
2014-08-27 12:24:11 +02:00
88698cb05d
Hook/TopBar: Rework interface for monitoring top bar
...
refs #6929
2014-08-27 11:31:48 +02:00
b7ae66b496
Hook: Add web hook base class
...
refs #6929
2014-08-27 11:31:47 +02:00
e0d7c3855d
Hook: Add class suffix for base class testing
...
refs #6928
2014-08-27 11:31:47 +02:00
87a5967501
Remove leading backslashes from the targets of use statements
...
- use \Exception;
+ use Exception;
2014-08-27 11:16:44 +02:00
5abf41edef
Hook/ConfigurationTab: Remove deprecated implementation
...
ConfigurationTab hook is not used anywhere. Test is
removed also.
2014-08-27 10:29:04 +02:00
6783d51f76
A form is "submitted" when it was "sent" but no submit label was set
...
This enables us to use handleRequest() as is when no specific submit button
is required.
refs #5525
2014-08-27 10:28:50 +02:00
0ff79b0948
Replace Form::onFailure() with Form::onShow()
...
There is currently no usecase for onFailure() but for onShow() wherewith
the case is covered when a form needs to be prepared before showing it
to the user while the form was not submitted in any way.
refs #5525
2014-08-27 10:25:50 +02:00
d3c2fc858c
Access formdata internally using a public helper method
...
This way concrete form implementations can also simply fetch form
dependent request values without referring to the form's submission
method.
refs #5525
2014-08-27 10:19:33 +02:00
65dd3f9a5b
Make the form in view scripts accessible using $form instead of $element
...
refs #5525
2014-08-27 10:10:55 +02:00
98b2bce15e
Icinga\Web\Form::onSuccess() must not return TRUE
...
When using Icinga\Web\Form directly without creating a specific sub-class
and calling handleRequest() one must not get redirected.
refs #5525
2014-08-27 10:09:29 +02:00
7e5b5a0b30
Hook/Grapher: Rework hook interface
...
Rework interface based on specification and changed consumer calls.
refs #6932
2014-08-27 09:35:43 +02:00
376e9aa160
Rename hook base classes
...
Adding suffix "Hook" to every base class. This simplifies development
because you don't need to alias bases classes in your concrete
hook classes
refs #6928
2014-08-26 14:29:55 +02:00
45cbd3f067
We do not require the request being passed to handleRequest()
...
refs #5525
2014-08-26 12:31:05 +02:00
5c7999fe9b
Forms should be responsible for any redirection as well
...
If no specific url has been set with setRedirectUrl() a form redirects to the
current action it was posted to.
refs #5525
2014-08-26 12:30:37 +02:00
1f7d4cb61b
Merge branch 'master' into bugfix/exceptions-with-printf-params-6931
2014-08-26 11:24:33 +02:00
febb2d1ae2
ProgrammingError: extend IcingaException
...
refs #6931
2014-08-26 11:15:19 +02:00
42e2b34356
Implement self provided configuration for dashboard/dashlets in modules
...
refs #6639
2014-08-26 10:34:36 +02:00
52534a2f46
It is a form's responsibility to process the request it was submitted with
...
How forms are being validated should not be a task that is part of the
controller action, but should be handled by the form base class as it is
most of the time the same procedure. Now a controller action just sets
up the form to use, calls handleRequest() and acts upon its return value.
(e.g. calling handleRequest() from another form or any redirection)
refs #5525
2014-08-25 17:06:45 +02:00
c93ab7951d
Check whether a form's data was sent instead of whether it's complete
...
It is not sufficient to just check whether all required elements are being
submitted. We definetely need to check whether the submit button was
pressed. But doing this and providing a standard button with a static name
simultaneously will produce conflicts if forms are using the same action
urls. To fix this, we'll add an additional form-identification check by using
a form's name or class.
refs #5525
2014-08-25 16:49:54 +02:00
7b221e2aba
It should not be a form's responsibility how its submit button should look..
...
...in case it's a standard button. No need to be DRY here.
refs #5525
2014-08-22 15:20:54 +02:00
2b879b344f
Do not populate using createElements() and fix documentation blocks
...
refs #5525
2014-08-22 12:04:14 +02:00
9c5878cbbe
ConfigurationError: extend IcingaException
...
refs #6931
2014-08-22 11:46:11 +02:00
1886569174
Implement Module self provided configuration for menus
...
refs #6639
2014-08-22 11:35:42 +02:00
bb7972aa39
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/controllers/AuthenticationController.php
application/controllers/ConfigController.php
application/forms/Authentication/LoginForm.php
application/forms/Preference/GeneralForm.php
modules/monitoring/application/controllers/ChartController.php
2014-08-20 13:13:50 +02:00
995355ec30
lib/Limiter: fix translate w/ sprintf
2014-08-19 16:29:11 +02:00
f49a34625e
Url\Params: check for QUERY_STRING before using it
...
fixes #6957
2014-08-19 14:53:56 +02:00
db3ef8fbd0
ActionController: remove redirectToLogin default
...
The redirectOnLogin function now doesn't have any predefined default.
This also leads to the behaviour that "Logout" will not redirect you
anywhere on a new login while "forcibly being logged out" (e.g. by
logging out in another browser tab) will bring you back to where you
came from.
2014-08-19 12:28:24 +02:00
9d4a4f49c9
ActionController: JS should redirect to __SELF__...
...
...once you lost your session. That's the only way to do this in a
smooth way. When the server get's an unauthenticated request for a
single container, redirecting to auth/login?redir=<that-container>
was not what you expect.
Together with JS handling __SELF__ in redirection URLs this will
play fine.
refs #6935
2014-08-19 09:57:24 +02:00
b9cc964e24
Url\Params: remove() should reindex on change
...
There was a small bug, fixed.
refs #6699
2014-08-19 09:49:53 +02:00
344909dfcd
Web\UrlParams: add() and set() should encode...
...
...while there is now a addEncoded function, mostly for internal use.
refs #6699
2014-08-19 09:45:58 +02:00
217595dc15
Web/Url: more intuitive separator usage
...
One might not expect to get a URL with params separated by & while
this is the correct way of writing them to HTML attributes. So default
behaviour is right now that all functions return URL params separated
by &, but if you cast a URL (or it's params) to a string, & will be
used.
Additionally there are toString functions allowing you to choose the
separator "manually".
refs #6699
2014-08-19 09:42:16 +02:00
7caccd7691
Web\Url: remove stripUrlFragment()
...
This function had an interesting history and seems to be a result of
missunderstanding of each others commits. Removed, as the fragment is
already there.
refs #6699
2014-08-19 09:36:15 +02:00
f2ed813c9a
Fix that Icinga\Web\Url::fromPath drops fragments
...
fixes #6284
2014-08-14 14:23:31 +02:00
666591beb7
Encode url before passing it to Icinga\Form\Dashboard\AddUrlForm
...
fixes #6611
2014-08-13 16:41:40 +02:00
7311ab964e
Do not set the full url from the request as action with form parameters
...
Setting an url with parameters named like form elements in a form with
method POST causes Zend to ignore any POST data because GET will be
processed with higher priority.
fixes #6806
2014-08-13 14:50:21 +02:00
e7da9c0a00
Make our anti CSRF logic being a form element
...
refs #5525
2014-08-12 14:43:10 +02:00
fe63ce664f
Make use if 'ignore´ instead of explicitly unsetting array keys
...
refs #5525
2014-08-12 13:57:28 +02:00
4b1169c0a1
Fix improper form submission
...
refs #5525
2014-08-12 10:41:19 +02:00
8f729bfb65
ActionController: set a default window title
...
In case a controller action didn't set a view title this fix restores
the default title on XHR requests.
fixes #6797
2014-07-31 17:04:26 +02:00
c3731fa79e
Adjust removeresource-action to suit the new resource form interface
...
refs #5525
2014-07-24 16:17:30 +02:00
a68ccecb28
Revert "Do not use htmlspecialchars in widgets"
...
This reverts commit 2ff43abcf5
2014-07-23 12:28:04 +02:00
2ff43abcf5
Do not use htmlspecialchars in widgets
...
refs #6759
2014-07-23 12:12:05 +02:00
8b2cc3a558
Do not consider <button type=submit> when checking form completion
...
refs #5525
2014-07-23 10:58:45 +02:00
0bf0213547
Rename Form::addElement to Form::createElement
...
Since we are using mainly createElement and addElement is only an alias for
createElement if no object is passed our changes to addElement can safely
be moved to createElement.
refs #5525
2014-07-23 10:57:46 +02:00
25c9ee567d
Add missing use statement for Zend_View_Abstract
2014-07-23 10:54:22 +02:00
75e09f2c69
Do not consider submit buttons when checking form completion
...
refs #5525
2014-07-21 15:25:00 +02:00
091ddbe552
Partiall revert bfc54b7e
...
Refactor Url->getParams() to return an instance of UrlParam instead of an array.
fixes #6760
2014-07-21 09:22:19 +02:00
f5ac592645
Do not consider disabled elements when checking form completion
...
Values of disabled inputs are not sent by browsers.
refs #5525
2014-07-21 08:57:41 +02:00
f4ff2c90f2
It's a form's responsibility how its submit button should look like
...
refs #5525
2014-07-18 09:54:36 +02:00
6ac471c598
Also mention the viewscript functionality of Form::loadDefaultDecorators()
...
refs #5525
2014-07-18 09:52:50 +02:00
8f0b9899a3
We cannot know what kind of data is passed to Form::isValid()
...
refs #5525
2014-07-18 09:52:05 +02:00
78a6175acc
Make form creation lazy and implement the new validation mechanism
...
Form creation must not depend on specific function calls. If a forms' elements are required and missing, create them. Form::isValid() must be
able to determine whether a form can be processed or not without to rely
on a particular button value.
refs #5525
2014-07-18 09:51:15 +02:00
37fd3deb67
Rename initCsrfToken to addCsrfToken and move it upwards
...
Form::addCsrfToken() should be public and fluent to ensure more
flexibility.
refs #5525
2014-07-18 09:43:03 +02:00
58188c5cc1
We only want to rely on Form::isValid() when about to process forms
...
As the new auto-submission implementation does not depend on whether
a submit button was pressed or not we need another way to determine
whether a form should be processed.
refs #5525
2014-07-18 09:33:09 +02:00
802c095bf8
Configuration values need to be inserted to forms explicitly
...
It's the controllers' responsibility to ensure that forms are populated with
configuration values on GET requests.
refs #5525
2014-07-18 09:27:10 +02:00
21cd503ee7
Form buttons need to be added explicitly
...
We either demand the user to add a submit button or provide a implicit
function call to be implemented by him, adding additional elements once
the form gets rendered.
refs #5525
2014-07-18 09:24:49 +02:00
47ae4d79dc
Forms do not need a special title property
...
As our upcoming wizard has no menu and our tabs are hardcoded we do not
need a special "title" property anymore.
refs #5525
2014-07-18 09:21:11 +02:00
1de2d0c14f
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Authentication/LoginForm.php
library/Icinga/Test/BaseTestCase.php
library/Icinga/Web/Form.php
library/Icinga/Web/Form/Decorator/BootstrapForm.php
2014-07-17 13:15:42 +02:00
bfc54b7e32
Fix array conversion of the Dashboard and its Components
...
Do not omit the parameters when converting the dashboard components to
an array. Add an array conversion to the UrlParams class.
refs #6691
2014-07-16 17:31:01 +02:00
5c507d5d91
Fix notice that the session has been already started after retrieving its id
2014-07-16 15:39:40 +02:00
e6dee9fe89
Protect login against CSRF
...
refs #5626
2014-07-16 09:55:23 +02:00
19f05256a0
Only call session_start() when reading from session
...
fixes #6383
2014-07-16 09:55:22 +02:00
3105c2059e
Remove license headers from all files
...
refs #6309
2014-07-15 13:43:52 +02:00
e567ad67c5
Display statehistory summary vertically
...
fixes #6636
2014-07-14 15:26:35 +02:00
0dce204651
Refactor Icinga\Web\Form
...
We eagerly waited badly for a new approach to build forms, so here it is.
Should be the best compromise between the Zend_Form functionality and
our requirements regarding automatic submits.
refs #5525
2014-07-10 11:13:45 +02:00
1a1263d9d8
Rename Icinga\Web\Form\Decorator\BootstrapForm
...
We do not use bootstrap anymore but do not want the default Zend
decorators either so this decorator got a more common name.
refs #5525
2014-07-10 11:09:48 +02:00
49c679fe0f
FilterEditor: hide "add" links
...
They where there to show how this should look like. Removed for now as
they are not implemented yet.
refs #6668
2014-07-08 17:21:36 +02:00
bb2c85f90b
Remove forgotten ActionController::requiresConfig() call
...
Should have been reverted by last commit but was not.
2014-07-07 16:12:26 +02:00
82d2f5ac9b
Revert "Merge branch 'feature/install-wizard-6136'"
...
This reverts commit 88d4262e7c6fae333048
2014-07-07 15:09:03 +02:00
0d4166b1bd
ModuleActionController: fix reference, var removed
2014-07-04 12:39:23 +02:00
3cfdf4c977
Web\Response: add redirection function
...
The response now provides redirectAndExit(). One more step to clean up
our action controller. Please not that this is still unused right now.
2014-07-04 12:35:33 +02:00
3772b9c16f
ActionController: set layout module name early
...
Didn't work correctly before
2014-07-04 12:33:49 +02:00
143a1e44fe
Add a HTML renderer for Icinga\Web\Menu
...
The menu was being rendered through recursive partials before. The
overhead this fact implicates is not as efficient as standard recursion
so there is now a special renderer for Icinga\Web\Menu utilizing
the RecursiveIteratorIterator
refs #6153
2014-07-03 15:46:46 +02:00
be18af7e7e
Merge Icinga\Web\MenuItem into Icinga\Web\Menu
...
We do not need an additional class for the menu's root item just to
encapsulate our config handling, so these two classes were now merged
into a single one. Icinga\Web\Menu now also extends from
RecursiveIterator to be able to render the menu more efficient to html.
refs #6153
2014-07-03 15:14:47 +02:00
7eb0f3c472
Remove @codingStandardsIgnoreStart/-Stop annotations
...
refs #6091
2014-06-30 13:59:58 +02:00
f2e5d8afa5
Remove @codeCoverageIgnoreStart/-Stop annotations
...
refs #6091
2014-06-30 13:58:37 +02:00
62928c48b0
helpers/timeSince: fix c&p error
2014-06-27 23:37:39 +02:00
7112ed23f4
Chart\InlinePie: locale-ignorant cast for floats
...
This has already been fixed with 92f454c3be0c5d4b#6348
2014-06-25 22:13:19 +02:00
10d1520711
Widget\Limiter: show "all"
...
In case we pass limit=0 we show this, still unsure whether we should
provide a link for "showing all" - might really hurt with millions of
history rows.
2014-06-25 20:39:10 +02:00
59dd80ed32
ActionController: benchmark should measure rendering
...
We have been cheating a little bit, now the measurement should be more
precise.
2014-06-25 20:37:17 +02:00
d49f30ff77
Improve InlinePie performance
...
Use str_replace instead of preg_replace
2014-06-25 15:24:53 +02:00
7b19bd1d99
Improve interface of InlinePie
...
Method setLabel can also accept a simple string and title is mandatory in constructor
2014-06-25 15:21:12 +02:00
8839166090
Add number format 'none' to InlinePie
2014-06-25 14:53:39 +02:00
35a5431512
Revert "Refractor InlinePie and Perfdata helper"
...
This reverts commit f003c38abd
2014-06-25 14:29:17 +02:00
f003c38abd
Refractor InlinePie and Perfdata helper
...
Refractor InlinePie methods for better usability, fix several coding guideline
issues and fix some typos
2014-06-25 12:41:17 +02:00
4591297e56
SortBox: use POST instead of GET
...
This avoids trouble with complex filter URLs
fixes #6556
2014-06-25 11:00:10 +02:00
1dcf44b9cd
FilterEditor: fix buggy dropdown boxes
...
There were some issues with option names. Also cleaned up HTML a
little bit and added autosubmission.
2014-06-25 10:37:06 +02:00
b40d0f6a1e
FilterWidget: POST instead of GET
...
Might have been a JS issue, but instead of messing with the URL just
POSTing is easier here - and works. Filters from the search box are
now added flawlessly to the filter tree.
2014-06-25 10:34:09 +02:00
2746b5ff9f
ConfigController: switch over to new config tabs
...
Module configuration now takes place in module detail view and does no
longer pollute our config tabs. Modules are now able to provide a bunch
of own config tabs, we don't really care what they use them for.
2014-06-24 21:31:59 +02:00
b38bcfc19b
Widget\FilterEditor: correct expression output
...
Filter expressions should be filled into form fields exactly as we
expect them at parse time.
fixes #6568
2014-06-24 21:00:01 +02:00
47b893e1ea
Widget\FilterEditor: handle custom vars
...
There was an issue with custom vars as they made only partially part
of the column dropdown. Sorted columns and tried to beautify column
names.
fixes #6569
2014-06-24 20:57:41 +02:00
3f9f4bb9e1
ModuleActionController: module object shortcut
...
This helps modules with the need to know more about themselves. No
more App -> Module Manager -> Module voodoo.
2014-06-24 20:54:39 +02:00
b7b99cfd67
Widget\AlertMessageBox: fix broken widget
...
This widget is pretty useless as the error view script can to it's
job. Interestingly nobody missed it, even the render() call was wrong.
I guess we will remove this soon, but for now it's fixed. Looks ugly,
but works.
2014-06-24 20:30:41 +02:00
ba9a633b73
Web\Form: relax form submission check
...
We have to live with some badly designed forms right now. Some have
submit buttons but don't know about, others don't have such but link
to foreign controllers fiddling with the form and adding different
button AFTER the form got submitted - it's a mess.
Relaxing the submission check to "just check whether btn_submit has
a value" fixes most of this. However I do not consider this being a
solution for the long run.
fixes #6423
fixes #5967
refs #6540
2014-06-23 13:31:34 +02:00
ea44de8698
ActionController/translate: detect domain only once
2014-06-22 20:09:23 +02:00
23ed744747
params/_render: replace it everywhere
...
Cleaning up controllers and JS, using headers only and respecting
history.
2014-06-22 20:07:44 +02:00
61600ae2d4
ModuleActionController: fix typo
2014-06-22 19:39:54 +02:00
997587d729
Chart\InlinePie: remove ugly default border
2014-06-22 16:38:12 +02:00
216f0f3f55
isIframe: clean up, load less html and js
...
We use isIframe only when we have no JS, therefore it makes no sense
to load JS files in an iFrame. Also removed sidebar.
2014-06-22 16:30:06 +02:00
3b84078b2f
Params/_render: get rid of it, start with iframe
2014-06-22 16:18:23 +02:00
bb23d0636c
ModuleActionController: use isXhr()
2014-06-22 16:04:55 +02:00
3774eb6889
ActionController: add isXhr() method
...
Makes things easier as we use this a lot
2014-06-22 15:36:41 +02:00
331d756a2a
ActionController: isolate ignoreXhrBody
...
This function is only a workaround for broken forms not redirecting
after submission. Will hopefully be removed soon.
2014-06-22 15:33:38 +02:00
b4f8ef74fa
ActionController: remove obsolete code
2014-06-22 15:20:55 +02:00
631603aba3
ActionController: create postDispatchXhr
...
Moved XHR-specific stuff to a dedicated post-dispatch function
2014-06-22 15:17:28 +02:00
Johannes Meyer
Matthias Jentsch
Eric Lippmann
Alexander Fuhr
Thomas Gelf
Marius Hein
Alexander Klimov
Matthias Jentsch