d1b1bc368f
Monitoring_ConfigController: don't use SecurityForm::isSubmittedAndValid()
...
refs #5525
2014-08-21 11:51:49 +02:00
b81e96574a
SecurityForm: replace create() with createElements() and add addSubmitButton()
...
refs #5525
2014-08-21 11:48:07 +02:00
11063495b2
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
modules/monitoring/application/controllers/ConfigController.php
2014-08-21 10:22:16 +02:00
b146a8c311
Relax locale code validation to just a format check
...
fixes #6930
2014-08-21 10:07:07 +02:00
b36fe5d564
Fix version access while refreshing translations
2014-08-21 10:07:07 +02:00
a8d33d90e2
Monitoring\Object: fix a couple of cv-related issues
...
* Don't throw exceptions with no config
* Provide a secure default if not configured
* Improve code readability
2014-08-20 13:36:03 +02:00
bb7972aa39
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/controllers/AuthenticationController.php
application/controllers/ConfigController.php
application/forms/Authentication/LoginForm.php
application/forms/Preference/GeneralForm.php
modules/monitoring/application/controllers/ChartController.php
2014-08-20 13:13:50 +02:00
bb65fb396a
Merge branch 'bugfix/sensitive-custom-vars-6641'
...
fixes #6641
2014-08-20 12:29:45 +02:00
78b98a7d67
SecurityForm: Add helptext
...
refs #6641
2014-08-20 12:21:11 +02:00
09dfcca0bc
Merge branch 'master' into bugfix/styled-history-views-6637
2014-08-20 11:39:03 +02:00
4ceecf1146
Let comment view look more standardized and add limit control
...
refs #6637
2014-08-20 11:34:24 +02:00
071937910b
Monitoring/Object: filter protected customvars
...
Move the responsibility from the viewscript to Monitoring/Object
refs #6641
2014-08-19 18:46:37 +02:00
ba748cbc4a
Refactor multiSelect and highlight
...
refs #6705
2014-08-19 18:33:28 +02:00
ea0248ecf4
Remove '{{SAVE_ICON}}', tiny design fixes
...
refs #6641
2014-08-19 17:54:22 +02:00
6fe47bf5b0
Fix rows highlighting after refresh
...
fixes #6705
2014-08-19 17:32:17 +02:00
3573908071
Let downtime view look more list-like and fix downtime end calculation
...
refs #6637
2014-08-19 17:03:35 +02:00
8c02f140c3
doc: fix translate calls w/ sprintf
2014-08-19 16:22:54 +02:00
3e079efe2a
SecurityForm: replace `customvars' with `protected_customvars'
...
refs #6641
2014-08-19 14:51:30 +02:00
7035099468
Fix the host_unhandled_service_count error
...
fixes #6833
2014-08-19 14:43:24 +02:00
65473ac8ee
Monitoring config: use SecurityForm
...
refs #6641
2014-08-19 14:04:00 +02:00
1ba3954b95
Monitoring config: implement SecurityForm
...
refs #6641
2014-08-19 14:02:26 +02:00
6b468b7f9b
Monitoring_ConfigController: make writeConfiguration's parameter `file' non-required
...
refs #6641
2014-08-19 13:51:10 +02:00
1c74fd7028
Merge branch 'master' into feature/display-documentation-4820
...
Conflicts:
modules/doc/library/Doc/DocParser.php
2014-08-19 13:39:48 +02:00
55b3a5384a
doc: set page title
...
refs #4820
2014-08-19 13:38:18 +02:00
d35e0816c9
doc: use `sprintf' in exceptions
...
refs #4820
2014-08-19 13:20:46 +02:00
127e4f444f
doc: show prev chapter, index and next chapter links
...
refs #4820
2014-08-19 11:30:56 +02:00
0464099764
Monitoring: implement "Security" config tab
2014-08-19 11:19:30 +02:00
5c52e447f5
doc: upper case first character of a documentation's title
...
refs #4820
2014-08-19 10:26:38 +02:00
a333c3e57b
DocParser: remove explicit call to getRelativeUrl
...
As this URLs will get rendered we want them to be automatically casted
resulting in correct URLs with &
refs #6699
2014-08-19 10:07:46 +02:00
cb17590b71
doc: rename `nofollow' to `noFollow'
...
refs #4820
2014-08-19 09:57:22 +02:00
289aed8420
doc: Use `chapterId' instead of `chapterTitle' in URLs
...
Manually given chapter IDs are meant to not change while a chapter's title could change.
refs #4820
2014-08-19 09:45:53 +02:00
332be22f7e
Fix object history dates make output look similar to the event history
...
refs #6637
2014-08-18 15:32:12 +02:00
bbddb9ed87
Add limit-control and fix indentation of the eventhistory view
...
refs #6637
2014-08-18 15:30:59 +02:00
043688e514
Make event history view more fancier
...
refs #6637
2014-08-15 17:03:03 +02:00
cae84a5d7f
Fix float formatting of timeline circle margins and widths
...
fixes #6926
2014-08-15 13:39:02 +02:00
54461f9319
Treat hard states more severe than soft states
...
fixes #6571
2014-08-15 12:40:56 +02:00
dc8181cdc5
Escape linefeeds and carriage returns in commands and show them as html
...
fixes #6088
2014-08-14 10:23:04 +02:00
b5d6481c12
Make it possible to translate the process info view
...
refs #6610
2014-08-13 15:52:33 +02:00
7311ab964e
Do not set the full url from the request as action with form parameters
...
Setting an url with parameters named like form elements in a form with
method POST causes Zend to ignore any POST data because GET will be
processed with higher priority.
fixes #6806
2014-08-13 14:50:21 +02:00
fe63ce664f
Make use if 'ignore´ instead of explicitly unsetting array keys
...
refs #5525
2014-08-12 13:57:28 +02:00
f23bf912eb
Remove obsolete use statements
2014-08-12 09:49:52 +02:00
be14844fa8
Merge EditInstanceForm with CreateInstanceForm and rename it
...
As with the backend form, a user might like to change the name of an
instance. The new form and its actions are also adjusted to suit the new form interface.
refs #5525
2014-08-11 14:49:42 +02:00
96925487bd
CLI/monitoring/list: fix DataView-related exception
...
This uses the renamed DataView serviceStatus instead of the former
status and fixes the problem that CLI still assumed to have fetch
and count function on the DataView.
fixes #6777
2014-07-31 17:24:56 +02:00
51484ebf88
monitoring/Perfdata: ignore invalid min/max
...
key=23;0;0;0;0 and key=23;;;; lead to division by zero exceptions
This should fix this by ignoring empty strings for min/max (formerly
it got "converted" to float(0)) and also ignores min == max.
fixes #6828
2014-07-31 16:52:34 +02:00
f9e8ad3d0b
doc: Remove 'locale' directory
...
Since #6432 has been fixed, the empty locale directory can be removed.
refs #4820
2014-07-29 11:45:16 +02:00
f6b9b13654
doc: Rename 'chapterName' to 'chapterTitle'
...
refs #4820
2014-07-29 11:19:40 +02:00
3cafc8910a
doc/DocParser: Rename 'header' to 'title'
...
refs #4820
2014-07-29 11:12:06 +02:00
38a6df91b9
doc/DocParser: Rename 'chapterName' to 'chapterTitle'
...
refs #4820
2014-07-29 11:10:49 +02:00
55d3818ebb
doc/SectionRenderer: Support images
...
refs #4820
2014-07-29 11:10:06 +02:00
034923d886
Merge branch 'master' into feature/display-documentation-4820
2014-07-28 19:17:50 +02:00
788e3eb6fc
doc: No longer use separate view scripts
...
refs #4820
2014-07-28 19:17:03 +02:00
9eb4b62cd0
doc: Register PDF route
...
refs #4820
2014-07-28 19:15:44 +02:00
88312e6284
doc/lib: Add `SectionFilterIterator' for iterating over sections that are part of a particular chapter
...
refs #4820
2014-07-28 19:11:59 +02:00
79f6130e3c
doc/lib: Add `SectionRenderer' for rendering instances of `DocTree' as sections
...
refs #4820
2014-07-28 19:11:15 +02:00
8a229e15ab
doc/lib: Add `TocRenderer' for rendering instances of `DocTree' as toc
...
refs #4820
2014-07-28 19:10:40 +02:00
0033733062
doc/lib: Add `Renderer' as base class for toc and section renderer
...
refs #4820
2014-07-28 19:09:55 +02:00
134db3fc66
doc/DocParser: Replace `getDoc()' and `getToc()' with `getDocTree()'
...
refs #4820
2014-07-28 19:09:04 +02:00
51bc0274f3
doc/lib: Add `DocTree' for representing a documentation as tree of sections
...
refs #4820
2014-07-28 19:06:12 +02:00
c71086c748
doc/lib: Add `Section'
...
In the future a documentation will be represented as tree of sections.
refs #4820
2014-07-28 19:00:50 +02:00
c325c09293
doc/DocIterator: Use `NonEmptyFileIterator'
...
Considering empty files makes no sense.
refs #4820
2014-07-28 18:59:42 +02:00
4f8cbb99dd
doc/lib: Add `NonEmptyFileIterator' for iterating over non-empty files
...
refs #4820
2014-07-28 18:58:46 +02:00
71e81087b3
doc/ChapterNotFoundException: Remove unnecessary line breaks
...
refs #4820
2014-07-28 18:57:46 +02:00
77f8a3d67d
doc/DocEmptyException: Remove unnecessary line breaks
...
refs #4820
2014-07-28 18:55:54 +02:00
a0c331020b
doc/DocException: Extend `RuntimeException' instead of `Exception'
...
Errors in the documentation module can only be found on runtime.
refs #4820
2014-07-28 18:53:41 +02:00
507ac1c4d7
doc/MarkdownFileIterator: Nail down PHPDoc
...
refs #4820
2014-07-28 18:52:25 +02:00
5a738112ea
Remove isExistingBackend/-Instance
...
It is more efficient to access configuration files only once instead of
accessing them multiple times in different locations.
refs #5525
2014-07-25 16:02:13 +02:00
d7ed6bd249
Adjust removebackend-action to suit the new backend form interface
...
Drops additionally the ConfirmRemovalForm of the monitoring module
as there is already one in icingaweb2's form-set.
refs #5525
2014-07-25 16:00:38 +02:00
a78d11345b
Adjust createbackend-action to suit the new backend form interface
...
refs #5525
2014-07-25 15:58:44 +02:00
b743cf8143
Adjust editbackend-action to suit the new backend-form interface
...
refs #5525
2014-07-25 14:55:36 +02:00
488ea4633d
Merge EditBackendForm with CreateBackendForm and rename it
...
It is not necessary to distinct between whether a backend is created or
edited as a user perhaps likes to change the name of a backend directly
instead of the need to remove and recreate it.
refs #5525
2014-07-25 14:50:53 +02:00
af5a3262be
Revert backslash removal in front of namespace-less use statement
2014-07-25 09:12:12 +02:00
26d42da635
Re-add getResourcesByType as simplified version
...
refs #5525
2014-07-25 08:58:50 +02:00
a6bd802e3e
Remove unnecessary properties and its getters/setters
...
refs #5525
2014-07-25 08:58:11 +02:00
5f7652133e
Fix code-style and documentation
2014-07-25 08:39:27 +02:00
a4b7204e23
Contactgroups view: correct links to contacts detail pages
...
fixes #6514
2014-07-23 13:10:09 +02:00
a2809552f2
Do not use htmlspecialchars in view scripts
...
fixes #6759
2014-07-23 12:41:05 +02:00
9269a0cbd5
Revert "Do not use htmlspecialchars in view scripts"
...
This reverts commit 607aa9b203
2014-07-23 12:29:27 +02:00
607aa9b203
Do not use htmlspecialchars in view scripts
...
fixes #6759
2014-07-23 12:12:49 +02:00
9af89e6ccf
doc module: style h[1-6], table and code
...
Headers have different sizes
Tables have borders
Table headers are left-aligned
Codes are displayed inline (except inside pre) and have scrollbars if necessary
refs #6484
fixes #6632
2014-07-23 11:28:45 +02:00
cb27a3d0f1
Do not use height and width in bar charts, to avoid layout errors
2014-07-22 17:57:40 +02:00
e005333806
Merge branch 'master' into feature/display-documentation-4820
2014-07-22 12:25:58 +02:00
0a500efd8a
Determine the max value in LinearUnit dynamically
...
The range between min and max should always be divisable by the amount of
ticks, to ensure that the vertical lines are always at a full discrete value.
fixes #6769
2014-07-21 17:21:54 +02:00
53c9292b41
Fix BarChart padding in Dashboard
...
Use max-width instead of width in the chart layout to make better use of the available space, but prevent the charts from growing too big. Use a bigger weight and height in the default dashboard configuration.
fixes #6744
2014-07-21 13:06:35 +02:00
f9a274d079
Add contact detail view
...
refs #4804
refs #6514
2014-07-18 17:35:24 +02:00
96d3406446
Prefer style="clear: both;" rather than Bootstrap's class="clearfix"
2014-07-17 17:46:28 +02:00
882699201d
Contacts: replace foreach loop with hardcoded HTML and move the styles to a CSS file
2014-07-17 17:33:45 +02:00
eca0d50bae
Don't use printf format strings as array keys
...
An array with printf format strings as keys looks pretty ugly
2014-07-17 11:26:18 +02:00
4d199180b3
We do not want to access $_POST directly if it is possible to avoid it
2014-07-17 09:28:10 +02:00
b7f5c8a84d
Fix that the default sort order of a view is not being applied
...
fixes #6644
2014-07-17 09:28:10 +02:00
b23e36aa1a
Swap array keys and values
...
Non-hardcoded keys may be not unique
2014-07-16 17:54:06 +02:00
62da942159
Don't close and re-open php tags, remove unneeded spaces
...
To close and re-open php tags makes no sense if there's nothing between them
2014-07-16 17:54:06 +02:00
1ad263170e
Revert "Small fixes"
...
This reverts commit 8086292b1b
2014-07-16 15:30:20 +02:00
f1d7cd8b50
Remove forgotten coding standards annotation
2014-07-16 13:59:43 +02:00
cb04c42bab
Use htmlspecialchars to prevent attacks
2014-07-16 13:10:28 +02:00
8086292b1b
Small fixes
2014-07-15 18:00:52 +02:00
4c415aac5c
Make contacts' view look more like contactgroups' view
2014-07-15 16:17:02 +02:00
3105c2059e
Remove license headers from all files
...
refs #6309
2014-07-15 13:43:52 +02:00
d021ddebee
Make contacts' view work like the downtimes' one
...
fixes #6513
2014-07-15 10:47:12 +02:00
bacea36ad9
Improve piechart limitation and show non-piechart perfdata as well
...
The perfdata helper did an improper limitation as it might have skipped
valid values due to applying the limit before the filter. When not in compact
view the helper now also shows non-piechart values by using their raw
representation.
refs #6515
2014-07-14 13:48:30 +02:00
5908e9fc70
Do not show pie charts for perfdata values when no percentage is available
...
refs #6515
2014-07-11 16:32:05 +02:00
ec2d1daa6b
Perfdata plugin should also have a knowledge about labels
...
Prior to this change the PerfdataSet only knew the labels of a performance
data value which prevented the Perfdata object from being used
individually.
refs #6515
2014-07-11 16:31:00 +02:00
906c132dc0
Merge branch 'master' into feature/display-documentation-4820
2014-07-11 16:05:09 +02:00
b4dc0f38b3
Fix monitoring backend configuration not showing resource selection fields
...
fixes #6448
2014-07-10 15:50:52 +02:00
53f3d74103
Fix word wrapping in perfdata labels and values
...
fixes #6377
2014-07-10 14:54:53 +02:00
b85ac3ab45
Translate labels in the ChartController
2014-07-09 18:13:40 +02:00
8d697a3d8e
Fix coding style
2014-07-09 18:13:40 +02:00
0d92efc1b0
Consider is_active column when fetching host and service statistics
...
fixes #6157
2014-07-09 11:49:22 +02:00
2b05aa9504
monitoring/list: do not apply empty filter
...
Fixes problems with the servicematrix when no filter is applied.
I'm not yet happy with this, calls to where() should automagically
handle existing empty filters.
fixes #6543
2014-07-08 16:36:05 +02:00
9a6821c860
monitoring/list/hosts: restore page behaviour
...
The problem here was that an accidentally removed closing div tag in
15325949
2014-07-08 15:17:00 +02:00
1950c09478
Remove encoding suffix from locale identifiers
...
We do not need those as the encoding of a gettext-catalog is already
mentioned in its header.
refs #6602
2014-07-07 09:09:22 +02:00
e3b2f15863
list/hosts: show unhandled services righthand
...
This way we automagically fix the problem with the wrong row links.
I guess we should re-introduce the "row-action" class allowing "precedence"
rules, so also a link not being the first one in a row could act as "row-link".
Changed formatting / text output a little bit, IMO even more cure is needed.
fixes #6645
2014-07-04 18:13:44 +02:00
d2098be625
Only display header when not in compact mode
...
fixes #6508
2014-07-04 12:45:17 +02:00
db5c6631d9
Merge branch 'master' into feature/display-documentation-4820
...
Conflicts:
modules/doc/library/Doc/Controller.php
2014-07-01 12:42:55 +02:00
2ea418cbe6
doc module: Respond with 404 if a chapter was not found or the doc directory is empty
...
refs #4820
2014-06-30 15:48:43 +02:00
1bbfa9b9ca
doc module: Let `DocParser' throw `DocEmptyException' and `ChapterNotFound' exception
...
`DocEmptyException' is thrown during construction when a documentation directory is empty.
`ChapterNotFound' is thrown when a chapter was not found when calling `getChapter()'.
refs #4820
2014-06-30 15:24:40 +02:00
c48f7f9fba
doc module: Add `DocIterator::count()'
...
Method used to count available markdown documentation files.
refs #4820
2014-06-30 15:22:32 +02:00
a8e6dda783
doc module: Add `DocEmptyException'
...
refs #4820
2014-06-30 15:21:35 +02:00
0382e2265c
doc module: Add `ChapterNotFoundException'
...
refs #4820
2014-06-30 15:21:16 +02:00
93cc24a93a
doc module: Move `DocException' beneath `Exception' namespace
...
There are more exceptions to come which also will be beneath the `Exception' namespace.
refs #4820
2014-06-30 15:18:22 +02:00
f3172b96e4
Remove missed echo instruction for debug purposes
2014-06-30 14:06:11 +02:00
7eb0f3c472
Remove @codingStandardsIgnoreStart/-Stop annotations
...
refs #6091
2014-06-30 13:59:58 +02:00
71bd784992
Add files to skip during coverage generation to the global ignore list
...
refs #6091
2014-06-30 13:55:11 +02:00
9a1b7179e1
Fix violations of coding guidelines
2014-06-30 12:33:51 +02:00
7fe056d03a
Display note when host and service is not found
...
When the show/host and show/service views do not find a host or service,
don't show a non-working view, but display a error message
fixes #6469
2014-06-30 12:33:51 +02:00
a2fa5c055c
Display a message when a list view is empty
...
fixes #6469
2014-06-30 12:33:51 +02:00
e73471030c
doc/modules/index: Only list modules which have the 'doc' directory
...
refs #4820
2014-06-30 11:43:25 +02:00
1532594948
Deduplicate code: lists/hosts.phtml VS lists/hosts-compact.phtml
...
fixes #6541
2014-06-27 11:53:08 +02:00
a4fc6dedea
monitoring/list: fix limit=0 check
...
This used to be fixed, but got accidentally re-broken by last commit
this night.
2014-06-26 16:34:37 +02:00
7f99be73fd
Adjust usages of Icinga\Util\File to suit the new interface introduced earlier
2014-06-26 15:57:14 +02:00
a91bbd3a75
monitoring/list: add stateType parameter
...
This allows one to show only hard states, useful for support dashboards.
2014-06-26 00:42:38 +02:00
c85a0ac11e
list/limits: special treatment for 0 only, not null
2014-06-26 00:39:10 +02:00
d44f89f287
list/hosts: fix downtime icon
...
I re-enabled host list icons, they have been missing for a while. The
downtime icon logic used to be inverted, this fixes it. Also showing
acknowledgements now even if object is in downtime.
2014-06-25 21:46:03 +02:00
ff9c29472e
monitoring/status: re-introduce comments, problems
...
This re-introduces expensive columns been disabled time ago and adds
even more to it. We are now showing last comment, last ack comment and
service problem count on hosts in list views.
It still costs performance, but seems that we can stand it. I'd like
to add more like this to the host view.
2014-06-25 21:42:24 +02:00
d634889acb
DataView: ignore case on sort dir
...
fixes #6573
2014-06-25 21:34:05 +02:00
11ce302be0
Ido\StatusQuery: fine-tune query filters
...
This is still experimental. We normalize a lot of columns, this allows
us to sort in a convenient way while having nice "showable" columns.
When used as filters (same goes for ordering) however, functions and
operations on table columns often hinder the db from using indexes.
The new filter implementation allows us to override query creating per
single column, that's what this first sample is trying to show. We still
need to fix alias handling, so unfortunately I have to deal with "real
columns" in the case construct.
Performance gain in large environments is impressive, more to come.
2014-06-25 21:12:44 +02:00
86f70e0a4f
list/services: don't count with no limit
...
This is a performance evaluation right now, we might delegate such
logic to paginator later on. Cuts load time for lists and/or dashlets
with complicated filters by 50% - only for those with limit=0 of course.
2014-06-25 20:45:08 +02:00
32572ae653
Monitoring\Object\Service: don't load host comment
...
I'd like to reintroduce those columns, showing last object comment
and so one. Those joins are costly, we can fetch host comments way
easier directly from host object once we are here. But I guess we
don't even need it.
2014-06-25 20:21:19 +02:00
ae99dd39fd
Fix intendation in MultiController
...
Use spaces instead of tabs
2014-06-25 15:25:54 +02:00
7b19bd1d99
Improve interface of InlinePie
...
Method setLabel can also accept a simple string and title is mandatory in constructor
2014-06-25 15:21:12 +02:00
ae4aa9c182
Fix violations of coding guidelines
2014-06-25 15:07:39 +02:00
85aed364b7
Fix typing error in 'threshold'
2014-06-25 15:02:04 +02:00
35a5431512
Revert "Refractor InlinePie and Perfdata helper"
...
This reverts commit f003c38abd
2014-06-25 14:29:17 +02:00
f003c38abd
Refractor InlinePie and Perfdata helper
...
Refractor InlinePie methods for better usability, fix several coding guideline
issues and fix some typos
2014-06-25 12:41:17 +02:00
4591297e56
SortBox: use POST instead of GET
...
This avoids trouble with complex filter URLs
fixes #6556
2014-06-25 11:00:10 +02:00
b40d0f6a1e
FilterWidget: POST instead of GET
...
Might have been a JS issue, but instead of messing with the URL just
POSTing is easier here - and works. Filters from the search box are
now added flawlessly to the filter tree.
2014-06-25 10:34:09 +02:00
2746b5ff9f
ConfigController: switch over to new config tabs
...
Module configuration now takes place in module detail view and does no
longer pollute our config tabs. Modules are now able to provide a bunch
of own config tabs, we don't really care what they use them for.
2014-06-24 21:31:59 +02:00
ccdf1ca354
monitoring/ConfigController: use notifications
2014-06-24 21:28:01 +02:00
2b2901524c
ConfigController: useless use of render
2014-06-24 21:24:40 +02:00
532ab60b36
monitoring/show/history: fix html on empty list
...
This view script used to render broken HTML on empty result
2014-06-24 21:23:51 +02:00
f75a4430a6
monitoring/config: make use of Config()
...
Thee helper function supports lazy loading, requires less code and is
easier to read.
2014-06-24 21:22:38 +02:00
d5d3f5548f
monitoring/list/hosts: support addcolumns parameter
...
At least it doesn't fail right now, this only works for services so far.
View script still needs to be adjusted, will probably be done with #6541 .
2014-06-24 21:12:55 +02:00
9187cd11bb
monitoring/configuration: provide a config tab
2014-06-24 21:01:44 +02:00
51c57520ad
iconSubmitForm: replace with labelSubmitForm
...
There is no way in ZF to have an input[type=submit] with an unescaped
label ( = value). I temporarily replaced all iconSubmitForms with
inputs labelled with "X" - as all we used them for were delete
operations.
2014-06-23 14:42:26 +02:00
010466f8f9
Replace sizeof with count
...
Do not use sizeof to get the length of an array, as the function name 'sizeof'
is misleading
2014-06-23 14:19:55 +02:00
d199a8b036
CommandForm: input[type=submit] instead of button
...
No need for a "button" here. As they have been broken in ZF for
a long while we should better stay with input[type=submit]
fixes #5978
2014-06-23 14:10:15 +02:00
4d42b4d2c4
ScheduleDowntimeForm: replace obsolete ::fromRequest
...
A serious fix would involve passing the current backend to our
command forms.
2014-06-23 13:35:58 +02:00
bde6e29c61
Display a message instead of empty service matrix
...
refs #6535
2014-06-23 12:24:27 +02:00
0efd44e1b0
CommandForm: don't clear class
...
autosubmit class got cleared for no reason after enabling autosubmission.
Please note that the fact that their submission leads to a new form is
another issue.
fixes #6540
2014-06-23 11:27:06 +02:00
23ed744747
params/_render: replace it everywhere
...
Cleaning up controllers and JS, using headers only and respecting
history.
2014-06-22 20:07:44 +02:00
216f0f3f55
isIframe: clean up, load less html and js
...
We use isIframe only when we have no JS, therefore it makes no sense
to load JS files in an iFrame. Also removed sidebar.
2014-06-22 16:30:06 +02:00
3b84078b2f
Params/_render: get rid of it, start with iframe
2014-06-22 16:18:23 +02:00
2a0e72273a
ChartController: use correct ActionController
...
...and some code cleanup
2014-06-22 14:08:04 +02:00
b7fc0b67a8
Web/controllers: use own Request/Response objects
...
* introduces Icinga\Web\Response
* uses ModuleActionController where necessary
* no module translationDomain voodoo in base ActionController
2014-06-22 13:49:21 +02:00
ef5e1b54fd
Web\Window: fix it's usage, add helper function
...
Improved window handling, fixed controllers using it.
2014-06-22 13:21:21 +02:00
b03307196a
monitoring/list/services: hardcode margin once again
2014-06-21 05:27:10 +02:00
57ad88c38c
monitoring/process: was broken, fix it
...
Stumbled across two issues here:
* It's currently not possible to fetch all (*) columns from a DataView
* Backends are not able to tell their names
Worked around the first issue by naming all columns and implemented a
quick & dirty solution for the second one.
2014-06-21 04:25:02 +02:00
7f53ba11cf
Hook\Grapher: use it in monitoring/show
2014-06-21 04:13:14 +02:00
2ab75e1433
SelectionToolbar: temporarily disabled
...
Doesn't work as multiselect doesn't understand all filters
2014-06-21 03:33:16 +02:00
7b5d7bdbcf
monitoring/statehistorysummary: filter fixes
...
Slightly adjusted filter string to fit new filters, fixed an issue
with 'object_type' column in virtual eventhistory table.
2014-06-21 03:18:00 +02:00
b3cdeee35d
monitoring/timeline: should benefit from new filter
...
Different changes have been applied:
* Allow integer unix timestamps as parameters for timestamp columns
* Remove alias-rewriting from Url class
* Remove all traces of raw_timestamp
* Use new filters
2014-06-21 03:09:40 +02:00
e2f7a1054e
CSV/JSON export: work with new query interfaces
...
NB: I do not like the fact that we have to do as follows:
DataView->getQuery()->fetchWhatever();
Guess this is worth a few more proxy functions.
2014-06-21 00:09:11 +02:00
66f68f4990
monitoring/config: tab doesn't get focus
...
Fixes this. Tab handling is rather strange right now and module tabs
will not scale. We need a better solution for the future.
fixes #6320
2014-06-20 23:22:07 +02:00
c0c7a815f8
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
2014-06-20 19:18:38 +02:00
a904ff51aa
monitoring/eventhistory: improve query performance
...
This takes care of timestamp columns, modifies queries in a way not
depending on db functions, filters are passed through to subqueries
for better performance.
2014-06-20 19:14:34 +02:00
6d7a1cfe08
list/services: remove hardcoded margin
2014-06-20 19:12:46 +02:00
127b728a4c
list/notifications: fix query, select columns, style
2014-06-20 19:12:10 +02:00
e170c889d2
monitoring/CommandForm: remove obsolete classes
2014-06-20 14:24:32 +02:00
fb18de1f42
monitoring\CommandController: use new filters
2014-06-20 14:22:48 +02:00
f80b951cec
monitoring/ShowController: remove obsolete function
2014-06-20 14:21:29 +02:00
a8bde7cc14
monitoring/show/services: do not limit result
...
Still a little bit hackish, we will replace this once we have a request
object fully aware of our new UrlParams parser.
fixes #6511
2014-06-20 14:16:36 +02:00
4821c6e3e5
monitoring/show/history: use limiter, nicer output
2014-06-20 14:02:03 +02:00
65db5c4acc
list/services: move filterEditor to content
...
As it may occupy quite some space it is better having it scrollable
2014-06-20 13:50:25 +02:00
1bddcd7282
list/hosts,services: use limiter widget
2014-06-20 13:49:50 +02:00
f4b7075293
monitoring/multi: view script cleanup
...
They now play fine with new filters, tried to improve usability
2014-06-20 13:46:09 +02:00
f2c67ea047
MultiControllers: use new filters
...
This makes things easier, no more nested lists - just filters easy
to read and understand
2014-06-20 13:38:58 +02:00
255accb215
monitoring/MultiController: use correct controller
2014-06-20 13:35:25 +02:00
371b66bd8b
monitoring\ListController: handle filter editing
...
Handle filter modifications in one place. We still should try to
abstract this on step farther.
2014-06-20 13:26:10 +02:00
0642c9d33c
monitoring/list/hosts: filter-related cleanup
2014-06-20 13:24:32 +02:00
5dfd4aedac
monitoring/downtime: add missing ticket hook
...
We used to have this when showing comments, but not for downtimes.
2014-06-20 12:37:09 +02:00
ccb01aa152
Monitoring\Controller: add $url to all views
...
There are too many view scripts fiddling with namespaces. There is
still the url helper, not sure why it's not going to be used. I may
roll this back one far day...
2014-06-20 12:26:00 +02:00
ecf84077e5
Ido\CommentQuery: add host/service shortcut column
2014-06-20 12:23:23 +02:00
aae49ce0c0
Do not show tooltips for piechart areas that indicate empty or free areas
...
refs #6117
2014-06-18 17:38:25 +02:00
6555d347a7
Escape InlinePie html and adjust chart size
...
fixes #6117
2014-06-18 14:43:14 +02:00
be0c5d4b23
Add more meaningful tooltip labels to InlinePies
...
Show current title, a well-formated value and a label for each area in a
tooltip and add the ability to customize tooltip labels of InlinePies
refs #6117
2014-06-18 14:43:14 +02:00
8185f8b8a9
Ido\EventHistoryQuery: fix it to fit new filters
...
Works for single objects, still some work required for "generic"
history.
2014-06-17 14:02:54 +00:00
21febddad2
Widget\Filter*: rudimentary filter widgets
...
Initial implementation, more to come
2014-06-17 14:00:38 +00:00
a53f589a6b
monitoring/controllers: filter-related cleanup
2014-06-17 13:48:26 +00:00
1a91f0369e
list/servicematrix: adjust URLs to fit new filters
2014-06-17 13:37:29 +00:00
ef4403f204
monitoring/show/history: make it look better
...
Supporting newly implemented history states (comment removal...),
prepare for translation, better styling.
2014-06-17 13:32:12 +00:00
e3e6826d9d
Icinga\Filter: remove
2014-06-17 13:26:57 +00:00
517894d86f
show/header.phtml: try to look like other states
2014-06-17 13:22:52 +00:00
a42b66ab14
monitoring/show/services: QUERY_STRING voodoo
...
Looks less ugly than before, still ugly nonetheless. Will be better
once we care about request routing by ourselves.
2014-06-17 13:17:13 +00:00
304c7d146b
monitoring/show/history: pagination count
...
Fixes it as it didn't work, raised default row count to 50
2014-06-17 13:14:58 +00:00
75a9640563
Monitoring\Object\Service: add check performance
...
Service object was missing latency and check properties
2014-06-17 13:14:00 +00:00
0e09a1c7ba
Monitoring\Object\Host: explicit WHERE
...
Related to the former commit, no more auto-voodoo
2014-06-17 13:12:36 +00:00
3ccfe347f3
Monitoring\Object: replace fromRequest with params
...
This is only a temporary solution, the Monitoring\Object should be
fetched from the backend created in our front controller.
2014-06-17 13:10:54 +00:00
0ecd527e8c
monitoring/list: make use of new params
...
This brings our lists back to life and makes our filters work again.
2014-06-17 13:05:18 +00:00
58d4ddcb4c
monitoring/list: no need to declare $this->backend
...
This happens in the monitoring base controller right now
2014-06-17 13:03:05 +00:00
468b290277
Monitoring\Controller: provide $this->backend
...
Every monitoring controller needs $backend, so why declaring it over
and over again. Created "moduleInit" dummy function in our base action
controller to allow such implementations without polluting init().
2014-06-17 12:55:43 +00:00
25758332ab
CSS/monitoring: get rid of different formatting
...
First attempt to clean up the GUI, "same" elements looked different
in different places.
TODO: move more monitoriny-only CSS to the monitoring module
2014-06-17 12:53:39 +00:00
660f84b22f
DataView\EventHistory: default sort by timestamp
...
It doesn't make much sense to sort history by "hostname" hardcoded to
service-only host columns. Default is now timestamp DESC, internally
this is mapped to raw_timestamp.
2014-06-17 12:51:13 +00:00
dd595a2ad3
Ido/EventHistoryQuery: obsolete raw_timestamp
...
This was never thought to be used in frontends. Frontend code ALWAYS
needs to work with unix timestamps, raw timestamps are used internally
(e.g. between View and Query) to achieve better search and sort
performance.
2014-06-17 12:47:02 +00:00
93e2f36fc8
DataView: remove duplicate case handling
2014-06-17 12:46:41 +00:00
dab90d6c4a
GroupsummaryQuery: distinct columns/desiredColumns
...
I guess this needs some more investigation, desiredColumns are the
ones the user asked for ([alias => ]column), with column being once
again an alias in the "real" query. Alias resolution used to work
better long time ago, we should reflect on this.
2014-06-17 12:42:50 +00:00
027ef6ede3
Ido\Query\*historyQuery: subqueries join objects
...
Each of our history subqueries should be able to join main object
tables on their own for performance reasons.
2014-06-17 12:36:32 +00:00
7cd696b31b
Data/queries: adjust to fit new filters
...
Slight changes to get our queries working with new filter implementation.
2014-06-17 12:34:02 +00:00
d2ccc68214
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
...
Conflicts:
modules/monitoring/application/controllers/ListController.php
2014-06-17 09:47:14 +00:00
25a73ea3a1
Merge branch 'master' into feature/display-documentation-4820
2014-06-13 17:29:41 +02:00
8fe1d49ce9
doc/cs: Begin additional if conditions on a new line
2014-06-13 17:23:20 +02:00
4c76f5ab02
Ido/Query: small fixes
...
Replaced baseQuery in ContactGroupQuery, added short host/service
columns to CustomvarQuery.
2014-06-13 10:44:03 +00:00
405266e000
Drop Icinga\Util\Process in favour of an upcoming stronger implementation
2014-06-13 11:59:13 +02:00
b935cb34fb
Add clicommands to run unit- and style-tests
...
refs #6092
2014-06-13 09:27:27 +02:00
851977cbeb
Revert "Add clicommands to run unit- and style-tests"
...
This reverts commit 0805d73e34
2014-06-13 09:14:22 +02:00
0805d73e34
Add clicommands to run unit- and style-tests
...
refs #6092
2014-06-12 16:29:07 +02:00
d28d20696c
Move binary testing stuff and phpunit.xml to its own module
...
refs #6092
2014-06-12 16:29:07 +02:00
61ac3b0168
doc: Fix translation exceptions
...
refs #6432
refs #4820
2014-06-06 14:45:13 +02:00
160a75403d
Merge branch 'master' into feature/display-documentation-4820
...
Conflicts:
modules/doc/library/Doc/DocParser.php
2014-06-06 14:25:13 +02:00
16d5d65a05
doc: Fix actions and view scripts DocParser usage
...
refs #4820
2014-06-06 14:12:32 +02:00
d446e0db2e
doc: Implement DocParser::getChapter()
...
refs #4820
2014-06-06 14:12:30 +02:00
07330c1ca9
doc: Don't use absolute 'use' in MarkdownFileIterator
...
refs #4820
2014-06-06 14:12:27 +02:00
625a6dae40
doc: Remove DocTocHtmlRenderer as it's superseded by Data/Tree/NodeRenderer
...
refs #4820
2014-06-06 14:12:22 +02:00
cf987544c5
doc: Remove class DocToc as it's superseded by Data/Tree/Node
...
refs #4820
2014-06-06 14:12:13 +02:00
97c55d8dad
monitoring/list: clean up and fit new filters
...
refs #6418
2014-06-06 07:37:37 +00:00
defa02a609
Debug: Remove garbage statement for debug purposes
2014-06-06 09:28:46 +02:00
e1421c0d7e
Ido\StatusQuery: make sure performance killers...
...
...can no longer be reached. Column-ignorant uses still stumbled over
this. Left the code there as we should take a decision on how to approach
this.
2014-06-06 07:10:52 +00:00
4f3596fcaf
Monitoring\Object: fit new Query classes
...
refs #6418
2014-06-06 07:09:15 +00:00
c77e178bc7
Monitoring\DataView: small changes
...
Nothing interesting here
2014-06-06 07:07:07 +00:00
1677193571
Monitoring: adjust Backend and DataView
...
Made them use the new filters and interfaces.
refs #6418
2014-06-06 07:05:21 +00:00
1c3ab74e80
IdoQuery: fit new DbQuery implementation
...
Just a bunch of small changes, more to come. Fixes customvar handling
and is now able to handle the new Filter implementation.
refs #6418
2014-06-06 06:57:28 +00:00
f1e73c5fc5
Data\Db\DbQuery: forgot to rename once
...
refs #6418
2014-06-06 06:52:48 +00:00
3adf7752c4
Data\Db\DbQuery: rename also in monitoring module
...
refs #6418
2014-06-06 06:51:11 +00:00
bfe6a1593a
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
2014-06-06 05:32:54 +00:00
6d321d67cd
JS/CSS: Get IE8 working
...
Just a bunch of JS and CSS improvements / fixes
refs #6417
2014-06-05 15:03:59 +00:00
c592236258
vendorlibs: library/vendor to libary/IcingaVendor
...
This doesn't make it much better but allows to build a package
libicinga-vendor-php placing those files to /usr/share/php/IcingaVendor
or similar.
refs #4075
2014-06-05 00:10:49 +00:00
76a9e67e35
Added initial pt_BR translation
...
fixes #6395
Signed-off-by: Thomas Gelf <thomas@gelf.net>
2014-06-04 22:08:13 +00:00
d66055bce2
CLI/monitoring/list: fix formatting-related error
...
Small fix, this got broken by language-related changes in a66a1a47
2014-06-04 21:25:26 +00:00
29f593a357
Authentication: Add backend to handle external authentication
...
Drop external auth configuration from config.ini and move
implementation into a single backend provider named
'autologin'. This provider can strip realm names from
username with a custom regexp.
fixes #6081
2014-06-03 17:59:22 +02:00
d5cf2f2472
doc: Implement `DocParser::getToc()'
...
refs #4820
2014-06-03 15:23:59 +02:00
ed8de18ad5
DocParser: Use first header in a file as section title
...
refs #4820
2014-06-03 14:56:44 +02:00
370bfca6e6
DocParser: Remove itemPriority since it's nowhere used
...
refs #4820
2014-06-03 14:53:28 +02:00
a66a1a4729
Refactor the timeSincePrefix and timeUntilPrefix functions
...
Instead of having two separate functions to get the prefix
and the formatted time interval the new functions return
both the prefix and the time interval.
refs #5981
2014-05-29 13:03:10 +02:00
7b0a48bef5
Rename timeUnless to timeUntil
...
refs #5981
2014-05-29 12:38:59 +02:00
d01a98b7e6
Fix some of the time-related grammar mistakes
...
This updates some of the messages to use "For"
instead of "Since" where appropriate.
fixes #5981
2014-05-29 11:30:08 +02:00
0f1983fb25
doc: Fix links in index view scripts
...
refs #4820
2014-05-28 17:24:28 +02:00
49e927c4bf
doc: Support `doc/module/:moduleName/toc' URLs
...
refs #4820
2014-05-28 17:19:48 +02:00
dc1bada56f
doc: Add a view script for module's doc toc
...
refs #4820
2014-05-28 17:19:24 +02:00
72ab5027b5
doc: Add view script for the toc of Icinga Web 2's doc
...
refs #4820
2014-05-28 17:18:57 +02:00
d3a9f17fc2
doc/parser: Return the DocTocHtmlRenderer instead of an array
...
refs #4820
2014-05-28 17:18:07 +02:00
2f1303a13b
doc: No longer use a partial for viewing a toc
...
refs #4820
2014-05-28 17:16:37 +02:00
f0b6a3557e
doc/lib: Add DocTocHtmlRenderer class to render a toc to HTML
...
refs #4820
2014-05-28 17:15:43 +02:00
d2936d0338
doc/lib: Add DocToc class representing a toc
...
refs #4820
2014-05-28 17:15:08 +02:00
b11c0c36f9
Doc: Support `doc/icingaweb/chapter/:chapterName' URLs
...
refs #4820
2014-05-28 13:34:39 +02:00
0f4d2ad80c
Doc: Support `doc/module/:moduleName/chapter/:chapterName' URLs
...
refs #4820
2014-05-28 13:33:07 +02:00
93ee8e0a3d
Doc: Remove index/toc view script
...
I see no reference to this file.
refs #4820
2014-05-28 13:28:06 +02:00
7a0173e2fb
monitoring/IdoQuery:
...
IDO version is cached in a session namespace. This fails where you
are using multiple IDO backends with different versions. We still have
no backend-specific base class where we could handle this, so for now
I continue to do so in the IdoQuery.
This patch creates one namespace per Host/dbname combination.
2014-05-28 09:39:38 +00:00
f790e0c323
Translation: keep translation domain with partial
...
We should try to avoid partial and pass translation domain where forced
to use it.
refs #6338
2014-05-27 22:20:21 +00:00
7b58134378
show/history: sorry, typo
2014-05-27 22:16:45 +00:00
3ae4f762d8
Translation: initial German translation
...
refs #6340
2014-05-27 21:50:16 +00:00
cfa0251dbf
Translation: another bunch of translatable strings
...
refs #6339
2014-05-27 21:47:13 +00:00
b47cec3e02
Translation: use translation for monitoring/views
...
Just a bunch of translation-helper calls
refs #6339
2014-05-27 21:44:02 +00:00
6159c05457
Doc: Fix IndexController not using `DocController'
...
refs #4820
2014-05-27 15:12:21 +02:00
178402b65c
Doc: Add action to view a chapter of a module's documentation
...
Note that the FULL documentation is displayed yet.
refs #4820
2014-05-27 15:12:21 +02:00
e78d98a607
Doc: Add action to display a chapter of Icinga Web 2's documentation
...
Note that the FULL documentation is displayed yet.
refs #4820
2014-05-27 15:12:21 +02:00
dad7dc9e6c
Doc: Rename `DocController::renderDocAndToc()' to `renderChapter()'
...
Prepare that every chapter is displayed on a new page.
refs #4820
2014-05-27 15:12:21 +02:00
282af5a794
Doc: Add `toc' view script
...
refs #4820
2014-05-27 15:12:21 +02:00
e320d8613c
Doc: Rename `docandtoc' view script to `chapter'
...
Prepare that every chapter is displayed on a new page.
refs #4820
2014-05-27 15:12:21 +02:00
0f5e076771
Doc: Add action to view the toc of a module's documentation
...
refs #4820
2014-05-27 15:12:20 +02:00
dd6427019a
Doc: Add action to render the toc of Icinga Web 2's documentation
...
refs #4820
2014-05-27 15:12:13 +02:00
884e4c8e94
Doc: Add `DocController::renderToc()' method
...
refs #4820
2014-05-27 15:12:13 +02:00
71615151a4
Doc: Rename `Controller' to `DocController'
...
refs #4820
2014-05-27 15:12:13 +02:00
6ce739e23d
Doc: Construct parser with the path to the documentation
...
Before, the parser decided which path to used based on a given module name.
Now, the parser requires the path to the documentation.
Further the toc items no longer include a URL. The must URL must be generated
from a render function or view script.
refs #4820
2014-05-27 15:12:06 +02:00
5923622fb8
modules/doc: Fix toc links
...
The DocParser generates toc links with a hard-coded URL. This should
be changed to be generated from a route. But we did not decide how
to handle route overrides yet.
refs #4820
2014-05-27 15:11:33 +02:00
1d5c4c5055
modules/doc: Add styles
...
refs #4820
2014-05-27 15:11:33 +02:00
89bddb10e7
modules/doc: Tell which doc directory does not exist, in case it does not exist :)
...
Thanks Michael
refs #4820
2014-05-27 15:11:33 +02:00
5627c09b37
modules/doc: Reduce tab size to two spaces in module/index.phtml
...
refs #4820
2014-05-27 15:11:33 +02:00
a40f34394b
modules/doc: List available documentations on index
...
refs #4820
2014-05-27 15:11:33 +02:00
4001f1de62
modules/doc: Remove module/view.phtml as it has been replaced by renderDocAndToc()
...
refs #4820
2014-05-27 15:11:33 +02:00
ba860edb75
modules/doc: Remove icingaweb/index.phtml since it's replaced by renderDocAndToc()
...
refs #4820
2014-05-27 15:11:33 +02:00
40c2c64985
modules/doc: Implement doc/module/$moduleName URLs
...
refs #4820
2014-05-27 15:11:32 +02:00
74ea4d19b8
modules/doc: Rename populateView() to renderDocAndToc()
...
Rename populateView() to renderDocAndToc() since the method now sets the viewHelper
to docandtoc.phtml
refs #4820
2014-05-27 15:11:32 +02:00
99971e241c
modules/doc: Replace Parsedown's decprecated method parse() with text()
...
refs #4820
2014-05-27 15:11:32 +02:00
ce37c20736
modules/doc: Add route 'modules/doc/icingaweb' to display Icinga Web 2's documentation
...
refs #4820
2014-05-27 15:11:32 +02:00
e6abe21fb8
modules/doc: Rename DocParser::getDocumentation() to getDocAndToc()
...
refs #4820
2014-05-27 15:11:32 +02:00
83c12cfb2e
modules/doc: Add partial for displaying doc and toc
...
refs #4820
2014-05-27 15:11:32 +02:00
a91961284d
modules/doc: Show nothing on index yet
...
Before, doc's IndexController::indexAction() showed the documentation
of Icinga Web 2 but index should rather show an overview of available
docs.
refs #4820
2014-05-27 15:11:32 +02:00
40e45a2a39
monitoring/lists: Don't render unexistant controls
...
Even PHP code in HTML comments will be executed. As the filter object
sometimes failes, this can result in an invisible "breaking" exception.
refs #6031
2014-05-26 14:57:18 +00:00
af41ae875d
monitoring/module.info: provide sample metadata
...
We are currently able to read module metadata, but our modules don't
provide such. Here you go, feel free to extend it's description.
2014-05-26 14:35:59 +00:00
12b57c6d95
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
...
Conflicts:
modules/monitoring/library/Monitoring/Backend/Ido/Query/ContactgroupQuery.php
modules/monitoring/library/Monitoring/Backend/Ido/Query/IdoQuery.php
modules/monitoring/library/Monitoring/Backend/Ido/Query/StatusQuery.php
modules/monitoring/library/Monitoring/Controller.php
2014-05-20 23:15:11 +00:00
79f3b32474
monitoring/viewscripts: avoid errors in comments
...
PHP code may cause errors even if sitting in HTML comments. Also fixed a
HTML nesting error in list/servicematrix and reduced indentation.
2014-05-20 22:26:21 +00:00
8b28bdc82a
Monitoring\Object: small fix for strange private's
2014-05-20 22:22:48 +00:00
a7b8e0023d
Monitoring\Object: explictely define columns
...
Define the colums we use instead of fetching "everything" status view
provides. Without this performance degrades with every new feature.
2014-05-20 22:19:26 +00:00
76c1aa73c8
Monitoring\Controller: remove obsolete namespaces
2014-05-20 22:13:39 +00:00
d155c7a3fc
Fix checks for empty check source attribute
...
refs ##5814
2014-05-20 23:46:33 +02:00
ef2ac077c8
Fix typo in flapping note
2014-05-20 23:45:48 +02:00
941ff2a980
monitoring/show: remove CheckSource helper
...
It isn't doing anything but escape, so we can safely skip it.
2014-05-20 20:39:02 +00:00
31fa794440
monitoring/ido: implement IDO version support
...
We want to make use of new IDO features without breaking compatibility.
This is a quickfix as otherwise we would currently break everything
below 1.10. Code contains a few TODOs as this needs improvement.
2014-05-20 20:36:39 +00:00
9fbdb65a4b
Add check source to host/service details
...
refs #5814
2014-05-20 20:07:09 +02:00
cff577fb83
ShowController: don't show a random service
...
When you chose a host and clicked on "Services" the GUI used to show
a random (the first) service. Made no sense, should work as expected
right now.
2014-05-20 13:57:28 +00:00
8f77ce607e
show/services: don't navigate to the right
...
When using list/services for show/services (services for a single host)
we us an ugly PREG-based hack fixing the base link target. This got
broken by the multiselect feature, now it's working again. We need a
better solution for this.
2014-05-20 13:53:36 +00:00
33e326a232
list/services: ignore broken service image hacks
...
People used to configure something like "dot.png'> <img ..." as their
service image icon. Those hacks will no longer work as we correctly
escape everything. This fix hinders Icingaweb from even trying to load
them.
2014-05-20 13:31:13 +00:00
e6d80ae1f6
IDO Queries: performance quickfixes
...
Will be obsoleted by the new filter implementation, but for now it
helps a little bit
2014-05-20 13:27:58 +00:00
339460fee4
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
2014-05-09 16:29:54 +00:00
6523af711c
Monitoring_ListController: autorefresh matrix...
...
...and notification views
fixes #6152
2014-05-09 16:01:47 +00:00
d93c060e6a
Upgrade htmlpurifier to 4.6.0
...
refs #6165
2014-05-09 10:41:20 +00:00
e04ca8c29a
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
2014-05-07 15:53:48 +00:00
d0c56126b8
Fix inline pie reload.
...
refs #6124
2014-05-07 17:03:27 +02:00
820b6b7a8d
Data\BaseQuery: rename to Data\SimpleQuery
...
BaseQuery should no longer be abstract but be usable as is as soon as
we stripped ResultSet-specific tasks. As "Base" suggests something that
must be extended, the name no longer fits. So this is SimpleQuery right
now.
2014-05-07 11:55:35 +00:00
bc4783099a
Monitoring/ListController: Sort `hostStatus' view from request params
...
The `hostAction()' lacked ordering because the action no longer uses `HostStatusView::fromRequest()'.
2014-05-07 10:25:48 +02:00
5b895ab038
Data views: Implement `Sortable' interface
...
Because the `ListController' should only operate on data views,
data views should be a proxy to their underlying queries.
The methods `DataView::fromRequest()' and `DataView::sort()' are from now on deprecated
because they are relaced by `$backend->select()->from($viewName)' and `DataView::order()' respectively.
2014-05-07 10:19:00 +02:00
068e07109b
Monitoring/ListController: Operate on the `hostStatus' view instead of the query
...
The monitoring module's ListController should only operate on data views instead of queries.
Thus the applyRestrictions() method now expects a data view instead of a query. Further since
filters are subject to change the applyRestrictions() method now does nothing.
The `hostsAction()' no longer uses `DataView::fromRequest()' but selects the data view from
a monitoring backend. `DataView::fromRequest()' orders the underlying query which must be reworked
in the current scenario.
2014-05-07 09:40:23 +02:00
cfdb695c94
Monitoring/ListController: Remove variable activeRowHref from view
...
The variable grapher activeRowHref is not being used anywhere.
2014-05-07 09:29:58 +02:00
3afcf277bd
Monitoring/ListController: Remove variable grapher from view
...
The variable grapher retrieved as first available grapher hook is not being
used anywhere.
2014-05-07 09:27:42 +02:00
d87788b9c1
Merge branch 'master' into feature/query-interfaces-6018
...
Conflicts:
modules/monitoring/library/Monitoring/Backend/Ido/Query/ContactgroupQuery.php
2014-05-06 18:45:12 +02:00
97d6feccb8
Data views: Expect a query instance instead of a backend
2014-05-06 18:34:01 +02:00
c23e0c3782
Remove createBackend() method from the base controller
...
Refering to d389d8e
2014-05-06 18:24:42 +02:00
d389d8e0f0
Re-establish Backend::createBackend
...
This partially reverts fcf7f7d6
2014-05-06 18:23:22 +02:00
0627d954ac
Fix usages of Icinga\Module\Monitoring\Plugin\*
...
refs #5973
2014-05-05 16:16:45 +02:00
3d88e720c4
Rewrite perfdata plugin classes
...
refs #5973
2014-05-05 16:15:49 +02:00
d4502575d3
Fix filter test location
2014-05-05 16:15:26 +02:00
b7f4fa4a29
Fix deprecation warning in Perfdata.php
...
fixes #6076
2014-04-29 12:00:34 +02:00
e2ba172a8e
Make dashboard components using the ini writer class
...
fixes #5524
2014-04-29 11:30:53 +02:00
290fe9eeb5
Rewrite test for Icinga\Web\Hook
...
refs #6011
2014-04-28 14:06:40 +02:00
1db9b1ede4
Move non-factory functions from DateTimeFactory to Icinga\Util\Format
2014-04-28 14:06:39 +02:00
c641988233
Preserve multiselection during refresh
...
refs #5765
2014-04-28 09:48:06 +02:00
b791883fa8
Fix configuration checkboxes and colors in piecharts
...
refs #5765
2014-04-28 09:48:06 +02:00
b16c6efa05
Add PieChart to display hosts and services, improve layout and fix flag
...
checkboxes
refs #5765
2014-04-28 09:48:06 +02:00
081b5072a6
Fix layout of MultiController views
...
refs #5765
2014-04-28 09:48:06 +02:00
cb630d45ad
Fix issues issues with javascript multiselection
...
refs #5765
2014-04-28 09:48:05 +02:00
3b2bb3c4fc
Move functions to perform single, multi and range-selection into the ui module
...
refs #5765
2014-04-28 09:48:05 +02:00
6d303f1c42
Add abillity for multi and range-selection to events.js
...
Add the abillity to select multiple rows, with a multi-selection using the
CTRL-key or a range-selection using the shift-key. Also fix several issues in
the Multi-Controller of the Backend.
refs #5765
2014-04-28 09:48:05 +02:00
f741bc01f3
We need stricter control over Monitoring Object queries
...
* fromRequest-generated ones are sometimes buggy and sometimes slow
* this is just a temporary quickfix for the worst problems
2014-04-17 16:41:10 +00:00
cf7aaaed8e
Better sort default for service status
2014-04-17 16:25:32 +00:00
54175f98bf
Fix wrong contactgroup service column and make better use of MySQL indexes
2014-04-17 16:14:57 +00:00
fcf7f7d6dc
Replace Backend::createBackend() with Monitoring/Controller::createBackend()
...
Library code should not read configuration files. The new createBackend() method
from Monitoring/Controller takes care of reading backend configuration and error
handling. The Backend constructor now requires a resource instance.
2014-04-17 15:53:23 +02:00
e804f56d5f
Data views: Rename getTableName() to getQueryName()
...
getQueryName is more obvious because the function returns
the name of the query the view should use for querying.
2014-04-17 13:59:11 +02:00
62e044d888
IdoQuery: Move resolveColumns() to the columns() function
...
Since the BaseQuery no longer allows passing the columns to select via
its the constructor, the columns are resolved when set by the
columns() function.
2014-04-16 10:06:44 +02:00
eeadc17a6e
StatusQuery: Rename baseQuery to select
2014-04-15 18:12:56 +02:00
734c329caa
StatusSummaryQuery: Rename baseQuery to select
2014-04-15 18:12:00 +02:00
2ba1ef4793
StateHistorySummaryQuery: Rename baseQuery to select
2014-04-15 18:11:09 +02:00
a30d1cdb2f
ServicegroupQuery: Rename baseQuery to select
2014-04-15 18:10:30 +02:00
Alexander Klimov
Johannes Meyer
Thomas Gelf
Alexander Fuhr
Eric Lippmann
Matthias Jentsch
Matthias Jentsch
Marius Hein
Carlos Cesario
Gunnar Beutner
Michael Friedrich