Commit Graph

13800 Commits

Author SHA1 Message Date
raviks789 8fe428f987 `CustomVarTable`: Cast `$wrapper` to `ipl\Html\HtmlDocument` using inline `@var` in `renderGroup()` 2023-08-23 10:53:13 +02:00
raviks789 baeba7c27a `AdminAccountPage`: Cast `$query` to `LdapQuery` using inline `@var` 2023-08-23 10:53:13 +02:00
raviks789 9e0c8ef76a `RequirementsRenderer`: Cast `$currentSet` to `RequirementSet` in `beginChildren()` using inline @var 2023-08-23 10:53:13 +02:00
raviks789 7677a0bc4e `WebWizard`: Access `Form::getName()` with correct name case in `getNewPage()` 2023-08-23 10:53:13 +02:00
raviks789 ea2166be6d `WebWizard`: Import exception `InvalidArgumentException` 2023-08-23 10:53:13 +02:00
raviks789 fc321ddc49 `WebWizard`: Use inline `@var` to cast setup pages to correct type 2023-08-23 10:53:13 +02:00
raviks789 aa5da53c9d `Webserver`: Fix name case of return type for `createInstance()` method 2023-08-23 10:53:13 +02:00
raviks789 c0145890a3 `ArrayToTextTableHelper`: Update PHPDoc for constructor 2023-08-23 10:53:13 +02:00
raviks789 06d61001b1 `GettextTranslationHelper`: Fix parameter list for `getSourceFileNames()` method 2023-08-23 10:53:13 +02:00
raviks789 00f367c7d6 `MonitoredObjectController`: Access `MonitoredObject::fetchEventhistory()` with correct name case 2023-08-23 10:53:13 +02:00
Sukhwinder Dhillon 72d155c57d Remove not in use class `Plugin.php` 2023-08-23 10:53:13 +02:00
Sukhwinder Dhillon 31bfdb33e1 Github Actions: Add PhpStan
Co-authored-by: Ravi Srinivasa <raviks789@gmail.com>
2023-08-23 10:53:13 +02:00
raviks789 bd0fb8c154 Remove the use of unavailable property `$this->lessc->importDisabled`
The functionality to set import to disabled is removed in `lessc`. Hence the code where this
property is used has been removed from `LessCompiler`.
2023-08-23 10:53:13 +02:00
raviks789 8e3c456327 Fix parameter name mismatch in `View::escape` method
The mismatch arises after migration from ZF1 to ZF-future.
2023-08-23 10:53:13 +02:00
raviks789 695fe25891 Remove dead code from `Visitor.php`
The method `Visitor::visitColor` seems like a dead code and contains dynamic property
allocation. Hence, this method has been removed.
2023-08-23 10:53:13 +02:00
raviks789 825f3a9b7f Avoid use of dynamic properties deprecated in PHP 8.2 2023-08-23 10:53:13 +02:00
Alexander A. Klimov 6de4bd6e7e Explicitly add Module#configdir as (non-dynamic) property
W/o this the login page, if on PHP 8.2, says:

Deprecated: Creation of dynamic property Icinga\Application\Modules\Module::$configdir is deprecated in /usr/share/icingaweb2/library/Icinga/Application/Modules/Module.php on line 264

This breaks modules (if any) which use the property and not the getter.
2023-08-23 10:53:13 +02:00
raviks789 f330fcba91 Add PHP 8.2 to the php workflow 2023-08-23 10:53:13 +02:00
Sukhwinder Dhillon 847ba4f395 PdfExport: Fix false positive `! empty($this->content)` 2023-08-22 12:44:46 +02:00
raviks789 8b99852fc2
Remove unused `FilterWidget::class` (#5061) 2023-08-21 15:35:17 +02:00
Bernd Arnold 7da8431c7c Fix documentation format (kiosk mode)
The text for the ini file was all shown in one line.
It's formatted properly now.
2023-08-21 11:26:14 +02:00
Yonas Habteab 9c7d19ea95 JS: Don't always prefix extra updates containers with `#` 2023-08-11 16:14:17 +02:00
Johannes Meyer 4a52a653e4 js: Always load redirects to their designated target
The server applies the redirection magic now, but only
for compatibility reasons.

resolves #4881
2023-08-11 16:08:00 +02:00
Johannes Meyer 243192ba93
js: Enhance server side container closing (#5065)
* Let response header `X-Icinga-Container` either influence a request's
`$target` or `$redirectTarget`, but not both

* Issuing a `__CLOSE__` in a detail url still closes `#col2` and
refreshes `#col1`
* Issuing a `__CLOSE__` for a nested container still empties it
* Issuing a `__CLOSE__` in a modal, now refreshes the modal openers
container (now also `#col1`)
2023-08-11 16:07:38 +02:00
Johannes Meyer 51992f414e modal.js: Use a modal toggle's container as redirect target by default
Not the container's base target. The redirect target may still be
overridden by `data-base-target` on the `form` or by the response
using `X-Icinga-Container`.
2023-08-11 10:32:29 +02:00
Johannes Meyer 257a7070a1 js: Support `__CLOSE__` as extra update 2023-08-11 10:32:29 +02:00
Johannes Meyer eed6374dd2 js: Enhance server side container closing
* Let response header `X-Icinga-Container` either influence a request's `$target` or `$redirectTarget`, but not both
* Close a request's `$target` instead of the `$redirectTarget` upon the redirect url `__CLOSE__`

* Issuing a `__CLOSE__` in a detail url still closes `#col2` and refreshes `#col1`
* Issuing a `__CLOSE__` for a nested container still empties it
* Issuing a `__CLOSE__` in a modal, now refreshes the modal openers container
* If `X-Icinga-Extra-Updates` is set, automatic refreshing won't happen
2023-08-11 10:32:29 +02:00
Johannes Meyer 65b3006adf Check if `\Throwable` instead of `\Exception`..
..everywhere else...

fixes #5079
2023-08-10 14:12:06 +02:00
Johannes Meyer de178d0086
Remove vendor dependency (#5048)
The libraries in vendor directory has been moved to `composer.json` file
in
[icinga-php-thirdparty](https://github.com/Icinga/icinga-php-thirdparty).

### Blocked By
Icinga/icinga-php-thirdparty#11

closes #5007
2023-08-09 15:59:12 +02:00
Johannes Meyer 0a6db983f3 IcingaException: Expect `\Throwable` instead `\Exception` 2023-08-09 15:53:49 +02:00
raviks789 c6d4bf5020 Update php test workflow
Since the vendor libraries are moved to `icinga-php-thirdparty`. The php test workflow needs
to be updated, so that these libraries could be found during the test run.
2023-08-09 15:53:49 +02:00
raviks789 8a17c56345 Remove requiring vendor dependencies
Also avoid autoloading vendor.
2023-08-09 15:16:16 +02:00
raviks789 50bd5cfdc9 Remove `librarary/vendor` directory
The vendor dependencies will be moved to `composer.json` in `icinga-php-thirdparty`.
2023-08-09 15:16:16 +02:00
Johannes Meyer f61d278110 test: Support `ICINGAWEB_CONFIGDIR` during bootstrapping 2023-08-09 13:48:45 +02:00
Yonas Habteab 4ccebb78b5 `loader.js`: Allow to override the actual form action using `formaction` attr 2023-07-18 10:47:52 +02:00
Johannes Meyer d311005089
Update test bootstrapping (#5050) 2023-07-05 09:32:11 +02:00
Johannes Meyer 597cb5c94d tests: Use a real app for bootstrapping
Makes the tests less isolated, but streamlines
the autoloading and other stuff in a way that's
more maintainable than before.
2023-07-05 09:24:49 +02:00
Johannes Meyer 82d39be642 BaseTestCase: Refactor request and response mocking 2023-07-04 17:05:06 +02:00
Johannes Meyer 08bfc4f596 BaseTestCase: Drop timezone setup, the app will do it 2023-07-04 17:05:06 +02:00
Johannes Meyer 531479a92e BaseTestCase: Deprecate directory properties 2023-07-04 17:05:06 +02:00
Johannes Meyer 3f447cb954 BaseTestCase: Remove `t` and `mt` function declarations 2023-07-04 17:05:06 +02:00
Johannes Meyer 58673b0b95 PhpCommand: Accept phpunit path as option and fix coverage 2023-07-04 17:05:06 +02:00
Johannes Meyer 776e0803fa tests: The app is soon not mocked anymore, so don't use it as such 2023-07-04 16:26:36 +02:00
Johannes Meyer e572652f4c ConfigTest: Always load test config from disk 2023-07-04 16:25:11 +02:00
Johannes Meyer d0b2ed177c tests: Drop DateFormatTestBroken as it is .. broken 2023-07-04 16:24:37 +02:00
Johannes Meyer c9f3f0444d tests: Require view helpers at runtime 2023-07-04 16:24:19 +02:00
Johannes Meyer e7adc06497 ApplicationBootstrap: Process `ICINGAWEB_MODULES_DIR` by default 2023-07-04 16:08:41 +02:00
Gianluca Piccolo db9888b1f1 Fixes #5020 2023-06-22 15:11:39 +02:00
Sukhwinder Dhillon 59fc7dd745 Fix installation doc for centOS 2023-06-22 15:10:05 +02:00
Thomas Gelf 463cc748bf MonitoringBadgeNavigationItemRenderer: do not fail
...on wildcard filter
2023-06-22 15:07:47 +02:00