0822aff293
library/form: Fix return value of `getName()' not being filterd the first time it's called
...
`Form::getName()' auto-detects the form's name if it's not set and sets the form's name using `Zend_Form::setName()'.
`Zend_Form::setName()' then filters the form name stripping backslash '\' characters. The first call to `Form::getName()'
did not regard the filtering and thus returned the unfiltered name which led to `Form::wasSent()' returning `false'.
refs #5525
2014-09-01 14:40:45 +02:00
57dd9a699e
monitoring/commands: ToggleFeature: Use 'return $this' for documenting fluent interfaces
...
refs #6593
2014-09-01 10:29:34 +02:00
f3e74f0f24
library/form: Append class 'autosubmit' in case the element to autosubmit has the class attribute set
...
Before, the class attribute would've been overwritten.
refs #5525
2014-09-01 09:44:04 +02:00
a01ee00c27
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
...
Conflicts:
library/Icinga/Protocol/Commandpipe/Transport/Transport.php
2014-08-29 17:24:44 +02:00
fb5685bac3
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Config/Authentication/BaseBackendForm.php
application/forms/Config/Authentication/DbBackendForm.php
application/forms/Config/Authentication/LdapBackendForm.php
application/forms/Config/Authentication/ReorderForm.php
application/forms/Config/LoggingForm.php
application/forms/Config/ResourceForm.php
application/forms/Preference/GeneralForm.php
library/Icinga/Application/Config.php
library/Icinga/Web/Form.php
modules/monitoring/application/controllers/ConfigController.php
modules/monitoring/application/forms/Config/Backend/CreateBackendForm.php
modules/monitoring/application/forms/Config/Instance/CreateInstanceForm.php
modules/monitoring/application/forms/Config/Instance/EditInstanceForm.php
modules/monitoring/application/forms/Config/SecurityForm.php
2014-08-29 16:05:56 +02:00
8c82f1a868
monitoring/commands: Add common `ToggleFeature' command
...
`ToggleFeature' should be used for enabling/disabling concrete features of the monitoring host.
refs #6593
2014-08-29 15:45:35 +02:00
4d353ac7bf
monitoring/commands: Add `CommandTransport' factory
...
Instead of auto-detecting which transport class to use, the instances configuration
now supports a new setting named `transport' with the possible values 'local' and 'remote'.
refs #6593
2014-08-29 15:36:55 +02:00
6324192127
monitoring/commands: Throw `LogicException' if the remote host is not set in `RemoteCommandFile'
...
refs #6593
2014-08-29 15:36:11 +02:00
ae35650c7e
Adjust authentication backend forms to suit.. some form implementation
...
refs #5525
2014-08-29 15:16:13 +02:00
6fdc436f65
monitoring/commands: Add `TransportException'
...
`TransportException' should be thrown if a command was not sent.
refs #6593
2014-08-29 15:14:53 +02:00
249099348e
monitoring/commands: Replace `SecureShell' with `RemoteCommandFile'
...
`RemoteCommandFile' is configured via property setters instead of the too general `setEndpoint' function.
The ssh command to be executed only has the option 'BatchMode' set to 'yes' as this is enough to disable
interactive authentication methods. Further, all arguments become espaced.
refs #6593
2014-08-29 15:08:58 +02:00
ec46b368df
monitoring/commands: Replace `LocalPipe' with `LocalCommandFile'
...
`LocalCommandFile' is configured via property setters instead of the too general `setEndpoint' function.
refs #6593
2014-08-29 15:04:48 +02:00
2ac4a8503c
monitoring/commands: Remove the `Transport' interface
...
The `Transport' interface is superseded by the `CommandTransportInterface'.
refs #6593
2014-08-29 14:44:49 +02:00
e7eae87f16
monitoring/commands: Replace `Command' with `IcingaCommand'
...
Since there's already a `Cli\Command', `Command' is now named `IcingaCommand'.
All concrete Icinga commands should extend `IcingaCommand' which handles
command encoding. All other "features" of the `Command' object have been removed
because theses "features" should be handled by upcoming concrete command classes.
refs #6593
2014-08-29 14:38:52 +02:00
0e2e1bc005
monitoring/commands: Add `CommandTransportInterface'
...
All concrete Icinga command transport classes should implement the `CommandTransportInterface' .
refs #6593
2014-08-29 14:34:16 +02:00
364c7c0858
Add base form class for configuration forms
...
refs #5525
2014-08-29 12:25:25 +02:00
e020dd3541
Icinga\App..\Config: Rename __construct to fromIni and add setConfigPath
...
Prior to this change it was not possible to create an instance of Config
without passing a config file.
2014-08-29 12:23:48 +02:00
79b0ed64ec
Make it possible to provide a closure to be called instead of onSuccess()
...
This allows us to write generic forms like the ConfirmRemoval form but to
utilize handleRequest() while providing a closure in the array that is passed
to a form's constructor.
refs #5525
2014-08-29 12:21:31 +02:00
055a107b90
Merge branch 'bugfix/piechart-labels-stick-out-7022'
...
fixes #7022
2014-08-29 09:14:36 +02:00
bf23688e73
Make autosubmit work in non-JS enviroments
...
We require forms to set autosubmit=true on elements which are supposed
to be submitted automatically now. The base form then ensures that this
works in JS environments and non-JS environments as well by applying the
right changes to the HTML.
refs #5525
2014-08-29 09:08:53 +02:00
486104d59e
Check explictly for FALSE when calling onSuccess()
...
This allows us to just end onSuccess() without requiring it to return TRUE
to initiate redirection.
refs #5525
2014-08-29 09:04:20 +02:00
3642b7b6fc
Adjust CSS for inlinePies to be centered on the current line
2014-08-28 18:27:30 +02:00
a26370bb12
Adjust PieCharts that are rendered without labels
...
Center and resize PieCharts to use the full width and height of the available view port
2014-08-28 18:25:19 +02:00
e799d65d3f
Only apply SVG responsiveness when not rendered in compact mode
...
Don't let SVGs grow vertically in when displayed in the dashboard, to avoid wasted space
2014-08-28 16:52:02 +02:00
648debff88
Draw charts for single ServiceGroups as PieChart
2014-08-28 16:50:29 +02:00
00a2d225a2
Ensure that PieCharts are centered and that labels dont leave the viewBox
...
Add scaling and transformations to move the PieChart into a valid coordinate system and reduce the offset of the labels to make more efficient use of available space.
2014-08-28 16:42:31 +02:00
c5cface661
Improve readability of small pie charts
...
Use a bigger font, to ensure that small pie charts still have readable labels.
2014-08-28 16:40:34 +02:00
98809a1447
Do not use width and height as width and height percentages in the outer SVG element
...
Height and width are solely used to define the SVGs ratio and should not cause side effects on the SVGs size in the site context.
2014-08-28 16:37:21 +02:00
a9eec0d672
Remove useless width and height properties from PieChart
2014-08-28 16:33:38 +02:00
f77cd9cafa
Fix coding guidelines
2014-08-28 16:21:16 +02:00
573a4ea12f
Fix spelling mistakes
2014-08-28 16:14:59 +02:00
4ca1eaa7ce
Merge branch 'bugfix/rebuild-form-builder-5525' into bugfix/commands-6593
...
Conflicts:
library/Icinga/Web/Form.php
modules/monitoring/application/forms/Config/SecurityForm.php
2014-08-28 13:58:02 +02:00
0da16e4c68
Merge branch 'bugfix/icinga2-contacts-7020'
...
fixes #7020
2014-08-28 13:42:16 +02:00
0a2b504db8
Gracatar: Pre sized with 60px because of display latency
...
refs #7020
2014-08-28 13:41:21 +02:00
c4c5bcdd48
ContactQuery: Change timeperiod joins to joinLeft()
...
refs #7020
2014-08-28 13:39:49 +02:00
dea7caa633
Merge branch 'bugfix/ConfigAwareFactory-5514'
...
fixes #5514
2014-08-28 12:15:31 +02:00
4e83bb098a
LdapBackendFormTest: Fix mock
...
refs #5514
2014-08-28 12:14:55 +02:00
e345aa257a
Platform: Drop *Available function
...
Create a function extensionLoaded and change usages.
refs #5514
2014-08-28 12:14:55 +02:00
436a4d2965
ResourceConfig: Chance createResouce to create
...
Not useful everywhere. Changed on the best suitable places.
refs #5514
2014-08-28 12:14:55 +02:00
9d0037a53a
ResourceFactory: Add function create(<name>)
...
The ConfigAwareFactory is an interface forcing "backend-type" classes to call
ResourceFactory::createResource() passing a config they got in the constructor.
That's kind of overdesigned, if the ResourceFactory wants to be something like
a service locator it's responsabilities should include object instantiation.
refs #5514
2014-08-28 12:14:54 +02:00
35d11bd145
Class doc for Platform
...
refs #5514
2014-08-28 12:14:54 +02:00
9b83074cc9
Class doc for ResourceFactory
...
refs #5514
2014-08-28 12:14:54 +02:00
22e17e9901
ResourceFactory: Move available function to platform
...
refs #5514
2014-08-28 12:14:54 +02:00
c194c02435
Remove useless 'use \Exception'
2014-08-28 11:45:26 +02:00
fdef695896
Fix: The use statement with non-compound name 'Exception' has no effect
2014-08-28 11:34:08 +02:00
66062c87b6
Remove unused use Zend_Config
2014-08-28 10:55:06 +02:00
947cd0c5d3
Merge branch 'master' of git.icinga.org:icingaweb2
...
fixes #7006
2014-08-27 17:22:09 +02:00
6a32c3a8ab
Make charts responsive
...
Let pie and grid charts of the chart controller automatically adapt to changing viewport sizes.
2014-08-27 17:21:55 +02:00
e342035464
Merge branch 'bugfix/contact-detail-4804'
...
fixes #4806
2014-08-27 16:39:08 +02:00
5e84ff4ac4
Show/Contact: Add notification history to view
...
refs #4804
2014-08-27 16:38:29 +02:00
Eric Lippmann
Johannes Meyer
Matthias Jentsch
Marius Hein
Alexander Klimov
Alexander Fuhr