tyler.durden
/
icingaweb2
mirror of https://github.com/Icinga/icingaweb2.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
3,030 Commits 117 Branches 71 Tags 80 MiB
Commit Graph

3030 Commits

Author SHA1 Message Date
Alexander Klimov f754531e4d Fix grammatical error 2014-08-26 10:22:14 +02:00
Johannes Meyer 52534a2f46 It is a form's responsibility to process the request it was submitted with 
How forms are being validated should not be a task that is part of the
controller action, but should be handled by the form base class as it is
most of the time the same procedure. Now a controller action just sets
up the form to use, calls handleRequest() and acts upon its return value.
(e.g. calling handleRequest() from another form or any redirection)

refs #5525
 2014-08-25 17:06:45 +02:00
Johannes Meyer c93ab7951d Check whether a form's data was sent instead of whether it's complete 
It is not sufficient to just check whether all required elements are being
submitted. We definetely need to check whether the submit button was
pressed. But doing this and providing a standard button with a static name
simultaneously will produce conflicts if forms are using the same action
urls. To fix this, we'll add an additional form-identification check by using
a form's name or class.

refs #5525
 2014-08-25 16:49:54 +02:00
Alexander Klimov 7074fa1331 NotWritableError: extend IcingaException 
refs #6931
 2014-08-25 12:56:35 +02:00
Alexander Klimov 6c9947326d NotReadableError: extend IcingaException 
refs #6931
 2014-08-25 12:38:34 +02:00
Alexander Klimov f4dbb4df96 NotImplementedError: extend IcingaException 
refs #6931
 2014-08-25 12:21:59 +02:00
Alexander Klimov 013aad8f73 MissingParameterException: extend IcingaException 
refs #6931
 2014-08-25 12:14:18 +02:00
Thomas Gelf 70fe22dfad monitoring/tactical: fix missing translations 2014-08-22 18:08:20 +02:00
Thomas Gelf 5c46355474 translation: refresh de_DE 2014-08-22 17:58:53 +02:00
Thomas Gelf c31972b99c translation: refresh monitoring module 2014-08-22 17:26:20 +02:00
Johannes Meyer 7b221e2aba It should not be a form's responsibility how its submit button should look.. 
...in case it's a standard button. No need to be DRY here.

refs #5525
 2014-08-22 15:20:54 +02:00
Johannes Meyer 403f745488 Remove obsolete loggingAction 
refs #6933
 2014-08-22 12:34:33 +02:00
Johannes Meyer 5028ec7b0b Avoid NIH 
It's useless to have specific getters and setters if generic methods from the
baseclass can be used as well to accomplish the same task.

refs #6641
 2014-08-22 12:30:13 +02:00
Johannes Meyer a0b2c0b454 Fix another documentation block 2014-08-22 12:18:26 +02:00
Johannes Meyer 75a0c17933 Ensure that all forms have a name 
refs #5525
 2014-08-22 12:15:02 +02:00
Johannes Meyer 2b879b344f Do not populate using createElements() and fix documentation blocks 
refs #5525
 2014-08-22 12:04:14 +02:00
Alexander Fuhr a5373a6e9e Merge branch 'bugfix/modules-menu-provider-6639' 
refs #6639
 2014-08-22 11:46:43 +02:00
Alexander Klimov 9c5878cbbe ConfigurationError: extend IcingaException 
refs #6931
 2014-08-22 11:46:11 +02:00
Alexander Fuhr 20cead67a6 Merge branch 'master' into bugfix/modules-menu-provider-6639 2014-08-22 11:44:10 +02:00
Alexander Fuhr aba5b1c80d Remove menu.ini from icingaweb2.spec 
refs #6639
 2014-08-22 11:40:20 +02:00
Alexander Fuhr 1886569174 Implement Module self provided configuration for menus 
refs #6639
 2014-08-22 11:35:42 +02:00
tgelf da821fd952 list/hosts: add missing host_attempt column 2014-08-22 05:23:45 -04:00
Alexander Fuhr f757f69bd1 Change Menu load from config ini files to self provided configuration 
refs #6639
 2014-08-22 11:10:17 +02:00
Alexander Fuhr 7e0047d00e Add Menu configuration in Monitoring Module 
refs #6639
 2014-08-22 11:07:49 +02:00
Thomas Gelf 49cd55eddd list/hosts: cleanup, should look like list/services 
Quite some changes here:

* Compact view should show icons too
* Ignore host icons with legacy HTML hacks
* Remove duplicate code
* Reduce HTML
* Reduce intendation for better readability
* Show attempts on soft states only, even in compact view
* Use the same HTML tags and styles as in list/services
* Fixes nesting error on compact view
 2014-08-22 11:06:45 +02:00
Johannes Meyer bc05d2ee64 Merge LoggingForm into GeneralForm 
fixes #6933
 2014-08-22 11:05:20 +02:00
Alexander Fuhr 968fa0a1cc Add configuration.php to Doc Module 
refs #6639
 2014-08-22 11:02:08 +02:00
Alexander Klimov b764993091 AuthenticationException: extend IcingaException 
refs #6931
 2014-08-22 10:59:52 +02:00
Alexander Fuhr 1e891c2510 Delete unnecessary menu.ini's and update puppet manifests 
refs #6639
 2014-08-22 10:58:28 +02:00
Alexander Klimov b55a313146 Implement IcingaException 
refs #6931
 2014-08-22 10:27:30 +02:00
Thomas Gelf 09412d03b6 Benchmark: hide timestamp on HTML output 
Wastes space and is mostly useless, absolut and relative expired time
gives more than enough information.
 2014-08-22 09:34:43 +02:00
Thomas Gelf af97db31d7 StaticController: fix gravatar sample img header 2014-08-21 19:10:53 +02:00
Alexander Klimov 8733238a6e Loader::registerNamespace(): correct exception message 2014-08-21 12:40:41 +02:00
Alexander Klimov 30d0ebcdfd Make 'modules/monitoring/config.ini' doesn't have to exist 2014-08-21 12:36:28 +02:00
Alexander Klimov d1b1bc368f Monitoring_ConfigController: don't use SecurityForm::isSubmittedAndValid() 
refs #5525
 2014-08-21 11:51:49 +02:00
Alexander Klimov b81e96574a SecurityForm: replace create() with createElements() and add addSubmitButton() 
refs #5525
 2014-08-21 11:48:07 +02:00
Johannes Meyer 11063495b2 Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	modules/monitoring/application/controllers/ConfigController.php
 2014-08-21 10:22:16 +02:00
Johannes Meyer b146a8c311 Relax locale code validation to just a format check 
fixes #6930
 2014-08-21 10:07:07 +02:00
Johannes Meyer b36fe5d564 Fix version access while refreshing translations 2014-08-21 10:07:07 +02:00
Alexander Fuhr 36a275371f Delete unnecessary configurations files from .vagrant-puppet 
fixes #5749
 2014-08-20 16:26:52 +02:00
Alexander Fuhr e0b9730f17 Update configurations source paths in puppet default.pp 
refs #5749
 2014-08-20 16:01:08 +02:00
Alexander Fuhr 00ac224ec1 Delete deprecated menu.ini.in 
refs #5749
 2014-08-20 15:39:48 +02:00
Alexander Fuhr bef639ecb8 Update deprecated output variable in puppet files 2014-08-20 15:16:42 +02:00
Thomas Gelf a8d33d90e2 Monitoring\Object: fix a couple of cv-related issues 
* Don't throw exceptions with no config
* Provide a secure default if not configured
* Improve code readability
 2014-08-20 13:36:03 +02:00
Johannes Meyer bb7972aa39 Merge branch 'master' into bugfix/rebuild-form-builder-5525 
Conflicts:
	application/controllers/AuthenticationController.php
	application/controllers/ConfigController.php
	application/forms/Authentication/LoginForm.php
	application/forms/Preference/GeneralForm.php
	modules/monitoring/application/controllers/ChartController.php
 2014-08-20 13:13:50 +02:00
Alexander Klimov bb65fb396a Merge branch 'bugfix/sensitive-custom-vars-6641' 
fixes #6641
 2014-08-20 12:29:45 +02:00
Alexander Klimov 78b98a7d67 SecurityForm: Add helptext 
refs #6641
 2014-08-20 12:21:11 +02:00
Johannes Meyer f4b33c64dc Merge branch 'bugfix/styled-history-views-6637' 
fixes #6637
 2014-08-20 11:39:37 +02:00
Johannes Meyer 09dfcca0bc Merge branch 'master' into bugfix/styled-history-views-6637 2014-08-20 11:39:03 +02:00
Johannes Meyer 4ceecf1146 Let comment view look more standardized and add limit control 
refs #6637
 2014-08-20 11:34:24 +02:00