Commit Graph

395 Commits

Author SHA1 Message Date
Marius Hein 6555a2ec0a Menu: Move request handling to complete
If a failure occur the menu is still working.
2015-02-02 15:03:36 +01:00
Marius Hein 8c758a9f12 Failure requests: Fix auto refresh and history
Allow to change url's in history and stop auto auto refresh if
the container URL is not up to date.
2015-02-02 13:32:40 +01:00
Marius Hein 190c1e8f04 Revert "Revert "Dashboard: Always replace title""
This reverts commit d1f13819e4.

Please do not ask. This was no syntax error.
2015-02-02 12:04:28 +01:00
Marius Hein d1f13819e4 Revert "Dashboard: Always replace title"
This reverts commit c0c0e7d9e5.

Syntax error
2015-02-02 12:01:40 +01:00
Marius Hein c0c0e7d9e5 Dashboard: Always replace title
This is needed if an error occurs and the exception title was rendered
into the container.
2015-02-02 12:00:08 +01:00
Marius Hein 7b8332ccd8 Notifications do not disappear after autorefresh
This is not affected anymore because the errors goes directly
into the container. But this commit fixes the codes if someone
use the notifications in the loader. Also remove unused
variable this.exception.

fixes #6278
2015-01-30 15:25:12 +01:00
Marius Hein 6ec2ee753d Render error messages in the container itself
fixes #6280
2015-01-30 14:50:25 +01:00
Marius Hein 4abb30e55b Merge branch 'master' into bugfix/ie8-fixes-6417 2015-01-28 17:08:56 +01:00
Johannes Meyer 618ab4f4b9 Introduce link target "_right" to keep a column with tabs rightmost
I'd have liked to get it to work that in case the tab control is not in the
rightmost column a "go back" in the history is being simulated causing
the preceding leftmost column(s) to be restored and the rightmost one
set to the one containing the tab control. But the history api does not
seem to support any read operations except for the current state..

refs #6436
2015-01-28 14:21:06 +01:00
Marius Hein 7ef86ddf49 Navigation: Bypass error-prone hover selector for IE8
refs #6417
2015-01-28 13:19:49 +01:00
Matthias Jentsch 3d07049fbf Re-render menu item after setting class to active
Force the browser to re-render the menu item, to update the link layout immediately
by recreting the content html.

fixes #7897
2014-12-29 16:21:10 +01:00
Matthias Jentsch cda5a6a903 Streamline chart implementation
Define sparkline layout through CSS class and remove label/tooltip formatting.

fixes #7077
2014-12-23 15:26:45 +01:00
Matthias Jentsch 64a2acd12e Do not display labels for single data sets in perfdata piecharts
Display generic chart titles for the whole piechart that only contain title and percentage and don't style perfdata piecharts using HTML properties.

refs #7077
refs #6200
refs #7304
2014-12-23 15:14:17 +01:00
Marius Hein b0382da5fe JS/submitForm: Choosing the right submit button in FF
refs #7751
2014-11-20 11:07:10 +01:00
Johannes Meyer f64b3c1439 Fix that the current page of our list view pagination is not being highlighted
fixes #7492
2014-11-14 11:58:29 +01:00
Alexander Fuhr 6ee0c218e9 Remove debug `console.log()' from `provideSelectionCount()'
refs #7654
2014-11-14 10:18:47 +01:00
Alexander Fuhr 540a8c7aa4 Fix hint counter on unselect the last row
refs #7654
2014-11-14 10:17:23 +01:00
Alexander Fuhr 46df428e28 Add selection count hint in grids with help for hosts and services
refs #7654
2014-11-13 12:50:39 +01:00
Johannes Meyer f7d168c80f Fix that FireFox < v33 is unable to find the button that got the focus 2014-11-07 14:22:03 +01:00
Johannes Meyer 170ded6510 Merge branch 'master' into feature/setup-wizard-7163
Conflicts:
	library/Icinga/Authentication/Backend/LdapUserBackend.php
	library/Icinga/File/Ini/IniWriter.php
2014-11-04 14:22:53 +01:00
Thomas Gelf 95f9bebdc5 js/loader: support multi-container redirection
Redirections to #!-separated URLs (multiple containers) should also
work when not re-rendering the whole layout.
2014-11-01 01:23:55 +01:00
Thomas Gelf 6298d303c4 js/loader: trigger 'beforerender' container event 2014-11-01 01:12:59 +01:00
Thomas Gelf f25f4f06d8 js/loader: disable click handler block on refresh
This used to be ways too slow when many elements where involved. Left
the old code there as a reminder. In case we really need it we should
use something faster like an overlay or so.
2014-11-01 01:11:12 +01:00
Johannes Meyer 9f127be1dc Merge branch 'master' into feature/setup-wizard-7163
Conflicts:
	application/forms/Config/General/LoggingConfigForm.php
2014-10-17 13:04:59 +02:00
Matthias Jentsch 6124f984ee Adjust scroll position on container after triggering the 'rendered' event
Prevent behaviors from altering the current scroll-position on page reload when refreshing or changing the focus.

fixes #7269
2014-10-14 15:50:15 +02:00
Johannes Meyer 62544111ff Fix that when pushing ENTER in a form with just <buttons> no button is sent 2014-10-09 13:42:15 +02:00
Matthias Jentsch ee63dfd310 Update navigation when the url of the main column changes 2014-10-01 17:47:21 +02:00
Matthias Jentsch ec9e9e8dfb Get correct navigation link id on first render 2014-10-01 16:49:30 +02:00
Matthias Jentsch fa2c9e46ed Cleanup comments and whitespaces 2014-10-01 16:48:38 +02:00
Matthias Jentsch ed91e119d2 Add close-button to all containers
refs #6216
2014-10-01 14:51:51 +02:00
Alexander Fuhr 07a4b25560 Merge branch 'master' into bug/history-notification-time-format-6980 2014-09-23 11:38:24 +02:00
Alexander Fuhr e784aa34b6 Implement DateTimeRenderer and fix history time format
refs #6980
2014-09-23 11:36:09 +02:00
Matthias Jentsch ef2f332869 Do not refresh a container when form input was changed or a form element is focused
Listen for changes in form elements and abort all reloads that contain a form with
at least one changed form element. Do not refresh containers that contain a focused form
element, except of elements with autofocus, to preserve form elements with a dropdown.
Only focus autofocus elements when there is currently no other selection.

refs #7146
refs #5537
fixes #7162
2014-09-19 15:48:44 +02:00
Matthias Jentsch 7f0a2d540b Tell navigation behavior about changes in active menus
fixes #7181
2014-09-12 15:01:25 +02:00
Matthias Jentsch ad53f7ad3d Use EventEmitter class as a way to delegate events from behaviors to the dom 2014-09-12 09:09:21 +02:00
Matthias Jentsch 2e0bef5696 Add missing event unbind 2014-09-10 17:10:08 +02:00
Matthias Jentsch 0ec97eb934 Only apply navigation link-click handlers to menu 2014-09-10 17:02:39 +02:00
Matthias Jentsch e216ba6721 Merge stash 2014-09-10 17:02:39 +02:00
Matthias Jentsch 7aadad913e Do not follow empty menu links 2014-09-10 17:02:39 +02:00
Matthias Jentsch cb9c9c78d8 Move navigation events into behavior 2014-09-10 17:02:39 +02:00
Matthias Jentsch c0908e32ba Remove unused behavior base-class 2014-09-10 17:02:39 +02:00
Matthias Jentsch f58da73e2d Move javascript behaviors into separate classes 2014-09-10 17:02:39 +02:00
Matthias Jentsch 5d2e849491 Apply behaviors correctly on startup 2014-09-10 17:02:39 +02:00
Matthias Jentsch d99d50b3c4 Add stub for javascript behaviors 2014-09-10 17:02:38 +02:00
Matthias Jentsch da7e599363 Only remove active elements in navigation on reload 2014-09-09 16:32:15 +02:00
Matthias Jentsch b7c207a9cb Do not drop preselection in the navigation on reload 2014-09-09 15:32:07 +02:00
Matthias Jentsch 157818c8e7 Fix navigation reload
Activate the correct menu item with JavaScript after relaod and don't
 render it on server-side on XHR requests.
2014-09-09 13:57:48 +02:00
Matthias Jentsch 56b779af4d Clean up mousemove handler and remove unused tooltip code 2014-09-08 16:46:47 +02:00
Matthias Jentsch 28f5ef2284 Fix elementsOverlap function for SVG elements
Access SVG getBBox function to acquire the bounding box for SVG elements
2014-09-08 16:37:20 +02:00
Matthias Jentsch 545db945da Auto refresh menu
Put the navigation into a container and reload it once every 15 seconds from a distinct menu action. Include the current
path into an URL param to still be able to mark the current menu item as active.

fixes #6955
2014-09-08 15:21:14 +02:00
Marius Hein f2df8d9bae Timezone detection: Set cookie expiration to 1 day
refs #6078
2014-09-05 15:24:13 +02:00
Marius Hein a300877878 Time detection: Add receiever to bootstrap method
refs #6078
2014-09-05 15:24:13 +02:00
Marius Hein 3ce42489c6 Timezone detection: Client implementation
refs #6078
2014-09-05 15:24:13 +02:00
Thomas Gelf 0b53f30b08 js/events: ignore mailto links
fixes #7079
2014-09-05 15:05:22 +02:00
Matthias Jentsch eeed030bb5 Do not use an invalid HTML attributes for rich titles 2014-09-04 13:32:30 +02:00
Matthias Jentsch e5be8d47ef Fix SVG bound calculation for tooltips in Firefox 2014-09-04 09:53:57 +02:00
Matthias Jentsch 868e8b25b6 Fix left over tooltips after reloads with layout shift 2014-09-04 09:32:15 +02:00
Matthias Jentsch 510e38335e Remove useless tooltip from host and service list
remove titles from time spans on all td.state, since the formatted time
is already displayed in the inner div
2014-09-03 17:43:43 +02:00
Matthias Jentsch da85112538 Merge branch 'master' into feature/svg-chart-tooltips-7024 2014-09-03 17:08:00 +02:00
Matthias Jentsch cd8416bd3c Add information about the source and installation of all needed jquery-tipsy files 2014-09-03 17:03:04 +02:00
Matthias Jentsch 593134203c Add minified version of tipsy sources 2014-09-03 17:02:01 +02:00
Matthias Jentsch b10b1ea034 Add jQuery tooltips 2014-09-03 15:53:56 +02:00
Thomas Gelf ef847801f2 js/loader.js: preserve scrolling position...
...on autorefresh and reset it otherwise.

fixes #6285
fixes #6988
2014-09-02 20:11:37 +02:00
Thomas Gelf f12a5741b8 js/loader: postpone redirection handling
Redirections should not be executed unless the original request has been
terminated and removed from pending requests.

fixes #6989
2014-09-02 19:05:49 +02:00
Thomas Gelf 538c6cf90b js/events: ignore button/submit clicks
In case you clicked a (submit) button in an action row this also
also triggered that row's click handler. As the event is going to be
stopped there, this leads to "unsubmittable forms". Fixed.

fixes #6963
2014-08-20 09:26:16 +02:00
Thomas Gelf 686152abf3 js/events: fix a small bug introduced right now
Links on non-multiselect action tables stopped working.

refs #6705
2014-08-19 19:04:29 +02:00
Alexander Fuhr ba748cbc4a Refactor multiSelect and highlight
refs #6705
2014-08-19 18:33:28 +02:00
Alexander Fuhr 6fe47bf5b0 Fix rows highlighting after refresh
fixes #6705
2014-08-19 17:32:17 +02:00
Thomas Gelf f40ada6c81 js/ui: check whether a link tag has a type
The new favicon didn't have such, resulting in JS error when reloading
CSS at runtime.
2014-08-19 12:23:51 +02:00
Thomas Gelf 9ce99bf280 js/helpers: add $.hasAttr
Need this for another fix and there is no such jQuery function. As this
seems to also be inconsistant across browsers I thought this would
definitively be worth a custom jQuery plugin.
2014-08-19 12:22:36 +02:00
Thomas Gelf 512e7d516b js/loader: Handle __SELF__ in redirection URLs
That's one more step to smoothly handle #! URLs, especially when you
are not yet authenticated.

refs #6935
2014-08-19 10:00:29 +02:00
Thomas Gelf 3ccfbec53c js/history: no additional container at login
History tries to load additional URLs separated by #! on page load. This
makes no sense on login page. However we need to preserve them when logging
in.

refs #6935
2014-08-19 09:22:10 +02:00
Johannes Meyer 7958a81975 Fix that a form's submit button is not being sent when the method is GET
fixes #6890
2014-08-12 12:49:03 +02:00
Johannes Meyer 3105c2059e Remove license headers from all files
refs #6309
2014-07-15 13:43:52 +02:00
Thomas Gelf 329b1cf960 js/loader: correctly get rid of data
I'm unsure whether this is a jQuery bug or not. The removeData()
function has no effect unless there is a matching data attribute.
Makes IMO no sense, as adding the attribute automagically adds data,
so why should removing it differ.

This patch makes sure that the corresponding attribute is removed too.
Fixes "dashboard sometimes flickering on refresh".

refs #6536
2014-07-08 20:10:44 +02:00
Thomas Gelf bbc0c36225 js/loader: remove pending request on form redirect
Our redirection helper catching forms redirecting to their source
while being shown right-hand left a pending request. Abort was triggered,
but had no effect as the request has already been completed.

fixes #6619
2014-07-07 20:12:49 +02:00
Thomas Gelf 590db51255 js/loader: handle form redirections automagically
An XHR redirection in a right-side container pointing to the URL
shown on the left should close it's own container and refresh the
lefthand one.

refs #6436
fixes #6435
2014-06-30 16:19:05 +02:00
Thomas Gelf 30106a9cbd js/loader: autorefresh requests should run parallel
The check whether a request was already running failed as soon as
another request was activ. Now they run as they should.
2014-06-25 20:15:44 +02:00
Thomas Gelf 1385667edc js/responsiveness: respect singlecolumn layouts
Target _next now depends on current layout
2014-06-24 07:46:37 +02:00
Thomas Gelf 0604d30348 js/loader: stop pending subcontainer requests
When redrawing a container we should cancel it's subcontainers pending
requests. This also fixes stopPendingRequestsFor(), it didn't really
work before.
2014-06-24 07:01:37 +02:00
Thomas Gelf 90bb20f4c3 js/ui: add toggleDebug function 2014-06-24 06:41:57 +02:00
Thomas Gelf 473a705e2e Assign unique ids to dashlets and subcontainers
Without this we have no chance to cancel pending requests for dashlets.

fixes #6552
2014-06-24 06:40:08 +02:00
Thomas Gelf ef0963af38 js/events: ignore javascript: in links 2014-06-24 06:35:52 +02:00
Thomas Gelf 6f19bb13b8 js/loader: ignore focus on autosubmitting elements
Autorefresh response is not rendered while your focus sits in a form.
This is not so useful for autosubmitting elements, let's ignore them.
2014-06-23 14:04:02 +02:00
Thomas Gelf 23ed744747 params/_render: replace it everywhere
Cleaning up controllers and JS, using headers only and respecting
history.
2014-06-22 20:07:44 +02:00
Thomas Gelf aded901aa5 js/loader: reload CSS BEFORE redirecting 2014-06-22 20:01:10 +02:00
Thomas Gelf 41b8b8cf31 js/loader: remove history-related noisy log entry 2014-06-22 19:58:58 +02:00
Thomas Gelf 180a6f08f5 js/loader: notifications should survive new layout
Once replacing the whole layout we used to override notifications.
This is now fixed, they are going to be detached and re-attached
before and after re-rendering the page content.
2014-06-22 19:55:50 +02:00
Thomas Gelf 7444ab7d26 js/ui: add notice when reloading CSS 2014-06-22 19:47:15 +02:00
Thomas Gelf 78193137f0 config/modules: show metadata, improve usability
Well... I didn't want to commit this before creating single-button
forms for enabling/disabling modules. However part of this accidentally
made it through, so let's finish it.

Still some work to do, but it already looks far better like this.

refs #4095
2014-06-21 02:27:27 +02:00
Thomas Gelf 747083d322 JS/history: handle also requests out of containers
On login/logout (not only) we have requests not rendered to containers.
History handling only cared about them and failed.

fixes #6466
2014-06-21 01:57:59 +02:00
Thomas Gelf c0c7a815f8 Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018 2014-06-20 19:18:38 +02:00
Thomas Gelf a79f786546 JS/loader: add icon cache prototype
Just playing around, I'm still unsure whether this really helps. The
motivation behind this patch are icons loaded again after not being
displayed for a little while.

Remains disabled unless we know whether and for which scenarios
(cache disabled, HTTPS...) this really helps.
2014-06-20 16:18:10 +02:00
Thomas Gelf 06a8803242 JS/loader: add failed requests to history
It's confusing if they are handled differently
2014-06-20 16:16:04 +02:00
Thomas Gelf 916c9c027e forms: fix isSubmitted
Implementation made wrong assumptions. A form is submitted when the
submit button has been pressed. It's value is then filled, it also
is when you're just pressing "RETURN". RETURN triggers the FIRST
submit button in a form. This way we are also able to find out which
form button has been pressed.

Current implementation is still poor, however isSubmitted works as
expected right now - and so does autosubmission.

fixes #5967
2014-06-20 14:32:22 +02:00
Thomas Gelf 834a73f926 JS/ui: fix "running" timesince/timeuntil
Broken got this by better English ;)
2014-06-20 13:54:16 +02:00
Thomas Gelf bd57f8f02a JS/loader: don't autorefresh while editing
We would loose our focus if autorefresh takes place. So we don't render
the new content in case a form field in the very same container carries
the focus. It would be great to have a better solution one far day, but
for now it plays fine like this.
2014-06-20 13:52:05 +02:00
Thomas Gelf 76219b025b js/events: multiple multiselect fixes
* Removed obsolete checks (event is only triggered for multiselect tables)
* allows deselecting last row, closing "detail view"
* fix bug when unselecting one of two rows, it used to keep the wrong one
* play nice with other involved non-row-level links
2014-06-20 13:43:18 +02:00
Thomas Gelf f98d8f7fc5 JS/ui: create new simple filter URLs 2014-06-20 13:40:41 +02:00
Thomas Gelf 68a90b8de8 JS/ui: separate closeContainer logic 2014-06-20 13:33:19 +02:00