c00e336ea8
Make the cue that is being appended to required form elements configurable
...
refs #7934
2015-02-27 09:08:05 +01:00
48c3199a2d
Form: Fix id protection
...
Altering element ids upon rendering makes it impossible to reference
them elsewhere. Zend_Form::getId() should be preferred over getName()
as it falls automatically back to getName() in case there is no id attribute
set. Setter are required to return their instance. Overwriting methods
without calling the parent (getId) without any valid (or at least
documented) reason is very bad practice.
refs #8460
2015-02-27 09:01:46 +01:00
6d81a194ab
Make form element descriptions accessible
...
Re-added the Help decorator to make sure an element's description
is being added in an accessible way.
2015-02-27 08:10:25 +01:00
0111fdf78e
Add an asterisk suffix to a form element's label if its required
...
The screen reader part "(required)" is not being considered with this
commit as most screen readers do not need this due to the ARIA and
HTML5 property.
resolves #7934
2015-02-26 16:05:13 +01:00
89451f3086
Ensure that form ids are unique
...
Add an unique prefix to each Form- or FormElement id, unless id protection is disabled explicitly, to prevent id collisions between different containers.
fixes #8460
2015-02-25 18:00:28 +01:00
cc403806f7
Fix refresh accessibility lable if it is empty
...
refs #7968
2015-02-25 15:28:09 +01:00
08ace05ac7
Remove animations.css from StyleSheet loading lessFiles
...
refs #7968
2015-02-25 13:56:32 +01:00
7f883a4770
Add own animation.less to provide own parameterized animate function
...
refs #7968
2015-02-25 13:51:26 +01:00
3a2b69a63c
Remove refreshTab property from Tabs
...
refs #7968
2015-02-25 13:24:11 +01:00
e219bb1664
Add doc for the label
...
refs #7968
2015-02-25 13:13:22 +01:00
481c58ec03
Add accessibility to renderRefreshTab
...
refs #7968
2015-02-25 12:14:26 +01:00
5297b15a61
Merge branch 'master' into feature/refresh-control-7968
2015-02-24 14:41:09 +01:00
d68c636359
Wizard: Disable the browser's form validation when navigating back
...
formnovalidate... The fukin awesomeness of HTML5 is sometimes
even impressing a god-damned h4x0r like me.
fixes #8507
2015-02-24 13:16:31 +01:00
8e8bab0795
Do only escape a qlink's label manually if necessary
2015-02-24 11:35:25 +01:00
956efe5ef9
Merge branch 'master' into feature/link-labels-8458
...
Conflicts:
application/views/scripts/config/application.phtml
application/views/scripts/config/module.phtml
application/views/scripts/config/modules.phtml
library/Icinga/Web/Widget/Dashboard/Dashlet.php
modules/monitoring/application/controllers/TimelineController.php
2015-02-24 08:42:36 +01:00
b626a96e16
Add aria-label to each box of the event grid
...
refs #8458
2015-02-23 17:14:40 +01:00
fb7640db0a
Add proper titles to the Limiter control
...
refs #8458
2015-02-23 17:06:01 +01:00
b2f817925b
Add proper titles to the FilterEditor
...
refs #8458
2015-02-23 17:05:39 +01:00
66305bd79a
Add proper titles to dashboards and dashlets
...
refs #8458
2015-02-23 17:05:02 +01:00
a5514392db
Adjust dashboard, output-format and module tabs
2015-02-23 17:03:11 +01:00
aa5c52dfdd
Implement content refresh control next to dropdown tab
...
refs #7968
2015-02-23 17:02:44 +01:00
9fb3dcabea
Introduce Icinga\Web\Widget\Tab::$label as alternative for $title
2015-02-23 16:48:02 +01:00
f6ea02fec5
qlink: Allow passing null as default for $properties
2015-02-23 16:29:07 +01:00
4cdc1313cf
Dashlet: Add titles to iframe title attribute
...
resolves #8459
2015-02-23 16:20:08 +01:00
2dda3be87b
Merge remote-tracking branch 'origin/master' into feature/organize-headings-7976
2015-02-23 14:28:48 +01:00
03160ef81a
Header: Add header to event history
...
Add header to the following widgets:
- FilterEditor
- SortBox
refs #7976
2015-02-23 14:23:56 +01:00
2992bf3445
Always display tooltips in all charts
...
Make information about data types available to colorblind, when hovering
over the displayed data set
fixes #8364
2015-02-18 13:21:42 +01:00
d3c79dae32
Merge branch 'master' into feature/organize-headings-7976
2015-02-17 15:21:29 +01:00
9c5d44caf0
Fix that webkit submits datetime values not according to RFC 3339
...
That's actually more of a workaround instead of a fix as the bug itself
is part of webkit, not Icinga Web 2.
fixes #8457
2015-02-17 12:50:11 +01:00
43691f6612
Drop BasketAction as it's not used anywhere
2015-02-16 14:37:54 +01:00
7be134a774
Merge master fixed conflicts
2015-02-16 11:24:15 +01:00
5321c2f9e5
Mute icons properly using the new automatic mechanisms of our view helpers
...
refs #8360
2015-02-16 10:52:42 +01:00
243bc6ec0c
Make the view helpers qlink, img and icon handle aria-tags automatically
...
refs #8358
refs #8360
2015-02-16 10:26:03 +01:00
2112676594
Implement hidden accessible control for auto refresh on the page
...
refs #7945
2015-02-13 14:34:29 +01:00
ce3a564de7
Header: Add header to tabs extension
...
refs #7976
2015-02-13 11:26:09 +01:00
b9c9f564ec
Add editable auto_refresh parameter to the user preferences
...
refs #7945
2015-02-12 15:12:10 +01:00
9232c5cf22
Add aria-hidden="true" to all icons that exist only for design reasons
...
refs #8360
2015-02-12 13:49:31 +01:00
09349288e1
Merge branch 'master' into feature/skip-content-7933
2015-02-12 13:14:56 +01:00
b6daf2237d
Menu: Add html5 nav element to menu
...
refs #7933
2015-02-12 13:14:01 +01:00
9e933d835d
Add Icinga\Web\Form\ErrorLabeller
...
refs #8415
2015-02-12 09:11:03 +01:00
aa473fb8cf
Standardize path validators according to Zend's validators
...
refs #8415
2015-02-12 09:11:02 +01:00
a2f3e7d4f7
Display an error in case a user inputs an invalid formatted datetime string
...
resolves #7975
2015-02-12 09:11:02 +01:00
a630db93e8
Show proper examples in case a user doesn't enter a permitted/correct val
...
resolves #7973
2015-02-12 09:11:02 +01:00
eb3063e36d
Form: Add prefix path for custom form validators
...
refs #8415
2015-02-12 09:11:02 +01:00
97261cd8bd
lib: Do not setLayout('pdf') twice
2015-02-11 15:15:18 +01:00
ec8a89b96e
lib: Add recursive iterator over a DOMNode
2015-02-11 13:20:01 +01:00
c5b6d7ee41
Ensure that all required form elements are marked as such in HTML markup
...
refs #8349
2015-02-05 13:15:18 +01:00
6bae2e0a53
Note that our license is GPL v2 or any later version in our license header instead of pointing to the license's URL
2015-02-04 10:52:27 +01:00
49e96b7200
Revert "monitoring/security: Guard delete comment action"
...
This reverts commit 4ef5f0c813
2015-02-03 16:51:00 +01:00
e8466ec7be
Fix inlinePie borders and SVG sizes
...
Add white border to inline piecharts in the list, to make them more visible on mouse hovering. Set a default image size for the loaded svg charts.
2015-02-03 16:46:12 +01:00
5b4fab0750
Add license header
...
This time without syntax errors hopefully :)
2015-02-03 16:27:59 +01:00
5fa2e3cfdc
Revert "Add license header"
...
This reverts commit 338d067aba
2015-02-03 16:16:26 +01:00
4ef5f0c813
monitoring/security: Guard delete comment action
2015-02-03 16:11:56 +01:00
338d067aba
Add license header
...
fixes #7788
2015-02-03 15:51:04 +01:00
08fd000496
Remove any topbar related stuff
...
It's not used anywhere.
2015-02-03 12:42:02 +01:00
cb08b25e17
Remove executable flags from some PHP libraries
...
Note: dompdf.php is actually a CLI script, but has no shebang and is not used
in Icingaweb2.
Fixes #8345
2015-02-03 10:50:50 +01:00
f8c5bf6819
Web\Hook: support hook base classes in modules
...
refs #8207
2015-02-02 17:44:29 +01:00
3596e7ce62
FilterEditor: use preserved params
...
fixes #7904
2015-02-02 17:07:54 +01:00
9d6906bd64
Save user dashboards to Icinga Web 2's configuration directory
...
fixes #8056
2015-02-02 15:06:29 +01:00
5a1ebf9c89
lib: Implement Tab::getUrl()
2015-02-02 14:16:26 +01:00
bf470125c3
Merge branch 'master' into feature/create-missing-directories-when-creating-inis-8219
...
Conflicts:
modules/monitoring/library/Monitoring/MonitoringWizard.php
2015-01-30 16:21:42 +01:00
df29dd0e7c
Implement Form::hasPermission() and Form::getPermission()
2015-01-30 09:35:01 +01:00
2faf5f0ca1
Throw SecurityException in ActionController::assertPermission()
2015-01-30 09:34:19 +01:00
63305fdf9a
Add Icinga\Application\Config::saveIni()
...
Simplifies saving INI files. Icinga\File\Ini\IniWriter does already require an
instance of Icinga\Application\Config so it's obvious to give "Config" the
task to initialize the writer.. We do also have a central place to handle
creating missing ancestor directories now.
refs #8219
2015-01-30 09:32:08 +01:00
dd483d98df
LessCompiler: Remove useless argument
...
refs #6417
2015-01-29 14:04:47 +01:00
c1df1f822e
ifont: Reorganize files and drop use less attributes
...
fixes #6417
2015-01-29 11:25:37 +01:00
4abb30e55b
Merge branch 'master' into bugfix/ie8-fixes-6417
2015-01-28 17:08:56 +01:00
9d05190517
ifont: Fix empty font glyphs for IE8
...
The embedded font is included inline in the stylesheets. IE falls back and
tries to load one of the other font sources which was not exported by the web
server. This fix moves the fontello directory to public and add add a
prefix path to the embedded stylesheet.
refs #6417
2015-01-28 17:06:55 +01:00
6fde4eec30
Show all tabs except "Add to Dashboard" when issuing a command
...
refs #8279
2015-01-28 12:50:29 +01:00
cd8822ceff
lib: Add View::hasPermission()
2015-01-23 09:36:45 +01:00
6da3cb8403
lib: Reorder auth related functions in the ActionController
2015-01-23 09:36:05 +01:00
ef0a7c0e77
Revert "Security: Temporary grant all permissions"
...
This reverts commit 9b7e75a616
2015-01-22 17:11:53 +01:00
0f13c0428c
Controller: Introduce method assertHttpMethod()
...
We have actions where only certain HTTP methods, e.g. POST are allowed but they are not restricted yet.
Controller::assertHttpMethod() takes a number of allowed HTTP methods and responds with HTTP 405 in case
the current request's method is not one of the given methods.
2015-01-22 15:47:16 +01:00
9b7e75a616
Security: Temporary grant all permissions
...
We'll introduce permissions and restrictions in the next hours. Because our web setup
does not configure permissions yet, all permissions are granted for all users from now on.
2015-01-22 15:20:38 +01:00
94d727dbb8
Fix error in Icinga\Web\Form in case the label decorator is missing
...
Zend_Form::getDecorator() returns false instead of null in case the
decorator is not found.
2015-01-22 09:21:50 +01:00
10eacf9682
Allow jumping to already visited pages
...
This was already possible using just the base implementation of Wizard
but since WebWizard has optional pages it did not work with pages that
had such an optional page as previous page.
refs #8191
2015-01-21 15:39:06 +01:00
64a8006973
Add Wizard::isComplete()
...
Wizard::isFinished() is not applicable in case a wizard is a child of another
wizard. Wizard::isComplete() fulfills the need to check whether a user went
through a wizard entirely.
refs #8191
2015-01-21 13:56:53 +01:00
1f6a81aefb
Add Wizard::skipPage()
...
Required to not to duplicate code in custom wizards and to avoid errors
when detecting the direction.
refs #8191
2015-01-21 13:07:08 +01:00
2288e2a687
Add support for nested wizards
...
The amount of vertical dimensions is not limited as well as the location a
nested wizard can occur in the main wizard's order. In case a custom
implementation is used as nested wizard, all core functionalities are
still being utilized.
refs #8191
2015-01-20 15:54:14 +01:00
a1a36301fe
View: Add string helpers
2015-01-19 14:20:57 +01:00
50bbf77d0c
Fix module domain detection in Form::getTranslationDomain()
...
The usage of preg_replace had two errors:
1) The regular expression was wrong
2) $matches[0] always contains the full matched string, not the first parenthesized subpattern
The correct version of preg_replace would've been:
if (preg_match('/^Icinga\\\\Module\\\\([A-Za-z]+)\\\\/', get_called_class(), $matches) === 1) {
return strtolower($matches[1]);
}
But since there's no benefit of using a regular expression here except less speed, I replaced it
with using explode.
refs #7551
2014-12-30 10:08:33 +01:00
a1950aabba
Fix some obsolete or wrong docstrings
2014-12-29 16:27:28 +01:00
4cf8da4bb9
Do not focus logout menu item after a recurring login
...
Implement new MenuItemRenderer made for pages that are not part
of the regular site navigation and should trigger a complete site reload
instead of handling it via XHR.
2014-12-29 16:20:05 +01:00
5e40ce2088
Only check the session save path is writable if the session handler is 'files'
...
fixes #8053
Signed-off-by: Eric Lippmann <eric.lippmann@netways.de>
2014-12-29 09:37:47 +01:00
7f5ba135ee
Revert "Relax session storage check to the `files' save handler"
...
This reverts commit f7d11ce11f#8053
2014-12-29 09:37:07 +01:00
41c101d99f
Use neutral default color in perfdata piecharts
...
If nothing is known about the state of the monitoring object, the piecharts should neither indicate OK nor Critical.
2014-12-23 16:12:25 +01:00
cda5a6a903
Streamline chart implementation
...
Define sparkline layout through CSS class and remove label/tooltip formatting.
fixes #7077
2014-12-23 15:26:45 +01:00
64a2acd12e
Do not display labels for single data sets in perfdata piecharts
...
Display generic chart titles for the whole piechart that only contain title and percentage and don't style perfdata piecharts using HTML properties.
refs #7077
refs #6200
refs #7304
2014-12-23 15:14:17 +01:00
f7d11ce11f
Relax session storage check to the `files' save handler
...
fixes #8053
2014-12-22 11:02:48 +01:00
6d263ae316
Do NOT fetch the translation domain from the request in Form::translate(..)
...
It might be the case that a module is using a library form...
refs #7551
2014-12-19 13:07:51 +01:00
cf43b81400
Use the class namespace instead of the request in Form::translate(Plural)
...
refs #7551
2014-12-19 12:08:54 +01:00
e5d2d4cec2
Add module-aware Form::translate and Form::translatePlural
...
refs #7551
2014-12-19 11:29:24 +01:00
4dfac28393
lib: Fix PHPDoc of Form::setOnSuccess()
2014-12-18 17:21:06 +01:00
7710fd7b0e
Hide unsupported export formats
...
refs #8112
2014-12-18 16:20:41 +01:00
3fde78f2b3
Enable the dompdf float support and fix our list's layout
2014-12-15 13:56:19 +01:00
bca28a5ae2
Display inline pie-charts also in views exported to PDF
...
fixes #6463
2014-12-15 13:55:20 +01:00
cddb68bffb
ActionController: shift global parameters globally
2014-12-03 10:40:48 +01:00
d41602a67c
Rearrange imports in Menu.php
2014-11-25 16:11:01 +01:00
eed10159fd
Menu: Don't render sub menus when a dot appears in the label
...
I guess this was intended to be a feature. Turns out to be a bug though :)
fixes #7772
2014-11-21 17:39:18 +01:00
d84318d8b8
Fix Menu's PHPDoc
...
Don't use @var and don't use @return self for fluent interfaces.
2014-11-21 17:13:39 +01:00
99ad72a0da
Remove the Help decorator
2014-11-20 13:50:40 +01:00
bdc0321f62
Dashboard: Fix wrong URL
...
refs #7751
2014-11-20 13:41:12 +01:00
bb664a87ea
Fix ugly positioning of help icons
...
If an element has a description, the description is now added to the element's label as title.
The CSS class has-feedback ensurers that the help icon is rendererd. If everything is working fine,
I'll the remove the super duper Help decorator.
2014-11-20 13:25:58 +01:00
e600dc8adb
Dashboard: Rename component to dashlet
...
refs #7751
2014-11-20 12:08:50 +01:00
fa44197947
Dashboard: fix complex urls
2014-11-19 16:45:15 +01:00
2830b13082
Merge branch 'master' into feature/security-gui-5647
2014-11-19 16:31:26 +01:00
32af89e0a7
Merge remote-tracking branch 'origin/master' into bugfix/broken-badges-7736
2014-11-19 15:28:27 +01:00
a2818bd937
Merge branch 'master' into feature/security-gui-5647
2014-11-19 14:13:26 +01:00
48699cacf4
Fix navigation layout in firefox and chrome
...
Hover css still broken
refs #7736
2014-11-19 12:15:18 +01:00
dbc1b1ce3e
Merge remote-tracking branch 'origin/master' into feature/add-to-dashboard-4537
2014-11-19 11:48:22 +01:00
a40f357f3c
Dashboard: Show error message when can not write to file
...
refs #4537
2014-11-19 11:47:31 +01:00
47d81ccf7b
css: allow to override vendor styles
...
* no more hovered icon underline
* simulate padding for headers in .controls
2014-11-19 10:33:57 +01:00
a5411c7a1c
Dashboard: Fix reading and disabled system dashboards
...
refs #4537
2014-11-19 10:33:41 +01:00
cfb0ca1be0
Merge remote-tracking branch 'origin/master' into feature/add-to-dashboard-4537
2014-11-19 10:21:50 +01:00
704a87c0f2
FilterEditor: make active element fit hover colors
2014-11-19 10:07:30 +01:00
eb823c4045
Widget\FilterEditor: fix root element stripping
2014-11-19 09:53:25 +01:00
c6ffdb3862
Widget\FilterEditor: fix failing parameter checking
2014-11-19 09:44:47 +01:00
5ace5fd2dc
Dashboard: Change icons
...
refs #4537
2014-11-18 17:47:57 +01:00
aef81a56d6
Merge branch 'master' into feature/security-gui-5647
...
Conflicts:
library/Icinga/Application/Config.php
library/Icinga/File/Ini/IniWriter.php
library/Icinga/Web/Form.php
library/Icinga/Web/Menu.php
2014-11-18 17:08:25 +01:00
f2717b6d26
Introduce Form::setOnSuccess() in favor of overriding the constructor
...
Zend_Form uses setters for options if a respective setter method exists.
It is not necessary to override the constructor for introducing new options.
Conflicts:
library/Icinga/Web/Form.php
2014-11-18 17:02:39 +01:00
10cfecf2ec
Merge remote-tracking branch 'origin/master' into feature/add-to-dashboard-4537
...
Conflicts:
application/controllers/DashboardController.php
library/Icinga/Web/Form.php
library/Icinga/Web/Widget/Dashboard.php
2014-11-18 16:36:42 +01:00
07c0180b1c
Merge branch 'master' into feature/redesign-7144
2014-11-18 16:36:19 +01:00
80871313e4
Dashboard: Remove actions
...
refs #4537
2014-11-18 16:28:04 +01:00
1cbdd2b51c
Fix that hidden elements are getting ovewritten when validating a form
...
This works by "disabling" hidden elements which causes the browser not
to submit them. Due to a bug in Zend we need to manually ensure that
Form::isValid does not overwrite the value of disabled elements with null.
fixes #7717
2014-11-18 15:06:46 +01:00
760bf1a020
Disable partial validation of forms by default
2014-11-18 15:06:46 +01:00
38ef33276a
Replace description decorator through help decorator
...
refs #7696
resolves #7696
2014-11-18 14:58:54 +01:00
4a4fbaee8e
Add Help decorator for icon help description
...
refs #7696
2014-11-18 14:58:05 +01:00
c288a68ed5
Merge branch 'master' into bugfix/drop-zend-config-7147
...
Conflicts:
application/forms/LdapDiscoveryForm.php
2014-11-18 13:21:18 +01:00
7621f6642d
Adjust usages of Icinga\Application\Config
...
refs #7147
2014-11-18 13:11:52 +01:00
8805e4af4b
Merge remote-tracking branch 'origin/master' into feature/add-to-dashboard-4537
2014-11-18 12:52:02 +01:00
3e58ec2530
Dashboard: Use new controller actions
...
refs #4537
2014-11-18 12:51:28 +01:00
f9d7062476
Form: Add our element and decorator paths instead of calling createIcingaFormElement
...
createIcingaFormElement lacks all stuff applied in Zend_Form::createElement().
2014-11-18 12:51:06 +01:00
9a79cd58e9
Re-enable auto-refresh
2014-11-18 10:48:33 +01:00
e3629a7f41
Number element: Use is_numeric in favor of Zend's float validator
...
The float validator uses Zend_Locale which we have stripped in our vendor library thus leading to erroneous validation.
Further we'll use php-intl instead of Zend_Locale one day :)
fixes #7692
2014-11-18 10:31:40 +01:00
cbcd276b44
Dashboard: Rewrite forms and controller [WIP]
...
refs #4537
2014-11-18 10:04:41 +01:00
47414f3528
Introduce Form::setOnSuccess() in favor of overriding the constructor
...
Zend_Form uses setters for options if a respective setter method exists.
It is not necessary to override the constructor for introducing new options.
2014-11-18 10:00:58 +01:00
bec0085683
Dashboard: Add urls to any dashboard (form)
...
refs #4537
2014-11-18 09:59:24 +01:00
769e8f2636
Dashboard/Component: Add remove link
...
refs #4537
2014-11-18 09:59:23 +01:00
b679c1e770
Dashboard: Refactor search/replace implementation
...
refs #4537
2014-11-18 09:59:23 +01:00
979bec24a5
Dashboard: Write user dashboards to disk
...
refs #4537
2014-11-18 09:59:23 +01:00
f6a2f6515d
Dashboard: Introduce user flag widget
...
Fix: Do not render disabled components.
refs #4537
2014-11-18 09:59:23 +01:00
af799d42dc
Widget/Dashboard: Cleanup object and remove unused stuff
...
refs #4537
2014-11-18 09:59:23 +01:00
f83bcbfd2b
updates current font set and changes service and reporting icons
2014-11-17 17:08:08 +01:00
878aa81d98
Changes conf icon in menu
2014-11-17 17:08:08 +01:00
0cea370a5c
Widget\Tab: fix tagParams check breaking tabs
2014-11-16 19:37:11 +01:00
2e1cc8ed35
Widget\Tabs: use icon font
2014-11-16 14:41:22 +01:00
9e0e3f12e3
FilterChain: addFilter should return itself
2014-11-16 02:49:33 +01:00
387928de02
Filter: support 'q' searches
...
This makes the overall search play nice with the FilterEditor and
reduces code in the action controller. Still some work to do, but
seems to be pretty fine right now.
2014-11-16 02:40:28 +01:00
5630374058
FilterEditor: handle ignoreParams correctly
2014-11-16 00:19:28 +01:00
e0bf021fb9
FilterEditor: apply submitted changes do filter
2014-11-15 23:49:37 +01:00
Johannes Meyer
Matthias Jentsch
Alexander Fuhr
Marius Hein
Alexander Klimov
Eric Lippmann
Markus Frosch
Thomas Gelf
Boden Garman
Bernd Erk
Gunnar Beutner