14096 Commits

Author SHA1 Message Date
Johannes Meyer
9ef4c71cec js: Fix error on app startup
jQuery seems to re-cycle event object references oO
2024-08-07 14:35:14 +02:00
Johannes Meyer
97f8767970 js: Only add .impact to a container's content 2024-08-07 14:33:14 +02:00
Sukhwinder Dhillon
62cae50f1e DbResourcePage: Warn the user if Icinga DB is used as configuration database 2024-08-07 14:23:13 +02:00
Sukhwinder Dhillon
c27ca26dad LdapConnection: Access array key only if its set
The key `$controlsReturned[LDAP_CONTROL_PAGEDRESULTS]` can be undefined
when `$controls[LDAP_CONTROL_PAGEDRESULTS]['iscritical']` is set to false.
2024-08-07 14:05:35 +02:00
Johannes Meyer
f8c08dbfec DeleteDowntimesCommandForm: Ignore 404's
fixes #5183
2024-08-07 13:56:08 +02:00
Johannes Meyer
474f918458 navigation/dashboard: Provide fallback for icingadb items without icon
fixes #5177
2024-08-07 13:41:23 +02:00
Johannes Meyer
8ec42b05f8 js: Explicitly update history when col2 is closed
Instead of doing this by default. There are too many
cases where this isn't necessary at all.

fixes #5178
2024-08-07 13:39:41 +02:00
Johannes Meyer
ff0fc55907
list/history: Use intl's default locale to format time and date (#5170) 2024-08-07 13:30:07 +02:00
Johannes Meyer
ab3c9f326d Require ipl version which provides i18n v0.2.2 2024-08-07 13:19:11 +02:00
Johannes Meyer
e1479b4a6a list/history: Use intl's default locale to format time and date 2024-08-07 13:16:51 +02:00
Johannes Meyer
b370d9bd9f
Fix broken UI when trying to resolve an undefined $macro$ (#5201)
fixes https://github.com/Icinga/icingaweb2/issues/5168
2024-08-07 11:50:22 +02:00
Sukhwinder Dhillon
68b264f649 Update phpstan baseline 2024-08-07 11:47:13 +02:00
Sukhwinder Dhillon
d6ceb9ad11 Macro: Fix typo and simplify the code 2024-08-07 11:47:13 +02:00
Sukhwinder Dhillon
41787d91bf Macro: Don't break ui if undefined macro given
$object can be an instance of stdClass and cannot call getName(). The name must then be retrieved manually.
2024-08-07 11:47:13 +02:00
Johannes Meyer
b268044efc
Add missing script-src policy (#5181)
fixes #5180
2024-08-07 11:46:00 +02:00
Johannes Meyer
bb47844646 js: Don't adjust style by using element.cssText
That's prohibited if using `script-src 'self';` in the csp header
2024-08-07 11:39:58 +02:00
Johannes Meyer
4c3139224e Csp: Include `script-src 'self';
fixes #5180
2024-08-07 11:39:58 +02:00
Johannes Meyer
fa394c8895
Fix that graphs disappear after using form controls (#5182) 2024-08-07 11:38:14 +02:00
Johannes Meyer
6964bd19a2 js: Improve rejection of autorefresh responses
Don't reject autorefreshes if an autosubmit
element is focused but not interacted with

fixes #4996
2024-08-07 11:20:11 +02:00
Johannes Meyer
a48a6ebcb5 js: Really stop rendering if a hook discards content
This is a potential breaking change for behaviors which
rely on being able to change content in-place even if
the response's content is not applied. This is the case
for grafana's iframe behavior, though that's more a hack
than a necessity so it doesn't break. I've found no other
implementations so I guess it's fine including it here.
2024-08-07 11:20:11 +02:00
Johannes Meyer
c79b513066 js: Apply render hooks in a defined order
Currently, form first and detach second.
Any other last. (e.g. grafana's iframe)
2024-08-07 11:20:11 +02:00
Johannes Meyer
acf8795d70
Fix several doc issues (#5215) 2024-04-15 13:27:31 +02:00
Johannes Meyer
b3bffa7832 Tab(s): Fix doc types 2024-04-15 13:02:10 +02:00
Johannes Meyer
a734aca11b Controller: Fix doc of httpNotFound and httpBadRequest 2024-04-15 13:02:10 +02:00
Johannes Meyer
efea832890 php: Split phpstan tests into a separate workflow 2024-04-08 17:10:58 +02:00
Robin Kraft
dba77bce57
add canceled downtimes to the history, if they were started (#5184)
fixes https://github.com/Icinga/icingaweb2/issues/5176
2024-04-05 16:23:56 +02:00
Johannes Meyer
d6881e0273 ConfigObject: Document generics 2024-02-15 14:13:48 +01:00
Johannes Meyer
58b3321852
phpstan: Streamline vendor file location with local dev-env (#5175) 2024-02-09 14:17:17 +01:00
Sukhwinder Dhillon
23dbdcf804 Phpstan: Seprate baselines based on php version 2024-02-09 14:13:44 +01:00
Sukhwinder Dhillon
804f28ea8a CommentParser: Add var type hint 2024-02-09 14:05:22 +01:00
Sukhwinder Dhillon
31e3455c79 LdapConnection: Fix ldap return type issues
ldap_connect() in php >= 8.1 returns `LDAP\Connection` instead of `resource` and all ldap_*() methods expects the returned type. But function defined return type and $ds type confuses phpstan, so i removed the hardcoded type hint.
2024-02-09 14:05:22 +01:00
Sukhwinder Dhillon
b270161455 phpstan: Streamline vendor file location with local dev-env
phpstan is not run with an action anymore, as the action runs
it its own docker container and hence has no access to files
outside the repository root. A side-effect of this is, that
phpstan now **really** runs with the php version set up by
the matrix.
2024-01-22 09:49:41 +01:00
Johannes Meyer
cd2daeb2cb
Release v2.12.1 (#5150) v2.12.1 2023-11-15 12:50:13 +01:00
Johannes Meyer
b23cbd796f Raise version to 2.12.1 2023-11-15 12:22:46 +01:00
Johannes Meyer
3042d7e973 Update CHANGELOG.md 2023-11-15 12:21:57 +01:00
Alexander Aleksandrovič Klimov
50f6f4d1c5 RELEASE.md: remove obsolete Docker section
Our GHA are going to create all Docker tags by themselves, no manual action needed.
2023-11-14 11:23:48 +01:00
Alexander Aleksandrovič Klimov
d3f64604a3
Support PHP 8.3 (#5137)
fixes #5136
2023-11-14 11:22:54 +01:00
Johannes Meyer
f676685876
migrate: Deprecate navigation command (#5148) 2023-11-13 16:45:40 +01:00
Johannes Meyer
c88c1ba635 Update phpstan-baseline.neon 2023-11-10 15:59:00 +01:00
Johannes Meyer
529616d1f1 migrate: Deprecate navigation command 2023-11-10 15:52:09 +01:00
Johannes Meyer
a1cd968579
Fix redirection loop (#5143)
fixes #5133
2023-10-27 10:21:40 +02:00
Johannes Meyer
a2c143d75e Response: Only preserve showCompact for explicit redirects
In case of a `__SELF__` redirect, the client should still have
the parameter in the location and its preserved this way then.
2023-10-27 10:15:47 +02:00
Johannes Meyer
30b540952a loader.js: Don't consider redirected form submits as auto submits
A redirect caused by a form submit is **never** an automatic submit.
Unless I'm missing something here. There is one way this may be true,
as ipl forms without a submit button are indeed successful due to a
autosubmit element, but they don't redirect by default. So if the
controller redirects in such a case, the form should have a submit
button, I guess..

Anyway, this is necessary due to the previous commit as this may
otherwise cause form submits, that re-render layout during a redirect,
are considered being auto submitted. (Such as the login form)
2023-10-27 10:15:47 +02:00
Johannes Meyer
4743c5f5c8 loader.js: Really don't push redirects to history
refs #4879
2023-10-27 10:15:47 +02:00
Johannes Meyer
e4e23a3abc doc: Fix link pointing to graphite's CSP support release 2023-10-27 10:15:21 +02:00
Johannes Meyer
2fb36c0c8a
Fix PostgreSQL grants (#5130)
fixes #5129
2023-10-27 08:01:36 +02:00
Yonas Habteab
ae9575e7e4 DbResourcePage: Don't fail validation if connecting to pgsql wasn't successfull 2023-10-26 17:07:17 +02:00
Yonas Habteab
bcdad8c9b3 MigrationManager: Enhance how pgsql privileges are checked
For mysql it's just enough to check whether the privileges are granted
at database or table label, but for PostgreSQL it's necessary that the
privileges are granted at database and at table level.
2023-10-26 17:07:17 +02:00
Yonas Habteab
329fd9e316 DbTool: Enhance issuing and verifying pgsql privileges 2023-10-26 17:07:17 +02:00
Yonas Habteab
a99f685d15 Add missing pgsql USAGE privilege 2023-10-26 17:07:17 +02:00