2536 Commits

Author SHA1 Message Date
Johannes Meyer
a40feeb324 Merge branch 'bugfix/show-non-piechart-perfdata-not-as-piechart-6515'
fixes #6515
2014-07-14 13:49:04 +02:00
Johannes Meyer
bacea36ad9 Improve piechart limitation and show non-piechart perfdata as well
The perfdata helper did an improper limitation as it might have skipped
valid values due to applying the limit before the filter. When not in compact
view the helper now also shows non-piechart values by using their raw
representation.

refs #6515
2014-07-14 13:48:30 +02:00
Johannes Meyer
5908e9fc70 Do not show pie charts for perfdata values when no percentage is available
refs #6515
2014-07-11 16:32:05 +02:00
Johannes Meyer
ec2d1daa6b Perfdata plugin should also have a knowledge about labels
Prior to this change the PerfdataSet only knew the labels of a performance
data value which prevented the Perfdata object from being used
individually.

refs #6515
2014-07-11 16:31:00 +02:00
Johannes Meyer
b046023623 Ensure that our menu inis are in sync and up2date
The menu configurations for vagrant missed the entries for the timeline,
applicationlog and contacts-view.

fixes #6512
2014-07-11 08:49:58 +02:00
Johannes Meyer
ab410de615 Make Icinga\Logger\Writer\FileWriter output more useful error messages
fixes #6464
2014-07-10 16:40:36 +02:00
Johannes Meyer
b4dc0f38b3 Fix monitoring backend configuration not showing resource selection fields
fixes #6448
2014-07-10 15:50:52 +02:00
Johannes Meyer
53f3d74103 Fix word wrapping in perfdata labels and values
fixes #6377
2014-07-10 14:54:53 +02:00
Eric Lippmann
3c9d2b0c9f git: Ignore git related files on export 2014-07-10 14:04:12 +02:00
Johannes Meyer
d22363d365 Fix error messages not being displayed in the preferences configuration 2014-07-10 13:43:49 +02:00
Matthias Jentsch
b85ac3ab45 Translate labels in the ChartController 2014-07-09 18:13:40 +02:00
Matthias Jentsch
3ed67c9af6 Determine the scale factor correctly
Fix error in the logic of the context renderer, that lead to a wrong scale factor
when the width was bigger than the height
2014-07-09 18:13:40 +02:00
Matthias Jentsch
8d697a3d8e Fix coding style 2014-07-09 18:13:40 +02:00
Matthias Jentsch
ec3bafa026 Fix number formatting in chart classes
Use explizit number formatting instead of implicit type conversions when
rendering SVGs, to prevent a change of the locale from breaking the charts.

fixes #6585
2014-07-09 18:13:40 +02:00
Johannes Meyer
e21b4243ca Fix error message when no authentication method available
The error handling for configuration files has slightly changed (non
existent files are treated as empty) so the authentication chain handling
needed to be adjusted as well.

fixes #6268
2014-07-09 12:53:25 +02:00
Johannes Meyer
0d92efc1b0 Consider is_active column when fetching host and service statistics
fixes #6157
2014-07-09 11:49:22 +02:00
Johannes Meyer
0fc2604af3 Use Icinga\Data\Db\DbConnection instead of Zend_Db_Select directly
fixes #6218
2014-07-09 10:41:54 +02:00
Thomas Gelf
329b1cf960 js/loader: correctly get rid of data
I'm unsure whether this is a jQuery bug or not. The removeData()
function has no effect unless there is a matching data attribute.
Makes IMO no sense, as adding the attribute automagically adds data,
so why should removing it differ.

This patch makes sure that the corresponding attribute is removed too.
Fixes "dashboard sometimes flickering on refresh".

refs #6536
2014-07-08 20:10:44 +02:00
Thomas Gelf
49c679fe0f FilterEditor: hide "add" links
They where there to show how this should look like. Removed for now as
they are not implemented yet.

refs #6668
2014-07-08 17:21:36 +02:00
Thomas Gelf
2b05aa9504 monitoring/list: do not apply empty filter
Fixes problems with the servicematrix when no filter is applied.
I'm not yet happy with this, calls to where() should automagically
handle existing empty filters.

fixes #6543
2014-07-08 16:36:05 +02:00
Thomas Gelf
9a6821c860 monitoring/list/hosts: restore page behaviour
The problem here was that an accidentally removed closing div tag in
15325949 caused the application to missbehave badly. Host details where
rendered below the list in some scenarios and the whole multicolumn
thingy started to feel broken.
2014-07-08 15:17:00 +02:00
Thomas Gelf
bbc0c36225 js/loader: remove pending request on form redirect
Our redirection helper catching forms redirecting to their source
while being shown right-hand left a pending request. Abort was triggered,
but had no effect as the request has already been completed.

fixes #6619
2014-07-07 20:12:49 +02:00
Johannes Meyer
bb2c85f90b Remove forgotten ActionController::requiresConfig() call
Should have been reverted by last commit but was not.
2014-07-07 16:12:26 +02:00
Johannes Meyer
82d2f5ac9b Revert "Merge branch 'feature/install-wizard-6136'"
This reverts commit 88d4262e7ca17430eb2385715f402becfc653797, reversing
changes made to 6fae333048d0ef2b95f52c8113143c79e10c4e50.

Conflicts:

	application/controllers/InstallController.php
	library/Icinga/Web/Controller/ActionController.php
2014-07-07 15:09:03 +02:00
Johannes Meyer
1950c09478 Remove encoding suffix from locale identifiers
We do not need those as the encoding of a gettext-catalog is already
mentioned in its header.

refs #6602
2014-07-07 09:09:22 +02:00
Johannes Meyer
b3cb29d804 Make Icinga\Util\Tranlsator not only return locale codes with encodings
refs #6602
2014-07-07 09:09:22 +02:00
Thomas Gelf
e3b2f15863 list/hosts: show unhandled services righthand
This way we automagically fix the problem with the wrong row links.
I guess we should re-introduce the "row-action" class allowing "precedence"
rules, so also a link not being the first one in a row could act as "row-link".

Changed formatting / text output a little bit, IMO even more cure is needed.

fixes #6645
2014-07-04 18:13:44 +02:00
Matthias Jentsch
d2098be625 Only display header when not in compact mode
fixes #6508
2014-07-04 12:45:17 +02:00
Thomas Gelf
0d4166b1bd ModuleActionController: fix reference, var removed 2014-07-04 12:39:23 +02:00
Thomas Gelf
3cfdf4c977 Web\Response: add redirection function
The response now provides redirectAndExit(). One more step to clean up
our action controller. Please not that this is still unused right now.
2014-07-04 12:35:33 +02:00
Thomas Gelf
3772b9c16f ActionController: set layout module name early
Didn't work correctly before
2014-07-04 12:33:49 +02:00
Matthias Jentsch
485e2168c1 Fix coding style 2014-07-04 11:42:24 +02:00
Matthias Jentsch
05139ae684 Fix a bug in the section map creation of the IniEditor
Don't omit the first line when putting 'glued' comments into
the following section
2014-07-04 11:38:30 +02:00
Matthias Jentsch
fa61b601d4 Test whether section comments are moved correctly 2014-07-04 11:35:00 +02:00
Matthias Jentsch
e78f01591d Fix PreservingIniWriterTest section test case
The test case now tests whether the section order of the ini file is updated correctly and
not whether the section order is preserved

fixes #6625
2014-07-03 17:26:55 +02:00
Eric Lippmann
839af7f363 Fix `make install-cli'
Replace spaces with tabs.

fixes #6580
2014-07-03 16:50:20 +02:00
Matthias Jentsch
57f3023ec4 Fix coding style 2014-07-03 16:20:45 +02:00
Matthias Jentsch
86ad5f738b Fix LdapBackendFormTest
Alter class mocks to fit the latest changes in LdapBackendFormTest

fixes #6597
2014-07-03 16:15:02 +02:00
Johannes Meyer
298edbe730 Merge branch 'bugfix/activate-menu-entry-based-on-the-url-6153'
fixes #6153
2014-07-03 15:47:04 +02:00
Johannes Meyer
143a1e44fe Add a HTML renderer for Icinga\Web\Menu
The menu was being rendered through recursive partials before. The
overhead this fact implicates is not as efficient as standard recursion
so there is now a special renderer for Icinga\Web\Menu utilizing
the RecursiveIteratorIterator

refs #6153
2014-07-03 15:46:46 +02:00
Johannes Meyer
8eac449d56 Adjust the test for Icinga\Web\MenuItem as its test subject has changed
refs #6153
2014-07-03 15:14:47 +02:00
Johannes Meyer
be18af7e7e Merge Icinga\Web\MenuItem into Icinga\Web\Menu
We do not need an additional class for the menu's root item just to
encapsulate our config handling, so these two classes were now merged
into a single one. Icinga\Web\Menu now also extends from
RecursiveIterator to be able to render the menu more efficient to html.

refs #6153
2014-07-03 15:14:47 +02:00
Eric Lippmann
8727c9b91d Revert "tests: Fix path to `extcmd_test'"
This reverts commit 4054bcf1011c36f3316292bb4fd892a987ab9ca7.

The changed path to `extcmd_test' is actually invalid because `extcmd_test' is located beneath `<icingaweb>/modules/test/bin'.
I erroneously assumed the latter as invalid because the compiled `extcmd_test' was missing.
2014-07-02 12:18:15 +02:00
Eric Lippmann
9b2d674c50 Merge branch 'bugfix/test-fix-6542'
fixes #6542
2014-07-02 11:39:28 +02:00
Eric Lippmann
4054bcf101 tests: Fix path to `extcmd_test'
The path to `extcmd_test' is now `<icingaweb>/test/php/extcmd_test' instead of being relative to the current directory.

refs #6542
2014-07-02 11:09:04 +02:00
Eric Lippmann
545a153490 Merge branch 'master' into bugfix/test-fix-6542 2014-07-02 10:57:08 +02:00
Johannes Meyer
d4a4cf90ad Fix vagrant provisioning for icinga1.x access 2014-07-02 08:39:49 +02:00
Johannes Meyer
920c027990 Ensure that the ini writer deletes properties properly
The fix for #5958 introduced with commit 6aaff6b3 caused the property
deletion of the PreservingIniWriter be even more faulty than before. The
actual fix for this issue is an improved procedure for how properties are
deleted as the initial implementation suffered from a few
misunderstandings in how properties in Zend_Ini files need to be handled.

fixes #6599
fixes #6601
fixes #6600
fixes #6598
fixes #6614
2014-07-01 14:55:45 +02:00
Johannes Meyer
87e72961e8 Revert "Fix that the ini writer produces invalid configuration files"
This reverts commit 9bec8e3c27702914f964a6be607ee12cb379d1bb.
2014-07-01 14:45:00 +02:00
Johannes Meyer
9bec8e3c27 Fix that the ini writer produces invalid configuration files
fixes #6614
2014-07-01 14:21:46 +02:00