5ea02b41ea
Optimize variable names and positions, cast array direct to object
2014-07-18 17:35:24 +02:00
2a204897b4
DbQuery: improve method description
...
Not English mine this was, copy paste did I ;)
2014-07-18 16:48:52 +02:00
209894d857
DbQuery: add dummy isTimestamp function
...
Not the best solution, but helps for now.
fixes #6675
2014-07-18 16:35:29 +02:00
f4ff2c90f2
It's a form's responsibility how its submit button should look like
...
refs #5525
2014-07-18 09:54:36 +02:00
6ac471c598
Also mention the viewscript functionality of Form::loadDefaultDecorators()
...
refs #5525
2014-07-18 09:52:50 +02:00
8f0b9899a3
We cannot know what kind of data is passed to Form::isValid()
...
refs #5525
2014-07-18 09:52:05 +02:00
78a6175acc
Make form creation lazy and implement the new validation mechanism
...
Form creation must not depend on specific function calls. If a forms' elements are required and missing, create them. Form::isValid() must be
able to determine whether a form can be processed or not without to rely
on a particular button value.
refs #5525
2014-07-18 09:51:15 +02:00
37fd3deb67
Rename initCsrfToken to addCsrfToken and move it upwards
...
Form::addCsrfToken() should be public and fluent to ensure more
flexibility.
refs #5525
2014-07-18 09:43:03 +02:00
58188c5cc1
We only want to rely on Form::isValid() when about to process forms
...
As the new auto-submission implementation does not depend on whether
a submit button was pressed or not we need another way to determine
whether a form should be processed.
refs #5525
2014-07-18 09:33:09 +02:00
802c095bf8
Configuration values need to be inserted to forms explicitly
...
It's the controllers' responsibility to ensure that forms are populated with
configuration values on GET requests.
refs #5525
2014-07-18 09:27:10 +02:00
21cd503ee7
Form buttons need to be added explicitly
...
We either demand the user to add a submit button or provide a implicit
function call to be implemented by him, adding additional elements once
the form gets rendered.
refs #5525
2014-07-18 09:24:49 +02:00
47ae4d79dc
Forms do not need a special title property
...
As our upcoming wizard has no menu and our tabs are hardcoded we do not
need a special "title" property anymore.
refs #5525
2014-07-18 09:21:11 +02:00
1de2d0c14f
Merge branch 'master' into bugfix/rebuild-form-builder-5525
...
Conflicts:
application/forms/Authentication/LoginForm.php
library/Icinga/Test/BaseTestCase.php
library/Icinga/Web/Form.php
library/Icinga/Web/Form/Decorator/BootstrapForm.php
2014-07-17 13:15:42 +02:00
bfc54b7e32
Fix array conversion of the Dashboard and its Components
...
Do not omit the parameters when converting the dashboard components to
an array. Add an array conversion to the UrlParams class.
refs #6691
2014-07-16 17:31:01 +02:00
5c507d5d91
Fix notice that the session has been already started after retrieving its id
2014-07-16 15:39:40 +02:00
eb977b7a55
Fix wrong variable assignment causing preferred languages not being set
2014-07-16 15:17:14 +02:00
e5fdf78c98
Fix testing errors due to accessing the session id by using our container
2014-07-16 10:18:00 +02:00
e6dee9fe89
Protect login against CSRF
...
refs #5626
2014-07-16 09:55:23 +02:00
b40027b6c7
Purge session when logging out
...
fixes #6739
2014-07-16 09:55:22 +02:00
19f05256a0
Only call session_start() when reading from session
...
fixes #6383
2014-07-16 09:55:22 +02:00
c7c2ad3790
Improve preference changeset calculation
...
The calculation is still subject to the concrete writer implementation as its
parent Icinga\User\Preferences\PreferencesStore is only an abstraction
layer without any knowledge how the data is actually stored so it is not able
to determine how to handle differences.
fixes #6220
2014-07-15 14:54:57 +02:00
3105c2059e
Remove license headers from all files
...
refs #6309
2014-07-15 13:43:52 +02:00
e567ad67c5
Display statehistory summary vertically
...
fixes #6636
2014-07-14 15:26:35 +02:00
906c132dc0
Merge branch 'master' into feature/display-documentation-4820
2014-07-11 16:05:09 +02:00
ab410de615
Make Icinga\Logger\Writer\FileWriter output more useful error messages
...
fixes #6464
2014-07-10 16:40:36 +02:00
0dce204651
Refactor Icinga\Web\Form
...
We eagerly waited badly for a new approach to build forms, so here it is.
Should be the best compromise between the Zend_Form functionality and
our requirements regarding automatic submits.
refs #5525
2014-07-10 11:13:45 +02:00
1a1263d9d8
Rename Icinga\Web\Form\Decorator\BootstrapForm
...
We do not use bootstrap anymore but do not want the default Zend
decorators either so this decorator got a more common name.
refs #5525
2014-07-10 11:09:48 +02:00
3ed67c9af6
Determine the scale factor correctly
...
Fix error in the logic of the context renderer, that lead to a wrong scale factor
when the width was bigger than the height
2014-07-09 18:13:40 +02:00
8d697a3d8e
Fix coding style
2014-07-09 18:13:40 +02:00
ec3bafa026
Fix number formatting in chart classes
...
Use explizit number formatting instead of implicit type conversions when
rendering SVGs, to prevent a change of the locale from breaking the charts.
fixes #6585
2014-07-09 18:13:40 +02:00
0fc2604af3
Use Icinga\Data\Db\DbConnection instead of Zend_Db_Select directly
...
fixes #6218
2014-07-09 10:41:54 +02:00
49c679fe0f
FilterEditor: hide "add" links
...
They where there to show how this should look like. Removed for now as
they are not implemented yet.
refs #6668
2014-07-08 17:21:36 +02:00
bb2c85f90b
Remove forgotten ActionController::requiresConfig() call
...
Should have been reverted by last commit but was not.
2014-07-07 16:12:26 +02:00
82d2f5ac9b
Revert "Merge branch 'feature/install-wizard-6136'"
...
This reverts commit 88d4262e7c6fae333048
2014-07-07 15:09:03 +02:00
b3cb29d804
Make Icinga\Util\Tranlsator not only return locale codes with encodings
...
refs #6602
2014-07-07 09:09:22 +02:00
0d4166b1bd
ModuleActionController: fix reference, var removed
2014-07-04 12:39:23 +02:00
3cfdf4c977
Web\Response: add redirection function
...
The response now provides redirectAndExit(). One more step to clean up
our action controller. Please not that this is still unused right now.
2014-07-04 12:35:33 +02:00
3772b9c16f
ActionController: set layout module name early
...
Didn't work correctly before
2014-07-04 12:33:49 +02:00
485e2168c1
Fix coding style
2014-07-04 11:42:24 +02:00
05139ae684
Fix a bug in the section map creation of the IniEditor
...
Don't omit the first line when putting 'glued' comments into
the following section
2014-07-04 11:38:30 +02:00
57f3023ec4
Fix coding style
2014-07-03 16:20:45 +02:00
143a1e44fe
Add a HTML renderer for Icinga\Web\Menu
...
The menu was being rendered through recursive partials before. The
overhead this fact implicates is not as efficient as standard recursion
so there is now a special renderer for Icinga\Web\Menu utilizing
the RecursiveIteratorIterator
refs #6153
2014-07-03 15:46:46 +02:00
be18af7e7e
Merge Icinga\Web\MenuItem into Icinga\Web\Menu
...
We do not need an additional class for the menu's root item just to
encapsulate our config handling, so these two classes were now merged
into a single one. Icinga\Web\Menu now also extends from
RecursiveIterator to be able to render the menu more efficient to html.
refs #6153
2014-07-03 15:14:47 +02:00
545a153490
Merge branch 'master' into bugfix/test-fix-6542
2014-07-02 10:57:08 +02:00
920c027990
Ensure that the ini writer deletes properties properly
...
The fix for #5958 introduced with commit 6aaff6b3fixes #6599
fixes #6601
fixes #6600
fixes #6598
fixes #6614
2014-07-01 14:55:45 +02:00
87e72961e8
Revert "Fix that the ini writer produces invalid configuration files"
...
This reverts commit 9bec8e3c27
2014-07-01 14:45:00 +02:00
9bec8e3c27
Fix that the ini writer produces invalid configuration files
...
fixes #6614
2014-07-01 14:21:46 +02:00
db5c6631d9
Merge branch 'master' into feature/display-documentation-4820
...
Conflicts:
modules/doc/library/Doc/Controller.php
2014-07-01 12:42:55 +02:00
7eb0f3c472
Remove @codingStandardsIgnoreStart/-Stop annotations
...
refs #6091
2014-06-30 13:59:58 +02:00
f2e5d8afa5
Remove @codeCoverageIgnoreStart/-Stop annotations
...
refs #6091
2014-06-30 13:58:37 +02:00
62928c48b0
helpers/timeSince: fix c&p error
2014-06-27 23:37:39 +02:00
7ab984106a
Replace Exception with Icinga\Exception\ProgrammingError in Icinga\Application\Loader
...
refs #6542
2014-06-27 15:20:56 +02:00
4b72e1b54f
Revert "Fix PHP Fatal error "Method Icinga\File\Csv::__toString() must not throw an exception in /vagrant/test/php/library/Icinga/File/CsvTest.php on line 35""
...
This reverts commit f2fdd7f39df759ff27c9c133f40bbcae14820708.
2014-06-27 14:30:57 +02:00
22e13ce282
Replace DatasourceInterface with Selectable in Icinga/Protocol/Statusdat/Reader
...
refs #6542
2014-06-27 14:30:57 +02:00
c0b44c3248
Revert "Fix PHP Fatal error "Interface Icinga\Data\DatasourceInterface not found in /vagrant/library/Icinga/Protocol/Statusdat/Reader.php on line 41""
...
This reverts commit 35e12c2053685a6951765a007a0e3f8c7999734f.
2014-06-27 14:30:57 +02:00
b04f9b91be
Fix PHP Fatal error "Interface Icinga\Data\DatasourceInterface not found in /vagrant/library/Icinga/Protocol/Statusdat/Reader.php on line 41"
2014-06-27 14:30:57 +02:00
0065cbe998
Fix PHP Fatal error "Method Icinga\File\Csv::__toString() must not throw an exception in /vagrant/test/php/library/Icinga/File/CsvTest.php on line 35"
2014-06-27 14:30:57 +02:00
9c1ee57628
Icinga\Util\File: throw an ErrorException with file and linenumber details
2014-06-27 09:54:17 +02:00
7f99be73fd
Adjust usages of Icinga\Util\File to suit the new interface introduced earlier
2014-06-26 15:57:14 +02:00
3b191d36c4
Let Icinga\Util\File extend from SplFileObject
...
We should extend SplFileObject as it provides already some of the
functionality Icinga\Util\File had and adds even more on top of that.
2014-06-26 15:57:14 +02:00
7112ed23f4
Chart\InlinePie: locale-ignorant cast for floats
...
This has already been fixed with 92f454c3be0c5d4b#6348
2014-06-25 22:13:19 +02:00
10d1520711
Widget\Limiter: show "all"
...
In case we pass limit=0 we show this, still unsure whether we should
provide a link for "showing all" - might really hurt with millions of
history rows.
2014-06-25 20:39:10 +02:00
59dd80ed32
ActionController: benchmark should measure rendering
...
We have been cheating a little bit, now the measurement should be more
precise.
2014-06-25 20:37:17 +02:00
d49f30ff77
Improve InlinePie performance
...
Use str_replace instead of preg_replace
2014-06-25 15:24:53 +02:00
7b19bd1d99
Improve interface of InlinePie
...
Method setLabel can also accept a simple string and title is mandatory in constructor
2014-06-25 15:21:12 +02:00
8839166090
Add number format 'none' to InlinePie
2014-06-25 14:53:39 +02:00
35a5431512
Revert "Refractor InlinePie and Perfdata helper"
...
This reverts commit f003c38abd
2014-06-25 14:29:17 +02:00
c18b6f26f0
Throw Ldap\Exception when something goes wrong in a Ldap connection
2014-06-25 12:41:17 +02:00
e7548b6fc7
Return null for empty DNS query results
2014-06-25 12:41:17 +02:00
f003c38abd
Refractor InlinePie and Perfdata helper
...
Refractor InlinePie methods for better usability, fix several coding guideline
issues and fix some typos
2014-06-25 12:41:17 +02:00
2fc793096a
Use the preferred language sent by the browser, not the configured one
...
refs #6074
2014-06-25 12:15:41 +02:00
461b050718
Add locale negotiation to Icinga\Util\Translator
...
Translator::getPreferredLocaleCode($header) can now be used with the
HTTP "Accept-Language" header to return the best matching locale using
the user's preferations reported by the browser and our available locale
stack. Additionally Translator::getLocale and Translator::getLanguage were
replaced by Translator::splitLocaleCode to provide a more flexible
implemenation in order to identify specific parts of a particular locale or
the current one.
refs #6074
2014-06-25 12:15:41 +02:00
53de3686a8
Bootstrap: Only replace config dir with its canonicalised absolute pathname when the dir exists
2014-06-25 11:59:09 +02:00
ab1d8655f9
Config: Hard-code path to preferences INI files
2014-06-25 11:59:09 +02:00
a18058e185
lib: Assume relative path for Config::resolvePath()
2014-06-25 11:59:09 +02:00
ebca81b040
Revert "Make preferences INI path NOT be configurable"
...
This reverts commit f2693613d1
2014-06-25 11:59:08 +02:00
fdf74c5e18
Revert "Make preferences INI path NOT be configurable"
...
This reverts commit 219869607d
2014-06-25 11:59:08 +02:00
fac3c9f3a6
Util\Translator: fix language list
...
Reverted former redundant patch, got confused by legacy web modules
been translated with earlier versions. They had a different directory
structure and registered erraneous domain directories.
This patch fixes the list, does an additional safety check (dirname must
end with .UTF-8) and strips .UTF-8 from the locale name. Former regex
matched always and therefore blacklisted every translation.
2014-06-25 11:43:15 +02:00
20cdb6e0b8
Revert "Util\Translator: show correct language list"
...
This reverts commit b7521f48b9
2014-06-25 11:37:37 +02:00
4591297e56
SortBox: use POST instead of GET
...
This avoids trouble with complex filter URLs
fixes #6556
2014-06-25 11:00:10 +02:00
7ebdb2d378
FilterQueryString: add hidden debug feature
...
Might help to track down potential problems in the future, should
not be enabled by default
2014-06-25 10:47:03 +02:00
9359f527db
FilterQueryString: fix issues with not
...
NOT is a "chain" with just one subfilter and therefore behaves a little
bit different. Should work fine now.
fixes #6554
2014-06-25 10:39:48 +02:00
1dcf44b9cd
FilterEditor: fix buggy dropdown boxes
...
There were some issues with option names. Also cleaned up HTML a
little bit and added autosubmission.
2014-06-25 10:37:06 +02:00
b40d0f6a1e
FilterWidget: POST instead of GET
...
Might have been a JS issue, but instead of messing with the URL just
POSTing is easier here - and works. Filters from the search box are
now added flawlessly to the filter tree.
2014-06-25 10:34:09 +02:00
b7521f48b9
Util\Translator: show correct language list
...
List was showing useless stuff such as LC_MESSAGES and no language
but the default one. We should have a look whether LC_MESSAGES is
really needed, it looks so ugly.
2014-06-25 10:31:03 +02:00
2746b5ff9f
ConfigController: switch over to new config tabs
...
Module configuration now takes place in module detail view and does no
longer pollute our config tabs. Modules are now able to provide a bunch
of own config tabs, we don't really care what they use them for.
2014-06-24 21:31:59 +02:00
b38bcfc19b
Widget\FilterEditor: correct expression output
...
Filter expressions should be filled into form fields exactly as we
expect them at parse time.
fixes #6568
2014-06-24 21:00:01 +02:00
47b893e1ea
Widget\FilterEditor: handle custom vars
...
There was an issue with custom vars as they made only partially part
of the column dropdown. Sorted columns and tried to beautify column
names.
fixes #6569
2014-06-24 20:57:41 +02:00
3f9f4bb9e1
ModuleActionController: module object shortcut
...
This helps modules with the need to know more about themselves. No
more App -> Module Manager -> Module voodoo.
2014-06-24 20:54:39 +02:00
13ef06c700
Modules\Module: modules should register config tabs
...
This allows modules to register their config tabs and provides a
convenient way to fetch a modules fully instanced config tabs.
2014-06-24 20:47:03 +02:00
b7b99cfd67
Widget\AlertMessageBox: fix broken widget
...
This widget is pretty useless as the error view script can to it's
job. Interestingly nobody missed it, even the render() call was wrong.
I guess we will remove this soon, but for now it's fixed. Looks ugly,
but works.
2014-06-24 20:30:41 +02:00
219869607d
Make preferences INI path NOT be configurable
...
fixes #6567
2014-06-24 18:29:28 +02:00
f2693613d1
Make preferences INI path NOT be configurable
...
refs #6567
2014-06-24 18:00:40 +02:00
3e31ff65a4
Prefer dirname rather than pathinfo
2014-06-24 15:57:13 +02:00
6daccae30e
Optimize IcingaConfig::resolvePath
2014-06-24 15:45:19 +02:00
6e4bf73c36
Compute config file paths properly
...
fixes #6564
fixes #6534
2014-06-24 14:54:31 +02:00
9bab7c0323
Signal that resolvePath doesn't support Windows
...
refs #6564
2014-06-24 13:22:43 +02:00
ff87588d96
Don't let config path seem absolute where it isn't
...
refs #6534
2014-06-24 10:12:07 +02:00
c563479888
Use Icinga\Util\File instead of fopen
2014-06-23 15:02:06 +02:00
9066a0c2fa
Fix deadlock when writing to the command pipe while noone is listening
2014-06-23 15:02:06 +02:00
2862c5667c
Make Icinga\Util\File an object
...
Was a class with just one static function beforehand and is now a fully
object oriented alternative for how files and pipes can be handled.
PHP warnings emitted by fopen, fwrite, fread and chmod are catched
and thrown as exceptions.
2014-06-23 15:02:06 +02:00
010466f8f9
Replace sizeof with count
...
Do not use sizeof to get the length of an array, as the function name 'sizeof'
is misleading
2014-06-23 14:19:55 +02:00
77a9dd1e6e
Throw exception on fetchDN, when no row exists
...
Instead of fetchDN, authentication now uses hasUser to check if the user
exists before querying the password, to prevent the exception from messing
up the whole authentication process
2014-06-23 14:02:45 +02:00
ba9a633b73
Web\Form: relax form submission check
...
We have to live with some badly designed forms right now. Some have
submit buttons but don't know about, others don't have such but link
to foreign controllers fiddling with the form and adding different
button AFTER the form got submitted - it's a mess.
Relaxing the submission check to "just check whether btn_submit has
a value" fixes most of this. However I do not consider this being a
solution for the long run.
fixes #6423
fixes #5967
refs #6540
2014-06-23 13:31:34 +02:00
ea44de8698
ActionController/translate: detect domain only once
2014-06-22 20:09:23 +02:00
23ed744747
params/_render: replace it everywhere
...
Cleaning up controllers and JS, using headers only and respecting
history.
2014-06-22 20:07:44 +02:00
61600ae2d4
ModuleActionController: fix typo
2014-06-22 19:39:54 +02:00
997587d729
Chart\InlinePie: remove ugly default border
2014-06-22 16:38:12 +02:00
216f0f3f55
isIframe: clean up, load less html and js
...
We use isIframe only when we have no JS, therefore it makes no sense
to load JS files in an iFrame. Also removed sidebar.
2014-06-22 16:30:06 +02:00
3b84078b2f
Params/_render: get rid of it, start with iframe
2014-06-22 16:18:23 +02:00
bb23d0636c
ModuleActionController: use isXhr()
2014-06-22 16:04:55 +02:00
3774eb6889
ActionController: add isXhr() method
...
Makes things easier as we use this a lot
2014-06-22 15:36:41 +02:00
331d756a2a
ActionController: isolate ignoreXhrBody
...
This function is only a workaround for broken forms not redirecting
after submission. Will hopefully be removed soon.
2014-06-22 15:33:38 +02:00
b4f8ef74fa
ActionController: remove obsolete code
2014-06-22 15:20:55 +02:00
631603aba3
ActionController: create postDispatchXhr
...
Moved XHR-specific stuff to a dedicated post-dispatch function
2014-06-22 15:17:28 +02:00
cf995b366b
ActionController: cleanup postDispatch
...
Make XHR handling more readable, move module-related stuff to the
module controller
2014-06-22 15:11:08 +02:00
7d6fd45466
Application\Web: use same request everywhere
2014-06-22 14:13:00 +02:00
de19745eb2
ActionController: move moduleInit to Module controller
2014-06-22 13:54:02 +02:00
2cd25b7376
ActionController: if/else should be easy to read
2014-06-22 13:52:40 +02:00
b7fc0b67a8
Web/controllers: use own Request/Response objects
...
* introduces Icinga\Web\Response
* uses ModuleActionController where necessary
* no module translationDomain voodoo in base ActionController
2014-06-22 13:49:21 +02:00
ef5e1b54fd
Web\Window: fix it's usage, add helper function
...
Improved window handling, fixed controllers using it.
2014-06-22 13:21:21 +02:00
b350e3640d
Web\Window: move window handle to dedicated class
...
One more step in cleaning up our ActionController
2014-06-22 13:01:48 +02:00
d69a6d1640
ActionController: remove getRequestUrl
...
Thie removes complexity and makes redirection to login less error-
prone.
2014-06-22 12:23:34 +02:00
9608d8254d
ActionController: remove addModuleContainer
...
This method was obsolete
2014-06-22 12:09:07 +02:00
4980b700da
ActionController: __construct() as first function
2014-06-22 12:07:50 +02:00
a4955df1a9
controller->Auth(): one more lazy-loading helper
...
Not sure about the capital A, but doesn't look so bad - and similar
to Config().
2014-06-22 12:06:09 +02:00
373e1c5ecb
Web\Controller: re-introduce ModuleActionController
...
This will help getting rid of a couple of if/else constructs
2014-06-22 12:03:37 +02:00
469eb3dc98
Web\Url: remove forgotten "debug" line
2014-06-22 11:59:24 +02:00
b3cdeee35d
monitoring/timeline: should benefit from new filter
...
Different changes have been applied:
* Allow integer unix timestamps as parameters for timestamp columns
* Remove alias-rewriting from Url class
* Remove all traces of raw_timestamp
* Use new filters
2014-06-21 03:09:40 +02:00
78193137f0
config/modules: show metadata, improve usability
...
Well... I didn't want to commit this before creating single-button
forms for enabling/disabling modules. However part of this accidentally
made it through, so let's finish it.
Still some work to do, but it already looks far better like this.
refs #4095
2014-06-21 02:27:27 +02:00
216c2ca770
Autorefresh: should work also on initial page load
...
fixes #6296
2014-06-21 01:54:32 +02:00
e2f7a1054e
CSV/JSON export: work with new query interfaces
...
NB: I do not like the fact that we have to do as follows:
DataView->getQuery()->fetchWhatever();
Guess this is worth a few more proxy functions.
2014-06-21 00:09:11 +02:00
c0c7a815f8
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
2014-06-20 19:18:38 +02:00
a904ff51aa
monitoring/eventhistory: improve query performance
...
This takes care of timestamp columns, modifies queries in a way not
depending on db functions, filters are passed through to subqueries
for better performance.
2014-06-20 19:14:34 +02:00
3e24a2cbe4
Paginator/SlidingWithBorder: use less space
...
Showing less items right now. It would be great if we could steer
this by parameter. IMO we should also think about dropping ZF
pagination and use a custom tiny widget.
2014-06-20 17:31:32 +02:00
afd6b11b7b
Web\Url: add set/mergeValues support
2014-06-20 15:50:55 +02:00
2cf79fe9a7
Widget\SortBox: hardcode some styles
...
This is a quickfix, should be moved to CSS once we know how our HTML
elements will definitively look like
2014-06-20 14:55:43 +02:00
916c9c027e
forms: fix isSubmitted
...
Implementation made wrong assumptions. A form is submitted when the
submit button has been pressed. It's value is then filled, it also
is when you're just pressing "RETURN". RETURN triggers the FIRST
submit button in a form. This way we are also able to find out which
form button has been pressed.
Current implementation is still poor, however isSubmitted works as
expected right now - and so does autosubmission.
fixes #5967
2014-06-20 14:32:22 +02:00
01631720cc
Dashboard\Component: don't pass on limit
...
Dashlets might be limited to just a few line, we shoultn't pass on
this parameters when showing the "large" variant
2014-06-20 14:29:45 +02:00
ac7354295a
Accessibiltiy: add alt tag for icons
...
Screen readers to not read title tags per default
2014-06-20 14:28:19 +02:00
27e7839d1b
Widget\Limiter: initial commit
...
This allows one to easily switch row count shown on a single page
2014-06-20 13:48:17 +02:00
07134cf931
JS/XHR: handle multiple notifications
...
As there seems to be problems with sending the same header multiple
times we put multiple notifications in one header.
2014-06-20 13:20:20 +02:00
617741c62f
helpers/widget: options are opional
2014-06-20 13:18:52 +02:00
dbf03ee647
ActionController: refine url handling on redirect
2014-06-20 13:18:03 +02:00
7cad4de3be
ActionController: allow to disable autorefresh
2014-06-20 13:17:11 +02:00
262dcff3a5
Util\Translator: tell us current locale and lang
2014-06-20 13:12:23 +02:00
ecbdb07bea
FilterQueryString: fix handling encoded <> signs
...
Those signs are URL-encoded and therefore not "seen" before decoding
the "key" part when the sit in front of the = sign. Same goes for
standalone ones. Fixed.
2014-06-20 13:06:07 +02:00
f2605b89ff
FilterQueryString: fix parsing expression lists
...
The parser sometimes failed when reaching a=b&b=(c|d|e) - fixed.
2014-06-20 13:04:53 +02:00
1ea15e1f66
FilterQueryString: fix sub-expression parsing
...
In a string like !(b=c)&a=d the parser used to fail once it reached
the &, fixed now.
2014-06-20 13:02:02 +02:00
a3a2e97f18
FilterQueryString: just cleaning up a little bit
2014-06-20 13:01:10 +02:00
4bada86731
Authentication\Manager: fix fromRemoteUser boolean
...
This used to be always true in case an autologin backend was enabled.
We only have a REMOTE_USER if there is such.
2014-06-20 12:58:17 +02:00
559457f730
Bootstrap/timezone: do not enforce config
...
The current way forces people running a correctly configured PHP
to configure timezone once again in Icinga Web. We want LESS config,
so this tries to fix this.
2014-06-20 12:54:37 +02:00
f498cd0c81
Web\Url: small fixes, allow override queryString
2014-06-20 12:41:16 +02:00
d504c27641
timeUntil/timeSince: add timestamp hover title
...
It's sometimes easier to read "full" timestamps.
2014-06-20 12:28:55 +02:00
317094aed3
Widget\FilterWidget: ui cleanup
2014-06-20 12:16:33 +02:00
644dd5e33e
Widget\FilterEditor: improve the filter editor
...
This adds quite a bunch of changes. Part of the filter-modifying
complexity has been moved to the filter, the editor widget itself
now makes use of new filter capabilities such as changing operator
or expression type.
2014-06-20 12:03:22 +02:00
1bfc4058f2
Data\Filter: automagically handle hierarchy
...
This adds a few more functions assisting filters in replacing
themselves or subnodes. Introducing Filter::chain().
2014-06-20 12:00:29 +02:00
18e49f6b9a
Data\Filter: add setters for all properties
...
To keep our filter editor simple we want our filters to handle also
operations replacing themselves.
2014-06-20 11:57:31 +02:00
97f88bf636
Data\Filter: clean up a few things
...
* throw useful exceptions
* our "id" should always be treated as a string
2014-06-20 11:55:27 +02:00
aae49ce0c0
Do not show tooltips for piechart areas that indicate empty or free areas
...
refs #6117
2014-06-18 17:38:25 +02:00
6555d347a7
Escape InlinePie html and adjust chart size
...
fixes #6117
2014-06-18 14:43:14 +02:00
be0c5d4b23
Add more meaningful tooltip labels to InlinePies
...
Show current title, a well-formated value and a label for each area in a
tooltip and add the ability to customize tooltip labels of InlinePies
refs #6117
2014-06-18 14:43:14 +02:00
521cc0cac4
Refactor Ldap and Dns utility functions and conform to coding guidelines
...
refs #6507
2014-06-18 14:38:44 +02:00
21febddad2
Widget\Filter*: rudimentary filter widgets
...
Initial implementation, more to come
2014-06-17 14:00:38 +00:00
54e97f114d
Widget\SortBox: hardcode element width
...
Temporarily added inline CSS, shall be removed soon
2014-06-17 13:54:32 +00:00
d63d8fe451
view/helpers: add $this->widget()
2014-06-17 13:53:05 +00:00
e3e6826d9d
Icinga\Filter: remove
2014-06-17 13:26:57 +00:00
992a8a276b
Web/ActionController: provide $this->params
...
We always need params, this are our new URL params made accessible
this way. This is just for our query string, not for POST body params.
2014-06-17 12:58:04 +00:00
468b290277
Monitoring\Controller: provide $this->backend
...
Every monitoring controller needs $backend, so why declaring it over
and over again. Created "moduleInit" dummy function in our base action
controller to allow such implementations without polluting init().
2014-06-17 12:55:43 +00:00
7cd696b31b
Data/queries: adjust to fit new filters
...
Slight changes to get our queries working with new filter implementation.
2014-06-17 12:34:02 +00:00
d1b2d47fed
Data\Filter: rework fitting new URLs
...
A bunch of things happened here. We distinct FilterChains (or, and,
not) from FilterExpressions (less, greater, equal...). We make use of
our new URL-Parser. We can directly address anonymous filter components
for editing filters. Too much things to explain them in detail, a filter
documentation will follow.
2014-06-17 12:28:28 +00:00
5ea9b2be84
Web\Url: make use of the new UrlParams class
...
This makes a lot of things easier while trying to preserve compatibililty.
However, a few things like aliases are marked for removal (TODO).
2014-06-17 10:07:19 +00:00
de5bb56fb3
Web\UrlParams: new implementation
...
The URL query string parsing done by PHP/ZF doesn't suffice our needs.
This is an implementation preserving filter-related "strange" query
string components while still offering legacy behaviour.
Missing right now: support for [].
2014-06-17 10:00:49 +00:00
7b77083c89
Data\Db\DbConnection: relax timeout, persistance
...
Raised connection timeout, helps when talking to DB servers behind
weak links. Please note that I'm not sure whether this really is a
better default.
While it doesn't matter with local sockets, connection overhead will
have an impact with remote database servers. We have to reconnect with
every single request. Persistent connections seem to be no longer as
errorprone as they used to be, but I'd still refuse to switch them on
by default.
What we need is a config setting for connection persistancy and wizards
strongly suggesting to use this when working with remote db servers.
2014-06-17 09:53:59 +00:00
e056310378
Data\Db\DbConnection: one more legacy class name
...
Fixed, Query is now DbQuery
2014-06-17 09:52:32 +00:00
9e1e502fc8
Data\Db\DbConnection: implement fromResourceName
...
This allows to instantiate DB connections with less code in our
controllers.
2014-06-17 09:51:37 +00:00
d2ccc68214
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
...
Conflicts:
modules/monitoring/application/controllers/ListController.php
2014-06-17 09:47:14 +00:00
25a73ea3a1
Merge branch 'master' into feature/display-documentation-4820
2014-06-13 17:29:41 +02:00
7f6010e1f8
lib/tree: Add PHPDoc to Node's methods
2014-06-13 17:22:43 +02:00
405266e000
Drop Icinga\Util\Process in favour of an upcoming stronger implementation
2014-06-13 11:59:13 +02:00
561616dca0
Add support for multi-value options
...
Makes it possible to supply options multiple times and to supply the
"--" flag to indicate that there are no options anymore to parse
refs #6092
2014-06-13 09:58:50 +02:00
b935cb34fb
Add clicommands to run unit- and style-tests
...
refs #6092
2014-06-13 09:27:27 +02:00
851977cbeb
Revert "Add clicommands to run unit- and style-tests"
...
This reverts commit 0805d73e34
2014-06-13 09:14:22 +02:00
44a7aa6adb
JS/IE8: deliver legacy jQuery for IE8
...
This patch makes IcingaWeb deliver a legacy jQuery version for IE8
as it is no longer supported in jQuery 2.x. JS for IE8 will not be
delivered minified to ease troubleshooting on that buggy platform.
fixes #5866
refs #6417
2014-06-12 17:33:28 +00:00
db73d324de
Autologin: Fix that the backend name must have been `autologin'
...
Before, the code validated the name of the backend instead of the `backend' directive against `autologin'.
2014-06-12 17:05:54 +02:00
0805d73e34
Add clicommands to run unit- and style-tests
...
refs #6092
2014-06-12 16:29:07 +02:00
7d2ee41f42
Autologin: Fix PHPDoc
2014-06-11 15:46:59 +02:00
992ccf4f6d
Autologin: Actually set the username upon authentication
...
Before, when using autologin the username of the authenticated user always was the empty string.
2014-06-11 15:46:59 +02:00
65a2bd41bc
Autologin: Do not use absolute `use'
2014-06-11 15:46:58 +02:00
7215ba4f59
Autologin: Do not require a bogus password in the source code
2014-06-11 15:46:58 +02:00
63fc8eb27e
Autologin: Use REMOTE_USER for authentication
...
It's not safe to rely on PHP_AUTH_USER and PHP_AUTH_TYPE because
PHP cgi handlers (fgcid for example) only set the REMOTE_USER environment variable
and the authentication type for negogiation methods (Kerberos for example) is neither
Basic nor Digest.
We may have to add REDIRECT_REMOTE_USER for authentication for proxy setups.
2014-06-11 15:46:58 +02:00
c09341d77e
Autologin: Do NOT sanitize username
...
I don't know the reason why this was done initially but a username must not be changed.
2014-06-11 15:46:58 +02:00
c42c7977be
Call extended backend health checks when creating ldap authentication backends
...
fixes #6457
2014-06-11 15:09:36 +02:00
6c82cb8988
Check ldap backend health during Authentication
...
Check if authentication is possible during authentication, to generate more
useful error and log messages, in case the backend configuration is wrong
ref #6457
2014-06-11 15:08:05 +02:00
bca166c644
Do not throw an exception when the username does not exist
...
refs #6457
2014-06-11 15:08:05 +02:00
159d765f14
Fix that calling ActionController::translate() throws an exception
...
Translating strings must not throw an exception
even if the given domain is not valid.
fixes #6432
2014-06-11 13:39:22 +02:00
305a025e7a
Detect ldap default naming context
...
Read the entries in the RootDTS of the given ldap server, to discover
its default naming context and capabilities
refs #6097
refs #6096
2014-06-06 18:18:58 +02:00
efe67377a8
Move dns discovery functions into separate class
...
Add functions to lookup and reverse-lookup domain names and move the ldap
discovery function into a separate class
refs #6093
2014-06-06 17:49:55 +02:00
953d22244a
Add host discovery to authentication page
...
Find all domains for a given hostname.
refs #6093
Conflicts:
application/forms/Install/AuthenticationPage.php
2014-06-06 17:49:55 +02:00
06296f29d8
UI/Sparklines: Change sparkline code to serverside only
...
fixes #6124
2014-06-06 16:35:33 +02:00
160a75403d
Merge branch 'master' into feature/display-documentation-4820
...
Conflicts:
modules/doc/library/Doc/DocParser.php
2014-06-06 14:25:13 +02:00
6c8d35c667
lib: Add a not yet customizable node renderer
2014-06-06 13:58:40 +02:00
ce0aee5e41
lib: Add Data/Tree/Node.php
2014-06-06 13:58:14 +02:00
d84532d593
lib: Remove TreeIterator
...
Nodes implementing the NodeInterface (which extends the RecursiveIterator interface)
are already iterable.
2014-06-06 13:57:18 +02:00
794ae141fa
lib: Let NodeInterface extend RecursiveIterator
...
Since a node may have children and they should be iterable, the Nodefinterface
now extends RecursiveIterator.
2014-06-06 13:55:58 +02:00
e01629fe0b
ActionController: fix initial redirect
...
refs #6419
2014-06-06 08:32:21 +00:00
1e9bc6c7d4
Data\PivotTable: should work with new queries
...
There is still some work to do be done here. And we should/could
rethink columns() VS getColumns().
2014-06-06 06:47:49 +00:00
db3accc704
Data\Db: rename Query and Connection to Db...
...
Class names in namespaces should not be chosen as once we didn't have
such. The fact that we already did "use Db\Connection as DbConnection"
is the best hint that naming was wrong.
So this patch renames Db\Connection to Db\DbConnection and does the
same with DbQuery. DbQuery has been adjusted to fit our new SimpleQuery
and to handle the new Filter implementation.
2014-06-06 06:43:13 +00:00
1fbca25d99
Data\DataArray: use SimpleQuery and new interfaces
...
Removed ArrayQuery implementation as SimpleQuery is enough here.
Renamed the Datasource class to ArrayDatasource.
refs #6418
2014-06-06 06:21:35 +00:00
31047e8082
Data\SimpleQuery: concrete implementation
...
SimpleQuery is no longer abstract, implements the Filterable interface
and should now be usable as a basic Query implemenation as is.
2014-06-06 06:12:17 +00:00
85605597cc
Data/interfaces: add Filterable, extend Connection
...
New interface ConnectionInterface attempts to aggregate things.
Extended Filterable interface, added Filter-related functions. Please
note that apply will probably get dropped later on, I'll keep it for
compatibility reasons right now.
refs #6418
2014-06-06 06:07:33 +00:00
f438cb30e1
Data\Filter: initial commit basic implementation
...
Basic operators are there, still missing: subclassed "where" to distinct
comparison operators like greater/less than on a class level.
refs #6418
2014-06-06 06:04:24 +00:00
d44a87717d
Data\SimpleQuery: implement column handling
...
We want SimpleQuery to be able to run standalone
2014-06-06 05:49:39 +00:00
4b8e09b12a
Data\SimpleQuery: get front controller without ZF
2014-06-06 05:48:29 +00:00
bfe6a1593a
Merge remote-tracking branch 'origin/master' into feature/query-interfaces-6018
2014-06-06 05:32:54 +00:00
20b43a92f1
Dashboard: Better implementation of handling errors
...
refs #6412
2014-06-05 16:07:40 +02:00
151f058286
Dashboard: Display error message on failure
...
When no (default) configuration is available for dashboards
application dies not very gracefully. Display error message
and guid the user to the solution is a better way.
fixes #6412
2014-06-05 15:20:54 +02:00
1b3bb6cade
Web\Url: add getQueryString() and without()
2014-06-05 03:44:12 +00:00
99aae5a0d9
JS/XHR: get ready to get XHR redirect-aware
...
These are just the first steps, there is more to come
2014-06-05 03:37:36 +00:00
1ebab3e5c1
vendor/lessphp: we don't need travis.yml right now
2014-06-05 00:15:31 +00:00
c592236258
vendorlibs: library/vendor to libary/IcingaVendor
...
This doesn't make it much better but allows to build a package
libicinga-vendor-php placing those files to /usr/share/php/IcingaVendor
or similar.
refs #4075
2014-06-05 00:10:49 +00:00
8df26bb5f5
bootstrapping: add a dispatchModule() shortcut
...
This allows to easily jump into a specific modules CLI controllers.
refs #6411
2014-06-04 23:39:12 +00:00
4202e34d13
bootstrapping: play nice with duplicate modules
...
A module loaded manually could also exist in the list of enabled
modules if a configuration is given and a module with the same name
has been enabled. This used to confuse documentation.
2014-06-04 23:37:36 +00:00
bdcec5a253
Cli\Loader: allow injecting a module name
...
This helps those who prefer to create their own executables instead
of creating icingacli subcommands.
refs #6411
2014-06-04 23:04:11 +00:00
eadb6cb518
bootstrapping: allow to retrieve a modules base...
...
...directory if it has been loaded but neither enabled nor installed.
refs #6411
2014-06-04 22:59:48 +00:00
0e6aecbd43
bootstrapping: allow to load modules neither...
...
...enabled nor installed by passing their base directory. In favour
of this parameter I dropped the possibility to inject a Module class
for testing purposes. There is no such test and I see no point in
doing so.
refs #6411
2014-06-04 22:57:50 +00:00
e076d2d1d6
bootstrapping: create only one CLI loader instance
...
This used to work fine as long as you didn't try to interfere from
outside to influence the cli loader. The instance returned by
cliLoader() was not the same as used internally once dispatching the
CLI command.
refs #6411
2014-06-04 22:52:38 +00:00
a221afd933
bootstrapping: autoloader exceptions should not...
...
...require to be autoloaded.
refs #6411
2014-06-04 22:50:08 +00:00
602b448505
bootstrapping: only web should depend on forms
...
This fixes the problem that CLI scripts or other applications without
an application directory would badly fail because of missing web forms.
refs #6411
2014-06-04 22:46:16 +00:00
bdc3423d4e
packaging/config: allow to override APPDIR
...
It is now possible to either define ICINGAWEB_APPDIR in an Environment
variable or to define it as a PHP constant before bootstrapping.
fixes #6400
2014-06-04 21:22:29 +00:00
55880cb5a3
packaging/config: rename ICINGA_APPDIR
...
Renamed ICINGA_APPDIR to ICINGAWEB_APPDIR for consistency. This way
it fits ICINGAWEB_CONFIGDIR.
refs #6400
2014-06-04 21:11:27 +00:00
e992f152bb
packaging/configuration: get rid of _ENV
...
We should use _SERVER for our settings as it works fine on CLI and
for web servers.
refs #6400
2014-06-04 21:08:49 +00:00
29f593a357
Authentication: Add backend to handle external authentication
...
Drop external auth configuration from config.ini and move
implementation into a single backend provider named
'autologin'. This provider can strip realm names from
username with a custom regexp.
fixes #6081
2014-06-03 17:59:22 +02:00
a0459d0172
ExternalAuthentication: Move authenticationMode to config.ini
...
fixes #6214
2014-06-03 15:26:15 +02:00
160a95e32d
Bootstrap/Web: Only load authentication.ini if needed
...
fixes #6238
2014-06-03 14:16:01 +02:00
cfcaf019bd
User backends: Throw exception when authentication fails due to an exception
...
refs #5685
2014-06-02 15:52:58 +02:00
2274b6e11e
lib: Add phpdoc to class `AuthChain'
...
refs #5685
2014-06-02 15:46:15 +02:00
79fb8b1e0d
Config: Remove base path subsitution
...
Test for leading slash and prepend base path to allow
absolute configuration files.
fixes #5556
2014-06-02 14:54:31 +02:00
5559cf6c2b
lib: Add AuthenticationException for exceptions thrown during authentication
...
Our user backends log exceptions thrown during authentication but they don't throw
a exception to inform the caller that an error occured. The new `AuthenticationException'
class should be thrown in that case.
2014-06-02 14:07:59 +02:00
a379502b15
Preferences: Rename `showBenchmark' to `show_benchmark'
...
We use underscore_case notation for all configuration keys.
refs #4952
2014-06-02 13:33:55 +02:00
50e01d1284
Config: Rename `configPath' to `config_path'
...
We use underscore_case notation for all configuration keys.
refs #4952
2014-06-02 12:09:16 +02:00
1619d682c7
vendor: Remove executeable bit from a read me file of HTMLPurifier
...
refs #5982
2014-06-02 10:45:30 +02:00
5cc69b53cf
Remove superfluous space in prefixedTimeSince
...
refs #5981
2014-05-29 13:11:01 +02:00
a66a1a4729
Refactor the timeSincePrefix and timeUntilPrefix functions
...
Instead of having two separate functions to get the prefix
and the formatted time interval the new functions return
both the prefix and the time interval.
refs #5981
2014-05-29 13:03:10 +02:00
7b0a48bef5
Rename timeUnless to timeUntil
...
refs #5981
2014-05-29 12:38:59 +02:00
d01a98b7e6
Fix some of the time-related grammar mistakes
...
This updates some of the messages to use "For"
instead of "Since" where appropriate.
fixes #5981
2014-05-29 11:30:08 +02:00
88460189cd
Encoding: no ASCII chars > 127 in HTTP headers
...
Had quite some trouble with this, decided to URL-encode titles and
notifications.
2014-05-28 21:34:36 +00:00
9edaaa82e8
lib: Add TreeIterator
2014-05-28 17:14:33 +02:00
040473f986
lib: Add NodeInterface
2014-05-28 17:13:42 +02:00
c12c4a9e4c
Modules: Call `Module::registerWebIntegration()' after including the run script
...
Routes added via a module's run script were not respected since
`Module::registerRoutes()' is called from `Module::registerWebIntegration()'.
refs #6303
2014-05-28 13:29:02 +02:00
Alexander Klimov
Thomas Gelf
Johannes Meyer
Matthias Jentsch
Eric Lippmann
Matthias Jentsch
Marius Hein
Gunnar Beutner